searching for reviewer(mats)
2edcae33cd6a9755aee477a868ccd4dff299eb35: Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats a=jcristau
Martin Stransky <stransky@redhat.com> - Mon, 10 Jun 2019 09:43:27 +0000 - rev 533939
Push 11470 by archaeopteryx@coole-files.de at Tue, 18 Jun 2019 22:45:51 +0000
Bug 1555565 - Export correct user's preference for dark theme by prefers-color-scheme media query, r=mats a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D33133
17b33cebec207345fbd4408eee75f8b6af239c42: Bug 1539366 - Avoid calling AreOnSameLine once we know we've already changed lines since it can be expensive to compute. r=mats a=jcristau
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 27 May 2019 20:38:46 +0000 - rev 533638
Push 11381 by archaeopteryx@coole-files.de at Wed, 05 Jun 2019 18:22:40 +0000
Bug 1539366 - Avoid calling AreOnSameLine once we know we've already changed lines since it can be expensive to compute. r=mats a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D26650
43f54f4b1e2aa7cc51a8dc003951672f12bcc89e: Bug 1539366 - Use a temporary object to compute the mPIStartBorderData coords so that we don't clobber the regular state. r=mats a=jcristau
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 27 May 2019 20:38:26 +0000 - rev 533637
Push 11381 by archaeopteryx@coole-files.de at Wed, 05 Jun 2019 18:22:40 +0000
Bug 1539366 - Use a temporary object to compute the mPIStartBorderData coords so that we don't clobber the regular state. r=mats a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D26649
d2388f832a7d352a8e97b1474518521b1e3c6523: Bug 1539366 - Use SetCoord to restore mPIStartBorderData's coord so that it also set mValid. r=mats a=jcristau
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 27 May 2019 20:38:11 +0000 - rev 533636
Push 11381 by archaeopteryx@coole-files.de at Wed, 05 Jun 2019 18:22:40 +0000
Bug 1539366 - Use SetCoord to restore mPIStartBorderData's coord so that it also set mValid. r=mats a=jcristau Without this the restore doesn't have any effect as the next frame sees that coord has mIsValid=false Differential Revision: https://phabricator.services.mozilla.com/D26648
b08f23a595db9c6e00f3effd3cb329d8ca69780f: Bug 1549812 - ScrollFrameRectIntoView should handle the frame going away. r=mats a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 May 2019 16:33:26 +0000 - rev 533404
Push 11309 by archaeopteryx@coole-files.de at Fri, 24 May 2019 21:38:50 +0000
Bug 1549812 - ScrollFrameRectIntoView should handle the frame going away. r=mats a=jcristau ScrollToShowRect already considers that possibility, so not doing it on the caller is a bug. Ideally scroll observers shouldn't be able to run script, more to that in a second. Differential Revision: https://phabricator.services.mozilla.com/D31088
7b115f2442480ee934e4dc7a9ec113b3d04c6367: Bug 1552719 - Make nsBulletFrame::Ordinal() O(1) again. r=mats a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 17:30:42 +0000 - rev 533334
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 1552719 - Make nsBulletFrame::Ordinal() O(1) again. r=mats a=jcristau I did this instead of just (ab)using the fact that every list item has at least one counter-increment node because: * I don't have the bullet frame around by the time we initially compute the counter increment, which means that I'd need to grow nsBlockFrame / add a frame property for the list item ordinal, which I think would be unfortunate. * It feels more consistent with the way regular CSS counters work and with the way we want ::marker to eventually work. Differential Revision: https://phabricator.services.mozilla.com/D31990
f3b0d67c8f66addf421324d6d237e21064ff56a5: Bug 1552719 - Make nsGenConList::NodeAfter handle correctly nested pseudo-elements. r=mats a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 17:29:26 +0000 - rev 533333
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 1552719 - Make nsGenConList::NodeAfter handle correctly nested pseudo-elements. r=mats a=jcristau When you have a ::after::marker, and you compare one against the other we ended up with the wrong result because of the pseudotype stuff. I think this is cleaner now that DoCompareTreePosition handles pseudos properly (which is really the thing this was working around). Differential Revision: https://phabricator.services.mozilla.com/D31989
438492603ace6b0739168979fff3a2fb039db111: Bug 1552719 - Make nsLayoutUtils::DoCompareTreePosition handle pseudos more diligently. r=mats a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 May 2019 17:29:17 +0000 - rev 533332
Push 11295 by ccoroiu@mozilla.com at Thu, 23 May 2019 11:54:32 +0000
Bug 1552719 - Make nsLayoutUtils::DoCompareTreePosition handle pseudos more diligently. r=mats a=jcristau I'm going to need it to fix the counters code in presence of nested pseudo-elements. Differential Revision: https://phabricator.services.mozilla.com/D31988
00afc705d4eef04a1d71cea44953d0ba232a3794: Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 May 2019 13:22:39 +0000 - rev 533162
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1549812 - Try to assert a bit harder about stuff not flushing under our nose. r=TYLin,mats I think these should hold, everything that runs under them should just schedule other stuff to some later date: * Synth mouse events -> scheduled as refresh driver observers. * Scroll events -> Scheduled as well. * Caret state change events -> Also scheduled after last patch. * IME and accessibility stuff -> I don't think they can reenter layout. We can always revert this if it causes troubles, plus it shouldn't crash on release so should be fine. Differential Revision: https://phabricator.services.mozilla.com/D31090
ac4a070f110542b267763a0544a6e13912170d8c: Bug 1549812 - ScrollFrameRectIntoView should handle the frame going away. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 14 May 2019 16:03:18 +0000 - rev 533160
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1549812 - ScrollFrameRectIntoView should handle the frame going away. r=mats ScrollToShowRect already considers that possibility, so not doing it on the caller is a bug. Ideally scroll observers shouldn't be able to run script, more to that in a second. Differential Revision: https://phabricator.services.mozilla.com/D31088
9d6897b968f6cd1b1cf525f19a45843907a157e9: Bug 1551389 - Compare line lists as well as lines when deciding if two frames are on the same line. r=mats
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 14 May 2019 22:26:17 +0000 - rev 532699
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1551389 - Compare line lists as well as lines when deciding if two frames are on the same line. r=mats Differential Revision: https://phabricator.services.mozilla.com/D31152
a811c910cfd3527d20556d09fca7dafc4003bc4d: Bug 1550532 - Avoid auto-hyphenating capitalized words, except for German. r=emilio,mats
Jonathan Kew <jkew@mozilla.com> - Mon, 13 May 2019 16:35:44 +0000 - rev 532453
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1550532 - Avoid auto-hyphenating capitalized words, except for German. r=emilio,mats This affects a number of our existing reftests, so we'll need to update those to not expect auto-hyphenation of a sentence-initial (capitalized) word. (Hyphenation behavior is not sufficiently well-specified for this to be tested at the WPT level, so we just use Gecko-specific reftests.) Differential Revision: https://phabricator.services.mozilla.com/D30912
d51f3432e142ef24333b125087f5fccc2fbc366a: Bug 1527392 - Do not clamp computed width and height by min-/max- values. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 11 May 2019 18:01:50 +0000 - rev 532360
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1527392 - Do not clamp computed width and height by min-/max- values. r=mats The spec says that when there's no box or the property doesn't apply, the computed value should be returned. That's not what we're doing right now, we're clamping by min-/max- values, which is wrong. This patch makes us match other engines and the spec, and it's an attempt to get interop on resolved values in: https://github.com/w3c/csswg-drafts/issues/3678 WebKit fails the WPT test, but due to a different reason: https://bugs.webkit.org/show_bug.cgi?id=197814 Differential Revision: https://phabricator.services.mozilla.com/D30780
c2250a23fd66e3c812cb023c2d12f6f5e8d5a2f2: Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 09 May 2019 02:32:30 +0000 - rev 531981
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert Differential Revision: https://phabricator.services.mozilla.com/D20115
10e1808b667554314618e4b9dc8c33e8a930ed9b: Bug 1548809 - Don't paint outlines for empty fragments of IB-splits. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 May 2019 13:31:34 +0000 - rev 531310
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548809 - Don't paint outlines for empty fragments of IB-splits. r=mats Added a test to test the empty block (didn't submit to WPT because it's not clear to me if the outlines of the two spans should form a single rect or not). Differential Revision: https://phabricator.services.mozilla.com/D29819
8c89fd37b79d353a6eb8794f3de11151f6924b26: Bug 1544242 - Fix selector-matching for nested pseudo-elements. r=heycam,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 May 2019 17:19:08 +0000 - rev 530952
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544242 - Fix selector-matching for nested pseudo-elements. r=heycam,mats We always include the combinator for pseudo-elements now (not including it was just an optimization) in order to not match when nested pseudo-elements are involved. We could add a more generic check in `matches_simple_selector` like: ``` if element.is_pseudo_element() { match *selector { Component::PseudoElement(..) | Component::NonTSPseudoClass(..) => {}, _ => return false, } } ``` But even that wouldn't be enough to make selectors like `:hover::marker` not match on the `::before::marker` pseudo-element, plus that code is really hot. So for now do the check on the `next_element_for_combinator` function. It's a bit hacky but it's the best I could came up with... While at it, simplify some checks to use is_pseudo_element() instead of implemented_pseudo_element() directly. Only the Rust patch as-is would make markers for ::before and ::after on list items not show up, so we also need to switch ::marker to use ProbeMarkerStyle() rather than ProbePseudoElementStyle(), since the marker should exist even if it matches no rules. Differential Revision: https://phabricator.services.mozilla.com/D27529
5e3c456acd732fc8ed215869c1d683a0e3e4a2b5: Bug 1547985 - Use rust types for vertical-align. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 May 2019 13:08:34 +0000 - rev 530926
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547985 - Use rust types for vertical-align. r=mats The previous commit removed the dependence on the discriminant value, so we don't need to keep discriminants different from text-align anymore. Differential Revision: https://phabricator.services.mozilla.com/D29361
40c62969bc70c14de88b144b011098a3f369ed5c: Bug 1547985 - Stop parsing the legend align's top and bottom attributes. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 May 2019 12:12:52 +0000 - rev 530925
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547985 - Stop parsing the legend align's top and bottom attributes. r=mats They do nothing, if they get parsed, they end up doing the same as text-align: start, which is the same that we'd get out of GetLogicalAlign if the attribute wasn't parsed in the first place. We don't use this attribute for anything else like attribute mapping, so this should be an idempotent patch. Differential Revision: https://phabricator.services.mozilla.com/D29360
08d39c306ffbbb2d5f9cb645e3a4103f2656aaa9: Bug 1440537 - Fix test_media_queries to not rely on flushing across docgroup boundaries. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 20 Apr 2019 18:46:21 +0200 - rev 530460
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1440537 - Fix test_media_queries to not rely on flushing across docgroup boundaries. r=mats Just make the iframe to test cloning same-origin using srcdoc, instead of using SpecialPowers to access cross-origin objects. Differential Revision: https://phabricator.services.mozilla.com/D28301
c08ca0ff0c98cdec6f6a70bdd9e7c610e5e39f95: Bug 1545699 - Remove a dead Loader::LoadSheet function. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 17:09:40 +0200 - rev 530113
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545699 - Remove a dead Loader::LoadSheet function. r=mats Differential Revision: https://phabricator.services.mozilla.com/D28213
593761a810cea50aebb2b9a423af791c773c10ac: Bug 1545707 - Dispatch cancel events for transitions/animations canceled on ::marker pseudo elements when the become no longer rendered; r=mats
Brian Birtles <birtles@gmail.com> - Mon, 22 Apr 2019 00:54:29 +0000 - rev 529141
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545707 - Dispatch cancel events for transitions/animations canceled on ::marker pseudo elements when the become no longer rendered; r=mats Differential Revision: https://phabricator.services.mozilla.com/D28176
bc8f94bb6bb6dad3f71b1ac955f1d89643548013: Bug 1545707 - Add tests for animation of ::marker pseudo-elements; r=mats
Brian Birtles <birtles@gmail.com> - Mon, 22 Apr 2019 00:54:09 +0000 - rev 529140
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545707 - Add tests for animation of ::marker pseudo-elements; r=mats In particular, this tests the composite order of ::marker pseudo-elements and dispatching cancel events for these elements. It adds one test that is known to fail in Gecko. This will be fixed in the next patch in this series. Differential Revision: https://phabricator.services.mozilla.com/D28175
60b2b50f00a7f7167ce645815cb0cd566c778e5b: Bug 1545328 Part 7 - Fix a typo in FindBestBalanceBSize(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:43:16 +0000 - rev 529049
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 7 - Fix a typo in FindBestBalanceBSize(). r=mats Differential Revision: https://phabricator.services.mozilla.com/D28157
4120cfae19360bed0f96dde2e6dbb8423f9f35d8: Bug 1545328 Part 6 - Mark some nsColumnSetFrame methods "const". r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:43:14 +0000 - rev 529048
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 6 - Mark some nsColumnSetFrame methods "const". r=mats Also, move GetAvailableContentBSize() to non-public section because it's only used by nsColumnSetFrame. Differential Revision: https://phabricator.services.mozilla.com/D28014
93a076c63319f8ef6225948ffb851dec6bbf08f9: Bug 1545328 Part 5 - Move "feasible" result into ColumnBalanceData, and make reflow methods return ColumnBalanceData. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:43:04 +0000 - rev 529047
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 5 - Move "feasible" result into ColumnBalanceData, and make reflow methods return ColumnBalanceData. r=mats ColumnBalanceData is reset in the beginning of ReflowChildren(), so I make ReflowChildren() return a fresh ColumnBalanceData so that it's easier (at least for me) to understand the data is recomputed in every reflow iteration. Also, FindBestBalanceBSize() uses ColumnBalanceData as an input to begin its column balancing iteration. Make the argument pass by value so that the caller's copy won't be modified. Differential Revision: https://phabricator.services.mozilla.com/D28013
31d11b8fca065f1c471fe0f681a3ea7b4b7b1ad4: Bug 1545328 Part 4 - Replace "height" with "block-size" in comments. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:43:00 +0000 - rev 529046
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 4 - Replace "height" with "block-size" in comments. r=mats I manually search "height" and replace it with "block-size" if the code around it uses logical coordinates. Differential Revision: https://phabricator.services.mozilla.com/D28012
d4cf957cb4d3131a18357f1faa9a6b7686a14f35: Bug 1545328 Part 3 - Stop exposing ClampUsedColumnWidth() in the header. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:42:56 +0000 - rev 529045
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 3 - Stop exposing ClampUsedColumnWidth() in the header. r=mats The static function is used only in nsColumnSetFrame's implementation. Differential Revision: https://phabricator.services.mozilla.com/D28011
ba82a40db6755a8c488d445872894a48df0190c9: Bug 1545328 Part 2 - Remove "virtual" keywords for methods that already have "override". r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 05:42:46 +0000 - rev 529044
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 2 - Remove "virtual" keywords for methods that already have "override". r=mats Differential Revision: https://phabricator.services.mozilla.com/D28010
7ccd0940d635e77d744d40d0a50ae78fcdb2a59f: Bug 1545328 Part 1 - Change two FindBestBalanceBSize()'s arguments to be passed by value. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Apr 2019 06:43:56 +0000 - rev 529043
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545328 Part 1 - Change two FindBestBalanceBSize()'s arguments to be passed by value. r=mats No code after FindBestBalanceBSize() is interested in aUnboundedLastColumn and aRunWasFeasible, so they don't need to be input/output arguments. Differential Revision: https://phabricator.services.mozilla.com/D28009
1bb7a184f2c8ff71dac4b1a54984826a0138c606: Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Apr 2019 04:41:17 +0000 - rev 528988
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats Now that they're not exposed to the web we can remove this special case. Differential Revision: https://phabricator.services.mozilla.com/D28071
08e2094f4b6b96b860a023c00c470665d53ce45d: Bug 1545558 - remove unnecessary text from divs from orthoganal-float test cases r=mats
Joel Maher <jmaher@mozilla.com> - Thu, 18 Apr 2019 21:05:09 +0000 - rev 528958
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545558 - remove unnecessary text from divs from orthoganal-float test cases r=mats remove unnecessary text from divs in orthogonal-float test cases Differential Revision: https://phabricator.services.mozilla.com/D28126
24d0d307385d2cf5ce66854e40b92d7b15dc8428: Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Apr 2019 15:20:34 +0000 - rev 528908
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats Now that they're not exposed to the web we can remove this special case. Differential Revision: https://phabricator.services.mozilla.com/D28071
3654d1720dab4da995c74f75e2c4750b6db03d52: Bug 1543672 - The counters code should use atoms rather than strings. r=mats,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Apr 2019 20:11:45 +0000 - rev 528377
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543672 - The counters code should use atoms rather than strings. r=mats,boris Servo already atomizes the counter names, it makes no sense to copy the string rather than bumping the refcount. Differential Revision: https://phabricator.services.mozilla.com/D27061
e4d51df238b69028b2cc7511efcea9bfe5f777a6: Bug 1543758 - Pseudo-elements should be allowed to be list-items. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 13 Apr 2019 22:22:51 +0000 - rev 528240
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543758 - Pseudo-elements should be allowed to be list-items. r=mats Per https://github.com/w3c/csswg-drafts/issues/3766 Differential Revision: https://phabricator.services.mozilla.com/D27122
78ed7f9d65666d570e1a87195c1ab5434d588fb8: Bug 1542530 - Selection.toString() works correctly when text is selected together with a set of div+svg elements, r=mats
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 11 Apr 2019 14:13:24 +0000 - rev 527833
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542530 - Selection.toString() works correctly when text is selected together with a set of div+svg elements, r=mats Differential Revision: https://phabricator.services.mozilla.com/D27064
4ec02d2be99e933a9599075f4e45c25687744111: Bug 1539171 - Make the list-item increment not visible from the computed style. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Apr 2019 15:21:17 +0000 - rev 527830
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539171 - Make the list-item increment not visible from the computed style. r=mats This is per https://drafts.csswg.org/css-lists/#declaring-a-list-item. I intentionally kept <li value> defined using attribute mapping, I think that's saner than special-casing it in layout. Differential Revision: https://phabricator.services.mozilla.com/D24935
441551c28fbf1decc68fcbafd9676c3ab62932f1: Bug 1543401 - Use rust lengths for row-gap / column-gap. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Apr 2019 16:00:03 +0000 - rev 527724
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543401 - Use rust lengths for row-gap / column-gap. r=mats Differential Revision: https://phabricator.services.mozilla.com/D26915
399822369a16cd4eb5ad06f644aeb25db88eecd0: Bug 1543161 - Simplify some rules used for file inputs. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Apr 2019 18:05:18 +0200 - rev 527701
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543161 - Simplify some rules used for file inputs. r=mats There's only one button in a file input. This used to be an input[type="button"]. There's no point in using more specific rules or such, the regular UA rules just work, and content can't style this button so it can't be overriden. This should be an idempotent patch. Differential Revision: https://phabricator.services.mozilla.com/D26753
34c20181c54f0e53d1f042a5e1a97d7b87b357bc: Bug 1541668 - Make nsTextFrame::GetRenderedText ignore full-width and full-size-kana transforms. r=Jamie,mats
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Apr 2019 14:44:43 +0000 - rev 526991
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541668 - Make nsTextFrame::GetRenderedText ignore full-width and full-size-kana transforms. r=Jamie,mats Differential Revision: https://phabricator.services.mozilla.com/D26146
14fdab21409c395f87570c85482011945c7c7651: Bug 1533554 - check for integer overflow; r=mats
Alex Gaynor <agaynor@mozilla.com> - Mon, 25 Mar 2019 17:02:11 +0000 - rev 526407
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533554 - check for integer overflow; r=mats Differential Revision: https://phabricator.services.mozilla.com/D22770
83ef6d9515c9bd1e68c8fb8dfc17f3c7ada7ced3: Bug 1517080 Part 6 - Remove nsFrameItems alias, and rename variables with suffix "Items" to "List". r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 04:45:47 +0000 - rev 525754
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 6 - Remove nsFrameItems alias, and rename variables with suffix "Items" to "List". r=mats Differential Revision: https://phabricator.services.mozilla.com/D15556
ede8668de94c4742c4a84f1616f2f4aa56f8dbc7: Bug 1517080 Part 5 - Rename nsAbsoluteItems to mozilla::AbsoluteFrameList. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 04:45:40 +0000 - rev 525753
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 5 - Rename nsAbsoluteItems to mozilla::AbsoluteFrameList. r=mats Also, rename variables that have suffix "Items" to "List". Differential Revision: https://phabricator.services.mozilla.com/D15555
7d5192894473d8494d17c9be951ef06c9c88d62a: Bug 1517080 Part 4 - Make nsFrameItems an alias of nFrameList, and remove nsFrameItems. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 03:25:10 +0000 - rev 525752
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 4 - Make nsFrameItems an alias of nFrameList, and remove nsFrameItems. r=mats nsFrameItems will be removed in Part 6. Differential Revision: https://phabricator.services.mozilla.com/D15554
c838c81514b31ca561dcd4b89703b150b3ed6f7c: Bug 1517080 Part 3 - Replace remaining nsFrameItem::Add() with nsFrameList::AppendFrame(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 03:31:21 +0000 - rev 525751
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 3 - Replace remaining nsFrameItem::Add() with nsFrameList::AppendFrame(). r=mats This patch is a mechanical replacement without any reparent, i.e. passing nullptr as parent into nsFrameList::AppendFrame(). Differential Revision: https://phabricator.services.mozilla.com/D25337
2721d70f1b6a6d8d6809751ddc2bb719dff6268d: Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:56:27 +0000 - rev 525750
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 2 - Replace nsFrameItems::AddChild() with nsFrameList::AppendFrame() in FinishBuildingScrollFrame(). r=mats Differential Revision: https://phabricator.services.mozilla.com/D25336
ae2fe9b13897d3ca5438f7aeff718640a1b2a426: Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Sat, 30 Mar 2019 02:59:25 +0000 - rev 525749
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1517080 Part 1 - Do not adjust table captions' parent when they're created. r=mats In order to get rid of nsFrameItems::AddChild() and use nsFrameList::AppendFrame() instead, we need to keep table captions' parent to be nsTableFrame when they're created (no adjust in ConstructFramesFromItem) so that their parent remain the same as other frames in the table when appending into the temporary aFrameItems. We then adjust captions' parent right before we call SetInitialChildList()/AppendFrames/InsertFrames(). Also, pass nullptr to AppendFrames() in nsTableWrapperFrame::AppendFrames() because callers should already set captions' parent frame properly. No need to reparent them again. Differential Revision: https://phabricator.services.mozilla.com/D25335
46ad671b9fafbabad163c8e6b7d7bc752d142f1b: Bug 1540093 - Unship line-height: -moz-block-height. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Mar 2019 11:11:27 +0000 - rev 525561
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540093 - Unship line-height: -moz-block-height. r=mats They're only used in forms.css, and only for some anonymous content, which are not content-accessible in the first place. The only place where this could be exposed is calling getComputedStyle(input, "::placeholder"), so I think this should be pretty safe, but I've added a pref just in case. While at it, also derive the Parse implementation. Less code is better. Differential Revision: https://phabricator.services.mozilla.com/D25118
7077ebbd4677cabc478006b26dbf7cc6ac9bd0dc: Bug 1540093 - Refactor some enabledness checks. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Mar 2019 11:12:12 +0000 - rev 525560
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540093 - Refactor some enabledness checks. r=mats There are some common checks that could get some easy-to-use aliases. Differential Revision: https://phabricator.services.mozilla.com/D25117
52bda46586ef992fcae3483089f3358f0953b029: Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Mar 2019 13:50:13 +0000 - rev 525390
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats Differential Revision: https://phabricator.services.mozilla.com/D24888
1803e27751d646abe24ff364147c64bfe55920b4: Bug 1539267 - Bug 1539171 - Follow the list-item definition from the spec a bit more closely. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Mar 2019 15:03:20 +0000 - rev 525196
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539267 - Bug 1539171 - Follow the list-item definition from the spec a bit more closely. r=mats The HTML restriction doesn't match any browser. This matches Edge, though I filed https://github.com/w3c/csswg-drafts/issues/3766 about the pseudo-element condition. Differential Revision: https://phabricator.services.mozilla.com/D24936