searching for reviewer(marcoz)
a423e8a5526660b0b84c79d9c7b13a0d1987eaff: Bug 1429442 - Buttons in "type control" popup in reader mode should have tooltips r=Gijs,MarcoZ
monikamaheshwari <monikamaheshwari1996@gmail.com> - Mon, 11 Mar 2019 11:47:49 +0000 - rev 521337
Push 10866 by nerli@mozilla.com at Tue, 12 Mar 2019 18:59:09 +0000
Bug 1429442 - Buttons in "type control" popup in reader mode should have tooltips r=Gijs,MarcoZ Added tooltips in type control for accessibility Differential Revision: https://phabricator.services.mozilla.com/D22679
546397372dd75a335d91268a5b5b539f17f266d9: Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Fri, 08 Mar 2019 07:55:13 +0000 - rev 521005
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531346 - Check for cyclical relationship with aria-activedescendant. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D22633
618b155f9f0ced0837981acecc19ff3514235263: Bug 1529407: Correct MSAA accValue and accRole for role="document". r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 21 Feb 2019 06:48:02 +0000 - rev 518101
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1529407: Correct MSAA accValue and accRole for role="document". r=MarcoZ 1. When role="document" is (redundantly) used on the body element, still expose the URL via accValue, just like we do for role="application". 2. Expose ROLE_SYSTEM_DOCUMENT for role="document" (rather than the string "document") as per the spec. (Chrome already does this, so I don't expect backwards compat problems with clients.) Differential Revision: https://phabricator.services.mozilla.com/D20582
01bc5a0dc801885894b7ce17e0bdbaf73b87c020: Bug 1527254 - Don't rely on tabpanels xul element in Android for offcreen state. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Thu, 14 Feb 2019 08:01:36 +0000 - rev 516890
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527254 - Don't rely on tabpanels xul element in Android for offcreen state. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D19710
af2e994137272f66289200e776063da970c7b3e3: Bug 1511398 - Don't append null proxies to batch list. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Tue, 29 Jan 2019 04:30:41 +0000 - rev 513662
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1511398 - Don't append null proxies to batch list. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D17845
311d09aeb1ab0e1ee583123634a4b28975172969: Bug 1521438: Correct IAccessible::get_accSelection implementation for no selection and single selection. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 21 Jan 2019 07:21:01 +0000 - rev 511785
Push 10563 by archaeopteryx@coole-files.de at Thu, 24 Jan 2019 17:31:37 +0000
Bug 1521438: Correct IAccessible::get_accSelection implementation for no selection and single selection. r=MarcoZ Previously, we were always returning VT_UNKNOWN and an IEnumVARIANT. According to the IAccessible documentation, this should only be done for multiple selection. Change this to correctly return VT_EMPTY for no selection and VT_DISPATCH (with an accessible) for single selection. Differential Revision: https://phabricator.services.mozilla.com/D17091
ce47b0935c9f67b00787f450ff226fbc64f7ee04: Bug 1514093 part 2: Marshal the result from IAccessible::get_accSelection as IEnumVARIANT. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 16 Jan 2019 08:13:20 +0000 - rev 511167
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514093 part 2: Marshal the result from IAccessible::get_accSelection as IEnumVARIANT. r=MarcoZ Our accSelection implementation always returns an IUnknown which clients QI to IEnumVARIANT. Marshaling as IUnknown works fine in this case, but it's more efficient and correct to marshal the correct interface. Also, without this, we'd hit an assertion. Depends on D16662 Differential Revision: https://phabricator.services.mozilla.com/D16663
346851347c909e92ed68dc3f104c63ff3e0eaa70: Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo
James Teh <jteh@mozilla.com> - Fri, 11 Jan 2019 04:52:50 +0000 - rev 510784
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo 1. This requires exposing radiogroup's focusedItem property to C++. Unfortunately, there's no existing equivalent in nsIDOMXULSelectControlItemElement. radiogroup is the only element that needs this, so a new interface has been created for it. 2. Accessibility uses focusedItem instead of selectedItem when setting focus. 3. When an item is focused, accessibility needs to be notified. This is done using a DOMMenuItemActive event. Differential Revision: https://phabricator.services.mozilla.com/D15295
460f0359741bd0026b7da0426836e1c0084a5be3: Bug 1518805 - Don't update bounds on gone or defunct accessibles. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Thu, 10 Jan 2019 06:59:16 +0000 - rev 510312
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518805 - Don't update bounds on gone or defunct accessibles. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D16064
01d64b7442cd23657d1135c9da9b254ba5317116: Bug 1518253 - Add accessibles to focus path hash table in non-e10s. r=MarcoZ
Eitan Isaacson <eitan@monotonous.org> - Tue, 08 Jan 2019 06:08:43 +0000 - rev 510036
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518253 - Add accessibles to focus path hash table in non-e10s. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D15858
db7ef78c063b2d0532056aa768f80493c8d0b739: Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 21 Dec 2018 09:16:38 +0000 - rev 509364
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ In order to support IA2 live regions with e10s (bug 1322532), text change events sent from the child process to the parent process use sync IPC. That comes at a slight performance cost: the content process is blocked until the parent returns from sending and handling the event. However, there is no reason to do this if the event is not for an accessible inside a live region; current clients don't need the sync behaviour outside of live regions. Differential Revision: https://phabricator.services.mozilla.com/D15183
415f827cb9ce211c48b0c6625e917582bc81fd3a: Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 21 Dec 2018 09:16:38 +0000 - rev 508753
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515294: Only use SendSyncTextChangeEvent for live regions. r=MarcoZ In order to support IA2 live regions with e10s (bug 1322532), text change events sent from the child process to the parent process use sync IPC. That comes at a slight performance cost: the content process is blocked until the parent returns from sending and handling the event. However, there is no reason to do this if the event is not for an accessible inside a live region; current clients don't need the sync behaviour outside of live regions. Differential Revision: https://phabricator.services.mozilla.com/D15183
5e4074b128f944119f2f224391453db85e2406cb: Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
Neil Deakin <neil@mozilla.com> - Mon, 17 Dec 2018 20:02:11 -0500 - rev 508229
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
003adae62f33b0425e68c6aafa3c255fc8611c06: Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
Neil Deakin <neil@mozilla.com> - Mon, 17 Dec 2018 15:43:51 -0500 - rev 508152
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513332, add some null-pointer checks on elements in XULListboxAccessible, r=marcoz
004331df8823ee887cc787e29ef7efe4fa4e596f: Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 20 Nov 2018 15:14:18 +0000 - rev 503840
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1429940 - Part 2 - Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences, instead of the "caption" element. r=MarcoZ,dao,jaws,flod This makes it possible to navigate by headings when using accessibility technology. Information labels displayed when removing the master password are also restored. Differential Revision: https://phabricator.services.mozilla.com/D11792
7ceb485a00ccd366cb25bedba008dcaf63a355d9: Bug 1052866 part 2: Handle QI to IAccessibleText for tables. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 29 Oct 2018 06:36:51 +0000 - rev 499722
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1052866 part 2: Handle QI to IAccessibleText for tables. r=MarcoZ The first patch inherits from the right classes, but because tables have additional interfaces, QueryInterface is overridden. It had to be updated to also include HyperTextAccessibleWrap. Rows worked correctly because they don't have any specific interfaces and thus don't override QI. They just inherit their QI implementation from their base class. Differential Revision: https://phabricator.services.mozilla.com/D10022
52b79f0655cb6bf92c4cd1fffafc617280feacd3: Bug 1052866 - Handle QI to IAccessibleText for tables. r=MarcoZ, a=RyanVM
James Teh <jteh@mozilla.com> - Mon, 29 Oct 2018 06:36:51 +0000 - rev 498229
Push 10077 by ryanvm@gmail.com at Wed, 31 Oct 2018 17:19:06 +0000
Bug 1052866 - Handle QI to IAccessibleText for tables. r=MarcoZ, a=RyanVM The first patch inherits from the right classes, but because tables have additional interfaces, QueryInterface is overridden. It had to be updated to also include HyperTextAccessibleWrap. Rows worked correctly because they don't have any specific interfaces and thus don't override QI. They just inherit their QI implementation from their base class. Differential Revision: https://phabricator.services.mozilla.com/D10022
4c11d8d96c247b0057a30e1521ac56ce90283f5e: Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 12 Oct 2018 15:07:17 +0100 - rev 496817
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure. Differential Revision: https://phabricator.services.mozilla.com/D8421
ba07c543cc935aed4a56a495a031dc8cd970290b: Bug 1496850 - add label to volume slider, r=MarcoZ
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 10 Oct 2018 17:40:42 +0000 - rev 496371
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496850 - add label to volume slider, r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D8202
c25dbd88a42d643e4a23fb27daeebe17da92199f: Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ
James Teh <jteh@mozilla.com> - Tue, 18 Sep 2018 05:10:35 +0000 - rev 492657
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1331755: Refactor handling of accessibility focus in the URL bar so focus never moves to suggestions while the user is editing. r=Gijs,MarcoZ When the user is editing the text in the URL bar (typing, backspace, etc.), the first suggestion is always selected. Because accessibility clients require autocomplete items to be "focused", the code needs to differentiate between explicit selection (e.g. via down/up arrow) and auto selection (e.g. when typing). Otherwise, the focus continually moves away from the text box while the user is typing, as was previously occurring. This makes it very difficult for the user to edit text, particularly backspace/delete. There was a previous attempt to handle this, but it was somewhat fragile and broke completely some time ago. Now, rather than trying to handle this based on autocomplete events, it is handled in the input and key press events. For input events, accessibility focus is forced back to the text box and further accessibility focus events are suppressed. For down arrow, up arrow, etc. key presses, accessibility focus events for suggestions are enabled. This makes it easier to understand and predict the user experience, rather than relying on underlying autocomplete implementation details. This is tested using an accessibility browser test, which makes it easier to make assertions about accessibility focus. This also means that if the underlying implementation details change (e.g. HTML + aria-activedescendant instead of XUL + DOMMenuItemActive events), this test should still be valid and allow us to catch regressions. Differential Revision: https://phabricator.services.mozilla.com/D5987
e67f28fac303774e424dee53737744f3fb2bf77e: Bug 1487304: Add more labels/descriptions in Privacy preferences for accessibility. r=johannh,MarcoZ
James Teh <jteh@mozilla.com> - Fri, 31 Aug 2018 07:57:57 +0000 - rev 489314
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1487304: Add more labels/descriptions in Privacy preferences for accessibility. r=johannh,MarcoZ This allows screen reader users to determine the context of various controls when tabbing through them. Specific changes: 1. Describe the "Cookies and Site Data" group using the disk space indicator; e.g. "Your stored cookies, site data and cache are currently using 315 MB of disk space." 2. Associate the description for the "Content Blocking" group; i.e. "Block third-party content, like ads or code..." 3. Correct association of the label for the "Do Not Track" setting; i.e. 'Send websites a “Do Not Track” signal that you don’t want to be tracked' 4. Associate the label for the "Permissions" group. 5. Make each permission a labelled group so the user knows what the various "Settings…" buttons are for. 6. Associate the label for the "Data Collection and Use" group. Differential Revision: https://phabricator.services.mozilla.com/D4638
179fc264c8643d1f8770ef2b2e861abf56a5287e: Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ
James Teh <jteh@mozilla.com> - Mon, 13 Aug 2018 06:28:35 +0000 - rev 486271
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1480060: Support aria-multiselectable on role tablist. r=MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D3076
b6c8ed7e23e393ac9dc6873ba0efecd52cf9cad0: Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 16:40:50 +1000 - rev 484006
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 903187: Map HTML ins/del to accessible roles. r=MarcoZ IA2 now has IA2_ROLE_CONTENT_INSERTION/DELETION. Mac has AXInsert/DeleteStyleGroup subroles. We now create accessibles for these elements and expose the appropriate role. For ATK, there is no specific role for these, so we just use the generic ATK_ROLE_SECTION. MozReview-Commit-ID: 2khzRa7BQ6z
84450fef88b2fa9c6696bf26cc5c211a0ce98b97: Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 10:30:25 +1000 - rev 483752
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478568 part 2: Map BLOCKQUOTE role to IA2_ROLE_BLOCK_QUOTE. r=MarcoZ MozReview-Commit-ID: KxGnO0R1dRJ
08dc38b9377252d2b10caea1c10971f6fbe25908: Bug 1478568 part 1: Update IAccessible2 so we can use new roles (IA2_ROLE_BLOCK_QUOTE, etc.). r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 27 Jul 2018 10:27:44 +1000 - rev 483751
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478568 part 1: Update IAccessible2 so we can use new roles (IA2_ROLE_BLOCK_QUOTE, etc.). r=MarcoZ MozReview-Commit-ID: GctgcmwrzMc
ab79c47390b5f8e508353093ed77b90b7e6fcce3: Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 18 Jul 2018 20:13:01 +1000 - rev 482500
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1476347: Fix accessibility for HTML dt/dd with a div as its parent. r=MarcoZ It is conforming in HTML to use a div to group dt/dd elements. Previously, we didn't create an accessible for dt/dd elements in this case. MozReview-Commit-ID: 8GDDxU3RbLd
254564563107faac0f16dd48fa6927ddbfac955c: Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 12 Jul 2018 20:22:09 -0400 - rev 481541
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1475376: Support aria-valuetext for implicit ARIA roles. r=MarcoZ For example, <input type="range"> maps to role="slider", so aria-valuetext should be supported. MozReview-Commit-ID: IYBVTHP3ZLo
cbf89941ccff2dde578bb11be34aec1a1b902b1f: Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 11 Jul 2018 16:26:19 +1000 - rev 480882
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ We don't fire a state change for the focused state, since that would be redundant given that we fire a focus event. However, that also means the handler cache previously didn't get invalidated when there was a focus change without any other update. That resulted in stale focused states, which could mean an object was exposed as focused when it wasn't. Invalidating the cache for focus events ensures the focused state is always up to date. MozReview-Commit-ID: DZTJMbiTwgt
7f496f2f11ef8fccba876b2a307bbf8f4f6e77e1: Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r=MarcoZ
Chris Peterson <cpeterson@mozilla.com> - Wed, 04 Jul 2018 14:39:57 -0700 - rev 480839
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1473453 - Part 1: a11y: assert `hitregion` property is always null or true. r=MarcoZ Fix clang-tidy warning about bool pointers: [misc-bool-pointer-implicit-conversion] accessible/generic/Accessible.cpp:644:9: warning: dubious check of 'bool *' against 'nullptr', did you mean to dereference it? The `hitregion` property is always null or points to a true bool, set here: https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/dom/canvas/CanvasRenderingContext2D.cpp#3936-3937 The `hitregion` property used to be an nsRect pointer: https://searchfox.org/mozilla-central/diff/c797577640f306df87e8c32313c5b826d1e58a9b/accessible/src/generic/Accessible.cpp#928 MozReview-Commit-ID: HYlAnMyaitB
4fd60abd9726046598d302b473106f7df33e66f1: Bug 468497: Inform the accessibility FocusManager when a XUL tree's view changes. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 05 Jul 2018 16:33:24 +1000 - rev 480358
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 468497: Inform the accessibility FocusManager when a XUL tree's view changes. r=MarcoZ Without this, accessibility clients don't get notified about the newly focused item. For example, this meant that nothing was reported by screen readers when switching tabs in Thunderbird with control+tab. MozReview-Commit-ID: F7vqvLXzeJR
825a33b82f472d439196ecfae5dd34fc6566a6f7: Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ a=lizzard
James Teh <jteh@mozilla.com> - Wed, 11 Jul 2018 16:26:19 +1000 - rev 477952
Push 9475 by archaeopteryx@coole-files.de at Fri, 13 Jul 2018 21:33:22 +0000
Bug 1474814: Invalidate the AccessibleHandler cache on focus events. r=MarcoZ a=lizzard We don't fire a state change for the focused state, since that would be redundant given that we fire a focus event. However, that also means the handler cache previously didn't get invalidated when there was a focus change without any other update. That resulted in stale focused states, which could mean an object was exposed as focused when it wasn't. Invalidating the cache for focus events ensures the focused state is always up to date. MozReview-Commit-ID: DZTJMbiTwgt
50a6c79860000396a9d1378687e150310ae96eb4: Bug 1460244 - Tables with CSS display properties no longer participate in layout table calculation, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Fri, 25 May 2018 10:55:52 -0400 - rev 474113
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1460244 - Tables with CSS display properties no longer participate in layout table calculation, r=marcoz
cb4152d2175e9ada6736224067b322a785e106c8: Bug 1462238: Extend/clarify expiry of accessibility instantiator/consumers telemetry. r=MarcoZ data-review=francois
James Teh <jteh@mozilla.com> - Thu, 17 May 2018 16:55:03 +1000 - rev 472994
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1462238: Extend/clarify expiry of accessibility instantiator/consumers telemetry. r=MarcoZ data-review=francois 1. Set A11Y_INSTANTIATORS to never expire. 2. A11Y_CONSUMERS was already set to never expire, but only because expiry was never explicitly declared (when this was allowed). Explicitly set it as never expiring now. This also means it can be removed from the associated whitelist. 3. Change the email for both so it gets to the team and me (since policy requires a responsible person and that's me now for these). MozReview-Commit-ID: BgjMoVnVp6U
c199ef8f320762d7fcbec18bd68f0aecc5c22c1b: Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 15 May 2018 09:44:21 -0400 - rev 472584
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1455357 - Setting grid item to display:contents resets its accessible role, patch=surkov,jamie, r=marcoz
1abaa57e467e72e566b4f74485ba10322bde6921: Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz
Alexander Surkov <surkov.alexander@gmail.com> - Tue, 08 May 2018 13:13:38 -0400 - rev 471646
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1005271 - HTML table with display:block should expose table semantics, r=marcoz
c3296237754d22e87755b3f9c4d75bb0e18eb95f: Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Alex Gaynor <agaynor@mozilla.com> - Fri, 13 Apr 2018 10:51:43 -0400 - rev 467504
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ MozReview-Commit-ID: 92S42SkSEEP
99c2396a4c8767d152e437299664d0e15c3d8e35: Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Alex Gaynor <agaynor@mozilla.com> - Fri, 13 Apr 2018 10:51:43 -0400 - rev 467448
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ MozReview-Commit-ID: 92S42SkSEEP
ad1a87f7ffa532f18f6ced9f93a2f51c790f1b35: Bug 1453873: Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 13 Apr 2018 14:14:50 +1000 - rev 466649
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1453873: Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ These events were a hack implemented in bug 703198. At that time, JAWS required focus events for selection changes in a collapsed combo box. However, these events also fire for expanded combo boxes. This is problematic with e10s because now, for an expanded combo box, the real focus events come from the XUL dropdown implemented in the parent process, which is not associated with the document a11y tree in any way. JAWS seems to cope just fine with value changes for Firefox combo boxes now and VFO have agreed that this is the correct path forward. MozReview-Commit-ID: Iefop25bFe0
5a6db1121fcede3d0844ec1be195ab7858cd1e19: Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ
alexander :surkov <surkov.alexander@gmail.com> - Thu, 05 Apr 2018 10:24:00 +0300 - rev 465687
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ
a61e917f9406110b7d84ccc01416fda61c8bf4d0: Bug 1448091 part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:53:01 -0400 - rev 463215
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1448091 part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ The singleton AccessibleHandlerControl maintains a global cache generation counter which is incremented whenever any node is changed. The handler for each node tracks the cache generation at the time its cache was initialized. To check whether the cache needs to be updated, the handler compares its generation against the global generation from AccessibleHandlerControl. If they differ, it refreshes the cache. Previously, the handler didn't update its cache generation after refreshing. This meant that every single query after the first change would refresh the whole cache, even if there wasn't a second change. This resulted in a huge number of wasted cache updates for clients such as JAWS which hold onto accessibles, rather than releasing them and fetching them again for each update. MozReview-Commit-ID: 80d4n1cIjzQ
702ffbc7ccd54d86913b43becf7a559da8b3f189: Bug 1448091 part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:44:05 -0400 - rev 463214
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1448091 part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ BuildDynamicIA2Data can't return an HRESULT; failure is communicated by the fact that the unique id in the data is set to 0. However, IGeckoBackChannel::Refresh returned S_OK even if BuildDynamicIA2Data failed. We now check the unique id and return an appropriate error code if it's 0. Among other things, this means that the handler will return an error when querying dead objects instead of returning stale cache data. MozReview-Commit-ID: IorDRHCItD8
aa06fb8316c272ecf735aecb59673544d6423631: Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r=MarcoZ
James Teh <jteh@mozilla.com> - Thu, 22 Mar 2018 17:57:34 -0400 - rev 463170
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1431256 correction: AccessibleHandler: Really return E_NOINTERFACE for IEnumVARIANT if there are no children. r=MarcoZ A typo meant we were checking the address of mChildCount, not the value. MozReview-Commit-ID: 7Hit3FBy9pr
8f68422b3307dc910732da8f07ceb9accbc74873: Bug 1431256 part 4: Remove IEnumVARIANT from the AccessibleHandler payload. r=MarcoZ
James Teh <jteh@mozilla.com> - Fri, 19 Jan 2018 11:40:42 +1000 - rev 463044
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1431256 part 4: Remove IEnumVARIANT from the AccessibleHandler payload. r=MarcoZ Now that the handler implements IEnumVARIANT itself (and uses our own internal method to retrieve the children), caching this remote interface is pointless. MozReview-Commit-ID: FyagiEcHMP2
7e3ec61fa95274530ca48fba49e263811c9f3d2b: Bug 1431256 part 3: AccessibleHandler: When a client requests children, fetch them optimally using a single cross-process call. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 21 Mar 2018 11:03:45 -0400 - rev 463043
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1431256 part 3: AccessibleHandler: When a client requests children, fetch them optimally using a single cross-process call. r=MarcoZ This implements IEnumVARIANT locally using the new method provided by HandlerProvider. This avoids marshaling full objects for text leaf accessibles (instead using HandlerTextLeaf), which is much faster. It also avoids a pointless cross-process call to IEnumVARIANT::Reset (and possibly IEnumVARIANT::Clone). Finally, it caches children after the first query so that clients (such as UI Automation) which walk children one by one don't incur separate cross-process calls for every child. MozReview-Commit-ID: KUIXQoXxInQ
580a1123de819a3798a53c9c14516d438fcb1046: Bug 1431256 part 2: AccessibleHandler: Implementation of IAccessible2 for text leaf accessibles using data provided in AccChildData. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 21 Mar 2018 10:56:11 -0400 - rev 463042
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1431256 part 2: AccessibleHandler: Implementation of IAccessible2 for text leaf accessibles using data provided in AccChildData. r=MarcoZ For text leaf accessibles, the HandlerProvider::AllChildren property provides text and other necessary information in an AccChildData struct, rather than providing the full accessible object. Therefore, we must provide a specific local implementation of IAccessible2 which answers queries based on the data provided in this struct. MozReview-Commit-ID: 8BYMF59EoTe
fc4b465ae5c1d8e9910c3e5815e3f4cb2f083637: Bug 1431256 part 1: Accessible HandlerProvider: Implement a method to optimally retrieve all children in a single call. r=MarcoZ
James Teh <jteh@mozilla.com> - Wed, 21 Mar 2018 10:08:53 -0400 - rev 463041
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1431256 part 1: Accessible HandlerProvider: Implement a method to optimally retrieve all children in a single call. r=MarcoZ When considering a large document, a huge number of the children we return are text leaf nodes. Marshaling full objects is expensive, but for text leaf nodes, the client is only interested in the text and a few other pieces of information. Therefore, rather than returning the full object for text leaf accessibles, we just return the text and other necessary information. For other non-text children, we return the full object as usual. In addition, clients normally use the IEnumVARIANT interface to retrieve children in a single call. However, it doesn't allow you to specify a starting index. Therefore, you must first call the Reset method to reset the starting point to 0. Practically, this means an extra cross-process call whenever the caller fetches children. When dealing with a large document, this can be a significant number of wasted calls. This new method retrieves all children always starting at the first using a single call. MozReview-Commit-ID: A9lc7BBTWdb
821855807c5b55884306ffe17c8b1e26e5d876eb: Bug 1453873 - Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ, a=jcristau
James Teh <jteh@mozilla.com> - Fri, 13 Apr 2018 14:14:50 +1000 - rev 460826
Push 9066 by ryanvm@gmail.com at Mon, 16 Apr 2018 16:39:10 +0000
Bug 1453873 - Stop firing accessible focus events for JAWS when combo box options are selected. r=MarcoZ, a=jcristau These events were a hack implemented in bug 703198. At that time, JAWS required focus events for selection changes in a collapsed combo box. However, these events also fire for expanded combo boxes. This is problematic with e10s because now, for an expanded combo box, the real focus events come from the XUL dropdown implemented in the parent process, which is not associated with the document a11y tree in any way. JAWS seems to cope just fine with value changes for Firefox combo boxes now and VFO have agreed that this is the correct path forward. MozReview-Commit-ID: Iefop25bFe0
c0ae9d98922d58dd629644966a67b35f30e35bda: Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ a=jcristau
alexander :surkov <surkov.alexander@gmail.com> - Thu, 05 Apr 2018 10:24:00 +0300 - rev 460727
Push 9030 by archaeopteryx@coole-files.de at Thu, 12 Apr 2018 15:46:07 +0000
Bug 1451673 - "Crash in mozilla::a11y::HTMLTableAccessible::IsProbablyLayoutTable" r=MarcoZ a=jcristau
880bdfaff98ec3098a2fd2ea50c29c52b540ee53: Bug 1448091 - Part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ, a=jcristau
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:53:01 -0400 - rev 460421
Push 8940 by ryanvm@gmail.com at Wed, 28 Mar 2018 19:11:14 +0000
Bug 1448091 - Part 2: AccessibleHandler: Don't repeatedly and unnecessarily refresh the cache after the first change. r=MarcoZ, a=jcristau The singleton AccessibleHandlerControl maintains a global cache generation counter which is incremented whenever any node is changed. The handler for each node tracks the cache generation at the time its cache was initialized. To check whether the cache needs to be updated, the handler compares its generation against the global generation from AccessibleHandlerControl. If they differ, it refreshes the cache. Previously, the handler didn't update its cache generation after refreshing. This meant that every single query after the first change would refresh the whole cache, even if there wasn't a second change. This resulted in a huge number of wasted cache updates for clients such as JAWS which hold onto accessibles, rather than releasing them and fetching them again for each update. MozReview-Commit-ID: 80d4n1cIjzQ
50c5d93932ca95a27cb9ddb5d9af37dc0c0d0ce1: Bug 1448091 - Part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ, a=jcristau
James Teh <jteh@mozilla.com> - Fri, 23 Mar 2018 11:44:05 -0400 - rev 460420
Push 8940 by ryanvm@gmail.com at Wed, 28 Mar 2018 19:11:14 +0000
Bug 1448091 - Part 1: Accessible HandlerProvider: Return an error if refreshing the cache fails. r=MarcoZ, a=jcristau BuildDynamicIA2Data can't return an HRESULT; failure is communicated by the fact that the unique id in the data is set to 0. However, IGeckoBackChannel::Refresh returned S_OK even if BuildDynamicIA2Data failed. We now check the unique id and return an appropriate error code if it's 0. Among other things, this means that the handler will return an error when querying dead objects instead of returning stale cache data. MozReview-Commit-ID: IorDRHCItD8