searching for reviewer(mak)
d719e13dbb8b: Bug 1504854 - Autofilled search shortcuts should show a single "Search with Engine" heuristic result in the popup. r=mak, a=jcristau
Drew Willcoxon <adw@mozilla.com> - Mon, 12 Nov 2018 15:45:39 +0000 - rev 498511
Push 10195 by ryanvm@gmail.com at Wed, 14 Nov 2018 19:22:22 +0000
Bug 1504854 - Autofilled search shortcuts should show a single "Search with Engine" heuristic result in the popup. r=mak, a=jcristau All we need to do is set `_searchEngineAliasMatch` with an empty query so that we don't try to add any more results. That hits the existing case where the user types out a full @ alias and we show only the "search with engine" heuristic result. Differential Revision: https://phabricator.services.mozilla.com/D11547
3931ebbd5588: Bug 1498023 - Search shortcuts should hide all one-off UI when typed. r=mak,Mardak, a=RyanVM
Drew Willcoxon <adw@mozilla.com> - Mon, 29 Oct 2018 16:13:49 +0000 - rev 498232
Push 10078 by ryanvm@gmail.com at Wed, 31 Oct 2018 19:18:30 +0000
Bug 1498023 - Search shortcuts should hide all one-off UI when typed. r=mak,Mardak, a=RyanVM * Disable or enable the one-offs per each new search based on whether the first char is "@". The patch does this in `onResultsAdded`, where other per-search initialization happens. * Remove the `disableOneOffButtons` option from the urlbar `search` method. It's not necessary anymore now that one-offs are automatically hidden for the only caller that uses this option (new tab with the "@engine" tiles). * Make the `oneOffSearchesEnabled` getter return the actual status of the one-off UI instead of relying on an `_oneOffSearchesEnabled` property. Differential Revision: https://phabricator.services.mozilla.com/D9883
38e139673b19: Bug 1500516 - Search aliases: @engine text should remain in the urlbar when highlighting search suggestion results, and modified suggestions should search with the @ engine r=mak a=RyanVM
Drew Willcoxon <adw@mozilla.com> - Thu, 25 Oct 2018 21:53:24 +0000 - rev 498173
Push 10054 by csabou@mozilla.com at Fri, 26 Oct 2018 19:18:40 +0000
Bug 1500516 - Search aliases: @engine text should remain in the urlbar when highlighting search suggestion results, and modified suggestions should search with the @ engine r=mak a=RyanVM * Slightly rework the logic that makes `searchSuggestionsCompletePromise` so that it checks `this.hasBehavior("searches")` and `this._inPrivateWindow` earlier so that it can avoid getting the query string and truncating it (along with the pref accesss) * Get rid of the `input` param to `_addSearchEngineMatch`. It's only used for forcing a trailing space for alias results that don't have a query, but `_addSearchEngineMatch` can detect that case on its own -- no need for an `input` param. * A slightly unrelated change: I noticed that when the spec shows a search for "@amazon telescopes", the first suggestion is not "telescopes", like it actually is in Firefox, but "telescopes for adults". That makes sense. There's no point in having the first suggestion echo back the heuristic result. It's better not to because (1) there's no visual dupe and (2) you don't have to press the down arrow key twice to get to non-dupe suggestions. So I added some logic to the suggestions fetching to ignore suggestions that are duplicates of the search string. I changed `_searchEngineAliasMatch` to `_searchEngineHeuristicMatch` because of course you can do searches without using an alias, and this new logic needs the query string in that case. * Slightly rework `_addSearchEngineMatch` to be a little more straightforward * Fix `head_autocomplete.js` so it intelligently compares moz-action results instead of a simple string comparison (and hope that the object is stringified the same way) Differential Revision: https://phabricator.services.mozilla.com/D9472
e89d63d1dd5f: Bug 1501337 - Fix a leak and uncleared listeners in places code relating to the edit bookmarks views. r=mak, a=RyanVM
Mark Banner <standard8@mozilla.com> - Tue, 23 Oct 2018 17:58:43 +0000 - rev 498116
Push 10030 by ryanvm@gmail.com at Wed, 24 Oct 2018 15:02:10 +0000
Bug 1501337 - Fix a leak and uncleared listeners in places code relating to the edit bookmarks views. r=mak, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D9546
418fa1fa4f74: Bug 1499581 - Autofill search engine aliases in the address bar when '@' is typed as the first character r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 19 Oct 2018 16:08:26 +0000 - rev 497965
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1499581 - Autofill search engine aliases in the address bar when '@' is typed as the first character r=mak One important unrelated change this makes is that previously (in my other patches), the only "@" aliases we recognized were the internal "@" aliases in nsSearchService. While I was working on the new test here I realized that engines with user (or test) aliases that start with "@" aren't recognized as having "@" aliases, but why not IMO. Differential Revision: https://phabricator.services.mozilla.com/D9074
eab3a0cf6429: Bug 1496815 - Suggest search engine aliases in the address bar when '@' is typed as the first character r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 19 Oct 2018 16:08:24 +0000 - rev 497964
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1496815 - Suggest search engine aliases in the address bar when '@' is typed as the first character r=mak This bug touches just about every part of the urlbar: UnifiedComplete, the autocomplete binding, the formatter, CSS. This builds on the patches in bug 1496814 and bug 1496811. Differential Revision: https://phabricator.services.mozilla.com/D8948
4aad71bbd529: Bug 1500086 - While typing, show the Go button and hide the history dropmarker. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 19 Oct 2018 15:58:57 +0000 - rev 497962
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1500086 - While typing, show the Go button and hide the history dropmarker. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9106
23321e0768f0: Bug 1500080 - UrlbarInput::value getter should return the untrimmed value. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 19 Oct 2018 15:25:55 +0000 - rev 497953
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1500080 - UrlbarInput::value getter should return the untrimmed value. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9088
59fed9e69c53: Bug 1500086 - While typing, show the Go button and hide the history dropmarker. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 19 Oct 2018 11:20:34 +0000 - rev 497923
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1500086 - While typing, show the Go button and hide the history dropmarker. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9106
f6c89db3520c: Bug 1500080 - UrlbarInput::value getter should return the untrimmed value. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 19 Oct 2018 11:36:40 +0000 - rev 497920
Push 10016 by rgurzau@mozilla.com at Mon, 22 Oct 2018 13:58:55 +0000
Bug 1500080 - UrlbarInput::value getter should return the untrimmed value. r=mak Differential Revision: https://phabricator.services.mozilla.com/D9088
665fecc38740: Bug 1496814 - Show only search suggestion results when only an engine alias and query are typed in the address bar r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 18 Oct 2018 15:23:55 +0000 - rev 497696
Push 10002 by archaeopteryx@coole-files.de at Fri, 19 Oct 2018 23:09:29 +0000
Bug 1496814 - Show only search suggestion results when only an engine alias and query are typed in the address bar r=mak This is based on the patch in bug 1496811. This patch looks a little worse than it probably is. (Maybe not by much.) Some of this is indentation changes, moving code around, renaming, and adding jsdocs. It looks like we missed the boat on uplifting this (and the other couple of bugs) to 63, so there's not a super-pressing need to keep the patch minimal. PlacesSearchAutocompleteProvider assumes you're fetching suggestions from the current engine, so I had to modify it to take an engine. While I was doing that, I got a little frustrated with some of its implementation, naming, and interface. It seems like it was written to be a little more generic than it ended up being? There doesn't seem to be any need for it to return generic "match" objects instead of simply engines and `{ suggestion, historical }` objects, for example. The "defaultMatch" concept also doesn't make much sense IMO, especially with the aforementioned changes. So I made some improvements, hopefully, and I also added some jsdocs. Differential Revision: https://phabricator.services.mozilla.com/D8818
c203c7e7a7fa: Bug 1497469 - Dispatch the ValueChange event from UrlbarInput. r=mak
Dão Gottwald <dao@mozilla.com> - Wed, 17 Oct 2018 13:07:58 +0000 - rev 497448
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1497469 - Dispatch the ValueChange event from UrlbarInput. r=mak Differential Revision: https://phabricator.services.mozilla.com/D8819
0f5b5590bf69: Bug 1496811 - Show only top single result when search only engine alias is typed in the address bar r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 17 Oct 2018 15:26:46 +0000 - rev 497445
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1496811 - Show only top single result when search only engine alias is typed in the address bar r=mak Differential Revision: https://phabricator.services.mozilla.com/D8804
c8afe4845022: Bug 1477669 - remove feed preview code and associated files/code, r=flod,mak,nika
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 16 Oct 2018 12:47:36 +0000 - rev 497202
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1477669 - remove feed preview code and associated files/code, r=flod,mak,nika Differential Revision: https://phabricator.services.mozilla.com/D8524
bd8f6c06661e: Bug 1498748 - Stop ignoring browser.urlbar.quantumbar in the first window. r=mak
Dão Gottwald <dao@mozilla.com> - Mon, 15 Oct 2018 12:59:31 +0000 - rev 497042
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1498748 - Stop ignoring browser.urlbar.quantumbar in the first window. r=mak Differential Revision: https://phabricator.services.mozilla.com/D8633
8411d22c2440: Bug 1495614 - Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 12 Oct 2018 13:45:37 +0000 - rev 496656
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495614 - Don't highlight the search engine alias when the urlbar input doesn't match the first heuristic result r=mak Differential Revision: https://phabricator.services.mozilla.com/D8479
94bc301b5bd4: Bug 1494471 - Ignore the autofill threshold when autofilling URLs r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 11 Oct 2018 08:34:25 +0000 - rev 496517
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494471 - Ignore the autofill threshold when autofilling URLs r=mak Differential Revision: https://phabricator.services.mozilla.com/D7361
224c0fc59fc1: Bug 1477671 - Replace synced livemarks with tombstones, r=mak,markh
Lina Cambridge <lina@yakshaving.ninja> - Sat, 06 Oct 2018 10:36:15 +0100 - rev 496385
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1477671 - Replace synced livemarks with tombstones, r=mak,markh This commit replaces incoming synced livemarks with tombstones, and reuploads the tombstone and updated parent to the server. Existing livemarks are left untouched to minimize data loss; we'll either delete them during migration, or when another client runs a full sync. Differential Revision: https://phabricator.services.mozilla.com/D7084
2cd029293041: Bug 1477672 - export and convert existing live bookmarks to avoid losing user data, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 17 Sep 2018 18:59:57 +0100 - rev 496383
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1477672 - export and convert existing live bookmarks to avoid losing user data, r=mak Differential Revision: https://phabricator.services.mozilla.com/D6062
85a806b69f15: Bug 1426245 - Test changes r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 09 Oct 2018 14:47:31 +0000 - rev 496014
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1426245 - Test changes r=mak MozReview-Commit-ID: 4fhhzspxLJZ Depends on D4606 Differential Revision: https://phabricator.services.mozilla.com/D5162
50ca67245a71: Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 09 Oct 2018 14:47:27 +0000 - rev 496013
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit# for further info. This essentially follows the same philosophy as the onVisits migration. MozReview-Commit-ID: I4bOvFH0ZQR Depends on D4605 Differential Revision: https://phabricator.services.mozilla.com/D4606
01f732762529: Bug 1426245 - Allow partial removal of places oberver listeners r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 09 Oct 2018 14:45:58 +0000 - rev 496012
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1426245 - Allow partial removal of places oberver listeners r=mak This was a bug in the original design that just hadn't shown up yet. If I were to listen to, say "notification-a", and then try to remove my listener for "notification-a" and "notification-b", we would end up with a dead listener staying in the list. This fixes that. MozReview-Commit-ID: KhYQSJaBDF9 Differential Revision: https://phabricator.services.mozilla.com/D4605
fa8c1d182709: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Tue, 02 Oct 2018 15:30:24 +0000 - rev 495667
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
237c55ddb112: Bug 1493636 - Always autofill bookmarks, regardless of their frecency and the autofill frecency threshold. r=mak
Drew Willcoxon <adw@mozilla.com> - Sat, 06 Oct 2018 00:22:04 +0000 - rev 495604
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493636 - Always autofill bookmarks, regardless of their frecency and the autofill frecency threshold. r=mak Differential Revision: https://phabricator.services.mozilla.com/D7673
e9c7d14fc4a9: Bug 1493636 - Always autofill bookmarks, regardless of their frecency and the autofill frecency threshold. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 05 Oct 2018 15:26:39 +0000 - rev 495591
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493636 - Always autofill bookmarks, regardless of their frecency and the autofill frecency threshold. r=mak Differential Revision: https://phabricator.services.mozilla.com/D7673
2614ca0a8884: Bug 1452626 - Remove the "download" binding. r=mak,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 04 Oct 2018 11:12:03 +0100 - rev 495564
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452626 - Remove the "download" binding. r=mak,bgrins Differential Revision: https://phabricator.services.mozilla.com/D7176
2f1229c179d3: Bug 1494046 - Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 04 Oct 2018 08:54:25 +0000 - rev 495273
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494046 - Improve how the folder icon is selected on the folder list in the bookmark popup window. r=mak Change to using an event listener to follow when the selection changes more accurately. Also switch to using GUIDs as they are better defined than indexes. Differential Revision: https://phabricator.services.mozilla.com/D7537
35b71d287e96: Bug 1489060 - Urlbar autofill is broken when autofilling history is disabled and autofilling bookmarks is enabled r=mak
Drew Willcoxon <adw@mozilla.com> - Sat, 29 Sep 2018 08:53:42 +0000 - rev 494807
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1489060 - Urlbar autofill is broken when autofilling history is disabled and autofilling bookmarks is enabled r=mak In the origin query, the SELECT is aggregate due to both the TOTAL(frecency) column and the GROUP BY, but bookmarkedFragment is not aggregate. So it ends up looking only at whatever moz_place ends up first in its result set. If that moz_place's foreign_count is zero, then the whole bookmarkedFragment is zero, even if there are moz_places in the result set that are bookmarked. Change bookmarkedFragment to use TOTAL. Differential Revision: https://phabricator.services.mozilla.com/D6867
c869bea1ed94: Bug 1493969 - Refactor the user interface update code of download elements. r=mak,ursula
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 28 Sep 2018 14:59:30 +0100 - rev 494717
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1493969 - Refactor the user interface update code of download elements. r=mak,ursula Differential Revision: https://phabricator.services.mozilla.com/D4539
c96874a02a34: Bug 1495031 - Eliminate ambiguous ctor for nsMaybeWeakPtr r=mak
Andrew McCreight <continuation@gmail.com> - Sat, 29 Sep 2018 08:25:18 +0000 - rev 494615
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495031 - Eliminate ambiguous ctor for nsMaybeWeakPtr r=mak When bug 1494765 adds support for conversion between nsCOMPtr<>s to related types, code using nsMaybeWeakPtr fails to compile due to ambiguous constructors. I'm not sure exactly why this is, but it seems like we only really need to support two ctors: T* and nsCOMPtr<nsIWeakReference>, for the cases of a strong and weak reference, respectively. The operator= overloads are needed for the branches in AppendWeakElement. Differential Revision: https://phabricator.services.mozilla.com/D7222
7e5bf501404a: Bug 1491724 - Search engine keyword should be highlighted only when the search will actually be performed on the corresponding search engine r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 28 Sep 2018 23:29:26 +0000 - rev 494598
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491724 - Search engine keyword should be highlighted only when the search will actually be performed on the corresponding search engine r=mak My reasoning in https://bugzilla.mozilla.org/show_bug.cgi?id=1484737#c3 was wrong. I assumed that if a result started with a search alias then it had to be a search alias result, but that's clearly not true. This is such a pain to get right, and all the messy logic in this patch reflects that. Differential Revision: https://phabricator.services.mozilla.com/D6528
91d895e3296e: Bug 1494274 - Port clickSelectsAll and doubleClickSelectsAll behavior from urlbarBindings.xml to UrlbarInput.jsm. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 28 Sep 2018 17:57:53 +0200 - rev 494493
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494274 - Port clickSelectsAll and doubleClickSelectsAll behavior from urlbarBindings.xml to UrlbarInput.jsm. r=mak
80e6c958c849: Bug 1494077: Remove unused macro and its supporting #define to fix a unified build problem. r=mak
David Major <dmajor@mozilla.com> - Thu, 27 Sep 2018 08:58:55 -0400 - rev 494245
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494077: Remove unused macro and its supporting #define to fix a unified build problem. r=mak
d4c858c70bc9: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Tue, 25 Sep 2018 18:21:56 +0000 - rev 493928
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
db16547e0d60: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Mon, 24 Sep 2018 16:12:46 +0000 - rev 493662
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
52ee9ddf5060: Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
Dragana Damjanovic <dd.mozilla@gmail.com> - Sat, 22 Sep 2018 23:54:11 +0300 - rev 493547
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
83ab7c05f538: Bug 1328519 - Simplify the definition of the Downloads Panel width. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 19 Sep 2018 17:01:09 +0100 - rev 493546
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1328519 - Simplify the definition of the Downloads Panel width. r=mak The width is now defined on the entire list instead of the inner elements, similarly to other Photon panels like the main menu. This is a prerequisite for preventing layout issues while removing the "download" binding. Differential Revision: https://phabricator.services.mozilla.com/D6284
442b0454a618: Bug 462674 - URLBar: Autocomplete "about:" URLs r=mak
Nicolas Ouellet-Payeur <nicolaso@google.com> - Fri, 21 Sep 2018 00:31:02 +0000 - rev 493331
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 462674 - URLBar: Autocomplete "about:" URLs r=mak Pages that are whitelisted for displaying on about:about can be autocompleted in the URL bar. MozReview-Commit-ID: BYhWUImyiJH Differential Revision: https://phabricator.services.mozilla.com/D3072
9828a37ea75f: Bug 1485987 - Make urlbar.search() fire an input event. r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 20 Sep 2018 23:05:33 +0000 - rev 493300
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1485987 - Make urlbar.search() fire an input event. r=mak `urlbar.search` needs to simulate the user's typing. Fire an input event, as we do elsewhere to simulate it. Differential Revision: https://phabricator.services.mozilla.com/D6215
dc225279994a: Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
Dragana Damjanovic <dd.mozilla@gmail.com> - Thu, 20 Sep 2018 20:53:28 +0000 - rev 493297
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus Implement necko part of ESNI Differential Revision: https://phabricator.services.mozilla.com/D2716
db8fbd7e55fc: Bug 1492379 - Switch off tests in unifiedcomplete and four more all depending on UnifiedComplete.js for Thunderbird. r=mak
Jorg K <jorgk@jorgk.com> - Wed, 19 Sep 2018 04:34:00 +0300 - rev 493021
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1492379 - Switch off tests in unifiedcomplete and four more all depending on UnifiedComplete.js for Thunderbird. r=mak
843a421610f0: Bug 1491671 - Upgrade to SQLite 3.25.1. r=mak
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 19 Sep 2018 13:28:02 +0000 - rev 492960
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491671 - Upgrade to SQLite 3.25.1. r=mak Differential Revision: https://phabricator.services.mozilla.com/D6207
b05359ae06be: Bug 1490527 - Use UrlbarPreferences.jsm in UnifiedComplete.js r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 18 Sep 2018 20:13:18 +0000 - rev 492749
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1490527 - Use UrlbarPreferences.jsm in UnifiedComplete.js r=mak Replace the `Prefs` object in UnifiedComplete.js with usage of the new UrlbarPreferences.jsm. Differential Revision: https://phabricator.services.mozilla.com/D5627
67f7bbfb61c2: Bug 1489282 - Create a UrlbarPreferences module that can be used across all urlbar components r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 18 Sep 2018 20:06:27 +0000 - rev 492748
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1489282 - Create a UrlbarPreferences module that can be used across all urlbar components r=mak This factors out the `Prefs` object from UnifiedComplete.js into UrlbarPreferences.jsm and makes required changes so it's not tied to consts and other identifiers local to UnifiedComplete.js. It adds another new module, UrlbarUtils.jsm, for storing consts that both UrlbarPreferences and UnifiedComplete use. In order to preserve blame as much as possible, I used `hg cp` to copy UnifiedComplete.js to UrlbarPreferences.jsm, and then I removed all the non-Prefs code before making other changes, so this patch looks bigger than it really is. (Maybe I wasn't actually so successful in preserving a lot of blame.) Differential Revision: https://phabricator.services.mozilla.com/D5626
23c9c6b2dc81: Bug 1490527 - Use UrlbarPreferences.jsm in UnifiedComplete.js r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 18 Sep 2018 06:37:13 +0000 - rev 492738
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1490527 - Use UrlbarPreferences.jsm in UnifiedComplete.js r=mak Replace the `Prefs` object in UnifiedComplete.js with usage of the new UrlbarPreferences.jsm. Differential Revision: https://phabricator.services.mozilla.com/D5627
1de95b7783f0: Bug 1452629 - Part 5 - Remove the "downloadDetailsFull" description element. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 28 Aug 2018 16:53:04 +0100 - rev 492152
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452629 - Part 5 - Remove the "downloadDetailsFull" description element. r=mak Differential Revision: https://phabricator.services.mozilla.com/D4461
48e3334d170d: Bug 1452629 - Part 4 - Remove the "downloadShowMoreInfo" description element. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 28 Aug 2018 15:41:36 +0100 - rev 492151
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452629 - Part 4 - Remove the "downloadShowMoreInfo" description element. r=mak Differential Revision: https://phabricator.services.mozilla.com/D4460
4aca3cccf16f: Bug 1452629 - Part 3 - Remove the "downloadOpenFile" description element. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 28 Aug 2018 15:36:36 +0100 - rev 492150
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452629 - Part 3 - Remove the "downloadOpenFile" description element. r=mak The "Open File" message is now correctly displayed when hovering the one-pixel-wide clickable area around the action button. Differential Revision: https://phabricator.services.mozilla.com/D4459
de4eb68568a0: Bug 1452629 - Part 2 - Avoid redundant button label elements in the "download" widget. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 28 Aug 2018 15:57:52 +0100 - rev 492149
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452629 - Part 2 - Avoid redundant button label elements in the "download" widget. r=mak Differential Revision: https://phabricator.services.mozilla.com/D4447
58fc7f243f76: Bug 1452629 - Part 1 - Avoid redundant button elements in the "download" widget. r=mak
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 13 Sep 2018 16:16:46 +0100 - rev 492148
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1452629 - Part 1 - Avoid redundant button elements in the "download" widget. r=mak Differential Revision: https://phabricator.services.mozilla.com/D4441