searching for reviewer(mak)
519424ad964e1c825dbfc2bcf7df48b432c806c7: Bug 1675611 - Part 2 - Show tab-to-search onboarding results until they are interacted with three times. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 13 Nov 2020 20:15:16 +0000 - rev 623478
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675611 - Part 2 - Show tab-to-search onboarding results until they are interacted with three times. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96905
3505eb4f3af05cba284e46dccaef52cec8d8558d: Bug 1675611 - Part 1 - Add UrlbarProvider.onSelection. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 13 Nov 2020 20:15:08 +0000 - rev 623477
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675611 - Part 1 - Add UrlbarProvider.onSelection. r=mak Differential Revision: https://phabricator.services.mozilla.com/D97023
56c6cf7f93f9c3405e9aa044639343cf0c552938: Bug 1675045 - Add search mode hostname check to the muxer. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 13 Nov 2020 18:18:57 +0000 - rev 623468
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675045 - Add search mode hostname check to the muxer. r=mak Differential Revision: https://phabricator.services.mozilla.com/D95929
8d1e363aa14acf66d3d0b67ae45a627e0c770cb7: Bug 1676054: The caret position is kept until keyup enter. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Wed, 11 Nov 2020 00:59:59 +0000 - rev 622975
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676054: The caret position is kept until keyup enter. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96505
93e79df17b6269d96f67a784bb54c474634bd51d: Bug 1676398 - browser.urlbar.update2.emptySearchBehavior should only affect search engines in search mode. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 10 Nov 2020 23:18:14 +0000 - rev 622953
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676398 - browser.urlbar.update2.emptySearchBehavior should only affect search engines in search mode. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96616
0a93a065053d33501d5272f5388f6b7919879343: Bug 1652520 - do not overwrite extensions for all filetypes, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 10 Nov 2020 13:59:39 +0000 - rev 622847
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1652520 - do not overwrite extensions for all filetypes, r=mak Differential Revision: https://phabricator.services.mozilla.com/D96406
58d4317c9427190d33004df2632544cc4a8fedeb: Bug 1652520 - do not overwrite extensions for all filetypes, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 10 Nov 2020 12:07:30 +0000 - rev 622830
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1652520 - do not overwrite extensions for all filetypes, r=mak Differential Revision: https://phabricator.services.mozilla.com/D96406
0b8e83a62b1009c14e30166bdc21a9623321f777: Bug 1675976 - Stop recording bogus data for some urlbar.picked.searchmode.* probes. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 09 Nov 2020 19:18:51 +0000 - rev 622741
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675976 - Stop recording bogus data for some urlbar.picked.searchmode.* probes. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96321
834d6bf63d60ec2c005c3a188b5380e1a0661de8: Bug 1675627 - Do not show alias engines in search mode. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 09 Nov 2020 17:59:35 +0000 - rev 622734
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675627 - Do not show alias engines in search mode. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96256
5c2240a8de0beb7b1ea95921a8331bb256b7f59c: Bug 1673299: Change the timing that moves the focus to the browser. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 08 Nov 2020 23:51:44 +0000 - rev 622629
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673299: Change the timing that moves the focus to the browser. r=mak Differential Revision: https://phabricator.services.mozilla.com/D95830
4c449cde60a7ab3c7f305ffec29d56b04487bf43: Bug 1661000: Avoid urlbar search string canonization if ctrl key comes from a previous action. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Sun, 08 Nov 2020 23:34:48 +0000 - rev 622628
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1661000: Avoid urlbar search string canonization if ctrl key comes from a previous action. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93920
f609549255b37493b752afb97ed0aded9c628b7e: Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 06 Nov 2020 09:46:35 +0000 - rev 622427
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r=mak Differential Revision: https://phabricator.services.mozilla.com/D96114
58edeb3eb4e003826cdf59725892b1cebd90c651: Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 05 Nov 2020 21:08:10 +0000 - rev 622400
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1432604 - use the last-used folder for new bookmarks, r=mak Differential Revision: https://phabricator.services.mozilla.com/D94880
6354c3742a1a1fc7840bb507524da587f6446542: Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 06 Nov 2020 00:37:09 +0000 - rev 622399
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak Differential Revision: https://phabricator.services.mozilla.com/D95231
ca3a56aafb99d290939f6ae0b8bb2250de162409: Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 05 Nov 2020 21:08:09 +0000 - rev 622398
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak Differential Revision: https://phabricator.services.mozilla.com/D94879
109da131e1e8582fd7f22519533f43841b7656e2: Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 05 Nov 2020 21:08:40 +0000 - rev 622397
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws This adds a pref containing a parent GUID, a lazy pref getter that validates that GUID (asynchronously), and starts using the pref from the PlacesCommandHook. It also sets the future default (toolbar) into firefox.js, and overrides that on the default branch when the new 2020 bookmarks pref is not set. Finally, it sets the pref to the unfiled default for existing profiles with a migration. If we end up delaying shipping, we'll need to update that migration - but I don't see a way around that. Differential Revision: https://phabricator.services.mozilla.com/D94500
2d95d51679240afa5d4088ef1c1a2b14d86f2563: Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
Jared Wein <jwein@mozilla.com> - Thu, 05 Nov 2020 23:00:47 +0000 - rev 622382
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large. Differential Revision: https://phabricator.services.mozilla.com/D95798
455ff5647429040ea927ab6f50855afb93a156e2: Bug 1432604 - use the last-used folder for new bookmarks, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 04 Nov 2020 23:43:05 +0000 - rev 622338
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1432604 - use the last-used folder for new bookmarks, r=mak Differential Revision: https://phabricator.services.mozilla.com/D94880
cf70da964b70ffde7549161f99f7b77b9a33b35f: Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 05 Nov 2020 18:56:06 +0000 - rev 622337
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1425290 - also default bookmark properties (for keyword search bookmarks and multiple tab bookmarks) to the new default parent, r=mak Differential Revision: https://phabricator.services.mozilla.com/D95231
e6b38d403cc338cc2a347065b3e5d417c24f1019: Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 04 Nov 2020 23:24:35 +0000 - rev 622336
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak Differential Revision: https://phabricator.services.mozilla.com/D94879
09f049232773a7bfefa5822296547b51d083c16e: Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 04 Nov 2020 23:24:27 +0000 - rev 622335
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws This adds a pref containing a parent GUID, a lazy pref getter that validates that GUID (asynchronously), and starts using the pref from the PlacesCommandHook. It also sets the future default (toolbar) into firefox.js, and overrides that on the default branch when the new 2020 bookmarks pref is not set. Finally, it sets the pref to the unfiled default for existing profiles with a migration. If we end up delaying shipping, we'll need to update that migration - but I don't see a way around that. Differential Revision: https://phabricator.services.mozilla.com/D94500
bfe8bc960f45341cbcb3fa837c19b3e3d068035f: Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
Jared Wein <jwein@mozilla.com> - Thu, 05 Nov 2020 19:09:18 +0000 - rev 622332
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large. Differential Revision: https://phabricator.services.mozilla.com/D95798
f522c86c6e17a1fba3a8af3c6bb16845123b82cd: Bug 1665048 - Update telemetry.rst with search mode launch version. r=mak DONTBUILD
Harry Twyford <htwyford@mozilla.com> - Thu, 05 Nov 2020 16:06:24 +0000 - rev 622318
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1665048 - Update telemetry.rst with search mode launch version. r=mak DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D96064
01138b19cd8387b3c383bcca33f0f0e1eb42ad16: Bug 1674469 - Introduce experimental pref that can override urlbar.update2 for a holdback study. r=mak,mikedeboer
Harry Twyford <htwyford@mozilla.com> - Wed, 04 Nov 2020 11:04:36 +0000 - rev 622106
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674469 - Introduce experimental pref that can override urlbar.update2 for a holdback study. r=mak,mikedeboer This default-true pref has no effect when true and overrides update2 when false. This will allow us to set it to true for our Control branch so they will just fall back to the default-true update2 pref. We can set it to false for the Treatment branch, who will not get update2 features regardless of the value of urlbar.update2. We want to uplift this patch to 83. That way, we can set browser.urlbar.experiment.update2 in Release 82, but it will have no effect either way until 83 merges to Release. Differential Revision: https://phabricator.services.mozilla.com/D95806
4cf859c2cad22d26bee38703dd4e5ffa2bb8510e: Bug 1577539: Use fixed uri since the beginning of the loading. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Wed, 04 Nov 2020 00:19:29 +0000 - rev 622002
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1577539: Use fixed uri since the beginning of the loading. r=mak Depends on D93187 Differential Revision: https://phabricator.services.mozilla.com/D94821
693a84154f2f4ae339f23eb6257f877f9cefe900: Bug 1577539: Change the timing of formatting/unformatting the URL. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 02 Nov 2020 15:13:26 +0000 - rev 622001
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1577539: Change the timing of formatting/unformatting the URL. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93187
88621bb93444674721772c53002ea26f23363f0f: Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 30 Oct 2020 11:03:44 +0000 - rev 621526
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak Differential Revision: https://phabricator.services.mozilla.com/D95273
41a57cf5142040cdca243135138351d71d508f23: Bug 1671241 - Set aria-activedescendant upon selecting a tab-to-search result if the user previously selected the tab-to-search result. r=mak
Harry Twyford <htwyford@mozilla.com> - Fri, 30 Oct 2020 12:43:07 +0000 - rev 621488
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671241 - Set aria-activedescendant upon selecting a tab-to-search result if the user previously selected the tab-to-search result. r=mak Differential Revision: https://phabricator.services.mozilla.com/D95214
38d90ab9f206e9db79d00c49f0b393605b542447: Bug 1639552 - Use ObfuscatingVFS if a URL containing a key is specified. r=dom-workers-and-storage-reviewers,mak,janv
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 29 Oct 2020 10:13:59 +0000 - rev 621335
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1639552 - Use ObfuscatingVFS if a URL containing a key is specified. r=dom-workers-and-storage-reviewers,mak,janv Differential Revision: https://phabricator.services.mozilla.com/D76172
2696dc0a1292466927deee3321d55aafaeabb82a: Bug 1639552 - Register ObfuscatingVFS. r=dom-workers-and-storage-reviewers,mak,janv
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 29 Oct 2020 10:13:46 +0000 - rev 621334
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1639552 - Register ObfuscatingVFS. r=dom-workers-and-storage-reviewers,mak,janv Differential Revision: https://phabricator.services.mozilla.com/D76147
51001c4cc73f6183f66eb6d986116155f35347f7: Bug 1671803 - Part 2 - Add localized name for Baidu's OpenSearch engine to WEB_ENGINE_NAMES. r=mak
Harry Twyford <htwyford@mozilla.com> - Tue, 27 Oct 2020 14:21:10 +0000 - rev 621025
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671803 - Part 2 - Add localized name for Baidu's OpenSearch engine to WEB_ENGINE_NAMES. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94838
9f165b9c934f5a309e4ac6d7cb320b6dca0f834a: Bug 1673062 - Fix intermittent TV browser/components/urlbar/tests/browser/browser_tokenAlias.js by increasing the timeout. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 26 Oct 2020 23:12:56 +0000 - rev 620854
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673062 - Fix intermittent TV browser/components/urlbar/tests/browser/browser_tokenAlias.js by increasing the timeout. r=mak The log shows that the last test task finishes, so it looks like the test is now just taking too long on these Mac machines in verify mode. That's plausible because I added a bunch of new checks in bug 1672680 (checking for different types of space characters). Green try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a320a06d40ddacfc76abc6cf097b11a959228c61&selectedTaskRun=Geg2Cpj5Q16A4-KuYuegyw.0 Differential Revision: https://phabricator.services.mozilla.com/D94665
61283442e9fe37fa0595c4b9f17f00182d69a421: Bug 699844 - Remove the Bookmarks annotations service API. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 26 Oct 2020 12:32:55 +0000 - rev 620771
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 699844 - Remove the Bookmarks annotations service API. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93315
413a70305cc689eb203f9bfb461a15415aea075c: Bug 699844 - Remove the live bookmark migrator as it is not needed now. r=mak,markh
Mark Banner <standard8@mozilla.com> - Mon, 26 Oct 2020 12:32:52 +0000 - rev 620770
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 699844 - Remove the live bookmark migrator as it is not needed now. r=mak,markh Differential Revision: https://phabricator.services.mozilla.com/D93314
be354ee427d01400963bf0086058b63b9dfadc09: Bug 1641287: Focus on browser after keyup. r=mak
Daisuke Akatsuka <daisuke@birchill.co.jp> - Mon, 26 Oct 2020 05:30:44 +0000 - rev 620637
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1641287: Focus on browser after keyup. r=mak Differential Revision: https://phabricator.services.mozilla.com/D92561
7d86a83672c5a74ae17f5f9141babb1c25293a89: Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 23 Oct 2020 13:49:20 +0000 - rev 620532
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak This fixes all the problems created by bug 1658964 and modifies existing tests so we check a variety of spaces. Differential Revision: https://phabricator.services.mozilla.com/D94555
5edc54d87ce82ee7866c30fd08225f21025ed755: Bug 1672643 - Do not show form history (search suggestions from history) at all when browser.urlbar.maxHistoricalSearchSuggestions == 0. r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 22 Oct 2020 22:25:12 +0000 - rev 620407
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672643 - Do not show form history (search suggestions from history) at all when browser.urlbar.maxHistoricalSearchSuggestions == 0. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94504
81801ba1e2cf64a98d7e632d444310e92b08700b: Bug 1670356 - use case insensitive comparisons when checking Windows executables, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Oct 2020 11:24:41 +0000 - rev 620132
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1670356 - use case insensitive comparisons when checking Windows executables, r=mak Differential Revision: https://phabricator.services.mozilla.com/D93852
2769479fb1a29a2826023045bbf531c63aa0e4ea: Bug 1671045 - Fix intermittent in browser_searchMode_sessionStore.js by requesting a longer timeout and disabling on Mac debug. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 20 Oct 2020 21:06:11 +0000 - rev 619984
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671045 - Fix intermittent in browser_searchMode_sessionStore.js by requesting a longer timeout and disabling on Mac debug. r=mak This test times out on macOS 10.14 opt and debug. Logs show that the test finishes properly but it exceeds the timeout threshold, so it appears that it just takes too long. Increasing the timeout threshold fixes the problem on opt, but it reveals another problem on debug where the watchdog process kills the main process because its shutdown lasts too long. This happens during step 3 of test-verify, which is "Run each test 10 times in one browser, in chaos mode." Around the time that the crash happens, logs show that there are "2047 DOMWINDOW created and 2037 destroyed log strings." The test opens, closes, and reopens many windows -- with chaos mode on top of that -- so it's possible that debug window instrumentation or just the debug nature of the build itself, plus slow machines, causes all the window opening and closing to perform very poorly and take a long time. This patch increases the timeout, which fixes opt, and disables the test entirely on debug -- and to reiterate, it's Mac only. Maybe the test could open and close tabs instead of windows in order to test session store, but I'm not sure it's worth rewriting. Here's a successful try run with an earlier version of this patch that did not disable the test on debug, but it shows that opt is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ab33a9225b9edf0cb8a95d556f9b76c7fc69470 And here's a run without the patch that shows opt is always orange: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e02bfc26ecb67f503cb24a180536e8c220226d5 Differential Revision: https://phabricator.services.mozilla.com/D94069
a3815d601038dc3b8103224a5da4d6fa76aea511: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 20 Oct 2020 20:35:26 +0000 - rev 619977
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
ff2ad4b3e863195075076107dc008bf248da9a91: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 20 Oct 2020 12:05:10 +0000 - rev 619925
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
6c5473b9d35095bda629a2b58f529c3e1f37c4a2: Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 19 Oct 2020 18:33:51 +0000 - rev 619734
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94012
19f174844357ed8d5ae122082e929b0ebc0b9afe: Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 19 Oct 2020 16:14:13 +0000 - rev 619732
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak This changes two bits of Firefox that, together with the mime service, end up very confused over webp + jpeg. 1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image mimetype as the content type, it should ignore the URL. It doesn't have full channel info so it can't really do better anyway. This fixes the context menu's "save image as..." case. 2) it changes the external helper app service to do a few things slightly differently: a. If we're told not to get an extension out of a URL, really don't. Don't just get the filename and then get it from there anyway... b. If we've got a suggested filename, and a primary extension for the mimetype, and the extension on the file is not one of the known extensions for the mimetype, replace it with the primary extension. This fixes the link case. It also adds tests for both of these mechanisms as well as "save image as." Differential Revision: https://phabricator.services.mozilla.com/D92306
cc5b59f193168024c08ba046f95bef975d8572a2: Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak
Jared Wein <jwein@mozilla.com> - Mon, 19 Oct 2020 16:52:32 +0000 - rev 619714
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1597084 - Set the image attribute on the bookmark-items in the toolbar when creating them to prevent flickering of the default favicon. r=mak Differential Revision: https://phabricator.services.mozilla.com/D93301
73e461c6ee8d400dcd1ba402b15b82893e69f7b4: Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak
Harry Twyford <htwyford@mozilla.com> - Mon, 19 Oct 2020 15:05:09 +0000 - rev 619702
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671803 - Add localized names for Baidu and Yandex to WEB_ENGINE_NAMES. r=mak Differential Revision: https://phabricator.services.mozilla.com/D94012
040da1001430825ab03e2d23795c5bd19392482c: Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r=mak, a=pascal
Harry Twyford <htwyford@mozilla.com> - Fri, 06 Nov 2020 09:46:35 +0000 - rev 619585
Push 14593 by ryanvm@gmail.com at Sat, 07 Nov 2020 13:50:59 +0000
Bug 1675622 - Show tab-to-search onboarding results more frequently in Firefox 83. r=mak, a=pascal Differential Revision: https://phabricator.services.mozilla.com/D96114
c8ce1c06779b654b3307a1f080cdf1816466790f: Bug 1674469 - Introduce experimental pref that can override urlbar.update2 for a holdback study. r=mak,mikedeboer, a=pascalc
Harry Twyford <htwyford@mozilla.com> - Wed, 04 Nov 2020 11:04:36 +0000 - rev 619523
Push 14547 by jcristau@mozilla.com at Thu, 05 Nov 2020 10:46:16 +0000
Bug 1674469 - Introduce experimental pref that can override urlbar.update2 for a holdback study. r=mak,mikedeboer, a=pascalc This default-true pref has no effect when true and overrides update2 when false. This will allow us to set it to true for our Control branch so they will just fall back to the default-true update2 pref. We can set it to false for the Treatment branch, who will not get update2 features regardless of the value of urlbar.update2. We want to uplift this patch to 83. That way, we can set browser.urlbar.experiment.update2 in Release 82, but it will have no effect either way until 83 merges to Release. Differential Revision: https://phabricator.services.mozilla.com/D95806
d56a5f8353e890e7d684887fc06616bea8f20dd6: Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak, a=pascalc
Dão Gottwald <dao@mozilla.com> - Fri, 30 Oct 2020 11:03:44 +0000 - rev 619462
Push 14513 by jcristau@mozilla.com at Tue, 03 Nov 2020 11:49:57 +0000
Bug 1672997 - Display separator before "Sponsored" top site label in narrow window. r=mak, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D95273
fced8a3a6496c9df9ff2f752b8fc1a33f42d6b49: Bug 1671803 - Part 2 - Add localized name for Baidu's OpenSearch engine to WEB_ENGINE_NAMES. r=mak, a=pascalc
Harry Twyford <htwyford@mozilla.com> - Tue, 27 Oct 2020 14:21:10 +0000 - rev 619459
Push 14513 by jcristau@mozilla.com at Tue, 03 Nov 2020 11:49:57 +0000
Bug 1671803 - Part 2 - Add localized name for Baidu's OpenSearch engine to WEB_ENGINE_NAMES. r=mak, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D94838
9f4696b061acad498993cd77c1bbd0d3dbab7c97: Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak, a=pascal
Drew Willcoxon <adw@mozilla.com> - Fri, 23 Oct 2020 13:49:20 +0000 - rev 619321
Push 14416 by ryanvm@gmail.com at Tue, 27 Oct 2020 17:14:12 +0000
Bug 1672680 - Properly handle non-ASCII spaces in search alias and restriction token searches. r=mak, a=pascal This fixes all the problems created by bug 1658964 and modifies existing tests so we check a variety of spaces. Differential Revision: https://phabricator.services.mozilla.com/D94555