searching for reviewer(mak)
5abddba6d262: Bug 1439396, r=mak a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Feb 2018 12:18:40 +0000 - rev 452508
Push 8746 by archaeopteryx@coole-files.de at 2018-02-21 23:43 +0000
Bug 1439396, r=mak a=RyanVM
5924d4660bad: Bug 1420714 - fix favicon fetching in reader mode, r=mak a=RyanVM
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 30 Jan 2018 15:13:23 +0000 - rev 452246
Push 8666 by apavel@mozilla.com at 2018-02-07 18:57 +0000
Bug 1420714 - fix favicon fetching in reader mode, r=mak a=RyanVM MozReview-Commit-ID: KZFoKNqVPPy
e83f82bb9962: Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened. r=mak, a=RyanVM
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 30 Jan 2018 14:38:25 +0000 - rev 452204
Push 8651 by ryanvm@gmail.com at 2018-02-05 20:15 +0000
Bug 1424469 - The Downloads view in the Library window doesn't get focus when opened. r=mak, a=RyanVM We have to keep track of the focused element while we remove the richlistbox element temporarily. MozReview-Commit-ID: AePydUyyUS7
7a901ba2676d: Bug 1404253 - Disable places' bookmarks backups in mochitests to avoid intermittent failures. r=mak, a=test-only
Mark Banner <standard8@mozilla.com> - Mon, 29 Jan 2018 15:50:44 +0000 - rev 452154
Push 8633 by ryanvm@gmail.com at 2018-02-01 17:14 +0000
Bug 1404253 - Disable places' bookmarks backups in mochitests to avoid intermittent failures. r=mak, a=test-only MozReview-Commit-ID: 53TipklHXxX
84a24eb373fa: Bug 1432263 - Make matchBuckets string parsing the same everywhere it's done. r=mak, a=lizzard
Drew Willcoxon <adw@mozilla.com> - Mon, 22 Jan 2018 11:21:55 -0800 - rev 452045
Push 8586 by ryanvm@gmail.com at 2018-01-25 02:57 +0000
Bug 1432263 - Make matchBuckets string parsing the same everywhere it's done. r=mak, a=lizzard MozReview-Commit-ID: GmGCHl4RtWB
b59b5e6e7070: Bug 1431489 - Follow-up fix: Allow users to choose whether search suggestions or history suggestions come first in the address bar. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 19 Jan 2018 11:35:26 -0800 - rev 451914
Push 8563 by ryanvm@gmail.com at 2018-01-21 14:49 +0000
Bug 1431489 - Follow-up fix: Allow users to choose whether search suggestions or history suggestions come first in the address bar. r=mak MozReview-Commit-ID: 7t1Co8JxA8O
a8ec51e616a7: Bug 1430318 - Fix getLastUsedDate bugs from using typedURLs r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 17 Jan 2018 11:15:27 -0800 - rev 451845
Push 8563 by ryanvm@gmail.com at 2018-01-21 14:49 +0000
Bug 1430318 - Fix getLastUsedDate bugs from using typedURLs r=mak getLastUsedDate should be converting the microseconds of typedURLs into milliseconds. MozReview-Commit-ID: DjJKm5aPcGD
e83e039a4803: Bug 1430318 - Prevent zeroes Edge history timestamps from breaking import r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 16 Jan 2018 11:08:21 -0800 - rev 451844
Push 8563 by ryanvm@gmail.com at 2018-01-21 14:49 +0000
Bug 1430318 - Prevent zeroes Edge history timestamps from breaking import r=mak Edge history visit times can be zero. Not sure of exactly what conditions cause this, but the Edge start page has a visit time of 0 on a local machine. MozReview-Commit-ID: KJ9iwbLIhj2
9e512081bde6: Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Wed, 17 Jan 2018 09:13:47 -0800 - rev 451699
Push 8560 by ryanvm@gmail.com at 2018-01-19 16:34 +0000
Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak MozReview-Commit-ID: 8Uk1Vuqc1lc
410a941bdce8: Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Wed, 17 Jan 2018 09:13:47 -0800 - rev 451685
Push 8560 by ryanvm@gmail.com at 2018-01-19 16:34 +0000
Bug 1431149 - Add an optional schema name argument to `OpenedConnection#{get, set}SchemaVersion`. r=mak MozReview-Commit-ID: 8Uk1Vuqc1lc
4d423fdc33dd: Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 16 Jan 2018 16:20:14 -0800 - rev 451547
Push 8558 by ryanvm@gmail.com at 2018-01-19 15:34 +0000
Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function. r=mak MozReview-Commit-ID: GgNiyRWKpEL
eac8b4f5f6b6: Bug 1430573 - Bump the Sync change counter for items with renamed untitled tags. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Tue, 16 Jan 2018 15:27:20 -0800 - rev 451500
Push 8554 by ryanvm@gmail.com at 2018-01-17 22:21 +0000
Bug 1430573 - Bump the Sync change counter for items with renamed untitled tags. r=mak MozReview-Commit-ID: IVzLpZEZ0tQ
f228865f492c: Bug 1421703 - Fix tests to use onVisits r=mak
Doug Thayer <dothayer@mozilla.com> - Thu, 14 Dec 2017 16:55:31 -0600 - rev 450376
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421703 - Fix tests to use onVisits r=mak Fairly straightforward. Fixes the tests that were broken due to the changes introduced in part 1. MozReview-Commit-ID: GbZ9ZpmG9nE
a542159042f5: Bug 1421703 - replace onVisit with onVisits r=mak
Doug Thayer <dothayer@mozilla.com> - Wed, 20 Dec 2017 14:27:24 -0800 - rev 450375
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421703 - replace onVisit with onVisits r=mak There's a heavy enough overhead to going through XPConnect for every observer for every visit on the nsINavHistoryObserver interface, so this patch reduces that by replacing the single- visit notification with one which accepts an array of visits. Some notes: To avoid problems with the orderings of the various ways in which we notify about visits, we have to send our bulk onVisits notification before doing any of the others. This does mean it technically behaves slightly different than the prior approach of interleaving the notifications, but I can't find any way in which this has any consequences to the end result, and it doesn't break any tests. MozReview-Commit-ID: GdeooH8mCkg
440dbdb51f94: Bug 1426216 - Allow users to choose whether search suggestions or history suggestions come first in the address bar. r=mak,past
Drew Willcoxon <adw@mozilla.com> - Wed, 10 Jan 2018 08:41:16 -0800 - rev 450337
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1426216 - Allow users to choose whether search suggestions or history suggestions come first in the address bar. r=mak,past MozReview-Commit-ID: HVWRyEu19Dv
98722ab8c2f6: Bug 888784 - Get rid of dead mozIStorageService code in FormHistory.jsm. r=mak
Mike Conley <mconley@mozilla.com> - Fri, 01 Dec 2017 14:55:24 -0500 - rev 450180
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Get rid of dead mozIStorageService code in FormHistory.jsm. r=mak MozReview-Commit-ID: XLOFLpMsPv
d92599272745: Bug 888784 - Make FormHistory.expireOldEntries use new Sqlite.jsm database backend. r=mak
Mike Conley <mconley@mozilla.com> - Fri, 01 Dec 2017 14:54:02 -0500 - rev 450179
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Make FormHistory.expireOldEntries use new Sqlite.jsm database backend. r=mak MozReview-Commit-ID: KSaWz0s6hF1
67c58cb32ac9: Bug 888784 - Make FormHistory.getAutoCompleteResults use Sqlite.jsm backend. r=mak
Mike Conley <mconley@mozilla.com> - Fri, 01 Dec 2017 10:53:32 -0500 - rev 450178
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Make FormHistory.getAutoCompleteResults use Sqlite.jsm backend. r=mak MozReview-Commit-ID: 7rYj1lMosLW
46fb8f82f2bf: Bug 888784 - Get rid of FormHistory.shutdown. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 18:11:18 -0500 - rev 450177
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Get rid of FormHistory.shutdown. r=mak FormHistory.shutdown was called via FormHistoryStartup.js's profile-before-change observer to close the database synchronously. Now FormHistory uses AsyncShutdown and closes the database asynchronously, so FormHistory.shutdown is no longer required. MozReview-Commit-ID: Lok5vx1dOTW
73ad820d09ec: Bug 888784 - Make FormHistory.update use Sqlite.jsm database backend. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 18:09:54 -0500 - rev 450176
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Make FormHistory.update use Sqlite.jsm database backend. r=mak MozReview-Commit-ID: 7Ku1kFtTYZK
18d185fa362e: Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 17:00:07 -0500 - rev 450175
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Remove FormHistory.getSchemaVersion and update some tests that used it to use add_task. r=mak MozReview-Commit-ID: EQBksMqeNm2
10c472d10264: Bug 888784 - Make FormHistory.search use Sqlite.jsm database backend. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 15:15:10 -0500 - rev 450174
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Make FormHistory.search use Sqlite.jsm database backend. r=mak MozReview-Commit-ID: J1ElTJpWHza
51fb50c1ea68: Bug 888784 - Make FormHistory.count use Sqlite.jsm database backend. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 14:28:13 -0500 - rev 450173
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Make FormHistory.count use Sqlite.jsm database backend. r=mak MozReview-Commit-ID: 53gec0qQL1y
80a207ed79ec: Bug 888784 - Add a new Sqlite.jsm based database connector to FormHistory.jsm. r=mak
Mike Conley <mconley@mozilla.com> - Thu, 30 Nov 2017 14:03:04 -0500 - rev 450172
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 888784 - Add a new Sqlite.jsm based database connector to FormHistory.jsm. r=mak MozReview-Commit-ID: JADYzdAokVJ
5323dfb26361: Bug 1407085 - nsAutoCompleteController shouldn't restore original value after somebody changes the input value even when Escape key is pressed r=mak
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 19 Dec 2017 16:46:20 +0900 - rev 450129
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1407085 - nsAutoCompleteController shouldn't restore original value after somebody changes the input value even when Escape key is pressed r=mak When Escape key is pressed, nsAutoCompleteController needs to restore last string which was default value of the input or typed by the user. However, somebody may change the value, e.g., an event listener which handles Escape key. In this case, nsAutoCompleteController shouldn't restore the last string. Unfortunately, when JS sets input value, DOM "input" event won't be fired. Therefore, nsAutoCompleteController doesn't have a chance to modify mSearchString in this case. Therefore, nsAutoCompleteController needs to store expected input string for checking if somebody modified the input value. For solving this issue, this patch adds a new member, mSetValue which is modified when the input value is modified by nsAutoCompleteController itself or mSearchString is modified. Even with this patch, if user temporarily selects an item of the popup and JS sets same value as the selected item from JS, nsAutoCompleteController restores the input value with mSearchString. However, this must be rare case and I don't have idea to fix this issue with simple patches. MozReview-Commit-ID: lig8c7xvD7
dd18db6ffcb0: Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 08 Jan 2018 13:42:53 +0000 - rev 450019
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1428760 - Tidy up browser_bookmarkProperties_*.js tests and stop using some obsolete APIs. r=mak MozReview-Commit-ID: 40PbcRNNPH6
cd0a659c0263: Bug 1409291 - Provide bug number and owner for the LINK_ICON_SIZES_ATTR_ probes. r=mak
Panagiotis Astithas <pastith@gmail.com> - Fri, 05 Jan 2018 16:59:42 -0800 - rev 449955
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1409291 - Provide bug number and owner for the LINK_ICON_SIZES_ATTR_ probes. r=mak
99f4d3702ed6: Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 21 Dec 2017 09:16:48 +0000 - rev 449609
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak MozReview-Commit-ID: 9ZMA2A879O8
5b21cd9021a7: Bug 1362425 - Remove unused browser/app/profile/pagethemes.rdf. r=mak
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 04 Jan 2018 00:37:11 +0100 - rev 449601
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1362425 - Remove unused browser/app/profile/pagethemes.rdf. r=mak MozReview-Commit-ID: 3ubOgBDMDwk
ed1d0d623ca4: Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 21 Dec 2017 09:16:48 +0000 - rev 449518
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak MozReview-Commit-ID: 9ZMA2A879O8
d64cd605dc2f: Bug 1362425 - Remove unused browser/app/profile/pagethemes.rdf. r=mak
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 04 Jan 2018 00:37:11 +0100 - rev 449510
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1362425 - Remove unused browser/app/profile/pagethemes.rdf. r=mak MozReview-Commit-ID: 3ubOgBDMDwk
21bc5f64c339: Bug 1421212 - Remove RESULTS_AS_FULL_VISIT. r=mak
ayus <aayusht4736@gmail.com> - Fri, 15 Dec 2017 21:31:31 +0530 - rev 448582
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421212 - Remove RESULTS_AS_FULL_VISIT. r=mak
2254a714e53d: Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak
Mark Banner <standard8@mozilla.com> - Thu, 14 Dec 2017 13:56:26 -0600 - rev 448326
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak MozReview-Commit-ID: LmZ7AYXBsJ4
6ab3ab7f0aa9: Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak
Mark Banner <standard8@mozilla.com> - Wed, 08 Nov 2017 15:32:51 +0000 - rev 448301
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak MozReview-Commit-ID: B6Bt8bHhh3e
15a13cdc34d5: Bug 1421701 - Chunk visits when notifying main thread r=mak
Doug Thayer <dothayer@mozilla.com> - Mon, 04 Dec 2017 13:46:10 -0800 - rev 448261
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421701 - Chunk visits when notifying main thread r=mak Since processing several hundred visits synchronously on the main thread can be somewhat expensive, and since the main thread might be idle while the storage worker is running, it makes sense to chunk the messages into groups of 100. We did have a concern that this changes the move of the underlying array to a copy, which might bring some cost with it. For small arrays, we simply move the underlying array to avoid the copy to mitigate it. However, for large arrays I was unable to observe any significant performance cost anyway, so I think we're in the clear. MozReview-Commit-ID: 1hWSEyKw6pi
3325c31e498c: Bug 1423247 - Couple Awesome Bar Composition (matchBuckets pref) to user's Address bar state (unified vs. 2 bar). r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 14 Dec 2017 14:14:10 -0800 - rev 448260
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1423247 - Couple Awesome Bar Composition (matchBuckets pref) to user's Address bar state (unified vs. 2 bar). r=mak MozReview-Commit-ID: LZIWVcDvMrK
8cbcc8b4fa57: Bug 1421704 - Optimize NotifyVisited IPC to take batch r=mak
Doug Thayer <dothayer@mozilla.com> - Mon, 04 Dec 2017 09:45:29 -0800 - rev 448200
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421704 - Optimize NotifyVisited IPC to take batch r=mak During history import, sending NotifyVisited messages from the chrome process to the content processes in order to change link colors can take a significant portion of the parent process's main thread time. Batching it seems to have very significant results on jank time during history imports. MozReview-Commit-ID: BHAXpIMa7ly
c4087b735507: Bug 1424672 - stop removing the header in the recently closed places views, r=mak,Paolo
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 12 Dec 2017 16:20:49 -0600 - rev 447949
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1424672 - stop removing the header in the recently closed places views, r=mak,Paolo MozReview-Commit-ID: J5HlyA8nxe2
d1f8af3283ae: Bug 1423820 - Copy temp entities after reattaching databases to a cloned storage connection. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Wed, 06 Dec 2017 22:34:18 -0800 - rev 447938
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1423820 - Copy temp entities after reattaching databases to a cloned storage connection. r=mak MozReview-Commit-ID: illWRvUv3Y
1b381ddb9779: Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 07 Dec 2017 12:25:33 +0100 - rev 447282
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1423647 - Restore border-radius for buttons in the Downloads View in the Library. r=mak MozReview-Commit-ID: 6kkdp8pHAlv
49358c06a122: Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 04 Dec 2017 15:24:02 -0800 - rev 447115
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak MozReview-Commit-ID: C3tmqIrt5ak
8312a6286023: Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 04 Dec 2017 15:24:02 -0800 - rev 446812
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak MozReview-Commit-ID: C3tmqIrt5ak
87305b25064e: Bug 1422289 - ContentLinkHandler should guess icon type from the extension when type is not defined. r=mak
Ed Lee <edilee@mozilla.com> - Fri, 01 Dec 2017 14:11:08 -0800 - rev 446703
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422289 - ContentLinkHandler should guess icon type from the extension when type is not defined. r=mak MozReview-Commit-ID: HfuqudW77jM
a414ba996915: Bug 1422724 - Remove items that are no longer in PlacesUtils.jsm from ESLint's module.json list. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 04 Dec 2017 12:09:44 +0000 - rev 446659
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422724 - Remove items that are no longer in PlacesUtils.jsm from ESLint's module.json list. r=mak MozReview-Commit-ID: IkbT2Vz65FJ
48e74a9e3496: Bug 1422724 - Remove unused constants in Places' controller.js. r=mak
Mark Banner <standard8@mozilla.com> - Mon, 04 Dec 2017 12:09:03 +0000 - rev 446658
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422724 - Remove unused constants in Places' controller.js. r=mak MozReview-Commit-ID: AWTTksnPUp8
cc8eaa26f2ed: Bug 1422383 - Clone temporary tables, views, and triggers when cloning a storage connection. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Thu, 30 Nov 2017 19:21:10 -0800 - rev 446657
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1422383 - Clone temporary tables, views, and triggers when cloning a storage connection. r=mak MozReview-Commit-ID: HwVMvvn7cui
dd84a4ad910e: Bug 1417101 - Remove the annotation observer from the bookmarks service. r=mak
Kit Cambridge <kit@yakshaving.ninja> - Thu, 16 Nov 2017 16:49:03 -0800 - rev 446656
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1417101 - Remove the annotation observer from the bookmarks service. r=mak Since `SetItemAnnotation` already queries `moz_bookmarks`, we can fetch and pass the changed bookmark's info directly to `nsNavBookmarks::NotifyItemChanged`, without going through the anno observer. This patch refactors the internal `Set*` methods to receive an optional `BookmarkData` for item annotation changes, and fire `OnItemChanged` notifications after notifying anno observers. `NotifyItemChanged` also updates the bookmark's last modified time if requested. MozReview-Commit-ID: Hz5qiOmAjsD
92f6d93364b6: Bug 1418443 - Send OnVisit notifications from single runnable r=mak
Doug Thayer <dothayer@mozilla.com> - Tue, 21 Nov 2017 14:43:47 -0800 - rev 446453
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1418443 - Send OnVisit notifications from single runnable r=mak Because there's an overhead in simply creating/sending/receiving a runnable, it makes sense to send our onVisits notifications from a bulk runnable in the case where we're inserting many visits. This is only step one of many optimizations we can and should make to the observer system. MozReview-Commit-ID: Co5yOUCRdnZ
c6402ba8ee6d: Bug 1421119 - Wait for the next event tick before resolving promise in browser_check_correct_controllers.js. r=mak
Tooru Fujisawa <arai_a@mac.com> - Fri, 01 Dec 2017 10:05:47 +0900 - rev 446313
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421119 - Wait for the next event tick before resolving promise in browser_check_correct_controllers.js. r=mak
efd54930bcdf: Bug 1421115 - Wait for the next event tick before resolving promise in places tests. r=mak
Tooru Fujisawa <arai_a@mac.com> - Fri, 01 Dec 2017 10:05:47 +0900 - rev 446310
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1421115 - Wait for the next event tick before resolving promise in places tests. r=mak