searching for reviewer(longsonr)
0118148f15342961169411101578d60e8eef1ef3: Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:55:53 +0000 - rev 532853
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Add reftest for rect, circle, ellipse and foreignObject r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30807
447c9248342b3ab04801d4684013042140085b23: Bug 1383650 - Use CSS to layout foreignObject r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:55:25 +0000 - rev 532852
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Use CSS to layout foreignObject r=longsonr Should also update layout code for foreignObject to use CSS geometry property. Differential Revision: https://phabricator.services.mozilla.com/D30806
6730776560c028a402e7112569e6ca8bf6cd742b: Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:54:46 +0000 - rev 532851
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Optimize attribute mapping by not parsing same thing twice r=longsonr Geometry properties are the most used SVG attributes. When authors specify them as attributes, we have to parse them in SVG side. So we don't want to parse them in CSS side again, otherwise the introduced performance loss is relatively high. With this optimization, this feature implementation doesn't slow down overall performace even if there are thousands of geometry elements. Differential Revision: https://phabricator.services.mozilla.com/D30778
a7b8e6460fb8b1245507e9e15deadc1e62674102: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:58:56 +0000 - rev 532850
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361
e864696f6cf80910479dce91eed090a6455a4e2f: Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:53:45 +0000 - rev 532849
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Add conversion utilities to get CSS counterpart of SVG unit and AttrEnum r=longsonr We need some utilities to convert SVG unit and attrenum to CSS unit and property id. This is useful when we need to pass parsed geometry property directly to CSS. Differential Revision: https://phabricator.services.mozilla.com/D30777
7bc3bff991c45a6e9caefe5fb4791aeba7d29256: Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:50:15 +0000 - rev 532847
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Invalidate path cache when geometry changed via CSS r=longsonr We cached the path of an element. Previously we only need to invalidate the cached path if an geometry attribute is changed. Now we also need to invalidate if the corresponding CSS is changed. Differential Revision: https://phabricator.services.mozilla.com/D30472
f1f7b4ad95474592279f9d5f9e337ce94240bdbd: Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:47:37 +0000 - rev 532846
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Resolve SVG geometry metrics from CSS r=longsonr,emilio This patch makes SVG retrieve metrics from CSS style. It doesn't handle <svg> element because geometry properties for outer <svg> element has been partially implemented long ago, it needs special change. It doesn't deal with the impact on SMIL. Differential Revision: https://phabricator.services.mozilla.com/D29992
18b030b3166027a1a1e3d35ed779bdc4d7c6ab85: Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 00:47:24 +0000 - rev 532845
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1383650 - Map SVG geometry attributes to CSS r=longsonr This patch maps SVG geometry attributes to CSS property, so that the values set via SVG attribute will be known by CSS. It doesn't deal with how the value is used. Differential Revision: https://phabricator.services.mozilla.com/D29960
027695189d656e036946b9774921fb8e2e09a1f8: Bug 1551137 - <svg:mpath> should work in Shadow DOM. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 13 May 2019 17:28:59 +0000 - rev 532456
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1551137 - <svg:mpath> should work in Shadow DOM. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D30894
3ce2113ec6925b3eb9f204f7175549f74cac6fc4: Bug 1133175 - Remove SVGTests.hasExtension. r=bz,longsonr
Cameron McCormack <cam@mcc.id.au> - Thu, 09 May 2019 14:39:28 +1000 - rev 532043
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1133175 - Remove SVGTests.hasExtension. r=bz,longsonr
6c00dab7137aabe0a86b9d64f567383dd2b81635: Bug 608812 - Add blurry reftest r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 02 May 2019 20:51:55 +0000 - rev 531211
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 608812 - Add blurry reftest r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D29621
75abef5719a78cabd33c64c2153a629355795713: Bug 608812 - Remove a bunch of WPT meta files that are no longer valid r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 02 May 2019 01:23:12 +0000 - rev 531034
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 608812 - Remove a bunch of WPT meta files that are no longer valid r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D29366
3dddcde1fde6ead64c93416de4f6d7af0157d5c3: Bug 608812 - Should snap subpixel value for outer svg and anon child r=longsonr
violet <violet.bugreport@gmail.com> - Wed, 01 May 2019 17:53:32 +0000 - rev 531033
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 608812 - Should snap subpixel value for outer svg and anon child r=longsonr We should snap subpixel value at nsDisplayTransform::GetResultingTransformMatrix for outer svg and the anon child. This will solve blurry rendering for subpixel position when webrender is __not__ enabled. Differential Revision: https://phabricator.services.mozilla.com/D29344
90c4bb8c0d5cb33135e4229c982f746bc1aa9ee7: Bug 1372537 - display:none of symbol should be important r=longsonr,emilio
violet <violet.bugreport@gmail.com> - Mon, 29 Apr 2019 00:20:30 +0000 - rev 530525
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1372537 - display:none of symbol should be important r=longsonr,emilio Differential Revision: https://phabricator.services.mozilla.com/D29099
2c949afac54e02d3e11c78c80d0b3c8c5cd7091f: Bug 1547209 - Compute transform matrix directly in nsSVGUtils::GetTransformMatrixInUserSpace r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 27 Apr 2019 07:22:53 +0000 - rev 530456
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547209 - Compute transform matrix directly in nsSVGUtils::GetTransformMatrixInUserSpace r=longsonr Since now most CSS transform related bugs are fixed, it's clear that the purpose of nsSVGUtils::GetTransformMatrixInUserSpace() should solely be to replace SVGElement::PrependLocalTransformsTo(eUserSpaceToParent). After fixing Bug 972041, the only other usecase (Bug 1247218) no longer exists. OTOH, there is a problem when the parent has a viewbox transform, in that case, SVGElement::PrependLocalTransformsTo() doesn't include it, but nsLayoutUtils::GetTransformToAncestor() does. In fact, it's much easier to compute the transform matrix directly based on the implementation of nsDisplayTransform::GetResultingTransformMatrixInternal(), which is also the function internally called by nsLayoutUtils::GetTransformToAncestor(). In particular, we don't need to look at 3D stuff since our matrix is inherently 2D. Differential Revision: https://phabricator.services.mozilla.com/D28970
bbd172d048d70b795867273c09ed7aec32c4d799: Bug 972041 - getCTM should account for CSS transform r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 27 Apr 2019 08:42:51 +0000 - rev 530455
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 972041 - getCTM should account for CSS transform r=longsonr We use nsSVGUtils::GetTransformMatrixInUserSpace to support CSS transform in getCTM. Differential Revision: https://phabricator.services.mozilla.com/D28969
54dcd30fb687720d349337ec93817a6ccb2d1079: Bug 1546636 - Should consider geometry box type r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 25 Apr 2019 19:56:15 +0000 - rev 530227
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546636 - Should consider geometry box type r=longsonr Geometry box was implemented long ago in Bug 1289011. But during some refactoring, the existence of geometry box was overlooked. We add back its support. Differential Revision: https://phabricator.services.mozilla.com/D28815
2a3c00a2d76186a205fd4e6d0496c28748cb2f3a: Bug 1533491 - nsCSSClipPathInstance::ApplyBasicShapeOrPathClip should consider transform r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 25 Apr 2019 00:52:25 +0000 - rev 530051
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533491 - nsCSSClipPathInstance::ApplyBasicShapeOrPathClip should consider transform r=longsonr nsSVGUtils::PaintFrameWithEffects needs to pass its transform to nsCSSClipPathInstance::ApplyBasicShapeOrPathClip so that the latter can compute the correct box. Differential Revision: https://phabricator.services.mozilla.com/D28655
0ebd471a1242aa288662526da42ab6ada428e45b: Bug 1073207 - getScreenCTM should account for padding and border for outer svg r=longsonr
violet <violet.bugreport@gmail.com> - Tue, 23 Apr 2019 18:15:57 +0000 - rev 529397
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1073207 - getScreenCTM should account for padding and border for outer svg r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D28488
03ea838144b57003bee53950ae138e23bf0f8066: Bug 1323962 - PaintSVG for container should consider CSS transform for its children r=longsonr
violet <violet.bugreport@gmail.com> - Tue, 23 Apr 2019 00:03:00 +0000 - rev 529271
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1323962 - PaintSVG for container should consider CSS transform for its children r=longsonr Container manages SVG/CSS transform of its children, thus PaintSVG of container should take children's CSS transform into account. Differential Revision: https://phabricator.services.mozilla.com/D28273
29ad5178399d2ae1743ff24838818e4f77ccfe39: Bug 1323962 - Should support CSS transform for clip-path r=longsonr
violet <violet.bugreport@gmail.com> - Mon, 22 Apr 2019 23:59:38 +0000 - rev 529270
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1323962 - Should support CSS transform for clip-path r=longsonr <clipPath> can itself have SVG transform, thus we need to override nsIFrame::IsSVGTransformed() method so that layout code will be aware of the SVG transform. The remaining is similar to <mask> Differential Revision: https://phabricator.services.mozilla.com/D28272
6ab85d4927b51b449d4d3c8ef3be3679fd2f04e7: Bug 1342800 - ComputeSize should not treat iframe as object r=firefox-svg-reviewers,longsonr
violet <violet.bugreport@gmail.com> - Mon, 22 Apr 2019 16:32:14 +0000 - rev 529269
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1342800 - ComputeSize should not treat iframe as object r=firefox-svg-reviewers,longsonr We should not treat <iframe> as <object> for SVG, otherwise there will be unexpected sizing and other webcompat problem (e.g. getScreenCTM). It behaved correctly before, the change was introduced to solve a double zooming problem (bug 843480) for <iframe>. Actually the zooming problem can be solved by avoiding zooming when the window frame is an <iframe>. Differential Revision: https://phabricator.services.mozilla.com/D28313
4c5a5b50c951ff946b39c178b080762e63043111: Bug 1247218 - Should consider CSS transform when using non-scaling-stroke r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 20 Apr 2019 02:04:52 +0000 - rev 529089
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1247218 - Should consider CSS transform when using non-scaling-stroke r=longsonr We remove initial x/y offset for nsSVGUtils::GetTransformMatrixInUserSpace so that it can be used in not-nondisplay context. Previously it was only used in nondisplay context, where x/y offset is always 0. Then we use this utility to get the transform matrix to judge whether we need special care for non-scaling-stroke. The old matrix doesn't account for CSS transform. Differential Revision: https://phabricator.services.mozilla.com/D28193
141cbcdbcef86709c3419cf1cba5aba72a090f02: Bug 1323962 - Should support CSS transform for pattern r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 18 Apr 2019 14:35:23 +0000 - rev 528984
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1323962 - Should support CSS transform for pattern r=longsonr The same as mask. Differential Revision: https://phabricator.services.mozilla.com/D27882
be0c4eed11e43d177ded8e8ddf0ab5379c9f3f44: Bug 1323962 - Should support CSS transform for mask r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 18 Apr 2019 17:19:42 +0000 - rev 528983
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1323962 - Should support CSS transform for mask r=longsonr SVGElement::PrependLocalTransformsTo doesn't take CSS transform into account, we should use nsIFrame::GetTransformMatrix instead. Differential Revision: https://phabricator.services.mozilla.com/D27659
b61895e5c5f987623287b96ca0122b41c18f2e02: Bug 1544270 - Change 1.f * something to float(something) r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 14 Apr 2019 09:32:19 +0000 - rev 528249
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544270 - Change 1.f * something to float(something) r=longsonr Change 1.f * something to float(something) Differential Revision: https://phabricator.services.mozilla.com/D27444
030327cc0e916e38498df64a116c44c887d30cfb: Bug 1544209 - Should not scale mFontSizeScaleFactor for user space r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 14 Apr 2019 07:41:42 +0000 - rev 528248
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544209 - Should not scale mFontSizeScaleFactor for user space r=longsonr We already get the user space metrics, mFontSizeScaleFactor is irrelevant and the scaling should not be applied in the first place. Otherwise we will get very wrong bounding box when <text> has SVG transform or the font has extreme size. Differential Revision: https://phabricator.services.mozilla.com/D27443
332599ee861c87e491e7a2bf3be650a08530722c: Bug 937268 - Should implement getBBox() for tspan r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 14 Apr 2019 05:57:24 +0000 - rev 528246
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 937268 - Should implement getBBox() for tspan r=longsonr We implements getBBox for tspan. The implementation also has consistent behavior as getBoundingClientRect. Differential Revision: https://phabricator.services.mozilla.com/D27428
ee2d5ba2854cbed117403c15872de471e0bc19af: Bug 937268 - Should implement getBBox() for tspan r=longsonr
violet <violet.bugreport@gmail.com> - Sat, 13 Apr 2019 14:48:13 +0000 - rev 528242
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 937268 - Should implement getBBox() for tspan r=longsonr We implements getBBox for tspan. The implementation also has consistent behavior as getBoundingClientRect. Differential Revision: https://phabricator.services.mozilla.com/D27428
5c98e7a25bc0bd99889d8f1d23bb93b222bc4698: Bug 1426594 - Should convert rect from TransformFramePointToTextChild to device pixel r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 12 Apr 2019 16:09:11 +0000 - rev 528199
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1426594 - Should convert rect from TransformFramePointToTextChild to device pixel r=longsonr We need device pixel, but TransformFramePointToTextChild returns in css pixel, thus a scaling is necessary. Differential Revision: https://phabricator.services.mozilla.com/D27322
449e2049eeefaabff1ed55030be3a783e44c30ba: Bug 1524901 - Should not set SVG viewport to intrinsic size when painting background image r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 11 Apr 2019 01:05:02 +0000 - rev 527737
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1524901 - Should not set SVG viewport to intrinsic size when painting background image r=longsonr When an SVG is used as a CSS background-image, we previously used the same behavior as a normal image. It will stretch if the background-size is incompatible with the intrinsic size of the SVG. This is a webcompat issue. Now we use the painting destination rect size instead to avoid stretching. Differential Revision: https://phabricator.services.mozilla.com/D26935
2f71952399fdddbe89abcf5193aa6568dc95c337: Bug 1542714 - Remove nsSVGUtils::GetUserToCanvasTM r=longsonr
violet <violet.bugreport@gmail.com> - Mon, 08 Apr 2019 17:20:07 +0000 - rev 527275
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542714 - Remove nsSVGUtils::GetUserToCanvasTM r=longsonr nsSVGUtils::GetUserToCanvasTM becomes dead code and no longer useful, since it doesn't take CSS transform into account. Let's remove it. Differential Revision: https://phabricator.services.mozilla.com/D26514
28eb58dd6af80262bac8fe10716717e795d8081c: Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr
violet <violet.bugreport@gmail.com> - Mon, 08 Apr 2019 04:39:23 +0000 - rev 527126
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr We should use nsLayoutUtils::GetTransformToAncestor instead of nsSVGUtils::GetUserToCanvasTM to get the transform matrix. Because the former will also take CSS transform into account while the latter won't. Differential Revision: https://phabricator.services.mozilla.com/D26441
253e90f0ccf31bf505eff30de9f200a718298d99: Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 07 Apr 2019 14:11:39 +0000 - rev 527118
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr We should use nsLayoutUtils::GetTransformToAncestor instead of nsSVGUtils::GetUserToCanvasTM to get the transform matrix. Because the former will also take CSS transform into account while the latter won't. Differential Revision: https://phabricator.services.mozilla.com/D26441
5830f058ab4ef321e8f0ccf65a236ced21ee05fd: Bug 1523343 - Should not round translation for SVG frame r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 05 Apr 2019 09:03:52 +0000 - rev 526931
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1523343 - Should not round translation for SVG frame r=longsonr When computing transform matrix, translation in SVG should not be rounded. Checking !IsSVGTransformed() isn't the correct way, since an SVG frame may have CSS transform applied. Differential Revision: https://phabricator.services.mozilla.com/D26271
f7f603959f6cc3fecc7984d808f1829c3293be8a: Bug 1529182 - Include stroke in SVG <text> bounding box. r=longsonr,heycam
Alex Henrie <alexhenrie24@gmail.com> - Thu, 04 Apr 2019 06:38:40 +0000 - rev 526731
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529182 - Include stroke in SVG <text> bounding box. r=longsonr,heycam I think I found another mistake in the SVG text code that could explain the regression: If the text is drawn with a stroke, shouldn't the stroke be included in the bounding box? Differential Revision: https://phabricator.services.mozilla.com/D26074
3fc13216fc98ff4f954b009a32abc4ebac00d37a: Bug 1540703 - Should also reflow SVGTextFrame for non-display active child of switch element r=longsonr
violet <violet.bugreport@gmail.com> - Tue, 02 Apr 2019 06:08:23 +0000 - rev 526344
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540703 - Should also reflow SVGTextFrame for non-display active child of switch element r=longsonr When <switch> happens to have an active child that is non-display, we should still reflow all its descendant SVGTextFrame for consistency. Differential Revision: https://phabricator.services.mozilla.com/D25699
7ca977e3a3a81e2269c74e6b482b77b25740e79e: Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 28 Mar 2019 08:57:10 +0000 - rev 525361
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr We also allow leading and trailing spaces for pair to be consistent with length, number, etc. Differential Revision: https://phabricator.services.mozilla.com/D25050
062344ad3eea0d383fc7e938577a8b0831c5a935: Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 28 Mar 2019 06:12:04 +0000 - rev 525334
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr We also allow leading and trailing spaces for pair to be consistent with length, number, etc. Differential Revision: https://phabricator.services.mozilla.com/D25050
c887f70fb725b6379c1504742eb973b51b087610: Bug 1512745 - Use nsWhitespaceTokenizer to ignore leading and trailing whitespace r=longsonr
violet <violet.bugreport@gmail.com> - Wed, 27 Mar 2019 08:52:33 +0000 - rev 525130
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1512745 - Use nsWhitespaceTokenizer to ignore leading and trailing whitespace r=longsonr Length attribute should allow leading and trailing whitespace per SVG2. Differential Revision: https://phabricator.services.mozilla.com/D23628
88b6e96d82153bf333e1a309f5ae384906168883: Bug 1531333 - Fix <svg:use> cycle detection. r=longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Mar 2019 22:26:53 +0000 - rev 524610
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531333 - Fix <svg:use> cycle detection. r=longsonr With the current code we'll eventually detect the cycle, but will take much more, creating many shadow trees unnecessarily. Take for example the following: <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="133" height="232774"> <style> symbol { display: block } </style> <symbol id="svg-sprite" viewBox="0 0 133 230866"> <title>svg-sprite</title> <symbol id="svg-sprite" viewBox="0 0 133 230866"> <title>svg-sprite</title> <use xlink:href="#svg-sprite" width="500" height="500" /> </symbol> <use xlink:href="#svg-sprite" y="1601" width="133" height="228958" /> </symbol> <use xlink:href="#svg-sprite" y="1601" width="133" height="230866" /> </svg> Before this patch, we'd create an svg use element subtree for #svg-sprite. That subtree will contain two other <use> elements, one under the <symbol>, one not under it. Both point to #svg-sprite, but we fail to detect we're an ancestor since the element #svg-sprite we're looking at is the clone of the #svg-sprite element. Thus we need to take a look at mOriginal instead (which is the <use> element under #svg-sprite) rather than at the clone. Yeah, I had to draw the trees, it's messy :) Blink and WebKit do something slightly different (they check the element id directly[1]). That's not 100% correct, since you can have multiple elements with the same ID. [1]: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/svg/svg_use_element.cc?l=560&rcl=861855dcb8c39ba8d42497247d433277858df79b Differential Revision: https://phabricator.services.mozilla.com/D24565
806b2a3b5bb196107a751380553fb29a9dd786e1: Bug 951904 - SVGTextFrame should always be reflowed even if it is inside a nonactive child of switch element r=longsonr
violet <violet.bugreport@gmail.com> - Thu, 21 Mar 2019 21:17:18 +0000 - rev 524391
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 951904 - SVGTextFrame should always be reflowed even if it is inside a nonactive child of switch element r=longsonr SVGTextFrame is special, it should always be reflowed to get the correct metrics. Differential Revision: https://phabricator.services.mozilla.com/D22841
0a948e5e83e64c7eb8f1dea235d0f70dbc4d5069: Bug 1537708 - Clean up NS_STATE_IS_OUTER_SVG flag in favor of IsSVGOuterSVGFrame r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 22 Mar 2019 02:23:35 +0000 - rev 524337
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537708 - Clean up NS_STATE_IS_OUTER_SVG flag in favor of IsSVGOuterSVGFrame r=longsonr NS_STATE_IS_OUTER_SVG is redundant, we clean it up and use nsIFrame::IsSVGOuterSVGFrame() instead. Differential Revision: https://phabricator.services.mozilla.com/D24330
94b858d366031724359dee96d3594349defe7806: Bug 1536892 - Check a frame does maintain overflow before adding to OverflowChangedTracker. r=longsonr CLOSED TREE
violet <violet.bugreport@gmail.com> - Tue, 19 Mar 2019 20:33:36 +0100 - rev 524202
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536892 - Check a frame does maintain overflow before adding to OverflowChangedTracker. r=longsonr CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D24305
88a8be92d7ae625c67fb3023c690cf5ae82a0214: Bug 1531890 - Take objectBoundingBox into account when a clipPath's child has its own clip-path. r=longsonr
Cameron McCormack <cam@mcc.id.au> - Tue, 19 Mar 2019 01:18:21 +0000 - rev 523728
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1531890 - Take objectBoundingBox into account when a clipPath's child has its own clip-path. r=longsonr Differential Revision: https://phabricator.services.mozilla.com/D23612
ae13953b50050a116254bd80244b479907046f27: Bug 1531333 - Fix <svg:use> cycle detection. r=longsonr a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Mar 2019 22:26:53 +0000 - rev 522698
Push 10907 by archaeopteryx@coole-files.de at Mon, 25 Mar 2019 11:57:16 +0000
Bug 1531333 - Fix <svg:use> cycle detection. r=longsonr a=pascalc With the current code we'll eventually detect the cycle, but will take much more, creating many shadow trees unnecessarily. Take for example the following: <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="133" height="232774"> <style> symbol { display: block } </style> <symbol id="svg-sprite" viewBox="0 0 133 230866"> <title>svg-sprite</title> <symbol id="svg-sprite" viewBox="0 0 133 230866"> <title>svg-sprite</title> <use xlink:href="#svg-sprite" width="500" height="500" /> </symbol> <use xlink:href="#svg-sprite" y="1601" width="133" height="228958" /> </symbol> <use xlink:href="#svg-sprite" y="1601" width="133" height="230866" /> </svg> Before this patch, we'd create an svg use element subtree for #svg-sprite. That subtree will contain two other <use> elements, one under the <symbol>, one not under it. Both point to #svg-sprite, but we fail to detect we're an ancestor since the element #svg-sprite we're looking at is the clone of the #svg-sprite element. Thus we need to take a look at mOriginal instead (which is the <use> element under #svg-sprite) rather than at the clone. Yeah, I had to draw the trees, it's messy :) Blink and WebKit do something slightly different (they check the element id directly[1]). That's not 100% correct, since you can have multiple elements with the same ID. [1]: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/svg/svg_use_element.cc?l=560&rcl=861855dcb8c39ba8d42497247d433277858df79b Differential Revision: https://phabricator.services.mozilla.com/D24565
5f22cf5bfe6f0281522103ecf8d23c88dc37b5e6: Bug 1504072 - non-display outer SVG also doesn't maintain overflow r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 17 Mar 2019 11:00:48 +0000 - rev 522601
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1504072 - non-display outer SVG also doesn't maintain overflow r=longsonr There is some inconsistency between nsIFrame::FrameMaintainsOverflow() and nsSVGContainerFrame::ComputeCustomOverflow(). If an element is a nondisplay outer SVG, the latter gives false while the former returns true. We make them consistent since nondisplay element doesn't need to maintain overflow. Differential Revision: https://phabricator.services.mozilla.com/D23809
fbbc4b0c00c3f82e351f89da586053f0aac0f3dc: Bug 1508028 - Change stroke-miterlimit restriction from GreaterThanOrEqualToOneNumber to NonNegativeNumber. r=longsonr,emilio
violet - Sat, 09 Mar 2019 13:05:56 +0000 - rev 521255
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1508028 - Change stroke-miterlimit restriction from GreaterThanOrEqualToOneNumber to NonNegativeNumber. r=longsonr,emilio
e1459b0afa258f53b7799447c063654e994e4d7f: Bug 1346610 - Compute width and height only when necessary to avoid exponential time complexity r=longsonr
violet <violet.bugreport@gmail.com> - Fri, 08 Mar 2019 07:27:24 +0000 - rev 521009
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1346610 - Compute width and height only when necessary to avoid exponential time complexity r=longsonr When only width is needed, we should not compute height, and vice versa. Otherwise there are exponentially repeated computations for nested svg elements, which will make the tab unresponsive due to 100% CPU usage for exponentially long time. Differential Revision: https://phabricator.services.mozilla.com/D20947
23359968e785bf0a57c5f0d3d373384d12a27e60: Bug 1528635 - Check urlExtraReferrer not null before dereference to avoid crash r=longsonr
violet <violet.bugreport@gmail.com> - Sun, 03 Mar 2019 19:35:42 +0000 - rev 520071
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528635 - Check urlExtraReferrer not null before dereference to avoid crash r=longsonr urlExtraReferrer could be null, we should check before dereference. Otherwise it will cause crash when webrender is enabled by gfx.webrender.enabled=true and gfx.webrender.all=true, Differential Revision: https://phabricator.services.mozilla.com/D20805