searching for reviewer(lizzard)
077503db67be: Bug 1422478 - Prevent tab separator from overlapping the new tab button during the tab open animation. r=johannh a=lizzard
Dão Gottwald <dao@mozilla.com> - Wed, 13 Dec 2017 10:47:49 +0100 - rev 442893
Push 8377 by dgottwald@mozilla.com at 2017-12-15 14:57 +0000
Bug 1422478 - Prevent tab separator from overlapping the new tab button during the tab open animation. r=johannh a=lizzard
198a20c061da: Bug 1408708 - Fetch stylesheet content via stylesheet window instead of top level content window. r=pbro a=lizzard
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 07 Dec 2017 08:22:43 -0500 - rev 442882
Push 8370 by archaeopteryx@coole-files.de at 2017-12-12 15:22 +0000
Bug 1408708 - Fetch stylesheet content via stylesheet window instead of top level content window. r=pbro a=lizzard MozReview-Commit-ID: AKXQLNAwy8t
df953324066b: Bug 1423456 - ContentCacheInParent::OnEventNeedingAckHandled() shouldn't decrement mPendingCompositionCount when it receives eCompositionCommit(AsIs) from the remote process but the composition has already been committed by a request to commit composition r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 06 Dec 2017 15:07:41 +0900 - rev 442878
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1423456 - ContentCacheInParent::OnEventNeedingAckHandled() shouldn't decrement mPendingCompositionCount when it receives eCompositionCommit(AsIs) from the remote process but the composition has already been committed by a request to commit composition r=m_kato a=lizzard After fixing bug 1420849, remote process started to ignore composition events after it synthesizes eCompositionCommit event after requesting to commit composition. However, remote process still keeps returning composition events when it receives from the main process. So, if the main process has already sent eCompositionCommit(AsIs) event when it's requested to commit composition from the remote process, ContentCacheInParent::OnEventNeedingAckHandled() receives both eCompositionCommitRequestHandled and eCompositionCommit(AsIs) events for *a* composition. Therefore, mPendingCompositionCount may be decremented twice for a composition. This causes hitting MOZ_DIAGNOSTIC_ASSERT. So, ContentCacheInParent need to manage if sent composition events are ignored or not. Then, ContentCacheInParent::OnEventNeedingAckHandled() stops decrementing mPendingCompositionCount when it receives eCompositionCommit(AsIs) events which are ignored by the remote process. This patch manages it with |mIsChildIgnoringCompositionEvents| and changes |bool mIsPendingLastCommitEvent| to |uint8_t mPendingCommitCount| for making ContentCache be able to manage multiple pending commit events if its remote process is too busy. MozReview-Commit-ID: CYQDeZXl7TJ
1dc54b85de4d: Bug 1420849 - Make PuppetWidget discard composition events after requesting commit composition and synthesizing eCommitComposition event until new eCompositionStart event comes r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 27 Nov 2017 20:34:01 +0900 - rev 442877
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1420849 - Make PuppetWidget discard composition events after requesting commit composition and synthesizing eCommitComposition event until new eCompositionStart event comes r=m_kato a=lizzard When ContentCacheInParent::RequestIMEToCommitComposition() returns true, the remote process will synthesize eCompositionCommit event. This causes destroying TextComposition event in the remote process (by IMEStateManager::DispatchCompositionEvent()). Then, IMEStateManager::DispatchCompositionEvent() will recreate new TextComposition instance when it receives new composition event. Then, it may request to commit composition to the main process via PuppetWidget accidentally. So, after PuppetWidget::RequestIMEToCommitComposition() synthesizes eCompositionCommit, PuppetWidget should discard following composition events until it receives eCompositionStart since they are unnecessary for the content and they are for the old composition, i.e., outdated events. MozReview-Commit-ID: BNRcoYxABpd
524a38fae76c: Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:30:18 +0900 - rev 442876
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1405832 - part 4: ContentCacheInParent::OnEventNeedingAckHandled() shouldn't crash in release build r=m_kato a=lizzard For protecting main process, we should stop crashing main process in release build even when we detect our bug. However, we should keep crashing with MOZ_DIAGNOSTIC_ASSER which is enabled only on Night and Developer Edition. MozReview-Commit-ID: 5BQ46IFzXXj
8e59e9aed421: Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 23:08:37 +0900 - rev 442875
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1405832 - part 3: ContentCacheInParent::RequestIMEToCommitComposition() should call nsIWidget::NotifyIME() via TextComposition::RequestToCommit() r=m_kato a=lizzard Now, TextComposition::RequestToCommit() manages if it has already requested IME to commit or cancel composition and this is important for redundant requests. Therefore, ContentCacheInParent::RequestIMEToCommitComposition() shouldn't call nsIWidget::NotifyIME() directly. MozReview-Commit-ID: 69VpgyK9Jk5
31bb04b6df15: Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:59:04 +0900 - rev 442874
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1405832 - part 2: TextComposition::RequestToCommit() should request IME to commit or cancel composition only when it hasn't been request it yet and hasn't received commit event yet r=m_kato a=lizzard According to the log in crash reports, eCompositionCommitRequestHandled is sent to ContentCacheInParent twice or more for a composition. This causes breaking mPendingCompositionCount and mPendingEventsNeedingAck management. Currently, nsIWidget::NotifyIME() should be called only by TextComposition::RequestToCommit(). Therefore, the method should manage if it should request it actually. If the composition has already received eCompositionCommit(AsIs) event, it shouldn't request it because parent process may have already stated new composition and it shouldn't be broken by request for old composition. MozReview-Commit-ID: 2ekSa6EIeRP
0136b24f43b3: Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato a=lizzard
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 20 Nov 2017 22:20:02 +0900 - rev 442873
Push 8369 by archaeopteryx@coole-files.de at 2017-12-12 15:15 +0000
Bug 1405832 - part 1: ContentCacheInParent::RequestIMEToCommitComposition() should increment mPendingEventsNeedingAck itself if it treat the request handled synchronously without actually requesting IME to commit composition r=m_kato a=lizzard This is a simple bug of ContentCacheInParent. When ContentCacheInParent::RequestIMEToCommitComposition() returns true, PuppetWidget::RequestIMEToCommitComposition() will send eCompositionCommitRequestHandled pseudo event message back to the main process. This causes counting down mPendingEventsNeedingAck in ContentCacheInParent::OnEventNeedingAckHandled(). Therefore, in the normal path, ContentCacheInParent::OnCompositionEvent() increments it for receiving the pseudo event message. However, if the tab parent has already lost focus, RequestIMEToCommitComposition() returns true without requesting native IME to commit composition. So, ContentCacheInParent::OnCompositionEvent() cannot increment mPendingEventsNeedingAck for coming eCompositionCommitRequestHandled. Therefore, RequestIMEToCommitComposition() needs to increment mPendingEventsNeedingAck by itself when it won't request IME to commit composition but it returns true. MozReview-Commit-ID: 4Alwfy8avB
39aaf54972cb: Backed out changeset 072f8d4a9964 (bug 1355109) for causing crashes with various extensions. a=lizzard
Brian Hackett <bhackett1024@gmail.com> - Tue, 26 Sep 2017 14:12:25 -0400 - rev 433630
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Backed out changeset 072f8d4a9964 (bug 1355109) for causing crashes with various extensions. a=lizzard
784563523bf7: Bug 1412681 - Fix NSS dialogs. r=snorp, a=lizzard
Jim Chen <nchen@mozilla.com> - Mon, 30 Oct 2017 22:48:58 -0400 - rev 432883
Push 8099 by ryanvm@gmail.com at 2017-11-01 00:39 +0000
Bug 1412681 - Fix NSS dialogs. r=snorp, a=lizzard The context object for NSS dialogs apparently won't give us a window, so we have to fall back to the active window. MozReview-Commit-ID: 4cHpcE8oggL
2d90d22d7dc8: Bug 1411957 - Part 2: Update tzdata in ICU data files to 2017c. r=Waldo, a=lizzard
André Bargull <andre.bargull@gmail.com> - Thu, 26 Oct 2017 23:10:51 +0900 - rev 432881
Push 8099 by ryanvm@gmail.com at 2017-11-01 00:39 +0000
Bug 1411957 - Part 2: Update tzdata in ICU data files to 2017c. r=Waldo, a=lizzard MozReview-Commit-ID: IHLvaaTEIPm
23ba8c9c8066: Bug 1411957 - Part 1: Treat Canada/East-Saskatchewan as a legacy ICU time zone. r=Waldo, a=lizzard
André Bargull <andre.bargull@gmail.com> - Sat, 28 Oct 2017 02:50:59 -0700 - rev 432880
Push 8099 by ryanvm@gmail.com at 2017-11-01 00:39 +0000
Bug 1411957 - Part 1: Treat Canada/East-Saskatchewan as a legacy ICU time zone. r=Waldo, a=lizzard MozReview-Commit-ID: DS5hECjNK7u
aa8f74f0ad60: Bug 1408990 - Only add the entry to the performance object if the loading document's principal is the same as the triggering principal. r=bz, r=dragana, a=lizzard FENNEC_57_0b13_BUILD1 FENNEC_57_0b13_RELEASE FIREFOX_57_0b13_BUILD1 FIREFOX_57_0b13_RELEASE
Valentin Gosu <valentin.gosu@gmail.com> - Sat, 28 Oct 2017 00:15:01 +0200 - rev 432852
Push 8084 by ryanvm@gmail.com at 2017-10-30 16:39 +0000
Bug 1408990 - Only add the entry to the performance object if the loading document's principal is the same as the triggering principal. r=bz, r=dragana, a=lizzard MozReview-Commit-ID: 7o8XKHioP1p
ce6aa85a6c11: Bug 1409496 - Cleaning data per domain, must delete localStorage data. r=asuth, a=lizzard
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 25 Oct 2017 19:14:34 +0200 - rev 432780
Push 8056 by ryanvm@gmail.com at 2017-10-26 15:24 +0000
Bug 1409496 - Cleaning data per domain, must delete localStorage data. r=asuth, a=lizzard
7d28b5b2217d: Bug 1407414 - Crash in js::GetOwnPropertyDescriptor. r=bz, a=lizzard
Jason Orendorff <jorendorff@mozilla.com> - Tue, 17 Oct 2017 16:25:40 +0100 - rev 432779
Push 8056 by ryanvm@gmail.com at 2017-10-26 15:24 +0000
Bug 1407414 - Crash in js::GetOwnPropertyDescriptor. r=bz, a=lizzard
c0467da2b62e: Bug 1408412 - Use ARGS_LENGTH_MAX as upper bound in MArgumentsLength::computeRange. r=nbp, a=lizzard
Jan de Mooij <jdemooij@mozilla.com> - Wed, 25 Oct 2017 11:30:17 +0200 - rev 432775
Push 8056 by ryanvm@gmail.com at 2017-10-26 15:24 +0000
Bug 1408412 - Use ARGS_LENGTH_MAX as upper bound in MArgumentsLength::computeRange. r=nbp, a=lizzard
00e60f48b78d: Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett, a=lizzard
Jan de Mooij <jdemooij@mozilla.com> - Thu, 26 Oct 2017 16:15:35 +0200 - rev 432774
Push 8056 by ryanvm@gmail.com at 2017-10-26 15:24 +0000
Bug 1404636 - Special-case typed arrays in PropertyReadNeedsTypeBarrier. r=bhackett, a=lizzard
7eac5fd072cb: Bug 1406398 - Avoid rooting the object twice in EnumerableOwnProperties. r=jandem, a=lizzard
André Bargull <andre.bargull@gmail.com> - Thu, 12 Oct 2017 09:20:07 -0700 - rev 432773
Push 8056 by ryanvm@gmail.com at 2017-10-26 15:24 +0000
Bug 1406398 - Avoid rooting the object twice in EnumerableOwnProperties. r=jandem, a=lizzard
caed14a4e0c2: Bug 1407740 - Fix a crash by setting a flag to true. r=bz, a=lizzard
Andrew McCreight <continuation@gmail.com> - Fri, 20 Oct 2017 16:11:26 -0400 - rev 432648
Push 8019 by ryanvm@gmail.com at 2017-10-20 20:12 +0000
Bug 1407740 - Fix a crash by setting a flag to true. r=bz, a=lizzard
f609508b197d: Bug 1397811 - In order to not leak properties, ensure all the properties of adopted nodes are removed in case the adopt call fails. r=bz, a=lizzard
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 20 Oct 2017 11:02:29 +0100 - rev 432647
Push 8019 by ryanvm@gmail.com at 2017-10-20 20:12 +0000
Bug 1397811 - In order to not leak properties, ensure all the properties of adopted nodes are removed in case the adopt call fails. r=bz, a=lizzard
2b73168324dd: Bug 1250461 - Don't reject profiles with negative colorant tristiumlus value on macOS. r=mstange, a=lizzard
Jeff Muizelaar <jmuizelaar@mozilla.com> - Thu, 12 Oct 2017 11:46:08 -0400 - rev 432463
Push 7956 by ryanvm@gmail.com at 2017-10-12 19:12 +0000
Bug 1250461 - Don't reject profiles with negative colorant tristiumlus value on macOS. r=mstange, a=lizzard This is basically just this: https://bugs.chromium.org/p/chromium/issues/detail?id=562951 The original profile that caused us to add this check has bigger problems than negative colorant tristiumlus values. We should reject it using a better metric. In the mean time let's not reject these things on macOS.
238145ba52b8: Bug 1400003 - Mark Heap<T> and barrier classes as MOZ_NON_MEMMOVABLE. r=sfink, r=froydnj, a=lizzard
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 09 Oct 2017 10:03:20 +0100 - rev 432392
Push 7949 by ryanvm@gmail.com at 2017-10-11 20:50 +0000
Bug 1400003 - Mark Heap<T> and barrier classes as MOZ_NON_MEMMOVABLE. r=sfink, r=froydnj, a=lizzard
520e300d1266: Backed out changeset 072f8d4a9964 (bug 1355109) for causing crashes with various extensions. a=lizzard
Brian Hackett <bhackett1024@gmail.com> - Tue, 26 Sep 2017 14:12:25 -0400 - rev 431867
Push 7829 by ryanvm@gmail.com at 2017-09-26 18:12 +0000
Backed out changeset 072f8d4a9964 (bug 1355109) for causing crashes with various extensions. a=lizzard
a6fb3b978941: Bug 1395892 - Fix legacy badge in details view. r=andym, a=lizzard on a CLOSED TREE FIREFOX_56b13_RELBRANCH
Andrew Swan <aswan@mozilla.com> - Mon, 18 Sep 2017 15:34:32 -0700 - rev 431395
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1395892 - Fix legacy badge in details view. r=andym, a=lizzard on a CLOSED TREE MozReview-Commit-ID: 2RQOvJYHLzm
4b23af4a7d16: Bug 1400721 - Fix Skia's glyph LCD filter padding for FreeType 2.8.1. r=jrmuizel, a=lizzard FIREFOX_56b13_RELBRANCH
Lee Salzman <lsalzman@mozilla.com> - Mon, 18 Sep 2017 15:28:37 -0400 - rev 431394
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1400721 - Fix Skia's glyph LCD filter padding for FreeType 2.8.1. r=jrmuizel, a=lizzard MozReview-Commit-ID: JFvnANsTS0r
ae1985bf54b1: Bug 1392705 - Part 3: Call nsBaseWidget::DestroyLayerManager() in nsWindow::Destroy to ensure IPC is not shutdown in the destructor for Android. r=jchen, a=lizzard FIREFOX_56b13_RELBRANCH
Randall Barker <rbarker@mozilla.com> - Tue, 05 Sep 2017 13:00:06 -0700 - rev 431393
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1392705 - Part 3: Call nsBaseWidget::DestroyLayerManager() in nsWindow::Destroy to ensure IPC is not shutdown in the destructor for Android. r=jchen, a=lizzard Due to the indeterminate nature of Gecko shutdown, the ref count of the nsWindow on Android would sometimes go to zero before the XPCOM shutdown observer was called in nsBaseWindow which is where the compositor thread IPC is shutdown. If nsBaseWindow::Shutdown does not get called, then the compositor thread IPC is shutdown in the nsBaseWindow destructor. Unfortunately while the nsWindow is being deleted, it can be accessed in the compositor thread and cause a crash in LayerManagerComposite::RenderToPresentationSurface. Calling nsBaseWidget::DestroyLayerManager() in nsWindow::Destroy() ensures it gets called before the destructor gets invoked typically in the Destroy() call. MozReview-Commit-ID: KCv8SCmEjnb
1fdc2d468d02: Bug 1392705 - Part 2: Ensure LayerManagerComposite::RenderToPresentationSurface checks the compositor widget before using it. r=kats, a=lizzard FIREFOX_56b13_RELBRANCH
Randall Barker <rbarker@mozilla.com> - Fri, 01 Sep 2017 11:17:12 -0700 - rev 431392
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1392705 - Part 2: Ensure LayerManagerComposite::RenderToPresentationSurface checks the compositor widget before using it. r=kats, a=lizzard MozReview-Commit-ID: 6EP9Pp4h5cP
1348914ba2d8: Bug 1392705 - Part 1: Make UiCompositorControllerChild::Destroy synchronous. r=dvander, a=lizzard FIREFOX_56b13_RELBRANCH
Randall Barker <rbarker@mozilla.com> - Thu, 31 Aug 2017 14:26:46 -0700 - rev 431391
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1392705 - Part 1: Make UiCompositorControllerChild::Destroy synchronous. r=dvander, a=lizzard Ensure the UiCompositorControllerChild is shutdown in the UI thread before the compositor thread is shutdown by the main thread. MozReview-Commit-ID: 4hXYxSi9tzz
1c4f6e449d0b: Bug 1374231 - Work around intel drivers crashing for unknown reasons. r=Bas, a=lizzard FIREFOX_56b13_RELBRANCH
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 20 Sep 2017 09:56:38 +0200 - rev 431390
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1374231 - Work around intel drivers crashing for unknown reasons. r=Bas, a=lizzard Intel GPUs appear to be crashing when using RGB surfaces with the VP9 decoder. So use NV12 instead. MozReview-Commit-ID: GfVciBu7RxP
2deaefe29741: Bug 1400675 - Fix reference to undefined property FirsRunURL. r=gfritzsche, a=lizzard FIREFOX_56b13_RELBRANCH
Tobias Markus <tobbi.bugs@googlemail.com> - Mon, 18 Sep 2017 11:01:37 +0200 - rev 431389
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1400675 - Fix reference to undefined property FirsRunURL. r=gfritzsche, a=lizzard MozReview-Commit-ID: ACfUm7KqWuY
9344afc5eea6: Bug 1399478 - Fix buttonhighlight for doorhangers without a mainaction. r=steveck, a=lizzard FIREFOX_56b13_RELBRANCH
Johann Hofmann <jhofmann@mozilla.com> - Sat, 16 Sep 2017 15:30:50 +0200 - rev 431388
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1399478 - Fix buttonhighlight for doorhangers without a mainaction. r=steveck, a=lizzard We allow doorhangers to optionally disable the blue button highlight for their main actions, but didn't account for the fact that we display a default "OK" button when no mainAction was provided. MozReview-Commit-ID: 6ndWju3ytyq
b968bfa07de0: Bug 1384078 - Prevent enter key from closing extension panels. r=Gijs, a=lizzard FIREFOX_56b13_RELBRANCH
Kris Maglione <maglione.k@gmail.com> - Tue, 19 Sep 2017 16:37:07 -0700 - rev 431387
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1384078 - Prevent enter key from closing extension panels. r=Gijs, a=lizzard MozReview-Commit-ID: DnpiIUc4RkH
4dc03f0ad31c: Bug 1381344 - Use original target to determine if context node is remote. r=smaug, a=lizzard FIREFOX_56b13_RELBRANCH
Kris Maglione <maglione.k@gmail.com> - Mon, 18 Sep 2017 22:52:21 -0700 - rev 431386
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1381344 - Use original target to determine if context node is remote. r=smaug, a=lizzard MozReview-Commit-ID: EQlRNgXkc8B
ccc85929fce0: Bug 1379793 - Only allow pre header as title. r=jwu, a=lizzard FIREFOX_56b13_RELBRANCH
Nevin Chen <cnevinchen@gmail.com> - Mon, 18 Sep 2017 18:08:49 +0800 - rev 431385
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1379793 - Only allow pre header as title. r=jwu, a=lizzard MozReview-Commit-ID: 294jTWWyL69
c7571bece2ba: Bug 1400006 - Extend language negotiation in LocaleService to support looking for the best likelySubtag for the locale with region stripped. r=Pike, a=lizzard FIREFOX_56b13_RELBRANCH
Zibi Braniecki <zbraniecki@mozilla.com> - Thu, 14 Sep 2017 15:21:33 -0700 - rev 431384
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1400006 - Extend language negotiation in LocaleService to support looking for the best likelySubtag for the locale with region stripped. r=Pike, a=lizzard Add additional logic to our language negotation to do apply likelySubtags when a direct match is not available. Currently, if the user specifies the locale with region, and we do not have a direct for that region, we pick all locales for the same language and other regions in no order. The example of where it returns suboptimal results: 1) Requested locale "en-CA" 2) Available locales ["en-ZA", "en-GB", "en-US"] 3) Negotiated locales ["en-ZA", "en-GB", "en-US"] This would not happen, if the user requested a generic "de", "en" etc.: 1) Requested locale "en" 2) Available locales ["en-ZA", "en-GB", "en-US"] 3) Negotiated locales ["en-US", "en-ZA", "en-GB"] because after not finding a direct match, we would use likelySubtags to extend "en" to "en-Latn-US" and then find the priority match in "en-US". This patch extends this logic to "en-US" or "de-LU" by adding a step which strips the region tag and then applies likelySubtag on the result. This means that in absence of direct match the following fallbacks would happen: "de-LU" -> "de-DE" "es-CL" -> "es-ES" "en-CA" -> "en-US" This does not affect languages that use multiple scripts, so ar, sr and zh are not affected. MozReview-Commit-ID: BR1WrgXSf6a
d333328035f5: Bug 1394561 - Ensure WebVR content can catch up when IPC messages are delayed. r=daoshengmu, r=kanru, a=lizzard FIREFOX_56b13_RELBRANCH
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Tue, 19 Sep 2017 14:02:58 -0700 - rev 431383
Push 7783 by ryanvm@gmail.com at 2017-09-21 00:21 +0000
Bug 1394561 - Ensure WebVR content can catch up when IPC messages are delayed. r=daoshengmu, r=kanru, a=lizzard MozReview-Commit-ID: 8zuZt6A79IM
03a307b9d5d6: Bug 1389021 - Force CompositorManagerParent to close before shutting down the compositor thread. r=dvander, a=lizzard on a CLOSED TREE FIREFOX_56b13_RELBRANCH
Andrew Osmond <aosmond@mozilla.com> - Mon, 18 Sep 2017 16:13:03 -0400 - rev 431122
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1389021 - Force CompositorManagerParent to close before shutting down the compositor thread. r=dvander, a=lizzard on a CLOSED TREE
df0c3f4fc23f: Bug 1389021 - CompositorBridgeChild::ActorDestroy should not prevent CompositorBridgeChild::ShutDown from returning. r=nical, a=lizzard FIREFOX_56b13_RELBRANCH
Andrew Osmond <aosmond@mozilla.com> - Mon, 18 Sep 2017 16:21:54 -0400 - rev 431121
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1389021 - CompositorBridgeChild::ActorDestroy should not prevent CompositorBridgeChild::ShutDown from returning. r=nical, a=lizzard
05b18d3ca801: Bug 1399936: Migrate active preference experiment values to new storage. r=Gijs a=lizzard FIREFOX_56b13_RELBRANCH
Michael Kelly <mkelly@mozilla.com> - Tue, 19 Sep 2017 12:21:47 -0700 - rev 431120
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1399936: Migrate active preference experiment values to new storage. r=Gijs a=lizzard If a user is enrolled in a preference experiment when Firefox upgrades, the pref branch for storing experiment values will be empty on startup, causing no prefs to be set. This, in turn, triggers the check in PreferenceExperiments.init for prefs that differ from their experimental value, and unenrolls the user. The solution is to store a pref flag marking if the user has been migrated. If they have not, we take a one-time hit to startup perf and load the experiment storage, saving it to the new pref storage and marking the user as migrated. Since initExperimentPrefs is now async, by the time we decide to add an observer for UI_AVAILABLE_NOTIFICATION, the event may have already fired. We now instead add the observer before the first wait, so that it is added synchronously when startup is called. In addition, startup now sets a deferred when called, and shutdown waits for it to be resolved before doing anything. This avoids issues when shutdown occurs while startup is still executing, since shutdown now waits until startup is complete. MozReview-Commit-ID: 74VHHt18qnw
b138397a1343: Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs a=lizzard FIREFOX_56b13_RELBRANCH
Felipe Gomes <felipc@gmail.com> - Tue, 19 Sep 2017 17:15:00 -0300 - rev 431119
Push 7780 by ryanvm@gmail.com at 2017-09-19 21:16 +0000
Bug 1401249 - Fix getStringPref usage in clicktoplay-rollout. r=Gijs a=lizzard getStringPref(.., undefined) actually returns null instead of undefined. MozReview-Commit-ID: Lor44Q891Hg
678bea28fe03: Revert bug 1385514 for causing bug 1399722. r=ehsan, a=lizzard on a CLOSED TREE FIREFOX_56b13_RELBRANCH FENNEC_56_0b13_BUILD1 FENNEC_56_0b13_RELEASE
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 18 Sep 2017 17:02:21 -0400 - rev 430874
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Revert bug 1385514 for causing bug 1399722. r=ehsan, a=lizzard on a CLOSED TREE
63389830cb95: Bug 1390705 - Bump Flash Click-to-Play rollout to 100% on release. r=bsmedberg, a=lizzard FIREFOX_56b13_RELBRANCH
Felipe Gomes <felipc@gmail.com> - Tue, 22 Aug 2017 13:48:09 -0300 - rev 430873
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1390705 - Bump Flash Click-to-Play rollout to 100% on release. r=bsmedberg, a=lizzard MozReview-Commit-ID: FE2LRqIKanQ
59958378c2ce: Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. r=nechen, a=lizzard FIREFOX_56b13_RELBRANCH
Jing-wei Wu <topwu.tw@gmail.com> - Mon, 11 Sep 2017 10:23:25 +0800 - rev 430872
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. r=nechen, a=lizzard Call `onBackPressed()` when `android.R.id.home` is selected to make sure the same click behavior between HomeAsUpIndicator and back button. MozReview-Commit-ID: 3tTKtbDTugg
47fa81c799b4: Bug 1381638 - Change browser_devices_get_user_media_in_frame.js to test cam then cam+mic instead of mic then cam+mic, to avoid bug 1400488. r=ng, a=lizzard FIREFOX_56b13_RELBRANCH
Jan-Ivar Bruaroey <jib@mozilla.com> - Sun, 17 Sep 2017 14:55:51 -0400 - rev 430869
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1381638 - Change browser_devices_get_user_media_in_frame.js to test cam then cam+mic instead of mic then cam+mic, to avoid bug 1400488. r=ng, a=lizzard
fd583aba7c2b: Bug 1381638 - Prevent sharing multiple input devices in the same process. r=jesup, a=lizzard FIREFOX_56b13_RELBRANCH
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 15 Sep 2017 23:00:39 -0400 - rev 430868
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1381638 - Prevent sharing multiple input devices in the same process. r=jesup, a=lizzard
c8009a75623f: Bug 1400391 - Fix e10s xpcshell-test for remote webextensions. r=kmag, a=lizzard FIREFOX_56b13_RELBRANCH
Shane Caraveo <scaraveo@mozilla.com> - Sun, 17 Sep 2017 19:34:13 -0700 - rev 430867
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1400391 - Fix e10s xpcshell-test for remote webextensions. r=kmag, a=lizzard MozReview-Commit-ID: AgdmUNWLGaq
653105928c28: Bug 1393150 - Prevent remote extensions when e10s is off. r=bz, r=kmag, a=lizzard FIREFOX_56b13_RELBRANCH
Shane Caraveo <scaraveo@mozilla.com> - Thu, 14 Sep 2017 15:12:45 -0700 - rev 430866
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1393150 - Prevent remote extensions when e10s is off. r=bz, r=kmag, a=lizzard MozReview-Commit-ID: HjLLa9vx2UW
47991d799356: Bug 1399070 - Move launchWebAuthFlow to parent to fix opening auth window when remote. r=zombie, a=lizzard FIREFOX_56b13_RELBRANCH
Shane Caraveo <scaraveo@mozilla.com> - Mon, 18 Sep 2017 15:57:56 -0400 - rev 430865
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Bug 1399070 - Move launchWebAuthFlow to parent to fix opening auth window when remote. r=zombie, a=lizzard MozReview-Commit-ID: GAdlxYUM6rr
a841920fd8cb: Bug 1399796 - UnsubmittedCrashHandler should never check for unsubmitted crash reports if disabled or suppressed. r=Felipe, a=lizzard on a CLOSED TREE FIREFOX_56b13_RELBRANCH
Mike Conley <mconley@mozilla.com> - Fri, 15 Sep 2017 09:25:04 -0700 - rev 430803
Push 7769 by ryanvm@gmail.com at 2017-09-16 20:18 +0000
Bug 1399796 - UnsubmittedCrashHandler should never check for unsubmitted crash reports if disabled or suppressed. r=Felipe, a=lizzard on a CLOSED TREE Bug 1355492 moved the logic for scanning for unsubmitted crash reports out of the initialization of UnsubmittedCrashHandler, and the initialization is what decided whether or not it was appropriate to scan in the first place. This was done so that scanning could be deferred until idle after first paint. This patch makes it so that the scanning logic first ensures that the UnsubmittedCrashHandler is actually enabled and not suppressed (which is calculated earlier). I've also taken the liberty of adding a regression test. MozReview-Commit-ID: 3Aihom5Q17R
a3e692e095c6: Bug 1396307 - Make sure we only set mRaceCacheWithNetwork to true when the feature is enabled. r=michal, a=lizzard FIREFOX_56b13_RELBRANCH
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 06 Sep 2017 10:24:01 +0200 - rev 430802
Push 7769 by ryanvm@gmail.com at 2017-09-16 20:18 +0000
Bug 1396307 - Make sure we only set mRaceCacheWithNetwork to true when the feature is enabled. r=michal, a=lizzard MozReview-Commit-ID: FrLjfuExmYV