searching for reviewer(liuche)
e25f027b4c50: Update and reassign some expiring Telemetry probes in gfx. (bug 1430657, r=liuche)
David Anderson <danderson@mozilla.com> - Wed, 17 Jan 2018 19:21:39 -0800 - rev 451613
Push 8558 by ryanvm@gmail.com at 2018-01-19 15:34 +0000
Update and reassign some expiring Telemetry probes in gfx. (bug 1430657, r=liuche)
4c6d55c85948: Bug 1429986 - send telemetry data when users attempt to play mkv file. r=jwwang,liuche
Alfredo.Yang <ayang@mozilla.com> - Fri, 12 Jan 2018 15:40:52 +0800 - rev 451598
Push 8558 by ryanvm@gmail.com at 2018-01-19 15:34 +0000
Bug 1429986 - send telemetry data when users attempt to play mkv file. r=jwwang,liuche MozReview-Commit-ID: Ah3pXC4cJ7n
7c67b6dd2450: Bug 1428796 - Make devtools entry point telemetry never expire. r=Harald,liuche
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 08 Jan 2018 08:06:39 -0800 - rev 451583
Push 8558 by ryanvm@gmail.com at 2018-01-19 15:34 +0000
Bug 1428796 - Make devtools entry point telemetry never expire. r=Harald,liuche MozReview-Commit-ID: 9SUYvq7doWw
809a14e1c12b: Bug 1429510 - Make last shutdown time a scalar. r=chutten,liuche
Georg Fritzsche <georg.fritzsche@googlemail.com> - Thu, 11 Jan 2018 06:06:00 +0200 - rev 450957
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
Bug 1429510 - Make last shutdown time a scalar. r=chutten,liuche
6e299e057fd4: Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 11 Jan 2018 09:11:32 -0500 - rev 450911
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
Bug 1429765 - Extend lifetime of MediaRecorder telemetry probes. r=chutten,liuche Extend lifetime of MEDIA_RECORDER_RECORDING_DURATION, MEDIA_RECORDER_TRACK_ENCODER_INIT_TIMEOUT_TYPE, and SCALARS_MEDIARECORDER.RECORDING_COUNT telemetry probes. This allows continued monitoring of MediaRecorder usage in the wild. See Bug 1400757 for the original introduction of these probes. MozReview-Commit-ID: FzM2Awhv25H
7e989a375aa8: Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 03 Jan 2018 17:25:41 +0000 - rev 450052
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425967 - extend TAB_COUNT probe to last until 65, r=liuche,mconley MozReview-Commit-ID: AwHpPIrvOgE
96fefb68548f: Bug 1428131 Bump Orbot and Graphite Telemetry probes r=liuche
Tom Ritter <tom@mozilla.com> - Thu, 04 Jan 2018 12:52:22 -0600 - rev 450049
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1428131 Bump Orbot and Graphite Telemetry probes r=liuche MozReview-Commit-ID: Gw9Yf9r3LFc
c01ea7a84567: Bug 1425957 - Extend webextension telemetry probes for another 3 releases, r=liuche
Bob Silverberg <bsilverberg@mozilla.com> - Tue, 19 Dec 2017 13:35:36 -0500 - rev 450043
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425957 - Extend webextension telemetry probes for another 3 releases, r=liuche We are still using the data from these probes to help guide us in the development of the APIs in question, so would like to keep them in place until version 63. MozReview-Commit-ID: AC1k40XZGkf
2e333b0f2cd4: Bug 1424908 - extend telemetry probes for page action panel usage/customization, r=liuche
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 12 Dec 2017 14:12:17 -0600 - rev 450042
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1424908 - extend telemetry probes for page action panel usage/customization, r=liuche MozReview-Commit-ID: D1g6yVdGIRt
b16d13518be9: Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. r=jaws,liuche, data-review=liuche
Mike Conley <mconley@mozilla.com> - Thu, 04 Jan 2018 10:51:16 -0500 - rev 450035
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. r=jaws,liuche, data-review=liuche MozReview-Commit-ID: Fk1zCk9dkDf
7fc6865ed3f2: Bug 1423185 - Update document for the event when user finish first run on-boarding. r=liuche
Nevin Chen <cnevinchen@gmail.com> - Tue, 05 Dec 2017 21:27:57 +0800 - rev 449714
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1423185 - Update document for the event when user finish first run on-boarding. r=liuche Data review request comment: 1. What questions will you answer with this data? We want to know when the user exit on-boarding. So we can start to A/B testing on other contextual hints. We don't want to overlap them. 2. Why does Mozilla need to answer these questions? Are there benefits for users? We need this information to know if users had done on-boarding 3. What alternative methods did you consider to answer these questions? Why were they not sufficient? I can't think of any. 4. Can current instrumentation answer these questions? No 5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki. I can't find one for Android 6. How long will this data be collected? Choose one of the following: We want to permanently monitor this data. (Joe Cheng) 5. What populations will you measure? All Fennec users 6. Which release channels? All channels 7.Which countries? All countries 8. Which locales? All locales 9. Any other filters? Please describe in detail below. No 10.Please provide a general description of how you will analyze this data. We'd like to use Leanplum to cross-reference those events 11.Where do you intend to share the results of your analysis? We'll use it internally MozReview-Commit-ID: 2s7Hnc97dhp
4ab7f0a68337: Bug 1406011 - Update the document for defaultBrowser in core ping. r=liuche
Nevin Chen <cnevinchen@gmail.com> - Tue, 05 Dec 2017 16:45:45 +0800 - rev 447275
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1406011 - Update the document for defaultBrowser in core ping. r=liuche MozReview-Commit-ID: 6T9rF2B1T9O
5189909a58bb: Bug 1417361: Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 17:29:53 -0800 - rev 446222
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1417361: Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche This should make the code slightly simpler to follow. MozReview-Commit-ID: HrAv39eCtzb
508c22743a6d: Bug 1417361: Use anchor for context menu on tablet. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 16:35:54 -0800 - rev 446221
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1417361: Use anchor for context menu on tablet. r=liuche This uses the same anchors as the old code so should be low risk. MozReview-Commit-ID: 7pA3SSRghv0
418fcd00bb57: Bug 1416971: Update Pocket MORE link. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 27 Nov 2017 11:26:57 -0800 - rev 445608
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1416971: Update Pocket MORE link. r=liuche Updated URL is specified in comment 1. MozReview-Commit-ID: 3S6vJ4E7jYO
f92dde39c94c: Bug 1417361 - Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche, a=gchang
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 17:29:53 -0800 - rev 442737
Push 8317 by ryanvm@gmail.com at 2017-12-05 17:15 +0000
Bug 1417361 - Rename OnCardLongClickListener.onClick -> onLongClick. r=liuche, a=gchang This should make the code slightly simpler to follow. MozReview-Commit-ID: HrAv39eCtzb
b3759baf9588: Bug 1417361 - Use anchor for context menu on tablet. r=liuche, a=gchang
Michael Comella <michael.l.comella@gmail.com> - Tue, 28 Nov 2017 16:35:54 -0800 - rev 442736
Push 8317 by ryanvm@gmail.com at 2017-12-05 17:15 +0000
Bug 1417361 - Use anchor for context menu on tablet. r=liuche, a=gchang This uses the same anchors as the old code so should be low risk. MozReview-Commit-ID: 7pA3SSRghv0
af0fb48a0ac9: Bug 1416971: Update Pocket MORE link. r=liuche a=gchang on a CLOSED TREE
Michael Comella <michael.l.comella@gmail.com> - Mon, 27 Nov 2017 11:26:57 -0800 - rev 442581
Push 8261 by dluca@mozilla.com at 2017-11-29 14:38 +0000
Bug 1416971: Update Pocket MORE link. r=liuche a=gchang on a CLOSED TREE Updated URL is specified in comment 1. MozReview-Commit-ID: 3S6vJ4E7jYO
78be743420f1: Bug 1415266: Enable Pocket by default. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 07 Nov 2017 11:09:13 -0800 - rev 441418
Push 8130 by ryanvm@gmail.com at 2017-11-09 00:28 +0000
Bug 1415266: Enable Pocket by default. r=liuche MozReview-Commit-ID: CJXNQpsYTf6
1c2c05f1926c: Bug 1415266 - Enable Pocket by default. r=liuche, a=ritu on a CLOSED TREE FIREFOX_57b_RELBRANCH
Michael Comella <michael.l.comella@gmail.com> - Tue, 07 Nov 2017 11:09:13 -0800 - rev 441390
Push 8128 by ryanvm@gmail.com at 2017-11-08 14:10 +0000
Bug 1415266 - Enable Pocket by default. r=liuche, a=ritu on a CLOSED TREE MozReview-Commit-ID: CJXNQpsYTf6
77b37cb80401: Bug 1412164 - Add tour_type and timestamp column for onboarding telemetry. r=Fischer, r=liuche, a=ritu FIREFOX_57b_RELBRANCH
Fred Lin <gasolin@gmail.com> - Fri, 27 Oct 2017 10:20:34 +0800 - rev 440580
Push 8116 by ryanvm@gmail.com at 2017-11-02 18:11 +0000
Bug 1412164 - Add tour_type and timestamp column for onboarding telemetry. r=Fischer, r=liuche, a=ritu MozReview-Commit-ID: aqeoxjR7Tu
12a1cc903ec7: Bug 1412164 - add tour_type and timestamp column for onboarding telemetry;r=Fischer,liuche
Fred Lin <gasolin@gmail.com> - Fri, 27 Oct 2017 10:20:34 +0800 - rev 440508
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1412164 - add tour_type and timestamp column for onboarding telemetry;r=Fischer,liuche MozReview-Commit-ID: aqeoxjR7Tu
457d6f0b0789: Bug 1410221: Rm duplicated code in openContextMenu. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 15:06:03 -0700 - rev 440180
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1410221: Rm duplicated code in openContextMenu. r=liuche I verified this worked by checking the UITelemetry logs. MozReview-Commit-ID: IlD8CuxsUSA
c71c194a8765: Bug 1410221: Rm unnecessary context param from ActivityStreamContextMenu.show. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:57:57 -0700 - rev 440179
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1410221: Rm unnecessary context param from ActivityStreamContextMenu.show. r=liuche MozReview-Commit-ID: LvPCaFbwGEV
e010ad5fb52a: Bug 1410221: Move TopSite openContextMenu to StreamRecyclerAdapter with listener. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:50:17 -0700 - rev 440178
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1410221: Move TopSite openContextMenu to StreamRecyclerAdapter with listener. r=liuche We do this so we can bind the listener to the `parent` View argument in onCreateViewHolder. This is the last commit required to fix this bug. In practice, top sites should never cause a crash because they should never be off-screen on rotation but this is just for correctness/safety. MozReview-Commit-ID: 5P1HiR6woTH
6923f1c704e2: Bug 1410221: Rm unused StreamHighlightItemRowContextMenuListener. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:22:39 -0700 - rev 440177
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1410221: Rm unused StreamHighlightItemRowContextMenuListener. r=liuche MozReview-Commit-ID: LgPtdDMdjVV
35600a494a24: Bug 1410221: Pass in parent snackbarAnchor for WebpageItemRow. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 23 Oct 2017 14:05:39 -0700 - rev 440176
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1410221: Pass in parent snackbarAnchor for WebpageItemRow. r=liuche MozReview-Commit-ID: 76VLKcEPQWF
ee7541fb487a: Bug 1398972 - Update Histograms.json r=liuche
Doug Thayer <dothayer@mozilla.com> - Tue, 31 Oct 2017 11:39:18 -0700 - rev 440143
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1398972 - Update Histograms.json r=liuche Since the user can now block Flash and ask the browser to remember that decision, the histogram that collects user's choices on this has to be updated with a fourth option. MozReview-Commit-ID: J4r6nJIiaeQ
38345cd61a3d: Bug 1411657: Disable Pocket by default. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 25 Oct 2017 12:05:17 -0700 - rev 439041
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1411657: Disable Pocket by default. r=liuche From product (bug 1411657 comment 0): Activity Stream may be pushed to a later release on desktop. With that, we want the Pocket stories feature to be put behind a feature flag on Firefox Android,so we can launch the feature across all platforms simultaneously. MozReview-Commit-ID: 3KmZir3tGPc
4dc6374aca24: Bug 1411657: Use resources when getting default Pocket value. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 25 Oct 2017 12:02:14 -0700 - rev 439040
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1411657: Use resources when getting default Pocket value. r=liuche This is an existing bug that previously had no impact because the values were duplicated. Now that I'm going to change the value, the bug has to be fixed. I opted not to fix the bug for the other top sites features in order to minimize the scope of this change. MozReview-Commit-ID: L9bnEMfvpDG
31d0a5935711: Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche
gasolin <gasolin@gmail.com> - Thu, 31 Aug 2017 10:19:04 +0800 - rev 437628
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche MozReview-Commit-ID: KWRCnD4lFh9
c94d9d435a0d: Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche
gasolin <gasolin@gmail.com> - Thu, 31 Aug 2017 10:19:04 +0800 - rev 437468
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1389424 - enable onboarding telemetry via ping-centre;r=emtwo,Fischer,liuche MozReview-Commit-ID: KWRCnD4lFh9
d8c1c8894971: Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert
Mike de Boer <mdeboer@mozilla.com> - Tue, 17 Oct 2017 12:04:37 +0200 - rev 437384
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402267 - Add a scalar telemetry probe that tracks SessionFile worker restarts. data-r=liuche, r=chutten,liuche,ttaubert MozReview-Commit-ID: F3kCfz18kcQ
5ede138b6e27: Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 29 Sep 2017 17:49:32 -0500 - rev 436709
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche MozReview-Commit-ID: I4nH8sZNX5g
c4492a71092e: Bug 1392951 - Implement telemetry probe for home page setup. r=liuche,mconley
Evan Tseng <evan@tseng.io> - Fri, 06 Oct 2017 16:13:05 +0800 - rev 436382
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1392951 - Implement telemetry probe for home page setup. r=liuche,mconley - Send a ping when user type in "Home page" box. - String is longer than 4 letters and with at least one ".". - String is not deleted after 3 seconds. - Send a ping when "Use Current Page" is clicked. - Send a ping when "Use Bookmark" is clicked. - Send the number of "|" is detected in "Home page" box. MozReview-Commit-ID: 6bYK0eCkYym
ffd9345660e5: Bug 1395409: Add testActivityStreamPocketReferrer. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 17:33:08 -0700 - rev 435313
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1395409: Add testActivityStreamPocketReferrer. r=liuche MozReview-Commit-ID: FlcMG5IewRH
8ba3c0e7b8f7: Bug 1403755: Rm code to insert blanks into top sites. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Thu, 28 Sep 2017 14:09:48 -0700 - rev 435019
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403755: Rm code to insert blanks into top sites. r=liuche This code was being mistakenly activated when getting top sites for Activity Stream. This is the first removal of old top sites code and will mean we can't go back to old top sites by flipping the `ActivityStream.isEnabled` flag. Since we're planning to ship AS, this shouldn't matter. MozReview-Commit-ID: 9VB0RqNHmE0
0db210721aa4: Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 03 Oct 2017 10:29:49 -0700 - rev 435010
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche This is used in multi-locale builds, e.g. [1] where all German is "de" but in [2], we have a separate l10n repo for en-GB. [1]: https://hg.mozilla.org/releases/l10n/mozilla-beta/de [2]: https://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB MozReview-Commit-ID: CXw9aFH9psz
0bf07287d614: Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 03 Oct 2017 10:29:49 -0700 - rev 435006
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405404: Add 'de' to list of pocket whitelisted locales. r=liuche This is used in multi-locale builds, e.g. [1] where all German is "de" but in [2], we have a separate l10n repo for en-GB. [1]: https://hg.mozilla.org/releases/l10n/mozilla-beta/de [2]: https://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB MozReview-Commit-ID: CXw9aFH9psz
747862bc5edb: Bug 1404460: Add test for pocket locale enabling. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 18:36:41 -0700 - rev 434860
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404460: Add test for pocket locale enabling. r=liuche MozReview-Commit-ID: LHdQuICvVjE
bb2d7ca31f69: Bug 1404460: Hide Pocket preference if Pocket not available in locale. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 17:35:03 -0700 - rev 434859
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404460: Hide Pocket preference if Pocket not available in locale. r=liuche When changing locales, an open dialog will not refresh but clicking on the "Top sites" preference again (to display the dialog) will show the correct dialog for the current locale. MozReview-Commit-ID: 6UJvDIJZJtc
bc59c8db7297: Bug 1404460: Add POCKET_ENABLED_TO_LOCALE to asUserPrefs telemetry. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 17:01:10 -0700 - rev 434858
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404460: Add POCKET_ENABLED_TO_LOCALE to asUserPrefs telemetry. r=liuche After speaking with liuche, we decided it'd be better to add a bit to determine this rather than combining it with the isPocketEnabled field (which would be loss of data) or cross-referencing the locale of the submitted event when checking the Pocket value during telemetry analysis (which is hard to get right and likely to get out of date). MozReview-Commit-ID: JKFrdEsEbyp
141096343631: Bug 1404460: Only show Pocket stories in specified locales. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Mon, 02 Oct 2017 15:59:42 -0700 - rev 434857
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404460: Only show Pocket stories in specified locales. r=liuche Ideally, we'd centralize all queries as to which options are user specified. However, I wanted to do the smallest change so we can uplift so I filed bug 1405161 for this centralization. I opted not to include the "de" locale that is included on desktop because it does not appear we ever get the "de" locale on Firefox for Android [1]. I tested this patch by changing the system locale between locales with Pocket on my device (en-US, en-GB, de-DE) and locales without Pocket (ko-KR). The locale switching system makes this refresh automatically without extra code. I also intend to test via the in-app locale switcher but that will take time because I can't do artifact builds with multi-locale so I'm pushing this for review before I'm finished. Follow-up changes: - Add to telemetry - Hiding the preference in the undesired locales. - A test for isPocketEnabledByLocaleInner (useful to document how this is intended to work for locales with variants, different scripts, etc.) [1]: https://sql.telemetry.mozilla.org/queries/4613#table MozReview-Commit-ID: 7AVQ8fWub8I
aece6300bbea: Bug 1402026: Correct formatting for AS telemetry bulleted lists. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:10:02 -0700 - rev 434112
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402026: Correct formatting for AS telemetry bulleted lists. r=liuche Apparently, if you don't have whitespace above the bulleted list, it won't format as a list. MozReview-Commit-ID: LiLpSNScBxR
cd12463f9043: Bug 1402026: Add interaction extra to AS telemetry. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:07:28 -0700 - rev 434111
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402026: Add interaction extra to AS telemetry. r=liuche MozReview-Commit-ID: EOr8Z8KRPGq
55432b5c3cd8: Bug 1402026: Correct top site context menu telemetry note. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 15:01:42 -0700 - rev 434110
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402026: Correct top site context menu telemetry note. r=liuche The top sites menu button was removed in a previous iteration and long-click is used to access the context menu now. MozReview-Commit-ID: KzTg4Py8o8W
9e6eb09000d3: Bug 1402026: Add caveat about suggested source_subtype. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 27 Sep 2017 14:45:41 -0700 - rev 434109
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402026: Add caveat about suggested source_subtype. r=liuche In the bug, we decided that it was okay to document this case because: 1) we didn't know the specific questions we were trying to answer 2) We were facing the 57 deadline The alternative would be to change the behavior to perhaps the more intuitive behavior where suggested sites will always be marked as "suggested" clicks but note that there may be privacy concerns with that (in that there are a limited number of suggested sites so we'd know the frequency that unique users might visit the suggested sites). MozReview-Commit-ID: GxQZzwoZ1nQ
28c4a0eaad7d: Bug 1403347: Don't cache CustomListPreference dialog items. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 26 Sep 2017 16:23:59 -0700 - rev 434100
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403347: Don't cache CustomListPreference dialog items. r=liuche We're returning a list of only a few items that, at worst, reads from resources and is infrequently accessed: there is no reason to cache these values and the bugs, like this one, that caches entail. At the end of this patch, there's no crash, but the scrolling behavior isn't great: that's bug 1403139. MozReview-Commit-ID: 3zoXWk78cM4
ccb464644741: Bug 1403347: Set dialog titles in createDialogItems. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 26 Sep 2017 16:22:21 -0700 - rev 434099
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403347: Set dialog titles in createDialogItems. r=liuche We manipulate the data before the dialog is shown, rather than manipulating the Views after the dialog is shown: this is more stable. One question is what is the value of isHidden, which we branch on, when we're manipulating the data. isHidden is set: - When the preference is constructed (previous commit) - When the preference is set as the default (e.g. the default panel was hidden) - When "Hide" or "Show" is clicked in the preference Thus the preference (and hidden state) outlives the dialog and each time we reread the value of isHidden to set the dialog items. This would fix the bug but the dialog values are actually cached so we'll need to fix/remove that cache: coming up in the next changeset. MozReview-Commit-ID: 86v1RDNFZHZ
5bfd1cac74e5: Bug 1403347: Move initial setHidden to panel preference constructor. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Tue, 26 Sep 2017 16:32:20 -0700 - rev 434098
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403347: Move initial setHidden to panel preference constructor. r=liuche This is a code clean-up. Functionally, this is the same to the previous implementation. setHidden was originally called right after the constructor is called and so should just be called from the constructor. If it's not called from the constructor, there can be a period of confusion where a developer wonders, "Has isHidden been initialized by the time this other method I care about has been called?" This should make those questions disappear. This commit does not need to be uplifted (to change less in 57 and that the other code does not depend on it) but I'm placing it first so it's clearer to my reviewer when isHidden is initialized (which is relevant to my other patches). MozReview-Commit-ID: 80KXFDB1poY