searching for reviewer(karlt)
7b8a5f9aac6f: Bug 1284391 - Remove ui.allow_platform_file_picker pref on GTK widget. r=karlt
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 11 Jan 2018 13:10:28 +0000 - rev 450820
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
Bug 1284391 - Remove ui.allow_platform_file_picker pref on GTK widget. r=karlt MozReview-Commit-ID: Gdiww1Gbwpk
26fa4e61b9bc: Bug 1278282 - Remove the 'MOZ_WIDGET_GTK == 2' defines r=karlt,lsalzman
Sylvestre Ledru <sledru@mozilla.com> - Wed, 10 Jan 2018 08:52:04 +0100 - rev 450520
Push 8528 by ryanvm@gmail.com at 2018-01-12 02:17 +0000
Bug 1278282 - Remove the 'MOZ_WIDGET_GTK == 2' defines r=karlt,lsalzman MozReview-Commit-ID: 3v8D600g8St
0b80f477e21d: Bug 1425190 - Stop checking for GTK >= 2.24 in the printing code. r=karlt
Jonathan Watt <jwatt@jwatt.org> - Fri, 08 Dec 2017 09:44:17 +0000 - rev 449784
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425190 - Stop checking for GTK >= 2.24 in the printing code. r=karlt MozReview-Commit-ID: CEvccM9YzgC
c85b83645bb3: Bug 1425188 - Remove the ability to save as Postscript from the print dialog on Linux. r=karlt
Jonathan Watt <jwatt@jwatt.org> - Thu, 07 Dec 2017 14:52:25 +0000 - rev 449782
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1425188 - Remove the ability to save as Postscript from the print dialog on Linux. r=karlt Saving to PDF will now be the only option. MozReview-Commit-ID: 9WIDws6lByG
355d6145c397: Bug 1427520 - Stub gtk_widget_get_preferred_width/height in mozgtk2; r=karlt
Jan Steffens <jan.steffens@gmail.com> - Mon, 01 Jan 2018 06:34:23 +0100 - rev 449455
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1427520 - Stub gtk_widget_get_preferred_width/height in mozgtk2; r=karlt MozReview-Commit-ID: HUMEwgcwioX
a2007a896005: Bug 1282419 - Don't send a large notify image. r=karlt
Adam Gashlin <agashlin@mozilla.com> - Tue, 28 Nov 2017 17:08:41 -0800 - rev 446261
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1282419 - Don't send a large notify image. r=karlt
8c4514cb4120: Bug 1420171 Part 2: Remove some unused members from nsDeviceContextSpecG. r=karlt
Bob Owen <bobowencode@gmail.com> - Tue, 28 Nov 2017 08:58:58 +0000 - rev 445814
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1420171 Part 2: Remove some unused members from nsDeviceContextSpecG. r=karlt
d602eb4467cd: Bug 1420171 Part 1: Only default the print-to file name on Linux if not already set. r=karlt
Bob Owen <bobowencode@gmail.com> - Tue, 28 Nov 2017 08:58:43 +0000 - rev 445813
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1420171 Part 1: Only default the print-to file name on Linux if not already set. r=karlt This allows the web extension saveAsPDF function to work properly.
198b1e4e5438: bug 1414881 - Detect more resolution icons. r=karlt
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 16 Nov 2017 14:08:10 +0900 - rev 443927
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
bug 1414881 - Detect more resolution icons. r=karlt I add some resolution icons for HiDPI by bug 1415014. So we should detect these resolution icons. Also, Thunderbird has default256.png, so we should support it, too. MozReview-Commit-ID: 6BEgV0usnE2
9ba9c746b1b1: Bug 1416712 - Remove nsPaperPS as it seems to be dead code r=karlt
Sylvestre Ledru <sledru@mozilla.com> - Mon, 13 Nov 2017 11:24:47 +0100 - rev 443464
Push 8527 by Callek@gmail.com at 2018-01-11 21:05 +0000
Bug 1416712 - Remove nsPaperPS as it seems to be dead code r=karlt MozReview-Commit-ID: IWbo6cXDyiy
072ce042c1d8: Bug 1420171 - Part 2: Remove some unused members from nsDeviceContextSpecG. r=karlt, a=gchang
Bob Owen <bobowencode@gmail.com> - Tue, 28 Nov 2017 08:58:58 +0000 - rev 442733
Push 8317 by ryanvm@gmail.com at 2017-12-05 17:15 +0000
Bug 1420171 - Part 2: Remove some unused members from nsDeviceContextSpecG. r=karlt, a=gchang
b7d6ba8ab96b: Bug 1420171 - Part 1: Only default the print-to file name on Linux if not already set. r=karlt, a=gchang
Bob Owen <bobowencode@gmail.com> - Tue, 28 Nov 2017 08:58:43 +0000 - rev 442732
Push 8317 by ryanvm@gmail.com at 2017-12-05 17:15 +0000
Bug 1420171 - Part 1: Only default the print-to file name on Linux if not already set. r=karlt, a=gchang This allows the web extension saveAsPDF function to work properly.
baff3e812914: Bug 1398539: Inhibit screensaver with XScreenSaverSuspend r=karlt
Lee Bousfield <ljbousfield@gmail.com> - Wed, 13 Sep 2017 18:28:51 -0600 - rev 441076
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1398539: Inhibit screensaver with XScreenSaverSuspend r=karlt MozReview-Commit-ID: LhhpaDaPdaO
b503682a7c6e: Bug 1411121 - Part 1: Return NS_ERROR_FAILURE if nsIPrintDialogService doesn't exist on GTK when showing print dialog. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 06 Nov 2017 09:27:04 +0900 - rev 441062
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1411121 - Part 1: Return NS_ERROR_FAILURE if nsIPrintDialogService doesn't exist on GTK when showing print dialog. r=karlt A printingui uses the xul print dialog(i.e. printdialog.xul) if there are not nsIPrintDialogService. But this code is unreachable code since current gtk widget has nsIPrintDialogService always. So this patch will remove this code. MozReview-Commit-ID: EeM6YytEfdW
cd2a5b5cf752: Bug 1151753 - Set program class name when not using --class command line option. r=karlt
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 25 Oct 2017 15:58:49 +0900 - rev 440559
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1151753 - Set program class name when not using --class command line option. r=karlt GTK bug: https://bugzilla.gnome.org/show_bug.cgi?id=747634 Before 3.16.3, GDK cannot override classname by --class command line option when program uses gdk_set_program_class(). So if 3.16.3+, we should call gdk_set_program_class() to set program class name of default. MozReview-Commit-ID: KvNc3U6xHr7
99f78ebf8d65: Bug 1348310 - Use CLOCK_MONOTONIC as a base for nsWindow::GetEventTimeStamp() on Wayland, r=karlt
Martin Stransky <stransky@redhat.com> - Thu, 19 Oct 2017 15:28:47 +0200 - rev 440364
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1348310 - Use CLOCK_MONOTONIC as a base for nsWindow::GetEventTimeStamp() on Wayland, r=karlt We assume CLOCK_MONOTONIC as timebase for events on Wayland and use that to translates GDK event times to gecko timestamps. MozReview-Commit-ID: LWd2KWTQeha
d390f8888d71: Bug 1411121 - Part 1: Return NS_ERROR_FAILURE if nsIPrintDialogService doesn't exist on GTK when showing print dialog. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 01 Nov 2017 12:05:39 +0900 - rev 440301
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1411121 - Part 1: Return NS_ERROR_FAILURE if nsIPrintDialogService doesn't exist on GTK when showing print dialog. r=karlt A printingui uses the xul print dialog(i.e. printdialog.xul) if there are not nsIPrintDialogService. But this code is unreachable code since current gtk widget has nsIPrintDialogService always. So this patch will remove this code. MozReview-Commit-ID: EeM6YytEfdW
4df8244690cf: Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt
Brad Werth <bwerth@mozilla.com> - Tue, 10 Oct 2017 14:12:47 -0700 - rev 439538
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt MozReview-Commit-ID: ERsI916e7zf
76300bd1f7c1: Bug 1400238 - Notify TabParent when the GTK client offset changes. r=karlt
Botond Ballo <botond@mozilla.com> - Wed, 18 Oct 2017 13:29:47 -0400 - rev 438486
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1400238 - Notify TabParent when the GTK client offset changes. r=karlt MozReview-Commit-ID: 1TacAhl6c2M
7636f668f84e: Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt
Brad Werth <bwerth@mozilla.com> - Tue, 10 Oct 2017 14:12:47 -0700 - rev 438453
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt MozReview-Commit-ID: ERsI916e7zf
349f51081127: Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt
Brad Werth <bwerth@mozilla.com> - Tue, 10 Oct 2017 14:12:47 -0700 - rev 438435
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403690 Part 4: gtk rearrange header and implementation to keep init and refresh functions together. r=karlt MozReview-Commit-ID: ERsI916e7zf
41ddeed089a4: Bug 1408456 - Convert test_analyserNodeOutput.html to a web-platform-test: test-analyser-output.html. r=karlt
Paul Adenot <paul@paul.cx> - Tue, 17 Oct 2017 14:47:44 +0200 - rev 438417
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1408456 - Convert test_analyserNodeOutput.html to a web-platform-test: test-analyser-output.html. r=karlt This also brings in and convert some utilities we have in Gecko, that will ease porting more tests. MozReview-Commit-ID: 2yPZQO504kH
fc9a7b008e91: Bug 1408456 - Convert test_analyserNodeMinimum.html to a web-platform-test: test-analyser-minimum.html. r=karlt
Paul Adenot <paul@paul.cx> - Tue, 17 Oct 2017 14:43:53 +0200 - rev 438416
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1408456 - Convert test_analyserNodeMinimum.html to a web-platform-test: test-analyser-minimum.html. r=karlt MozReview-Commit-ID: F6VNiYBXr7Z
794463d2292e: Bug 1408456 - Convert test_analyserScale.html to a web-platform-test: test-analyser-scale.html. r=karlt
Paul Adenot <paul@paul.cx> - Tue, 17 Oct 2017 14:47:32 +0200 - rev 438415
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1408456 - Convert test_analyserScale.html to a web-platform-test: test-analyser-scale.html. r=karlt MozReview-Commit-ID: CUhtCzfoi95
a374884e626c: Bug 1408456 - Convert test_analyserNodeWithGain.html to a web-platform-test: test-analyser-gain.html. r=karlt
Paul Adenot <paul@paul.cx> - Mon, 16 Oct 2017 17:04:45 +0200 - rev 438414
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1408456 - Convert test_analyserNodeWithGain.html to a web-platform-test: test-analyser-gain.html. r=karlt MozReview-Commit-ID: 7gIj3cdZiZB
c9d3baf64827: Bug 1408456 - Convert test_AnalyserNode.html to a web-platform-test. r=karlt
Paul Adenot <paul@paul.cx> - Mon, 16 Oct 2017 17:16:36 +0200 - rev 438413
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1408456 - Convert test_AnalyserNode.html to a web-platform-test. r=karlt MozReview-Commit-ID: GR3Ze8KIAKB
f902cf92b444: Bug 1364843 - Implement MOZ_GTK_HEADER_BAR* theme entries, r=jhorak,karlt
Martin Stransky <stransky@redhat.com> - Tue, 19 Sep 2017 21:22:45 +0200 - rev 438096
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1364843 - Implement MOZ_GTK_HEADER_BAR* theme entries, r=jhorak,karlt Based on patch by Andrew Comminos [:acomminos] <andrew@comminos.com> MozReview-Commit-ID: DTVePe1R563
4997882c1be8: Bug 1364843 - Added WidgetNodeType entries for GtkHeaderBar implementation, r=jhorak,jimm,karlt
Martin Stransky <stransky@redhat.com> - Tue, 19 Sep 2017 18:24:13 +0200 - rev 438092
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1364843 - Added WidgetNodeType entries for GtkHeaderBar implementation, r=jhorak,jimm,karlt Based on patch by Andrew Comminos [:acomminos] <andrew@comminos.com> MozReview-Commit-ID: GA3CDhCeqfD
38a9db7104d9: Bug 1381815 - fixing dimensions of radio and checkbox for GTK 3.20+; r=karlt
Jan Horak <jhorak@redhat.com> - Tue, 10 Oct 2017 13:35:56 +0200 - rev 437710
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1381815 - fixing dimensions of radio and checkbox for GTK 3.20+; r=karlt In the GTK < 3.20 the size of radio and checkbox toggle is determined by indicator spacing and indicator size. By GTK 3.20+ it is replaced by standard box model (padding, margin, border). The patch fixes that while keeping the functionality for older GTK. The values are also cached by similar way as scrollbar metrics are cached now. The focus is no longer rendered by GTK but by Mozilla code, so the extra size for toggles has been removed from GetExtraSizeForWidget and toggles no longer render focus indicator. MozReview-Commit-ID: 1Wg5AgHy1Vz
fb2b1aa5bb5e: Bug 1185236 - Add AdjustPrintJobNameForIPP() wide version. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 15:48:39 +0900 - rev 436847
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Add AdjustPrintJobNameForIPP() wide version. r=karlt MozReview-Commit-ID: AE3mvnrVAqn
f39bad8999fa: Bug 1185236 - Shorten print job name when GTK version is older than 3.18.2. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 15:48:39 +0900 - rev 436846
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Shorten print job name when GTK version is older than 3.18.2. r=karlt Since GTK 3.18.2, GTK allows setting job name with more than 255 bytes. As result, CUPS received the IPP error. (RFC 2911, Section 4.3.1) This patch will shorten print job name, if runtime GTK version is older than 3.18.2. MozReview-Commit-ID: EfB87Bvo6hX
388a4fce5b4e: Bug 1185236 - Add adjustPrintJobName in order to avoid IPP job name limit. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 15:47:33 +0900 - rev 436845
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Add adjustPrintJobName in order to avoid IPP job name limit. r=karlt MozReview-Commit-ID: n2k9lwfoyW
2cbe403d5c16: Bug 1185236 - Add AdjustPrintJobNameForIPP() wide version. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 09:50:56 +0900 - rev 436735
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Add AdjustPrintJobNameForIPP() wide version. r=karlt MozReview-Commit-ID: AE3mvnrVAqn
0466471b9f67: Bug 1185236 - Shorten print job name when GTK version is older than 3.18.2. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 09:46:39 +0900 - rev 436734
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Shorten print job name when GTK version is older than 3.18.2. r=karlt Since GTK 3.18.2, GTK allows setting job name with more than 255 bytes. As result, CUPS received the IPP error. (RFC 2911, Section 4.3.1) This patch will shorten print job name, if runtime GTK version is older than 3.18.2. MozReview-Commit-ID: EfB87Bvo6hX
445f1e6fc862: Bug 1185236 - Add adjustPrintJobName in order to avoid IPP job name limit. r=karlt
Mantaroh Yoshinaga <mantaroh@gmail.com> - Fri, 13 Oct 2017 08:55:08 +0900 - rev 436733
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1185236 - Add adjustPrintJobName in order to avoid IPP job name limit. r=karlt MozReview-Commit-ID: n2k9lwfoyW
d06512adfab5: Bug 1405267 - Don't stub gdk_window_get_window_type in mozgtk2. r=karlt
Chris Coulson <chrisccoulson@ubuntu.com> - Tue, 03 Oct 2017 04:58:00 -0400 - rev 435443
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405267 - Don't stub gdk_window_get_window_type in mozgtk2. r=karlt
a33c563d5428: Bug 1397918 - don't use versions of libxcb before 1.11.1. r=karlt
Lee Salzman <lsalzman@mozilla.com> - Fri, 22 Sep 2017 00:10:35 -0400 - rev 433141
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1397918 - don't use versions of libxcb before 1.11.1. r=karlt MozReview-Commit-ID: Ec8ZhCBlPj2
48052fefc77e: Bug 1405267 - Don't stub gdk_window_get_window_type in mozgtk2. r=karlt, a=ritu
Chris Coulson <chrisccoulson@ubuntu.com> - Tue, 03 Oct 2017 04:58:00 -0400 - rev 432310
Push 7929 by ryanvm@gmail.com at 2017-10-09 18:47 +0000
Bug 1405267 - Don't stub gdk_window_get_window_type in mozgtk2. r=karlt, a=ritu
103c51cbee81: Bug 1397918 - Don't use versions of libxcb before 1.11.1. r=karlt, a=sledru
Lee Salzman <lsalzman@mozilla.com> - Fri, 22 Sep 2017 00:10:35 -0400 - rev 431792
Push 7814 by ryanvm@gmail.com at 2017-09-24 21:16 +0000
Bug 1397918 - Don't use versions of libxcb before 1.11.1. r=karlt, a=sledru MozReview-Commit-ID: Ec8ZhCBlPj2
cd4bfa0b73b3: Bug 1401063: Cache remaining gtk window and button colors to eliminate on-demand gtk calls in ::NativeGetColor. r=karlt
Brad Werth <bwerth@mozilla.com> - Tue, 19 Sep 2017 13:00:28 -0700 - rev 431546
Push 7784 by ryanvm@gmail.com at 2017-09-21 00:40 +0000
Bug 1401063: Cache remaining gtk window and button colors to eliminate on-demand gtk calls in ::NativeGetColor. r=karlt MozReview-Commit-ID: HbZqBUG0w7y
fd4481cbbd29: bug 1400839 use -1 instead of 0 to indicate absent glxtest_pipe fd r=karlt
sebastian@ifyouwantblood.de - Tue, 19 Sep 2017 11:47:12 +1200 - rev 431091
Push 7777 by ryanvm@gmail.com at 2017-09-19 13:41 +0000
bug 1400839 use -1 instead of 0 to indicate absent glxtest_pipe fd r=karlt Englightenment closes fd 0 on child processes and so pipe() can return a zero fd. MozReview-Commit-ID: 5d9xQXgwgfv
ff9e183ca0fe: Bug 1400148 - Don't use -1 to represent an unset nsCursor. r=karlt.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 15 Sep 2017 14:34:37 +1000 - rev 430947
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 1400148 - Don't use -1 to represent an unset nsCursor. r=karlt. Because UBSan complains about casting -1: > runtime error: load of value 4294967295, which is not a valid value for type 'nsCursor'
e46b61728739: Bug 1400175 - Stub gdk_screen_get_monitor_workarea in mozgtk2; r=karlt
Jan Steffens <jan.steffens@gmail.com> - Fri, 15 Sep 2017 13:44:14 +0200 - rev 430935
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 1400175 - Stub gdk_screen_get_monitor_workarea in mozgtk2; r=karlt MozReview-Commit-ID: 72K6U17JuoK
30f93fe09f99: Bug 1314928 - get link text color by GTK_STATE_FLAG_LINK on Gtk3 >= 3.12, r=karlt
Martin Stransky <stransky@redhat.com> - Fri, 25 Aug 2017 10:30:28 +0200 - rev 426333
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1314928 - get link text color by GTK_STATE_FLAG_LINK on Gtk3 >= 3.12, r=karlt MozReview-Commit-ID: BPR2AgoUx5H
1f349caf1814: Bug 1314928 - get link text color by GTK_STATE_FLAG_LINK on Gtk3 >= 3.12, r=karlt
Martin Stransky <stransky@redhat.com> - Fri, 25 Aug 2017 10:30:28 +0200 - rev 426303
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1314928 - get link text color by GTK_STATE_FLAG_LINK on Gtk3 >= 3.12, r=karlt MozReview-Commit-ID: BPR2AgoUx5H
74d4d1d6155d: Bug 1389851 - netwerk: Fix -Wunreachable-code-return warning in nsGIOProtocolHandler.cpp. r=karlt
Chris Peterson <cpeterson@mozilla.com> - Wed, 09 Aug 2017 00:38:15 -0700 - rev 425283
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1389851 - netwerk: Fix -Wunreachable-code-return warning in nsGIOProtocolHandler.cpp. r=karlt netwerk/protocol/gio/nsGIOProtocolHandler.cpp:89:10: warning: 'return' will never be executed [-Wunreachable-code-return] This `return NS_ERROR_FAILURE` statement at the end of this function is unreachable because all of the preceding switch statement's cases return. MozReview-Commit-ID: 3qDu2IqTPrW
6936e0705405: Bug 1377950 - Reset all compositors when GdkScreen "composited-changed" fires. r=karlt
Ryan Hunt <rhunt@eqrion.net> - Fri, 11 Aug 2017 02:52:08 -0500 - rev 424178
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1377950 - Reset all compositors when GdkScreen "composited-changed" fires. r=karlt MozReview-Commit-ID: 3vva2XgSa60
dcbf487465de: Bug 1389133 - don't invalidate style content for missing widgets, r=karlt
Martin Stransky <stransky@redhat.com> - Thu, 10 Aug 2017 18:07:41 +0200 - rev 423804
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1389133 - don't invalidate style content for missing widgets, r=karlt MozReview-Commit-ID: 2KfjYGvsiVv
61e9f34166f4: Bug 1388614 - Make sure MathML display items are unique. r=karlt
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 10 Aug 2017 23:26:42 +1200 - rev 423670
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1388614 - Make sure MathML display items are unique. r=karlt FrameLayerBuilder requires the the (frame,per-frame-key) for each display item is unique. It only enforces this in certain situations though, so there's cases where we've gotten away without this. Retained display lists introduces more situations where we rely on this, so I've found a few. MathML nsDisplayNotation and nsDisplayMathMLBar are the two fixed by this patch.
6b2edbf5944a: Bug 1388614 - Make sure MathML display items are unique. r=karlt
Matt Woodrow <mwoodrow@mozilla.com> - Thu, 10 Aug 2017 23:26:42 +1200 - rev 423449
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1388614 - Make sure MathML display items are unique. r=karlt FrameLayerBuilder requires the the (frame,per-frame-key) for each display item is unique. It only enforces this in certain situations though, so there's cases where we've gotten away without this. Retained display lists introduces more situations where we rely on this, so I've found a few. MathML nsDisplayNotation and nsDisplayMathMLBar are the two fixed by this patch.