searching for reviewer(jya)
b369f6cf661f: Bug 1450845 - Add crashtest for seekToNextFrame when a seek is already in progress. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 07 Jun 2018 09:44:48 -0400 - rev 477577
Push 9386 by nbeleuzu@mozilla.com at 2018-06-23 22:41 +0000
Bug 1450845 - Add crashtest for seekToNextFrame when a seek is already in progress. r=jya MozReview-Commit-ID: 892uIqNuLSg
be60095b4e99: Bug 1450845 - MediaDecoderStateMachine now ignores SeekToNextFrame if already seeking. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 06 Jun 2018 15:17:30 -0400 - rev 477576
Push 9386 by nbeleuzu@mozilla.com at 2018-06-23 22:41 +0000
Bug 1450845 - MediaDecoderStateMachine now ignores SeekToNextFrame if already seeking. r=jya SeekToNextFrame is handled differently than other seeks by the MediaDecoderStateMachine, and should not take place while other seeks already are. Bug 1410225 implemented some changes in HTMLMediaElement to prevent this, but it's still possible to move to a seeking state in the MDSM and accept SeekToNextFrame (as in this bug). This changeset changes the MDSM to reject SeekToNextFrame if a seek is already happening. Since the MDSM now does this the changes from bug 1410225 can be removed. This has the functional change of the promise from SeekToNextFrame being rejected if the seek in not performed due to another seek. Previously the promise would succeed when the other seek completed. This seems sensible as the next frame seek does not actually take place. MozReview-Commit-ID: HD9WRFq3LZV
765bb540a814: Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher. r=jya
Chris Pearce <cpearce@mozilla.com> - Mon, 21 May 2018 14:19:47 +1200 - rev 475938
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher. r=jya We currently observe changes to HTMLMediaElement::mPaused via a hand-rolled wrapper class. We can use use mozilla::Watchable<> and avoid rolling our own equivalent here. This also paves the way for using state watching on other observable state in HTMLMediaElement. MozReview-Commit-ID: 4lBlJiV15iG
789bb9105bd5: Bug 1453127 - Clear output streams on shutdown. r=jya
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 30 May 2018 10:44:56 +0200 - rev 475656
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1453127 - Clear output streams on shutdown. r=jya
b4ee1c9ee23a: Bug 1453127 - Ensure TrackID uniqueness for captured MediaDecoder. r=jya
Andreas Pehrson <pehrsons@mozilla.com> - Tue, 29 May 2018 10:21:51 +0200 - rev 475655
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1453127 - Ensure TrackID uniqueness for captured MediaDecoder. r=jya
303f3b1c85cd: Bug 1453127 - Make sure decoder-captured tracks end when changing src. r=jya
Andreas Pehrson <pehrsons@mozilla.com> - Tue, 29 May 2018 10:13:14 +0200 - rev 475654
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1453127 - Make sure decoder-captured tracks end when changing src. r=jya
a0c658fae24c: Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya
Jan Keromnes <janx@linux.com> - Thu, 31 May 2018 14:52:59 +0300 - rev 474913
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464162 - Make a few vector operations more efficient by reserving size beforehand. r=jya Summary: These automated fixes were generated like so: ./mach configure --enable-clang-plugin ./mach build-backend --backend=CompileDB run-clang-tidy-6.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,performance-inefficient-vector-operation * Reviewers: jya Reviewed By: jya Subscribers: jya Bug #: 1464162 Differential Revision: https://phabricator.services.mozilla.com/D1381
4ae4cc41c1ad: Bug 1465409 - Change lint rules for mediasource tests to prefer no spaces for array notation. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 30 May 2018 08:18:54 -0400 - rev 474875
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465409 - Change lint rules for mediasource tests to prefer no spaces for array notation. r=jya Change rules so we enforce ["foo", "bar"] rather than [ "foo", "bar" ]. MozReview-Commit-ID: KX6wJd8jmeJ
e9d31a050a67: Bug 1462990 - Use async/await in mediasource/test/mediasource.js r=bryce,jya
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 18 May 2018 10:26:11 -0400 - rev 474542
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1462990 - Use async/await in mediasource/test/mediasource.js r=bryce,jya MozReview-Commit-ID: BnQ30DnY4mB
359724bd9ca7: Bug 1461276 - Update telemetry probes for media. r=jya datareview=chutten
Paul Adenot <paul@paul.cx> - Thu, 24 May 2018 15:40:56 +0200 - rev 474312
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461276 - Update telemetry probes for media. r=jya datareview=chutten This makes drno and jya the recipient for the media alert emails, removes cpearce, ajones, and also removes a few people that are not involved with the project anymore (and the some emails were no longer valid anyways). Also, bump a number of probes to 63, to get an updated picture of the data. MozReview-Commit-ID: EmlHyihnxIw
5803745ab436: Bug 1461276 - Update telemetry probes for media. r=jya datareview=chutten
Paul Adenot <paul@paul.cx> - Thu, 24 May 2018 15:40:56 +0200 - rev 474307
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461276 - Update telemetry probes for media. r=jya datareview=chutten This makes drno and jya the recipient for the media alert emails, removes cpearce, ajones, and also removes a few people that are not involved with the project anymore (and the some emails were no longer valid anyways). Also, bump a number of probes to 63, to get an updated picture of the data. MozReview-Commit-ID: EmlHyihnxIw
ff5eea52d8da: Bug 1461540 - Ensure errorMessage is initialized on all code paths in WebAudioDecodeJob::OnFailure(). r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 15 May 2018 13:12:13 +1200 - rev 472988
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461540 - Ensure errorMessage is initialized on all code paths in WebAudioDecodeJob::OnFailure(). r=jya Doesn't look like it's strictly necessary, but suppresses the warning. MozReview-Commit-ID: EQBar71yNVg
abc9351a9c15: Bug 1461785 - Update dom/media/mediasource/test to abide eslint rules, add .eslintrc.js. r=jya,standard8
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 14 May 2018 10:08:59 -0400 - rev 472937
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461785 - Update dom/media/mediasource/test to abide eslint rules, add .eslintrc.js. r=jya,standard8 Add .eslintrc.js to configure globals from mediasource.js and to add extra rules to encourage use of let and const over var. Linting changes: - Prefer const and let to var. This provides tighter scoping and avoids reassignment. - Mozilla rules do not allow for shadowing of variables, so several tests have had promise lists renamed to avoid this. - Numerous minor fixes to formatting including using double quotes, spacing, missing semicolons. - Remove some unused variables. - Arrays have spaces after opening braces and before closing braces, e.g. [ "foo" ], this is to be consistent with our clang-format rules. - Fix naming of resourcePathSeen in test_MediaSource_memory_reporting.html. MozReview-Commit-ID: 5q6oS7EWLTk
1591f55d3e32: Bug 1457359 - Update mp4parse and disable FallibleVec when jemalloc is disabled. r=glandium,jya
Matthew Gregan <kinetik@flim.org> - Thu, 10 May 2018 12:11:51 +1200 - rev 472054
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1457359 - Update mp4parse and disable FallibleVec when jemalloc is disabled. r=glandium,jya Update mp4parse-rust to 0c8e1d91464aaa63b82ebf076b63cda1df4230d1, which adds uuid parsing support and exports the mp4parse_fallible feature from mp4parse_capi. Update gkrust to pass MOZ_MEMORY as a feature, and use that to conditionally enable mp4parse_fallible/FallibleVec. MozReview-Commit-ID: 2HDYbL2CGgJ
b5fac38dc791: Bug 1457359 - Update mp4parse and disable FallibleVec when jemalloc is disabled. r=glandium,jya
Matthew Gregan <kinetik@flim.org> - Thu, 10 May 2018 12:11:51 +1200 - rev 472045
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1457359 - Update mp4parse and disable FallibleVec when jemalloc is disabled. r=glandium,jya Update mp4parse-rust to 0c8e1d91464aaa63b82ebf076b63cda1df4230d1, which adds uuid parsing support and exports the mp4parse_fallible feature from mp4parse_capi. Update gkrust to pass MOZ_MEMORY as a feature, and use that to conditionally enable mp4parse_fallible/FallibleVec. MozReview-Commit-ID: 2HDYbL2CGgJ
0a3654c48315: Bug 1461276 - Update telemetry probes for media. r=jya, datareview=chutten, a=RyanVM
Paul Adenot <paul@paul.cx> - Thu, 24 May 2018 15:40:56 +0200 - rev 471319
Push 9370 by ryanvm@gmail.com at 2018-06-18 14:04 +0000
Bug 1461276 - Update telemetry probes for media. r=jya, datareview=chutten, a=RyanVM This makes drno and jya the recipient for the media alert emails, removes cpearce, ajones, and also removes a few people that are not involved with the project anymore (and the some emails were no longer valid anyways). Also, bump a number of probes to 63, to get an updated picture of the data. MozReview-Commit-ID: EmlHyihnxIw
5218dfec0630: Bug 1453127 - Clear output streams on shutdown. r=jya, a=RyanVM
Andreas Pehrson <pehrsons@mozilla.com> - Wed, 30 May 2018 10:44:56 +0200 - rev 471187
Push 9321 by ryanvm@gmail.com at 2018-06-06 17:54 +0000
Bug 1453127 - Clear output streams on shutdown. r=jya, a=RyanVM
434582a80532: Bug 1453127 - Ensure TrackID uniqueness for captured MediaDecoder. r=jya, a=RyanVM
Andreas Pehrson <pehrsons@mozilla.com> - Tue, 29 May 2018 10:21:51 +0200 - rev 471186
Push 9321 by ryanvm@gmail.com at 2018-06-06 17:54 +0000
Bug 1453127 - Ensure TrackID uniqueness for captured MediaDecoder. r=jya, a=RyanVM
bfe53eb4206e: Bug 1453127 - Make sure decoder-captured tracks end when changing src. r=jya, a=RyanVM
Andreas Pehrson <pehrsons@mozilla.com> - Tue, 29 May 2018 10:13:14 +0200 - rev 471185
Push 9321 by ryanvm@gmail.com at 2018-06-06 17:54 +0000
Bug 1453127 - Make sure decoder-captured tracks end when changing src. r=jya, a=RyanVM
64583d3e0f6f: Bug 1244870 - initialization of err variable r=jya
Jean-Luc Bonnafoux <jeanluc.bonnafoux@wanadoo.fr> - Tue, 24 Apr 2018 20:42:02 +0200 - rev 469456
Push 9171 by ryanvm@gmail.com at 2018-04-28 10:35 +0000
Bug 1244870 - initialization of err variable r=jya MozReview-Commit-ID: 6Zh7tqNdHeu
c4b87fb85648: Bug 1456115 - Increase stack sizes when using audioipc. r=jya
Paul Adenot <paul@paul.cx> - Wed, 25 Apr 2018 12:28:14 +0200 - rev 469070
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1456115 - Increase stack sizes when using audioipc. r=jya This patch set calls a bit deeper in the audio callback thread (down into opus, in particular). MozReview-Commit-ID: 6LWACS6V0Yz
4a1df66695dd: Bug 1456115 - Re-serialize inbound NotifyPull. r=jya
Paul Adenot <paul@paul.cx> - Thu, 12 Apr 2018 14:23:03 +0200 - rev 469068
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1456115 - Re-serialize inbound NotifyPull. r=jya We made NotifyPull parallel to try to lower the load, and we initially measured an improvement. However, we did the measurements with a profiler that did an aggregation of the results. Our results had an high variance, so the mean load was in fact not meaningful. More careful measurement performed without doing any aggregation show that, under load, relying on the fact that the scheduler schedules the tasks on time is too risky, and that the code is fast enough to not have to parallelize. MozReview-Commit-ID: CMhSn8Sc0OO
9c77f5b53b56: Bug 1456115 - Re-serialize inbound NotifyPull. r=jya
Paul Adenot <paul@paul.cx> - Thu, 12 Apr 2018 14:23:03 +0200 - rev 468951
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1456115 - Re-serialize inbound NotifyPull. r=jya We made NotifyPull parallel to try to lower the load, and we initially measured an improvement. However, we did the measurements with a profiler that did an aggregation of the results. Our results had an high variance, so the mean load was in fact not meaningful. More careful measurement performed without doing any aggregation show that, under load, relying on the fact that the scheduler schedules the tasks on time is too risky, and that the code is fast enough to not have to parallelize. MozReview-Commit-ID: CMhSn8Sc0OO
d81ab6f099ee: Bug 1306529 - OmxDataDecoder: Fix a stall issue on shutting down r=jya
Takuro Ashie <ashie@clear-code.com> - Tue, 27 Mar 2018 16:37:21 +0900 - rev 467855
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1306529 - OmxDataDecoder: Fix a stall issue on shutting down r=jya Because the shutdown closure awaits finishing itself by TaskQueue::AwaitShutdownAndIdle(), the function blocks infinitely. The code is wrongly introduced at the following commit: * https://bugzilla.mozilla.org/show_bug.cgi?id=1319987 * https://hg.mozilla.org/mozilla-central/rev/b2171e3e8b69 This patch calls it on mTaskQueue intead of mOmxTaskQueue to avoid the issue. MozReview-Commit-ID: 4qmX2QlniEG
f7db89b0787b: Bug 1306529 - Add initial implementation of PureOmxPlatformLayer r=jya
Takuro Ashie <ashie@clear-code.com> - Wed, 18 Apr 2018 11:38:12 +0900 - rev 467854
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1306529 - Add initial implementation of PureOmxPlatformLayer r=jya It's a concrete class of OmxPlatformLayer for accessing OpenMAX IL libraries directly. It will be usable on various embedded linux systems. Note that it's not enabled by default yet. Add the following config to your mozconfig. ac_add_options --enable-openmax TODO: Implement zero-copy mode MozReview-Commit-ID: EMEXAKzzR64
ba5089a967b9: Bug 1448222 - Remove MediaPrefs. r=jya
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 20 Mar 2018 09:48:56 +1100 - rev 467531
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1448222 - Remove MediaPrefs. r=jya This patch converts all the prefs in MediaPrefs to the new StaticPrefs system. Note that the "media.wmf.skip-blacklist" pref was present in both MediaPrefs and gfxPrefs. The copy in MediaPrefs was never used; this explains why this patch does not add an entry for it to StaticPrefList.h. Note also that the patch removes themedia.rust.mp4parser pref, because it's unused. MozReview-Commit-ID: IfHP37NbIjY
2a39d6a9a949: Bug 1443942 - Move code to toggle high res timers into VideoSink. r=jya
Chris Pearce <cpearce@mozilla.com> - Fri, 06 Apr 2018 13:33:28 +1200 - rev 466075
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Move code to toggle high res timers into VideoSink. r=jya We have code in the MDSM to toggle on high resolution timers on Windows when we start/stop playing because the VideoSink relies on being awoken by timers to update the set of current frames in the compositor's queue, and on Windows 7 we end up dropping frames due to the timer lag without this. We assert in the MDSM's destructor that we've turned off high res timers (as they cause needless battery drain, so we only want them on when we need them), and the new test_mediarecorder_principals is hitting that assert on Windows. I think we're missing turning them off when we create a new VideoSink for outputting to the MSG. That affects the value returned by MediaDecoderStateMachine->mVideoSink->IsPlaying(), which is what we use to decide whether we should enable high resolution timers. We track whether we've enabled high res timers in MDSM::mHiResTimersRequested, and that gets out of sync with IsPlaying() when we re-create the MediaSink. Rather than trying to handle all the permutations of places where we need to turn off high resolution timers in the MDSM, we're better to move the code to toggle high res timers into the VideoSink, as that's actually where we need to be sure that we have high resolution timers enabled anyway. It's the VideoSink after all that is relying on timers for frame update, not the MDSM. Also remove the media.hi-res-timers.enabled pref, as we haven't needed it. MozReview-Commit-ID: 9dNxcYxPDZH
f23060397905: Bug 1443942 - Ensure MediaCacheStreams are initialized with the length of the resource, not the length of the byte range response. r=jya
Chris Pearce <cpearce@mozilla.com> - Wed, 04 Apr 2018 12:36:00 +1200 - rev 466073
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Ensure MediaCacheStreams are initialized with the length of the resource, not the length of the byte range response. r=jya I'm seeing intermittent failures of test_midflight_redirect_blocked. In this test, our custom server responds to Firefox's 0- HTTP Byte Range request with a [0,200] response. When Firefox requests 200-, the server responds with a cross origin redirect, and then the remainder of the resource. However sometimes while running test_midflight_redirect_blocked the MP4 demuxer reads through all 200 bytes while trying to parse metadata before the redirect has occurred and fed more data into the cache, and so the demuxer thinks it's hit end of stream, and reports a failure. The demuxer thinks it's hit end of stream, because we initialize the MediaCacheStream length in ChannelMediaResource::Open() with the value of the Content-Length HTTP header. But in an HTTP byte range response, the Content-Length header tells you the length of the range returned, not the length of the entire resource. The length of the resource is in the Content-Range header, we need to use that if available. So to fix this intermittent test failure, we need to also parse the Content-Range header in ChannelMediaResource::Open(), and use the length from that if available. MozReview-Commit-ID: 29pPRsUvxag
79bd527dd8c8: Bug 1443942 - Fix dom/media/test/midflight-redirect.sjs. r=jya
Chris Pearce <cpearce@mozilla.com> - Wed, 04 Apr 2018 14:30:15 +1200 - rev 466072
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Fix dom/media/test/midflight-redirect.sjs. r=jya Problems here: * The variable `to` is undefined for byte range requests to the end of the resource, making the math fail. Firefox normally makes ranges requests like this. * The bytes.length/4 calculation may not be a whole number, so can result in a byte range header part of the way between two bytes. We need to round the length off. * Instead of re-calculating the contentLength, we can just use the length of the actual byterange substring being returned. That's clearer. * test_midflight_redirect_blocked needs the redirect to happen before metadata has completed loading, but other tests require the redirect to happen *after* metadata is loaded. So add a redirectAt query parameter for the requester to control when to redirect. MozReview-Commit-ID: I6n1NqK0Uze
e02b7f9e296d: Bug 1443942 - Switch over to midflight redirect for all redirect media tests. r=jya
Chris Pearce <cpearce@mozilla.com> - Thu, 29 Mar 2018 18:16:33 +1300 - rev 466071
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Switch over to midflight redirect for all redirect media tests. r=jya We have two SJS files; midflight-redirect.sjs and dynamic_redirect.sjs, which are very similar, but dynamic_redirect.sjs is buggy, so we should just use midflight-redirect.sjs. dynamic_redirect.sjs is buggy because it relies on the client doing multiple HTTP requests to it in order to redirect, but we can't actually guarantee this. Previously users of it would try things like setting a small MediaCache size, or only using Ogg for which we expect a seek to the end to calculate the duration, but I have observed the entire resource being downloaded in one hit before the media element has finished loading metadata, meaning the seek (in the Ogg case) can happen without another HTTP request. This is even with a small MediaCache. midfligh-redirect.sjs solves this problem by explicitly only returning a partial response, so the client is forced to make another HTTP request, which we will serve a redirect to. MozReview-Commit-ID: 39imyayhnBG
482dbcc619ce: Bug 1443942 - Rewrite test_mixed_principals. r=jya
Chris Pearce <cpearce@mozilla.com> - Wed, 28 Mar 2018 16:56:37 +1300 - rev 466070
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Rewrite test_mixed_principals. r=jya The original test is failing, as it assumed we'd not error when origins were mixed without CORS, and the original test was using outdated practises, so rewrite it. MozReview-Commit-ID: KlOH83GUOk
ee486ce2d660: Bug 1443942 - Make redirect SJS' serve with headers to prevent Necko caching. r=jya
Chris Pearce <cpearce@mozilla.com> - Wed, 28 Mar 2018 16:55:46 +1300 - rev 466069
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Make redirect SJS' serve with headers to prevent Necko caching. r=jya Try to prevent Necko from caching the results of our SJS media responses, as some of the test that use it rely on the server being hit and serving a redirect. Sometimes the tests which rely on hitting a redirect in an SJS where timing out without this, as Necko would cache the response and not hit the server, and so not hit the redirect. Also include a noise parameter to increase the likelihood that the URL is unique, to further reduce the chance that Necko caches the result. MozReview-Commit-ID: 3cLEiDoh4HG
53d478be2796: Bug 1443943 - Ensure redirect SJS' serve the correct content types. r=jya
Chris Pearce <cpearce@mozilla.com> - Wed, 28 Mar 2018 16:51:04 +1300 - rev 466068
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443943 - Ensure redirect SJS' serve the correct content types. r=jya dynamic_redirect.sjs and midflight-redirect.sjs are serving files with "Content-Type: video/ogg", which is incorrect and could lead to problems given that we're not always asking it to serve Ogg files. So include the type be to served as a query parameter. MozReview-Commit-ID: 5f0PXy8lL3G
038cca3ed2ca: Bug 1443942 - Test for blocking midflight redirects in media elements. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 06 Mar 2018 14:44:26 +1300 - rev 466067
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Test for blocking midflight redirects in media elements. r=jya Test that playback works if we don't block, doesn't if we do block, and does if we do block and CORS is used. MozReview-Commit-ID: 9PTZXLOdHIU
d8c358ea16eb: Bug 1443942 - Block mid-flight redirects to cross origin destinations during media loads. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 06 Mar 2018 09:55:03 +1300 - rev 466066
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443942 - Block mid-flight redirects to cross origin destinations during media loads. r=jya There's no compelling use case for mid-flight redirects, and Chrome already blocks it, so there's little point in maintaining it. Add a hidden pref to toggle blocking, so we can toggle it off during testing to ensure that we're blocking a working mid-flight redirect. MozReview-Commit-ID: EnGNmYFr8Uv
87206102c699: Bug 1306529 - OmxDataDecoder: Fix a stall issue on shutting down r=jya
Takuro Ashie <ashie@clear-code.com> - Tue, 27 Mar 2018 16:37:21 +0900 - rev 465891
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1306529 - OmxDataDecoder: Fix a stall issue on shutting down r=jya Because the shutdown closure awaits finishing itself by TaskQueue::AwaitShutdownAndIdle(), the function blocks infinitely. The code is wrongly introduced at the following commit: * https://bugzilla.mozilla.org/show_bug.cgi?id=1319987 * https://hg.mozilla.org/mozilla-central/rev/b2171e3e8b69 This patch calls it on mTaskQueue intead of mOmxTaskQueue to avoid the issue. MozReview-Commit-ID: 4qmX2QlniEG
7e70a7f597c4: Bug 1306529 - Add initial implementation of PureOmxPlatformLayer r=jya
Takuro Ashie <ashie@clear-code.com> - Wed, 28 Mar 2018 18:21:04 +0900 - rev 465890
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1306529 - Add initial implementation of PureOmxPlatformLayer r=jya It's a concrete class of OmxPlatformLayer for accessing OpenMAX IL libraries directly. It will be usable on various embedded linux systems. Note that it's not enabled by default yet. Add the following config to your mozconfig. ac_add_options --enable-openmax TODO: Implement zero-copy mode MozReview-Commit-ID: EMEXAKzzR64
8fc7e04ebbf4: Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion. r=jya
Alex Chronopoulos <achronop@gmail.com> - Mon, 09 Apr 2018 13:07:58 +0300 - rev 465879
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1451781 - Check if output device is mono and remove stereo check in order to disable opus channel inversion. r=jya MozReview-Commit-ID: 3x27rBs5Ika
b2904f128f85: Bug 1448705: use input latency for draining r=jya
Randell Jesup <rjesup@jesup.org> - Thu, 05 Apr 2018 17:15:07 -0400 - rev 465575
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1448705: use input latency for draining r=jya
0c1f66e827e8: Bug 1447821 - Add logging to ADTSSampleConverter ctor. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Mon, 26 Mar 2018 14:29:31 -0400 - rev 463738
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1447821 - Add logging to ADTSSampleConverter ctor. r=jya Add logging to aid in debugging of our EME ADTS conversion path. MozReview-Commit-ID: A7Wv8n31V8V
bf78f178cc7f: Bug 1447821 - Update EMEDecoderModule to handle profile values < 1. r=jya
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 23 Mar 2018 14:54:41 -0400 - rev 463737
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1447821 - Update EMEDecoderModule to handle profile values < 1. r=jya Update EMEDecoderModule to use 2 as profile number when the given profile is less than 1 or greater than 4. The CDM doesn't appear to care what values are given, but 2 was chosen as a safe fallback per discussion on the bug. This addresses the use case where 0 values are stored in mProfile due to the use of extended profiles (which are then stored in the mExtendedProfile field). MozReview-Commit-ID: 5XgabNDsgdf
fc9024c91420: Bug 1446929 - Support audio files in media Benchmark class. r=jya
Christian Holler <choller@mozilla.com> - Tue, 27 Mar 2018 14:07:12 +0200 - rev 463722
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1446929 - Support audio files in media Benchmark class. r=jya MozReview-Commit-ID: 3EWNM1F4loN
f5bd43e4e83d: Bug 1446932 - Handle nullptr in FlacFrameParser::GetTags. r=jya
Christian Holler <choller@mozilla.com> - Tue, 27 Mar 2018 13:02:15 +0200 - rev 463718
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1446932 - Handle nullptr in FlacFrameParser::GetTags. r=jya MozReview-Commit-ID: I50zXqUUD7x
cc799615ea60: Bug 1448627 - Update cubeb to 7712aaab. r=jya
Paul Adenot <paul@paul.cx> - Sun, 25 Mar 2018 11:33:26 +0200 - rev 463386
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1448627 - Update cubeb to 7712aaab. r=jya MozReview-Commit-ID: HbYayQvtQQc
2bbfded200e0: Bug 1432779 - Rust vendor. r=jya
Dan Glastonbury <dan.glastonbury@gmail.com> - Thu, 22 Mar 2018 20:10:19 +1000 - rev 463328
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1432779 - Rust vendor. r=jya MozReview-Commit-ID: 5FQjIPBWTEZ
b98af64fa15c: Bug 1432779 - Update cubeb-pulse-rs to commit 247b01d. r=jya
Dan Glastonbury <dan.glastonbury@gmail.com> - Thu, 22 Mar 2018 19:42:39 +1000 - rev 463327
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1432779 - Update cubeb-pulse-rs to commit 247b01d. r=jya MozReview-Commit-ID: ACsPdk19RoA
408c4c89868d: Bug 1437366 - Set the correct (possibly clamped) rate on the MediaStreamTrack when the MSG runs at a rate not compatible with the webrtc.org code, and fix interval calculation. r=jya,pehrsons
Paul Adenot <paul@paul.cx> - Mon, 05 Mar 2018 13:31:00 +0100 - rev 462557
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1437366 - Set the correct (possibly clamped) rate on the MediaStreamTrack when the MSG runs at a rate not compatible with the webrtc.org code, and fix interval calculation. r=jya,pehrsons MozReview-Commit-ID: HOPjfdUJBSU
d9c664130c22: Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:41:46 +1300 - rev 461541
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1445104 - Format HTMLMediaElement constructor with leading ',' instead of trailing. r=jya MozReview-Commit-ID: DiRjKmtERGq
e8a5c35df168: Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:33:42 +1300 - rev 461540
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1445104 - Remove HTMLMediaElement::{mStatsShowing,mMediaSecurityVerified} as they're unused. r=jya MozReview-Commit-ID: LtKw4Hj3M0G
e865836987b3: Bug 1445104 - Initialize HTMLMediaElement fields in class declaration. r=jya
Chris Pearce <cpearce@mozilla.com> - Tue, 13 Mar 2018 13:32:05 +1300 - rev 461539
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1445104 - Initialize HTMLMediaElement fields in class declaration. r=jya This makes the constructor simpler. MozReview-Commit-ID: 30CO1iBj4rH