searching for reviewer(jwatt)
b6f29aa89d9bf40df981ccd36d1bd6c7f6da24b3: Bug 1777293 - Implement Element.checkVisibility(). r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Aug 2022 17:28:04 +0000 - rev 699224
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1777293 - Implement Element.checkVisibility(). r=jwatt Implement it with a "no-flush" ChromeOnly option so that things like bug 1783045 can use it without causing flashes of unstyled content, etc. Differential Revision: https://phabricator.services.mozilla.com/D155206
495ffb27c683fe2219b559708d3eb415847faa10: Bug 1782596 - Propagate preferred color-scheme to non-top frames. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Aug 2022 14:23:09 +0000 - rev 699185
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1782596 - Propagate preferred color-scheme to non-top frames. r=jwatt The ColorSchemeMode::Preferred change doesn't make a difference (that is, always use the preferred one), since when we only propagate from top's embedder the embedder is chrome, which always has the preferred color-scheme. Differential Revision: https://phabricator.services.mozilla.com/D154931
caf2468b70be8691d1531918cef2f3443d4adf68: Bug 1782596 - Propagate preferred color-scheme to non-top frames. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 21 Aug 2022 21:34:01 +0000 - rev 698996
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782596 - Propagate preferred color-scheme to non-top frames. r=jwatt The ColorSchemeMode::Preferred change doesn't make a difference (that is, always use the preferred one), since when we only propagate from top's embedder the embedder is chrome, which always has the preferred color-scheme. Differential Revision: https://phabricator.services.mozilla.com/D154931
fce170c26768d739918ab76f3a003df985ea7e3a: Bug 1780455 - Fix an assertion to account for imagemap hacks. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jul 2022 15:57:14 +0000 - rev 695813
Push 16885 by ffxbld-merge at Mon, 25 Jul 2022 15:04:18 +0000
Bug 1780455 - Fix an assertion to account for imagemap hacks. r=jwatt I tried to add a crashtest without the video attachment and so on but that didn't quite make it. Differential Revision: https://phabricator.services.mozilla.com/D152374
70c7d7b7502ffb751f9de51b1a7b60b4231e701f: Bug 1777982 - Some minor cleanups in nsCSSProps.h. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Jul 2022 22:22:18 +0000 - rev 694743
Push 16885 by ffxbld-merge at Mon, 25 Jul 2022 15:04:18 +0000
Bug 1777982 - Some minor cleanups in nsCSSProps.h. r=jwatt Drive-by, but might as well remove this useless namespacing. Depends on D151594 Differential Revision: https://phabricator.services.mozilla.com/D151595
709e57b20c535aff2487e748cc889d3d8ac9ac50: Bug 1778747: Allowlist the other, very similar, printer preference tree r=jwatt
Tom Ritter <tom@mozilla.com> - Tue, 12 Jul 2022 14:14:29 +0000 - rev 694696
Push 16885 by ffxbld-merge at Mon, 25 Jul 2022 15:04:18 +0000
Bug 1778747: Allowlist the other, very similar, printer preference tree r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D151527
0e8db6f687c468c97f4c96d13f23355b4fd7bb6c: Bug 1774946 - Check for allowed colors recursively in forced-colors mode. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Jun 2022 14:07:12 +0000 - rev 692313
Push 16793 by ffxbld-merge at Mon, 27 Jun 2022 15:12:58 +0000
Bug 1774946 - Check for allowed colors recursively in forced-colors mode. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D149733
6fb2ab75b12bbd9708b2476aa2c5e520b776ff02: Bug 1770729 - Fix IntersectionObserver overflow: clip on zero-sized elements. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 May 2022 13:52:48 +0000 - rev 689198
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1770729 - Fix IntersectionObserver overflow: clip on zero-sized elements. r=jwatt I realized my fix in bug 1769512 (using IsEmpty()) wasn't quite correct in this case, because IntersectionObserver preserves edge-inclusive intersections. Differential Revision: https://phabricator.services.mozilla.com/D147078
0368bdfdea8ec8200ee1dd6602e0cf4d4da05430: Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 May 2022 07:21:43 +0000 - rev 689168
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D146432
55417342979d9b6101e8f9d4021ce8d9166b5a9d: Bug 1767374 - Update cssparser. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 21 May 2022 17:22:53 +0000 - rev 689100
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1767374 - Update cssparser. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D146995
c2e0177263236907964538c9ad8a96f37162b110: Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 17:43:58 +0000 - rev 689066
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769512 - Implement overflow-clip-margin: <length>. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D146432
f0c4c97a8e6aa34214f287cb499321b6a0186c2f: Bug 1738380 - Draw backgrounds of iframes with mismatched embedder color schemes. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 15:20:34 +0000 - rev 689052
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1738380 - Draw backgrounds of iframes with mismatched embedder color schemes. r=jwatt In the future we might want to (also?) propagate the prefers-color-scheme on the iframe like we do for the content/chrome boundary / top browsing contexts, see: * https://github.com/w3c/csswg-drafts/issues/4772 * https://github.com/w3c/csswg-drafts/issues/7213 Differential Revision: https://phabricator.services.mozilla.com/D146162
0d8f25c4388af0894425506e71024044f4d3402a: Bug 1769512 - Support both negative and positive offsets in border radius adjustments. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 15:16:39 +0000 - rev 689051
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769512 - Support both negative and positive offsets in border radius adjustments. r=jwatt Depends on D146430 Differential Revision: https://phabricator.services.mozilla.com/D146431
135f6d473a24298f8343c28884a775013e4313f6: Bug 1768285 - Clean up unused -moz-window-shadow values. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 23:20:48 +0000 - rev 688735
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1768285 - Clean up unused -moz-window-shadow values. r=jwatt After bug 1768278 and bug 1767815 there's no more uses of the cliprounded value in the tree (also it causes artifacts on HiDPI screens so we probably don't want new usages). The "sheet" value is unused, and the other values other than "default" and "none" are only derived from "default", so they don't need to be exposed in the style system. Differential Revision: https://phabricator.services.mozilla.com/D145821
a193c9399ab4f76e74811c560b8e2ab4b18bf1cf: Bug 1769832: Move a print-related #include to an ifdef-guarded section, to fix compile error with --disable-printing. r=jwatt
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 17 May 2022 21:55:45 +0000 - rev 688718
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769832: Move a print-related #include to an ifdef-guarded section, to fix compile error with --disable-printing. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D146627
1b654110d225e6d416c8164179c2ac6931704b49: Bug 1769775 - Add a MozPromise version of CanonicalBrowsingContext::Print. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 16:02:35 +0000 - rev 688566
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769775 - Add a MozPromise version of CanonicalBrowsingContext::Print. r=jwatt And use it to implement the JS version of the method. This should avoid the various complications that bug 1659819 hit. Differential Revision: https://phabricator.services.mozilla.com/D146590
8027f6771a74487960e588a23e3eae848d5eff5c: Bug 1769769 - Don't generate nsIPrintDialogService.h in the source dir. r=jwatt a=graft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 15:11:35 +0000 - rev 688557
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769769 - Don't generate nsIPrintDialogService.h in the source dir. r=jwatt a=graft It seems the order of XPIDL_SOURCES vs. XPIDL_MODULE is important. Differential Revision: https://phabricator.services.mozilla.com/D146579
d79f367b7aad800265fbd330d471a8445cda47a9: Bug 1769769 - Don't generate nsIPrintDialogService.h in the source dir. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 May 2022 15:11:35 +0000 - rev 688554
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769769 - Don't generate nsIPrintDialogService.h in the source dir. r=jwatt It seems the order of XPIDL_SOURCES vs. XPIDL_MODULE is important. Differential Revision: https://phabricator.services.mozilla.com/D146579
ce1de25028672d40508bae9306bd2eb1133e0d10: Bug 1769263 - Remove layout.css.line-height.normal-as-resolved-value.enabled. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 13 May 2022 19:28:40 +0000 - rev 687941
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1769263 - Remove layout.css.line-height.normal-as-resolved-value.enabled. r=jwatt It's been enabled-by-default for years. Differential Revision: https://phabricator.services.mozilla.com/D146309
96b07fabcc110a87dd3e1032a631c13b41e284d9: Bug 1768157 - Remove kSelectPopupList. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 May 2022 15:46:49 +0000 - rev 687182
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1768157 - Remove kSelectPopupList. r=jwatt It's unused since bug 1744009 at least, so no behavior change. Depends on D145714 Differential Revision: https://phabricator.services.mozilla.com/D145715
e8b41cbc0c9fa0140ad2b88c55a02048d09c6508: Bug 1768157 - Remove unused menulist button styles and resources. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 May 2022 15:19:45 +0000 - rev 687176
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1768157 - Remove unused menulist button styles and resources. r=jwatt The non-native theme draws the button arrow nowadays always, so these backgrounds never really get painted. No behavior change. Depends on D145713 Differential Revision: https://phabricator.services.mozilla.com/D145714
3a4c98a2d6a78acb6479ba9784f23340f245892e: Bug 1768157 - Remove unneeded !important declarations from forms.css for the select button. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 May 2022 14:45:50 +0000 - rev 687173
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1768157 - Remove unneeded !important declarations from forms.css for the select button. r=jwatt The select button is native anonymous so it can't be overridden by content anyways. This patch doesn't change behavior. Depends on D145712 Differential Revision: https://phabricator.services.mozilla.com/D145713
1ce090cbb73bbab346cf826c83c92c7d5408b31a: Bug 1768155 - Allow nsComboboxControlFrame to be laid out without a <button>. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 06 May 2022 14:45:49 +0000 - rev 687172
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
Bug 1768155 - Allow nsComboboxControlFrame to be laid out without a <button>. r=jwatt Don't generate the button if the combobox doesn't need it anyways (if the appearance is not menulist). While at it improve the code that reframes on appearance: textfield changes so that it only applies to number inputs as it should. This shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D145712
426217dec9ed1d44c05a3fc169f31fd92e32bbec: Bug 1766718 - Add NS_PRINT to prevent build break. r=jwatt
Seinlin <seinlin.maung@gmail.com> - Thu, 28 Apr 2022 08:09:14 +0000 - rev 686019
Push 16598 by ffxbld-merge at Mon, 02 May 2022 14:23:32 +0000
Bug 1766718 - Add NS_PRINT to prevent build break. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D144888
132a5b2c52e7656f8aeacbcdb03647788914d892: Bug 1760316 - Add another Canon entry to the monochrome settings list. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 19 Mar 2022 16:48:25 +0000 - rev 681298
Push 16502 by ffxbld-merge at Mon, 04 Apr 2022 15:15:04 +0000
Bug 1760316 - Add another Canon entry to the monochrome settings list. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D141499
da4c45d3e93ee2958ff1a233616b6c903031e673: Bug 1758974 - Reuse inherited custom properties if they didn't change after resolution. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Mar 2022 18:12:56 +0000 - rev 680677
Push 16502 by ffxbld-merge at Mon, 04 Apr 2022 15:15:04 +0000
Bug 1758974 - Reuse inherited custom properties if they didn't change after resolution. r=jwatt This should be cheap and gives us a lot of memory savings for the page on the bug, by deduplicating the inherited properties between parent and children. WebKit implements a similar optimization. Differential Revision: https://phabricator.services.mozilla.com/D140826
7155ccc1c9feb4984d37e8add5618c943869749b: Bug 1758974 - Make custom-property substitution only traverse variables which could have references. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Mar 2022 18:12:55 +0000 - rev 680676
Push 16502 by ffxbld-merge at Mon, 04 Apr 2022 15:15:04 +0000
Bug 1758974 - Make custom-property substitution only traverse variables which could have references. r=jwatt If a name is not in self.seen, it means we've inherited it from our parent. That in turn means that it can't have any variable reference (because we inherit the computed variables) and we can skip the work of traversing it, as we'd hit the early-return in traverse() anyways. This doesn't fix the memory usage issue of the page on the bug, which has a giant list of properties on the root and then a custom property specified on all elements, but should significantly reduce the time we spend iterating over custom properties for all those elements. Differential Revision: https://phabricator.services.mozilla.com/D140825
12e1eb49424dc9764ce45210abcee6bf3ffe9dc8: Bug 1758029: Gracefully bail out of canvas SVG-filter invalidation codepath, if the canvas has been unlinked due to cycle collection. r=jwatt
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 08 Mar 2022 23:08:32 +0000 - rev 680309
Push 16502 by ffxbld-merge at Mon, 04 Apr 2022 15:15:04 +0000
Bug 1758029: Gracefully bail out of canvas SVG-filter invalidation codepath, if the canvas has been unlinked due to cycle collection. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D140419
99cf7aba706c81fa216271d38a4d196628dc890e: Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 28 Feb 2022 14:33:29 +0000 - rev 679216
Push 16409 by ffxbld-merge at Tue, 08 Mar 2022 09:45:25 +0000
Bug 1749537 - remove obsolete _formatPrintButtonShortcuts(), r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D135949
e886d63306282828c3d562467074d5a57d308a89: Bug 1746795 - Make gfxPlatformFontList::CommonFontFallback honor a preference for emoji presentation when searching its font list, rather than just returning the first match for the codepoint. r=jwatt
Jonathan Kew <jkew@mozilla.com> - Tue, 25 Jan 2022 16:18:06 +0000 - rev 675352
Push 16310 by ffxbld-merge at Mon, 07 Feb 2022 15:08:47 +0000
Bug 1746795 - Make gfxPlatformFontList::CommonFontFallback honor a preference for emoji presentation when searching its font list, rather than just returning the first match for the codepoint. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D136730
258cab44142bbf2f2049b001dea3c21dfa8acc1f: Bug 1746795 - Make gfxPlatformFontList::CommonFontFallback honor a preference for emoji presentation when searching its font list, rather than just returning the first match for the codepoint. r=jwatt, a=RyanVM
Jonathan Kew <jkew@mozilla.com> - Tue, 25 Jan 2022 16:18:06 +0000 - rev 673877
Push 16288 by ryanvm@gmail.com at Wed, 26 Jan 2022 15:11:59 +0000
Bug 1746795 - Make gfxPlatformFontList::CommonFontFallback honor a preference for emoji presentation when searching its font list, rather than just returning the first match for the codepoint. r=jwatt, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D136730
944668ceb2740105c176b5b22d6ac4a1cb5ff3c2: Bug 1747595 - Make color-adjust an alias of print-color-adjust as per spec. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 29 Dec 2021 21:52:25 +0000 - rev 673099
Push 16213 by ffxbld-merge at Mon, 10 Jan 2022 14:37:06 +0000
Bug 1747595 - Make color-adjust an alias of print-color-adjust as per spec. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D134779
f18f0c33b55b9d1ffc8697f5796427917bc45654: Bug 1742362 - Improve error handling of nsDeviceContext. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 21 Dec 2021 18:53:14 +0000 - rev 672542
Push 16213 by ffxbld-merge at Mon, 10 Jan 2022 14:37:06 +0000
Bug 1742362 - Improve error handling of nsDeviceContext. r=jwatt I think what's going on is that we get AbortDocument(), then BeginPage(). It's not too unreasonable that this can happen more often on macOS 12, since BeginPage() can run off a timer and we had bugs about printing being slow in those systems (which presumably make users more likely to cancel printing?). Anyways add some null-checks and promote some assertions to DIAGNOSTIC_ASSERTs so that we can catch the bad state ASAP. Differential Revision: https://phabricator.services.mozilla.com/D134313
ce9483d8d18f63f2594ecd3d5444123594248873: Bug 1744749 - Add an API to get the real canvas background color. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Dec 2021 14:56:32 +0000 - rev 671952
Push 16213 by ffxbld-merge at Mon, 10 Jan 2022 14:37:06 +0000
Bug 1744749 - Add an API to get the real canvas background color. r=jwatt Extensions are using getComputedStyle(body).backgroundColor, which is wrong at multiple levels. The one that matters for this bug is that it is not color-scheme aware. Depends on D133770 Differential Revision: https://phabricator.services.mozilla.com/D133771
72adcadcd2fdff006e3782aff6a5e379ff693f7f: Bug 1715387 - Flush style properly for DOM APIs which use d property. r=jwatt,hiro,emilio
Boris Chiou <boris.chiou@gmail.com> - Mon, 13 Dec 2021 01:03:39 +0000 - rev 671518
Push 16213 by ffxbld-merge at Mon, 10 Jan 2022 14:37:06 +0000
Bug 1715387 - Flush style properly for DOM APIs which use d property. r=jwatt,hiro,emilio In order to make sure these APIs work properly, we have to flush style before building the path to make sure the d property is up-to-date. 1. isPointInFill() 2. isPointInStroke() 3. getTotalLength() 4. getPointAtLength() 5. getPathSegAtLength() (note: Legacy API, only Gecko and WebKit support.) Differential Revision: https://phabricator.services.mozilla.com/D133434
82ed4d9f0a5c0bc95578422cfc8e5d159de45b31: Bug 1744749 - Add an API to get the real canvas background color. r=jwatt,a=dsmith
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Dec 2021 14:56:32 +0000 - rev 670667
Push 16171 by dsmith@mozilla.com at Tue, 21 Dec 2021 15:50:56 +0000
Bug 1744749 - Add an API to get the real canvas background color. r=jwatt,a=dsmith Extensions are using getComputedStyle(body).backgroundColor, which is wrong at multiple levels. The one that matters for this bug is that it is not color-scheme aware. Depends on D133770 Differential Revision: https://phabricator.services.mozilla.com/D133771
e2dc9aa72ad982a4d2e9b3ed75757a892a14e1f4: Bug 1743027 - Simplify plaintext.css dark mode code. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Nov 2021 15:06:51 +0000 - rev 670057
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1743027 - Simplify plaintext.css dark mode code. r=jwatt Now that we have dark color-scheme everywhere we don't need to hard-code this. Differential Revision: https://phabricator.services.mozilla.com/D132187
330e483cb0e40ed3343e26bb03e393fa0338478d: Bug 1741593 - Setting MOZ_APP_* values should not depend on launcher process. r=jwatt
Mike Kaply <mozilla@kaply.com> - Wed, 17 Nov 2021 23:03:27 +0000 - rev 668952
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1741593 - Setting MOZ_APP_* values should not depend on launcher process. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D131394
2f40a908044e148079d0db8f2dc86571b73d9149: Bug 1669149 p7: Always use size from device context for print paper size on Windows. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:05 +0000 - rev 668731
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p7: Always use size from device context for print paper size on Windows. r=jwatt This is always available and makes it more consistent for comparing print settings. Also change to round when converting back to DEVMODE for better accuracy. Depends on D99810 Differential Revision: https://phabricator.services.mozilla.com/D99811
9cd220f0da6006471f6e4873c0fc95939d29ce50: Bug 1669149 p6: Change print settings stored as floats to be stored as doubles. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:04 +0000 - rev 668730
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p6: Change print settings stored as floats to be stored as doubles. r=jwatt This more precisely matches what we get from the printer and use in layout. Depends on D99808 Differential Revision: https://phabricator.services.mozilla.com/D99810
7cc7109100a6ac7b05658521e9bf0417ea406927: Bug 1669149 p5: Make nsPrintSettingsService::ReadPrefs return NS_ERROR_NOT_AVAILABLE, not NS_OK, if no prefs are read. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:04 +0000 - rev 668729
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p5: Make nsPrintSettingsService::ReadPrefs return NS_ERROR_NOT_AVAILABLE, not NS_OK, if no prefs are read. r=jwatt This allows us to detect if any prefs were read in JavaScript. Depends on D99807 Differential Revision: https://phabricator.services.mozilla.com/D99808
a969b3be9e10e77f2e31ad55c7bdea7f7863c0c4: Bug 1669149 p4: Change unwriteable margin pref to be stored in twips. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:04 +0000 - rev 668728
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p4: Change unwriteable margin pref to be stored in twips. r=jwatt This means that more precise values can be stored, so that they match what we actually retrieve from the printer and use in layout. Depends on D99806 Differential Revision: https://phabricator.services.mozilla.com/D99807
1fb0f7dc84a9c5e7c68b56e6a66561177356a544: Bug 1669149 p3: Never go back to the parent for print settings with tab modal print UI. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:03 +0000 - rev 668727
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p3: Never go back to the parent for print settings with tab modal print UI. r=jwatt Depends on D105824 Differential Revision: https://phabricator.services.mozilla.com/D99806
6e70617cbb792926afef0773aef6c736f99c523a: Bug 1669149 p2: Update the printer's DefaultSettings with the global settings. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:03 +0000 - rev 668726
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p2: Update the printer's DefaultSettings with the global settings. r=jwatt Depends on D98458 Differential Revision: https://phabricator.services.mozilla.com/D105824
2f7c6dff65fc9e0bc21369d0a6c4ad388e017119: Bug 1669149 p1: Introduce nsIPrintSettings::EquivalentTo and nsIPrinter::CopyFromWithValidation. r=jwatt
Bob Owen <bobowencode@gmail.com> - Tue, 16 Nov 2021 08:17:02 +0000 - rev 668725
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1669149 p1: Introduce nsIPrintSettings::EquivalentTo and nsIPrinter::CopyFromWithValidation. r=jwatt This is to allow settings saved in prefs to be validated against a printer and for print preview to be updated if any changes affecting layout occur. Differential Revision: https://phabricator.services.mozilla.com/D98458
1b335acf7f139b32671a75980be0d78149e31973: Bug 1739894 - Stop including overflowing descendants in outlines. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Nov 2021 20:00:13 +0000 - rev 668378
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1739894 - Stop including overflowing descendants in outlines. r=jwatt Keep old behavior behind a pref. I've kept the tests that failed enabling the pref because they're somewhat hard to rewrite and I'd rather avoid that until we know this will stick, specially since they test the guts of the recursive function that I'm basically ~disabling. I've checked that the rendering on those is sensible / matches other browsers. Differential Revision: https://phabricator.services.mozilla.com/D130717
492b433034b3f9021ee2a8ad67277f4183c9cd80: Bug 1739894 - Stop including overflowing descendants in outlines. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 10 Nov 2021 15:24:30 +0000 - rev 668340
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1739894 - Stop including overflowing descendants in outlines. r=jwatt Keep old behavior behind a pref. I've kept the tests that failed enabling the pref because they're somewhat hard to rewrite and I'd rather avoid that until we know this will stick, specially since they test the guts of the recursive function that I'm basically ~disabling. I've checked that the rendering on those is sensible / matches other browsers. Differential Revision: https://phabricator.services.mozilla.com/D130717
f09021021385b0457e9c0dcea9eb74e9cf822629: Bug 1707643 part 1: Non-functional test cleanup (mostly in reference cases) for grid "last-baseline" alignment tests. r=jwatt,emilio
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 09 Nov 2021 06:14:21 +0000 - rev 668064
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1707643 part 1: Non-functional test cleanup (mostly in reference cases) for grid "last-baseline" alignment tests. r=jwatt,emilio These tests were previously split out from the more general alignment tests (which live alongside them without "last-baseline" in their filename). These last-baseline-specific tests are meant to compartmentalize the "last baseline" alignment value, since not all browser engines implement that yet. (And then the more general sibling-test covers all of the other alignment modes.) In that previous splitting-out task, the last-baseline reference cases carried along some cruft that turned out not to be necessary. In particular: they only need to mock up "end" alignment, but they received some copypasted CSS rules for "start" and "center" alignment as well, and those rules are unused. This patch removes those unused rules. It also makes a cosmetic change to grid-abspos-staticpos-justify-self-img-last-baseline-002.html (and its reference case), to match the styling used in its non-"last-baseline" analog (grid-abspos-staticpos-justify-self-img-002.html). This cosmetic change just avoids near-overlap between adjacent content in the test, and doesn't impact the actual functionality being tested. Differential Revision: https://phabricator.services.mozilla.com/D130712
a3bf09c4c539845ea40134ab8e54644be968c765: Bug 1738693 - Serialize image local refs as local. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 08 Nov 2021 14:30:36 +0000 - rev 667962
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738693 - Serialize image local refs as local. r=jwatt As per https://github.com/w3c/csswg-drafts/issues/3195 If we ship this, then we can simplify a bunch of code (we can remove SpecifiedImageUrl / ComputedImageUrl and co). Differential Revision: https://phabricator.services.mozilla.com/D130160
d530a84aee25df1f7e3ac7294b66dcac4f3cb3fe: Bug 1507308 - Serialize mask using servo. r=jwatt
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 08 Nov 2021 14:29:52 +0000 - rev 667961
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1507308 - Serialize mask using servo. r=jwatt text-decoration is dealt with in D130018. Remove the test that checks that we don't serialize mask with various non-default properties since now we serialize it correctly. Remove mask from another test, because with this patch we start serializing the url like the mask-image shorthand, which would also fail this test. Making serialization consistent with the longhand makes sense IMO. There's https://github.com/w3c/csswg-drafts/issues/3195 to make image serialization and non-image URL serialization consistent. Will try to fix that in the coming days. After that we can re-add mask/mask-image to that test. Differential Revision: https://phabricator.services.mozilla.com/D130095