searching for reviewer(jolin)
6dddcf3ed69f9fca47fe69fc4269f2475614df94: Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin
Jon Bauman <jbauman@mozilla.com> - Mon, 03 Jan 2022 19:39:46 +0000 - rev 673264
Push 16213 by ffxbld-merge at Mon, 10 Jan 2022 14:37:06 +0000
Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D134232
17fbdf16f20fb5bd172bfdf80700fee14965a574: Bug 1529581 - Update some more webrtc::VideoFrame ctors. r=bwc,jolin
Andreas Pehrson <apehrson@mozilla.com> - Wed, 03 Nov 2021 15:23:28 +0000 - rev 667601
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1529581 - Update some more webrtc::VideoFrame ctors. r=bwc,jolin This also fixes what looks like a bug with the timestamp (wrong base) in WebrtcMediaDataDecoderCodec. Differential Revision: https://phabricator.services.mozilla.com/D128250
8a8ee5055c0dd414ef3d5c325cc1ed10ebcdeb4f: Bug 1529581 - Update some more webrtc::VideoFrame ctors. r=bwc,jolin
Andreas Pehrson <apehrson@mozilla.com> - Tue, 02 Nov 2021 14:35:59 +0000 - rev 667444
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1529581 - Update some more webrtc::VideoFrame ctors. r=bwc,jolin This also fixes what looks like a bug with the timestamp (wrong base) in WebrtcMediaDataDecoderCodec. Differential Revision: https://phabricator.services.mozilla.com/D128250
42baadc27ce54d045b4270a46553a7741d497cbe: Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin
Jon Bauman <jbauman@mozilla.com> - Wed, 06 Oct 2021 19:02:15 +0000 - rev 664190
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin Fix clang-tidy lints Depends on D127291 Differential Revision: https://phabricator.services.mozilla.com/D127585
c529cef5bc53fda2afa6efd0d7f6954121e38534: Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin
Jon Bauman <jbauman@mozilla.com> - Wed, 06 Oct 2021 19:02:15 +0000 - rev 664189
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D127291
1dabc86bebed4da80e8ae53ea0068fd29a5c69c6: Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin
Jon Bauman <jbauman@mozilla.com> - Wed, 06 Oct 2021 19:02:14 +0000 - rev 664188
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1725190 - Incorrect file extension when downloading CR3 files. r=jolin Add failing test Differential Revision: https://phabricator.services.mozilla.com/D127290
287831701e2d7ee97807553945ceca1a1375b32a: Bug 1729467 - Restyle test to conform to code style. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 14 Sep 2021 16:10:49 +0000 - rev 660913
Push 15888 by ffxbld-merge at Mon, 04 Oct 2021 18:11:00 +0000
Bug 1729467 - Restyle test to conform to code style. r=jolin Drive by restyle of the test. Change should not impact functionality. Depends on D124802 Differential Revision: https://phabricator.services.mozilla.com/D124803
3a8ffeec76031cddf13673ae21a5cac6e63e6b8b: Bug 1729467 - Don't log for every failing pixel in test. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 14 Sep 2021 16:10:49 +0000 - rev 660912
Push 15888 by ffxbld-merge at Mon, 04 Oct 2021 18:11:00 +0000
Bug 1729467 - Don't log for every failing pixel in test. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D124802
820a165f2cf5ffc89aa59b8edc58f8cdb1f359d2: Bug 1726202 - Add cbcs clear key test cases. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 25 Aug 2021 20:41:43 +0000 - rev 658754
Push 15794 by ffxbld-merge at Mon, 06 Sep 2021 12:31:55 +0000
Bug 1726202 - Add cbcs clear key test cases. r=jolin Add several test cases to cover our cbcs path. These test a number of different patterns. These patterns are - 1:9, 5:5, 10:0. These are more conventional patterns. - 7:7, 9:8. These are not conventional. Both go against the spec by not summing to 10. This tests we can appropriately handle unconventional cases. Note that the spec says patterns should only be applied to video tracks. So in all cases the audio actually use 0:0 (full encryption). So these test cases also cover the 0:0 case. Differential Revision: https://phabricator.services.mozilla.com/D123498
8c2f03f7897cf429863ec087b8fd796fbec18117: Bug 1727133 - Handle clear key cbcs media with 0:0 pattern. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 25 Aug 2021 20:41:43 +0000 - rev 658753
Push 15794 by ffxbld-merge at Mon, 06 Sep 2021 12:31:55 +0000
Bug 1727133 - Handle clear key cbcs media with 0:0 pattern. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D123359
d570e61a442dc5b2067fc8a9a00aa043519b0bf0: Bug 1721874 - Remove getDecryptingGMPVideoDecoder. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 26 Jul 2021 16:15:24 +0000 - rev 655246
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1721874 - Remove getDecryptingGMPVideoDecoder. r=jolin This code path is now the same as getGMPVideoDecoder, so we can merge them into one and remove the decrypting decoder specific case. Differential Revision: https://phabricator.services.mozilla.com/D120649
762c7aeeb496bd68dd6e3669cecd9b1603512a78: Bug 1721867 - Remove the concept of decryptor id from the GMP. r=alwu,jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Thu, 22 Jul 2021 22:19:53 +0000 - rev 655089
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1721867 - Remove the concept of decryptor id from the GMP. r=alwu,jolin Decryptor id is no longer used anywhere functional, but we still have code referencing and plumbing values around. This patch removes all the remaining usage I can find in Gecko. Differential Revision: https://phabricator.services.mozilla.com/D120647
9317e6a8cf03f3aec383256bdf4821dc8c8d94e7: Bug 1716196 - Misleading log message: "AppleVTDecoder: system doesn't support hardware acceleration". r=jolin
Jon Bauman <jbauman@mozilla.com> - Fri, 16 Jul 2021 19:21:10 +0000 - rev 654342
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1716196 - Misleading log message: "AppleVTDecoder: system doesn't support hardware acceleration". r=jolin Differential Revision: https://phabricator.services.mozilla.com/D118296
ac63a680ce97938ace219cb5eae306be10de0d2c: Bug 1715947 - Don't call callback after GeckoHlsPlayer is released. r=jolin
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 14 Jun 2021 02:17:57 +0000 - rev 651299
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1715947 - Don't call callback after GeckoHlsPlayer is released. r=jolin `GeckoHlsPlayer.release()` releases `ExoPlayer` object on player thread. But it doesn't wait for whether it calls stop and callback is released. But `HLSDecoder` calls `GeckoHLSResourceWrapper.destroy()` then dispose JNI callback object immediately. So `GeckoHlsPlayer` may calls callback even if callback is disposed. We should check `mReleasing` before calling callback. Differential Revision: https://phabricator.services.mozilla.com/D117505
85a342301715da0c972f97e6a415cac0efcff19e: Bug 1715947 - Don't call callback after GeckoHlsPlayer is released. r=jolin, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 14 Jun 2021 02:17:57 +0000 - rev 649760
Push 15567 by jcristau@mozilla.com at Mon, 21 Jun 2021 13:26:28 +0000
Bug 1715947 - Don't call callback after GeckoHlsPlayer is released. r=jolin, a=jcristau `GeckoHlsPlayer.release()` releases `ExoPlayer` object on player thread. But it doesn't wait for whether it calls stop and callback is released. But `HLSDecoder` calls `GeckoHLSResourceWrapper.destroy()` then dispose JNI callback object immediately. So `GeckoHlsPlayer` may calls callback even if callback is disposed. We should check `mReleasing` before calling callback. Differential Revision: https://phabricator.services.mozilla.com/D117505
e3e9aa4186aa6767aad99e22d1304cb9de648923: WIP: Bug 1703707 - Replace cross-process OMXClient call with IPC to enable isolated process in Android r=geckoview-reviewers,aklotz,agi,jolin
owlishDeveloper <bugzeeeeee@gmail.com> - Fri, 16 Apr 2021 23:34:35 +0000 - rev 644004
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
WIP: Bug 1703707 - Replace cross-process OMXClient call with IPC to enable isolated process in Android r=geckoview-reviewers,aklotz,agi,jolin Differential Revision: https://phabricator.services.mozilla.com/D111200
e060214ffbb13404459d1f521adc7de47c69ac01: Bug 1679356 - P2. Ignore HW accelerated flag when using the Apple's VT decoder. r=jolin
Jean-Yves Avenard <jyavenard+gecko@gmail.com> - Tue, 01 Dec 2020 00:43:38 +0000 - rev 625561
Push 14929 by ffxbld-merge at Mon, 14 Dec 2020 15:19:11 +0000
Bug 1679356 - P2. Ignore HW accelerated flag when using the Apple's VT decoder. r=jolin On Apple Silicon, the flag kVTDecompressionPropertyKey_UsingHardwareAcceleratedVideoDecoder always returns false; even thoough we can really tell it's hardware accelerated by the CPU usage percentage (from 130% to 6% when playing 4K VP9). So we ignore that flag for now, and just rely on VTIsHardwareDecodeSupported to return true. Depends on D97983 Differential Revision: https://phabricator.services.mozilla.com/D97984
5194f8d4d5890aafe62c42f9b1fa75d6a9a64bf5: Bug 1595994 - P12. Allow ffvpx and the AppleDecoderModule in the RDD. r=haik,jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 20 Oct 2020 23:27:52 +0000 - rev 620026
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1595994 - P12. Allow ffvpx and the AppleDecoderModule in the RDD. r=haik,jolin Ultimately, we should be able to remove everything that got added to the RDD sandbox from the content's one. Fly-by fix; allow checking if AVX512 is supported in content sandbox. Splitting sandbox setting from Utility to a new RDD one as per review comment in P12 considering it's no longer an IPC only sandbox. Depends on D91688 Differential Revision: https://phabricator.services.mozilla.com/D91689
c1a849c9d7bf6fa178b606a3bac4e98fce25a067: Bug 1618529 - Store clear crypto subsample info in uint32 rather than uint16. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 05 Oct 2020 18:17:06 +0000 - rev 617409
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1618529 - Store clear crypto subsample info in uint32 rather than uint16. r=jolin This avoids us risking an overflow when we convert encrypted media with subsamples to AnnexB (since that conversion can grow the clear sizes of the sample). See the test in the preceding patch for an example of how and why this happens. Differential Revision: https://phabricator.services.mozilla.com/D92300
a9ede779b8270af13008174b67ab833cfd39e29d: Bug 1618529 - Add gtest coverage for AnnexB conversions. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 05 Oct 2020 18:22:08 +0000 - rev 617408
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1618529 - Add gtest coverage for AnnexB conversions. r=jolin Add test code to ensure AnnexB conversions behave as we expect. This adds some coverage for non-encrypted conversions that we only tested with broader tests until now. It also adds a test to ensure we don't overflow our subsample sizes when dealing with encrypted media with very large subsamples. This latter test covers the issue seen in bug 1618529. Differential Revision: https://phabricator.services.mozilla.com/D92299
ac2a9e14740018e62803946dd75d599b744cefa4: Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 30 Sep 2020 20:19:26 +0000 - rev 616760
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r=jolin Fix up includes so AnnexB.h and TestMediaDataEncoder.cpp don't rely on unified build order. Reformat include lists to match style guide. Rework #include guard on AnnexB.h to reflect style guide. Differential Revision: https://phabricator.services.mozilla.com/D91825
5d7abb6835313bf0866e00e9073701a2b0691aa8: Bug 1618529 - Store clear crypto subsample info in uint32 rather than uint16. r=jolin, a=jcristau
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 05 Oct 2020 18:17:06 +0000 - rev 615112
Push 14241 by jcristau@mozilla.com at Thu, 08 Oct 2020 18:07:02 +0000
Bug 1618529 - Store clear crypto subsample info in uint32 rather than uint16. r=jolin, a=jcristau This avoids us risking an overflow when we convert encrypted media with subsamples to AnnexB (since that conversion can grow the clear sizes of the sample). See the test in the preceding patch for an example of how and why this happens. Differential Revision: https://phabricator.services.mozilla.com/D92300
6b03f7b5d4da9daa40dbc8f4271bc0840ecae9d0: Bug 1618529 - Add gtest coverage for AnnexB conversions. r=jolin, a=jcristau
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 05 Oct 2020 18:22:08 +0000 - rev 615111
Push 14241 by jcristau@mozilla.com at Thu, 08 Oct 2020 18:07:02 +0000
Bug 1618529 - Add gtest coverage for AnnexB conversions. r=jolin, a=jcristau Add test code to ensure AnnexB conversions behave as we expect. This adds some coverage for non-encrypted conversions that we only tested with broader tests until now. It also adds a test to ensure we don't overflow our subsample sizes when dealing with encrypted media with very large subsamples. This latter test covers the issue seen in bug 1618529. Differential Revision: https://phabricator.services.mozilla.com/D92299
1ebe12ede1c1c5d2ed9bf878630e2f1a2b2f1120: Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r=jolin, a=jcristau
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 30 Sep 2020 20:19:26 +0000 - rev 615107
Push 14240 by jcristau@mozilla.com at Thu, 08 Oct 2020 18:06:14 +0000
Bug 1668099 - Fix symbols that rely on unified build order in media gtests. r=jolin, a=jcristau Fix up includes so AnnexB.h and TestMediaDataEncoder.cpp don't rely on unified build order. Reformat include lists to match style guide. Rework #include guard on AnnexB.h to reflect style guide. Differential Revision: https://phabricator.services.mozilla.com/D91825
bbd0700771c8a09c4ff33cfd2a9f4e02e2897163: Bug 1662514 - Take mCallbackMutex when accessing mError; r=jolin
Dan Minor <dminor@mozilla.com> - Wed, 09 Sep 2020 00:25:09 +0000 - rev 613318
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1662514 - Take mCallbackMutex when accessing mError; r=jolin Differential Revision: https://phabricator.services.mozilla.com/D89489
400346c54de1abd508f99c0d82ea1cbcd76054b7: Bug 1654111 - Rename threads in GMPServiceParent and GMPParent to reflect main thread usage. r=jolin,jya
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 21 Aug 2020 16:51:35 +0000 - rev 613130
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1654111 - Rename threads in GMPServiceParent and GMPParent to reflect main thread usage. r=jolin,jya Differential Revision: https://phabricator.services.mozilla.com/D84266
343d941ac9dc1cb70df5ab625e07c44838202d8d: Bug 1662210 - Remove dead MediaKeys code from MediaElement's SuspendOrResumeElement. r=jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Mon, 31 Aug 2020 18:19:18 +0000 - rev 612346
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1662210 - Remove dead MediaKeys code from MediaElement's SuspendOrResumeElement. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D88887
6154886fbf74cb3c8a196abf0050d52ef7eb1326: Bug 1661346 - Disable AV1 on Android release versions r=jolin
James Willcox <snorp@snorp.net> - Thu, 27 Aug 2020 15:54:07 +0000 - rev 611901
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1661346 - Disable AV1 on Android release versions r=jolin Differential Revision: https://phabricator.services.mozilla.com/D88328
70a4742a8eb528c8bcda57543130d1d490b0f4be: Bug 1661346 - Disable AV1 on Android release versions. r=jolin, a=jcristau
James Willcox <snorp@snorp.net> - Thu, 27 Aug 2020 15:54:07 +0000 - rev 610559
Push 13643 by ryanvm@gmail.com at Fri, 28 Aug 2020 14:36:09 +0000
Bug 1661346 - Disable AV1 on Android release versions. r=jolin, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D88328
ee727292d69c358d0e3234b518d2417329a3ca13: Bug 1660107 - Set proper mimetype. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 20 Aug 2020 01:29:48 +0000 - rev 610108
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1660107 - Set proper mimetype. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D87677
f7243c8b47724331ab1f1eadba4fa3233f4ad053: Bug 1650696 - P4. Remove the expectation for a MediaDataDecoder to work on a specified TaskQueue. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 17 Aug 2020 23:52:21 +0000 - rev 609672
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1650696 - P4. Remove the expectation for a MediaDataDecoder to work on a specified TaskQueue. r=jolin It will now be up to the caller to determine where the decoder is going to run. This allows to simplify the audio decoders so that they can run synchronously and be wrapped in a Wasm sandbox (which doesn't support multi-threading) The structure guarantees that all MediaDataDecoder methods are called on the same thread it's been initialised. To achieve this, wherever a MediaDataDecoder was created, we wrap it in a MediaDataDecoderProxy that ensures that all methods are running on the given thread. We keep the behaviour of all methods in all MediaDataDecoder to assert that they are running on the expected thread for diagnostic purposes. It could go in the future. Video decoders that could block excessingly the thread on which they are called are made to run on their own task queue. The Apple decoder is mostly entirely asynchronous, with the exception of the drain method which could block. We exclude the android and omx decoders are the framework they use is 100% asynchronous and already operate on another thread. Differential Revision: https://phabricator.services.mozilla.com/D86929
aee9055c07c2f50d246a2203dc207932ede6c1b9: Bug 1650696 - P3. Add missing methods to AllocationPolicy. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Aug 2020 21:16:19 +0000 - rev 609671
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1650696 - P3. Add missing methods to AllocationPolicy. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D86930
3ddc585f69cfcf7d39c97e9bef6a5fce082f1f48: Bug 1650696 - P2. Add missing methods to MediaDataDecoderProxy. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Aug 2020 21:16:12 +0000 - rev 609670
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1650696 - P2. Add missing methods to MediaDataDecoderProxy. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D86928
52cfcbf997856aff5c2548880f9a99883a5cea8a: Bug 1650696 - P1. Remove remnant of AbstractThread in EME and GMP decoders. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Aug 2020 21:04:07 +0000 - rev 609669
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1650696 - P1. Remove remnant of AbstractThread in EME and GMP decoders. r=jolin Once upon a time, having an AbstractThread was required in order to use MozPromise; this is no longer the case. Also, now all nsIThread support DirectTask dispatching making the need to wrap a nsIThread in a XPCOMThreadWrapper unecessary. We probably don't need a dedicated GMPThread and could likely use a BackgroundTaskqueue instead. Differential Revision: https://phabricator.services.mozilla.com/D86927
d6c1978bcabea9bbadd17764a249a504577e3ca9: Bug 1657521 - P6. Attempt to create a decoder via the PDMFactory as fallback. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 13 Aug 2020 02:15:58 +0000 - rev 609132
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P6. Attempt to create a decoder via the PDMFactory as fallback. r=jolin The MediaChangeMonitor would always use the selected PDM in order to create a decoder; this only worked if the Decode method returned an error if the format was unsupported and this is how the WMF decoder worked. However, the AppleVTDecoder fails on creation instead. Now that the VP9 profile is known at creation time, we should move the WMF decoder to do the same. Differential Revision: https://phabricator.services.mozilla.com/D86545
791287b954142d17ae82c82ce9a4cf992d36eeea: Bug 1657521 - P5. Add VP9 HW decoder support on macOS 11 (Big Sur). r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 13 Aug 2020 02:16:19 +0000 - rev 609131
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P5. Add VP9 HW decoder support on macOS 11 (Big Sur). r=jolin To create a VP9 decoder, the VideoToolbox requires a vppC atom similar to how the H264 one requires an avcC one. That information is typically not available in the webm container and is found in the VP9 bytestream with each keyframe. In order to minimise the extent of the changes, we move the task of retrieving the vpcC content in the MediaChangeMonitor as it already performs a similar task in order to detect if the format has changed. The VPXChangeMonitor will now only instantiate a VP9 decoder once a keyframe is seen. Differential Revision: https://phabricator.services.mozilla.com/D86544
233bb07b9bb931d853a956abf8a4cc8b0e73e919: Bug 1657521 - P2. Attempt to use Apple VT decoder before FFmpeg. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 13 Aug 2020 02:16:20 +0000 - rev 609128
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P2. Attempt to use Apple VT decoder before FFmpeg. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D86543
99693abc449917ff26e9c76eedc100c0ee94793c: Bug 1657521 - P1. Add method to generate a vpcC box from the VP9 bitstream. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 13 Aug 2020 02:14:11 +0000 - rev 609127
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P1. Add method to generate a vpcC box from the VP9 bitstream. r=jolin The mac VP9 decoder; like the H264 requires some out of band settings before it can be created. This information is only found in the mp4 container, we can create it from the vp9 bitstream. For now we ignore the colors information as we can't handle it properly yet in our compositor and this is not available in the bytestream. Differential Revision: https://phabricator.services.mozilla.com/D86542
e97937bf5e3a386e08d67112e5cbc2bd56777137: Bug 1657521 - P4. Attempt to create a decoder via the PDMFactory as fallback. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Aug 2020 05:39:19 +0000 - rev 608994
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P4. Attempt to create a decoder via the PDMFactory as fallback. r=jolin The MediaChangeMonitor would always use the selected PDM in order to create a decoder; this only worked if the Decode method returned an error if the format was unsupported and this is how the WMF decoder worked. However, the AppleVTDecoder fails on creation instead. Now that the VP9 profile is known at creation time, we should move the WMF decoder to do the same. Differential Revision: https://phabricator.services.mozilla.com/D86545
8d70f3cb5e3b28e7e55e3ce23f66a99104034148: Bug 1657521 - P3. Add VP9 HW decoder support on macOS 11 (Big Sur). r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Aug 2020 04:08:43 +0000 - rev 608993
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P3. Add VP9 HW decoder support on macOS 11 (Big Sur). r=jolin To create a VP9 decoder, the VideoToolbox requires a vppC atom similar to how the H264 one requires an avcC one. That information is typically not available in the webm container and is found in the VP9 bytestream with each keyframe. In order to minimise the extent of the changes, we move the task of retrieving the vpcC content in the MediaChangeMonitor as it already performs a similar task in order to detect if the format has changed. The VPXChangeMonitor will now only instantiate a VP9 decoder once a keyframe is seen. Differential Revision: https://phabricator.services.mozilla.com/D86544
5c3c1ec039d2579557cf4f15789c0d7d356a0e78: Bug 1657521 - P2. Attempt to use Apple VT decoder before FFmpeg. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Aug 2020 04:08:30 +0000 - rev 608992
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P2. Attempt to use Apple VT decoder before FFmpeg. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D86543
132eb437fdda4a5cde692625073778696d67be74: Bug 1657521 - P1. Add method to generate a vpcC box from the VP9 bitstream. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Aug 2020 04:08:23 +0000 - rev 608991
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1657521 - P1. Add method to generate a vpcC box from the VP9 bitstream. r=jolin The mac VP9 decoder; like the H264 requires some out of band settings before it can be created. This information is only found in the mp4 container, we can create it from the vp9 bitstream. For now we ignore the colors information as we can't handle it properly yet in our compositor and this is not available in the bytestream. Differential Revision: https://phabricator.services.mozilla.com/D86542
0a7d95ea90f1cae13100eee355a8bf8abbfa486b: Bug 1656289 - Enable EME for all GeckoView builds. r=jolin
Randall E. Barker <rbarker@mozilla.com> - Sat, 01 Aug 2020 06:49:55 +0000 - rev 607788
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1656289 - Enable EME for all GeckoView builds. r=jolin Differential Revision: https://phabricator.services.mozilla.com/D85426
d0a0af1b399a35808cec95e81d420a28b15596e1: Bug 1656289 - Enable EME for all GeckoView builds. r=jolin, a=RyanVM
Randall E. Barker <rbarker@mozilla.com> - Sat, 01 Aug 2020 06:49:55 +0000 - rev 606748
Push 13529 by ryanvm@gmail.com at Mon, 10 Aug 2020 18:13:31 +0000
Bug 1656289 - Enable EME for all GeckoView builds. r=jolin, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D85426
9effc53efcc25e75e1770c123f988ab02364fe65: Bug 1648363 - Don't use AbstractThread with GMP service. r=jolin
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 27 Jun 2020 01:26:37 +0000 - rev 601754
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648363 - Don't use AbstractThread with GMP service. r=jolin Currently that thread is always the main thread; but really it doesn't have to be. We make this use a generic nsISerialEventTarget and rename some members to better reflect what thread is doing what. Differential Revision: https://phabricator.services.mozilla.com/D81079
cd62b971a4f43b4ccf61c236bc85f95706ff3474: Bug 1612557 - part5 : use `MediaSampleMarkerPayload` in VideoSink. r=jolin
alwu <alwu@mozilla.com> - Fri, 15 May 2020 23:51:14 +0000 - rev 594240
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1612557 - part5 : use `MediaSampleMarkerPayload` in VideoSink. r=jolin This patch will do : - use `MediaSampleMarkerPayload` to replace `VideoFrameMarkerPayload` The advantage of doing so : - after finishing a support for `MediaSampleMarkerPayload` in profiler front-end side, we can show the sample's start and end time when hovering on the marker icon. Differential Revision: https://phabricator.services.mozilla.com/D75469
e1c8313256c73b47747eef0ea0182ac62440aa61: Bug 1617929 - Make a best effort to use extra data found in h264 samples. r=jya,jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 15 Apr 2020 17:21:15 +0000 - rev 587726
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1617929 - Make a best effort to use extra data found in h264 samples. r=jya,jolin Prior to this patch if we tried to extract extra data from an h264 sample but then found a partial NAL unit we'd discard the already found extra data rather than processing it. This is problematic for avc3 streams where encryption starts during a NAL unit, as even if we'd seen extra data prior to finding such a partial unit, we'd discard it. With this patch we will instead process the extra data we've already found in a best effort attempt. If we get sent avc3 content that encrypts in band extra data we'll still be in trouble, but I am not sure such content exists at this stage. This also changes our handling for non-encrypted streams, where we will now also try to use any already discovered extra-data. Differential Revision: https://phabricator.services.mozilla.com/D70767
8d298947b2d85c1be799dfe85d21ffda8f8baccd: Bug 1617929 - Remove H264Changemonitor's special encrypted handling. r=jya,jolin
Bryce Seager van Dyk <bvandyk@mozilla.com> - Wed, 15 Apr 2020 17:20:57 +0000 - rev 587725
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1617929 - Remove H264Changemonitor's special encrypted handling. r=jya,jolin This undoes the changes from bug 1560092. These changes assumed that we couldn't play encrypted avc3 content as we couldn't read SPS + PPS info from the stream. However, after some testing I believe the issue is we can try and detect SPS + PPS data in such streams, but need to better handle the encrypted case. A following patch will address better handling SPS + PPS data in encrypted streams. Differential Revision: https://phabricator.services.mozilla.com/D70766
8cada78c7c199f45c24673e07a2cff7745ee9e7d: Bug 1611938 - Add mutex to WebrtcMediaDataEncoderCodec; r=jolin
Dan Minor <dminor@mozilla.com> - Wed, 15 Apr 2020 15:45:56 +0000 - rev 587696
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1611938 - Add mutex to WebrtcMediaDataEncoderCodec; r=jolin Differential Revision: https://phabricator.services.mozilla.com/D68785
65ec189c410cd474fc4eaef2cb9525956235ea94: Bug 1611938 - Change dispatches in WebrtcMediaDataEncoderCodec; r=jolin
Dan Minor <dminor@mozilla.com> - Tue, 07 Apr 2020 23:48:58 +0000 - rev 586444
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1611938 - Change dispatches in WebrtcMediaDataEncoderCodec; r=jolin Differential Revision: https://phabricator.services.mozilla.com/D68785