searching for reviewer(jnicol)
45eeed639240b52db83fbdcf98a2295662d2145c: Bug 1734958 - Don't spin forever trying to get gl errors. r=gfx-reviewers,jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 13 Oct 2021 16:09:17 +0000 - rev 664922
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1734958 - Don't spin forever trying to get gl errors. r=gfx-reviewers,jnicol I should have known better than to expect that all drivers would implement a queue correctly. Differential Revision: https://phabricator.services.mozilla.com/D128385
a8f496596e34f73af5890c88525fb8fa7cb6cf68: Bug 1733340 - Disable backdrop-filter for now. r=jnicol
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 30 Sep 2021 11:07:11 +0000 - rev 662759
Push 15888 by ffxbld-merge at Mon, 04 Oct 2021 18:11:00 +0000
Bug 1733340 - Disable backdrop-filter for now. r=jnicol There are a fair amount of performance and correctness issues that need to be worked on, and at least I don't have the time to work on them right now, so let's disable it until some of the issues blocking bug 1578503 are fixed. Differential Revision: https://phabricator.services.mozilla.com/D127085
ddea60ea119b0e9be7bd5fed658dfe516880fd3a: Bug 1729445 - Don't batch texture uploads for large-ish items. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 08 Sep 2021 12:41:51 +0000 - rev 660315
Push 15888 by ffxbld-merge at Mon, 04 Oct 2021 18:11:00 +0000
Bug 1729445 - Don't batch texture uploads for large-ish items. r=jnicol In other words, don't batch items if we don't expect to be able to fit other items in the staging texture. The batched upload path has a cost on Windows (an extra copy) that is easily recovered when batching a lot of small items (typically works very well with glyphs), but we get diminishing returns and even slowdowns for larger items. Differential Revision: https://phabricator.services.mozilla.com/D124791
df331c8f3557e68fadc8c4086c8ad220c4e6af7b: Bug 1722908 - Make accent-color foreground-computation prefs atomic. r=jnicol
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Jul 2021 14:26:13 +0000 - rev 655594
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1722908 - Make accent-color foreground-computation prefs atomic. r=jnicol When there are remote processes we query all colors on the main thread as part of the pref update, but otherwise this code can totally run OMT, and we hit the thread-safety assert in: https://searchfox.org/mozilla-central/rev/cfc40681e13089f92fb3f5f67d5d527fb04d9505/modules/libpref/init/StaticPrefListBegin.h#23 Differential Revision: https://phabricator.services.mozilla.com/D121199
8ff3883453c5478c981ff44bfa2eae85650a5852: Bug 1721631 - Remove Android WebRender experiment hack. r=jnicol,geckoview-reviewers,agi
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 21 Jul 2021 21:22:43 +0000 - rev 654968
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1721631 - Remove Android WebRender experiment hack. r=jnicol,geckoview-reviewers,agi We're not running this experiment anymore. Differential Revision: https://phabricator.services.mozilla.com/D120487
9d2cc3a9622d834ec8551ace34a254e7da0c683a: Bug 1721631 - Remove Android WebRender experiment hack. r=jnicol,geckoview-reviewers,agi
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 21 Jul 2021 18:30:17 +0000 - rev 654936
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1721631 - Remove Android WebRender experiment hack. r=jnicol,geckoview-reviewers,agi We're not running this experiment anymore. Differential Revision: https://phabricator.services.mozilla.com/D120487
fed826274ee9b02bef53def3412f4f33758696ec: Bug 1721407 - Explicitly block Mali 4xx for WR so that they get SW-WR by default. r=jnicol
Andrew Osmond <aosmond@mozilla.com> - Tue, 20 Jul 2021 16:22:20 +0000 - rev 654782
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1721407 - Explicitly block Mali 4xx for WR so that they get SW-WR by default. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D120359
29aa77245cdf12bce0c0567804c3f79ea86dc306: Bug 1718570 - Implement full partial damage support, r=gfx-reviewers,aosmond,jnicol
Robert Mader <robert.mader@posteo.de> - Wed, 14 Jul 2021 10:05:08 +0000 - rev 654074
Push 15702 by ffxbld-merge at Mon, 09 Aug 2021 15:40:47 +0000
Bug 1718570 - Implement full partial damage support, r=gfx-reviewers,aosmond,jnicol This becomes possible as a side effect of making sure that the current buffer content is always completely valid, by blitting from the previous buffer, analogous to `NativeLayerCA::HandlePartialUpdate` and `WindowSurfaceWaylandMB::HandlePartialUpdate`. Apart from reducing overpaint, this improves correctness is many situations, avoiding glitches. Note: the approach here may not be optimal concerning efficiency yet and improvements are planed after further refactoring. Depends on D118925 Differential Revision: https://phabricator.services.mozilla.com/D119015
78fb999f9fcad3959612ec758c663459389a89f5: Bug 1721407 - Explicitly block Mali 4xx for WR so that they get SW-WR by default. r=jnicol a=pascalc
Andrew Osmond <aosmond@mozilla.com> - Tue, 20 Jul 2021 16:22:20 +0000 - rev 653748
Push 15644 by pchevrel@mozilla.com at Wed, 21 Jul 2021 06:52:06 +0000
Bug 1721407 - Explicitly block Mali 4xx for WR so that they get SW-WR by default. r=jnicol a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D120359
99d52c8d27da238e06dcaa8b574075f06b456a0b: Bug 1719238 - Fix selection of glyph sizes during pinch-zoom r=jnicol,gfx-reviewers
Glenn Watson <git@intuitionlibrary.com> - Wed, 07 Jul 2021 07:01:29 +0000 - rev 653299
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1719238 - Fix selection of glyph sizes during pinch-zoom r=jnicol,gfx-reviewers When picture cache tiles were changed to be raster roots, this broke quantizing of glyph sizes based on current scale. Restore this behavior for high-quality pinch-zoom mode, and also select the correct fixed scale for low-quality zoom mode. Differential Revision: https://phabricator.services.mozilla.com/D119145
dd947fcc5fa8c7060ec8dc25909b633789e815de: Bug 1718166 - Ensure glyph scale quantization is >= 1 r=gfx-reviewers,jnicol
Glenn Watson <git@intuitionlibrary.com> - Fri, 25 Jun 2021 09:25:10 +0000 - rev 652745
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1718166 - Ensure glyph scale quantization is >= 1 r=gfx-reviewers,jnicol Now that picture cache tiles are raster roots, their scale is expressed via the device-pixel scale. This means the calculated scale can be too small when zoom factor is < 1 and a pinch-zoom is currently active. This is not a complete fix, it's an interim improvement until we implement a proper fix. A complete fix will need to include the device-pixel scale in the quantization process. However, this will take some time to get right, since the existing code for selecting a glyph size is quite complex due to different permutations and how that code has evolved. Differential Revision: https://phabricator.services.mozilla.com/D118781
9c4c018ccafd08acfb350b480686663735c1604a: Bug 1717862 - Ship Software WebRender and WebRender to remaining Android devices. r=jnicol
Andrew Osmond <aosmond@mozilla.com> - Wed, 23 Jun 2021 16:55:18 +0000 - rev 652527
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1717862 - Ship Software WebRender and WebRender to remaining Android devices. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D118605
cebda231c6429edabf3ef130e0c1e2214ad7c18c: Bug 1717738 - Fix low-quality pinch-zoom mode with hw-wr r=gfx-reviewers,jnicol
Glenn Watson <git@intuitionlibrary.com> - Wed, 23 Jun 2021 10:32:03 +0000 - rev 652497
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1717738 - Fix low-quality pinch-zoom mode with hw-wr r=gfx-reviewers,jnicol Fixes a case where at the end of a pinch-zoom on the Draw compositor the tiles would be drawn incorrectly (due to the transforms not being quite right for the local-to-surface case here, which was affecting the occlusion calculations). Differential Revision: https://phabricator.services.mozilla.com/D118559
b7a6595f93ae95cba533461d307edcfdfe666ddd: Bug 1716559 - Remove TextureImageEGL. r=jnicol,jgilbert
Jeff Muizelaar <jmuizelaar@mozilla.com> - Tue, 15 Jun 2021 21:10:47 +0000 - rev 651706
Push 15597 by ffxbld-merge at Mon, 12 Jul 2021 12:28:04 +0000
Bug 1716559 - Remove TextureImageEGL. r=jnicol,jgilbert TextureImageEGL doesn't seem to provide any value beyond BasicTextureImage. It's last usage was bug 814159. Removing this has the side effect of using BasicTextureImage for small images instead of always using TilingTextureImage. Differential Revision: https://phabricator.services.mozilla.com/D117904
9138e54dded5d30786caecb04757bf265dfc0471: Bug 1710814 - Set the image tiling threshold to 4k. r=gfx-reviewers,jnicol
Nicolas Silva <nsilva@mozilla.com> - Mon, 17 May 2021 09:05:52 +0000 - rev 647886
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1710814 - Set the image tiling threshold to 4k. r=gfx-reviewers,jnicol Depends on D114954 Differential Revision: https://phabricator.services.mozilla.com/D114955
2f4df00f1a4ee724aab28d0e5c52b33d82676159: Bug 1710503 - Fix blend container + complex transform optimization r=gfx-reviewers,jnicol
Glenn Watson <git@intuitionlibrary.com> - Tue, 11 May 2021 20:08:32 +0000 - rev 647551
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1710503 - Fix blend container + complex transform optimization r=gfx-reviewers,jnicol Ensure that we only apply the mix-blend container -> tile cache optimization in cases where we know the transform on the blend container is axis-aligned. Differential Revision: https://phabricator.services.mozilla.com/D114812
9519a923633720f5848a217f23790e15885dec5c: Bug 1709535 - Fix clear tiles. r=gfx-reviewers,jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 05 May 2021 09:22:48 +0000 - rev 646699
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1709535 - Fix clear tiles. r=gfx-reviewers,jnicol In bug 1696905 I changed how clear tiles are rendered from multiply blend to opaque, however it breaks window controls on Windows 8 (the only thing that clear tiles are used for). This patch reverts clear tiles to the previous behavior. I'm not sure how to test this part of the code because it depends on the widget integration code having something to show behind the window. Differential Revision: https://phabricator.services.mozilla.com/D114327
fdcb5a739952e6f15b8e0ed572c616ed011d5e7f: Bug 1709535 - Fix clear tiles. r=gfx-reviewers,jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 05 May 2021 09:22:48 +0000 - rev 646690
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1709535 - Fix clear tiles. r=gfx-reviewers,jnicol In bug 1696905 I changed how clear tiles are rendered from multiply blend to opaque, however it breaks window controls on Windows 8 (the only thing that clear tiles are used for). This patch reverts clear tiles to the previous behavior. I'm not sure how to test this part of the code because it depends on the widget integration code having something to show behind the window. Differential Revision: https://phabricator.services.mozilla.com/D114327
3e151e90c2636a10f2f46acc4d7aa7e8b9250d57: Bug 1706396 - Enable WebRender on android with mesa (intel chromebooks). r=jnicol,aosmond
Nicolas Silva <nsilva@mozilla.com> - Mon, 26 Apr 2021 13:19:21 +0000 - rev 645622
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1706396 - Enable WebRender on android with mesa (intel chromebooks). r=jnicol,aosmond Differential Revision: https://phabricator.services.mozilla.com/D112990
8d99f538b0bfbf20f664904952bd42ec48a55fcc: Bug 1697096 - Call WebRenderAPI::Resume() in AllocPWebRenderBridgeParent() if necessary on Android r=jnicol
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 20 Apr 2021 06:48:35 +0000 - rev 644853
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1697096 - Call WebRenderAPI::Resume() in AllocPWebRenderBridgeParent() if necessary on Android r=jnicol On Android, WebRenderAPI::Resume() call is triggered from Java side. But Java side does not know about fallback to RenderCompositorOGLSWGL. Then in this fallback case, RenderCompositor::Resume() needs to be called from gfx code if it is necessary to be called. Resume() is necessary only when RenderCompositor::Resume() is implemented. The Resume() is implemented only on RenderCompositorEGL and RenderCompositorOGLSWGL. And only RenderCompositorOGLSWGL uses software WebRender. Differential Revision: https://phabricator.services.mozilla.com/D107620
a36d05a943a37b42f8d41ff91260c2403a5b7a4e: Bug 1706000 - Remove WebRenderBridgeParent::mPaused r=jnicol,gfx-reviewers
sotaro <sotaro.ikeda.g@gmail.com> - Mon, 19 Apr 2021 21:59:46 +0000 - rev 644782
Push 15485 by ffxbld-merge at Mon, 31 May 2021 15:17:16 +0000
Bug 1706000 - Remove WebRenderBridgeParent::mPaused r=jnicol,gfx-reviewers WebRenderBridgeParent::mPaused does not hold correct paused state, initial state of mPaused was always false. And CompositorBridgeParent already keeps correct paused state. Differential Revision: https://phabricator.services.mozilla.com/D112518
a58584bb44ede327d7a9e0317ced5106a013a9c4: Bug 1699985 - Use correct depth enum in glInvalidateFramebuffer for the default framebuffer, r=jnicol
Robert Mader <robert.mader@posteo.de> - Tue, 13 Apr 2021 19:26:01 +0000 - rev 643314
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699985 - Use correct depth enum in glInvalidateFramebuffer for the default framebuffer, r=jnicol According to the spec, when the default framebuffer is bound, `GL_DEPTH` has to be used instead of `GL_DEPTH_ATTACHMENT`. This is relevant on the EGL Wayland platform. Differential Revision: https://phabricator.services.mozilla.com/D111826
d2d5f4fbf73da0185bbab3457febeec4cdaaf3b0: Bug 1704235 - Cache and share shader program name. r=jnicol,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Sat, 10 Apr 2021 12:31:54 +0000 - rev 642931
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704235 - Cache and share shader program name. r=jnicol,gfx-reviewers This computes the shader's name only once and then stores it inside an Rc so that we can pass it around by reference outside of the Program, rather than always having to reallocate or copy it. Differential Revision: https://phabricator.services.mozilla.com/D111524
a9fbe11857ba0bc377777e6280d411def4206415: Bug 1699013 - Add the crash test. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 07 Apr 2021 08:23:28 +0000 - rev 642274
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699013 - Add the crash test. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D110409
bb62a924a4ed0ac6f135e375ff1a6cc3238b084e: Bug 1699013 - Avoid assertion in the image tiling code. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 07 Apr 2021 08:23:27 +0000 - rev 642273
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699013 - Avoid assertion in the image tiling code. r=jnicol We can gracefully handle null stride when there's no visible rect since it should always result in an empty iterator. Differential Revision: https://phabricator.services.mozilla.com/D110089
2bf97020a1e63c23fed2003d3548dd90ce2352b5: Bug 1700232 - Add the crash test. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 31 Mar 2021 13:20:15 +0000 - rev 641514
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700232 - Add the crash test. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D110402
93c7ed3f5606865707e5ebee8709b13ce0c2e220: Bug 1702133: Add null checks to AutoSerializeWithMoz2D. r=jnicol
Bob Owen <bobowencode@gmail.com> - Wed, 31 Mar 2021 08:14:31 +0000 - rev 641419
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1702133: Add null checks to AutoSerializeWithMoz2D. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D110373
f27f91cac303aa5fd098f2910d48c52841e97ef6: Bug 1699598 - Create GLContext for CompositorOGL when sw-wr is enabled on Android r=jnicol
sotaro <sotaro.ikeda.g@gmail.com> - Tue, 23 Mar 2021 12:10:58 +0000 - rev 640176
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699598 - Create GLContext for CompositorOGL when sw-wr is enabled on Android r=jnicol Confirmed that the change work on Mali-400 MP device. GLContextProviderEGL::CreateForCompositorWidget() with aWebRender=true failed to create GLContext when GLES3 is not supported on device. When aWebRender=false, it does not request depth buffer nor GLES3. Though when android device supports GLES3, GLES3 context was created on android devices that I tested. Differential Revision: https://phabricator.services.mozilla.com/D109015
2ec036188487e104ebabeb0df30fdb4ac952f9c5: Bug 1700232 - Add the crash test. r=jnicol, a=test-only
Nicolas Silva <nsilva@mozilla.com> - Wed, 31 Mar 2021 13:20:15 +0000 - rev 639802
Push 15262 by ryanvm@gmail.com at Thu, 01 Apr 2021 15:49:19 +0000
Bug 1700232 - Add the crash test. r=jnicol, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D110402
b3f2f1151271140b4605ebed29c2abd5a8cd587e: Bug 1702133: Add null checks to AutoSerializeWithMoz2D. r=jnicol, a=RyanVM
Bob Owen <bobowencode@gmail.com> - Wed, 31 Mar 2021 08:14:31 +0000 - rev 639797
Push 15259 by ryanvm@gmail.com at Wed, 31 Mar 2021 17:42:01 +0000
Bug 1702133: Add null checks to AutoSerializeWithMoz2D. r=jnicol, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D110373
c54da9c3d4e193d461cd3993ddda6e4beaac78fb: Bug 1699306 - Define __VERSION__ in SWGL GLSL. r=jnicol
Lee Salzman <lsalzman@mozilla.com> - Wed, 17 Mar 2021 23:52:11 +0000 - rev 639058
Push 15212 by ffxbld-merge at Mon, 22 Mar 2021 14:40:41 +0000
Bug 1699306 - Define __VERSION__ in SWGL GLSL. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D108875
c6277b2016bb5bd8b76182afe3c99fd1dee421d2: Bug 1697715 - Change pref gfx.webrender.software.opengl to true on Android r=jnicol
sotaro <sotaro.ikeda.g@gmail.com> - Thu, 11 Mar 2021 08:45:32 +0000 - rev 637989
Push 15212 by ffxbld-merge at Mon, 22 Mar 2021 14:40:41 +0000
Bug 1697715 - Change pref gfx.webrender.software.opengl to true on Android r=jnicol On Android, we expect to use WebRender (Software OpenGL)"RenderCompositorOGLSWGL" instead of WebRender (Software)"RenderCompositorSWGL". Differential Revision: https://phabricator.services.mozilla.com/D107969
d30e850755fd44a700de76eae983fe9dcf3d360f: Bug 1697187 - Print the shader when encountering glslopt errors. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Wed, 10 Mar 2021 07:42:33 +0000 - rev 637773
Push 15212 by ffxbld-merge at Mon, 22 Mar 2021 14:40:41 +0000
Bug 1697187 - Print the shader when encountering glslopt errors. r=jnicol glslopt error messages typically look like: 314(15): error: syntax error, unexpected NEW_IDENTIFIER, expecting ',' or ';' Which would be fine if we had a way to see what is at line 314, however we don't store the concatenated shader string on disk so it's a bit hard to guess where in the source a typo led to a an unknown identifier. This patch makes the build script print the shader source with line numbers when glslopt throws an error. Differential Revision: https://phabricator.services.mozilla.com/D107655
d599ca139ac8563912d807e19ba39690e2afe67b: Bug 1688062 - Update target SDK to API 30. r=esawin,jnicol
Agi Sferro <agi@sferro.dev> - Mon, 01 Mar 2021 19:12:16 +0000 - rev 636464
Push 15212 by ffxbld-merge at Mon, 22 Mar 2021 14:40:41 +0000
Bug 1688062 - Update target SDK to API 30. r=esawin,jnicol Differential Revision: https://phabricator.services.mozilla.com/D106556
b9370586b586a64c4b25dad9f8a1546e018e8a18: Bug 1691421 - Shrink the staging texture pool automatically. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Tue, 09 Feb 2021 15:40:52 +0000 - rev 633784
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1691421 - Shrink the staging texture pool automatically. r=jnicol If we have more than 8 unused/reusable staging textures and buffers for more than 120 consecutive frames, start deallocation them, spreading the deallocation over multiple frames. The vast majority of frames require less than 4 staging textures and buffers (most don't require any), but some SVG animations can put a lot of pressure on uploads, requiring 30+ staging textures per frame. This patch avoids staying at this kind of peak memory usage for too long. Differential Revision: https://phabricator.services.mozilla.com/D104510
802a5cf1ca38fc59ec1fbf5a88467a611049e657: Bug 1691421 - Improve the way stalls are avoided in the staging texture pool. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Tue, 09 Feb 2021 15:40:51 +0000 - rev 633783
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1691421 - Improve the way stalls are avoided in the staging texture pool. r=jnicol Instead of using a triple buffering scheme, tag each texture with a frame index and only reuse a texture that hasn't been used for more than two frames. Differential Revision: https://phabricator.services.mozilla.com/D104421
130bb97f571816e049bd65f2c9fb44d992c61193: Bug 1691042 - Dump alpha8 mask and glyph textures in frame captures. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 05 Feb 2021 19:11:15 +0000 - rev 633459
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1691042 - Dump alpha8 mask and glyph textures in frame captures. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D104213
e69e816379abf7d3b3f21bcdd5c0f20bf697ccdc: Bug 1690247 - Don't batch texture uploads with SWGL. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 05 Feb 2021 13:23:37 +0000 - rev 633279
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1690247 - Don't batch texture uploads with SWGL. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D104158
38961402cdc146188ddab4c449444c80d9328c31: Bug 1690886 - Support 4-component swizzles in SWGL. r=jnicol
Lee Salzman <lsalzman@mozilla.com> - Thu, 04 Feb 2021 21:50:36 +0000 - rev 633214
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1690886 - Support 4-component swizzles in SWGL. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D104098
b56f1be360db78e260fe47b3977a27d5ff33d822: Bug 1599606 - Remove an assert in non-WebRender code. r=jnicol
Markus Stange <mstange.moz@gmail.com> - Tue, 02 Feb 2021 09:49:10 +0000 - rev 632762
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1599606 - Remove an assert in non-WebRender code. r=jnicol This assert fails on the new reftest from this bug, on Android. I haven't dug into it too deeply, given that it's code that'll be going away at some point soon (hopefully), but I think what happens is that we have a fixed layer which is not annotated as fixed. That's normal for background-attachment: fixed root backgrounds. We handle explicitly-annotated-as-fixed layers a bit further up in this function. Returning false here seems like a very safe thing to do. Depends on D54855 Differential Revision: https://phabricator.services.mozilla.com/D103736
06775794753816195cc8077ad8894377449b628a: Bug 1681310 - Add a batched texture upload code path using glTexSubImage2D. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Tue, 02 Feb 2021 06:50:00 +0000 - rev 632713
Push 15122 by ffxbld-merge at Mon, 22 Feb 2021 12:02:19 +0000
Bug 1681310 - Add a batched texture upload code path using glTexSubImage2D. r=jnicol Our existing batched texture upload logic works with pixel buffer objects which we don't use with ANGLE. The motivation is to avoid expensive driver overhead from submitting many glTexSubImage2D calls (one for each texture cache item) on low-end Intel Windows configurations. On Windows+Intel it is much faster to use batched draw calls to copy from staging textures to texture cache than using CopySubResourceRegion (when there is a high number of copies). Differential Revision: https://phabricator.services.mozilla.com/D103333
f48ce1c53912aa61817dd88818ee11fd1ce49f35: Bug 1687219 - Update a bunch of telemetry expirations. r=jnicol
Jeff Muizelaar <jmuizelaar@mozilla.com> - Mon, 18 Jan 2021 09:05:02 +0000 - rev 630536
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1687219 - Update a bunch of telemetry expirations. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D102126
b4582fea9f92355b8ca61b0ff239d2d01beecf93: Bug 1686862 - Account for the new A8 glyphs texture in various places. r=jnicol,lsalzman
Markus Stange <mstange.moz@gmail.com> - Fri, 15 Jan 2021 16:03:18 +0000 - rev 630308
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1686862 - Account for the new A8 glyphs texture in various places. r=jnicol,lsalzman Differential Revision: https://phabricator.services.mozilla.com/D101862
98fb1ef4d6e13743bad4511d605b2d0c3e574fe6: Bug 1680769 - Add a test case. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 18 Dec 2020 09:27:04 +0000 - rev 628809
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1680769 - Add a test case. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D98944
bf177e6625275332a646d7db8c2d6fbdd7a85e02: Bug 1682365 - Pt 5 - Refactor RenderTaskLocation r=jnicol
Glenn Watson <git@intuitionlibrary.com> - Fri, 18 Dec 2020 22:23:40 +0000 - rev 628276
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1682365 - Pt 5 - Refactor RenderTaskLocation r=jnicol Once the new graph API is in place, it becomes possible to express an input dependency on a persistent target (for example, if wanting to read back from a picture cache tile for a mix-blend, or marking that a color target depends on a render task in a texture cache). To make that simpler to express, this patch adds a specific struct for render target locations that are persistent, and updates the surrounding code to use it. At the same time, introduce an Unallocated field for dynamic tasks that are not yet allocated, rather than using an Option. Differential Revision: https://phabricator.services.mozilla.com/D99305
e30c7d6f0717c2b84c1a5e51ad1608b85af946d0: Bug 1682365 - Pt 4 - Add RenderTaskGraphBuilder / RenderTaskGraph split r=jnicol
Glenn Watson <git@intuitionlibrary.com> - Fri, 18 Dec 2020 22:23:40 +0000 - rev 628275
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1682365 - Pt 4 - Add RenderTaskGraphBuilder / RenderTaskGraph split r=jnicol This patch splits the graph building functionality into `RenderTaskGraphBuilder` and the graph querying code into the existing `RenderTaskGraph` struct. The Builder struct is retained frame to frame, which means there is no longer a need for the `RenderTaskGraphCounters` struct. The Graph struct is constructed per-frame by calling `end_pass` on the Builder. Although this doesn't do much different internally, it will make integration with the new task graph changes simpler. It also enforced during frame building when it is possible to add / query render tasks. A few unrelated tidy ups are included in this patch - mostly removing where the task graph is passed to from a few structs and methods that no longer require access to the graph. Differential Revision: https://phabricator.services.mozilla.com/D99297
1a59c94a034f49dc998a8d90de5c7f112a0f415b: Bug 1682365 - Pt 3 - Remove array textures from picture cache tiles. r=nical,jnicol
Glenn Watson <git@intuitionlibrary.com> - Fri, 18 Dec 2020 22:23:40 +0000 - rev 628274
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1682365 - Pt 3 - Remove array textures from picture cache tiles. r=nical,jnicol This patch makes picture cache tiles use normal textures instead of array textures. With this and the previous patch, WR no longer uses array textures at all (except when provided by the external image handler trait). Differential Revision: https://phabricator.services.mozilla.com/D99013
d7c981ef38fcddeb7f0adf18fc6ea978217a7b08: Bug 1679751 - Fix cargo test build. r=jnicol. CLOSED TREE
Nicolas Silva <nsilva@mozilla.com> - Fri, 18 Dec 2020 18:29:25 +0200 - rev 628204
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1679751 - Fix cargo test build. r=jnicol. CLOSED TREE Reviewers: jnicol Reviewed By: jnicol Tags: #testing-approved Bug #: 1679751 Differential Revision: https://phabricator.services.mozilla.com/D100126
c250273ad967f07470a1420df55ab1629663f1ce: Bug 1679751 - More android 8 reftest fuzziness adjustments. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 18 Dec 2020 13:24:37 +0000 - rev 628196
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1679751 - More android 8 reftest fuzziness adjustments. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D100104
a6b10fddf201f7ac8b4afffeca5c3ef889ff5857: Bug 1679751 - More reftest adjustments. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Fri, 18 Dec 2020 10:30:37 +0000 - rev 628183
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1679751 - More reftest adjustments. r=jnicol Once again, Android 8.0 Pixel2 debug being hidden in fuzzy queries means we don't see see them break. Differential Revision: https://phabricator.services.mozilla.com/D100088