searching for reviewer(jld)
6e1eba5c88ad47f0a2a3aa37b4c2cae9f31c2ef3: Bug 1569183: Stop doing a proxy lookup to determine whether we're configured to use a proxy (for the proxy_only_if_behind_proxy pref), and instead look at whether we loaded the doc using a proxy. r=mjf,mayhemer,jld
Byron Campen [:bwc] <docfaraday@gmail.com> - Wed, 18 Sep 2019 14:27:42 +0000 - rev 555157
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1569183: Stop doing a proxy lookup to determine whether we're configured to use a proxy (for the proxy_only_if_behind_proxy pref), and instead look at whether we loaded the doc using a proxy. r=mjf,mayhemer,jld Differential Revision: https://phabricator.services.mozilla.com/D45289
f627d416294f68eb93f6fb772b19160f68376eb4: Bug 1579874 - Use the correct process type for socket process r=jld
Kershaw Chang <kershaw@mozilla.com> - Thu, 12 Sep 2019 20:34:58 +0000 - rev 554389
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1579874 - Use the correct process type for socket process r=jld Differential Revision: https://phabricator.services.mozilla.com/D45633
b5b8a0153dbeee0ad4713790db77702efe3e1d61: Bug 1572846 - Update Clearkey to use NSS for decryption instead of OpenAES r=bryce,jld
Ryan Alderete <ralderete@mozilla.com> - Thu, 05 Sep 2019 19:19:06 +0000 - rev 553413
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1572846 - Update Clearkey to use NSS for decryption instead of OpenAES r=bryce,jld Clearkey previously relied on OpenAES to do its encryption. In order to facilitate future changes and the need for CBC support, switch to NSS, which should be more flexible and actively maintained. Differential Revision: https://phabricator.services.mozilla.com/D41993
b4df7e108b5d6fbee1bfbf941307f405bc7dd7c0: Bug 1163079 - ensure we fetch app/profile dir information on the main thread in GeckoChildProcessHost r=jld,bryce,haik
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 04 Sep 2019 12:04:52 +0000 - rev 553003
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1163079 - ensure we fetch app/profile dir information on the main thread in GeckoChildProcessHost r=jld,bryce,haik Differential Revision: https://phabricator.services.mozilla.com/D42860
3a41fd305c3ce85b9f534f15cd90dfd4ae82c0d1: Bug 1577831 - remove `using namespace std;` from IPC glue code; r=jld
Nathan Froyd <froydnj@mozilla.com> - Sat, 31 Aug 2019 00:00:12 +0000 - rev 551544
Push 11865 by btara@mozilla.com at Mon, 02 Sep 2019 08:54:37 +0000
Bug 1577831 - remove `using namespace std;` from IPC glue code; r=jld Just some minor prefixing needs to be done to enable this. Differential Revision: https://phabricator.services.mozilla.com/D44220
761130438aee679e64a332c3028e0dae35a4b87b: Bug 1562785 - Extend/revive the process launch telemetry r=jld
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 28 Aug 2019 15:21:22 +0000 - rev 550920
Push 11858 by rmaries@mozilla.com at Thu, 29 Aug 2019 15:29:30 +0000
Bug 1562785 - Extend/revive the process launch telemetry r=jld Differential Revision: https://phabricator.services.mozilla.com/D42231
266d6e0597d8666ec55d833064cc0296dc7d1502: Bug 1575564 - avoid non-mainthread use of NS_GetSpecialDirectory in linux sandboxbroker, r=jld,gcp
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 22 Aug 2019 16:37:18 +0000 - rev 550016
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1575564 - avoid non-mainthread use of NS_GetSpecialDirectory in linux sandboxbroker, r=jld,gcp Differential Revision: https://phabricator.services.mozilla.com/D42951
2679dd0ac87918827ebff13feb21d42590a4f739: Bug 1573578 - Whitelist brk syscall if jemalloc is disabled. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 14 Aug 2019 22:50:51 +0000 - rev 549434
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1573578 - Whitelist brk syscall if jemalloc is disabled. r=jld Differential Revision: https://phabricator.services.mozilla.com/D41998
8e7132cf888ad0752610283d43f4145dc6fb9512: Bug 1572565 - Make the remote sandbox broker process' telemetry string consistent r=jld
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 09 Aug 2019 00:03:33 +0000 - rev 547767
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1572565 - Make the remote sandbox broker process' telemetry string consistent r=jld Differential Revision: https://phabricator.services.mozilla.com/D41291
1a0970e3338e3007aed3252d5274d43e4486afeb: Bug 1570950 - Make sure the IPC channel is closed before destroying r=jld
Kershaw Chang <kershaw@mozilla.com> - Tue, 06 Aug 2019 21:17:40 +0000 - rev 547230
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1570950 - Make sure the IPC channel is closed before destroying r=jld The stack from crash report suggests that ChildImpl was deleted at the end of function GetOrCreateSocketActorForCurrentThread(). This only happens when SendInitBackground failed, so we have to close the IPC channel before ChildImpl getting destroyed. Differential Revision: https://phabricator.services.mozilla.com/D40838
775fd495c7b2c3ca604b23314556faf65314a1ef: Bug 1571092 - Mark various MozPromise-returning methods MOZ_MUST_USE. r=jld
Bobby Holley <bobbyholley@gmail.com> - Mon, 05 Aug 2019 20:10:58 +0000 - rev 546954
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1571092 - Mark various MozPromise-returning methods MOZ_MUST_USE. r=jld Differential Revision: https://phabricator.services.mozilla.com/D40528
e0497ac5ae6671b18ab63791f183d4717ac3af78: Bug 1571092 - Add missing return statement. r=jld
Bobby Holley <bobbyholley@gmail.com> - Mon, 05 Aug 2019 20:08:59 +0000 - rev 546953
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1571092 - Add missing return statement. r=jld Differential Revision: https://phabricator.services.mozilla.com/D40527
de98fc620593931bf5272f70288a03c2750c7272: Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r=bwc,kershaw,jld
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 29 Jul 2019 12:27:59 +0000 - rev 545604
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1567892 - PeerConnectionMedia should use nsIProtocolProxyService on the parent process - PProxyConfigLookup IPC protocol, r=bwc,kershaw,jld Differential Revision: https://phabricator.services.mozilla.com/D39010
73935c7cf465f1471c3554425de4e340da0f6393: Bug 1565996 - Handle relative paths in linker config parsing. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Fri, 26 Jul 2019 14:03:53 +0000 - rev 545390
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1565996 - Handle relative paths in linker config parsing. r=jld Differential Revision: https://phabricator.services.mozilla.com/D38634
20d0b13f6471dadde512a67dcf4b4f6e86179a8a: Bug 1566839 - Use NS_WARNING rather than NS_ERROR when child process initialization fails. r=jld
Bobby Holley <bobbyholley@gmail.com> - Mon, 22 Jul 2019 19:14:45 +0000 - rev 544240
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1566839 - Use NS_WARNING rather than NS_ERROR when child process initialization fails. r=jld Differential Revision: https://phabricator.services.mozilla.com/D38908
80d6cffc62983c5d92453dcb2d9111f78b7163b6: Bug 1566592 - Use a dedicated thread for launching on android. r=jld
Bobby Holley <bobbyholley@gmail.com> - Tue, 16 Jul 2019 22:52:48 +0000 - rev 543528
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1566592 - Use a dedicated thread for launching on android. r=jld At the moment, this shouldn't make any difference because we only ever launch one child process on android. Differential Revision: https://phabricator.services.mozilla.com/D38244
6aebc76dace8f9a68bc229bfefcdb83af1fd07fb: Bug 1563821 - Check if content child is shuttingdown before create SocketProcessBridgeChild r=jld
Kershaw Chang <kershaw@mozilla.com> - Thu, 11 Jul 2019 22:42:05 +0000 - rev 543054
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1563821 - Check if content child is shuttingdown before create SocketProcessBridgeChild r=jld Differential Revision: https://phabricator.services.mozilla.com/D37776
cb2d564879e3e441c2220f389448e71e7280de6e: Bug 1562762 - Return a Promise from DoLaunch. r=jld
Bobby Holley <bobbyholley@gmail.com> - Fri, 12 Jul 2019 04:48:44 +0000 - rev 543020
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562762 - Return a Promise from DoLaunch. r=jld Differential Revision: https://phabricator.services.mozilla.com/D37602
a82b17a644d7961e00c8c4dbd4d9137bc39423ff: Bug 1562762 - Return a Promise from DoLaunch. r=jld
Bobby Holley <bobbyholley@gmail.com> - Thu, 11 Jul 2019 15:28:00 +0000 - rev 542983
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562762 - Return a Promise from DoLaunch. r=jld Differential Revision: https://phabricator.services.mozilla.com/D37602
fd887713ac62d4aebc74a70a2e61adbc4ba93fa7: Bug 1563832 - Decompose PerformAsyncLaunch into the platform hierarchy. r=jld
Bobby Holley <bobbyholley@gmail.com> - Thu, 11 Jul 2019 15:27:58 +0000 - rev 542896
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1563832 - Decompose PerformAsyncLaunch into the platform hierarchy. r=jld Differential Revision: https://phabricator.services.mozilla.com/D37306
3f03d5f1ebfbe356d9a13632791c116a3de21dbd: Bug 1563832 - Move a few things into BaseProcessLauncher. r=jld
Bobby Holley <bobbyholley@gmail.com> - Thu, 11 Jul 2019 15:27:51 +0000 - rev 542895
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1563832 - Move a few things into BaseProcessLauncher. r=jld I'm not convinced the current comment about being race-free is accurate in context of the launcher pool. It probably _is_ correct under this patch, because ProcessLaunchers should only be constructed on a single thread, but it's easy enough just to make it atomic. Hopefully moving the timestamp doesn't perturb telemetry too much. Differential Revision: https://phabricator.services.mozilla.com/D37305
79629d87282a5c9f48ff5e9f0b734c093773fddb: Bug 1563832 - Create an inheritance hierarchy for the platform-specific bits of process launching. r=jld
Bobby Holley <bobbyholley@gmail.com> - Thu, 11 Jul 2019 15:27:47 +0000 - rev 542894
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1563832 - Create an inheritance hierarchy for the platform-specific bits of process launching. r=jld Differential Revision: https://phabricator.services.mozilla.com/D37304
11d1d46d11fb6c1b80e16e7f2b71054d9854afd0: Bug 1562763 - Factor process launching into a helper class, and use more promises. r=jld
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Jul 2019 22:37:37 +0000 - rev 542788
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562763 - Factor process launching into a helper class, and use more promises. r=jld This is intended to facilitate future work to break up PerformAsyncLaunch into asynchronous pieces. It also aims to fix some raciness around access to state in the GeckoChildProcessHost instance. There appears to be at least one data race in the existing code, in which OpenPrivilegedHandle are run on both the launcher thread and the IO thread without synchronization. Differential Revision: https://phabricator.services.mozilla.com/D36539
6035908e789b2b931d33f16d81938ff531f33420: Bug 1562763 - Move some types around. r=jld
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Jul 2019 22:37:35 +0000 - rev 542787
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562763 - Move some types around. r=jld Having to namespace these into GeckoChildProcessHost is annoying. The |using| declarations help to some extent, but it's easier to just put them in mozilla::ipc. Differential Revision: https://phabricator.services.mozilla.com/D36538
ae890583cd7668edc232dcd9dfff8696e230a033: Bug 1562763 - Make ContentParent::InitInternal fallible. r=jld
Bobby Holley <bobbyholley@gmail.com> - Wed, 10 Jul 2019 22:37:34 +0000 - rev 542786
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562763 - Make ContentParent::InitInternal fallible. r=jld Depending on the timing of events, we can invoke InitInternal after we've already torn down the compositor thread, which can make CreateContentBridges fail, which in turn makes us unable to make a correct InitRendering call. Implement the infrastructure to bail out in this case. Differential Revision: https://phabricator.services.mozilla.com/D36644
e3cc2a54770d39526562d09a5cb3ddd34fc878b6: Bug 1565996 - Handle relative paths in linker config parsing. r=jld, a=RyanVM
Gian-Carlo Pascutto <gcp@mozilla.com> - Fri, 26 Jul 2019 14:03:53 +0000 - rev 541611
Push 11651 by ryanvm@gmail.com at Mon, 29 Jul 2019 18:05:17 +0000
Bug 1565996 - Handle relative paths in linker config parsing. r=jld, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D38634
997f6179442e6a146b24e176bb7057aa10669a29: Bug 1523822 - [Wayland] Get clipboard data again when poll returns EINTR/EAGAIN, r=jld
Martin Stransky <stransky@redhat.com> - Tue, 02 Jul 2019 09:00:26 +0000 - rev 540572
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1523822 - [Wayland] Get clipboard data again when poll returns EINTR/EAGAIN, r=jld Differential Revision: https://phabricator.services.mozilla.com/D36454
182966bfca87b7f3b4897b760113da45c84c043a: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Fri, 21 Jun 2019 01:33:47 +0000 - rev 539424
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
f79736d79ee10a1d26cbf42ec9fe02a303b74e22: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Wed, 19 Jun 2019 06:13:50 +0000 - rev 538869
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
11c118fa5f2bfe81cda414f9108e4f71f7e8fe64: Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld
Tarek Ziadé <tarek@mozilla.com> - Tue, 18 Jun 2019 16:36:52 +0000 - rev 538777
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529022 - Add a GeckoChildProcessHosts iterator r=jld Adds GeckoChildProcessHost::GetAll() and use it in ChromeUtils::GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D33920
381a74484140c4183bc8d3b094848a95214795ed: Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen
Jonathan Kingston <jkt@mozilla.com> - Thu, 13 Jun 2019 08:58:07 +0000 - rev 538289
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1315460 - Removal of keygen element r=keeler,baku,jld,hsivonen Differential Revision: https://phabricator.services.mozilla.com/D22810
370c40e4923073a87845b57c1f4851bacd9663da: Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen
Bob Owen <bobowencode@gmail.com> - Wed, 12 Jun 2019 11:10:48 +0100 - rev 538142
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552160 Part 1: Roll-up of chromium sandbox update and mozilla patches to get a running browser. r=jld,aklotz,tjr,bobowen This updates security/sandbox/chromium/ files to chromium commit 84108231f6e6e0772fb9a4643679ce76aa771e67. Existing and new patches applied from security/sandbox/chromium-shim/patches/with_update/ to give a compiling and mostly working browser. See patch files for additional commit comments.
b2cb7ee93eef1d56006716ed24f3d0c11e071f11: Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld
Michael Froman <mfroman@mozilla.com> - Mon, 10 Jun 2019 15:03:46 +0000 - rev 537887
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld Differential Revision: https://phabricator.services.mozilla.com/D34186
1d330fafedddde0c820308cddfd4e30351bfd477: Bug 1555891 - Merge PVideoDecoder into PRemoteDecoder. r=jya,jld
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 11 Jun 2019 02:01:51 +0000 - rev 537799
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555891 - Merge PVideoDecoder into PRemoteDecoder. r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D33587
a1198059b0809f9c752511256aaaec26a2c56a29: Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 11 Jun 2019 02:01:34 +0000 - rev 537798
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555891 - Merge PVideoDecoderManager into PRemoteDecoderManager. r=jya,jld Differential Revision: https://phabricator.services.mozilla.com/D33586
5a608649393bef07f165cba9526c5e859b9da090: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 19:56:51 +0000 - rev 537606
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
0635eeb2fad4f1bae96a51c85f8adddc11693e41: Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange
Tarek Ziadé <tarek@mozilla.com> - Fri, 07 Jun 2019 07:48:37 +0000 - rev 537523
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529023 - Enable threads on macOS for GetProcInfo r=jld,mstange To run task_for_pid() on child processes, we need the child task port for security reasons. This port can be obtained via a Mach IPC exchange. This is what GeckoChildProcessHost::GetChildTask() provides, so we use it in cocoa's version of GetProcInfo() Differential Revision: https://phabricator.services.mozilla.com/D25927
4357d695b8d5dd901788d922b73e89f16c45b2c9: Bug 1464032 Part 12: Add CanvasParent, CanvasChild and RecordedTextureData. r=mattwoodrow, jld
Bob Owen <bobowencode@gmail.com> - Sun, 02 Dec 2018 14:19:11 +0000 - rev 537455
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1464032 Part 12: Add CanvasParent, CanvasChild and RecordedTextureData. r=mattwoodrow, jld RecordedTextureData records TextureData calls for play back in the GPU process. CanvasChild and CanvasParent set up the recorder and translator. They also help to manage the starting of translation and co-ordinating the translation with the frame transactions. This patch also includes other changes to wire up recording and playback.
eba3d102aaaec6b608d61f35fb5043a44213c3da: Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 03 Jun 2019 21:35:44 +0000 - rev 536465
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld Differential Revision: https://phabricator.services.mozilla.com/D33517
aba5bfdd772bbc630ed53edb59aa43c0544484e8: Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 22 May 2019 01:33:46 +0000 - rev 534528
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld Don't hold gMutex when calling HandleSharePortsMessage() from PortServerThread to avoid deadlock. Differential Revision: https://phabricator.services.mozilla.com/D31694
969f29e56fa1b018fe790d888e05df6f1ddbdbb1: Bug 1547085 - Discard messages sent to dead actors, r=jld
Nika Layzell <nika@thelayzells.com> - Tue, 21 May 2019 17:04:25 +0000 - rev 534431
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1547085 - Discard messages sent to dead actors, r=jld Historically we've failed very loudly when receiving a message which was destined for an actor which had already been destroyed. This had the effect of requiring manual teardown for most actors, as work would need to be done to ensure messages weren't sent when the target actor might be about to tear itself down. In addition, due to this teardown work being done outside of IPDL, this work would have to manually be checked in subactors, and involved the addition of new flags, such as `mIPCOpen`, in order to track whether IPC had begun to be shut down, and discard messages manually if it had. It is an ongoing issue that we occasionally miss places where we need to discard messages, and it is easy to not remember to perform async destruction when building a new actor, meaning that extra work is required to correctly discard messages when the actor is being torn down. Due to the correct decision, almost all of the time, being to discard the message, this patch takes the approach of transforming the crash which was previously performed into a message discard. The hope is that this will reduce the burden on actor implementors, by allowing the use of `Send__delete__` without first synchronizing with the remote actor, as well as reduce unintentional crashes. Differential Revision: https://phabricator.services.mozilla.com/D28892
2a84ae0921d1b955b2f229b16ec84ca0937ceb0e: Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld, a=jcristau
Michael Froman <mfroman@mozilla.com> - Mon, 10 Jun 2019 15:03:46 +0000 - rev 533987
Push 11484 by jcristau@mozilla.com at Fri, 21 Jun 2019 06:08:09 +0000
Bug 1555076 - avoid a potential timeout race on Windows RDD launch. r=jld, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D34186
121bb815438386f3f7b31a39da9aa3f29bc96f18: Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld a=jcristau
Gian-Carlo Pascutto <gcp@mozilla.com> - Mon, 03 Jun 2019 21:35:44 +0000 - rev 533715
Push 11407 by opoprus@mozilla.com at Mon, 10 Jun 2019 12:30:38 +0000
Bug 1555589 - Include sys/prctl.h not linux/prctl.h. r=jld a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D33517
3b40f41fc5bef54def5ea1d0ccc0727f142dfdbd: Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld a=jcristau
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 22 May 2019 01:33:46 +0000 - rev 533385
Push 11307 by nbeleuzu@mozilla.com at Fri, 24 May 2019 18:27:55 +0000
Bug 1550771 - Deadlock in SharedMemoryBasic_mach triggered by AV1 playback r=jld a=jcristau Don't hold gMutex when calling HandleSharePortsMessage() from PortServerThread to avoid deadlock. Differential Revision: https://phabricator.services.mozilla.com/D31694
a64a71ccebf79139da2288edca29186292c5a257: Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld
Jan Varga <jan.varga@gmail.com> - Mon, 08 Apr 2019 10:56:19 +0200 - rev 531393
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld Differential Revision: https://phabricator.services.mozilla.com/D26476
7de7d6a0be86d400ee23ca1ac806eb358555b28d: Bug 1514869 - patch 8 - Make the SetCharacterMap message async, and use the unshared gfxCharacterMap in the content process until the shared one is in place. r=jwatt,jld
Jonathan Kew <jkew@mozilla.com> - Mon, 29 Apr 2019 14:39:05 +0000 - rev 530577
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1514869 - patch 8 - Make the SetCharacterMap message async, and use the unshared gfxCharacterMap in the content process until the shared one is in place. r=jwatt,jld Differential Revision: https://phabricator.services.mozilla.com/D24137
21ef00977ab69cd330d727d582fef291276391c4: Bug 1514869 - patch 1 - Basic implementation of a cross-process sharable font list, using shared memory to store the list of families & faces, and per-font character maps. r=jwatt,jld
Jonathan Kew <jkew@mozilla.com> - Sat, 27 Apr 2019 15:37:29 +0000 - rev 530570
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1514869 - patch 1 - Basic implementation of a cross-process sharable font list, using shared memory to store the list of families & faces, and per-font character maps. r=jwatt,jld Differential Revision: https://phabricator.services.mozilla.com/D22937
e25e95c59e6b1b913d895183d00461175ae5ab74: Bug 1494469 - Removed duplicate IPC::MAX_MESSAGE_SIZE constant r=jld
hafsa <hijitsuhisa@gmail.com> - Fri, 12 Apr 2019 13:01:41 +0000 - rev 528329
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494469 - Removed duplicate IPC::MAX_MESSAGE_SIZE constant r=jld The maximum size of an IPC message is defined twice; IPC::Channel::kMaximumMessageSize = 256 MiB and IPC::MAX_MESSAGE_SIZE = 65 KiB . The latter one is used for Windows printing and its small size could cause errors. I removed the small constant, and made changes to the files using it : - The windows printing file now uses kMaximumMessageSize / 2 - nsWebBrowserPersist uses its old constant Differential Revision: https://phabricator.services.mozilla.com/D24972
b34795658d239ba6415a9ad5e72fe10d7de38265: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE
Aaron Klotz <aklotz@mozilla.com> - Tue, 09 Apr 2019 00:45:24 +0300 - rev 527248
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld on a CLOSED TREE The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816
7ecc024df5d45ada7499e2f70d79670e8c9d4d51: Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld
Aaron Klotz <aklotz@mozilla.com> - Mon, 08 Apr 2019 20:19:51 +0000 - rev 527243
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541130: Add XRE_GetChildProcBinPathType to nsXULAppAPI.h; r=froydnj,jld The binary path type of a particular content process is useful information outside of IPC. Given that `XRE_EnableSameExecutableForContentProc` already exists, and given that the binary path type is closely related to `GeckoProcessType`, I've added a new function, `XRE_GetContentProcBinPathType`. The mapping of process type to binary type has been moved to the `GeckoProcessTypes` definitions. This patch also modifies `ipc::GeckoChildProcessHost` to call into the new function. Differential Revision: https://phabricator.services.mozilla.com/D25816