searching for reviewer(jimb)
7494e80f5b3e1af69e599908feac1bd21ccbac31: Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:25:26 -1000 - rev 531550
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
337d93c03c2e540b3f1d220f4ccbd1f9deb37435: Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Thu, 02 May 2019 08:25:26 -1000 - rev 531261
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
872645a5122c58a40f877a2291e5931a70e507e7: Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Fri, 19 Apr 2019 06:57:06 -1000 - rev 531112
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1392408 Part 1 - Add interface to help convert SavedFrames to JSON, r=jimb.
277725a3d886b7c192c37f2af5b60e0454a8350c: Bug 1477084 - Fix assertion with Debugger forcing return from an async generator before its initial yield. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Thu, 11 Apr 2019 17:49:03 +0000 - rev 527861
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1477084 - Fix assertion with Debugger forcing return from an async generator before its initial yield. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D14789
e647490b3655a5518a296ab09d164085ac21eacd: Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 23:04:01 +0000 - rev 520658
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb I don't understand how the test ever worked. I think the idea was that each operation would result in changes to the prefs, because those prefs are the source of truth for the recent-files list. However, I don't understand why some tests would not trigger multiple observer callbacks, which should have been a huge mess. The new code doesn't observe the prefs at all. Where possible, it waits for an appropriate promise; in other places it uses `setTimeout()` to wait for the next tick, relying on the Scratchpad implementation to be done reacting by then. Since the original code was event-driven, most tests were split across two functions. Each test function had the bottom half of one test and the top half of the next test. The new code uses async/await and can therefore at least group related functionality into single cohesive test functions. But those test functions aren't as independent as they look -- most of them still depend on previous tests to set up the expected starting state. Differential Revision: https://phabricator.services.mozilla.com/D20759
0f09d2f3b19f54fcb70933039fe57299daf0f273: Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 23:03:47 +0000 - rev 520657
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb Tests can use the promise to avoid racing on the text being available and the UI ready for interaction. Differential Revision: https://phabricator.services.mozilla.com/D20758
19d2e4ea75cfc67ad9a43fb704d91a7a485ea3bb: Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 01:06:46 +0000 - rev 520549
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 2: Rewrite a Scratchpad test to eliminate some race conditions. r=jimb I don't understand how the test ever worked. I think the idea was that each operation would result in changes to the prefs, because those prefs are the source of truth for the recent-files list. However, I don't understand why some tests would not trigger multiple observer callbacks, which should have been a huge mess. The new code doesn't observe the prefs at all. Where possible, it waits for an appropriate promise; in other places it uses `setTimeout()` to wait for the next tick, relying on the Scratchpad implementation to be done reacting by then. Since the original code was event-driven, most tests were split across two functions. Each test function had the bottom half of one test and the top half of the next test. The new code uses async/await and can therefore at least group related functionality into single cohesive test functions. But those test functions aren't as independent as they look -- most of them still depend on previous tests to set up the expected starting state. Differential Revision: https://phabricator.services.mozilla.com/D20759
af3e74a36fecd705da30496a44865a3a25d4ef6b: Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Wed, 06 Mar 2019 01:06:31 +0000 - rev 520548
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525395 - Part 1: Make Scratchpad.openFile return a promise. r=jimb Tests can use the promise to avoid racing on the text being available and the UI ready for interaction. Differential Revision: https://phabricator.services.mozilla.com/D20758
5adb94d8c8e0b264ce0d28c23e6a9c046373b87a: Bug 1447244 Part 4 - Add DebuggerSource.id, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Wed, 16 Jan 2019 11:59:57 -1000 - rev 518728
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1447244 Part 4 - Add DebuggerSource.id, r=jimb.
320d791829e22e3940e3dadd8a85fe9dd5ee5f88: Bug 1447244 Part 3 - Track source ID in JSErrorReport and ErrorObject, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Wed, 16 Jan 2019 11:59:34 -1000 - rev 518727
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1447244 Part 3 - Track source ID in JSErrorReport and ErrorObject, r=jimb.
37828dbf6749d4df221a8402099e6f5edec60e50: Bug 1447244 Part 2 - Track source ID in saved frames, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Wed, 16 Jan 2019 11:59:03 -1000 - rev 518726
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1447244 Part 2 - Track source ID in saved frames, r=jimb.
4d1b489236353ca9500c962b4c6441d63b5bd50c: Bug 1447244 Part 1 - Add unique id to ScriptSource, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Wed, 16 Jan 2019 11:58:33 -1000 - rev 518725
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1447244 Part 1 - Add unique id to ScriptSource, r=jimb.
5c934ede1cfccb44efad20006f58ecf7c85e761a: Bug 1518661 - Part 5: Give SpiderMonkey well-defined sense of step and breakpoint locations. r=jimb,bhackett
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:31:00 +0000 - rev 516787
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 5: Give SpiderMonkey well-defined sense of step and breakpoint locations. r=jimb,bhackett Until now, SpiderMonkey's debugger interfaces have generally relied on the implicitly-defined 'entrypoint' concept. This meant that assigning a given bytecode a position also automatically meant that it behaved like a breakpoint. This both made it hard to maintain, and hard to define user's expectations because there could potentially be many more breakpoints than users would actually want. This patch adds an official concept of recommended breakpoint and recommended step-next pause locations, and APIs for users to query for them. The expectation being that users would now use this metadata in debugging UIs. Differential Revision: https://phabricator.services.mozilla.com/D15994
5add2761a3b689c41f2cd57cfa772787e6fc21a3: Bug 1518661 - Part 4: Convert bytecode positions to be more expression-oriented. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:31:00 +0000 - rev 516786
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 4: Convert bytecode positions to be more expression-oriented. r=jimb,jorendorff This brings SpiderMonkey more in line with V8 for the positions that it uses for expressions nested within statements. We generally prefer to use the expression's own location rather than the location of the statement, in the majority of cases. Differential Revision: https://phabricator.services.mozilla.com/D15993
82a6589f4b919e399f1af4ae4831b8cb3436e0c8: Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:55:21 +0000 - rev 516731
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff When we mark call expressions as breakpoints, we want to make it as likely as possible that the call has its own unique positon. The existing logic means that it is more likely that the beginning of a call will align with the start of an expression statement or other debuggable step point. By using the property-access location, we're less likely to collide. Thid also adds a new bytecodes that were missed in the original code that added this position handling logic. Differential Revision: https://phabricator.services.mozilla.com/D17661
b7f9a1180f2356de24e63fe6f40949f914cc1b88: Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Wed, 13 Feb 2019 02:54:57 +0000 - rev 516729
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff This is just a bit of cleanup I'd noticed while writing new implementations of these. Differential Revision: https://phabricator.services.mozilla.com/D17659
d381785b0c4c0acf1c733fb8ea77fdafb1d15f37: Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Tue, 12 Feb 2019 23:46:27 +0000 - rev 516707
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff When we mark call expressions as breakpoints, we want to make it as likely as possible that the call has its own unique positon. The existing logic means that it is more likely that the beginning of a call will align with the start of an expression statement or other debuggable step point. By using the property-access location, we're less likely to collide. Thid also adds a new bytecodes that were missed in the original code that added this position handling logic. Differential Revision: https://phabricator.services.mozilla.com/D17661
64ebb085a6b3a5924ddc40c680bf40bb2459f1bd: Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Tue, 12 Feb 2019 23:45:18 +0000 - rev 516705
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff This is just a bit of cleanup I'd noticed while writing new implementations of these. Differential Revision: https://phabricator.services.mozilla.com/D17659
aeaa74707320c6c9af5fd1b8c234cba7608f2671: Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Tue, 12 Feb 2019 01:28:27 +0000 - rev 516515
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff When we mark call expressions as breakpoints, we want to make it as likely as possible that the call has its own unique positon. The existing logic means that it is more likely that the beginning of a call will align with the start of an expression statement or other debuggable step point. By using the property-access location, we're less likely to collide. Thid also adds a new bytecodes that were missed in the original code that added this position handling logic. Differential Revision: https://phabricator.services.mozilla.com/D17661
a4ff0bd9ff80f0d9129cb9d9138baffc87a1a836: Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Tue, 12 Feb 2019 01:27:22 +0000 - rev 516513
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff This is just a bit of cleanup I'd noticed while writing new implementations of these. Differential Revision: https://phabricator.services.mozilla.com/D17659
6c45ce836a12f98585902a3c0037b990424aa048: Bug 1518661 - Part 4: Assign the correct start position to arrow functions. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Fri, 08 Feb 2019 22:39:34 +0000 - rev 516229
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 4: Assign the correct start position to arrow functions. r=jimb,jorendorff This position ends up being used for source notes in some cases now, meaning that this can cause breakpoints to be given the wrong position when assigned to a variable. This fixes that by using the correct token for the position value. Differential Revision: https://phabricator.services.mozilla.com/D17662
dd2caed0182342a7be4e89942c7f7407a286b5da: Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Fri, 08 Feb 2019 22:39:23 +0000 - rev 516228
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 3: Adjust call-expression positions. r=jimb,jorendorff When we mark call expressions as breakpoints, we want to make it as likely as possible that the call has its own unique positon. The existing logic means that it is more likely that the beginning of a call will align with the start of an expression statement or other debuggable step point. By using the property-access location, we're less likely to collide. Thid also adds a new bytecodes that were missed in the original code that added this position handling logic. Differential Revision: https://phabricator.services.mozilla.com/D17661
8bad1d8c8944c2694643b3ffc3eb6d358f70ddbf: Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff
Logan Smyth <loganfsmyth@gmail.com> - Fri, 08 Feb 2019 22:37:46 +0000 - rev 516226
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1518661 - Part 1: Pass PropertyName* directly instead of creating ID. r=jimb,jorendorff This is just a bit of cleanup I'd noticed while writing new implementations of these. Differential Revision: https://phabricator.services.mozilla.com/D17659
7a9287969e243a81a4613cd2404d5a447fcea808: Bug 1516958 - Weaken failing assertion that fails to account for nuked wrappers. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Thu, 07 Feb 2019 22:21:44 +0000 - rev 515578
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516958 - Weaken failing assertion that fails to account for nuked wrappers. r=jimb In theory, nuking a debugger or debuggee compartment should sever all Debugger connections, but it doesn't (bug 1084626). Therefore we must tolerate dead objects in the allocation log. Differential Revision: https://phabricator.services.mozilla.com/D19064
227f1a73b16fba34216e1fb408eca5aeefcf8497: Bug 1477084 - Fix assertion with Debugger forcing return from an async generator before its initial yield. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Fri, 04 Jan 2019 16:22:31 +0000 - rev 509658
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1477084 - Fix assertion with Debugger forcing return from an async generator before its initial yield. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D14789
8bf9415e1de84e1d4050d3cf2d56d065e94adf5d: Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 28 Dec 2018 19:07:15 +0000 - rev 509185
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D15018
c3e4039f9d1eb6f1bad5e75e0d2c4d46c8549acf: Bug 1492937 - Make the JS subscript loader load scripts exclusively as UTF-8, with no way to specify any other encoding, and adjust a bunch of existing tests to use UTF-8 directly, rather than Unicode escape sequences or similar. (This also changes the encoding of .sjs scripts and all mochitest-browser tests in the tree from Latin-1 to UTF-8.) r=yzen, r=MattN, r=jimb, r=kmag
Jeff Walden <jwalden@mit.edu> - Wed, 19 Dec 2018 13:46:20 -0800 - rev 508565
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1492937 - Make the JS subscript loader load scripts exclusively as UTF-8, with no way to specify any other encoding, and adjust a bunch of existing tests to use UTF-8 directly, rather than Unicode escape sequences or similar. (This also changes the encoding of .sjs scripts and all mochitest-browser tests in the tree from Latin-1 to UTF-8.) r=yzen, r=MattN, r=jimb, r=kmag
ef37f622e40ebf5b4c23011cab444269b1c6d23e: Bug 801304 Part 3 - Add test that XHR does not break run-to-completion when paused in the debugger, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Fri, 14 Dec 2018 06:48:13 -1000 - rev 507909
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 801304 Part 3 - Add test that XHR does not break run-to-completion when paused in the debugger, r=jimb.
7bfd0ddce88e35eb5be95af2f62d7a50208b0741: Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb, a=RyanVM
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 28 Dec 2018 19:07:15 +0000 - rev 506662
Push 10502 by ryanvm@gmail.com at Sat, 12 Jan 2019 23:41:05 +0000
Bug 1515447 - Add receiver parameter to Debugger.Object's getProperty and setProperty. r=jimb, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D15018
10e651a2adff43b61e560dd13707598cc08b1bc9: Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester,jimb
Jason Orendorff <jorendorff@mozilla.com> - Sun, 09 Dec 2018 15:48:33 +0000 - rev 506115
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1503012 - Part 2: Shim some web-platform-tests for streams into the jit-tests. r=arai,chmanchester,jimb This is an egregious hack. The web-platform-tests were not meant to run in the shell. The eight tests that are included are the ones that we pass with flying colors. In most of the others, we still have a failure or two. Differential Revision: https://phabricator.services.mozilla.com/D11533
203424f500da8a1f759ee8be89d3274567926a3f: Bug 1510367 - More precisely specify the |breakpoint| function that ought be broken on in js/src/gdb/tests tests so that we don't mis-specify it on js::jit::AssemblerX86Shared::breakpoint. :-\ r=jimb
Jeff Walden <jwalden@mit.edu> - Tue, 20 Nov 2018 09:45:21 -0800 - rev 505373
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510367 - More precisely specify the |breakpoint| function that ought be broken on in js/src/gdb/tests tests so that we don't mis-specify it on js::jit::AssemblerX86Shared::breakpoint. :-\ r=jimb
12525933eb9e4b77aed03ef536aac18a36f81278: Bug 1501666 - Fix bug in elaborate assertion that counts step hooks. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Fri, 30 Nov 2018 01:23:39 +0000 - rev 505326
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501666 - Fix bug in elaborate assertion that counts step hooks. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D12493
c35837cdc103523d2d5d1d7920e6206bf658ad70: Bug 1244409 - Re-enable DOM worker debugger tests on linux. r=jimb
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 29 Nov 2018 07:41:08 +0000 - rev 505128
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1244409 - Re-enable DOM worker debugger tests on linux. r=jimb MozReview-Commit-ID: 64TZGSsmE7T Differential Revision: https://phabricator.services.mozilla.com/D13286
5cbc491766657725174cb9f025a59b0ef7de2b74: Bug 1494758 - Fix a multiply-busted Debugger test. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Fri, 19 Oct 2018 17:57:04 +0000 - rev 500201
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1494758 - Fix a multiply-busted Debugger test. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D7192
29cb1c5f801df211a1f8b36d8731e0c81519c760: Bug 1483709 - Remove bogus DebuggerFrame slot constants. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 30 Oct 2018 16:27:55 +0000 - rev 500185
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1483709 - Remove bogus DebuggerFrame slot constants. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D10102
6c8949f053e0e9c6216329d9b3f081fc0b6b2936: Bug 1448880 - Part 6: Re-enable stepping when an async or generator frame with an .onStep hook is resumed. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:24:11 +0000 - rev 499103
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 6: Re-enable stepping when an async or generator frame with an .onStep hook is resumed. r=jimb That is, don't put it off until Debugger::getFrame() is called. The effect is subtle, as indicated by the test changes: the onEnterFrame hooks in those tests were causing getFrame to be called very early during generator resumption, which made the tests pass. With this patch, we no longer adjust the step mode count when suspending or resuming. This change is necessary to make the frame->isDebuggee() call in Debugger::onResumeFrame the right criterion for calling slowPathOnResumeFrame. It's true if the step mode count on the script is nonzero. (This approach also simplifies error handling, as resuming a Debugger.Frame is now idempotent: we don't have to worry about adjusting the step mode count too much or not enough on error.) Depends on D6986 Differential Revision: https://phabricator.services.mozilla.com/D6988
27b0121d9e314b26e2c11857b18409f5dabbd75b: Bug 1448880 - Part 5: Tell removeFromFrameMapsAndClearBreakpointsIn() if we are suspending. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:36:35 +0000 - rev 499102
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 5: Tell removeFromFrameMapsAndClearBreakpointsIn() if we are suspending. r=jimb Since the argument is not used yet, this too is a pure refactoring, with no change in behavior yet. Depends on D6985 Differential Revision: https://phabricator.services.mozilla.com/D6986
61031045a58cad9c96f2051a858031bf37443769: Bug 1448880 - Part 4: Split Debugger::onResumeFrame from onEnterFrame. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:23:15 +0000 - rev 499101
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 4: Split Debugger::onResumeFrame from onEnterFrame. r=jimb Pure refactoring, no change in behavior. This is in anticipation of doing additional work in onResumeFrame. Depends on D6984 Differential Revision: https://phabricator.services.mozilla.com/D6985
9c03b503909a6d03150869a782d5e148870c20f5: Bug 1448880 - Part 3: AbstractFramePtr::isGeneratorFrame(). r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:23:07 +0000 - rev 499100
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 3: AbstractFramePtr::isGeneratorFrame(). r=jimb This proves handy in several places, later in the stack. Depends on D6983 Differential Revision: https://phabricator.services.mozilla.com/D6984
64810935a7516678a1e655b8d1034ac8700b53d7: Bug 1448880 - Part 2: Persist Debugger.Frame objects for generators across yield/await. r=jimb.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:22:00 +0000 - rev 499099
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 2: Persist Debugger.Frame objects for generators across yield/await. r=jimb. This is the minimal patch, but it leaves two bugs: 1. When a generator or async function is resumed, stepping is reenabled in Debugger::getFrame, which isn't necessarily called. The onStep tests in this patch work because they all use an onEnterFrame hook, which causes getFrame to be called as soon as the generator is resumed. 2. .onStep and .onPop hooks on suspended Frames do not survive GC if there are no other references to the Frame or the Debugger object. The behavior is safe, but the hooks can just mysteriously stop firing when GC happens. The next three patches in this stack lay the groundwork for fixing these bugs, without changing behavior; part 6 fixes the first bug; and part 7 fixes the second. Depends on D6982 Differential Revision: https://phabricator.services.mozilla.com/D6983
2f3da01d8816a0117e39eca43cd4c52c0a381a4d: Bug 1448880 - Part 1: Always close a generator on early forced return. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:21:01 +0000 - rev 499098
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1448880 - Part 1: Always close a generator on early forced return. r=jimb The previous code failed to close the generator in the case where JSOP_GENERATOR had run but JSOP_INITIAL_YIELD had not, a bit of sloppiness that created yet another special case. Things will get more complicated when we start keeping frames live while suspended; it's better to not have this special case. Differential Revision: https://phabricator.services.mozilla.com/D6982
5f68c00ed7d9c6f37c16a452f38d4c7ab42462db: Bug 956376 - Part 2: Support Debugger#findSource in WebReplay. r=jimb
Tooru Fujisawa <arai_a@mac.com> - Mon, 27 Aug 2018 08:17:39 +0900 - rev 493147
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 956376 - Part 2: Support Debugger#findSource in WebReplay. r=jimb
4c0cb356cbf18fb88059be94d1c40f3feb2433e5: Bug 956376 - Part 1: Add Debugger.findSources. r=jimb
Tooru Fujisawa <arai_a@mac.com> - Thu, 23 Aug 2018 09:27:30 +0900 - rev 493146
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 956376 - Part 1: Add Debugger.findSources. r=jimb
a577413d62ba7f7954e6f00c97c5e0db43a36acf: Bug 1488163 - Fix an compartment assertion that failed while evaluating another assertion. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 18 Sep 2018 15:22:17 +0000 - rev 492711
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488163 - Fix an compartment assertion that failed while evaluating another assertion. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D5303
309721897c1c45f166a2cd8f0332ea354e118db0: Bug 1468384 - Add Debugger.Script.isModule. r=jimb
Logan F Smyth <loganfsmyth@gmail.com> - Mon, 17 Sep 2018 19:35:23 +0000 - rev 492610
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1468384 - Add Debugger.Script.isModule. r=jimb Differential Revision: https://phabricator.services.mozilla.com/D5380
f33e65ea17cfa05865ab838768428b91d82934cc: Bug 1434391 - Fix OOM handling bug in Debugger (and eliminate an unnecessary wrap() call). r=jimb r=jorendorff
Jason Orendorff <jorendorff@mozilla.com> - Thu, 30 Aug 2018 11:09:46 -0500 - rev 491088
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1434391 - Fix OOM handling bug in Debugger (and eliminate an unnecessary wrap() call). r=jimb r=jorendorff
a5b2607fc1885b4f86cc7421fda89a19737788e4: Bug 1434391 - Fix OOM handling bug in Debugger (and eliminate an unnecessary wrap() call). r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Thu, 30 Aug 2018 11:09:46 -0500 - rev 491015
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1434391 - Fix OOM handling bug in Debugger (and eliminate an unnecessary wrap() call). r=jimb
71b13044d9c4b60e7daac28bd7b9a2dd20cc14a5: Bug 1488163 - Fix an compartment assertion that failed while evaluating another assertion. r=jimb a=pascalc
Jason Orendorff <jorendorff@mozilla.com> - Tue, 18 Sep 2018 15:22:17 +0000 - rev 489930
Push 9837 by nbeleuzu@mozilla.com at Wed, 19 Sep 2018 15:33:50 +0000
Bug 1488163 - Fix an compartment assertion that failed while evaluating another assertion. r=jimb a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D5303
0e0a9ee8560adeb81dfffbc2a5f1c367f196392d: Bug 1479909 Part 1 - Tolerate multiple scripts with the same source when replaying, r=jimb.
Brian Hackett <bhackett1024@gmail.com> - Thu, 30 Aug 2018 11:58:33 -1000 - rev 489550
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1479909 Part 1 - Tolerate multiple scripts with the same source when replaying, r=jimb.
55517d66b222c53a03d75e84d79d1a32f760274a: Bug 1479391 - Fix crash after forced return from a generator. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 14 Aug 2018 10:47:05 -0500 - rev 489130
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1479391 - Fix crash after forced return from a generator. r=jimb This patch switches from GeneratorObject::finalSuspend to setClosed in order to dodge an assertion in finalSuspend that the Generator state machine is transitioning along an expected edge. The way the Debugger manipulates Generator state is decidedly unexpected, from the perspective of the normal rules, and we've decided to accept that.