searching for reviewer(jfkthame)
aad364962b8221c5d805e84b377f84ed7d7a018e: Bug 1798494. r=jfkthame, a=dsmith
Andrew Osmond <aosmond@mozilla.com> - Thu, 24 Nov 2022 18:20:20 +0000 - rev 713338
Push 17309 by dsmith@mozilla.com at Mon, 28 Nov 2022 15:25:42 +0000
Bug 1798494. r=jfkthame, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D162616
865857977bab8231915c1aca03511cd982c385cd: Bug 1787551 - Disable Android's Font Match API on OPPO, realme and OnePlus. r=jfkthame,a=dsmith
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 18 Nov 2022 15:41:47 +0000 - rev 713276
Push 17282 by dsmith@mozilla.com at Tue, 22 Nov 2022 14:38:47 +0000
Bug 1787551 - Disable Android's Font Match API on OPPO, realme and OnePlus. r=jfkthame,a=dsmith According to crash data, some devices by OPPO and realme and OnePlus seem to crash when using Font Match API. I would like to disable it until root cause finds. Differential Revision: https://phabricator.services.mozilla.com/D162185
6625b1c05b83bb8775098bb9826312dfdf968f8f: Bug 1800072 - Remove special-case for XUL type="menu-button". r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 Nov 2022 14:38:07 +0000 - rev 712699
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1800072 - Remove special-case for XUL type="menu-button". r=jfkthame It broke in bug 1799343, and the TB folks are using type="menu", so let's remove this. Differential Revision: https://phabricator.services.mozilla.com/D161795
bac7456de5c6d3b73f33465908fbeea3bb3ad088: Bug 1799748 - Backport fix for libpixman CVE-2022-44638. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 09 Nov 2022 18:42:13 +0000 - rev 712613
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1799748 - Backport fix for libpixman CVE-2022-44638. r=jfkthame Backport of upstream commit: https://gitlab.freedesktop.org/pixman/pixman/-/commit/a1f88e842e0216a5b4df1ab023caebe33c101395 Differential Revision: https://phabricator.services.mozilla.com/D161624
6d6c7ba89b31f1716df98d5774857d019a351674: Bug 1798953 part 2: Annotate gfxSkipCharsIterator as MOZ_STACK_CLASS. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 03 Nov 2022 18:03:59 +0000 - rev 711911
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1798953 part 2: Annotate gfxSkipCharsIterator as MOZ_STACK_CLASS. r=jfkthame In practice, it's only instantiated on the stack; and that's kinda important, to reduce the likelihood that it somehow outlives the 'gfxSkipChars' instance that it maintains a raw pointer to and is iterating over. Differential Revision: https://phabricator.services.mozilla.com/D159922
3ca372ab2ceca82327882e044a4bbcf42c65641f: Bug 1798953 part 1: Initialize ClusterIterator::mIterator in the init list. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 03 Nov 2022 18:03:59 +0000 - rev 711910
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1798953 part 1: Initialize ClusterIterator::mIterator in the init list. r=jfkthame Before this patch, we implicitly invoke the default constructor for this member-var, and then immediately stomp on the results with a reassignment. This patch avoids that unnecessary usage of the default constructor, saving ourslves a bit of work and getting this member-var more directly into a fully-initialized/valid state. Differential Revision: https://phabricator.services.mozilla.com/D159903
03d862aee42e4e11a552199999c59886dd26d204: Bug 1797688 - Part 2: Bail out from gfxFontInfoLoader::StartLoader InOrBeyond(AppShutdown). r=jfkthame
Jens Stutte <jstutte@mozilla.com> - Tue, 01 Nov 2022 14:08:43 +0000 - rev 711628
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1797688 - Part 2: Bail out from gfxFontInfoLoader::StartLoader InOrBeyond(AppShutdown). r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D160620
46c1e1e644f589354b31e6ac6683005d7ea637d5: Bug 1793127. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Sun, 30 Oct 2022 23:48:26 +0000 - rev 711464
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1793127. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D159655
c3adab33084768d150a9c19228e765d0092f6409: Bug 1798080 part 2: Add const annotation to some never-modified member-vars in SVGTextFrame's helper classes, to reflect reality. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Sat, 29 Oct 2022 17:43:29 +0000 - rev 711438
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1798080 part 2: Add const annotation to some never-modified member-vars in SVGTextFrame's helper classes, to reflect reality. r=jfkthame This patch doesn't impact behavior. The new const annotations will help to simplify reasoning about these various helper classes & what states they could possibly be in. Differential Revision: https://phabricator.services.mozilla.com/D160695
d172c72030b9a30fca10649583e08c8924bc0e31: Bug 1798080 part 1: Add MOZ_STACK_CLASS annotation to some text layout/painting classes, to reflect reality. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Sat, 29 Oct 2022 17:43:29 +0000 - rev 711437
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1798080 part 1: Add MOZ_STACK_CLASS annotation to some text layout/painting classes, to reflect reality. r=jfkthame This patch doesn't impact behavior; it's just adding an annotation to activate a static analysis check for various classes. The annotation gives us some confidence that these instances are tightly scoped to a particular function-call. This helps reduce concerns about to-what-extent the affected classes might need to worry about the lifetimes of the objects pointed to by their member-vars. The specific classes I'm annotating are: - gfxTextRunDrawCallbacks and PaintTextParams, both of which have multiple subclasses, all of which will automatically inherit this annotation and benefit from it. - TextFrameIterator and CharIterator, two local utility classes in SVGTextFrame.cpp. Differential Revision: https://phabricator.services.mozilla.com/D160694
276b26a8ddb0b45ae5775c150c4dcf57f83d3f3e: Bug 1797146 - Remove system font support for various font longhands. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Oct 2022 14:42:49 +0000 - rev 711114
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1797146 - Remove system font support for various font longhands. r=jfkthame We don't use them[1], and these are generally not properties that authors would be able to set via the font shorthand anyways. Let's simplify the code. This fixes the font-variant bug and also unblocks further clean-ups of these properties in the future. [1]: https://searchfox.org/mozilla-central/rev/59f0bf3c13dd455d9f5415b89178de701ea6b850/widget/LookAndFeelTypes.ipdlh#12-18 Differential Revision: https://phabricator.services.mozilla.com/D160352
098c18154cb16919faafc902cf954cb40510e545: Bug 1791622 - Ensure FontFaceSet::Delete removes entries in the correct order. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Tue, 25 Oct 2022 14:05:29 +0000 - rev 710806
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1791622 - Ensure FontFaceSet::Delete removes entries in the correct order. r=jfkthame FontFaceSet and FontFaceSetImpl maintain independent but matching lists of FontFace and FontFaceImpl objects respectively. When FontFaceSet::Delete is called, we should remove from the FontFaceSet first instead of the FontFaceSetImpl because FontFaceSetImpl::Delete calls back into FontFaceSet to update its status if the removed FontFace was the last object holding it back from a status change. Differential Revision: https://phabricator.services.mozilla.com/D159857
f9d2d5f60fe9704ef62acae6098c7a83316280da: Bug 1796697 part 4: Annotate gfxSkipCharsIterator as MOZ_STACK_CLASS. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 24 Oct 2022 14:06:13 +0000 - rev 710629
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1796697 part 4: Annotate gfxSkipCharsIterator as MOZ_STACK_CLASS. r=jfkthame In practice, it's only instantiated on the stack; and that's kinda important, to reduce the likelihood that it somehow outlives the 'gfxSkipChars' instance that it maintains a raw pointer to and is iterating over. Differential Revision: https://phabricator.services.mozilla.com/D159922
b7ee22f54a6c6ee45f4a82d562181c14cedcc833: Bug 1796697 part 3: Use the 'NotNull' type to make it clear that gfxSkipCharsIterator::mSkipChars can never be null. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 24 Oct 2022 14:06:13 +0000 - rev 710628
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1796697 part 3: Use the 'NotNull' type to make it clear that gfxSkipCharsIterator::mSkipChars can never be null. r=jfkthame This patch doesn't change behavior; it's just using the type system to make it clearer that this variable never gets assigned to a null pointer. (In fact, its value is always initialized using the address of a C++ reference, which by definition is never null.) Note: we can't make the mSkipChars member itself into a C++ reference here; that would prevent gfxSkipCharsIterator instances from being reassignable (since C++ references can't be rebound), which would be a problem since we do in fact reassign gfxSkipCharsIterator instances in a few places. In contrast, this patch's NotNull-pointer mSkipChars does allow itself to be reassigned, which in turn allows gfxSkipCharsIterator to remain reassignable. Depends on D159903 Differential Revision: https://phabricator.services.mozilla.com/D159904
d43777f8ef79934859149bbd1efb018419d86ee3: Bug 1796697 part 2: Remove gfxSkipCharsIterator's dummy no-arg constructor, as well as its associated now-unnecessary "IsInitialized()" API. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 24 Oct 2022 14:06:12 +0000 - rev 710627
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1796697 part 2: Remove gfxSkipCharsIterator's dummy no-arg constructor, as well as its associated now-unnecessary "IsInitialized()" API. r=jfkthame This patch doesn't change behavior. This no-arg constructor only had one inadvertent usage -- it was used to default-initialize one of ClusterIterator's member-vars, just before we reassign it to something else in the constructor body. (I'm fixing that here by explicitly constructing that member-var up-front in the init list, rather than in the constructor body.) Depends on D159902 Differential Revision: https://phabricator.services.mozilla.com/D159903
a2763d3ad250047ca8ba498e4029c2fb459a5343: Bug 1796697 part 1: Update SVGTextFrame.cpp to use Maybe<> to represent an optionally-invalid gfxSkipCharsIterator. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 24 Oct 2022 14:06:12 +0000 - rev 710626
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1796697 part 1: Update SVGTextFrame.cpp to use Maybe<> to represent an optionally-invalid gfxSkipCharsIterator. r=jfkthame This patch shouldn't change behavior. This lets us remove the rarely-used no-arg constructor for gfxSkipCharsIterator in the next patch. (That constructor was an alternate representation of an invalid gfxSkipCharsIterator; but the Maybe<> representation added here makes things a bit easier to reason about.) Differential Revision: https://phabricator.services.mozilla.com/D159902
6535746d5911eaa475624bb77cccb471c07af64d: Bug 1795536 - Don't let resizer set the width/height properties of the target element if its size won't change. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 24 Oct 2022 10:31:19 +0000 - rev 710598
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1795536 - Don't let resizer set the width/height properties of the target element if its size won't change. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D159906
f4b1fb8a71dd45e7a37d4ca764a910f1f7c0cbe7: Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame
Neil Deakin <neil@mozilla.com> - Fri, 21 Oct 2022 09:11:27 +0000 - rev 710275
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D159703
05f17b2551cb8583002fa405a8982ca5c8166be2: Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame
Neil Deakin <neil@mozilla.com> - Thu, 20 Oct 2022 15:37:58 +0000 - rev 710213
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D159703
e53fcc445d5321f1a2bfc73559fe3b69df62f804: Bug 1796292 - Update HarfBuzz to 5.3.1. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 20 Oct 2022 13:23:12 +0000 - rev 710197
Push 17248 by ffxbld-merge at Mon, 14 Nov 2022 14:54:11 +0000
Bug 1796292 - Update HarfBuzz to 5.3.1. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D159779
2757f1eb82e255dff94f7d1bbbe1fa62970047ec: Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame, a=dmeehan
Neil Deakin <neil@mozilla.com> - Fri, 21 Oct 2022 09:11:27 +0000 - rev 709688
Push 17231 by dmeehan@mozilla.com at Wed, 02 Nov 2022 16:51:54 +0000
Bug 1791033, avoid crash by computing the extension's byte length correctly and truncate the filename's extension when it is too long, r=gsvelto,jfkthame, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D159703
21e88846cd99b12e6a4be9574cd1d76946708d71: Bug 1793127. r=jfkthame, a=dmeehan
Andrew Osmond <aosmond@mozilla.com> - Sun, 30 Oct 2022 23:48:26 +0000 - rev 709672
Push 17223 by dmeehan@mozilla.com at Tue, 01 Nov 2022 14:04:58 +0000
Bug 1793127. r=jfkthame, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D159655
c21f18c56e5483f8933a0df96b526f1991bbab75: Bug 1794407 - More reliable OSX menulist styling. r=jfkthame,mstange,desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 12 Oct 2022 10:43:41 +0000 - rev 709022
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1794407 - More reliable OSX menulist styling. r=jfkthame,mstange,desktop-theme-reviewers,dao So that they work with increased zoom leves on <select>. This effectively happened before, because width on XUL was being treated like min-width, effectively. Differential Revision: https://phabricator.services.mozilla.com/D158978
862b29c567ef03e4c50b97a38e10245b14ff9582: Bug 1794407 - More reliable OSX menulist styling. r=jfkthame,mstange
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Oct 2022 09:26:11 +0000 - rev 708938
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1794407 - More reliable OSX menulist styling. r=jfkthame,mstange So that they work with increased zoom leves on <select>. Differential Revision: https://phabricator.services.mozilla.com/D158978
4f5780d954a6593cd7b71e79c88c6a8d0b5ee45f: Bug 1794307 - Update HarfBuzz to 5.3.0. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 10 Oct 2022 13:13:02 +0000 - rev 708866
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1794307 - Update HarfBuzz to 5.3.0. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D158913
d938816c9cd1876cd724db059a54a3ba31a2b97c: Bug 1791108 - Ensure macOS checked checkmark is actually 15px. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Oct 2022 11:31:59 +0000 - rev 708631
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1791108 - Ensure macOS checked checkmark is actually 15px. r=jfkthame I can reproduce this. The issue here is that on XUL layout width sets the preferred width, but content might still expand the box size. In my machine the checkmark is 15.01px, which is enough to break the math and push the C away. Switching away from XUL flex into modern flex would fix it, but meanwhile this achieves the same effect and fixes the bug. Seems hard to add an automated test for this... Differential Revision: https://phabricator.services.mozilla.com/D158754
96d92a6cb032469ee380541b633794d12d9b9571: Bug 1792885 - Don't add NotoColorEmojiLegacy to font list if COLRv1 is supported. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Tue, 04 Oct 2022 06:23:58 +0000 - rev 708356
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1792885 - Don't add NotoColorEmojiLegacy to font list if COLRv1 is supported. r=jfkthame Gecko supports COLRv1 font when `gfx.font_rendering.colr_v1.enabled=true`. So I think we can disable bug 1760567's workaround to use COLRv1 version of Noto Color Emoji in Android 13 when `gfx.font_rendering.colr_v1.enabled=true`. Differential Revision: https://phabricator.services.mozilla.com/D158494
5b0f4e85a272f171c864e1f48c4b6f28439e07cc: Bug 1791290 - Update HarfBuzz to 5.2.0. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 21 Sep 2022 19:19:27 +0000 - rev 707541
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1791290 - Update HarfBuzz to 5.2.0. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D157590
6168b847e82104c7ede72c65794c57ac71ff158f: Bug 1791281 - Simplify our setup for font metric queries from style. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 20 Sep 2022 19:30:45 +0000 - rev 707446
Push 17159 by ffxbld-merge at Mon, 17 Oct 2022 13:42:28 +0000
Bug 1791281 - Simplify our setup for font metric queries from style. r=jfkthame While looking at moving the flag around I realized that the only reason we have FontMetricsProvider and co is because we didn't have access to the per-document font-prefs cache. That's trivial to fix tho, so do that and simplify the setup for font queries even more. Differential Revision: https://phabricator.services.mozilla.com/D157589
3d11fc84074269c1ccbc55076bb110243818d973: Bug 1791108 - Ensure macOS checked checkmark is actually 15px. r=jfkthame,mstange,spohl a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Oct 2022 11:31:59 +0000 - rev 707239
Push 17146 by pchevrel@mozilla.com at Thu, 06 Oct 2022 18:09:51 +0000
Bug 1791108 - Ensure macOS checked checkmark is actually 15px. r=jfkthame,mstange,spohl a=pascalc I can reproduce this. The issue here is that on XUL layout width sets the preferred width, but content might still expand the box size. In my machine the checkmark is 15.01px, which is enough to break the math and push the C away. Switching away from XUL flex into modern flex would fix it, but meanwhile this achieves the same effect and fixes the bug. Seems hard to add an automated test for this... Differential Revision: https://phabricator.services.mozilla.com/D158754
4687a05809821d13691b1ec13fe668bbd4049a89: Bug 1789905 - add 'week' support to mozIntl's formatbestUnit code, r=jfkthame
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 15 Sep 2022 07:53:17 +0000 - rev 706960
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1789905 - add 'week' support to mozIntl's formatbestUnit code, r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D157162
91edb8eb2baea8a7326c8014c685eca1848a187d: Bug 1785991 - Add COLRv1 fuzzer. r=jfkthame
Christian Holler <choller@mozilla.com> - Wed, 07 Sep 2022 11:27:34 +0000 - rev 706146
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1785991 - Add COLRv1 fuzzer. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D155056
28008334e7f0ff3b2c2bbcbfe5b0c560ec78a53c: Bug 1788785 - Skip placeholders for first-letter-finding code. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 02 Sep 2022 15:07:15 +0000 - rev 705373
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1788785 - Skip placeholders for first-letter-finding code. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D156294
9c804d2af20e84e3348989614dcb3083b159db99: Bug 1786513 - Make SimpleResizeReflow not flush by default. r=jfkthame,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Sep 2022 10:54:24 +0000 - rev 705245
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1786513 - Make SimpleResizeReflow not flush by default. r=jfkthame,layout-reviewers Only GeckoMVMContext really needs the flush, to measure scrolled height afterwards. Do that explicitly. This shouldn't change behavior, for the most part; there was a preload test that relied on the flush when changing DPI to start a run really clean, but other than that this looks green on try. Should at best be neutral (just code clean-up), or be a performance improvement. In a follow-up, we can possibly remove the DelayedResize code from the view manager, though I need to think how to possibly coalesce the MVM reflows, so let's not do that yet. Differential Revision: https://phabricator.services.mozilla.com/D155385
f9408b84600bb52e39a9a27db92a134a53e43f3f: Bug 1404086 - Early-out when the length adjust scale factor is zero. r=jfkthame
Nicolas Silva <nsilva@mozilla.com> - Tue, 30 Aug 2022 09:45:46 +0000 - rev 699909
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1404086 - Early-out when the length adjust scale factor is zero. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D155834
e29b0fbf77f13b756463397b77738e8d9395c592: Bug 1786513 - Make SimpleResizeReflow not flush by default. r=jfkthame,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Aug 2022 12:58:12 +0000 - rev 699657
Push 17066 by ffxbld-merge at Mon, 19 Sep 2022 09:56:23 +0000
Bug 1786513 - Make SimpleResizeReflow not flush by default. r=jfkthame,layout-reviewers Only GeckoMVMContext really needs the flush, to measure scrolled height afterwards. Do that explicitly. This shouldn't change behavior, for the most part; there was a preload test that relied on the flush when changing DPI to start a run really clean, but other than that this looks green on try. Should at best be neutral (just code clean-up), or be a performance improvement. In a follow-up, we can possibly remove the DelayedResize code from the view manager, though I need to think how to possibly coalesce the MVM reflows, so let's not do that yet. Differential Revision: https://phabricator.services.mozilla.com/D155385
3cf88b8fe9206b1a3beed0de0a924f0fdb414a12: Bug 1786088: Run the font-loader task eagerly for dom/html mochitests. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Sun, 21 Aug 2022 23:01:56 +0000 - rev 699001
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1786088: Run the font-loader task eagerly for dom/html mochitests. r=jfkthame This helps avoid intermittent test failures that otherwise might happen if a "font-info-updated" notification arrives partway through a test and causes an unexpected restyle & reframe. Differential Revision: https://phabricator.services.mozilla.com/D155156
866e80f446586dea16695d94dc8e672fd1b652d5: Bug 1784940 - Acquire/release locks in gfxFont::Measure fewer times. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Wed, 17 Aug 2022 15:19:22 +0000 - rev 698708
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1784940 - Acquire/release locks in gfxFont::Measure fewer times. r=jfkthame gfxFont::Measure would acquire/release a read-only lock on gfxGlyphExtents::mLock for every glyph in the text run. This patch makes it so that we once the lock once. We may need to populate the gfxGlyphExtents hashtable once, where we need to upgrade to a read-write lock. Differential Revision: https://phabricator.services.mozilla.com/D154816
4267ceaa7558c79dd4d6789a6bfcb6ced5c25180: Bug 1781558 - Update HarfBuzz to 5.1.0. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 10 Aug 2022 17:47:44 +0000 - rev 697960
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1781558 - Update HarfBuzz to 5.1.0. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D152830
5c3218d57119a9c339668054ce9f7e75f4a0d76d: Bug 1781177 - Refactor gfxFont::GetShapedWord to use lambdas. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Thu, 04 Aug 2022 10:42:45 +0000 - rev 697376
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1781177 - Refactor gfxFont::GetShapedWord to use lambdas. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D153634
fc0b5ff1637955705a824b5a509f6cd0809ed693: Bug 1782947 - Check for null pres context in nsLayoutUtils::GetTextRunFlagsForStyle. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Wed, 03 Aug 2022 14:05:29 +0000 - rev 697196
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782947 - Check for null pres context in nsLayoutUtils::GetTextRunFlagsForStyle. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D153583
9bf4473c5219d406f7d2509024ca483872b1fba2: Bug 1782710 - Avoid accessing network service or principals on worker threads with font pathways. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Wed, 03 Aug 2022 11:39:34 +0000 - rev 697181
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782710 - Avoid accessing network service or principals on worker threads with font pathways. r=jfkthame We do some initialization of gfxFontSrcURI and gfxFontFaceSrc that is main thread only on the DOM worker threads. These portions of the initialization can easily be deferred to on demand access since they are only ever used on the main thread itself. Differential Revision: https://phabricator.services.mozilla.com/D153461
f4e889c6bd9646fb9d729c2da011b2479bacb658: Bug 1782731 - Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Tue, 02 Aug 2022 20:58:41 +0000 - rev 697009
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782731 - Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame This pref could be accessed off the main thread with workers. Convert it to a threadsafe StaticPref. Differential Revision: https://phabricator.services.mozilla.com/D153470
32689459fc627339fe17cbf6228c7309d3ad89c1: Bug 1782731 - Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Tue, 02 Aug 2022 15:07:34 +0000 - rev 696958
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782731 - Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame This pref could be accessed off the main thread with workers. Convert it to a threadsafe StaticPref. Differential Revision: https://phabricator.services.mozilla.com/D153470
b7b04703f99dad1c5de3a89038776b1dc3f68c1a: Bug 1782710 - Avoid accessing network service or principals on worker threads with font pathways. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Tue, 02 Aug 2022 14:26:57 +0000 - rev 696954
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1782710 - Avoid accessing network service or principals on worker threads with font pathways. r=jfkthame We do some initialization of gfxFontSrcURI and gfxFontFaceSrc that is main thread only on the DOM worker threads. These portions of the initialization can easily be deferred to on demand access since they are only ever used on the main thread itself. Differential Revision: https://phabricator.services.mozilla.com/D153461
4979a1899d2ebe7d4696c310d2124e3240694e8c: Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame
Pier Angelo Vendrame <pierov@torproject.org> - Tue, 02 Aug 2022 10:30:35 +0000 - rev 696921
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1774413: Bundled fonts are not picked up on macOS r=jfkthame Bundled fonts were not picked up because also child processes need to register them. Also, they were assigned User visibility, instead of Base, which was not coherent with other platforms. Differential Revision: https://phabricator.services.mozilla.com/D150400
577c514ce632eb519f1fe0faf13d673b3548722e: Bug 1780193 - Refactor gfxFontCache expiration behaviour to mitigate perf reductions. r=jfkthame
Andrew Osmond <aosmond@mozilla.com> - Fri, 29 Jul 2022 14:48:38 +0000 - rev 696702
Push 16977 by ffxbld-merge at Mon, 22 Aug 2022 14:10:44 +0000
Bug 1780193 - Refactor gfxFontCache expiration behaviour to mitigate perf reductions. r=jfkthame In this patch, we make gfxFont use normal AddRef/Release semantics, and instead now hold a strong reference to it inside the cache. At all times a font should be in the expiration tracker, and whenever a lookup is performed, we mark it as used. When the tracker attempts to expire an entry, we check to see if the only strong reference is inside the cache itself. If so, it is deleted. If not, we mark it as used again instead of expiring it. This has the advantage of making gfxFont::Release cheaper when there is only one outstanding reference left outside the cache. It used to acquire the gfxFontCache mutex in order to reinsert the font into the expiration tracker when the last strong reference was cleared. This is a very common case since the typical use case is only the main thread is interacting with the cache, one font reference at a time. This does not completely restore us to the previous performance observed, but it does reclaim half of the original design benefit while remaining threadsafe. Differential Revision: https://phabricator.services.mozilla.com/D153110
1dcb29795850db0c2baf36789c2df0760a5d0e9d: Bug 1782947 - Check for null pres context in nsLayoutUtils::GetTextRunFlagsForStyle. r=jfkthame, a=dsmith
Andrew Osmond <aosmond@mozilla.com> - Wed, 03 Aug 2022 14:05:29 +0000 - rev 696121
Push 16931 by dsmith@mozilla.com at Thu, 04 Aug 2022 18:37:42 +0000
Bug 1782947 - Check for null pres context in nsLayoutUtils::GetTextRunFlagsForStyle. r=jfkthame, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D153583
e80c5ded53d60962745e413c6204b979c34e565b: Bug 1780540 - Don't forget charmap after setting in a font entry. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 Jul 2022 14:58:13 +0000 - rev 695806
Push 16885 by ffxbld-merge at Mon, 25 Jul 2022 15:04:18 +0000
Bug 1780540 - Don't forget charmap after setting in a font entry. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D152379
1047dbd1683d05567dc75ff5c2fca494ae75b072: Bug 1780461 - Fix HarfBuzz Wcomma errors introduced in version 4.4.1. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 21 Jul 2022 14:33:08 +0000 - rev 695801
Push 16885 by ffxbld-merge at Mon, 25 Jul 2022 15:04:18 +0000
Bug 1780461 - Fix HarfBuzz Wcomma errors introduced in version 4.4.1. r=jfkthame Cherry-pick of upstream commit: https://github.com/harfbuzz/harfbuzz/pull/3719 Differential Revision: https://phabricator.services.mozilla.com/D152318