searching for reviewer(jfkthame)
9762ed4cda7a8591349dfe72c01caa69bb6d282a: Bug 1615899 - Update expectancies for writing-system-line-break-001.html on win 7 debug. r=jfkthame
Mihai Alexandru Michis <malexandru@mozilla.com> - Sat, 27 Jun 2020 09:24:49 +0000 - rev 601825
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1615899 - Update expectancies for writing-system-line-break-001.html on win 7 debug. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D81433
c214953fc30a030e6a42a076e20eede641cd2873: Bug 1647774 - Fix a clang-11 error about FNCMapEntry in gfxFT2FontList.cpp r=jfkthame
David Major <dmajor@mozilla.com> - Fri, 26 Jun 2020 14:34:24 +0000 - rev 601677
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647774 - Fix a clang-11 error about FNCMapEntry in gfxFT2FontList.cpp r=jfkthame clang-11 is unhappy about this typedef being anonymous when it's not C-compatible due to the base class. This could be fixed by adding a tag, but looking around at other subclasses of `PLDHashEntryHdr`, most instances just define the struct in the C++ way. Differential Revision: https://phabricator.services.mozilla.com/D80681
10febd201f132f2debff3aa96c7e995733e66d0b: Bug 1648287 - Restore changes from bug 1646926 lost via bug 1644895 r=jfkthame
longsonr <longsonr@gmail.com> - Wed, 24 Jun 2020 23:51:39 +0000 - rev 601368
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648287 - Restore changes from bug 1646926 lost via bug 1644895 r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D80980
d2d4420f7b52ba45cf88499374ee4db1633d76a9: Bug 1647303 - Update HarfBuzz to 2.6.8. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 22 Jun 2020 15:44:53 +0000 - rev 600701
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647303 - Update HarfBuzz to 2.6.8. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D80476
ff1782eb34f0840d5d922d6c9feb6ec1f6dd539e: Bug 1644575 part 2: Remove now unused SFNT* files and functions. r=jfkthame
Bob Owen <bobowencode@gmail.com> - Mon, 22 Jun 2020 12:19:56 +0000 - rev 600623
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644575 part 2: Remove now unused SFNT* files and functions. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D80429
81f749c7b1ad017eca2806a84f16905e10e66e8f: Bug 1644575: Change SFNTData::GetUniqueKey to use a hash of head tables within the font data. r=jfkthame
Bob Owen <bobowencode@gmail.com> - Mon, 22 Jun 2020 12:19:39 +0000 - rev 600622
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644575: Change SFNTData::GetUniqueKey to use a hash of head tables within the font data. r=jfkthame This is used instead of hashing the first full name. Differential Revision: https://phabricator.services.mozilla.com/D80412
7a13c77442451fdb9fd1032f605f1322a218702b: Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Jun 2020 09:45:40 +0000 - rev 600616
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame This avoids arbitrary precision loss when computing REM units and so on, which is particularly important if we ever change the base of our app units (but useful regardless). Differential Revision: https://phabricator.services.mozilla.com/D79928
ac468fb1ea9db6653e39c5fcfbaebea8ac07673b: Bug 1646240 - Default to visual selection direction on non-Linux Nightly r=jfkthame
Kagami Sascha Rosylight <saschanaz@outlook.com> - Sat, 20 Jun 2020 20:53:59 +0000 - rev 600563
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646240 - Default to visual selection direction on non-Linux Nightly r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D79939
299e19193e11d8a8e40279d86b45fa189e9b8710: Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jun 2020 13:55:03 +0000 - rev 600387
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame This avoids arbitrary precision loss when computing REM units and so on, which is particularly important if we ever change the base of our app units (but useful regardless). Differential Revision: https://phabricator.services.mozilla.com/D79928
7b238f810d269de00cec04e50271add78b2ab164: Bug 1645003 - Return pointer from GetPrimaryOrCaretFrameForNodeOffset and its deps r=jfkthame
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 18 Jun 2020 10:26:47 +0000 - rev 600372
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645003 - Return pointer from GetPrimaryOrCaretFrameForNodeOffset and its deps r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D80063
ac246edd1e3657a2a7a7326a7db5455d3304e419: Bug 1645713 - Do less work when finding common ancestor for text run creation. r=jfkthame
Cameron McCormack <cam@mcc.id.au> - Tue, 16 Jun 2020 23:40:37 +0000 - rev 600051
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645713 - Do less work when finding common ancestor for text run creation. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D79625
fb27ef9d01e058045a3c0016a12d8ae399779512: Bug 1645879 - Detect reversed direction frame when collapsing selection r=jfkthame
Kagami Sascha Rosylight <saschanaz@outlook.com> - Tue, 16 Jun 2020 11:52:49 +0000 - rev 599934
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645879 - Detect reversed direction frame when collapsing selection r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D79739
5fbe59ee691017c6c9cabf862abd0471675bb74b: Bug 1645045 - Don`t assume the last fallback is the last locale in gtest. r=jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Thu, 11 Jun 2020 18:40:35 +0000 - rev 599250
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645045 - Don`t assume the last fallback is the last locale in gtest. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D79313
fe18d84dddfc4b7ee7158115778caae23e4b0fdf: Bug 1645132 - Use NSToCoordCeilClamped to prevent overflow when laying out very big text nodes. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Jun 2020 18:18:45 +0000 - rev 599247
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1645132 - Use NSToCoordCeilClamped to prevent overflow when laying out very big text nodes. r=jfkthame The test in D79145 hits a negative isize assertion because of this. Differential Revision: https://phabricator.services.mozilla.com/D79328
dacfcfdaac0b92294ee6000f09df47711950e83b: Bug 1644868 - Return pointer from GetPrimaryFrameFor* r=jfkthame
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 11 Jun 2020 10:56:11 +0000 - rev 599152
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644868 - Return pointer from GetPrimaryFrameFor* r=jfkthame Those methods have two sources to check after call: the return value and the pointer. This can be confusing as a caller may think they should check both when they don't need to. Since the two always behaves together (a valid pointer + NS_OK, or nullptr + NS_ERROR_FAILURE), this replaces the return value with the pointer. Differential Revision: https://phabricator.services.mozilla.com/D79196
66c8ca356eda12add3ab014dea4b80cbacb169c4: Bug 1644511 - Part 2: Make selection collapsing follow bidi.edit.caret_movement_style r=jfkthame
Kagami Sascha Rosylight <saschanaz@outlook.com> - Wed, 10 Jun 2020 21:17:51 +0000 - rev 599060
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644511 - Part 2: Make selection collapsing follow bidi.edit.caret_movement_style r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D79005
de37ec69840f553cd99c607a7d8d144d65532fae: Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Sun, 31 May 2020 07:12:31 +0000 - rev 598035
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug Differential Revision: https://phabricator.services.mozilla.com/D71815
c2e9a178e0a329a67c1227d8abc5267541c21cca: Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Sun, 31 May 2020 07:12:35 +0000 - rev 598033
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71679
b2be75c1d5855dc0bf41ea74ff29f70ec29a283c: Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Sun, 31 May 2020 07:12:38 +0000 - rev 598032
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71677
c474b7ffe3af28e1f3ca7c7f3589647cdfa29a32: Bug 1643005 - Update HarfBuzz to 2.6.7. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 03 Jun 2020 17:38:40 +0000 - rev 597832
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643005 - Update HarfBuzz to 2.6.7. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D78056
8fcbd624276badee1dfada3021eb7197da3b7aae: Bug 1639698 - Ensure that the first text run that triggers a font load has its drawing skipped if needed. r=jfkthame
Cameron McCormack <cam@mcc.id.au> - Mon, 01 Jun 2020 10:04:36 +0000 - rev 597477
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1639698 - Ensure that the first text run that triggers a font load has its drawing skipped if needed. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D77578
02618db5d8ca7d1af19cccb38c8386a095faa2d1: Bug 1626761 - Fixing readability-else-after-return bug, found by clang-tidy. r=jfkthame
bharath bmsce <bharath.bmsce@yahoo.in> - Mon, 01 Jun 2020 11:48:19 +0000 - rev 597288
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1626761 - Fixing readability-else-after-return bug, found by clang-tidy. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D77591
74b6fa2a1409d7576547bc57487dc5f69352b371: Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Sat, 30 May 2020 09:37:02 +0000 - rev 596897
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug Differential Revision: https://phabricator.services.mozilla.com/D71815
77ff0aee23f6d6a1a65f76c0a6b6e4e23a8eb447: Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Sat, 30 May 2020 09:36:37 +0000 - rev 596895
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71679
90bde53721ac5bf10a14f3d48bf08b1c01a5aa76: Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Sat, 30 May 2020 09:36:25 +0000 - rev 596894
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71677
b4aa2007863153e3b39aef004689964d728b1038: Bug 1629113 - Use specific prompt for onbeforeunload. r=johannh,jfkthame
Agi Sferro <agi@sferro.dev> - Fri, 22 May 2020 16:24:12 +0000 - rev 595493
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1629113 - Use specific prompt for onbeforeunload. r=johannh,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D72721
38f56c3806e41af2013c3ed16002518ca56b2dbe: Bug 1640263 - Remove a dead function declaration in nsIWidget.h. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 May 2020 21:28:43 +0000 - rev 595469
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1640263 - Remove a dead function declaration in nsIWidget.h. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D76532
9b4e5fe79094f8a61f161100fa9273f75a4d953f: Bug 1639563 - fix GCC internal compiler error. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Fri, 22 May 2020 16:53:29 +0000 - rev 595444
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639563 - fix GCC internal compiler error. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D76508
3391ec4e90a52591835b253dd476a7f1e72cf0f8: Bug 1639563 - factor out gfxOTSContext into reusable header file. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Fri, 22 May 2020 04:47:44 +0000 - rev 595427
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639563 - factor out gfxOTSContext into reusable header file. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D76358
43abf0a9602a925e6a96b6510e8cb6197c32f5a2: Bug 1639563 - factor out gfxOTSContext into reusable header file. r=jfkthame
Lee Salzman <lsalzman@mozilla.com> - Thu, 21 May 2020 21:12:37 +0000 - rev 595301
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639563 - factor out gfxOTSContext into reusable header file. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D76358
9bfa9853d763b83aa4cbc63c8a5c50f991964d9e: Bug 1638331 - Expand the conditions for crashing in GetDWriteSystemFonts. r=jfkthame
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 15 May 2020 17:00:03 +0000 - rev 595064
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638331 - Expand the conditions for crashing in GetDWriteSystemFonts. r=jfkthame We're not seeing any crashes so let's look for a null systemFonts as well. Differential Revision: https://phabricator.services.mozilla.com/D75546
a20b9fb485fce4a3b149e9a61045e33bb424f53d: Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 19 May 2020 16:28:13 +0000 - rev 594581
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Cache bundles in Localization C++. r=jfkthame,smaug Differential Revision: https://phabricator.services.mozilla.com/D71815
ee3255e55ab3488c3a9b5ed770e43d458b80c482: Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 19 May 2020 16:27:58 +0000 - rev 594579
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Move aIsSync to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71679
7d5a3d1035dc4283912d270549a0532fee02bc0d: Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 19 May 2020 16:30:42 +0000 - rev 594578
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631593 - Move resourceIds to Localization C++. r=stas,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71677
60e704719c059532c00d93fc18ae2cda8ae01524: Bug 1637771 - Don't draw inner focus ring styles for unthemed buttons / combo-boxes. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 May 2020 14:11:26 +0000 - rev 593621
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637771 - Don't draw inner focus ring styles for unthemed buttons / combo-boxes. r=jfkthame Now that we have outlines for them, unthemed select / buttons show two different focus indicators, which is undesired. Furthermore, the ones in comboboxes are basically unremovable / unstylable, so authors end up having to use massive hacks to do it, see bug 1580935. This fixes it elegantly (IMO) by just rendering them when themed (which is what these were for anyway, to match the windows theme). Differential Revision: https://phabricator.services.mozilla.com/D75283
18afbaa4a0063992c60dc15e7a634a8eceba1bb9: Bug 1636998 - Only suppress auto-style outlines for widgets that paint their own focus indicator. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 May 2020 20:38:26 +0000 - rev 593453
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636998 - Only suppress auto-style outlines for widgets that paint their own focus indicator. r=jfkthame Turns out we did have a hook for this already! But it is used to draw or not inner button styles, so not quite equivalent. I had to expand the amount of things it applies to because buttons and such do paint focus indicators in all widgets. This patch could cause some undesired outlines in some widgets. I hope not (I tried to audit to the best of my knowledge), but in that case they'd be just more values to add to the list. Differential Revision: https://phabricator.services.mozilla.com/D74733
f5546bfc96041192518676f44d328ac533b595b2: Bug 1636998 - Only suppress auto-style outlines for widgets that paint their own focus indicator. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 May 2020 14:47:07 +0000 - rev 593422
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636998 - Only suppress auto-style outlines for widgets that paint their own focus indicator. r=jfkthame Turns out we did have a hook for this already! But it is used to draw or not inner button styles, so not quite equivalent. I had to expand the amount of things it applies to because buttons and such do paint focus indicators in all widgets. This patch could cause some undesired outlines in some widgets. I hope not (I tried to audit to the best of my knowledge), but in that case they'd be just more values to add to the list. Differential Revision: https://phabricator.services.mozilla.com/D74733
7783096f5b4e9d3a86cb3a206634ae8928c5a639: Bug 1631118 - Update HarfBuzz to 2.6.6. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 12 May 2020 17:12:15 +0000 - rev 593177
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631118 - Update HarfBuzz to 2.6.6. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71420
a3f5d01bee732bd53d36aafcba84c11719c41f8e: Bug 1631118 - Update HarfBuzz to 2.6.6. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 12 May 2020 08:42:31 +0000 - rev 593059
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1631118 - Update HarfBuzz to 2.6.6. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D71420
a9c05c4d4107bdf493b413f1373f0c1f8ef7de4d: Bug 1636963 - Update freetype2 to 2.10.2. r=jfkthame
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 11 May 2020 11:15:16 -0400 - rev 592896
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636963 - Update freetype2 to 2.10.2. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D74709
64190615fc2217db63de798eecc474f4c1956525: Bug 633109 - Use system font iterator APIs if Andorid API 29+. r=jfkthame
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 07 May 2020 11:03:08 +0000 - rev 592488
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 633109 - Use system font iterator APIs if Andorid API 29+. r=jfkthame Android API 29 or later has font matcher and system font API that is for accessing font data from native code. Although Android's Default fonts are installed `/system/fonts`, some vendors also install some fonts in another directories. Example, Pixel 2's fonts are installed in `/system/fonts` and `/product/fonts`. Differential Revision: https://phabricator.services.mozilla.com/D70533
0010e22f0dafa5d3f8b7fe095dd0ca51b745d38b: Bug 1311444 - Disable outline-style: auto rendering on themed widgets, and use it for elements for which we otherwise disable outlines by default. r=Jamie,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 May 2020 09:48:31 +0000 - rev 592121
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1311444 - Disable outline-style: auto rendering on themed widgets, and use it for elements for which we otherwise disable outlines by default. r=Jamie,jfkthame This guarantees outline indicators for these elements even if not natively styled. Differential Revision: https://phabricator.services.mozilla.com/D73856
845efef1d2f61dbfffa135d5e338f961b2177967: Bug 1626570 - Improve handling of copying arrays in layout/generic/. r=jfkthame
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 05 May 2020 10:11:01 +0000 - rev 591868
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1626570 - Improve handling of copying arrays in layout/generic/. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D72353
b256a79e09213a2481eb91844106fddfc977fb04: Bug 1634743 - Fix caret baseline on a line with only inlines to account for line-height properly. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 May 2020 19:18:27 +0000 - rev 591304
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1634743 - Fix caret baseline on a line with only inlines to account for line-height properly. r=jfkthame While I'm looking at this code... This fixes the case described in comment 46. Differential Revision: https://phabricator.services.mozilla.com/D73465
a38299795286f775856652593dee810cff56a6d7: Bug 1634543 - Fix caret baseline of a block with only empty lines. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 May 2020 14:34:11 +0000 - rev 591228
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1634543 - Fix caret baseline of a block with only empty lines. r=jfkthame Even with the fix above, we get the caret baseline wrong because the line is non-empty, but the baseline is all the way to the top. Maybe an alternative to this would be to move the line-height hack to the beginning of layout but that sounds a bit more fishy. Otherwise we should do this more often, I suspect. I added one test that fails because of nsInlineFrame... Anyhow probably follow-up material? Depends on D73362 Differential Revision: https://phabricator.services.mozilla.com/D73363
b97ab5796dec6061b5689483ec2bc2371ba598f3: Bug 1634543 - Make emptiness check for contenteditable also account for empty frames. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 May 2020 15:05:34 +0000 - rev 591227
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1634543 - Make emptiness check for contenteditable also account for empty frames. r=jfkthame Like abspos and other out of flows. Seems to match more what other browsers do. Differential Revision: https://phabricator.services.mozilla.com/D73362
54553700d61d6f8cbb0ad1fee5a023b9b7dc7d36: Bug 1633828 - Check for empty text nodes in nsFind::PeekNextChar. r=jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 May 2020 14:26:25 +0000 - rev 591222
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1633828 - Check for empty text nodes in nsFind::PeekNextChar. r=jfkthame This check was done in GetNextNonEmptyTextFragmentInSameBlock which I removed in bug 1627643. Hopefully the fuzzer finds an easy reduced test-case to land as a crashtest, otherwise I can try to construct one. Differential Revision: https://phabricator.services.mozilla.com/D72926
df52240beaab53ecca8ac2a31905233197f67228: Bug 1633910 - Encode all whitespaces but single or isolated \u0020. r=jfkthame
Marco Bonardo <mbonardo@mozilla.com> - Wed, 29 Apr 2020 12:44:54 +0000 - rev 590259
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1633910 - Encode all whitespaces but single or isolated \u0020. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D73026
554dcd35c9e0d2f43b8050415afb283da34dde8c: Bug 1633225 - r=jfkthame
Marco Bonardo <mbonardo@mozilla.com> - Tue, 28 Apr 2020 21:48:58 +0000 - rev 590128
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1633225 - r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D72680
578d8d0d8c6e202078409f99846c70a5e07b54a8: Bug 1629506. r=jfkthame
Marco Bonardo <mbonardo@mozilla.com> - Tue, 28 Apr 2020 20:04:26 +0000 - rev 590070
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1629506. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D72608