searching for reviewer(jdm)
14faf5e9443e08f1c9ca8a010c7e4214783116a9: Bug 1529591 - Check Mac system geo permission prior to showing request permission dialog. r=jdm
Garvan Keeley <garvankeeley@gmail.com> - Thu, 04 Jul 2019 18:34:31 +0000 - rev 540976
Push 11533 by archaeopteryx@coole-files.de at Mon, 08 Jul 2019 18:18:03 +0000
Bug 1529591 - Check Mac system geo permission prior to showing request permission dialog. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D36030
7510c8179dffd0bff95bf117ff877995d9f59849: Bug 1529591 - Check Mac system geo permission prior to showing request permission dialog. r=jdm
Garvan Keeley <garvankeeley@gmail.com> - Wed, 26 Jun 2019 17:42:32 +0000 - rev 539960
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1529591 - Check Mac system geo permission prior to showing request permission dialog. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D36030
ef772f4c6eeccdfaaf2f1fde1a71119a5547b951: Bug 1559494 - disable new_window_null.tentative.html on android under the correct path r=jdm
Andreea Pavel <apavel@mozilla.com> - Tue, 25 Jun 2019 16:11:56 +0000 - rev 539692
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559494 - disable new_window_null.tentative.html on android under the correct path r=jdm Differential Revision: https://phabricator.services.mozilla.com/D35813
3429489885f855dc1658504c7d3b91de52446e3f: Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 08 May 2019 12:44:46 +0000 - rev 531903
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm I thought a bit about how to test it and it's not particularly great. test_css_parse_error_smoketest.html is great to assert that something _gets_ reported, but not that it doesn't :) Differential Revision: https://phabricator.services.mozilla.com/D30201
eee17e1b043502d063b1d609bd98750e91c1bc00: Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 08 May 2019 12:44:46 +0000 - rev 531873
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm I thought a bit about how to test it and it's not particularly great. test_css_parse_error_smoketest.html is great to assert that something _gets_ reported, but not that it doesn't :) Differential Revision: https://phabricator.services.mozilla.com/D30201
ebcb2c853b9ce80debb2a093c3855a16a2f15492: Bug 1538101 - Centralize a bit invalid value error reporting. r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 08 May 2019 12:44:36 +0000 - rev 531872
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538101 - Centralize a bit invalid value error reporting. r=jdm Also, buffer the errors, since we're going to want to look at the whole declaration block to skip reporting them. This shouldn't change behavior, just moves some work to the caller, and defers a bit the work so that it happens only when error reporting is enabled. Differential Revision: https://phabricator.services.mozilla.com/D30200
6c982370080bbaed64a58475ec21db59dfe8327a: Bug 1542593 - Don't access gNeckoChild if not on main thread r=jdm
Kershaw Chang <kershaw@mozilla.com> - Thu, 02 May 2019 17:29:46 +0000 - rev 531278
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542593 - Don't access gNeckoChild if not on main thread r=jdm gNeckoChild is only accessed on main thread, so we should use NS_IsMainThread to see whether we should access gNeckoChild or not. This patch also makes UDPSocketChild::Bind return NS_ERROR_NOT_AVAILABLE when mBackgroundManager is null. Differential Revision: https://phabricator.services.mozilla.com/D29658
f7e1b8a24398e572fe25ed0b40d7db6df0f5cc18: Bug 1546488 - Always use uncached images in test_img_mutations.html; r=jdm
Edgar Chen <echen@mozilla.com> - Mon, 29 Apr 2019 15:05:34 +0000 - rev 530642
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546488 - Always use uncached images in test_img_mutations.html; r=jdm Differential Revision: https://phabricator.services.mozilla.com/D28971
8ca248347c5b8f645d3fb286569d6536dddb42bf: Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r=jdm
Tim D. Smith <tdsmith@mozilla.com> - Tue, 23 Apr 2019 23:34:36 +0000 - rev 530053
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r=jdm The GEOLOCATION_REQUEST_GRANTED probe expires in the next release. We're using this probe to target a survey, as in bug 1499851; new followup work that we're discussing now will also require the probe. Since we've extended collection a few times already, let's turn collection on for the rest of the year. Differential Revision: https://phabricator.services.mozilla.com/D27567
3ab48ce01773af9a130477e46c50e17f9042ea4b: Bug 1535124 part 3. Add MOZ_CAN_RUN_SCRIPT annotations to geolocation code as needed. r=jdm
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 18:05:09 +0000 - rev 524071
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535124 part 3. Add MOZ_CAN_RUN_SCRIPT annotations to geolocation code as needed. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D23521
c18c758f3e31c4a0b4a535fab4006a114c13acaa: Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r=jdm a=pascalc
Tim D. Smith <tdsmith@mozilla.com> - Tue, 23 Apr 2019 23:34:36 +0000 - rev 523371
Push 11166 by apavel@mozilla.com at Fri, 26 Apr 2019 12:48:25 +0000
Bug 1544539 - Collect GEOLOCATION_REQUEST_GRANTED through 2019 r=jdm a=pascalc The GEOLOCATION_REQUEST_GRANTED probe expires in the next release. We're using this probe to target a survey, as in bug 1499851; new followup work that we're discussing now will also require the probe. Since we've extended collection a few times already, let's turn collection on for the rest of the year. Differential Revision: https://phabricator.services.mozilla.com/D27567
cc930a52098bb3b8ebe042e6cf4739f8c470cad5: Bug 1533750 - pack members of PermissionEntry better on 64-bit platforms; r=jdm
Nathan Froyd <froydnj@mozilla.com> - Mon, 11 Mar 2019 18:36:44 +0000 - rev 521441
Push 10866 by nerli@mozilla.com at Tue, 12 Mar 2019 18:59:09 +0000
Bug 1533750 - pack members of PermissionEntry better on 64-bit platforms; r=jdm The current ordering leaves a hole after `mExpireType` due to the need to align a 64-bit `mExpireTime` and another one after `mNonSessionExpireTime` to pad out the structure. We can group members by their type (and initialize them in that order to avoid compiler warnings) to avoid the holes and save a little bit of space. Differential Revision: https://phabricator.services.mozilla.com/D22713
2c74368a599dc58d7319f559efae08a2ba9af214: Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 20:53:13 -0800 - rev 517353
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm
911689ef9f33dbe026bad0c7e3d6ed4f030d6f29: Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 20:53:13 -0800 - rev 516952
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524688: Part 17 - Convert NetworkGeolocationProvider to static registration. r=jdm
84a4caccdc9719660a45831f8529128076cf7821: Bug 1523627 - HTMLSourceElement should keep track of its media list even if there's no image next-sibling yet. r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Feb 2019 15:20:15 +0000 - rev 514319
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523627 - HTMLSourceElement should keep track of its media list even if there's no image next-sibling yet. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D18334
4cfc198196e989cbda49033f03879d7f1b53fae7: Bug 1518045 - Make Servo use a single thread-pool for layout-related tasks per-process. r=jdm
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 17 Dec 2018 23:46:42 +0100 - rev 509772
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518045 - Make Servo use a single thread-pool for layout-related tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks https://github.com/servo/servo/pull/22487, with a few minor fixes to the build that are landing as part of the sync associated to this bug, and an lsan exception tweak to point to the right module since it's moving.
2103b5139f4447305fc32eaf161cdae52e0df8fe: Bug 1513186 - Still use MLS for nightly & early beta r=jdm
Sylvestre Ledru <sledru@mozilla.com> - Tue, 11 Dec 2018 15:00:11 +0000 - rev 507044
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513186 - Still use MLS for nightly & early beta r=jdm Differential Revision: https://phabricator.services.mozilla.com/D14140
6de1ea2f0c0fefd9272907491c42be398fa99e49: Bug 1512161 - Use Windows & Mac system API for geolocation r=jdm
Sylvestre Ledru <sledru@mozilla.com> - Thu, 06 Dec 2018 20:18:13 +0000 - rev 506007
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1512161 - Use Windows & Mac system API for geolocation r=jdm Differential Revision: https://phabricator.services.mozilla.com/D13802
393308a8a29c848b93ecc1c5c1cd5970b26bded6: Bug 1501445 - Remove unused netwerk/wifi/tests/wifi_access_point_test.html. r=jdm
Mark Banner <standard8@mozilla.com> - Fri, 09 Nov 2018 15:29:43 +0000 - rev 501877
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501445 - Remove unused netwerk/wifi/tests/wifi_access_point_test.html. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D11443
0dc37e5676af1f7851a7a86a339d9903fa42e59c: Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 23:42:48 +0000 - rev 498987
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm Depends on D9293. Differential Revision: https://phabricator.services.mozilla.com/D9294
eff50d9238028b1202f7a3d68a7c9da92ddbadcd: Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Tue, 23 Oct 2018 08:34:13 +0000 - rev 498986
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm Ran ESLint's automatic '--fix' option on the above files. Differential Revision: https://phabricator.services.mozilla.com/D9293
501fffbf872d0a320069448010aa0706d3b81409: Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 19:41:58 +0000 - rev 498899
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm Depends on D9293. Differential Revision: https://phabricator.services.mozilla.com/D9294
406ca9722ffaa14caf02923c541942725f835d32: Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 19:41:33 +0000 - rev 498898
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm Ran ESLint's automatic '--fix' option on the above files. Differential Revision: https://phabricator.services.mozilla.com/D9293
b06daed16bea581b8352ef5c17bcba2554bdf750: Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe r=jdm
Tim D. Smith <tdsmith@mozilla.com> - Thu, 27 Sep 2018 18:41:45 +0000 - rev 495448
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe r=jdm Differential Revision: https://phabricator.services.mozilla.com/D7027
4b87a1cf5afe90be21b815f15380cbae184343b8: Bug 1440462 - Send httponly cookie names to content processes. r=jdm
Nicholas Hurley <hurley@mozilla.com> - Wed, 26 Sep 2018 15:39:33 +0000 - rev 494050
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1440462 - Send httponly cookie names to content processes. r=jdm Previously, if script tried to set a cookie that matched a cookie we had received via Set-Cookie that was labeled httponly, script would think that cookie was properly set (even though it wasn't). This ensures that script knows just enough about httponly cookies to prevent this inconsistent view while avoiding leakages of the potentially-sensitive cookie values. Differential Revision: https://phabricator.services.mozilla.com/D5700
7a7b481a00f4bfcc735eaec0d589f029bfa1efa0: Bug 1491047 - Add a telemetry probe for measuring how many browsing sessions have had a private window opened in them; data-review=francois r=jdm
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 25 Sep 2018 04:53:40 +0000 - rev 493709
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491047 - Add a telemetry probe for measuring how many browsing sessions have had a private window opened in them; data-review=francois r=jdm Differential Revision: https://phabricator.services.mozilla.com/D6063
0d3a741ff37cabc53dbc6255dae361af1888c65b: Bug 1442845 - Added firefox will save clipboard in private browsing r=jdm
savvysiddharth <siddharth21805@gmail.com> - Mon, 17 Sep 2018 20:48:28 +0000 - rev 493074
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1442845 - Added firefox will save clipboard in private browsing r=jdm Before this patch, default home page of private sessions didn't inform about saving clipboard text. Now it informs that "copied text" will be saved in private session. Differential Revision: https://phabricator.services.mozilla.com/D5941
8db4f905ae7af3cc59ff0832b4bac21edb810f09: Bug 1488441 - Extend cookie's expiring time from 1s to 3s r=jdm
Kershaw Chang <kershaw@mozilla.com> - Wed, 05 Sep 2018 18:24:51 +0000 - rev 490703
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488441 - Extend cookie's expiring time from 1s to 3s r=jdm The fail log shows that the cookie's expiring time is too short(only 1s). The cookie could be already expired. A simple solution in this patch is just extending the expiring time to 3s. Differential Revision: https://phabricator.services.mozilla.com/D5034
403376728e2a6f023afe6ff2db8e576b062557fa: Bug 1488692 - Remove old ini files when updating wpt metadata r=jdm
James Graham <james@hoppipolla.co.uk> - Wed, 05 Sep 2018 17:21:12 +0000 - rev 490698
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488692 - Remove old ini files when updating wpt metadata r=jdm The easiest way to ensure that old metadata files are removed is simply to check that all the existing metadata files still correspond to a test file, and remove those that do not. This happens before metadata update so that if the metadata update causes a patch to be created, these changes are included in the patch. Differential Revision: https://phabricator.services.mozilla.com/D5015
24f05c63c730fc2f2062bb40cca91b02e07ef17b: Bug 1488784 - Part 2: Remove the XPCOM component registration for nsCookiePermission; r=jdm
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 05 Sep 2018 11:00:15 -0400 - rev 490677
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488784 - Part 2: Remove the XPCOM component registration for nsCookiePermission; r=jdm Differential Revision: https://phabricator.services.mozilla.com/D5038
968d5eb8789a94289f4e58db85fde04be1633d72: Bug 1488784 - Part 1: Rewrite browser_bug578534.js to not use the cookie permission service; r=jdm
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 05 Sep 2018 10:13:48 -0400 - rev 490676
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488784 - Part 1: Rewrite browser_bug578534.js to not use the cookie permission service; r=jdm Differential Revision: https://phabricator.services.mozilla.com/D5037
135174a61d2db7777a05677af493e2ed23b8fe31: Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe. r=jdm, a=pascalc
Tim D. Smith <tdsmith@mozilla.com> - Thu, 27 Sep 2018 18:41:45 +0000 - rev 490181
Push 9937 by ryanvm@gmail.com at Fri, 05 Oct 2018 15:10:08 +0000
Bug 1494496 - Renew GEOLOCATION_REQUEST_GRANTED probe. r=jdm, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D7027
45c93938ae141adb685e154d04d5a4e5935a92fc: Bug 1491047 - Add a telemetry probe for measuring how many browsing sessions have had a private window opened in them; data-review=francois r=jdm a=pascalc
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 25 Sep 2018 04:53:40 +0000 - rev 490067
Push 9896 by ebalazs@mozilla.com at Wed, 26 Sep 2018 13:11:06 +0000
Bug 1491047 - Add a telemetry probe for measuring how many browsing sessions have had a private window opened in them; data-review=francois r=jdm a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D6063
ad14a62f4df6d7a0d4e83490506d495a6369a5f4: Bug 1488441 - Extend cookie's expiring time from 1s to 3s. r=jdm, a=test-only
Kershaw Chang <kershaw@mozilla.com> - Wed, 05 Sep 2018 18:24:51 +0000 - rev 489723
Push 9755 by ryanvm@gmail.com at Thu, 06 Sep 2018 14:22:46 +0000
Bug 1488441 - Extend cookie's expiring time from 1s to 3s. r=jdm, a=test-only The fail log shows that the cookie's expiring time is too short(only 1s). The cookie could be already expired. A simple solution in this patch is just extending the expiring time to 3s. Differential Revision: https://phabricator.services.mozilla.com/D5034
a596012f29db4681255057a35690f251a73b7282: Bug 1357676 - Implement batch eviction r=jdm
Kershaw Chang <kershaw@mozilla.com> - Mon, 03 Sep 2018 14:49:58 +0000 - rev 489605
Push 9740 by archaeopteryx@coole-files.de at Tue, 04 Sep 2018 16:57:14 +0000
Bug 1357676 - Implement batch eviction r=jdm 1. Add network.cookie.QuotaPerHost, which has the default value 150. 2. When the cookies exceed more than 180, evict cookies to 150. 3. The concept of eviction is to sort all cookies by whether the cookie is expired and the cookie's last access time. Then, evict cookies by the given count. 4. Details of evict algorithm: 4.1 Create a priority queue and push all cookies in it. 4.2 Use custom comparator to compare the cookie by expiry and last access. 4.3 Pop 30(180 - 150) cookies from the queue and append them to an output array. Differential Revision: https://phabricator.services.mozilla.com/D3342
513621c77f125e2c2198e7e71d064ebb3f13bb74: Bug 1357676 - Modify failed tests r=jdm
Kershaw Chang <kershaw@mozilla.com> - Thu, 30 Aug 2018 15:41:37 +0000 - rev 489244
Push 9738 by aciure@mozilla.com at Mon, 03 Sep 2018 16:13:51 +0000
Bug 1357676 - Modify failed tests r=jdm We've introduced a new pref network.cookie.quotaPerHost and also a rule that the value of network.cookie.maxPerHost should always be bigger than network.cookie.quotaPerHost. So, before changing the value of network.cookie.maxPerHost, we have to set network.cookie.quotaPerHost first. This patch only sets network.cookie.quotaPerHost equal to network.cookie.maxPerHost - 1 in all failed tests. Differential Revision: https://phabricator.services.mozilla.com/D4346
9cf35b96d52478037f6b0da91a6df7f8476b736e: Bug 1466128 part 2 - Rename AutoCompartment to AutoRealm. r=jdm
Jan de Mooij <jdemooij@mozilla.com> - Tue, 14 Aug 2018 14:25:48 +0200 - rev 487911
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1466128 part 2 - Rename AutoCompartment to AutoRealm. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D3325
d814396399b3dc90603e72b01d4c610228ec299e: Bug 1466128 part 1 - Rename ac.rs to ar.rs. r=jdm
Jan de Mooij <jdemooij@mozilla.com> - Tue, 14 Aug 2018 14:24:22 +0200 - rev 487910
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1466128 part 1 - Rename ac.rs to ar.rs. r=jdm Differential Revision: https://phabricator.services.mozilla.com/D3324
fb1e9182ad38dc4d34162d7bbaff875a3730f549: Bug 1479354 - Null-check this.listener when reporting cached geolocation values r=jdm
Thi Huynh <so61pi.re@gmail.com> - Tue, 31 Jul 2018 20:23:24 +0700 - rev 485994
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1479354 - Null-check this.listener when reporting cached geolocation values r=jdm
bc1c54e5dceab68e5ea448ca69b26ed8d74edb09: Bug 1476053 - Add an option not to store state when running wpt-update, r=jdm
James Graham <james@hoppipolla.co.uk> - Tue, 10 Jul 2018 10:09:43 +0100 - rev 483099
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1476053 - Add an option not to store state when running wpt-update, r=jdm This adds some overhead and can be annoying since it requries explicitly aborting failed jobs. The state storage isn't very useful for just udpating metadata (the typical gecko usecase), but is useful for performing syncs (a typical servo usecase). Therefore add a --no-store-state option and set it by default in the gecko mach frontend. MozReview-Commit-ID: LhEcMkyuRHD
8c9fa6f809a8ccce4cc34f9283ce97aaae7e3e29: Bug 1479354 - Null-check this.listener when reporting cached geolocation values. r=jdm a=lizzard
Thi Huynh <so61pi.re@gmail.com> - Tue, 31 Jul 2018 20:23:24 +0700 - rev 478432
Push 9666 by cbrindusan@mozilla.com at Wed, 15 Aug 2018 10:01:01 +0000
Bug 1479354 - Null-check this.listener when reporting cached geolocation values. r=jdm a=lizzard
c399c7dbe562b4c152c4d3cb770cc68b8cc854a8: Bug 1468030 - Geolocation test can sometimes fail with POSITION_UNAVAILABLE on Android. r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sat, 09 Jun 2018 11:05:49 -0700 - rev 476511
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1468030 - Geolocation test can sometimes fail with POSITION_UNAVAILABLE on Android. r=jdm MozReview-Commit-ID: I7NHyznmCJC
8e8a87c6a518e51b42abf2d12cdfcced8003a4ce: Bug 645325 - Part 7: Always check location results in geolocation tests' success callbacks. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sat, 10 Mar 2018 02:11:09 -0800 - rev 476284
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 7: Always check location results in geolocation tests' success callbacks. r=garvank r=jdm MozReview-Commit-ID: DVQAvxfzJNx
5759d2ab032b348f16f7ced9a8e266d98bc6c3a1: Bug 645325 - Part 6: Disable geolocation request cache when testing different location providers. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sat, 10 Mar 2018 00:23:07 -0800 - rev 476283
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 6: Disable geolocation request cache when testing different location providers. r=garvank r=jdm Disable NetworkGeolocationProvider.js request cache for test cases that change the geo.wifi.uri. The cache does not remember from which location service the cached request came from and we expect different results when we change the provider URL (geo.wifi.uri). MozReview-Commit-ID: 7SbhBOkek4H
d0cd7366b1a23ba8fc9ead34f4fd4281e7383318: Bug 645325 - Part 5: Add stricter type and range checks for JavaScript Coordinates properties. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sat, 10 Mar 2018 01:50:20 -0800 - rev 476282
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 5: Add stricter type and range checks for JavaScript Coordinates properties. r=garvank r=jdm MozReview-Commit-ID: 32XkDhYjIyu
7482eb372d941c9e171fade2c32eb5bc44ef97e1: Bug 645325 - Part 4: Handle null listener when xhr callbacks are called after WifiGeoPositionProvider shutdown. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Fri, 09 Mar 2018 22:20:50 -0800 - rev 476281
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 4: Handle null listener when xhr callbacks are called after WifiGeoPositionProvider shutdown. r=garvank r=jdm I hit this error when testing geolocation with Wi-Fi disabled. There is a race where the WifiGeoPositionProvider gets shut down (settting this.listener to null) but the xhr request is still alive (and the xhr callback later hits the null this.listener). MozReview-Commit-ID: E3jCFM3om5A
14e4da56b11b208bf49521f3490ca51143d562f4: Bug 645325 - Part 3: Remove nsGeoPosition's unused `long long aTimestamp` constructor. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sun, 25 Feb 2018 16:32:16 -0800 - rev 476280
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 3: Remove nsGeoPosition's unused `long long aTimestamp` constructor. r=garvank r=jdm And change nsGeoPosition to store DOMTimeStamp instead of long long because it is a more descriptive type. DOMTimeStamp is a typedef for uint64_t, so we're not losing any precision using DOMTimeStamp instead of long long. MozReview-Commit-ID: hjXnw959yC
814c7e1c16e505a87ee1c27b814a00839dba08c8: Bug 645325 - Part 2: Remove the two-second startup delay for the MLS fallback provider on Windows and macOS. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Wed, 28 Feb 2018 23:59:03 -0800 - rev 476279
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 2: Remove the two-second startup delay for the MLS fallback provider on Windows and macOS. r=garvank r=jdm The Windows and macOS location providers used to start the MLS provider (with a two-second delay) and then call the operating system's location provider, letting them race. Currently, however, we only start the MLS fallback provider after the system provider returns an error, so the two-second startup delay is just wasted time. I left the starup delay option in MLSFallback because the Linux gpsd provider still uses it to race MLS with the system's GPS provider. MozReview-Commit-ID: 3ZFeF1g6PoG
de5472e604faa2f69196f131af198366c2b38e8f: Bug 645325 - Part 1: Use NaN to indicate unset optional coordinate values returned from the location providers. r=garvank r=jdm
Chris Peterson <cpeterson@mozilla.com> - Sun, 25 Feb 2018 23:35:16 -0800 - rev 476278
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 645325 - Part 1: Use NaN to indicate unset optional coordinate values returned from the location providers. r=garvank r=jdm nsGeoPositionCoords will convert NaNs returned from the location providers to null properties of the JavaScript Coordinates object. MozReview-Commit-ID: Cmuf2aO0ClD
73d26c2c475fbd75af8502b618281d3b45e209bc: Bug 1456742 - Make sure to call UpdatePrivateBrowsing() in http channel to properly set private browsing state of the channel when no load group or callbacks have been set on it before AsyncOpen. r=jdm
Honza Bambas <honzab.moz@firemni.cz> - Fri, 11 May 2018 06:11:00 -0400 - rev 474525
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456742 - Make sure to call UpdatePrivateBrowsing() in http channel to properly set private browsing state of the channel when no load group or callbacks have been set on it before AsyncOpen. r=jdm