searching for reviewer(janv)
55da5150365dc92235e56b3c9717f432abc68270: Bug 1546752 - Stop creating, writing, and reading the .metadata file in QuotaManager except the upgrades; r=janv, a=jcristau
Tom Tung <shes050117@gmail.com> - Mon, 20 May 2019 14:13:27 +0000 - rev 533813
Push 11435 by jcristau@mozilla.com at Wed, 12 Jun 2019 14:26:08 +0000
Bug 1546752 - Stop creating, writing, and reading the .metadata file in QuotaManager except the upgrades; r=janv, a=jcristau The main goal of this issue is to reduce IO during the storage initialization and stop creating .metadata file since we already have .metadata-v2 file to track the information for the origin directory. Therefore, this patch only stop create, write, and read the .metadata file. And, leaving the work for removing it to the next minor upgrade. Differential Revision: https://phabricator.services.mozilla.com/D28824
eacd2f22961f47f00d357814c55d8e707bf5598b: Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv a=jcristau
Eden Chuang <echuang@mozilla.com> - Fri, 07 Jun 2019 08:18:37 +0200 - rev 533697
Push 11402 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 19:13:00 +0000
Bug 1516333 - Part 2: Add LS unit test for uri encoding edge cases; r=janv a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D33617
d13ae743074c0570c499c217c1cf9262f74a28c4: Bug 1516333 - Part 1: Move group and origin re-escaping from QuotaManager::GetQuotaObject to GetQuotaObjectFromNameAndParameters in TelemetryVFS.cpp; r=janv,asuth a=jcristau
Eden Chuang <echuang@mozilla.com> - Fri, 07 Jun 2019 08:04:57 +0200 - rev 533696
Push 11402 by archaeopteryx@coole-files.de at Fri, 07 Jun 2019 19:13:00 +0000
Bug 1516333 - Part 1: Move group and origin re-escaping from QuotaManager::GetQuotaObject to GetQuotaObjectFromNameAndParameters in TelemetryVFS.cpp; r=janv,asuth a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D33769
695621ee868dc607e49f848c72be87fe7a14c909: Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 29 Apr 2019 10:49:58 +0000 - rev 533185
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1514600 - P1 - Notify LS to cleanup the gUsages while storage initialization fails; r=janv Differential Revision: https://phabricator.services.mozilla.com/D27502
9437ce7f56f17a5f38e3c64f165005845a50fc69: Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh
Tom Tung <shes050117@gmail.com> - Tue, 14 May 2019 16:49:03 +0000 - rev 532627
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1535298 - Capture and ignore the exception for not having a host from a principal URI; r=janv,johannh Protocols, likes about:, moz-extension, ... etc, don't have a host. Thus, an exception will be returned if they are accessed. To avoid from that, this patch catches this bug a try-catch. Differential Revision: https://phabricator.services.mozilla.com/D29821
158510da415deb7ae973e79f1658b305d75ac96b: Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv
Tom Tung <shes050117@gmail.com> - Tue, 23 Apr 2019 18:05:41 +0000 - rev 529419
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv Differential Revision: https://phabricator.services.mozilla.com/D28520
de1c51fce80e5bee60661bff92e2006970ecd760: Bug 1539538 - Introduce UnsafePtr r=froydnj,janv
Yaron Tausky <ytausky@mozilla.com> - Tue, 09 Apr 2019 14:41:57 +0000 - rev 527393
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539538 - Introduce UnsafePtr r=froydnj,janv This commit adds a smart pointer class that verifies that no dangling pointers remain after the pointee went out of scope. This verification is opt-in and can be controlled both statically and dynamically by the pointee. Differential Revision: https://phabricator.services.mozilla.com/D25200
02b7484f316b1936479d4e28789c9c6dbf3fad9c: Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv
violet <violet.bugreport@gmail.com> - Fri, 22 Mar 2019 14:01:31 +0000 - rev 524626
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1507229 - Argument sanity check at CreateMutableFile() to avoid assertion failure r=janv CreateMutableFile() doesn't allow empty name, we should check it before further processing to avoid assertion failure. Differential Revision: https://phabricator.services.mozilla.com/D23999
7bf89a70ca2059034470bcd61508c8c229621d1d: Bug 1529301 - P0 - Change some code to align the clang format; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 21 Mar 2019 08:53:48 +0000 - rev 524438
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1529301 - P0 - Change some code to align the clang format; r=janv Differential Revision: https://phabricator.services.mozilla.com/D24226
74af12527bdc09354ae688de5cc6cfa4f191f32d: Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv a=pascalc
Tom Tung <shes050117@gmail.com> - Tue, 23 Apr 2019 18:05:41 +0000 - rev 523370
Push 11166 by apavel@mozilla.com at Fri, 26 Apr 2019 12:48:25 +0000
Bug 1481164 - Dispatch to the Background thread even when the Connection is a nullptr in IdleConnectionRunnable::Run(); r=janv a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D28520
7a0c015fcc50407349ec27b25ad0c002edca0f60: Bug 1535619 - add meta information to create bugs for files in dom/localstorage/ in 'Core :: DOM: Web Storage' r=janv
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 15 Mar 2019 14:01:58 +0000 - rev 522048
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1535619 - add meta information to create bugs for files in dom/localstorage/ in 'Core :: DOM: Web Storage' r=janv Differential Revision: https://phabricator.services.mozilla.com/D23670
29e28daebae57e16db9d32017e7f34eb968d02fb: Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj
Yaron Tausky <ytausky@mozilla.com> - Wed, 06 Mar 2019 16:26:07 +0000 - rev 520508
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj Differential Revision: https://phabricator.services.mozilla.com/D21241
44d83d32e254ccdb9441b8c0388262e436918da5: Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj
Yaron Tausky <ytausky@mozilla.com> - Wed, 06 Mar 2019 13:53:16 +0000 - rev 520489
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516277 - Add local execution mode to nsThread r=janv,froydnj Differential Revision: https://phabricator.services.mozilla.com/D21241
4389ed44ce098d81136244e70a941d812ea73221: Bug 1515605 - Enable ESLint for dom/localstorage (manual changes). r=janv
Mark Banner <standard8@mozilla.com> - Fri, 21 Dec 2018 10:13:00 +0000 - rev 508759
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515605 - Enable ESLint for dom/localstorage (manual changes). r=janv Differential Revision: https://phabricator.services.mozilla.com/D15073
a535962417c0d37bd82387093238f6457109e279: Bug 1515605 - Enable ESLint for dom/localstorage (automatic changes). r=janv
Mark Banner <standard8@mozilla.com> - Fri, 21 Dec 2018 10:12:45 +0000 - rev 508758
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515605 - Enable ESLint for dom/localstorage (automatic changes). r=janv Differential Revision: https://phabricator.services.mozilla.com/D15072
fd8d109b37c1cc5642971fc254bfa60153f5d98d: Bug 1502871 - Get RefPtr to transaction before using it; r=janv
Yaron Tausky <ytausky@mozilla.com> - Thu, 20 Dec 2018 13:39:46 +0000 - rev 508623
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1502871 - Get RefPtr to transaction before using it; r=janv Avoid use-after-free by getting a RefPtr to a transaction before calling content code that could cause its deallocation. Differential Revision: https://phabricator.services.mozilla.com/D14427
5ae197bcb7f7d87dafcb6d90045dc8b01e4cd282: Bug 1502871 - Get RefPtr to transaction before using it. r=janv, a=RyanVM
Yaron Tausky <ytausky@mozilla.com> - Thu, 20 Dec 2018 13:39:46 +0000 - rev 506387
Push 10393 by ryanvm@gmail.com at Wed, 26 Dec 2018 21:58:42 +0000
Bug 1502871 - Get RefPtr to transaction before using it. r=janv, a=RyanVM Avoid use-after-free by getting a RefPtr to a transaction before calling content code that could cause its deallocation. Differential Revision: https://phabricator.services.mozilla.com/D14427
fd65b14ab7e8aba272dd49f84af229b3ecef6e0a: Bug 1286798 - Part 53: Review code comments; r=janv,mrbkap,mccr8
Andrew Sutherland <asutherland@asutherland.org> - Mon, 05 Nov 2018 14:04:39 -0500 - rev 505271
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1286798 - Part 53: Review code comments; r=janv,mrbkap,mccr8
6214aafc061f09377c40eca490cc12621169c892: Bug 1286798 - Part 35: Implement database shadowing; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:49:07 +0100 - rev 505253
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1286798 - Part 35: Implement database shadowing; r=asuth,janv This adds synchronization to the global database used by previous local storage implementation. This patch was enhanced by asuth to bind attached database path. Places has shown that argument binding is necessary. (Profiles may include usernames in their path which can have cool emoji and such.)
2620df4a91da32a75123274b2f603e45e78ca3df: Bug 1286798 - Part 26: Implement a lazy data migration from old webappsstore.sqlite; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:48:38 +0100 - rev 505244
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1286798 - Part 26: Implement a lazy data migration from old webappsstore.sqlite; r=asuth,janv This patch was enhanced by asuth to bind attached database path. Places has shown that argument binding is necessary. (Profiles may include usernames in their path which can have cool emoji and such.)
75c28b78f8ee02018ccaec9c2f4035d46182d10e: Bug 1286798 - Part 10: Support for storage events; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:47:45 +0100 - rev 505228
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1286798 - Part 10: Support for storage events; r=asuth,janv Storage events are fired either directly after getting response from synchronous SetItem call or through observers. When a new onstorage event listener is added, we sycnhronously register an observer in the parent process. There's always only one observer actor per content process. PBackgroundLSDatabase is now managed by a new PBackgroundLSObject protocol. PBackgroundLSObject is needed to eliminate the need to pass the principal info and document URI everytime a write operation occurs. Preparation of an observer shares some states with preparation of a datastore, so common stuff now lives in LSRequestBase and preparation of a datastore now implements a nested state machine. This patch was enhanced by asuth to drop observers only when the last storage listener is removed. EventListenerRemoved is invoked on any removal, not just the final removal, so we need to make sure it's the final removal before dropping observer.
0b0a03cf7b64cc9cc6eff36c3ae7f56f010e944c: Bug 1286798 - Part 6: Fix a dead lock in the single process case; r=asuth,janv
Jan Varga <jan.varga@gmail.com> - Thu, 29 Nov 2018 21:47:30 +0100 - rev 505224
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1286798 - Part 6: Fix a dead lock in the single process case; r=asuth,janv Expose the nested main event target, so it can be used in the single process case by the parent side to process runnables which need to run on the main thread. After this change we don't have use hacks like getting profile directory path on the child side and sending it to the parent. The parent side can now do it freely even in the single process case. This patch was enhanced by asuth to not tunnel the nested main event target through IPC.
2317749c5abfb7eab139a2545d2fa5362d2309f0: Bug 1496801 - Set persist mode on ExtensionStorageIDB for extensions with the unlimitedStorage permission. r=mixedpuppy,janv
Luca Greco <lgreco@mozilla.com> - Sat, 17 Nov 2018 20:07:28 +0000 - rev 504312
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1496801 - Set persist mode on ExtensionStorageIDB for extensions with the unlimitedStorage permission. r=mixedpuppy,janv Differential Revision: https://phabricator.services.mozilla.com/D7915
78f4415212432c196010505418aaa0ffdeeb7677: Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 25 Oct 2018 16:34:56 +0200 - rev 499807
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv An issue for missing the "response_padding_size" column in cache.sqlite was reported in bug 1425146 comment 39. This test reproduces it and is mainly to ensure that a Cache directory which lacks a directory padding file and contains an old version of cache.sqlite can still be initialized successfully.
52646a13f5de473e342c6c1ff2719137fcd43ac4: Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 07 Sep 2018 10:28:30 +0200 - rev 499806
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv Bug 1290481 introduces the padding mechanism, but there was a corner case which weren't handled correctly. It created a chance to access cache database before acutally checking the database version and schema upgrade. If the schema of cache.sqlite is too old and the padding file disappear, it breaks origins initialization. This patch ensure the schema is updated to the newest before accessing it.
c768d21501f987b2bef5293994c5b772b48991b0: Bug 1395102 - P4 - Reuse the code for MaybeUpgradeClients() in the upgrade helpers; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 19 Oct 2018 11:36:08 +0200 - rev 498773
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1395102 - P4 - Reuse the code for MaybeUpgradeClients() in the upgrade helpers; r=janv This patch moves MaybeUpgradeClients to RepositoryOperationBase class from UpgradeStorageFrom1_0To2_0Helper and UpgradeStorageFrom2_0To2_1Helper so that lines of code can be reused.
47335300b3377e6a3c696fb9392d30d567a2bac6: Bug 1395102 - P3 - Reuse the code for QuotaManager::UpgradeStorageFromxxToxx(); r=janv
Tom Tung <shes050117@gmail.com> - Wed, 17 Oct 2018 15:37:16 +0200 - rev 498772
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1395102 - P3 - Reuse the code for QuotaManager::UpgradeStorageFromxxToxx(); r=janv This patch adds a new function QM::UpgradeStorage() to reuse lines of code in QM:UpgradeStorageFrom0_0To1_0(), QM:UpgradeStorageFrom1_0To2_0(), and QM:UpgradeStorageFrom2_0To2_1().
a0de0c0ec6b01e9d74cd2bcfe6333e1cbaf566dc: Bug 1395102 - P2 - Rename the intermediate class in P1 to RepositoryOperationBase; r=janv
Tom Tung <shes050117@gmail.com> - Wed, 17 Oct 2018 14:29:55 +0200 - rev 498771
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1395102 - P2 - Rename the intermediate class in P1 to RepositoryOperationBase; r=janv To do this, it also rename the StorageDirectoryHelper to StorageOperationBase to align with classes naming. Bsides, this patch renames RepositoryOperationBase::DoUpgrade() to RepositoryOperationBase::ProcessRepository().
0d01e0a4de9550efec739bfe912b0cdb50057941: Bug 1395102 - P1 - Introduce a intermediate helper class to reuse code for upgrading origin directories; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 18 Oct 2018 11:12:28 +0200 - rev 498770
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1395102 - P1 - Introduce a intermediate helper class to reuse code for upgrading origin directories; r=janv This patch mainly create a new helper class and it inherits from StorageDirectoraryHelper to reuse the code in CreateOrUpgradeDirectoryMetadataHelper::CreateOrUpgradeMetadataFiles(), UpgradeStorageFrom0_0To1_0Helper::DoUpgrade(), UpgradeStorageFrom1_0To2_0Helper::DoUpgrade(), UpgradeStorageFrom2_0To2_1Helper::DoUpgrade().
7a1bcf3d6977e2944c6fd0c80b713e0add581848: Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv a=jcristau
Tom Tung <shes050117@gmail.com> - Thu, 25 Oct 2018 16:34:56 +0200 - rev 498394
Push 10138 by ebalazs@mozilla.com at Thu, 08 Nov 2018 12:27:01 +0000
Bug 1425146 - P2 - Add a test reproducing the reported issue to verify that a Cache directory without a padding file and with an old version of the database doesn't break the storage initialization; r=janv a=jcristau An issue for missing the "response_padding_size" column in cache.sqlite was reported in bug 1425146 comment 39. This test reproduces it and is mainly to ensure that a Cache directory which lacks a directory padding file and contains an old version of cache.sqlite can still be initialized successfully.
b82e4143ecdbf2d35811fc952738c2d7ab772f7f: Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv a=jcristau
Tom Tung <shes050117@gmail.com> - Fri, 07 Sep 2018 10:28:30 +0200 - rev 498393
Push 10138 by ebalazs@mozilla.com at Thu, 08 Nov 2018 12:27:01 +0000
Bug 1425146 - P1 - Ensure the schema for the cache.sqlite is up to date beforing accessing it; r=janv a=jcristau Bug 1290481 introduces the padding mechanism, but there was a corner case which weren't handled correctly. It created a chance to access cache database before acutally checking the database version and schema upgrade. If the schema of cache.sqlite is too old and the padding file disappear, it breaks origins initialization. This patch ensure the schema is updated to the newest before accessing it.
daed617054ce114772d208c79bbe8cd8d858d310: Bug 1481716 - Add a telemetry probe to track how long does the QM take for initializing repositories; r=janv, data-review=francois
Tom Tung <shes050117@gmail.com> - Mon, 13 Aug 2018 10:34:10 +0200 - rev 497210
Push 9996 by archaeopteryx@coole-files.de at Thu, 18 Oct 2018 18:37:15 +0000
Bug 1481716 - Add a telemetry probe to track how long does the QM take for initializing repositories; r=janv, data-review=francois This patch adds a telemetry probe to track the time for initializing both the default and the temporary repositories.
6de689423ff668027dd71205bfa21f3dfa3fb05c: Bug 1389380 - Add a test for storage pressure event; r=janv
Tom Tung <shes050117@gmail.com> - Thu, 04 Oct 2018 10:32:41 +0200 - rev 495432
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1389380 - Add a test for storage pressure event; r=janv A storage pressure event should be fired when the current usage is greater than the global limit. Currently, the QuotaManger checks the usage and the limit in two different cases, and this test verfiies both cases do fire a storage pressure event with a correct value of usage. The first one is that a quota client is asking for writting a new storage into the disk, but it will make the currnet usage become greater than the global limit. The other one is that the calculating limit is less than the current usage while initilaizing the temporary storage.
4f495d81e201cd809515bdd76bab7292fa76f5df: Bug 1389378 - A test for verifying persisted origins bounded by the global limit; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 17 Sep 2018 11:21:41 +0200 - rev 495426
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1389378 - A test for verifying persisted origins bounded by the global limit; r=janv Bug 1372116 reported that PersistOp() didn't create an originInfo object for the persisting origin if the temporary storage had been initialized. The test verifies that no matter the temporary storage was initialized or not the PersistOp should hanlde the originInfo object properly so that the persisting origin will be bounded by the global limit.
75a2cc1386416e4d20da45bf63027540f73c1c04: Bug 1495687 - Introduce initTemporaryStorage to nsIQuotaManagerService for testing; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 02 Oct 2018 16:08:43 +0200 - rev 495425
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1495687 - Introduce initTemporaryStorage to nsIQuotaManagerService for testing; r=janv
3ed04fa44d07ed2a7c8734f24e0d198c6002b743: Bug 1389390 - Add a test to verify a persisted origin won't be evicted; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 25 Sep 2018 17:14:53 +0200 - rev 494718
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1389390 - Add a test to verify a persisted origin won't be evicted; r=janv Bug 1298392 introduced persist() to QuotaManager. This patch intends to verify that normally the oldest origin will be evicted if the global limit is reached, but if the oldest origin is persisted, then it won't be evicted.
4ffdf21d17fa654eab1398d6579304a52d456755: Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future; r=janv
Tom Tung <shes050117@gmail.com> - Tue, 11 Sep 2018 12:39:14 +0200 - rev 491921
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future; r=janv CheckedInt propagates the mIsValid in each add operation so that it avoids having a bunch of code for the overflow check in each add operation. Furthermore, it avoids mismatching parameters between the computing result and the additional overflow check. This patch uses it based on advantages described above.
3206c9b8db975f6b30bc4ee1a70402ccfdc68e36: Bug 1488401 - Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 13 Sep 2018 06:40:51 +0000 - rev 491859
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488401 - Remove the remnants of the DiskSpaceWatcher r=asuth,janv,smaug Differential Revision: https://phabricator.services.mozilla.com/D4933
e565eaca9472d11d9ce4f749c218c3ae167a0ccf: Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future. r=janv, a=pascalc
Tom Tung <shes050117@gmail.com> - Tue, 11 Sep 2018 12:39:14 +0200 - rev 489885
Push 9816 by ryanvm@gmail.com at Mon, 17 Sep 2018 13:22:22 +0000
Bug 1379411 - Apply CheckedInt to infoLength for preventing it from overflowing in the future. r=janv, a=pascalc CheckedInt propagates the mIsValid in each add operation so that it avoids having a bunch of code for the overflow check in each add operation. Furthermore, it avoids mismatching parameters between the computing result and the additional overflow check. This patch uses it based on advantages described above.
0ae703cca0f392b3c1cdd1a98f019e50ff7f86a7: Bug 1485971 - Followup for enabling test on Beta and Release for bug 1482812; r=janv
Tom Tung <shes050117@gmail.com> - Fri, 24 Aug 2018 15:16:26 +0200 - rev 488593
Push 9733 by dluca@mozilla.com at Tue, 28 Aug 2018 21:01:00 +0000
Bug 1485971 - Followup for enabling test on Beta and Release for bug 1482812; r=janv Bug 1482812 enabled the check for whether origin is valid in both Beta and Release channels, but it didn't enable the test under the quota folder. That test verified the check does work while executing storage.persist() if the origin hasn't been initialized yet. Thus, this patch removes the pref to verify this check does work for storage.persist() on Beta and the Release channels.
c2a1d27fb7a9777e1f08719f0c59e104eb325d53: Bug 1483042 - Remove more ~RefPtr that fire after a Rooted has been unwrapped for a return value, r=janv
Steve Fink <sfink@mozilla.com> - Mon, 13 Aug 2018 14:51:20 -0700 - rev 488169
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483042 - Remove more ~RefPtr that fire after a Rooted has been unwrapped for a return value, r=janv
dcbb7762dc2fa3afbbf969016c29b125d97b52f2: Bug 1484615 - Followup comment fix for bug 1409641; r=janv
Tom Tung <shes050117@gmail.com> - Mon, 20 Aug 2018 11:46:24 +0200 - rev 487685
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1484615 - Followup comment fix for bug 1409641; r=janv This patch add comments to IndexedDBHelper.jsm to clarify how txn.result is set. The comments should clear up any confusion caused by previous commit message (fix for bug 1409641).
cf257868689ac19d05c88e0b2607b180373cfcb3: Bug 1482812: Patch for turning on the origin parser check on both beta and release. r=janv
Tom Tung <shes050117@gmail.com> - Wed, 15 Aug 2018 16:59:26 +0200 - rev 487182
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1482812: Patch for turning on the origin parser check on both beta and release. r=janv This patch, basically, turns the check. To avoid checking the same direcotries multiple time, it creates a member hashtable |mValidOrigins| in QuotaManager and use it in EnsureOriginDirectory(). Since it needs to use the member hashtable, this patch also moves EnsureOriginDirectory() to become a QuotaManager member function.
3f0e23762df5816b8a28819865679e960c2dbfac: Bug 1409641: Get the result only when it's defined in IDBtranscation. r=janv
Tom Tung <shes050117@gmail.com> - Thu, 16 Aug 2018 16:09:40 +0200 - rev 487181
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1409641: Get the result only when it's defined in IDBtranscation. r=janv
1cee27f6b2336dfeaaeaf45e660f1614118cf7e8: Bug 1357636 - Improve IndexedDB error message on deleting an undefined object; r=janv
Diego Pino Garcia <dpino@igalia.com> - Wed, 15 Aug 2018 15:35:58 +0200 - rev 486796
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1357636 - Improve IndexedDB error message on deleting an undefined object; r=janv Patch authored by Diego Pino Garcia.
ea2e159b63a948d9fe9b8f828fe9c272b10b4b20: Bug 1483493 - Use 'Core :: DOM: Web Storage' in meta data for related files to create bugs in that component. r=janv
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 15 Aug 2018 09:22:45 +0000 - rev 486717
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1483493 - Use 'Core :: DOM: Web Storage' in meta data for related files to create bugs in that component. r=janv Differential Revision: https://phabricator.services.mozilla.com/D3401
21cbd16b3b271dcea0a2899629191f84e5ad4278: Bug 1481753: Remove redundant lines for flipping the flag and checking the storage limits. r=janv
Tom Tung <shes050117@gmail.com> - Wed, 08 Aug 2018 15:43:46 +0200 - rev 485847
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1481753: Remove redundant lines for flipping the flag and checking the storage limits. r=janv Tags: #secure-revision Differential Revision: https://phabricator.services.mozilla.com/D2937
b0f4e67b3ae1bd2e084e12a6dd6cd816636c3a8c: Bug 1469395 - Remove support for storing WebAssembly.Modules in IDB (r=lth,janv,Ms2ger)
Luke Wagner <luke@mozilla.com> - Wed, 08 Aug 2018 12:13:16 -0500 - rev 485804
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1469395 - Remove support for storing WebAssembly.Modules in IDB (r=lth,janv,Ms2ger)
6910c42470727a88aa07dffa0376febc3e0f7fff: Bug 1478895 - Add an explanatory comment to HashName(). r=janv
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 27 Jul 2018 18:26:37 +1000 - rev 483831
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478895 - Add an explanatory comment to HashName(). r=janv DONTBUILD because it's a comment-only change.
7f73954c5633e0b9ddf209cd4f92e710f8bed63c: Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r=janv
Robert Bartlensky <rbartlensky@mozilla.com> - Thu, 19 Jul 2018 13:36:33 +0100 - rev 482471
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1476603: Fix DEAD_STORE error in dom/indexedDB/ActorsParent.cpp. r=janv MozReview-Commit-ID: B6oqb3tp3ND