searching for reviewer(iain)
f33438610827fd864a238a34b617772a2837b00f: Bug 1676266 - Add rateMyCacheIR to testcase ignorelist. r=iain
Caroline Cullen <ccullen@mozilla.com> - Tue, 10 Nov 2020 00:00:56 +0000 - rev 622769
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676266 - Add rateMyCacheIR to testcase ignorelist. r=iain Differential Revision: https://phabricator.services.mozilla.com/D96474
8cdc2037b4b092157f1d04700bb09b00b19bbca6: Bug 1675905 - Simplify IonBuilder::createThisScripted. r=jandem,iain a=tjr
Ted Campbell <tcampbell@mozilla.com> - Sat, 07 Nov 2020 05:36:31 +0000 - rev 622624
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675905 - Simplify IonBuilder::createThisScripted. r=jandem,iain a=tjr Differential Revision: https://phabricator.services.mozilla.com/D96309
d818a9726c698c464396d16f43fc73027a78ee4e: Bug 1640737 part 2 - Add a test, remove now unused code. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 06:26:23 +0000 - rev 621115
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1640737 part 2 - Add a test, remove now unused code. r=iain Depends on D77008 Differential Revision: https://phabricator.services.mozilla.com/D77009
3627ad8d7aa7e5d7152262d65e683488ebf55461: Bug 1669914 - Return false if recursive mode DisassembleScript shell function cannot get or create a script. r=iain
Caroline Cullen <ccullen@mozilla.com> - Fri, 23 Oct 2020 17:14:53 +0000 - rev 620537
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1669914 - Return false if recursive mode DisassembleScript shell function cannot get or create a script. r=iain Differential Revision: https://phabricator.services.mozilla.com/D94068
c96fb1d8ad9346a1fa99868dc79dff8eb87a5a3f: Bug 1669914 - Return false if recursive mode DisassembleScript shell function cannot get or create a script. r=iain
Caroline Cullen <ccullen@mozilla.com> - Thu, 22 Oct 2020 18:16:37 +0000 - rev 620386
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1669914 - Return false if recursive mode DisassembleScript shell function cannot get or create a script. r=iain Differential Revision: https://phabricator.services.mozilla.com/D94068
0c34dcab98807ca775304955c39230962eb8bc5c: Bug 1671812 - Don't specialize OSR phis as float32. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Mon, 19 Oct 2020 16:53:53 +0000 - rev 620106
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671812 - Don't specialize OSR phis as float32. r=iain In GuessPhiType we skip the phi operand that has the incoming OSR value, but we also need to ensure we don't specialize the phi as float32 or we risk loss of precision. The float32 optimization is pretty complicated. Hopefully this can be factored out and simplified the coming months (bug 1655773). Differential Revision: https://phabricator.services.mozilla.com/D93927
f1da4198e696bbeb7c96e22ce1427655a173b243: Bug 1675905 - Simplify IonBuilder::createThisScripted. r=jandem,iain a=RyanVM DEVEDITION_83_0b10_BUILD1 DEVEDITION_83_0b10_RELEASE FIREFOX_83_0b10_BUILD1 FIREFOX_83_0b10_RELEASE
Ted Campbell <tcampbell@mozilla.com> - Sat, 07 Nov 2020 05:36:31 +0000 - rev 619611
Push 14619 by ryanvm@gmail.com at Sun, 08 Nov 2020 17:47:01 +0000
Bug 1675905 - Simplify IonBuilder::createThisScripted. r=jandem,iain a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D96309
4c4fae92b0cf9a64215c7f6a0565ab65064dd157: Bug 1671812 - Don't specialize OSR phis as float32. r=iain, a=pascalc
Jan de Mooij <jdemooij@mozilla.com> - Mon, 19 Oct 2020 16:53:53 +0000 - rev 619224
Push 14356 by jcristau@mozilla.com at Thu, 22 Oct 2020 17:16:13 +0000
Bug 1671812 - Don't specialize OSR phis as float32. r=iain, a=pascalc In GuessPhiType we skip the phi operand that has the incoming OSR value, but we also need to ensure we don't specialize the phi as float32 or we risk loss of precision. The float32 optimization is pretty complicated. Hopefully this can be factored out and simplified the coming months (bug 1655773). Differential Revision: https://phabricator.services.mozilla.com/D93927
000f531b8ba8a1536e5fcd0ff70f5e62fec389a0: Bug 1668532 part 2 - Assert resumeAfter is only used with non-movable instructions. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 08 Oct 2020 00:47:56 +0000 - rev 618722
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1668532 part 2 - Assert resumeAfter is only used with non-movable instructions. r=iain This caught some isEffectful instructions that were marked isMovable. That doesn't really make sense, but this also doesn't fix any actual issues because optimizations check both. Depends on D92579 Differential Revision: https://phabricator.services.mozilla.com/D92580
94aa4cd72aed19410ec3cfb69bdc9c4de0543d72: Bug 1668532 part 1 - Port MIonToWasmCall optimization to Warp. r=bbouvier,iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Oct 2020 14:33:42 +0000 - rev 618721
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1668532 part 1 - Port MIonToWasmCall optimization to Warp. r=bbouvier,iain Mostly based on IonBuilder::inlineWasmCall. Because there's a post-conversion instruction for i64 => BigInt, we unfortunately have to relax some assertions around resume points. Differential Revision: https://phabricator.services.mozilla.com/D92579
6c44f42ee22d5f2299cf1da0a24ebb3ca10656f3: Bug 1669597 - Use word-alignment to avoid misaligning the stack pointer. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Oct 2020 09:39:00 +0000 - rev 618640
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669597 - Use word-alignment to avoid misaligning the stack pointer. r=iain Also fixes the callVM trampoline on x64. This now matches the ARM64 and MIPS64 implementations. Differential Revision: https://phabricator.services.mozilla.com/D93075
0cec6fdfd6760c7ee05cad8bd7f66509c01192b5: Bug 1661256 part 31 - Convert BigInt's callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Fri, 09 Oct 2020 17:39:03 +0000 - rev 618482
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 31 - Convert BigInt's callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91811
50d9ea94a142eaf9547085adcff387a373fc42bd: Bug 1661256 part 25 - Convert Allocate* and CreateMathResult* callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Fri, 09 Oct 2020 17:38:48 +0000 - rev 618476
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 25 - Convert Allocate* and CreateMathResult* callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91805
addad36eb103803cae31f952e3c87ff24dedabb8: Bug 1670265 - Part 2: Remove no longer used CodepointsWithSameUpperCase class. r=iain
André Bargull <andre.bargull@gmail.com> - Sat, 10 Oct 2020 09:48:59 +0000 - rev 618375
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1670265 - Part 2: Remove no longer used CodepointsWithSameUpperCase class. r=iain Removes the `CodepointsWithSameUpperCase` class and the generator code in "make_unicode.py". Depends on D93089 Differential Revision: https://phabricator.services.mozilla.com/D93090
2956214a5ca776b6b218fe5209a7fb0421200037: Bug 1670265 - Part 1: Remove reverse case folding info. r=iain
André Bargull <andre.bargull@gmail.com> - Sat, 10 Oct 2020 09:48:29 +0000 - rev 618374
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1670265 - Part 1: Remove reverse case folding info. r=iain Removes the `ReverseFoldCase{1,2,3}()` functions and the accompanying `FoldingInfo::reverse{1,2,3}` fields. And updates the Unicode script to no longer emit these fields. `folding_shift` had to be changed from 5 to 6, because the tuple stored in `folding_cache` is now only holding the `folding` code unit. In `process_case_folding()` we no longer need to assert that we have at maximum three reverse case foldings, so we can remove the `len(rev_folding) <= 3` assertion, too. Drive-by changes: - Add a small comment to `read_case_folding` describing the line format. - Also assert we only handle common and simple case foldings and restrict the return value of `read_case_folding` to only return the `(code, mapping)` tuple. Differential Revision: https://phabricator.services.mozilla.com/D93089
6c8257875230d510f3ad7577cf255cfad706e9a3: Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Fri, 09 Oct 2020 17:38:24 +0000 - rev 618321
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91799
61f34fc7500538872225eeb8929f4a8e3760b2e9: Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 18:46:53 +0000 - rev 618224
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91799
b82f8c69c9e43d03010c899423f7d1283febc736: Bug 1669918 - Pass initializer_list directly to the transpiler. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 08 Oct 2020 15:51:38 +0000 - rev 618162
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669918 - Pass initializer_list directly to the transpiler. r=iain This way we don't have to copy it to a temporary Vector. Differential Revision: https://phabricator.services.mozilla.com/D92881
fc3e86aa0da0736eb8e9028626109f006025fd39: Bug 1669913 - Use maybeJitScript() to check for a JitScript to avoid failure in cases where a JitScript is not present. r=iain
Caroline Cullen <ccullen@mozilla.com> - Thu, 08 Oct 2020 17:55:15 +0000 - rev 618095
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669913 - Use maybeJitScript() to check for a JitScript to avoid failure in cases where a JitScript is not present. r=iain Differential Revision: https://phabricator.services.mozilla.com/D92980
24fb1a1114797eaedb9186ea898e98d22b0a8110: Bug 1661256 part 8 - Convert js::RegExp*OptimizableRaw callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 18:46:08 +0000 - rev 618057
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 8 - Convert js::RegExp*OptimizableRaw callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91788
b369ea98bd7f654a25bc26a81c550907a9dae1a5: Bug 1661256 part 4 - Add irregexp callWithABI function calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 18:46:44 +0000 - rev 618053
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 4 - Add irregexp callWithABI function calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91784
28b28725b6a6bc2a9ef315ac88a826c3b73fc5ba: Bug 1669415 - Fix phi type for phis with more than two operands. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 07 Oct 2020 07:18:15 +0000 - rev 617608
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669415 - Fix phi type for phis with more than two operands. r=iain With Warp, loop phis always have a MIRType::Value type during MIR building. Other phis, however, can be type specialized during MIR building if all operands have the same type. This is fine because these phis are always created before they're used. We were doing this when creating a new phi for the first two operands, but we could then add a third (or later) operand to the phi without updating the phi's type to reflect that. This also adds assertions to MPhi to check new inputs have consistent types. These assertions don't pass with IonBuilder because it handles loop phis a bit differently, so only enable them if Warp is enabled. Differential Revision: https://phabricator.services.mozilla.com/D92558
543509e7d886b5aae1de4e5b092a9fd8c4f29cf1: Bug 1667203 - Check for a jitScript before spewing anything in rateMyCacheIR. r=iain
Caroline Cullen <ccullen@mozilla.com> - Mon, 05 Oct 2020 20:17:05 +0000 - rev 617428
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667203 - Check for a jitScript before spewing anything in rateMyCacheIR. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91349
94eebfae1cfea422c2bcc0acb97a578153de65d8: Bug 1667203 - Have rateMyCacheIR return void. r=iain
Caroline Cullen <ccullen@mozilla.com> - Mon, 05 Oct 2020 20:17:18 +0000 - rev 617427
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667203 - Have rateMyCacheIR return void. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91348
f7b9e09c3ed8a74a0680133c3dbe0939547336cd: Bug 1666615 - Update comments for CacheIR health report. r=iain
Caroline Cullen <ccullen@mozilla.com> - Mon, 05 Oct 2020 20:16:35 +0000 - rev 617426
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666615 - Update comments for CacheIR health report. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91347
06d38d4ef74f4f34f53b54463d3d1a7f422369c3: Bug 1669012 - Make MToString hoistable. r=iain
Tom Schuster <evilpies@gmail.com> - Mon, 05 Oct 2020 20:05:46 +0000 - rev 617412
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669012 - Make MToString hoistable. r=iain Enabling this code allows us to hoist some additional well typed cases. Compared to normal Ion of course we quite often have Value typed PHIs etc. Differential Revision: https://phabricator.services.mozilla.com/D92473
026239352468a00213b154f9ae623e889b010297: Bug 1661256 part 31 - Convert BigInt's callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 16:56:24 +0000 - rev 617369
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 31 - Convert BigInt's callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91811
8cb65ed2344971ddbc613e9b96a2889e18f8f0af: Bug 1661256 part 25 - Convert Allocate* and CreateMathResult* callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 16:56:09 +0000 - rev 617363
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 25 - Convert Allocate* and CreateMathResult* callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91805
8bc6fafde18ca5a14ecb6b8fd7bcbcb8bc147cbc: Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 16:55:51 +0000 - rev 617357
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91799
5502d812c16c304cad09aaf413523a673cf73729: Bug 1661256 part 8 - Convert js::RegExp*OptimizableRaw callWithABI calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 16:54:22 +0000 - rev 617346
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 8 - Convert js::RegExp*OptimizableRaw callWithABI calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91788
4ac6aec3ab018c74b6fd4769bab0fbf78475d7ea: Bug 1661256 part 4 - Add irregexp callWithABI function calls. r=iain
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Mon, 05 Oct 2020 16:54:12 +0000 - rev 617342
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661256 part 4 - Add irregexp callWithABI function calls. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91784
1433349f32bcf32cabda86a142a534ef55f0e028: Bug 1667685 - Fix OOM bug in addInlinedChild. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Mon, 28 Sep 2020 16:49:16 +0000 - rev 617002
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667685 - Fix OOM bug in addInlinedChild. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91570
fe936dd686a0e92e087ea0467508f738576efa0b: Bug 1666417 part 10 - Enable Warp by default in the JS shell. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:45:50 +0000 - rev 616857
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 10 - Enable Warp by default in the JS shell. r=iain Changes the JitOptions to match setWarpEnabled(true) and makes --no-warp disable Warp. Differential Revision: https://phabricator.services.mozilla.com/D91902
a9b6455b350042b72ca7050c50610254ffc923b3: Bug 1666417 part 9 - Fix some arm64-simulator test failures. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:38:26 +0000 - rev 616833
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 9 - Fix some arm64-simulator test failures. r=iain The change in Simulator::overRecursed fixes a test failure, the old code didn't make sense. Now it matches the ARM32 and MIPS simulators. The other changes may not be necessary after part 7, but it makes sense to reduce the excessive iteration counts. Depends on D91900 Differential Revision: https://phabricator.services.mozilla.com/D91901
780e65c0e175661413289b0fd937ae0e3d636dd6: Bug 1666417 part 8 - Fix check to work on no-jit builds. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:36:41 +0000 - rev 616832
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 8 - Fix check to work on no-jit builds. r=iain This fixes some jit-test failures with a no-jit build. That's because (annoyingly) JS_GetGlobalJitCompilerOption always returns false in that configuration. Depends on D91899 Differential Revision: https://phabricator.services.mozilla.com/D91900
a3a3cf901fd0950e3087cf7d36703228c4740a1c: Bug 1666417 part 7 - Fix ASan test timeouts. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:31:22 +0000 - rev 616831
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 7 - Fix ASan test timeouts. r=iain Depends on D91898 Differential Revision: https://phabricator.services.mozilla.com/D91899
3be1201498e24ccbdaf913d3c136634956e0e753: Bug 1666417 part 6 - Disable AssertValid* calls on simulator builds. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:30:59 +0000 - rev 616830
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 6 - Disable AssertValid* calls on simulator builds. r=iain This fixes timeouts when running certain jit-tests. This patch is a measurable speedup when running all jit-tests with a simulator build. Depends on D91897 Differential Revision: https://phabricator.services.mozilla.com/D91898
9813153bab06ffa7a98561b7959575662e92a094: Bug 1666417 part 5 - Add debuggee check to AddInlinedCompilations. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 20:30:38 +0000 - rev 616829
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 5 - Add debuggee check to AddInlinedCompilations. r=iain The breakpoint-14.js jit-test had intermittent failures on Windows. Fortunately they could be reproduced with rr chaos mode. Differential Revision: https://phabricator.services.mozilla.com/D91897
ffc4085cd1ee03dbfd33d1f105753b7d42994e2d: Bug 1667699 - Get function script after checking the function is inlinable. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 07:27:00 +0000 - rev 616636
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667699 - Get function script after checking the function is inlinable. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91547
8e4778c34026e50aa0e554a92110fd80d1d11e95: Bug 1667680 - Fix assertion to account for --ion-limit-script-size=off testing flag. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 30 Sep 2020 07:17:48 +0000 - rev 616635
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667680 - Fix assertion to account for --ion-limit-script-size=off testing flag. r=iain Differential Revision: https://phabricator.services.mozilla.com/D91545
e2ed122bd760ce374861548d15217e0dfaa2fbce: Bug 1667330 - Stop exposing constructor names of JS objects. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Sat, 26 Sep 2020 03:00:15 +0000 - rev 616292
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667330 - Stop exposing constructor names of JS objects. r=iain The getConstructorName testing function and UbiNode got the constructor name of a JS object via the ObjectGroup's TypeNewScript. There's currently no way to get that information without TI (and it always depended on brittle optimization heuristics) so this patch removes that code. Differential Revision: https://phabricator.services.mozilla.com/D91419
91b890df65c564e5bbcd24b30ed576a045211fc5: Bug 1666417 part 3 - Enable Warp in the browser. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 22 Sep 2020 18:27:14 +0000 - rev 615540
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 3 - Enable Warp in the browser. r=iain Also bumps the threshold to 1500 to match DefaultJitOptions::setWarpEnabled. Changing the JS shell default is more tricky and will be done separately if this sticks. Depends on D90957 Differential Revision: https://phabricator.services.mozilla.com/D90958
30f2572e7374b17e505706ca90e9a71412c98761: Bug 1657206 - Run RateMyCacheIR without having to explicitly call the shell function. r=iain
Caroline Cullen <ccullen@mozilla.com> - Tue, 22 Sep 2020 18:36:26 +0000 - rev 615495
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1657206 - Run RateMyCacheIR without having to explicitly call the shell function. r=iain Differential Revision: https://phabricator.services.mozilla.com/D90752
40b474c5524905058b46cef968b93bcf507f7a4d: Bug 1657206 - Call RateMyCacheIR with one script, but spew multiple scripts from the same StructuredSpewer. r=iain
Caroline Cullen <ccullen@mozilla.com> - Tue, 22 Sep 2020 18:36:24 +0000 - rev 615494
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1657206 - Call RateMyCacheIR with one script, but spew multiple scripts from the same StructuredSpewer. r=iain Differential Revision: https://phabricator.services.mozilla.com/D90750
98e2eaed1e4b0be87249490edaf11ddff1599641: Bug 1666417 part 2 - Remove JitOptions.typeInference. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 22 Sep 2020 16:00:25 +0000 - rev 615473
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 2 - Remove JitOptions.typeInference. r=iain At this point it's equivalent to Warp being disabled. Depends on D90956 Differential Revision: https://phabricator.services.mozilla.com/D90957
a02a9c3592857d127de84bdf32709a4036ec0345: Bug 1666417 part 1 - Make Warp pref work on non-Nightly. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 22 Sep 2020 16:00:21 +0000 - rev 615472
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666417 part 1 - Make Warp pref work on non-Nightly. r=iain Differential Revision: https://phabricator.services.mozilla.com/D90956
b2656b6122e4d66092ce178173b190ce5aff8854: Bug 1666070 - Fix trialInline testing function to ignore cross-realm scripts. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Mon, 21 Sep 2020 17:11:08 +0000 - rev 615365
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666070 - Fix trialInline testing function to ignore cross-realm scripts. r=iain Differential Revision: https://phabricator.services.mozilla.com/D90853
84818eed989b5a5af378129fa90ec303ab5a9147: Bug 1666230 - Tidy up CacheIR opcode metadata. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Mon, 21 Sep 2020 17:13:51 +0000 - rev 615364
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666230 - Tidy up CacheIR opcode metadata. r=iain Replace argLengths array with a byte-sized struct that stores both the arg length and transpile flag. Use this flag in WarpOracle instead of the switch-statement. The flag could also be used by trial inlining to check for un-transpilable ops. Differential Revision: https://phabricator.services.mozilla.com/D90847
653d91b24508b338a17a3dc165287d42914eee75: Bug 1665303 - Clean up inlined ICScript if attaching the new stub failed. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Fri, 18 Sep 2020 13:36:58 +0000 - rev 614587
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1665303 - Clean up inlined ICScript if attaching the new stub failed. r=iain It was hard to fix the test to reproduce on mozilla-central tip so this adds a trialInline() testing function to trigger trial inlining of the caller's frame. Differential Revision: https://phabricator.services.mozilla.com/D90552
924265487b2027f671db48967587710ba7e239b0: Bug 1664786 part 8 - Add TrialInliningState to the fallback stub. r=iain
Jan de Mooij <jdemooij@mozilla.com> - Wed, 16 Sep 2020 17:00:38 +0000 - rev 614424
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1664786 part 8 - Add TrialInliningState to the fallback stub. r=iain This patch adds an enum class to track the inlining state per fallback stub and uses it for the following: * Don't scan CacheIR of stubs we definitely can't inline (will matter more for getters/setters). * Similarly, optimize the check for trial-inlined stubs in WarpOracle. * Assert in WarpOracle that we didn't trial-inline a stub the transpiler doesn't support. * Ensure we never attempt a second trial-inlining at the same location. Differential Revision: https://phabricator.services.mozilla.com/D90410