searching for reviewer(honza)
81429c99783c16e8056af18656d913a2b984b64f: Bug 1563914 - Fix ConsoleTable with invalid headers. r=Honza, a=RyanVM
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 09 Jul 2019 08:47:58 +0000 - rev 541595
Push 11649 by ryanvm@gmail.com at Mon, 29 Jul 2019 15:49:36 +0000
Bug 1563914 - Fix ConsoleTable with invalid headers. r=Honza, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D37164
441998ce7a5e32dca5f00505c575d4b75706256b: Bug 1565781 - Fix ConsoleTable with nested holey array. r=Honza. a=RyanVM
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Jul 2019 12:04:42 +0000 - rev 541494
Push 11621 by archaeopteryx@coole-files.de at Mon, 22 Jul 2019 20:16:35 +0000
Bug 1565781 - Fix ConsoleTable with nested holey array. r=Honza. a=RyanVM A test is added to ensure this is fixed properly. We also fix the Array previewer to properly return undefined for unknown array properties, rather than null. Differential Revision: https://phabricator.services.mozilla.com/D38467
50e3b40b9d54cc36b384b649ff147901863ff806: Bug 1567082 - Fix console table overflow. r=Honza. a=RyanVM
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 22 Jul 2019 19:37:00 +0300 - rev 541469
Push 11618 by dvarga@mozilla.com at Mon, 22 Jul 2019 16:58:11 +0000
Bug 1567082 - Fix console table overflow. r=Honza. a=RyanVM Reviewers: Honza Reviewed By: Honza Bug #: 1567082 Differential Revision: https://phabricator.services.mozilla.com/D38466
cab912119d7999d329e3cb06f15ad780547fa119: Bug 1562914 - Fix PropTypes error in FilterBar in split console. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 03 Jul 2019 11:15:28 +0000 - rev 540749
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562914 - Fix PropTypes error in FilterBar in split console. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D36618
5289c222f0d082ea10ef220b698ceeceb74ac2d1: Bug 1562839 - Put editor mode behind a pref. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 03 Jul 2019 11:14:22 +0000 - rev 540748
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562839 - Put editor mode behind a pref. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D36582
938ba43a3350c4f81a5ed152b02eb92f9e68c949: Bug 1519315 - Display CodeMirror's gutter in console input when devtools.webconsole.input.editor is true. r=Honza.
Bryan Kok <bryan.wyern1@gmail.com> - Fri, 28 Jun 2019 16:27:55 +0000 - rev 540206
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1519315 - Display CodeMirror's gutter in console input when devtools.webconsole.input.editor is true. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D33995
8cb2280adc9c245ead1fe1de49793a38486bc92a: Bug 1519105 - Add a keyboard shortcut to switch between inline and editor mode. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 28 Jun 2019 09:25:59 +0000 - rev 540147
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1519105 - Add a keyboard shortcut to switch between inline and editor mode. r=Honza. We use Cmd/Ctrl + B to switch between inline and editor mode. This should be familiar for VSCode users as it toggles the file sidebar. When changing the layout, we persist the choice into the editor pref so the user keeps the same layout the next time they open the console. Differential Revision: https://phabricator.services.mozilla.com/D34718
adf05ab240a59a1054e2d5f0dca0bf518b529283: Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 13:13:32 +0000 - rev 540146
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza. When the editor preference is true, a CSS class is added to the panel that allow us to shift the layout to a CSS Grid, where the input panel is on the left and the output on the right. A toolbar is added to be able to execute an expression when in editor mode. Differential Revision: https://phabricator.services.mozilla.com/D17096
5bb0858a753789688471fdeabe33538d9af22ed4: Bug 1560804 - Fix double scrollbar in network message detail. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 28 Jun 2019 08:50:43 +0000 - rev 540141
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1560804 - Fix double scrollbar in network message detail. r=Honza. We take this as an opportunity to fix the alignment between the XHR badge and the URL. Differential Revision: https://phabricator.services.mozilla.com/D36297
42fa48dca98885b5da0568284a5e1a0456ffd289: Bug 1559398 - Implement table and preview sections in WebSocket side panel. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Fri, 28 Jun 2019 07:24:59 +0000 - rev 540131
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559398 - Implement table and preview sections in WebSocket side panel. r=Honza Implement table and preview sections in WebSocket side panel. Differential Revision: https://phabricator.services.mozilla.com/D35983
89d1a2584683d3159cf1ed79a73e83bc04263775: Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe,Honza
tanhengyeow <E0032242@u.nus.edu> - Thu, 27 Jun 2019 11:54:37 +0000 - rev 539988
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe,Honza Hide WebSocketsPanel in console. Differential Revision: https://phabricator.services.mozilla.com/D36158
9c00486078c9290f0750159958aebc1730e0156d: Bug 1560320 - Dismiss autocomplete on Ctrl+A on OSX. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:48:34 +0000 - rev 539986
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1560320 - Dismiss autocomplete on Ctrl+A on OSX. r=Honza. Ctrl + A moves the cursor to the beginning of the line, so we need to dismiss autocomplete. A test case is added to make sure this behaves as expected. Differential Revision: https://phabricator.services.mozilla.com/D35573
87fa4e9eb13a108440f136703c218a345f5ff8f4: Bug 1559329 - Set "group similar messages" to true by default. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:42:15 +0000 - rev 539985
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559329 - Set "group similar messages" to true by default. r=Honza. This was making browser_webconsole_scroll.js fail. After some investigation, I found that the `isInWarningGroup` prop, a function defined in `mapStateToProp` was causing a re-rendering (because we were creating a new function each time), impacting the shouldScrollToBottom behaviour. To fix this, we no longer create a `isInWarningGroup` prop, but directly use the `isMessageInWarningGroup` selector, which was modified to take an array of visible messages instead of the whole state. Differential Revision: https://phabricator.services.mozilla.com/D35016
3e211dfbeb71fd8868e9e9d941e1a64e1d760981: Bug 1559335 - Fix messages ordering when 2 messages have the same timestamp. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Jun 2019 11:41:56 +0000 - rev 539984
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559335 - Fix messages ordering when 2 messages have the same timestamp. r=Honza. If 2 messages are emitted during the same microsecond, their timestamps are similar, and the sorting we do when filtering for warning groups might be erroneous. In such case, we now check the message id, to see which one we handled first, which should be enough. A test is added to ensure this works as expected. Basically, we now render 2 logs one after the another, to increase the chance they'll get the same timestamp. The updated test was failing without the fix, and seems to pass with it. Differential Revision: https://phabricator.services.mozilla.com/D35015
49ba71fb412d5de62e59bfdd0a0723fe83145c9b: Bug 1174100 - Cache information is not exposed to HAR. r=Honza
lloan <lloanalas@outlook.com> - Wed, 26 Jun 2019 15:07:06 +0000 - rev 539848
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1174100 - Cache information is not exposed to HAR. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33570
c239c5218b5beb7712243663a833384cd9ca8718: Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Wed, 19 Jun 2019 20:00:30 +0000 - rev 538894
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555625 - Basic skeleton of side panel for WS frames. r=Honza Implement basic skeleton of side panel for WS frames. Differential Revision: https://phabricator.services.mozilla.com/D34704
1b06448abd9346a6a3a0161e94a9f3f3bec6a8ef: Bug 1554881 - Simplify RequestListItem render r=Honza
Gregor Weber <gweber@mozilla.com> - Fri, 14 Jun 2019 13:38:55 +0000 - rev 538502
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1554881 - Simplify RequestListItem render r=Honza Differential Revision: https://phabricator.services.mozilla.com/D35010
b4f0ee392b9771796370b8f2b3194abba3599ff6: Bug 1174100 - Cache information is not exposed to HAR. r=Honza
lloan <lloanalas@outlook.com> - Fri, 14 Jun 2019 12:12:44 +0000 - rev 538495
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1174100 - Cache information is not exposed to HAR. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33570
7428c765611785fbd85b41aea1069d671bfc259d: Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 13 Jun 2019 12:35:04 +0000 - rev 538310
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557632 - Don't check if input is compilable unit on Ctrl+Enter. r=Honza. In the regular webconsole input, on Enter, we check that the input is a compilable unit, so the user don't accidentally execute an incomplete snippet. In the editor mode, the user will have to use Ctrl/Cmd + Enter to execute, so we don't have to worry about Enter (it will simply append a new line). And since the user might deal with a large number of characters, we don't want to prevent them to execute. If it's malformed, they will get an error in the output and can fix their input easily, since it wasn't cleared. The patch adds a test to ensure this work as expected. Differential Revision: https://phabricator.services.mozilla.com/D34522
3a9e09d5a4d7663c9016b011b4f15d9a34364071: Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza
yulia <ystartsev@mozilla.com> - Wed, 12 Jun 2019 23:34:59 +0000 - rev 538254
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1494796 - fix netmonitor test to ensure elements exist on the dom before testing; r=Honza the test `browser_net_params_sorted` may not have been functioning for some time. While investigating this, I discovered that we were getting an empty array for `actualKeys`. Iterating over this array returned immediately. As a result the test always passed, even though the shape of the data changed. I updated this code so that it waits for the dom to be populated with the number of keys expected. I also updated the test to reflect the data the front end has today. Differential Revision: https://phabricator.services.mozilla.com/D32713
ee33e076cbcbe786125f83079bd8e5b43bb73a99: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 15:27:08 +0000 - rev 537905
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza,jdescottes Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278
eb9868016897672165b4a95e9adf41c3883b6ec0: Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza
David Walsh <dwalsh@mozilla.com> - Tue, 11 Jun 2019 08:49:38 +0000 - rev 537892
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1558237 - Prevent unwanted background for event listener breakpoints toggles r=Honza Differential Revision: https://phabricator.services.mozilla.com/D34381
d218c415396f9188c5d19ac09c50b6db82730016: Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 13:47:37 +0000 - rev 537880
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza. This allows to have more meaningful warning group messages, i.e. "Content Blocking" is turned into something like "The resource at '<URL>' was blocked because content blocking is enabled". This is done by parsing the message of the first warning to put in the group, and replacing the URL with a generic placeholder. We take this as an opportunity to decouple content blocked messages and storage access blocked ones, as they have slightly different meanings and consequences. Tests are updated to match the new labels, and a new test is added to make sure that we can have multiple warning group in a single "page navigation" session. Differential Revision: https://phabricator.services.mozilla.com/D34339
be1ba46ab9fd608f8fb61882d0e23ffe01f8739e: Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 08:26:22 +0000 - rev 537836
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza. Hitting Ctrl+ArrowRight didn't have any effect on windows/linux. The patch fixes this and add a test to make sure a user can navigate from word to word using Ctrl (or Alt on OSX) and Arrow Left/Right keys. Differential Revision: https://phabricator.services.mozilla.com/D34312
de1dc8a5ce5403163d5b2d4215795ca429358433: Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Tue, 11 Jun 2019 08:16:31 +0000 - rev 537835
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552458 - Implement backend actor for WebSocket inspection. r=Honza Implement backend actor for WebSocket inspection Differential Revision: https://phabricator.services.mozilla.com/D33278
e69430c126d73a919b73ed81002d690dea888358: Bug 1556308 - Prevent nemonitor errors for failed requests r=Honza
David Walsh <dwalsh@mozilla.com> - Mon, 10 Jun 2019 16:16:08 +0000 - rev 537734
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556308 - Prevent nemonitor errors for failed requests r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33988
b596d98d59fd5aea938f1b1391d4e208c5bb01fb: Bug 1556454 - Use consistent red color and show blocked badge for blocked requests r=Honza
David Walsh <dwalsh@mozilla.com> - Fri, 07 Jun 2019 08:21:24 +0000 - rev 537568
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556454 - Use consistent red color and show blocked badge for blocked requests r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33862
89b7f73b270126eea62ee77f6873805976fd8abe: Bug 1523864 - Move filter bar layout change to the App level. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 07 Jun 2019 14:23:35 +0000 - rev 537502
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1523864 - Move filter bar layout change to the App level. r=Honza. This makes the console code more consistent, and adds the nice benefit of being able to check if the layout should be modified when performing non-window-resize events that might still impact the layout (sidebar toggle, sidebar resizing, ...). Differential Revision: https://phabricator.services.mozilla.com/D27668
4c8aa3c1d1234d5c7c4ff5c8da26ff307e4e0a92: Bug 1523864 Display filter buttons next to filter input if there is enough space. r=Honza
Kelly <kelly.bell@mail.utoronto.ca> - Fri, 07 Jun 2019 14:23:16 +0000 - rev 537501
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1523864 Display filter buttons next to filter input if there is enough space. r=Honza Set a minimum width on the filter bar of the Devtools Console window. When there is enough empty space to the right of the filterbar, allow the filter buttons to be desplaying inline, rather than on their own separate row. Differential Revision: https://phabricator.services.mozilla.com/D20188
0a7fc2e413adbcb44d40e2a9f559fbe7a2b6c985: Bug 1556068 - Track JsPropertyProvider's analyzeInput string and bail if it's taking too long. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 06 Jun 2019 13:08:21 +0000 - rev 537250
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556068 - Track JsPropertyProvider's analyzeInput string and bail if it's taking too long. r=Honza. It can happen that the string we receive is quite large and as a result takes a long time to analyze, freezing the process. This patch simply tracks for how long the for loop is running, and bail out if it's greater than a given time (set to 2500 ms for now). This is mostly a safeguard, a future patch should try to improve the performance of the function itself. Differential Revision: https://phabricator.services.mozilla.com/D33791
e6dd869ef4841de8c3628e173525c376aafce585: Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 04 Jun 2019 15:06:06 +0000 - rev 536472
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33616
37918f3c49dfa66c3fb8c5a12ee3e11a9e35d088: Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza
Tim Nguyen <ntim.bugs@gmail.com> - Tue, 04 Jun 2019 12:53:16 +0000 - rev 536444
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33616
41ead3af829120a34c76a1f01472dca7c004e0e1: Bug 1525618 - Add an option in the settings panel to toggle warning groups. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 03 Jun 2019 15:10:45 +0000 - rev 536273
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1525618 - Add an option in the settings panel to toggle warning groups. r=Honza. We also listen for the warningGroup preference change to toggle warningGroups in the console output. If warningGroups were disabled, we need to loop through the state messages to create warningGroups when needed. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D32716
abf29aea4d1edd7cc377f18d1b25149b020bcabf: Bug 1555909 - Remove workaround for cleanup the list on destroy. r=Honza
lloan <lloanalas@outlook.com> - Mon, 03 Jun 2019 07:35:04 +0000 - rev 536217
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555909 - Remove workaround for cleanup the list on destroy. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D33444
b067a5b108dd7d396453500caf047c41fc678ad2: Bug 1157817 - Show blocked requests in the Network Monitor r=Honza,Harald
David Walsh <dwalsh@mozilla.com> - Tue, 28 May 2019 12:13:08 +0000 - rev 535463
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1157817 - Show blocked requests in the Network Monitor r=Honza,Harald Displays blocked requests in the Network monitor request listing, providing a reason for why the request was blocked based on response codes provided b nsILoadInfo.idl Differential Revision: https://phabricator.services.mozilla.com/D31907
9341602d655c3baf915ad49624e71815aa0bfb94: Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza
Vincent Lequertier <vi.le@autistici.org> - Mon, 27 May 2019 07:23:44 +0000 - rev 535321
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552629 - Fix misaligned "Edit and Resend" button in the netmonitor Headers panel;r=Honza If the "Referrer Policy" header is missing, summaryReferrerPolicy is null, so summaryEditAndResendBtn contains only the "Edit and Resend" button, making it misaligned. We fix this by making sure summaryEditAndResendBtn always contains the last non-null header. Differential Revision: https://phabricator.services.mozilla.com/D32322
8e80b2082da53556d32efa82121b2391899ab543: Bug 1554095 - Fix Block URL action. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Mon, 27 May 2019 06:47:10 +0000 - rev 535302
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1554095 - Fix Block URL action. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D32522
c1d2feb784e02c9ed085d1faed370e85edcb3032: Bug 1341155 - Show full path in File column in developer tools. r=Honza
lloan <lloanalas@outlook.com> - Thu, 23 May 2019 12:24:57 +0000 - rev 534834
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1341155 - Show full path in File column in developer tools. r=Honza New column, defaulted to hidden, to show full URL for resource in netMonitor panel. Differential Revision: https://phabricator.services.mozilla.com/D31348
53132931ba91cbd4a394734e32abbf387d6c6162: Bug 1553473 - Fix PropTypes. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 May 2019 09:26:44 +0000 - rev 534833
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553473 - Fix PropTypes. r=Honza. The FilterBar propType was a leftover from a previous patch where the prop was removed. The SearchBox one was added in a recent patch, but shouldn't have been required (as we have a default in the render function for it). Differential Revision: https://phabricator.services.mozilla.com/D32150
baf86b77635c22a5739fcef15e0a9172fd5cbd6b: Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 May 2019 08:57:36 +0000 - rev 534534
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza. Before sending back the stacktrace, we remove all the devtools internal frames using removeFramesAboveDebuggerEval. A test (that was failing without the fix) is added to ensure this works as expected. The test revealed some issues in webconsole-connection-proxy (mostly trying to access webConsoleUI while closing the toolbox), which we fix in the patch as well. Differential Revision: https://phabricator.services.mozilla.com/D31249
78571bb1f20e643cdab9791f61b0aa7b6a8bdf90: Bug 1534932 - Ensure filtering works with warningGroups. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 May 2019 12:43:04 +0000 - rev 534363
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1534932 - Ensure filtering works with warningGroups. r=Honza. We want the warningGroup to be displayed if at least one of its children will be visible. We also want all the children if the warningGroup should be visible. This requires a few changes in the message reducers, mainly in the getVisibility function. But we also modify maybeSortVisibleMessages to place the messages in warningGroups at the expected positions. A complete mochitest is added to ensure the output always has the expected messages in the expected order. Differential Revision: https://phabricator.services.mozilla.com/D31220
be01ec66f386d44d59fc56ab904a84c299521177: Bug 1419358 - Never filter-out navigation markers message. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 21 May 2019 12:42:34 +0000 - rev 534362
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1419358 - Never filter-out navigation markers message. r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D31219
36ada63cb9fb9ff56e7556cfc1db8cfad2c46a2d: Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 20 May 2019 12:33:06 +0000 - rev 534180
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1541355 - Don't display DevTools internal frames in Netmonitor stacktrace. r=Honza. Before sending back the stacktrace, we remove all the devtools internal frames using removeFramesAboveDebuggerEval. A test (that was failing without the fix) is added to ensure this works as expected. The test revealed some issues in webconsole-connection-proxy (mostly trying to access webConsoleUI while closing the toolbox), which we fix in the patch as well. Differential Revision: https://phabricator.services.mozilla.com/D31249
0c663b927b277a56270923e22fb22911b8f5ada5: Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza. a=jcristau
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Jun 2019 08:26:22 +0000 - rev 533856
Push 11441 by opoprus@mozilla.com at Thu, 13 Jun 2019 13:39:01 +0000
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza. a=jcristau Hitting Ctrl+ArrowRight didn't have any effect on windows/linux. The patch fixes this and add a test to make sure a user can navigate from word to word using Ctrl (or Alt on OSX) and Arrow Left/Right keys. Differential Revision: https://phabricator.services.mozilla.com/D34312
5ae78f2863c680529abed3a69bde02e25cafa8ee: Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza a=jcristau
Tim Nguyen <ntim.bugs@gmail.com> - Fri, 07 Jun 2019 02:00:36 +0300 - rev 533671
Push 11391 by ncsoregi@mozilla.com at Thu, 06 Jun 2019 23:05:04 +0000
Bug 1551870 - Reintroduce netmonitor-toolbar-container in single-toolbar mode so React doesn't re-render the toolbar when switching panels. r=Honza a=jcristau Reviewers: Honza Reviewed By: Honza Subscribers: reviewbot Bug #: 1551870 Differential Revision: https://phabricator.services.mozilla.com/D33616
f6b2a8d526cdeff38133e8048d3d9a8796d46080: Bug 1554095 - Fix Block URL action. r=Honza a=jcristau
tanhengyeow <E0032242@u.nus.edu> - Mon, 27 May 2019 06:47:10 +0000 - rev 533635
Push 11381 by archaeopteryx@coole-files.de at Wed, 05 Jun 2019 18:22:40 +0000
Bug 1554095 - Fix Block URL action. r=Honza a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32522
d5a1f414d631aa02482f1c650387bc14c5e31b62: Bug 1466598 - [Network-Monitor] Right click on method enables request details tab. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Fri, 17 May 2019 07:01:05 +0000 - rev 533117
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1466598 - [Network-Monitor] Right click on method enables request details tab. r=Honza Show context menu properly Differential Revision: https://phabricator.services.mozilla.com/D29126
7fdd2abe918b6ba220dd097d27d1a2cda6cfa8e6: Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza
lloan <lloanalas@outlook.com> - Fri, 17 May 2019 06:50:40 +0000 - rev 533116
Push 11276 by rgurzau@mozilla.com at Mon, 20 May 2019 13:11:24 +0000
Bug 1530914 - Highlighted resource information is difficult to read when blocked. r=Honza When looking at the resource listing, and there's a blocked item, it is difficult to read the pink text. Before: https://bug1530914.bmoattachments.org/attachment.cgi?id=9063611 Now: https://i.imgur.com/znNx8aQ.png Differential Revision: https://phabricator.services.mozilla.com/D31354
11ea9feda2a39cd013315ed5afcb5e8abbdd099f: Bug 1500915 - Properly decode urls. r=Honza
Mrigank Krishan <mrigankkrishan@gmail.com> - Wed, 15 May 2019 08:47:51 +0000 - rev 532732
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1500915 - Properly decode urls. r=Honza Used decodeURI insted of decodeURLComponent and replace `+` with ` `(space). I've not tackled the line break issue yet. Differential Revision: https://phabricator.services.mozilla.com/D23014
9cca1de0aa3969e0f3e5e05a99455a343ab9e5a5: Bug 1479365 - Invert selection colors in selected rows; r=Honza,yzen,nchevobbe
Florens Verschelde <florens@fvsch.com> - Wed, 15 May 2019 07:36:04 +0000 - rev 532730
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1479365 - Invert selection colors in selected rows; r=Honza,yzen,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D30794