searching for reviewer(hiro)
3ad2fc2915b1a66bb7180dee6796144121042dfe: Bug 1654429 - Enable test_transitions_replacement_on_busy_frame.html for fission and xorigin. r=hiro
Boris Chiou <boris.chiou@gmail.com> - Sat, 25 Jul 2020 03:14:44 +0000 - rev 606511
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1654429 - Enable test_transitions_replacement_on_busy_frame.html for fission and xorigin. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84884
236c6d4f049c5c3bd509297c6a3a720cb8688181: Bug 1652288 - Expand the RCD-RSF's ink overflow rect by the dynamic toolbar height in DescendIntoChild(). r=hiro
Botond Ballo <botond@mozilla.com> - Fri, 24 Jul 2020 18:20:20 +0000 - rev 606462
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652288 - Expand the RCD-RSF's ink overflow rect by the dynamic toolbar height in DescendIntoChild(). r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84780
564081c2d0cdd4a047bf7ac02d786c89313133e2: Bug 1652288 - Expand the RCD-RSF's ink overflow rect by the dynamic toolbar height in DescendIntoChild(). r=hiro
Botond Ballo <botond@mozilla.com> - Fri, 24 Jul 2020 17:49:44 +0000 - rev 606454
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652288 - Expand the RCD-RSF's ink overflow rect by the dynamic toolbar height in DescendIntoChild(). r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84780
35d658861d6eb9ab153137480aef105db20fbdd6: Bug 1648344 Part 4: Disable a wpt test on android. r=hiro
Brad Werth <bwerth@mozilla.com> - Fri, 24 Jul 2020 00:16:32 +0000 - rev 606241
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648344 Part 4: Disable a wpt test on android. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84754
eeeaa4833c449b45af701d848ee48dfc6600eb42: Bug 1648344 Part 3: Update test expectations for viewport tags width no width or initial-scale. r=hiro
Brad Werth <bwerth@mozilla.com> - Fri, 24 Jul 2020 00:16:32 +0000 - rev 606240
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648344 Part 3: Update test expectations for viewport tags width no width or initial-scale. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84013
5900b99f8c02d90e2adbd87aa6be8d9a06a08541: Bug 1648344 Part 2: Cleanup Document to remove NoValidContent viewport type. r=hiro
Brad Werth <bwerth@mozilla.com> - Wed, 22 Jul 2020 23:11:42 +0000 - rev 606239
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648344 Part 2: Cleanup Document to remove NoValidContent viewport type. r=hiro The NoValidContent type was added to detect cases where we needed to apply default width the viewport. That approach is no longer needed, and this enum can be removed, as well as the code that sets and checks that enum. Differential Revision: https://phabricator.services.mozilla.com/D84447
757734d716e2a21518be6cfd076c50ff23e94f9c: Bug 1648344 Part 1: Apply default viewport width in more circumstances, matching Chrome. r=hiro
Brad Werth <bwerth@mozilla.com> - Wed, 22 Jul 2020 23:46:18 +0000 - rev 606238
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648344 Part 1: Apply default viewport width in more circumstances, matching Chrome. r=hiro Setting the effective max-width to the default viewport width value this way matches Chrome behavior and improves web compatibility. https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/page/viewport_description.cc;l=94-101;drc=f668b0ef8c8813fd06387ec215a08f2df7dd1234?originalUrl=https:%2F%2Fcs.chromium.org%2F Differential Revision: https://phabricator.services.mozilla.com/D84446
b38b315243499ab4f8bfe92e5cdea272469233fb: Bug 1648064 - Disable lazy loading for print documents. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Jul 2020 20:29:08 +0000 - rev 606058
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648064 - Disable lazy loading for print documents. r=hiro This, along with the previous patches, allow lazy-loaded images to show up in print, even if they haven't been loaded otherwise. Differential Revision: https://phabricator.services.mozilla.com/D81780
f735d4f6b21ffaa8b46e745c35f372aa06d8e3a6: Bug 1648064 - Disable lazy loading for print documents. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Jul 2020 14:39:45 +0000 - rev 606014
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1648064 - Disable lazy loading for print documents. r=hiro This, along with the previous patches, allow lazy-loaded images to show up in print, even if they haven't been loaded otherwise. Differential Revision: https://phabricator.services.mozilla.com/D81780
e369d25873ad9d13122b6a740a2ac5ef5a9d2804: Bug 1654107 - Fix non-unified build errors in CompositorAnimationStorage.{h,cpp}. r=hiro
Botond Ballo <botond@mozilla.com> - Mon, 20 Jul 2020 23:05:46 +0000 - rev 605746
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1654107 - Fix non-unified build errors in CompositorAnimationStorage.{h,cpp}. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D84258
f6127ce5c74439b7468a36c08941f3ab7210930f: Bug 1652120 - Initialize local variable in PresShell::CreateRangePaintInfo. r=hiro
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Jul 2020 06:37:51 +0000 - rev 605231
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652120 - Initialize local variable in PresShell::CreateRangePaintInfo. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D83739
20c29266e1df44a703e84554b449204b0e8f55b9: Bug 1652344 p2. Fix the print settings creation in the print preview tests. r=hiro
Jonathan Watt <jwatt@jwatt.org> - Mon, 13 Jul 2020 00:30:00 +0000 - rev 604514
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652344 p2. Fix the print settings creation in the print preview tests. r=hiro nsIWebBrowserPrint.globalPrintSettings returns a new object each time. That is why the code in these tests doesn't work, and why they have the workaround to set the pref to disable the progress dialog. This patch fixes the code and removes the prefs setting workaround. This patch also changes the code to use the print settings service to get the print settings. That's all that nsIWebBrowserPrint.globalPrintSettings does anyway. Making this change allows me to remove nsIWebBrowserPrint.globalPrintSettings in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D83279
8042b7b369435bf8c17d0b2d9af65aabb0a966ac: Bug 1256980 - Make z-index only apply to positioned and grid / flex item frames. r=miko,hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Jun 2020 22:51:12 +0000 - rev 602509
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1256980 - Make z-index only apply to positioned and grid / flex item frames. r=miko,hiro Differential Revision: https://phabricator.services.mozilla.com/D81557
41f514fd5202276ded6fed65ff6e9820e8f6f80b: Bug 1638844 - Update fuzzy condition for linux-64-ccov. r=hiro
Boris Chiou <boris.chiou@gmail.com> - Mon, 29 Jun 2020 21:26:07 +0000 - rev 602236
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1638844 - Update fuzzy condition for linux-64-ccov. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D81586
dc28a52cb810537acb394dd00d6cc91aeefa1063: Bug 1648796 - Mark a handful of tests with user-scalable=no. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 26 Jun 2020 22:22:49 +0000 - rev 601744
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648796 - Mark a handful of tests with user-scalable=no. r=hiro On Android, if user-scalable=no is not set, Gecko uses the "minimum scale size" as the scrollport size, to allow for the user zooming out all the way to the minimum allowed scale. This has a number of effects, such as dropping the layout scroll range to zero for the root scrollframe. This can causes a number of WPT tests to fail; they currently pass only because the minimum scale size changes take effect after the test is already done. However, moving the minimum scale size changes to happen earlier causes these tests to fail. It's better to modify the tests to disable this behaviour, so that the assumptions in the test are not invalidated. Differential Revision: https://phabricator.services.mozilla.com/D81355
93abfd457d35f92d20cb04d4878aea73b2d691f0: Bug 1648305 - Use the scrollable rect size for first-paint intrinsic scale calculation. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Jun 2020 08:41:24 +0000 - rev 601452
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648305 - Use the scrollable rect size for first-paint intrinsic scale calculation. r=hiro When meta-viewport support is enabled, the call to UpdateResolutionForFirstPaint from RefreshViewportSize is followed by a call to ShrinkToDispalySizeIfNeeded, which calls UpdateResolutionForContentSizeChange and uses the scrollable rect size for the intrinsic scale computation. So the intrinsic scale computation in UpdateResolutionForFirstPaint causes a transient state where the resolution and visual viewport size is wrong. It is corrected immediately after, but changing the visual viewport size like that ends up marking frames dirty for reflow. Avoiding the transient state avoids those reflows, which is a nice optimization. Differential Revision: https://phabricator.services.mozilla.com/D80996
8ed7030eea2641e8c9fd6c2fdfe9aa8bdf672dde: Bug 1648193 - Additional minor cleanup. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 24 Jun 2020 23:48:51 +0000 - rev 601366
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648193 - Additional minor cleanup. r=hiro Instead of having callers compute the cssToDev and pass it to the zoom/ resolution conversion functions, we can just do it in those functions directly. Differential Revision: https://phabricator.services.mozilla.com/D80939
f47b6c7919222b0e2172fc26713ff7d045999b6c: Bug 1648193 - Split UpdateResolution into three different functions. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 24 Jun 2020 23:45:00 +0000 - rev 601365
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648193 - Split UpdateResolution into three different functions. r=hiro This is a hard diff to read but fundamentally a pretty simple patch. The old UpdateResolution function had a giant if condition in the middle conditioned on the update type. Inside the ViewportSize branch there was a further nested if conditioned on mIsFirstPaint. The function got split into three, with each new function holding one of the three main blocks of code, along with a copy of the stuff before and after the if condition. And then I simplified each function individually to remove unnecessary variables, add some early-exits and reduce nesting levels, etc. Depends on D80937 Differential Revision: https://phabricator.services.mozilla.com/D80938
ecc93a6635fc5634eff30696116e4674d9b8640d: Bug 1648193 - Stop passing things to MVM that it already knows how to compute. r=hiro
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 24 Jun 2020 22:22:17 +0000 - rev 601364
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648193 - Stop passing things to MVM that it already knows how to compute. r=hiro This removes the two parameters to ShrinkToDisplaySizeIfNeeded and corresponding parameters passed to UpdateResolution. The call site in nsGfxScrollFrame gets the arguments from the MVM itself, so it seems silly to be getting things from the MVM just to pass it back in. The other call sites are already in theMVM. This change might be slightly less efficient because it re-computes the viewport info when the caller might already have it but this isn't a hot code path so I'm not too concerned. Differential Revision: https://phabricator.services.mozilla.com/D80937
730dac40b4ba32e0f225b4bb5b3b380407ed8e69: Bug 1647871 - Simplify content viewer composition size code. r=kats,hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Jun 2020 14:46:40 +0000 - rev 601269
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647871 - Simplify content viewer composition size code. r=kats,hiro This should be equivalent because: * Content viewer size and widget size should eventually be the same always (modulo mid-resize, see bug 1645954). * Only the root content document has a widget on android (the puppet widget). * Only the root content document has a dynamic toolbar. * We were only calling this on the root document, which has no parent pres context (at least with e10s). Without e10s we could have a chrome prescontext (not sure it that ends up being a parent in the pres context chain), but we should never change the resolution of that one, so I think aScaleContentViewerSize is just useless. This avoids having two sources of truth by always checking the content viewer size without subtracting the dynamic toolbar max size. Differential Revision: https://phabricator.services.mozilla.com/D80723
a174387c4c8b42945f2e33a03174803a69c202f6: Bug 1644395 - Add additional wpt infra tests for mismatch, r=hiro
James Graham <james@hoppipolla.co.uk> - Tue, 23 Jun 2020 10:00:30 +0000 - rev 600854
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644395 - Add additional wpt infra tests for mismatch, r=hiro Differential Revision: https://phabricator.services.mozilla.com/D79083
ceff82dfdd5e5dc91d2fced74c92659443071b89: Bug 1644395 - Marionette support for wpt print reftests, r=marionette-reviewers,hiro,maja_zf
James Graham <james@hoppipolla.co.uk> - Tue, 23 Jun 2020 10:00:26 +0000 - rev 600852
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644395 - Marionette support for wpt print reftests, r=marionette-reviewers,hiro,maja_zf Render print reftests to a PDF using the printing machinary, and use pdf.js from gecko itself to convert the PDF to an image for pixel comparisons. For the surrounding reftest machinery, the main change here is that we convert reftests to work in terms of lists of images rather than a single image. For normal reftests we only have a single image in the list; for print reftests we can have several (one per page). This is implemented in terms of iterators to avoid unnecessary renders when the test fails on an earlier page. Differential Revision: https://phabricator.services.mozilla.com/D79081
582c1dd945caeb1b6286d5cad51e68cab144618a: Bug 1644395 - Add additional wpt infra tests for mismatch, r=hiro
James Graham <james@hoppipolla.co.uk> - Mon, 22 Jun 2020 13:44:16 +0000 - rev 600676
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644395 - Add additional wpt infra tests for mismatch, r=hiro Differential Revision: https://phabricator.services.mozilla.com/D79083
59e998eb5e59a146ac2289ae9c2e3fd35071fce1: Bug 1644395 - Marionette support for wpt print reftests, r=marionette-reviewers,hiro,maja_zf
James Graham <james@hoppipolla.co.uk> - Mon, 22 Jun 2020 13:44:06 +0000 - rev 600674
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644395 - Marionette support for wpt print reftests, r=marionette-reviewers,hiro,maja_zf Render print reftests to a PDF using the printing machinary, and use pdf.js from gecko itself to convert the PDF to an image for pixel comparisons. For the surrounding reftest machinery, the main change here is that we convert reftests to work in terms of lists of images rather than a single image. For normal reftests we only have a single image in the list; for print reftests we can have several (one per page). This is implemented in terms of iterators to avoid unnecessary renders when the test fails on an earlier page. Differential Revision: https://phabricator.services.mozilla.com/D79081
5af8a1c15e5d8d378c6b0d253ebc5bb4c0424f65: No bug - Document the #layout-reviewers group. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Jun 2020 03:00:34 +0000 - rev 600542
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
No bug - Document the #layout-reviewers group. r=hiro DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D80324
eee3381d8d373a57de8e6159a44b4eb9f15f6222: Bug 1646619 - Update reftest annotations for android device. r=hiro
Glenn Watson <git@intuitionlibrary.com> - Thu, 18 Jun 2020 06:21:50 +0000 - rev 600336
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646619 - Update reftest annotations for android device. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D80145
2069d33fce0318e442afb5111ccd2a96a2b87bf8: Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Jun 2020 00:42:47 +0000 - rev 600319
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro We're converting to nscoord in some places unnecessarily, reducing the precision of the computed value we return. This makes some tests unnecessarily fail if we change the base of nscoord. Differential Revision: https://phabricator.services.mozilla.com/D79996
2011f0091ccf6e495d05d76772bd9055c758ec95: Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Jun 2020 22:30:14 +0000 - rev 600282
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646336 - Don't unnecessarily lose precision in nsComputedDOMStyle. r=hiro We're converting to nscoord in some places unnecessarily, reducing the precision of the computed value we return. This makes some tests unnecessarily fail if we change the base of nscoord. Differential Revision: https://phabricator.services.mozilla.com/D79996
52126fd9ffdf8322286962810e68257e28b1df93: Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 14 Jun 2020 23:26:04 +0000 - rev 599709
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo It was removed from the spec. Differential Revision: https://phabricator.services.mozilla.com/D78834
5f2a4500c96d3078d5f241be979e126e619b8813: Bug 1642922 - Tweak scroll-padding implementation to also account for visibility. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Jun 2020 21:24:33 +0000 - rev 599557
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642922 - Tweak scroll-padding implementation to also account for visibility. r=hiro The previous implementation made us think that stuff was visible when in fact it was not. Differential Revision: https://phabricator.services.mozilla.com/D79345
bca9f7459a161e1bb7b9b4482694513ff76fde62: Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Jun 2020 13:21:54 +0000 - rev 598753
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo It was removed from the spec. Bug 1643934 updates the WPT tests. Differential Revision: https://phabricator.services.mozilla.com/D78834
8be6868381828e323d97d6200afe35b1d2fe1b68: Bug 1630919 - Do not throttle an effect due to opacity if the frame is animating opacity itself. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 23:12:26 +0000 - rev 595295
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630919 - Do not throttle an effect due to opacity if the frame is animating opacity itself. r=hiro When transitioning visibility and opacity at the same time, we create two effects, one animating opacity, and one visibility. We're incorrectly throttling the visibility animation due to opacity, because _that_ effect is not animating opacity, but the other one is and thus doesn't get throttled. Use HasAnimationOfOpacity() to check for this case. This is slightly sketchy, because the first time we get through there we may not even have started the opacity animation yet. However it kinda works, because the fact that there's a (non-throttled, because of the aEffect.HasOpacityChange()) opacity animation means that we'll tick both of them, and unthrottle them next frame. This seems better than the alternative which is never throttling animations in opacity: 0 roots. Differential Revision: https://phabricator.services.mozilla.com/D76405
7ded7f391f1b90c8ccc81bf151d289a802470317: Bug 1609024 - Remove cache mechanism which is not very useful. r=hiro,snorp,mccr8
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 21 May 2020 17:02:06 +0000 - rev 595225
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1609024 - Remove cache mechanism which is not very useful. r=hiro,snorp,mccr8 I don't think all this complexity is worth it for having a marginally-more-realistic testing story. Using the pref just works and we should do that, I think. Differential Revision: https://phabricator.services.mozilla.com/D59980
0143fd91ba203aab4103c98f09d0dc2bf7b21e30: Bug 1638773: Allow initial-scale clamping when user-scalable=no, add WPT. r=hiro
Brad Werth <bwerth@mozilla.com> - Wed, 20 May 2020 15:15:07 +0000 - rev 595009
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638773: Allow initial-scale clamping when user-scalable=no, add WPT. r=hiro This corrects the handling of user-scalable=no to first clamp scale (whether specified or default) between min and max scales, then applies the resulting value to initial-scale, min and max. Differential Revision: https://phabricator.services.mozilla.com/D76056
1ec3a730a72f0e14a68b65b11a83badc4b8335bd: Bug 1626794 - Add strong ref to document and MOZ_CAN_RUN_SCRIPT annotation to Animation::CommitStyles r=hiro
Emily McDonough <emcdonough@mozilla.com> - Sun, 17 May 2020 20:47:37 +0000 - rev 594427
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1626794 - Add strong ref to document and MOZ_CAN_RUN_SCRIPT annotation to Animation::CommitStyles r=hiro Differential Revision: https://phabricator.services.mozilla.com/D75418
01970559781abd2a8e594cf253401e1dff4d1bde: Bug 1564128 part 3 - Reftests checking for if animations are applied in print preview r=hiro
Emily McDonough <emcdonough@mozilla.com> - Thu, 14 May 2020 23:15:51 +0000 - rev 593959
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1564128 part 3 - Reftests checking for if animations are applied in print preview r=hiro Changes the existing reftest to expect success, and adds additional tests for pseudo-elements, paused animations, the web animation API, and shadow DOM elements. Differential Revision: https://phabricator.services.mozilla.com/D73140
b533efb48731cdb95ef7070581afe54ba7d65931: Bug 1564128 part 2 - Copy animations to static document clones r=emilio,hiro
Emily McDonough <emcdonough@mozilla.com> - Thu, 14 May 2020 19:41:03 +0000 - rev 593958
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1564128 part 2 - Copy animations to static document clones r=emilio,hiro This also requires changing the EffectCompositor to allow animations in print and print preview, and setting up a document timeline for the cloned document Differential Revision: https://phabricator.services.mozilla.com/D69069
e9e8c329a21cbf6fa0a7b4425e0fd2d1ad181f59: Bug 1564128 part 1 - Add clone function for Animation and constructor for KeyframeEffect to copy properties but not the target. r=hiro
Emily McDonough <emcdonough@mozilla.com> - Thu, 14 May 2020 19:41:01 +0000 - rev 593957
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1564128 part 1 - Add clone function for Animation and constructor for KeyframeEffect to copy properties but not the target. r=hiro This is needed for copying animations from an original document to a static clone during printing/print preview. Differential Revision: https://phabricator.services.mozilla.com/D73139
02e266dc4a3da99bfd63b091789f2602844870e7: Bug 1636119 - Don't snap SVG content during animation r=hiro
longsonr <longsonr@gmail.com> - Thu, 14 May 2020 10:43:11 +0000 - rev 593585
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636119 - Don't snap SVG content during animation r=hiro Differential Revision: https://phabricator.services.mozilla.com/D74505
614e528541e6e5bc727d2b005ebe86cdfec51e3c: Bug 1540906 - Disable the pref of synchronizing transform animations with geometric animations on nightly. r=hiro
Boris Chiou <boris.chiou@gmail.com> - Mon, 11 May 2020 20:40:48 +0000 - rev 592983
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1540906 - Disable the pref of synchronizing transform animations with geometric animations on nightly. r=hiro The original site issue (https://trello.com/) seems not obvious on nightly now. (See Bug 1301305 for more details.) So perhaps we could give this a trial to disable this pref, for the better performance in other cases. Differential Revision: https://phabricator.services.mozilla.com/D74278
f373457163975d38ebf0e70f57012debf4bf6b2c: Bug 1636731 - Use FunctionRef for animation generation enumeration. r=hiro
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 10 May 2020 02:17:47 +0000 - rev 592758
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636731 - Use FunctionRef for animation generation enumeration. r=hiro I see the allocation and deallocation of the std::function show up in profiles. Differential Revision: https://phabricator.services.mozilla.com/D74551
49cf3f1ea7be1479bbe30226570e6f0955c60178: Bug 1465776 - run css/css-variables/variable-transitions* tests as backlog (tier-2). r=hiro
Joel Maher <jmaher@mozilla.com> - Thu, 07 May 2020 09:44:02 +0000 - rev 592338
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1465776 - run css/css-variables/variable-transitions* tests as backlog (tier-2). r=hiro run css/css-variables/variable-transitions* tests as backlog (tier-2) Differential Revision: https://phabricator.services.mozilla.com/D74212
cb92328d2f9806eb6c1554eb21fed6fde0e4aa3c: Bug 1626570 - Improve handling of copying arrays in dom/animation/. r=hiro
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 05 May 2020 10:42:23 +0000 - rev 591843
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1626570 - Improve handling of copying arrays in dom/animation/. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D73642
e2d84b2e5a7e108ec12c1a293bb401fe78ef831b: Bug 1633276. Ensure that when IsFrameScrolledOutOfView calls nsLayoutUtils::TransformFrameRectToAncestor the ancestor frame is actually an ancestor. r=hiro
Timothy Nikkel <tnikkel@gmail.com> - Tue, 05 May 2020 07:19:46 +0000 - rev 591774
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1633276. Ensure that when IsFrameScrolledOutOfView calls nsLayoutUtils::TransformFrameRectToAncestor the ancestor frame is actually an ancestor. r=hiro The SCROLLABLE_FIXEDPOS_FINDS_ROOT flag makes GetNearestScrollableFrame return the root scroll frame for fixed pos frames. Fixed pos frames are direct children of the root _frame_, which means that the frame we pass to TransformFrameRectToAncestor are not ancestors of each other in either direction. Differential Revision: https://phabricator.services.mozilla.com/D73587
d4b281989ea6aded83371f294e56a3536424361d: Bug 1638773: Allow initial-scale clamping when user-scalable=no, add WPT. r=hiro, a=RyanVM
Brad Werth <bwerth@mozilla.com> - Wed, 20 May 2020 15:15:07 +0000 - rev 591548
Push 13173 by ryanvm@gmail.com at Thu, 21 May 2020 20:26:54 +0000
Bug 1638773: Allow initial-scale clamping when user-scalable=no, add WPT. r=hiro, a=RyanVM This corrects the handling of user-scalable=no to first clamp scale (whether specified or default) between min and max scales, then applies the resulting value to initial-scale, min and max. Differential Revision: https://phabricator.services.mozilla.com/D76056
d578f391630abbb18f9585ccf6ee5964be9331a1: Bug 1633276. Ensure that when IsFrameScrolledOutOfView calls nsLayoutUtils::TransformFrameRectToAncestor the ancestor frame is actually an ancestor. r=hiro
Timothy Nikkel <tnikkel@gmail.com> - Mon, 04 May 2020 02:32:43 +0000 - rev 591326
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1633276. Ensure that when IsFrameScrolledOutOfView calls nsLayoutUtils::TransformFrameRectToAncestor the ancestor frame is actually an ancestor. r=hiro The SCROLLABLE_FIXEDPOS_FINDS_ROOT flag makes GetNearestScrollableFrame return the root scroll frame for fixed pos frames. Fixed pos frames are direct children of the root _frame_, which means that the frame we pass to TransformFrameRectToAncestor are not ancestors of each other in either direction. So we treat fixed pos frames specially and don't pass that flag. Differential Revision: https://phabricator.services.mozilla.com/D73587
12014da3d9f1bbc66c4ae6daa2ec656d564a0c29: Bug 1598145 Part 3: Add a test of changed meta viewport tags. r=hiro
Brad Werth <bwerth@mozilla.com> - Thu, 30 Apr 2020 23:25:53 +0000 - rev 590876
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1598145 Part 3: Add a test of changed meta viewport tags. r=hiro This test checks several replaced meta viewport tags, exercising the code in MobileViewportManager that changes resolution to maintain the proportional amount of content visible in the display area as the viewport size changes. It also checks the shrink-to-fit behavior of pages with user-scalable=no. Differential Revision: https://phabricator.services.mozilla.com/D72762
483d819e358005169b68f6d68426517ac43877ac: Bug 1598145 Part 2: Make some more RDM test functions await reflow. r=mtigley,hiro
Brad Werth <bwerth@mozilla.com> - Thu, 30 Apr 2020 23:25:53 +0000 - rev 590875
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1598145 Part 2: Make some more RDM test functions await reflow. r=mtigley,hiro To reduce intermittents in RDM tests, setTouchAndMetaViewportSupport and spawnViewportTask now await reflow before resolving. Additionally an awaited reflow in setViewportSizeAndAwaitReflow was changed to use the standard method. Differential Revision: https://phabricator.services.mozilla.com/D72969
8981f51879216a0c6e3251dff16741123dfb5eed: Bug 1598145 Part 1: For user-scalable=no, force min and max zoom to match initial zoom, add WPT. r=hiro
Brad Werth <bwerth@mozilla.com> - Thu, 30 Apr 2020 23:25:53 +0000 - rev 590874
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1598145 Part 1: For user-scalable=no, force min and max zoom to match initial zoom, add WPT. r=hiro This provides web compatability with Chrome's interpretation of the spec at https://drafts.csswg.org/css-device-adapt/#user-zoom-desc. This changes makes us treat "the user cannot interactively change the zoom factor" as inclusive of ANY method of the user agent changing zoom levels, regardless of whether or not the user initiated an action. So, in addition to preventing things like double-tap-to-zoom and pinch-zoom, this change prevents zoom changes to fit all content into the viewport, or to maintain visible content proportionality if the viewport is resized dynamically. This also adds an assert to cases where Document::GetViewportInfo returns a viewport with a non-positive scale factor that it also sets the auto scale flag. This also adds a tentative web-platform test. Differential Revision: https://phabricator.services.mozilla.com/D72004
036714d0988bd81117136a141574a71f5181b657: Bug 1627326 - Provide more meaningful values for the stuck sides. r=botond,hiro
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 16 Apr 2020 03:21:06 +0000 - rev 587886
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1627326 - Provide more meaningful values for the stuck sides. r=botond,hiro As described in bug 1630274, this has some unfixed cases, but it should give good results in most real-world cases, where the magnitude of transient async scrolling is relatively low. Depends on D71083 Differential Revision: https://phabricator.services.mozilla.com/D71084