searching for reviewer(heycam)
c0c2da9127f3: Bug 1540385 - Fix revalidation in <svg:use> subtree. r=heycam a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 07 Apr 2019 16:59:42 +0300 - rev 523011
Push 11021 by nbeleuzu@mozilla.com at Sun, 07 Apr 2019 14:07:17 +0000
Bug 1540385 - Fix revalidation in <svg:use> subtree. r=heycam a=pascalc Summary: So as to avoid incorrectly sharing styles across elements. Reviewers: heycam Reviewed By: heycam Bug #: 1540385 Differential Revision: https://phabricator.services.mozilla.com/D25918
9174ce9e9471: Bug 1141387 - Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r=heycam, a=test-only
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 29 Mar 2019 05:58:25 +0000 - rev 522865
Push 10971 by ryanvm@gmail.com at Mon, 01 Apr 2019 13:55:07 +0000
Bug 1141387 - Set image.animation_mode=none to avoid the animated GIF is advanced to the next frame. r=heycam, a=test-only The animated GIF in background-blending-image-color-gif.html has two animation frames, the one is a red rectangle, the other is a green rectangle. The reftest is supposed to take the snapshot during the time where the animation frame is the red rectangle (the first frame) and the frame duration is 1000ms. So if we take over 1000ms there for some reasons, say on slow platforms, before taking the snapshot, the reftet fails. Differential Revision: https://phabricator.services.mozilla.com/D24843
1b8d74f0b43f: Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam, a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Mar 2019 09:50:51 +0000 - rev 522723
Push 10922 by ryanvm@gmail.com at Tue, 26 Mar 2019 15:06:46 +0000
Bug 1535612 - CSSKeyframeList::RemoveRule should clear parent references when removed. r=heycam, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D23729
5ce27c44f79e: Bug 1533783 - Avoid crashing when calling insertRule("@import ...") on a detached sheet. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Mar 2019 22:30:37 +0000 - rev 521983
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1533783 - Avoid crashing when calling insertRule("@import ...") on a detached sheet. r=heycam This should unblock the fuzzers for now, though it's not the ideal solution. It's the only reasonably easy solution to unblock them though, I think. We should probably always keep track of the document a stylesheet was associated with. We'll need that for constructible stylesheets anyway. That requires some though on how to get the cycle-collection and such right, though, and I wouldn't be able to write or land that ASAP. Differential Revision: https://phabricator.services.mozilla.com/D23584
5be153ff04f4: Bug 1533891 - Give up on optimizing out image loads load resolution for non-text. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Mar 2019 22:24:37 +0000 - rev 521979
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1533891 - Give up on optimizing out image loads load resolution for non-text. r=heycam ::first-line reparenting may make non-first continuations to get a new style on which we haven't run StartImageLoads when fragmenting out of the first-line. Given this was mostly an opportunistic optimization let's remove it rather than sacrificing correctness. With bug 1465474 we would be able to fix this... Differential Revision: https://phabricator.services.mozilla.com/D23525
8995d452cf89: Bug 1533963 - Use a single RestyleHint representation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Mar 2019 11:47:50 +0000 - rev 521872
Push 10870 by nbeleuzu@mozilla.com at Fri, 15 Mar 2019 20:00:07 +0000
Bug 1533963 - Use a single RestyleHint representation. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22828
5b275de602ae: Bug 1533424 - Don't allow InspectorUtils to mess up with our UA sheets. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Mar 2019 15:17:54 +0000 - rev 521549
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1533424 - Don't allow InspectorUtils to mess up with our UA sheets. r=heycam You can mess up stuff pretty badly if that happens, and we want to do this anyway for the shared UA sheet stuff, so... Differential Revision: https://phabricator.services.mozilla.com/D22554
b56791a96f96: Bug 1533424 - Don't allow InspectorUtils to mess up with our UA sheets. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 08 Mar 2019 13:54:11 +0000 - rev 521039
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533424 - Don't allow InspectorUtils to mess up with our UA sheets. r=heycam You can mess up stuff pretty badly if that happens, and we want to do this anyway for the shared UA sheet stuff, so... Differential Revision: https://phabricator.services.mozilla.com/D22554
1ae26ce1cf09: Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 11:59:36 +0000 - rev 520750
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles The only fishy bit is the animation stuff. In particular, there are two places where we just mint the revert behavior: * When serializing web-animations keyframes (the custom properties stuff in declaration_block.rs). That codepath is already not sound and I wanted to get rid of it in bug 1501530, but what do I know. * When getting an animation value from a property declaration. At that point we no longer have the CSS rules that apply to the element to compute the right revert value handy. It'd also use the wrong style anyway, I think, given the way StyleBuilder::for_animation works. We _could_ probably get them out of somewhere, but it seems like a whole lot of code reinventing the wheel which is probably not useful, and that Blink and WebKit just cannot implement either since they don't have a rule tree, so it just doesn't seem worth the churn. The custom properties code looks a bit different in order to minimize hash lookups in the common case. FWIW, `revert` for custom properties doesn't seem very useful either, but oh well. Differential Revision: https://phabricator.services.mozilla.com/D21877
49d30719700f: Bug 1533088: Initialize member-var FlexItem::mAlignSelfFlags to zero, in the legacy-box and 'visibility:collapse' FlexItem scenarios. r=heycam
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 06 Mar 2019 23:11:19 +0000 - rev 520667
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533088: Initialize member-var FlexItem::mAlignSelfFlags to zero, in the legacy-box and 'visibility:collapse' FlexItem scenarios. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22350
d34db0a03314: Bug 1532768 - Don't crash when given bad types to cssPropertySupportsType. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Mar 2019 20:50:19 +0000 - rev 520583
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532768 - Don't crash when given bad types to cssPropertySupportsType. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22222
6a337f639022: Bug 1532856 - Serialize radii with servo. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 06 Mar 2019 04:47:47 +0000 - rev 520481
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532856 - Serialize radii with servo. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22231
020e9abe510a: Bug 1528071 - Move `GetAtomBase`s into classes to avoid unified name conflict. r=heycam
David Major <dmajor@mozilla.com> - Wed, 06 Mar 2019 04:41:13 +0000 - rev 520480
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528071 - Move `GetAtomBase`s into classes to avoid unified name conflict. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D22013
0d659b1c6de3: Bug 1528071 - Add include guards to StaticAtoms.py r=heycam
David Major <dmajor@mozilla.com> - Wed, 06 Mar 2019 04:40:03 +0000 - rev 520472
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528071 - Add include guards to StaticAtoms.py r=heycam This will make the headers more unified-build-friendly. Differential Revision: https://phabricator.services.mozilla.com/D22012
9387009d5ec9: Bug 1532128 - layout/style: Remove unused functions Gecko_AnnotateCrashReport() and Gecko_AddBufferToCrashReport(). r=heycam
Chris Peterson <cpeterson@mozilla.com> - Sat, 02 Mar 2019 21:31:23 -0800 - rev 520410
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532128 - layout/style: Remove unused functions Gecko_AnnotateCrashReport() and Gecko_AddBufferToCrashReport(). r=heycam clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). The Gecko_*CrashReport() function definitions were added in bug 1407080. The function calls were removed in https://hg.mozilla.org/integration/autoland/rev/22f60f0b91ee. A clue that this function was no longer called: bug 1348273 changed the function prototype in GeckoBindings.h to take a uint32_t key parameter, but left the function definition in GeckoBindings.cpp taking a const char* key. And yet nothing blew up. layout/style/GeckoBindings.cpp:2294:6 [-Wmissing-prototypes] no previous prototype for function 'Gecko_AnnotateCrashReport' Differential Revision: https://phabricator.services.mozilla.com/D21852
f8fb6e47bb24: Bug 1524688: Part 52 - Convert WebVTT components to static registration. r=heycam
Kris Maglione <maglione.k@gmail.com> - Wed, 30 Jan 2019 11:31:25 -0800 - rev 519991
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524688: Part 52 - Convert WebVTT components to static registration. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D18462
635dd2d69386: Bug 1531582 - Don't drop the change hint for ContentStateChanged on the floor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Mar 2019 02:04:12 +0000 - rev 519812
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531582 - Don't drop the change hint for ContentStateChanged on the floor. r=heycam This doesn't matter yet because all the states that return a change hint are on stylesheets, but will matter with bug 1472637. Differential Revision: https://phabricator.services.mozilla.com/D21616
60128088f862: Bug 1531582 - Don't drop the change hint for ContentStateChanged on the floor. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Mar 2019 02:04:12 +0000 - rev 519731
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531582 - Don't drop the change hint for ContentStateChanged on the floor. r=heycam This doesn't matter yet because all the states that return a change hint are on stylesheets, but will matter with bug 1472637. Differential Revision: https://phabricator.services.mozilla.com/D21616
1a48f163c0f2: Bug 1530847 - Add a Zero trait that doesn't require Add, and use it in place of num_traits and IsZeroLength. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Feb 2019 19:03:03 +0000 - rev 519694
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530847 - Add a Zero trait that doesn't require Add, and use it in place of num_traits and IsZeroLength. r=heycam Use it to be consistent in InsetRect serialization and storage between Servo and Gecko. Differential Revision: https://phabricator.services.mozilla.com/D21493
17d59b664c0f: Bug 1530826 - Fix computed value clamping. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Feb 2019 23:34:25 +0000 - rev 519156
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530826 - Fix computed value clamping. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D21268
7754ccd4cb02: Bug 1520018: Add web-platform-test for table element's UA-stylesheet-provided CSS rules. r=heycam
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 26 Feb 2019 19:29:58 +0000 - rev 519131
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1520018: Add web-platform-test for table element's UA-stylesheet-provided CSS rules. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D20892
eff6eff2d385: Bug 1277437 - part5 : apply default style on cue when we don't use pseudo element. r=heycam
Alastor Wu <alwu@mozilla.com> - Thu, 21 Feb 2019 19:34:51 +0000 - rev 518551
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1277437 - part5 : apply default style on cue when we don't use pseudo element. r=heycam If cue div is not a pseudo element, which means we don't have a default style applying on it. Therefore, we should set the default css style for it. Differential Revision: https://phabricator.services.mozilla.com/D19864
b6a5f3dc8878: Bug 1277437 - part4 : change font size internally in CueStyleBox. r=heycam
Alastor Wu <alwu@mozilla.com> - Tue, 19 Feb 2019 16:04:38 +0000 - rev 518550
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1277437 - part4 : change font size internally in CueStyleBox. r=heycam CueStyleBox should handle all css attributes, so it make more sense to adjust font size and style inside CueStyleBox. Differential Revision: https://phabricator.services.mozilla.com/D19719
f21dc82d9ba7: Bug 1277437 - part3 : apply WebVTT cue settings. r=heycam
Alastor Wu <alwu@mozilla.com> - Tue, 19 Feb 2019 22:23:10 +0000 - rev 518549
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1277437 - part3 : apply WebVTT cue settings. r=heycam Follow the spec 7.2 [1] and 7.4 [2] to process cue and apply css setting for the div element. [1] https://www.w3.org/TR/webvtt1/#processing-cue-settings [2] https://www.w3.org/TR/webvtt1/#applying-css-properties Differential Revision: https://phabricator.services.mozilla.com/D19253
45a5af08e7f6: Bug 1277437 - part2 : make CueStyleBox class-based. r=heycam
alwu <alwu@mozilla.com> - Tue, 19 Feb 2019 14:25:33 +0000 - rev 518548
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1277437 - part2 : make CueStyleBox class-based. r=heycam Using class syntax for CueStyleBox made us easier to simplify the code and make it more readable. Differential Revision: https://phabricator.services.mozilla.com/D19252
797abfd47a05: Bug 1277437 - part1 : remove UA agent checkings. r=heycam
alwu <alwu@mozilla.com> - Thu, 14 Feb 2019 07:01:42 +0000 - rev 518547
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1277437 - part1 : remove UA agent checkings. r=heycam There is no need to check whether the code is running on other browser, because we won't upstream the change back to the github repo, as this code uses a lots mozilla-only APIs. Differential Revision: https://phabricator.services.mozilla.com/D19251
738bb0805a9c: Bug 1525775 - [css-mediaqueries] Synthesize a value for eIntID_SystemUsesDarkTheme to determine if GTK are using a light or dark theme. r=heycam,karlt
Mats Palmgren <mats@mozilla.com> - Thu, 21 Feb 2019 09:12:35 +0100 - rev 518081
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525775 - [css-mediaqueries] Synthesize a value for eIntID_SystemUsesDarkTheme to determine if GTK are using a light or dark theme. r=heycam,karlt
2bbbcf59d8f9: Bug 1528451 - Move code that starts image loads to DidSetComputedStyle. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Feb 2019 00:40:10 +0000 - rev 517765
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528451 - Move code that starts image loads to DidSetComputedStyle. r=heycam This is more consistent with all the other image request code, and handles pseudo-elements properly without having to add more out-of-band calls to UpdateStyleOfOwnedChildFrame and such. Differential Revision: https://phabricator.services.mozilla.com/D20107
533f35feb9eb: Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Feb 2019 11:17:28 +0000 - rev 517763
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D20141
1fc71d46c09a: Bug 1525955 - Include anon boxes in CSSPseudoElementType, to remove ComputedStyle::mPseudoTag. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Feb 2019 13:44:33 +0000 - rev 517762
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525955 - Include anon boxes in CSSPseudoElementType, to remove ComputedStyle::mPseudoTag. r=heycam This is more consistent with what the Rust bits of the style system do, and removes a pointer from ComputedStyle which is always nice. This also aligns the Rust bits with the C++ bits re. not treating xul pseudos as anonymous boxes. See the comment in nsTreeStyleCache.cpp regarding those. Can't wait for XUL trees to die. Depends on D19001 Differential Revision: https://phabricator.services.mozilla.com/D19002
d981515b874b: Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Feb 2019 11:17:28 +0000 - rev 517749
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D20141
d33544f0d8e6: Bug 1528451 - Move code that starts image loads to DidSetComputedStyle. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Feb 2019 00:40:10 +0000 - rev 517737
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528451 - Move code that starts image loads to DidSetComputedStyle. r=heycam This is more consistent with all the other image request code, and handles pseudo-elements properly without having to add more out-of-band calls to UpdateStyleOfOwnedChildFrame and such. Differential Revision: https://phabricator.services.mozilla.com/D20107
133509097b7c: Bug 1525775 - [css-mediaqueries] Synthesize a value for eIntID_SystemUsesDarkTheme to determine if GTK are using a light or dark theme. r=heycam,karlt
Mats Palmgren <mats@mozilla.com> - Mon, 18 Feb 2019 18:17:10 +0100 - rev 517704
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525775 - [css-mediaqueries] Synthesize a value for eIntID_SystemUsesDarkTheme to determine if GTK are using a light or dark theme. r=heycam,karlt
22e77b65286a: Bug 1528613 - Downgrade two assertions from release assert for now. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Feb 2019 00:30:17 +0000 - rev 517601
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528613 - Downgrade two assertions from release assert for now. r=heycam These assertions can happen in certain circumstances (see the referenced bug). These assertions are not security sensitive, but they affect correctness. They're old (from before my change), so I prefer dealing with them in a public bug and stop crashing release for now. Differential Revision: https://phabricator.services.mozilla.com/D20105
795f2e303548: Bug 1527410 - Preserve calc() rounding behavior. r=heycam,jrmuizel
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Feb 2019 23:27:23 +0100 - rev 517408
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527410 - Preserve calc() rounding behavior. r=heycam,jrmuizel See the comment. I don't really this is ideal, I filed bug 1528114 to investigate changing that. Differential Revision: https://phabricator.services.mozilla.com/D19584
51d4957627fb: Bug 1526736 - Rename MozLength to Size, and MaxLength to MaxSize. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Feb 2019 10:59:49 +0000 - rev 516352
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1526736 - Rename MozLength to Size, and MaxLength to MaxSize. r=heycam MozLength is not a very descriptive name. If we're going to use it in both Gecko and Servo we may as well name it something more accurate. I would've chosen `ContentSize` per CSS2[1][2] if it wasn't a lie in presence of box-sizing. I don't have better ideas than `Size`, given that. [1]: https://drafts.csswg.org/css2/visudet.html#propdef-width [2]: https://drafts.csswg.org/css2/box.html#content-width Differential Revision: https://phabricator.services.mozilla.com/D19280
724ed6f24523: Bug 1526216 - Add a null-check for mChannel in nsFontFaceLoader::Cancel. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Feb 2019 02:10:52 +0000 - rev 516349
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1526216 - Add a null-check for mChannel in nsFontFaceLoader::Cancel. r=heycam If there's no channel the request is over and the Cancel() call would be a no-op anyway. Differential Revision: https://phabricator.services.mozilla.com/D19311
5a44200105e2: Bug 1485266 - Use stand-ins for native colors when RFP is enabled r=heycam
Liang-Heng Chen <xeonchen@gmail.com> - Wed, 06 Feb 2019 08:45:44 +0000 - rev 515269
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1485266 - Use stand-ins for native colors when RFP is enabled r=heycam Differential Revision: https://phabricator.services.mozilla.com/D17755
241a3659869b: Bug 1524220 - Mark 'document.documentElement.clientHeight + 200' test case fail. r=heycam
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 05 Feb 2019 23:52:24 +0000 - rev 515223
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524220 - Mark 'document.documentElement.clientHeight + 200' test case fail. r=heycam All of failure test cases in root-margin.html will be fixed by this PR https://github.com/web-platform-tests/wpt/pull/15254 . Differential Revision: https://phabricator.services.mozilla.com/D18760
6b71e3d434c2: Bug 1525134 - Move image loads out of the style struct accessors. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 19:47:29 +0000 - rev 515191
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525134 - Move image loads out of the style struct accessors. r=heycam After this I can pass the document from the caller to ResolveSameStructsAs, and get rid of the pres context pointer. Differential Revision: https://phabricator.services.mozilla.com/D18600
919de32d4905: Bug 1525134 - Move image loads out of the style struct accessors. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Feb 2019 18:57:50 +0100 - rev 514679
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525134 - Move image loads out of the style struct accessors. r=heycam After this I can pass the document from the caller to ResolveSameStructsAs, and get rid of the pres context pointer. Differential Revision: https://phabricator.services.mozilla.com/D18600
992f27cfecac: Bug 1525134 - Move image loads out of the style struct accessors. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Feb 2019 13:45:04 +0000 - rev 514661
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525134 - Move image loads out of the style struct accessors. r=heycam After this I can pass the document from the caller to ResolveSameStructsAs, and get rid of the pres context pointer. Differential Revision: https://phabricator.services.mozilla.com/D18600
6c01930800a7: Bug 1528613 - Downgrade two assertions from release assert for now. r=heycam, a=lizzard
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Feb 2019 00:30:17 +0000 - rev 513168
Push 10741 by ryanvm@gmail.com at Wed, 20 Feb 2019 23:45:30 +0000
Bug 1528613 - Downgrade two assertions from release assert for now. r=heycam, a=lizzard These assertions can happen in certain circumstances (see the referenced bug). These assertions are not security sensitive, but they affect correctness. They're old (from before my change), so I prefer dealing with them in a public bug and stop crashing release for now. Differential Revision: https://phabricator.services.mozilla.com/D20105
f8aadf41dcd0: Bug 1523181 - Don't implicitly flush the user font set. r=heycam, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 27 Jan 2019 16:30:38 +0100 - rev 512927
Push 10644 by ryanvm@gmail.com at Thu, 07 Feb 2019 15:29:46 +0000
Bug 1523181 - Don't implicitly flush the user font set. r=heycam, a=RyanVM Summary: Flushing it at a bad time can cancel loads whose timer / completion handler is in progress, which makes no sense. Reviewers: jfkthame, jwatt, heycam Tags: #secure-revision Bug #: 1523181 Differential Revision: https://phabricator.services.mozilla.com/D17856
9820006aa8fb: Bug 1521405 - Cleanup a few shorthand properties. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 Jan 2019 17:38:55 +0100 - rev 512266
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1521405 - Cleanup a few shorthand properties. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D17082
1a43fcfbf783: Bug 1521137 - Remove another font API outside of the pres context. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 22 Jan 2019 15:52:41 +0100 - rev 511949
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1521137 - Remove another font API outside of the pres context. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D17005
39f5f9728b69: Bug 1521137 - The pres context's base min font size is dead code. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 21 Jan 2019 07:15:02 +0000 - rev 511903
Push 10563 by archaeopteryx@coole-files.de at Thu, 24 Jan 2019 17:31:37 +0000
Bug 1521137 - The pres context's base min font size is dead code. r=heycam Nobody uses it from js, and we only thread the value around in layout. Let's kill all this code. Differential Revision: https://phabricator.services.mozilla.com/D16999
e9570ad88e6d: Bug 1519918 - Make nsFontFaceLoader::mFontFaceSet a weak reference. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 21 Jan 2019 11:10:26 +0000 - rev 511799
Push 10563 by archaeopteryx@coole-files.de at Thu, 24 Jan 2019 17:31:37 +0000
Bug 1519918 - Make nsFontFaceLoader::mFontFaceSet a weak reference. r=heycam And start tracking the loader ASAP to be on the safe side. Both sides already take care of cleaning up pointers on destruction. Differential Revision: https://phabricator.services.mozilla.com/D16514
8a7ab9b279fe: Bug 1519501 - Generalize a bit GenerateServoStyleConsts and rename to RunCbindgen. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 13 Jan 2019 00:42:48 +0100 - rev 510817
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1519501 - Generalize a bit GenerateServoStyleConsts and rename to RunCbindgen. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D16399
472bcde2c2d1: Bug 1518954 - Three-value position syntax uses calc() as its computed value representation. r=heycam
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 11 Jan 2019 01:07:22 +0100 - rev 510483
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1518954 - Three-value position syntax uses calc() as its computed value representation. r=heycam This restores the previous behavior of using calc(). Note that background-position / object-position, which test this, weren't hitting the assertion because they use another codepath. I didn't add more extensive tests for this because it's well tested for those two properties, and because this is legacy anyway, see the comment in the test. I did add the assertion to the codepath those two properties hit. Differential Revision: https://phabricator.services.mozilla.com/D16176