searching for reviewer(glandium)
6bb3ced4069304320bd3f68d5bdf213b9ecf8ee0: Bug 1801557 - import xsimd to third_party r=glandium
serge-sans-paille <sguelton@mozilla.com> - Fri, 13 Jan 2023 13:31:43 +0000 - rev 720979
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801557 - import xsimd to third_party r=glandium Differential Revision: https://phabricator.services.mozilla.com/D162537
8d257906dafbccbf25ed4cef1fc90bb4f625b6d9: Bug 1804280 - Refactor cargo subcommands in rust.mk. r=glandium
Arthur Carcano <arthur.carcano@ocamlpro.com> - Wed, 11 Jan 2023 04:12:41 +0000 - rev 720779
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804280 - Refactor cargo subcommands in rust.mk. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D163956
16b643d610fcae9bec27a852148f47943a66c4f1: Bug 1806049 - Explicitly use uint32_t r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 10 Jan 2023 22:30:05 +0000 - rev 720769
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806049 - Explicitly use uint32_t r=glandium We want to be precise about types used here. Although in practice unsigned is the same as uint32_t, it's not guaranteed. We want to definitely use 32-bit multiplication as it can be faster than 64-bit. Differential Revision: https://phabricator.services.mozilla.com/D164889
3b565e52fea884e7afe3de6f1d02304ca90ef37a: Bug 1806049 - Test all divisions r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 10 Jan 2023 22:30:05 +0000 - rev 720768
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806049 - Test all divisions r=glandium Don't wait until runtime to test that all valid divisions work. Test them during initialisation in debug builds. Differential Revision: https://phabricator.services.mozilla.com/D164888
f969998c988e89dd38c94ec79705f643ff5703a9: Bug 1806049 - Rename the FastDivisor variables r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 10 Jan 2023 22:30:04 +0000 - rev 720767
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806049 - Rename the FastDivisor variables r=glandium Rename the `m` and `p` variables to match those used in the Hacker's Delight book where the algorithm is presented. There were also some inconsistent names in comments that this fixes. Differential Revision: https://phabricator.services.mozilla.com/D164887
18d20db4c000bbe730af569c43000cbf30767fde: Bug 1806049 - Improve some code comments r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 10 Jan 2023 22:30:04 +0000 - rev 720766
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806049 - Improve some code comments r=glandium Differential Revision: https://phabricator.services.mozilla.com/D164886
404e1b833ec6ae498e69a9882883c5e5b2ef1ba8: Bug 1793784 - Replace the minidump_writer_linux crate with the minidump-writer crate r=glandium,supply-chain-reviewers
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 10 Jan 2023 22:14:30 +0000 - rev 720764
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1793784 - Replace the minidump_writer_linux crate with the minidump-writer crate r=glandium,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D158669
49c08aab962229ff80af9097dee7b6070ed9ac3a: Bug 1801557 - import xsimd to third_party r=glandium
serge-sans-paille <sguelton@mozilla.com> - Tue, 10 Jan 2023 10:22:33 +0000 - rev 720664
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801557 - import xsimd to third_party r=glandium Differential Revision: https://phabricator.services.mozilla.com/D162537
781b133ca6612db579e249daa800d30662552187: Bug 1806727 - Add an option to easily build with release configuration. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Jan 2023 09:27:26 +0000 - rev 720657
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806727 - Add an option to easily build with release configuration. r=glandium This doesn't build with release branding, but allows you to create a nightly build that has all the settings that we have on release, which will be useful for profiling. I could use --enable-release with a bit of effort, if you prefer (probably renaming the current version of --enable-release to something else). All-in-all, suggestions welcome on this approach. Differential Revision: https://phabricator.services.mozilla.com/D165219
5d265c462faf3196191a2ccf8fa9efda88dc0487: Bug 1801557 - import xsimd to third_party r=glandium
serge-sans-paille <sguelton@mozilla.com> - Thu, 05 Jan 2023 21:08:15 +0000 - rev 720313
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801557 - import xsimd to third_party r=glandium Differential Revision: https://phabricator.services.mozilla.com/D162537
cccb159a5b46d4c2a446010f6f50b5b5c9c92993: Bug 1801557 - import xsimd to third_party r=glandium
serge-sans-paille <sguelton@mozilla.com> - Wed, 04 Jan 2023 15:44:31 +0000 - rev 720062
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801557 - import xsimd to third_party r=glandium Differential Revision: https://phabricator.services.mozilla.com/D162537
a5df6a127e9d8117232ec8bc35ba4600ef0e21f3: Bug 1805371 - avoid building and running FaultyServer tests with system NSS. r=glandium,necko-reviewers,kershaw
John Schanck <jschanck@mozilla.com> - Tue, 03 Jan 2023 17:48:24 +0000 - rev 719929
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805371 - avoid building and running FaultyServer tests with system NSS. r=glandium,necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D164952
5e99a63a268e18810cb3c716efe2b10930c2ae91: Bug 1806123 - Refactoring upload_symbols.py r=glandium
Ben Dean-Kawamura <bdk@mozilla.com> - Fri, 30 Dec 2022 23:37:55 +0000 - rev 719790
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806123 - Refactoring upload_symbols.py r=glandium The functionality is the same, but the code is now split into several functions. This is preparation for more changes to fix bug 1806123. Differential Revision: https://phabricator.services.mozilla.com/D165035
7d5af3448aa453cd2889b42eb569c9e3456436a4: Bug 1807969 - upgrade aiohttp to 3.7.4 in condprof requirements to support new windows builder machine. r=glandium,perftest-reviewers,afinder
Joel Maher <jmaher@mozilla.com> - Fri, 30 Dec 2022 13:53:51 +0000 - rev 719759
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807969 - upgrade aiohttp to 3.7.4 in condprof requirements to support new windows builder machine. r=glandium,perftest-reviewers,afinder Differential Revision: https://phabricator.services.mozilla.com/D165694
cc0a32cc3b361f6fd6f4c39a650e3cf92af26d12: Bug 1806091 - patch clang to work with latest win11. r=glandium
Joel Maher <jmaher@mozilla.com> - Thu, 29 Dec 2022 18:08:58 +0000 - rev 719720
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806091 - patch clang to work with latest win11. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D165555
24214ef6895fa5e42b4cb3abb1ddb09e8bf5ec9b: Bug 1806736 - Wrap `.egg-info` deletion in a try to handle the scenario where a VCS isn't installed r=firefox-build-system-reviewers,glandium
ahochheiden <ahochheiden@mozilla.com> - Thu, 29 Dec 2022 11:39:40 +0000 - rev 719706
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806736 - Wrap `.egg-info` deletion in a try to handle the scenario where a VCS isn't installed r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D165576
8217148f9d5c81a324c13a64dfb853d2bc186e4a: Bug 1807012 - Fix detection of lld-link under windows r=glandium
serge-sans-paille <sguelton@mozilla.com> - Tue, 27 Dec 2022 22:37:47 +0000 - rev 719617
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807012 - Fix detection of lld-link under windows r=glandium Backport of https://reviews.llvm.org/D140534 Differential Revision: https://phabricator.services.mozilla.com/D165406
f75b763d17e0eb993ee6df7d772eb9956c05fff9: Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 23 Dec 2022 22:45:46 +0000 - rev 719506
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D165395
c0d8167d9801773de218bd0a82d3bd6a87e5f44a: Bug 1771075 - Enable C++20 -Wvolatile warnings. r=firefox-build-system-reviewers,glandium
Chris Peterson <cpeterson@mozilla.com> - Fri, 23 Dec 2022 03:27:37 +0000 - rev 719440
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1771075 - Enable C++20 -Wvolatile warnings. r=firefox-build-system-reviewers,glandium We can enable C++20 -Wvolatile warnings in gcc before we compile as -std=c++20, but not in clang. These warnings will be enabled by default with gcc and clang -std=c++20, so we won't need to explicitly enable -Wvolatile after we're compiling as -std=c++20. Differential Revision: https://phabricator.services.mozilla.com/D165380
b42c0644448cfaa39758d87060f70499abd700e0: Bug 1801836 - Remove no longer necessary 'from __future__' imports under python/. r=linter-reviewers,glandium,ahal DONTBUILD
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 23 Dec 2022 01:26:15 +0000 - rev 719435
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1801836 - Remove no longer necessary 'from __future__' imports under python/. r=linter-reviewers,glandium,ahal DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D165398
2d70bc3a42e38a539736e9856bd7e9f1e6e968a0: Bug 1806779 - Fix C++20 -Wdeprecated-volatile warnings in mfbt/SHA1.cpp. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Thu, 22 Dec 2022 02:58:24 +0000 - rev 719351
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806779 - Fix C++20 -Wdeprecated-volatile warnings in mfbt/SHA1.cpp. r=glandium C++20 deprecated decrement/increment of object of volatile-qualified types, e.g. v++. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1152r3.html mfbt/SHA1.cpp:400:9 [-Wdeprecated-volatile] compound assignment to object of volatile-qualified type 'volatile unsigned int' is deprecated mfbt/SHA1.cpp:401:9 [-Wdeprecated-volatile] compound assignment to object of volatile-qualified type 'volatile unsigned int' is deprecated mfbt/SHA1.cpp:402:9 [-Wdeprecated-volatile] compound assignment to object of volatile-qualified type 'volatile unsigned int' is deprecated mfbt/SHA1.cpp:403:9 [-Wdeprecated-volatile] compound assignment to object of volatile-qualified type 'volatile unsigned int' is deprecated mfbt/SHA1.cpp:404:9 [-Wdeprecated-volatile] compound assignment to object of volatile-qualified type 'volatile unsigned int' is deprecated shaCompress() has a comment emphasizing the importance of the X array being volatile. I verified that changing `XH(0) += A` to `XH(0) = XH(0) + A` generates the same -S assembly code (for clang -O2 on Apple Silicon). Whether this comment about the volatile code generated by gcc 3.4.3 -O3 in 2012 is still relevant for clang 15 -O2 in 2023 is a different question. Differential Revision: https://phabricator.services.mozilla.com/D165268
8b644e9165899a061c853e0959a314f1e3cccab3: Bug 1752703 - Move the pthread_thread_create() interposer under mozglue and prepare for having a single place where we place interposer functions r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 21 Dec 2022 10:24:41 +0000 - rev 719103
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1752703 - Move the pthread_thread_create() interposer under mozglue and prepare for having a single place where we place interposer functions r=glandium Differential Revision: https://phabricator.services.mozilla.com/D164470
7ce0022995741c7b33ae30aeb3e47204c64b913b: Bug 1804178 - [6/6] Switch from pytoml to toml in (almost) all other contexts r=firefox-build-system-reviewers,releng-reviewers,glandium,ahal
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:26 +0000 - rev 719072
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [6/6] Switch from pytoml to toml in (almost) all other contexts r=firefox-build-system-reviewers,releng-reviewers,glandium,ahal Convert all other imports of `pytoml` within mozilla-central to imports of `toml`. As both libraries patterned their API on that of the Python standard- library module `json`, this is mostly a straight replace, with two caveats: * pytoml's exception messages when loading a file provide the file name; toml's do not. Some additional machinery has been added or repurposed in a few places to ensure that the relevant filename is printed. * In `python_lockfile.py`, the order of arguments to `dump` needed to be reversed. (`toml` follows `json` in this; `pytoml` differs.) This patchset does not remove pytoml from `requirements.in`, as `pytoml` is still used by `compare-locales`. Differential Revision: https://phabricator.services.mozilla.com/D164155
56746370d08e429fc7e3697cff24e1395722cf3c: Bug 1804178 - [5/6] Remove regex-based license-scraping hackery r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:26 +0000 - rev 719071
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [5/6] Remove regex-based license-scraping hackery r=glandium `pytoml` could not handle single-quoted keys in table names, as these were added in TOML v0.5.0; but `toml` has no problem with them. Remove regex-based scraping of Cargo.toml files to find a crate's associated license, replacing it with `toml.load`. (This has been manually tested to ensure that dependencies with noncompliant licenses or unrecognized license files continue to be rejected.) Differential Revision: https://phabricator.services.mozilla.com/D164154
4aa38981a7114298220df812842dd29f70a80727: Bug 1804178 - [4/6] Remove pytoml output postprocessing r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:25 +0000 - rev 719070
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [4/6] Remove pytoml output postprocessing r=glandium The postprocessing phase that cleaned up `pytoml`'s output has little effect on `toml`'s output, which is already largely clean. Remove the additional code. Differential Revision: https://phabricator.services.mozilla.com/D164153
f8cf90fc83b85a78aa4fac4b8c93801b2284687f: Bug 1804178 - [3/6] Remove explicit sorting of TOML output r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:25 +0000 - rev 719069
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [3/6] Remove explicit sorting of TOML output r=glandium Remove explicit sorting, as this is no longer needed to guarantee determinism as of Python 3.6 (our minimum-supported version). (This is a separate commit solely to make it clear that the reordering of `.cargo/config.in` is indeed merely a reordering and contains no hidden functional changes.) Differential Revision: https://phabricator.services.mozilla.com/D164152
d2acef30c80318a3b7e7cd2c2182b66ec3786355: Bug 1804178 - [2/6] Convert use of `pytoml` to `toml` in vendor_rust.py r=glandium
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:25 +0000 - rev 719068
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [2/6] Convert use of `pytoml` to `toml` in vendor_rust.py r=glandium Replace `pytoml` with `toml` in `vendor_rust.py`. This is a minimal substitution that preserves existing behavior (along with a flake8 lint pass). Further simplification will follow in upcoming commits. In particular, we temporarily alter `recursive_sort` to ensure that the output of `pytoml` and `toml` are identical, rather than merely equivalent. (`pytoml` would reverse the ordering of keys in some contexts.) Differential Revision: https://phabricator.services.mozilla.com/D164151
903be63b308cd752119bc6d090225c26fc26d96e: Bug 1804178 - [1/6] Add `toml` to mach requirements r=firefox-build-system-reviewers,glandium
Ray Kraesig <rkraesig@mozilla.com> - Tue, 20 Dec 2022 23:01:24 +0000 - rev 719067
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804178 - [1/6] Add `toml` to mach requirements r=firefox-build-system-reviewers,glandium The `pytoml` library is abandoned, and does not support TOML v0.5.0, which Cargo uses. This prevents mach from properly parsing many Cargo.toml files. Include the `toml` library as a slightly more modern and currently- maintained alternative for use in mach. Supply-chain notes: - toml v0.10.2 is MIT-licensed, which is an approved MPL-compatible license. - I have personally audited this version of `toml` and consider it "safe-to-run", as much as any Python code can be: other than opening and reading/writing a file when specifically requested via `load`/ `dump` respectively, it performs only string manipulation and ordinary object creation. Differential Revision: https://phabricator.services.mozilla.com/D164150
9275ff4a79534c0eacd4fdddc89abe4368301f12: Bug 1806222 - Set llvm-symbolizer path for TSAN cpptests & gtests. r=glandium
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 20 Dec 2022 14:25:34 +0000 - rev 718993
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806222 - Set llvm-symbolizer path for TSAN cpptests & gtests. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D164960
afbd8f7148043d1fde87fd73041972e790dc46d2: Bug 1752703 - Add interposers for functions manipulating the environment to prevent crashes r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 20 Dec 2022 08:07:37 +0000 - rev 718956
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1752703 - Add interposers for functions manipulating the environment to prevent crashes r=glandium This add interposers for getenv(), putenv(), setenv(), unsetenv() and clearenv(). All interposers use a single lock for synchronization while internally using the libc-provided functions. This is done to prevent races that typically happen in Firefox code when multiple threads call getenv() while others are changing variables using setenv() and putenv(). Differential Revision: https://phabricator.services.mozilla.com/D164471
1adb41e2eb9b475e4afcdb3b70c05f7027d27709: Bug 1752703 - Move the pthread_thread_create() interposer under mozglue and prepare for having a single place where we place interposer functions r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Tue, 20 Dec 2022 08:07:37 +0000 - rev 718955
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1752703 - Move the pthread_thread_create() interposer under mozglue and prepare for having a single place where we place interposer functions r=glandium Differential Revision: https://phabricator.services.mozilla.com/D164470
dfa48aee03e5c7595261c34e38f0f485388c5c4c: Bug 1806497 - Update node to v16.19.0. r=firefox-build-system-reviewers,glandium
Mark Banner <standard8@mozilla.com> - Tue, 20 Dec 2022 07:56:04 +0000 - rev 718954
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806497 - Update node to v16.19.0. r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D165065
b47bdbd89fd40a69d4dee7167758e0169f6a8512: Bug 1805685 - Don't start source-test-clang-tidy task for header files. r=glandium
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Tue, 20 Dec 2022 07:31:25 +0000 - rev 718947
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805685 - Don't start source-test-clang-tidy task for header files. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D164684
b1c44a7274c50230f24862772d1c204e82d938a3: Bug 1805427 - Update Glean to 52.0.0, uuid to 1.0 r=glandium,janerik,webdriver-reviewers,supply-chain-reviewers
Chris H-C <chutten@mozilla.com> - Thu, 15 Dec 2022 14:04:54 +0000 - rev 718271
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805427 - Update Glean to 52.0.0, uuid to 1.0 r=glandium,janerik,webdriver-reviewers,supply-chain-reviewers Depends on D164603 Differential Revision: https://phabricator.services.mozilla.com/D164604
7ff758e0d08b4bdf0ce3bd2abe84a1bff3be8ff4: Bug 1799423 - link clang with lld r=firefox-build-system-reviewers,glandium
serge-sans-paille <sguelton@mozilla.com> - Wed, 14 Dec 2022 07:56:22 +0000 - rev 718118
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1799423 - link clang with lld r=firefox-build-system-reviewers,glandium As a side effect, this obsoletes the "link" config as clang always uses the lld linker alongside its own install. Differential Revision: https://phabricator.services.mozilla.com/D161436
72ad95ef4cdeb54e39d4fc41494cf30398c86918: Bug 1743322 - Make arena_bin_t 32 or 48 bytes long r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 13 Dec 2022 04:21:15 +0000 - rev 717932
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1743322 - Make arena_bin_t 32 or 48 bytes long r=glandium This structure is more optimal if it is somewhat aligned with the system's cache line length (which we assume is 64 bytes but that's not always true). This reduces the number of cache lines required to access one record on average. On 32-bit systems we can manage 32-bytes, on 64-bit systems we can manage 48 bytes. We do this by: * Make mRunSize the number of pages in a run rather than bytes, so that it can be stored in a single byte and save some space in bin headers. * Make mNumRuns a uint32_t on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D140036
3a6e4adf6853af7a7e1df0a492fb67fdcb8de63d: Bug 1743322 - Remove branches that decide how to divide r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 13 Dec 2022 04:21:15 +0000 - rev 717931
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1743322 - Remove branches that decide how to divide r=glandium This code path would choose from several ways about how to divide numbers. By calculating the inverse of the divisor early we can elude all the branches along this code path we can make it faster than the previous code or naive division. Differential Revision: https://phabricator.services.mozilla.com/D132322
b90142a28026c05ca12df82b95a315f87696bf74: Bug 1804375 - Re-enable clang -Wnull-dereference warnings in gtest. r=firefox-build-system-reviewers,glandium
Chris Peterson <cpeterson@mozilla.com> - Tue, 13 Dec 2022 03:57:35 +0000 - rev 717929
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804375 - Re-enable clang -Wnull-dereference warnings in gtest. r=firefox-build-system-reviewers,glandium Bug 1324242 disabled clang's -Wnull-dereference warnings in gtest code, but this warning can be re-enabled because the current version of gtest doesn't trigger these warnings. Differential Revision: https://phabricator.services.mozilla.com/D164027
5a65f0968b513247aa44f2e365cb924d98f75a4d: Bug 1803831 - [ci] Migrate 'valgrind' tasks from AWS -> GCP, r=MasterWayZ,ahal,glandium
Julien Cristau <jcristau@mozilla.com> - Mon, 12 Dec 2022 10:02:39 +0000 - rev 717653
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1803831 - [ci] Migrate 'valgrind' tasks from AWS -> GCP, r=MasterWayZ,ahal,glandium For some reason when running on b-linux-gcp workers, valgrind crashes, but it runs OK on t-linux-kvm-gcp, so use that. Differential Revision: https://phabricator.services.mozilla.com/D164090
25b323cc633b9153af06a672419a144f01ace40d: Bug 1805371 - avoid building and running FaultyServer tests with system NSS. r=glandium,necko-reviewers,kershaw a=RyanVM
John Schanck <jschanck@mozilla.com> - Tue, 03 Jan 2023 17:48:24 +0000 - rev 717623
Push 17423 by ryanvm@gmail.com at Wed, 04 Jan 2023 21:34:57 +0000
Bug 1805371 - avoid building and running FaultyServer tests with system NSS. r=glandium,necko-reviewers,kershaw a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D164952
79025940a6a6a48860c8f9b340d026e414544d8e: Bug 1799423 - link clang with lld r=firefox-build-system-reviewers,glandium
serge-sans-paille <sguelton@mozilla.com> - Thu, 08 Dec 2022 05:09:48 +0000 - rev 717013
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1799423 - link clang with lld r=firefox-build-system-reviewers,glandium As a side effect, this obsoletes the "link" config as clang always uses the lld linker alongside its own install. Differential Revision: https://phabricator.services.mozilla.com/D161436
6f64f678e2345b16191649df82d5d9f8720464c2: Bug 1803557 - Refactor cargo subcommands in mach_commands.py. r=glandium
Arthur Carcano <arthur.carcano@ocamlpro.com> - Wed, 07 Dec 2022 06:07:22 +0000 - rev 716853
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1803557 - Refactor cargo subcommands in mach_commands.py. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D163588
d0cc0efe7b232fed2a07250489cc6c3976d173f5: Bug 1804251 - Update debian-11 docker image r=glandium
serge-sans-paille <sguelton@mozilla.com> - Wed, 07 Dec 2022 05:09:30 +0000 - rev 716852
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1804251 - Update debian-11 docker image r=glandium - Update base snapshot - Upgrade to clang-13 and add lld-13 as a preliminary step for https://bugzilla.mozilla.org/show_bug.cgi?id=1799423 Differential Revision: https://phabricator.services.mozilla.com/D163945
e355b3e2a15c6b782e9ac13ce939cc9304ff0776: Bug 1801381 - Disable run_configure for mac repackaging r=glandium
Heitor Neiva <hneiva@mozilla.com> - Tue, 06 Dec 2022 21:11:43 +0000 - rev 716823
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1801381 - Disable run_configure for mac repackaging r=glandium Switches from `buildconfig.substs` to `bootstrap_toolchain` for the repackage job Refactors mozpack/dmg to not depend on the environment; Moves path resolution of tools up to `mozbuild.action.{make_dmg|unpack_dmg}` Update syntax to python 3.7+ Differential Revision: https://phabricator.services.mozilla.com/D163129
ba5d28166805f07d300686dacc8212eac18e93a1: Bug 840706 - Part 1: Add MFBT_API annotations to other methods in StringToDoubleConverter, r=glandium
Nika Layzell <nika@thelayzells.com> - Tue, 06 Dec 2022 20:27:49 +0000 - rev 716813
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 840706 - Part 1: Add MFBT_API annotations to other methods in StringToDoubleConverter, r=glandium The annotations added in bug 1770158 only covered `StringToDouble`, however as noted in the comments in that file, that isn't sufficient for accurately parsing floating point numbers. This patch extends the annotations to the single-precision floating point numbers as well and will be used in the next part to clean up the implementation of `nsTString::ToDouble`. Differential Revision: https://phabricator.services.mozilla.com/D148304
d299fa6358f750ef446b5015b92e1b4e8920da82: Bug 1743322 - Make arena_bin_t 32 or 48 bytes long r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 06 Dec 2022 00:50:51 +0000 - rev 716662
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1743322 - Make arena_bin_t 32 or 48 bytes long r=glandium This structure is more optimal if it is somewhat aligned with the system's cache line length (which we assume is 64 bytes but that's not always true). This reduces the number of cache lines required to access one record on average. On 32-bit systems we can manage 32-bytes, on 64-bit systems we can manage 48 bytes. We do this by: * Make mRunSize the number of pages in a run rather than bytes, so that it can be stored in a single byte and save some space in bin headers. * Make mNumRuns a uint32_t on all platforms. Differential Revision: https://phabricator.services.mozilla.com/D140036
25647d613534f8cdde54bc0494a0cf94f0a0fed8: Bug 1743322 - Remove branches that decide how to divide r=glandium
Paul Bone <pbone@mozilla.com> - Tue, 06 Dec 2022 00:50:51 +0000 - rev 716661
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1743322 - Remove branches that decide how to divide r=glandium This code path would choose from several ways about how to divide numbers. By calculating the inverse of the divisor early we can elude all the branches along this code path we can make it faster than the previous code or naive division. Differential Revision: https://phabricator.services.mozilla.com/D132322
62de122b294888133131b4a03c0985736522b0e9: Bug 1799233 - Add tasks to repack Firefox nightly builds into Debian Packages r=glandium
Gabriel Bustamante <gbustamante@mozilla.com> - Mon, 05 Dec 2022 21:10:07 +0000 - rev 716647
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1799233 - Add tasks to repack Firefox nightly builds into Debian Packages r=glandium Differential Revision: https://phabricator.services.mozilla.com/D161743
ba035c8866d8c76f1223332fa9f2397b3df7209d: Bug 1799174 - --disable-jemalloc for hazard analysis shell since ctypes doesn't get along with the allocator function replacement mechanism r=firefox-build-system-reviewers,glandium
Steve Fink <sfink@mozilla.com> - Sun, 04 Dec 2022 01:35:38 +0000 - rev 716568
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1799174 - --disable-jemalloc for hazard analysis shell since ctypes doesn't get along with the allocator function replacement mechanism r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D161353
4c6e650fe33dec46e43f5dc6387541312dfa9f02: Bug 1709543 - Only list macOS installation packages up to version 10.15 r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 02 Dec 2022 13:56:11 +0000 - rev 716444
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1709543 - Only list macOS installation packages up to version 10.15 r=glandium We need to modify the dmg tool to extract newer disk images and we lack support for unpacking YAA archives which are used starting with macOS 11. Once those issues are addressed we can revert this. Differential Revision: https://phabricator.services.mozilla.com/D162191