searching for reviewer(glandium)
96e224617b2fff363452bb728fbe7f061f097798: Bug 1648519 - Add back clang lib directory to LIB on Windows r=glandium
David Major <dmajor@mozilla.com> - Fri, 26 Jun 2020 19:36:30 +0000 - rev 601728
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648519 - Add back clang lib directory to LIB on Windows r=glandium clang 11 will stop using full paths in PGO dependentlib declarations, so we need to tell the linker where to find clang_rt.profile-x86_64.lib. This is roughly a revert of bug 1621552. Differential Revision: https://phabricator.services.mozilla.com/D81244
564eedd27f0a948aea1f7b666b8a7c64002d189e: Bug 1646936 - Generate a single metadata file in the objdir, and feed it to cbindgen. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Jun 2020 10:41:26 +0000 - rev 601656
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646936 - Generate a single metadata file in the objdir, and feed it to cbindgen. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D80360
8f948dd74abae461ee9688ac20769d3f180d1f33: Bug 1646936 - Generate a single metadata file in the objdir, and feed it to cbindgen. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Jun 2020 09:37:16 +0000 - rev 601650
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1646936 - Generate a single metadata file in the objdir, and feed it to cbindgen. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D80360
3387933a2ad2ad47f151d578cfbffb9673018f59: Bug 1644553: Don't enable profile use for artifact builds r=glandium,geckoview-reviewers,agi
Mitchell Hentges <mhentges@mozilla.com> - Wed, 24 Jun 2020 16:57:36 +0000 - rev 601296
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644553: Don't enable profile use for artifact builds r=glandium,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D80565
6803dda74d3349a45d95bc9ce248b90bd9086488: Bug 1318905 - mfbt:tests: Define RETURN_INSTR for riscv64 in TestPoisonArea r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Thu, 18 Jun 2020 07:11:09 +0000 - rev 600574
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1318905 - mfbt:tests: Define RETURN_INSTR for riscv64 in TestPoisonArea r=glandium Define RETURN_INSTR for riscv64 in TestPoisonArea, i.e. the riscv64 assembly opcodes for "ret ; ret". Differential Revision: https://phabricator.services.mozilla.com/D78625
06d7e1b6b7e704f58df2a20f4d3b41b19f6054d6: Bug 1318905 - build: Add riscv64 as target architecture to mozbuild r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Thu, 18 Jun 2020 07:11:09 +0000 - rev 600572
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1318905 - build: Add riscv64 as target architecture to mozbuild r=glandium Adds the basic definitions for riscv64 to mozbuild, allowing to build Spidermonkey. Differential Revision: https://phabricator.services.mozilla.com/D78623
71d7d5c52c77618b3d30edb42456cdc7c7288e6f: Bug 1643192 - Use git log to get base ref r=glandium
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 18 Jun 2020 06:39:55 +0000 - rev 600354
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643192 - Use git log to get base ref r=glandium Since there are still needs for .base_ref(), this uses git log way to get base commit. Differential Revision: https://phabricator.services.mozilla.com/D78183
dd9b53ba6fec48fe7f51ab0bc26621ba656967e7: Bug 1643072 - Enable symlink for non-JS files on Windows r=glandium
Kagami Sascha Rosylight <saschanaz@outlook.com> - Mon, 15 Jun 2020 22:22:50 +0000 - rev 599858
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643072 - Enable symlink for non-JS files on Windows r=glandium Differential Revision: https://phabricator.services.mozilla.com/D78090
8526c9dfc05a80c02a7fdf031f189992c3383d2d: Bug 1632429: remove redundant enum library r=glandium,jgraham
Mitchell Hentges <mhentges@mozilla.com> - Fri, 12 Jun 2020 13:21:38 +0000 - rev 599567
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1632429: remove redundant enum library r=glandium,jgraham Differential Revision: https://phabricator.services.mozilla.com/D78345
da95a35fb07571d59e9346cab07c4ca8a56c3fde: Bug 1644887 - `configure` calls into `$PYTHON3` rather than `python3` directly r=glandium
Ricky Stewart <rstewart@mozilla.com> - Wed, 10 Jun 2020 21:29:27 +0000 - rev 599061
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644887 - `configure` calls into `$PYTHON3` rather than `python3` directly r=glandium Especially after bug 1622963 landed, the system `python3` executable as reported by `which` may not be compatible with the build system (because it might be Python 3.5, for one). You can configure a custom `python3` executable by setting the `PYTHON3` environment variable, but `configure` just calls directly into `python3` regardless of whatever you might have configured `$PYTHON3` to be, so we fix that here. Also remove an explanatory comment that may have made sense 5 years ago but is no longer relevant. Differential Revision: https://phabricator.services.mozilla.com/D79187
590d76562067863dd840c9ff7cf85d5e8e2d6b4d: Bug 1643504 - Update webrender github-CI to use new docker image. r=glandium
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 09 Jun 2020 20:39:10 +0000 - rev 598909
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643504 - Update webrender github-CI to use new docker image. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D78903
a47141066d20ec88ac1e52040fcbc9175ed713af: Bug 1325771 - mfbt:tests: Define RETURN_INSTR for m68k in TestPoisonArea r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Sat, 06 Jun 2020 06:45:53 +0000 - rev 598338
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1325771 - mfbt:tests: Define RETURN_INSTR for m68k in TestPoisonArea r=glandium Define RETURN_INSTR for m68k in TestPoisonArea, i.e. the m68k assembly opcodes for "rts ; rts". Differential Revision: https://phabricator.services.mozilla.com/D77290
3d365d5659eedb1aa172f1617384d8f4aecf1f64: Bug 1642893 - Don't build NSPR by default for standalone JS builds. r=glandium
Jan de Mooij <jdemooij@mozilla.com> - Fri, 05 Jun 2020 07:52:37 +0000 - rev 598189
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642893 - Don't build NSPR by default for standalone JS builds. r=glandium For standalone JS builds there are three possibilities: no-NSPR (the default), build NSPR, or use system NSPR. This patch makes no-NSPR the default again when not overridden by --enable-nspr-build or --with-system-nspr. This was likely regressed by bug 1641775. Differential Revision: https://phabricator.services.mozilla.com/D78001
47230cc3258d80c3eacf2831fb2b70ac4ae91a77: Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Wed, 03 Jun 2020 18:30:50 +0000 - rev 597844
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium Adds the basic definitions for m68k to mozbuild, allowing to build Spidermonkey. Differential Revision: https://phabricator.services.mozilla.com/D77285
9c0a4461457638440c1383f3a42f51c3d18f7c69: Bug 1641291 - Part 3: Ensure that paths are considered paths when compiling. r=glandium
Nick Alexander <nalexander@mozilla.com> - Wed, 03 Jun 2020 18:18:32 +0000 - rev 597839
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641291 - Part 3: Ensure that paths are considered paths when compiling. r=glandium Extremely common file paths on macOS like `/Users/...` are interpreted as `/U...` flags by `clang-cl`. This is so common that there's a `-Wslash-u-filename` warning. Ensure that file paths are considered paths when compiling by terminating options with `--`. This commit handles everything except assembler invocations, because at least `nasm` doesn't handle `--`. Differential Revision: https://phabricator.services.mozilla.com/D77119
0dcf604b880e0c4dcb1c8f2c738e315c0b7c2c73: Bug 1641291 - Part 2: Make NSDISTMODE=copy impact install manifests. r=glandium
Nick Alexander <nalexander@mozilla.com> - Wed, 03 Jun 2020 18:18:23 +0000 - rev 597838
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641291 - Part 2: Make NSDISTMODE=copy impact install manifests. r=glandium This is strictly a quality of life improvement when cross-compiling to Windows targets. A common scenario is mounting an object directory into a Windows VM, which requires additional VM configuration to handle (absolute) symlinks. With this patch, `export NSDISTMODE=copy` in a mozconfig sidesteps any such symlink issues. Differential Revision: https://phabricator.services.mozilla.com/D77118
ace40545b46c2c994e05a51ec466e3cb81a97d0c: Bug 1325771 - mfbt:tests: Define RETURN_INSTR for m68k in TestPoisonArea r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Tue, 02 Jun 2020 07:01:56 +0000 - rev 597817
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1325771 - mfbt:tests: Define RETURN_INSTR for m68k in TestPoisonArea r=glandium Define RETURN_INSTR for m68k in TestPoisonArea, i.e. the m68k assembly opcodes for "rts ; rts". Depends on D77289 Differential Revision: https://phabricator.services.mozilla.com/D77290
393a6ff847ce341fbe0e86f1bccfbea5ed8c3157: Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - Tue, 02 Jun 2020 07:00:48 +0000 - rev 597813
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1325771 - build: Add m68k as target architecture to mozbuild r=glandium Adds the basic definitions for m68k to mozbuild, allowing to build Spidermonkey. Differential Revision: https://phabricator.services.mozilla.com/D77285
7c339f8c535ecc7f12dd6657ab1e8af77205bfd3: Bug 1636628 - update vendored libprio to 1.5 r=glandium
Robert Helmer <rhelmer@mozilla.com> - Fri, 15 May 2020 05:43:07 +0000 - rev 597387
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1636628 - update vendored libprio to 1.5 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D75192
0f124abbe1f9ddd954defe7e5854d48ddde707e3: Bug 1642893 - Don't build NSPR by default for standalone JS builds. r=glandium, a=jcristau
Jan de Mooij <jdemooij@mozilla.com> - Fri, 05 Jun 2020 07:52:37 +0000 - rev 597012
Push 13239 by jcristau@mozilla.com at Mon, 08 Jun 2020 14:18:19 +0000
Bug 1642893 - Don't build NSPR by default for standalone JS builds. r=glandium, a=jcristau For standalone JS builds there are three possibilities: no-NSPR (the default), build NSPR, or use system NSPR. This patch makes no-NSPR the default again when not overridden by --enable-nspr-build or --with-system-nspr. This was likely regressed by bug 1641775. Differential Revision: https://phabricator.services.mozilla.com/D78001
1501edba66fb7d7ace79fdf4d47923b0f47eb490: Bug 1636859 - Shut down the `fix-stacks` child process when `fix_stacks.py` exits. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 28 May 2020 00:34:30 +0000 - rev 596397
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636859 - Shut down the `fix-stacks` child process when `fix_stacks.py` exits. r=glandium Hopefully this will avoid some intermittent failures that occur when `fix-stacks` is deleted at the end of a test run. Differential Revision: https://phabricator.services.mozilla.com/D76980
9ca07f6e0135fba743fbe61650ef3177d4b0d8fe: Bug 1638976 - Convert 'mach power' to run with Python 3. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 25 May 2020 23:50:19 +0000 - rev 595852
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638976 - Convert 'mach power' to run with Python 3. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D76273
327c6c5acdbcbd884f818c0fa7b507048642291b: Bug 1638060 - Standardize interface of `mozfile` classes as `bytes`-based streams r=glandium
Ricky Stewart <rstewart@mozilla.com> - Fri, 22 May 2020 01:11:29 +0000 - rev 595454
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638060 - Standardize interface of `mozfile` classes as `bytes`-based streams r=glandium At the beginning of the Python 3 migration (circa bug 1602540), we made an update to the interface of `mozpack/files.py` in the direction of aligning with Python 3's built-in `file` support; namely, that opening a file in text mode returns a stream of `str` (text), and that opening a file in binary mode returns a stream of `bytes`. This was deemed to be more trouble than it was worth. This patch undoes all of those changes to the interface in favor of moving back to the Python 2 style, where all files are bytestreams. Differential Revision: https://phabricator.services.mozilla.com/D75424
be25dcaaad430eb4fee973998a30d7de690fb017: Bug 1632345 - mach doctor does not complain about noatime/reltime on tmpfs anymore r=Callek,glandium
adiabtaic28394 <adiabtaic28394@protonmail.com> - Fri, 22 May 2020 13:36:42 +0000 - rev 595411
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1632345 - mach doctor does not complain about noatime/reltime on tmpfs anymore r=Callek,glandium Differential Revision: https://phabricator.services.mozilla.com/D75917
63b7f29fb954642022320b64d7fc208675ab30f4: Bug 1637381: Fix reference to old tarball for win64-clang-tidy r=glandium
Chris AtLee <catlee@mozilla.com> - Fri, 22 May 2020 01:12:56 +0000 - rev 595328
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Fix reference to old tarball for win64-clang-tidy r=glandium Differential Revision: https://phabricator.services.mozilla.com/D76420
7054e490f0ce9a4fe79e7047dbde56c014eea223: Bug 1638574 - Allow to use widl when cross-compiling clang-cl builds. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 May 2020 01:16:59 +0000 - rev 595322
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638574 - Allow to use widl when cross-compiling clang-cl builds. r=glandium This avoids having to have clang-cl.exe and ml64.exe in the path. This requires a WIDL patch[1] and one other tweak, but it's working other than that. While at it, allow to pass extra flags to midl / widl. This is useful to test with a local widl for example, to pass the right include paths. [1]: https://www.winehq.org/pipermail/wine-devel/2020-May/166368.html Differential Revision: https://phabricator.services.mozilla.com/D75680
c413912c4f0e15c7ab69283d3a7cdcd2b7a7cb3d: Bug 1639815 - Fix for win asan build bustages. r=glandium
Cosmin Sabou <csabou@mozilla.com> - Fri, 22 May 2020 03:23:16 +0300 - rev 595312
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639815 - Fix for win asan build bustages. r=glandium CLOSED TREE
923ff4b6bda78ae87b6d47961b7361967bc6d9da: Bug 1637381: Use zstd for clang toolchains r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:31:55 +0000 - rev 595185
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Use zstd for clang toolchains r=glandium Differential Revision: https://phabricator.services.mozilla.com/D74930
e81e04151467bb7830440e1136e6c7631715c189: Bug 1637381: Use zstd for rust toolchains r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:30:56 +0000 - rev 595184
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Use zstd for rust toolchains r=glandium Differential Revision: https://phabricator.services.mozilla.com/D74929
fecf02b98dd71c3519fd6727528c51190ee6a7b8: Bug 1637381: Use python3 for repack_rust.py r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:30:54 +0000 - rev 595183
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Use python3 for repack_rust.py r=glandium repack_rust.py was the only toolchain build using a python script directly. we don't need it to use the `mach python` wrapper, so remove that special casing from the transform. Differential Revision: https://phabricator.services.mozilla.com/D75702
193de423be3441202905ccc85eef4d53f72f1b51: Bug 1637381: Use zstd for android toolchains r=firefox-build-system-reviewers,glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:29:13 +0000 - rev 595182
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Use zstd for android toolchains r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D74928
245952ad63ad8d52a0d73a987fa9a58b40027808: Bug 1637381: Add zstdpy script r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:28:55 +0000 - rev 595181
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Add zstdpy script r=glandium This is a simple command line utility for doing zstd compression/decompression of stdin to stdout. It depends on python's zstandard module being available. Differential Revision: https://phabricator.services.mozilla.com/D75358
aab5979b57e2654a22d0041a330343b8ff1665c7: Bug 1637381: Add python-zstandard to ubuntu test images so they can unpack toolchains r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:28:45 +0000 - rev 595180
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Add python-zstandard to ubuntu test images so they can unpack toolchains r=glandium Differential Revision: https://phabricator.services.mozilla.com/D75356
4aae9dc67310a0d7cc8eae3c415205b9930c153d: Bug 1637381: Add support for extracting zst files to mozbuild tooltool r=glandium
Chris AtLee <catlee@mozilla.com> - Thu, 21 May 2020 13:28:33 +0000 - rev 595179
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637381: Add support for extracting zst files to mozbuild tooltool r=glandium Differential Revision: https://phabricator.services.mozilla.com/D75203
ce69a90afaa52ec1c8269c3d84b8a610ef67d854: Bug 1639419 - Enable frame tree dumps whenever the layout debugger is enabled. r=TYLin,glandium
Cameron McCormack <cam@mcc.id.au> - Wed, 20 May 2020 23:44:49 +0000 - rev 595104
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639419 - Enable frame tree dumps whenever the layout debugger is enabled. r=TYLin,glandium Differential Revision: https://phabricator.services.mozilla.com/D76076
abd60784e8c3fde1a2396f5d8f0c4bd6289dfe4d: Bug 1588166 - Remove python-dbus build dependency. (notify-send replaced it and it's no longer needed.) r=glandium
Alex Vincent <ajvincent@gmail.com> - Wed, 20 May 2020 15:19:13 +0000 - rev 595021
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1588166 - Remove python-dbus build dependency. (notify-send replaced it and it's no longer needed.) r=glandium Differential Revision: https://phabricator.services.mozilla.com/D74798
415534347ba0c79d4d7ebc27c85723363aaceec3: Bug 1636574 - Allow setting `PYTHON3` in mozconfig r=glandium
Ricky Stewart <rstewart@mozilla.com> - Wed, 20 May 2020 15:39:29 +0000 - rev 595015
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636574 - Allow setting `PYTHON3` in mozconfig r=glandium Configuration values defined above `mozconfig_options` in `init.configure` are those that can't be configured in `mozconfig`. As far as I can tell there is nothing wrong *in principle* with setting `PYTHON3` in `mozconfig`, so here we just bump `mozconfig_options` above `PYTHON3` configuration. Side note, diagnosing this failure took a *long* time. The error message that this produced ("unknown option `PYTHON3`") is useless and the underlying algos being extremely mutable, I ended up having to spend a lot of time in the debugger and monitor all the underlying changes to a bunch of mutable data structures to determine where `PYTHON3` was getting lost. A better error message would be good here but I don't know how I would begin adding it. Differential Revision: https://phabricator.services.mozilla.com/D75635
9eff38d118ba65b9b2cd0fd79b8b1fe4b23be214: Bug 1638983 - Run `mach repackage` with Python 3 r=firefox-build-system-reviewers,glandium
Ricky Stewart <rstewart@mozilla.com> - Wed, 20 May 2020 15:35:58 +0000 - rev 595014
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638983 - Run `mach repackage` with Python 3 r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D76058
76aead72792b86ae34dc912e668cc9d00be34b30: Bug 1638995 - Run `mach valgrind-test` with Python 3 r=firefox-build-system-reviewers,glandium
Ricky Stewart <rstewart@mozilla.com> - Wed, 20 May 2020 05:31:58 +0000 - rev 595011
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638995 - Run `mach valgrind-test` with Python 3 r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D76057
72f6e2d0766718303361dd63ace5d146425bdbec: Bug 1577110: Don't add default toolchain artifact directory if already specified; r=glandium
Tom Prince <mozilla@hocat.ca> - Tue, 19 May 2020 22:44:45 +0000 - rev 594668
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1577110: Don't add default toolchain artifact directory if already specified; r=glandium If a task has explicitly specified artifact paths, don't additionally specify the default paths. If the task has private artifacts, having a directory that uploads public artifacts seems like an attractive nuissance. Differential Revision: https://phabricator.services.mozilla.com/D74200
53f1c8e4b4ef6281fba681d4eda5ad4789860211: Bug 1630558 - Generate more stable hashes for toolchain tasks r=glandium
Johan Lorenzo <jlorenzo@mozilla.com> - Tue, 19 May 2020 22:44:34 +0000 - rev 594667
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630558 - Generate more stable hashes for toolchain tasks r=glandium The toolchain transform rarely changes in ways that impact the generated toolchain. but does occasionally change in ways that don't. Stop including the digest of the transform module, to avoid needlessly rebuilding toolchains as often. Given that the cache route is versioned, we can bump the version if the transform does change in a way that requires rebuilding. Differential Revision: https://phabricator.services.mozilla.com/D74199
8ade9f1318ba08fed3e91ce3df7e8b28fc11131b: Bug 1635112 - Use `clang-tidy` as warning build error detector for our `static-analysis` targets. r=glandium
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 08 May 2020 07:19:23 +0000 - rev 594510
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635112 - Use `clang-tidy` as warning build error detector for our `static-analysis` targets. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D73692
9d015b5e2ef88f60f2cc865af893072a9019c8ee: Bug 1635112 - remove MSVC support from `WarningsCollector`. r=glandium
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 08 May 2020 07:19:02 +0000 - rev 594509
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635112 - remove MSVC support from `WarningsCollector`. r=glandium MSVC is not supported by the build system anymore. Differential Revision: https://phabricator.services.mozilla.com/D73809
33277064c34351810b7ca34691733c41157b3b79: Bug 1577110: Don't add default toolchain artifact directory if already specified; r=glandium
Tom Prince <mozilla@hocat.ca> - Fri, 15 May 2020 04:06:48 +0000 - rev 593967
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1577110: Don't add default toolchain artifact directory if already specified; r=glandium If a task has explicitly specified artifact paths, don't additionally specify the default paths. If the task has private artifacts, having a directory that uploads public artifacts seems like an attractive nuissance. Differential Revision: https://phabricator.services.mozilla.com/D74200
9baed9d8e952ddd6600340ab7249c282b4e2f144: Bug 1630558 - Generate more stable hashes for toolchain tasks r=glandium
Johan Lorenzo <jlorenzo@mozilla.com> - Fri, 15 May 2020 04:54:57 +0000 - rev 593966
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630558 - Generate more stable hashes for toolchain tasks r=glandium The toolchain transform rarely changes in ways that impact the generated toolchain. but does occasionally change in ways that don't. Stop including the digest of the transform module, to avoid needlessly rebuilding toolchains as often. Given that the cache route is versioned, we can bump the version if the transform does change in a way that requires rebuilding. Differential Revision: https://phabricator.services.mozilla.com/D74199
83a818c96a406cc86b99e6a58aff9e4ce6b19293: Bug 1553717 - Use Randomization on all arenas in non-Content Processes. r=glandium
Gian-Carlo Pascutto <gcp@mozilla.com> - Wed, 13 May 2020 08:31:04 +0000 - rev 593630
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1553717 - Use Randomization on all arenas in non-Content Processes. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D70240
465ff2025b7ff9753f7f1ff79d3e0bd56e19b77d: Bug 1636797 - Don't include .pyc, .pyd, or .pyo files in hash in taskgraph r=tomprince,glandium
Ricky Stewart <rstewart@mozilla.com> - Thu, 14 May 2020 00:15:40 +0000 - rev 593506
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636797 - Don't include .pyc, .pyd, or .pyo files in hash in taskgraph r=tomprince,glandium These files are ALWAYS ignored and are never relevant when hashing the state of a working tree. It would be better overall to not consult the filesystem directly and go through the VCS to ensure we never try to hash any ignored files, but these files seem to be the main stumbling block and the primary cause of bugs like bug 1636797, so this is a fine stopgap in the meantime. Differential Revision: https://phabricator.services.mozilla.com/D75126
f547aede83f1ccd93c1c83c392e3c63614bcdf49: Bug 1633494 - Augment `hg` command used to get commit time r=glandium
Ricky Stewart <rstewart@mozilla.com> - Tue, 12 May 2020 15:53:14 +0000 - rev 593133
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1633494 - Augment `hg` command used to get commit time r=glandium `hg` gives us some additional levers to tweak when determining which commits are public and non-public. All the better, because `hg`'s default behavior under a rebase is to preserve the original commit time, so if you rebase a month-old commit on the latest version of central, you might still get the "revision too old" error despite your tree actually being completely up-to-date. Here we replace the original logic with something a little bit more robust to that scenario. As before, this is a best-effort check that might have false positives or false negatives; this commit doesn't change that, but hopefully it decreases the amount of false positives under `hg`. Differential Revision: https://phabricator.services.mozilla.com/D74745
be3aa8f30db0246ecee9ba1ed146a5969e8fbd3d: Bug 1635852: Include minidump_stackwalk files in taskgraph sparse-profile; r=glandium
Tom Prince <mozilla@hocat.ca> - Thu, 07 May 2020 22:20:52 +0000 - rev 592460
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635852: Include minidump_stackwalk files in taskgraph sparse-profile; r=glandium Without this, taskgraph calculates the digest based on just the files in these directories that are in the sparse profile (I suspect this is just the moz.build files), and will rebuild it when those files change. This changes ensures that all files in those directories are used to calculate the digest. Additionally, this will cause the same digest to be generted by developers locally, since the files *are* present in the non-sparse checkout that most developers have. Differential Revision: https://phabricator.services.mozilla.com/D74113
d2dc990fff7907e2636eb8b35f7e05c34495aac8: Bug 1635750 - Fix perma failure in ccov by not depending on mozbuild r=glandium
Ricky Stewart <rstewart@mozilla.com> - Thu, 07 May 2020 16:05:11 +0000 - rev 592391
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635750 - Fix perma failure in ccov by not depending on mozbuild r=glandium Differential Revision: https://phabricator.services.mozilla.com/D74121