searching for reviewer(glandium)
42bd6d4455a4: Bug 1497155 - Allow toolchain artifact downloading command to be run on Taskcluster. r=glandium.
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 11 Oct 2018 08:11:41 +0000 - rev 496419
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497155 - Allow toolchain artifact downloading command to be run on Taskcluster. r=glandium. Differential Revision: https://phabricator.services.mozilla.com/D8360
98c8f1d6a5d2: Bug 1497774 - Remove the nightly dmd task. r=glandium
Eric Rahm <erahm@mozilla.com> - Wed, 10 Oct 2018 13:29:20 -0700 - rev 496382
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497774 - Remove the nightly dmd task. r=glandium We no longer need a separate nightly task for dmd since it's now enabled by default in nightly m-c builds.
d0e3cbf73f04: Bug 1497976: Pass close_fds when running commands for configure. r=glandium
Kris Maglione <maglione.k@gmail.com> - Tue, 09 Oct 2018 16:15:13 -0700 - rev 496313
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497976: Pass close_fds when running commands for configure. r=glandium Running rustc with an open fd 4 sometimes causes it to fail with an obscure error when it tries to connect to a job server on that fd. Closing the fd solves the problem. close_fds does what we need, and is the default value in Python 3, but not in Python 2. Differential Revision: https://phabricator.services.mozilla.com/D8167
6110df22039b: Bug 1464509: Add memory replacer with counters to the Gecko profiler r=glandium
Randell Jesup <rjesup@jesup.org> - Tue, 09 Oct 2018 22:28:56 -0400 - rev 496193
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1464509: Add memory replacer with counters to the Gecko profiler r=glandium
b69c28ab39fc: Bug 1480430: Modify jemalloc to allow dynamic replacement r=glandium
Randell Jesup <rjesup@jesup.org> - Tue, 09 Oct 2018 22:28:37 -0400 - rev 496192
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1480430: Modify jemalloc to allow dynamic replacement r=glandium
568a3198520c: Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium
Chris AtLee <catlee@mozilla.com> - Wed, 18 Oct 2017 09:45:00 -0400 - rev 495847
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium MozReview-Commit-ID: 12tmFzzvRvP
74abe131db1b: Bug 1409739 - Part 2: Remove old DMD configs r=glandium
Chris AtLee <catlee@mozilla.com> - Tue, 17 Oct 2017 11:26:04 -0400 - rev 495846
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 2: Remove old DMD configs r=glandium MozReview-Commit-ID: H7kc33CXIbQ
874a07fdb045: Bug 1496610: Don't treat ~ (tilde) in paths as special. r=glandium
Adam Gashlin <agashlin@mozilla.com> - Thu, 04 Oct 2018 18:55:07 -0700 - rev 495476
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496610: Don't treat ~ (tilde) in paths as special. r=glandium This fixes treatment of Windows paths, where tilde is not special, particularly in short file names.
494eb5db5648: Bug 1465731 - Fix armv6 build. r=glandium
Guillaume GARDET <guillaume.gardet@arm.com> - Wed, 03 Oct 2018 04:22:00 +0300 - rev 495334
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1465731 - Fix armv6 build. r=glandium ARM_ARCH setting is broken in build/autoconf/arch.m4 file, when multiple lines match the pattern. So, keep the 1st line only.
23f384237f73: Bug 1397263 - move GNU_AS checks to toolchain.configure; r=glandium
Ted Mielczarek <ted@mielczarek.org> - Wed, 03 Oct 2018 20:29:29 -0400 - rev 495302
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1397263 - move GNU_AS checks to toolchain.configure; r=glandium The GNU_AS check in old-configure depended on running with the value of $AS before it gets reset to just be the C compiler, which breaks when we move setting AS into moz.configure. This patch moves the GNU_AS check to toolchain.configure and changes it so that it works when the assembler is the C compiler. We do have to fix things slightly for clang, because the previous check was succeeding, but not because of clang: it was detecting the presence of "GNU" in the output for GNU ld/gold and a message about the GNU GPL.
b3ad04383928: Bug 1397263 - move MIDL_FLAGS to toolkit/moz.configure; r=glandium
Ted Mielczarek <ted@mielczarek.org> - Wed, 03 Oct 2018 20:29:29 -0400 - rev 495301
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1397263 - move MIDL_FLAGS to toolkit/moz.configure; r=glandium This is a straightforward port of MIDL_FLAGS from old-configure to moz.configure. The only behavioral change is that it removes support for prepending MIDL_FLAGS from the environment in configure, but I doubt anyone uses that.
b4dec9b774a8: Bug 1397263 - move AS checks to toolchain.configure; r=glandium
Nathan Froyd <froydnj@mozilla.com> - Wed, 03 Oct 2018 20:29:29 -0400 - rev 495300
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1397263 - move AS checks to toolchain.configure; r=glandium This is a fairly straightforward port of the AS tool checks from old-configure to toolchain.configure. AS is a little quirky in that we currently do a normal-looking check for it, but then override that value to be the C compiler for non-Windows builds, and ml[64]/armasm64 for Windows builds. After migrating those checks, the only things left in the MOZ_DEFAULT_COMPILER macro in compiler-opts.m4 were some unused bits, so I removed them: * Setting of CPP/CXXCPP, which are set in toolchain.configure now * Setting HOST_LDFLAGS to empty, which doesn't seem particularly useful. There was also a quirky old test that the assembler was ml[64] when js-ctypes is enabled that I removed, I don't think it provides any value since this patch will ensure that we're using the right assembler for Windows builds.
73a4e7ed19f3: Bug 1397263 - move MIDL checks to moz.configure; r=glandium
Ted Mielczarek <ted@mielczarek.org> - Wed, 03 Oct 2018 20:29:29 -0400 - rev 495299
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1397263 - move MIDL checks to moz.configure; r=glandium
387f946c7c48: Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium
Chris AtLee <catlee@mozilla.com> - Wed, 18 Oct 2017 09:45:00 -0400 - rev 495098
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium MozReview-Commit-ID: 12tmFzzvRvP
617288a6b2d9: Bug 1409739 - Part 2: Remove old DMD configs r=glandium
Chris AtLee <catlee@mozilla.com> - Tue, 17 Oct 2017 11:26:04 -0400 - rev 495097
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 2: Remove old DMD configs r=glandium MozReview-Commit-ID: H7kc33CXIbQ
9d52b6dad6f5: Bug 1484828 - Set SharedLibrary::mOffset to firstMappingStart - baseAddress. r=glandium
Markus Stange <mstange@themasta.com> - Fri, 21 Sep 2018 02:37:37 +0000 - rev 495076
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1484828 - Set SharedLibrary::mOffset to firstMappingStart - baseAddress. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D3834
dc3c5143ba4e: Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium
Chris AtLee <catlee@mozilla.com> - Wed, 18 Oct 2017 09:45:00 -0400 - rev 495057
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium MozReview-Commit-ID: 12tmFzzvRvP
e37ea5eb932a: Bug 1409739 - Part 2: Remove old DMD configs r=glandium
Chris AtLee <catlee@mozilla.com> - Tue, 17 Oct 2017 11:26:04 -0400 - rev 495056
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 2: Remove old DMD configs r=glandium MozReview-Commit-ID: H7kc33CXIbQ
39c8abcf9cb2: Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium
Chris AtLee <catlee@mozilla.com> - Wed, 18 Oct 2017 09:45:00 -0400 - rev 494991
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 3: Enable DMD in nightly/CI builds r=glandium MozReview-Commit-ID: 12tmFzzvRvP
c0da83c08b62: Bug 1409739 - Part 2: Remove old DMD configs r=glandium
Chris AtLee <catlee@mozilla.com> - Tue, 17 Oct 2017 11:26:04 -0400 - rev 494990
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1409739 - Part 2: Remove old DMD configs r=glandium MozReview-Commit-ID: H7kc33CXIbQ
432a98e50d2b: Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium
Franziskus Kiefer <franziskuskiefer@gmail.com> - Tue, 02 Oct 2018 14:59:34 +0200 - rev 494987
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium Differential Revision: https://phabricator.services.mozilla.com/D2725 Differential Revision: https://phabricator.services.mozilla.com/D2860
5f6fd031d3a6: Bug 1484073 - Emit less detailed debug info for Linux coverage builds. r=glandium
Marco Castelluccio <mcastelluccio@mozilla.com> - Tue, 02 Oct 2018 10:30:10 +0200 - rev 494905
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1484073 - Emit less detailed debug info for Linux coverage builds. r=glandium DONTBUILD as the coverage builds are only run on mozilla-central
816e01983b58: Bug 1445943: Add Enterprise Policy support for macOS. r=mstange,felipe,glandium
Stephen A Pohl <spohl.mozilla.bugs@gmail.com> - Thu, 27 Sep 2018 23:08:07 -0400 - rev 494377
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1445943: Add Enterprise Policy support for macOS. r=mstange,felipe,glandium
920494c619ef: Bug 1494138 - update vendored libprio to 1.2 r=glandium
Robert Helmer <rhelmer@mozilla.com> - Thu, 27 Sep 2018 06:10:05 +0000 - rev 494247
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1494138 - update vendored libprio to 1.2 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D6871
8d6329af610e: Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 26 Sep 2018 11:54:34 +0000 - rev 494032
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium Differential Revision: https://phabricator.services.mozilla.com/D5741
628ebca30ce3: Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 24 Sep 2018 13:21:38 +0000 - rev 493607
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium Differential Revision: https://phabricator.services.mozilla.com/D5741
c37ea7ae71ef: Bug 1393570 - Set allowInheritPrincipal=false by default r=Gijs,glandium
Rob Wu <rob@robwu.nl> - Tue, 18 Sep 2018 11:54:44 +0000 - rev 493560
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1393570 - Set allowInheritPrincipal=false by default r=Gijs,glandium This change prevents javascript:-URLs from being passed at the command line. This restriction was already applied to every URL but the first. Even the first URL did not result in any visible effect when Firefox is started. Yet somehow the PGO profiler script managed to rely on it. This commit ensures that "javascript:" URLs are not activated regardless of position in the command line, and switches to a data:-URL for the PGO script to achieve the (previously) desired effect of quitting the browser on startup. Depends on D4929 Differential Revision: https://phabricator.services.mozilla.com/D5958
5a566d2d6722: Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 21 Sep 2018 11:38:04 +0000 - rev 493372
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490240 - Fix the remaining compiler warnings in the crash reporter r=ted,glandium Differential Revision: https://phabricator.services.mozilla.com/D5741
3d337c5ca457: Bug 1400051 - IPC: use process_util_linux on BSD and remove process_util_bsd. r=glandium
Jed Davis <jld@mozilla.com> - Thu, 20 Sep 2018 19:53:31 -0600 - rev 493340
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1400051 - IPC: use process_util_linux on BSD and remove process_util_bsd. r=glandium This change is mainly to avoid the use of SetAllFDsToCloseOnExec, which has an unavoidable race condition that can leak file descriptors into child processes. The "Linux" implementation of child process creation, now that B2G support has been removed, is essentially a generic Unix fork+dup2+execve which works on BSD (and is already used on Solaris).
a8a7b6a9621a: Bug 1491788 - Use clang 7final to build firefox & clang-tidy r=glandium
Sylvestre Ledru <sledru@mozilla.com> - Mon, 17 Sep 2018 13:48:24 +0200 - rev 493142
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491788 - Use clang 7final to build firefox & clang-tidy r=glandium Differential Revision: https://phabricator.services.mozilla.com/D6018
d972ccfe657d: Bug 1490564 Add a x86 MinGW-clang toolchain job r=glandium
Tom Ritter <tom@mozilla.com> - Mon, 17 Sep 2018 15:39:14 +0000 - rev 492734
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490564 Add a x86 MinGW-clang toolchain job r=glandium Differential Revision: https://phabricator.services.mozilla.com/D5720
1ddd00661a4a: Bug 1490145 - Upgrade builders to rustc 1.29. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Tue, 18 Sep 2018 00:51:44 +0000 - rev 492658
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490145 - Upgrade builders to rustc 1.29. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D5826
4a1b33920a00: Bug 1490145 - Download rustc 1.29 in mach bootstrap. r=glandium
Chris Manchester <cmanchester@mozilla.com> - Fri, 14 Sep 2018 02:21:26 +0000 - rev 492656
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490145 - Download rustc 1.29 in mach bootstrap. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D5825
131a80cf6661: Bug 1491289 - re-vendor libprio to pick up fixes for using system NSS r=glandium
Robert Helmer <rhelmer@mozilla.com> - Tue, 18 Sep 2018 04:36:49 +0000 - rev 492652
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491289 - re-vendor libprio to pick up fixes for using system NSS r=glandium Differential Revision: https://phabricator.services.mozilla.com/D6082
b2a536ba5d4b: Bug 1485224 - Update Windows builders to VS 2017 15.8.4 and Windows SDK 17134. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 07 Sep 2018 07:15:19 +0900 - rev 492239
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485224 - Update Windows builders to VS 2017 15.8.4 and Windows SDK 17134. r=glandium
815d17af6a7e: Bug 1485224 - Workaround a linker bug of MSVC 2017 Update 8. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 28 Aug 2018 23:41:39 +0900 - rev 492238
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485224 - Workaround a linker bug of MSVC 2017 Update 8. r=glandium MSVC 15.8 linker dislikes forward slashes in the /OUT: parameter when it is generating a profile
98343cbec0c4: Bug 1384557 - move _DEPEND_CFLAGS+CL_INCLUDES_PREFIX to toolchain.configure, ignore {CC,CXX}_WRAPPER when using sccache; r=glandium
Ted Mielczarek <ted@mielczarek.org> - Fri, 14 Sep 2018 12:12:34 -0400 - rev 492210
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1384557 - move _DEPEND_CFLAGS+CL_INCLUDES_PREFIX to toolchain.configure, ignore {CC,CXX}_WRAPPER when using sccache; r=glandium Currently mozconfig.cache overrides a few build options for sccache. This patch moves them into toolchain.configure so that the build system will set them properly when sccache is in use. Additionally, {CC,CXX}_WRAPPER are set in config.mk, so just avoid setting them when sccache is in use.
2e5441b82052: Bug 1490567 Update ffi build to handle x86 MinGW-clang builds r=glandium
Tom Ritter <tom@mozilla.com> - Fri, 14 Sep 2018 02:08:17 +0000 - rev 492041
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490567 Update ffi build to handle x86 MinGW-clang builds r=glandium Differential Revision: https://phabricator.services.mozilla.com/D5643
704af02a849d: Bug 1480834 - 5. Keep target flag when building for Android on Linux; r=glandium
Jim Chen <nchen@mozilla.com> - Thu, 13 Sep 2018 12:09:26 -0400 - rev 491956
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1480834 - 5. Keep target flag when building for Android on Linux; r=glandium Currently, when building for Android x86-64 on Linux x86-64, we drop the '--target' flag, which causes the build to fail. This patch adds a check for OS mismatch, so we keep the '--target' flag in this situation. Differential Revision: https://phabricator.services.mozilla.com/D4483
ced591ff6815: Bug 1480834 - 4. Specify -Werror for pthread_cond_timedwait_monotonic_np check; r=glandium
Jim Chen <nchen@mozilla.com> - Thu, 13 Sep 2018 12:09:25 -0400 - rev 491955
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1480834 - 4. Specify -Werror for pthread_cond_timedwait_monotonic_np check; r=glandium On 64-bit Android, `pthread_cond_timedwait_monotonic_np` is only available for API 28+. The issue is, even though the NDK header does not define `pthread_cond_timedwait_monotonic_np` for API 27 and below, the NDK library _does_ include the function (in order to support builds targeting API 28+). During our configure test, the compiler only emits a warning about `pthread_cond_timedwait_monotonic_np` being undefined, but linking succeeds because the function is present in the library. Because linking succeeds, the test inadvertently passes. This patch adds a '-Werror' flag to the compilation, so the warning turns into an error to make the test fail. Differential Revision: https://phabricator.services.mozilla.com/D4482
c12699660620: Bug 1480834 - 3. Fix linker compile errors under x86-64; r=glandium
Jim Chen <nchen@mozilla.com> - Thu, 13 Sep 2018 12:09:25 -0400 - rev 491954
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1480834 - 3. Fix linker compile errors under x86-64; r=glandium The linker has x86-64 support but currently fails to compile. This patch fixes these compile errors to make it build under x86-64. Differential Revision: https://phabricator.services.mozilla.com/D4481
fe2c607f4af7: Bug 1485224 - Update Windows builders to VS 2017 Update 8 and Windows SDK 17134. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Fri, 07 Sep 2018 07:15:19 +0900 - rev 491693
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485224 - Update Windows builders to VS 2017 Update 8 and Windows SDK 17134. r=glandium
f7a6e536532e: Bug 1485224 - Workaround a linker bug of MSVC 2017 Update 8. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 28 Aug 2018 23:41:39 +0900 - rev 491692
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485224 - Workaround a linker bug of MSVC 2017 Update 8. r=glandium MSVC 15.8 linker dislikes forward slashes in the /OUT: parameter when it is generating a profile
6910a17f4aa6: Bug 1489096: Use clang 7.0.0rc3 for Windows builds. r=glandium
David Major <dmajor@mozilla.com> - Tue, 11 Sep 2018 23:57:29 -0400 - rev 491590
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1489096: Use clang 7.0.0rc3 for Windows builds. r=glandium
9533efb267a0: Bug 1490115 - Add extra tests for comment-only inputs. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 11 Sep 2018 09:41:40 +1000 - rev 491366
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490115 - Add extra tests for comment-only inputs. r=glandium
f0c8d0f1cb58: Bug 1490115 - Handle unaccompanied low surrogate pairs in the prefs parser. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 11 Sep 2018 09:41:37 +1000 - rev 491365
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490115 - Handle unaccompanied low surrogate pairs in the prefs parser. r=glandium Currently they cause the `String::from_utf16()` call to return an error result, and then the subsequent `unwrap()` on that result aborts.
5097db630d1f: Bug 1489744 - Fix a bounds violation crash in the prefs parser. r=glandium
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 11 Sep 2018 09:36:07 +1000 - rev 491359
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1489744 - Fix a bounds violation crash in the prefs parser. r=glandium Currently, if a get_char() call returns EOF, the index moves beyond the buffer's bounds and get_char() cannot be called again without triggering a panic. As a result, everywhere that encounters an EOF and then does subsequent parsing ungets the EOF... except there was one place that failed to do that: the match case for CharKind::Slash in get_token(). This meant that a single '/' at the end of the input could trigger a bounds violation (but only if it is the start of a new token). This EOF-unget requirement is subtle and easy to get wrong, so this patch eliminates it. get_char() now can be called repeatedly after an EOF, and will return EOF on each subsequent call. This means that some of the existing unget_char() calls can be removed. Some others are still necessary to get line numbers correct in error messages, but the outcome of mishandled cases is now much less drastic -- an incorrect line number in an error message instead of a panic. The patch also clarifies a couple of related comments.
c73d63442c8d: Bug 1481633 Resolve kPStaticModules undefined symbols in MinGW Clang r=glandium
Tom Ritter <tom@mozilla.com> - Tue, 11 Sep 2018 03:20:06 +0000 - rev 491323
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1481633 Resolve kPStaticModules undefined symbols in MinGW Clang r=glandium clang can handle MSVC-like codepaths generally, so we want to use those when building with clang for Windows. So we switch _MSC_VER over to _WIN32 to pick up those codepaths when compiling for Windows with clang. Additionally, we relax the ordering of sections for the same scenario. Note that we do need to tell clang to use -fms-extensions with the MSVC code, we do that in the mingw clang build job patch. Differential Revision: https://phabricator.services.mozilla.com/D3526
8d4bac2ca4da: Bug 1489205 In expandlibs.m4, use the Windows form only when we are compiling on Windows r=glandium
Tom Ritter <tom@mozilla.com> - Tue, 11 Sep 2018 03:20:06 +0000 - rev 491322
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1489205 In expandlibs.m4, use the Windows form only when we are compiling on Windows r=glandium Differential Revision: https://phabricator.services.mozilla.com/D5172
10ffdec164a9: Bug 1484406 - Update rust-size version. r=glandium
Eric Rahm <erahm@mozilla.com> - Thu, 06 Sep 2018 16:36:19 -0700 - rev 490962
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1484406 - Update rust-size version. r=glandium This updates the rust-size build to reference the latest version [1] that includes a work-around for calculating the .bss of a PE file that has a writable section with a smaller on-disk size than in-memory size. [1] https://github.com/luser/rust-size/commit/ab659d93b1faba95307df952aefe3fbed3583669