searching for reviewer(gerald)
523bbc540caf41b1b840e35268790322fa8711f9: Bug 1548371 - Fix --enable-task-tracer build. r=gerald
Markus Stange <mstange@themasta.com> - Thu, 02 May 2019 11:09:11 +0000 - rev 531151
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548371 - Fix --enable-task-tracer build. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D29559
be38681e82877a61527772e5831ccd6399aec61d: Bug 1532867 - Force unsigned arithmetic. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 01 May 2019 07:20:23 +0000 - rev 531016
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1532867 - Force unsigned arithmetic. r=gerald "For negative a, the behavior of a << b is undefined." https://en.cppreference.com/w/cpp/language/operator_arithmetic Differential Revision: https://phabricator.services.mozilla.com/D29459
884f5dc55873c9345ee945cd6d5427e8ab398071: Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 11 Apr 2019 12:36:51 +0000 - rev 527951
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel * Remove redundant virtual keywords * Mark all destructors of inheriting classes as virtual for clarity * Mark all classes without virtual destructor as final (exposed errors) * Make destructor virtual where it needed to be (some were missing) * Replace empty ({}) code declaration in header with = default * Remove virtual unused methods I probably missed some, it quickly became a rabbit hole. Differential Revision: https://phabricator.services.mozilla.com/D26060
ac91a1c2e3f530dad623df6983ace85d6ba40a77: Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:24:34 +0000 - rev 525748
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 4: Tests. r=froydnj,gerald Depends on D25024 Differential Revision: https://phabricator.services.mozilla.com/D25025
a01e770ef4f534b9ab9989be2080be0c59e6cbda: Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:26:26 +0000 - rev 525747
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald Depends on D25023 Differential Revision: https://phabricator.services.mozilla.com/D25024
3ae52b39cf6fa20b0ca827dad49610e6b154997c: Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:15 +0000 - rev 525746
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald Depends on D24583 Differential Revision: https://phabricator.services.mozilla.com/D25023
b9e91906edae1ca73ce9f69aa8ad26b9e588deef: Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:13 +0000 - rev 525745
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald Differential Revision: https://phabricator.services.mozilla.com/D24583
ced61a86c74c6ce2a966b2ac7880cfe3e7a8e0d8: Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 00:21:26 +0000 - rev 525700
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 4: Tests. r=froydnj,gerald Depends on D25024 Differential Revision: https://phabricator.services.mozilla.com/D25025
d6d331abbf0ebf89f4c7a3f391e4ac4b943c37cb: Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 00:21:24 +0000 - rev 525699
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald Depends on D25023 Differential Revision: https://phabricator.services.mozilla.com/D25024
26df801e44db03a402a6a9d3aa6143aa49f78cab: Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 00:21:17 +0000 - rev 525698
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald Depends on D24583 Differential Revision: https://phabricator.services.mozilla.com/D25023
113ac188a69e7d00c828e4400e81eb3dd25fbf46: Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 00:21:14 +0000 - rev 525697
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald Differential Revision: https://phabricator.services.mozilla.com/D24583
46b9df4a18e8b174991aff1b44d6bd1442db91d4: Bug 1539839 - Enable the mainthreadio feature by default for startup profiles, r=gerald.
Florian Quèze <florian@queze.net> - Thu, 28 Mar 2019 21:34:53 +0000 - rev 525474
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539839 - Enable the mainthreadio feature by default for startup profiles, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D25243
303a1f4c20e8d4fadb267a97573ea672f56279f6: Bug 1521370 - Ensure WMF PDM is always initialized on the right thread. r=mattwoodrow,gerald.
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 13 Mar 2019 06:16:52 +0000 - rev 521662
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1521370 - Ensure WMF PDM is always initialized on the right thread. r=mattwoodrow,gerald. And only do it once. Depends on D22874 Differential Revision: https://phabricator.services.mozilla.com/D23247
383f32cdb53bf9d3ce638dfaff490794758bbf0a: Bug 1534893 - Don't attempt to display an invalid TimeUnit. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 13 Mar 2019 06:58:35 +0000 - rev 521657
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1534893 - Don't attempt to display an invalid TimeUnit. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D23273
df1b1891f2f85f34846067282ada1a5260d37139: Bug 1533127 - Force unsigned operation. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 08 Mar 2019 03:03:16 +0000 - rev 520961
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1533127 - Force unsigned operation. r=gerald 1 << 31 is defined since C++14 and produces INT_MIN, but subtracting any positive number from INT_MIN would result in a signed overflow. This can be avoided by making the first argument unsigned (and in this case the second argument will be converted to unsigned as well.) Differential Revision: https://phabricator.services.mozilla.com/D22482
ae40216d31b37aa4a597d3e5c52f31c73bce746b: Bug 1531798 - Avoid deadlock when dumping a profile while the IOInterposer is active, r=gerald,mstange.
Florian Quèze <florian@queze.net> - Tue, 05 Mar 2019 12:01:33 +0000 - rev 520241
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531798 - Avoid deadlock when dumping a profile while the IOInterposer is active, r=gerald,mstange. Differential Revision: https://phabricator.services.mozilla.com/D21712
52fc794e22ee068c2444682cc3329aec53001a53: Bug 1531839 - Don't assume that MP4 blocks are in pts order. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 02 Mar 2019 07:36:55 +0000 - rev 520017
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531839 - Don't assume that MP4 blocks are in pts order. r=gerald It usually is, but obviously, not always. Include reversal of bug 1531241. Differential Revision: https://phabricator.services.mozilla.com/D21823
b03d042670c0d5241e8e57e5af9706e2a57b4c08: Bug 1531201 - Don't assume all frames' time is greater than 0. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 28 Feb 2019 02:34:04 +0000 - rev 519468
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531201 - Don't assume all frames' time is greater than 0. r=gerald We now allow frames to have a negative time (so that they can be decoded and trimmed). Differential Revision: https://phabricator.services.mozilla.com/D21474
a5516893759bb32fb264c2d69c2ae0880697c018: Bug 1530322 - P3. Add temporary diagnostics. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 09:10:04 +0000 - rev 518928
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P3. Add temporary diagnostics. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D21173
8ba89b2f60ff62709b44699b9909c00f3f32a5c0: Bug 1530322 - P2. Remove redundant code, and simplify. r!gerald r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 09:09:54 +0000 - rev 518927
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P2. Remove redundant code, and simplify. r!gerald r=gerald The assertions were unneeded as the test above covered the case. Differential Revision: https://phabricator.services.mozilla.com/D21172
3f3ba8c155c62cfb06f4aef1c392e01d2c8b1d56: Bug 1530322 - P1. Make Interval assertion diagnostic_assert. r!gerald r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 09:09:34 +0000 - rev 518926
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P1. Make Interval assertion diagnostic_assert. r!gerald r=gerald Differential Revision: https://phabricator.services.mozilla.com/D21171
65870fec6eea2103719af73c7369d5242250ecdb: Bug 1530322 - P3. Add diagnostics. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 06:39:57 +0000 - rev 518917
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P3. Add diagnostics. r=gerald Depends on D21172 Differential Revision: https://phabricator.services.mozilla.com/D21173
d5159dfc6d8636fb84fc8447ff15c03f0a4283b0: Bug 1530322 - P2. Remove redundant code, and simplify. r!gerald r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 06:45:32 +0000 - rev 518916
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P2. Remove redundant code, and simplify. r!gerald r=gerald The assertions were unneeded as the test above covered the case. Depends on D21171 Differential Revision: https://phabricator.services.mozilla.com/D21172
68fd0947b767892a557ba92daba8d9895e3856c4: Bug 1530322 - P1. Make Interval assertion diagnostic_assert. r!gerald r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Feb 2019 06:41:32 +0000 - rev 518915
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530322 - P1. Make Interval assertion diagnostic_assert. r!gerald r=gerald Differential Revision: https://phabricator.services.mozilla.com/D21171
ddc76517c3366c8651038ad3df94ca5eb00d1058: Bug 1524890 - P9. Add += and -= operator. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:19:18 +0000 - rev 518679
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524890 - P9. Add += and -= operator. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D20167
2b3f87f5d02c4dad01254642e40e445cfa467740: Bug 1524890 - P2. Add Intersects methods. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 22 Feb 2019 09:18:04 +0000 - rev 518672
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524890 - P2. Add Intersects methods. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D20160
8da76935aebee58a00ce47e9f36dbe65e495ab93: Bug 1528322 - Use a ranged for loop to iterate over chars array, as suggested by static analysis. r=gerald
Markus Stange <mstange@themasta.com> - Fri, 15 Feb 2019 20:51:58 +0000 - rev 517488
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1528322 - Use a ranged for loop to iterate over chars array, as suggested by static analysis. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D19966
27ab5f5e1fd4c759a4161b2a3dad96254292a0ed: Bug 1525223 - Pack ProfileBufferEntry storage without the use of unaligned union members. r=gerald
Markus Stange <mstange@themasta.com> - Fri, 15 Feb 2019 05:42:40 +0000 - rev 517443
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525223 - Pack ProfileBufferEntry storage without the use of unaligned union members. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D19887
2da67ecb372b2f8bea0543526dcaddd307fc3219: Bug 1527228 - Include PlatformMacros.h in order to correctly pick up the GP_ARCH_arm define and turn off packing of the ProfileBufferEntry struct, so that we don't do unaligned accesses on ARM. r=gerald
Markus Stange <mstange@themasta.com> - Fri, 15 Feb 2019 02:14:06 +0000 - rev 517253
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527228 - Include PlatformMacros.h in order to correctly pick up the GP_ARCH_arm define and turn off packing of the ProfileBufferEntry struct, so that we don't do unaligned accesses on ARM. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D19867
1d6f26a48a9a86a28f52416427c606a0bc3cc5fd: Bug 1515209 - Add a text marker for <script> evaluation. r=gerald
Markus Stange <mstange@themasta.com> - Thu, 14 Feb 2019 05:25:13 +0000 - rev 516887
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515209 - Add a text marker for <script> evaluation. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D19189
2250278e1466b921b0ddbe4c0960ec368ecce6f2: Bug 1515209 - Add profiler_add_text_marker and AUTO_PROFILER_TEXT_MARKER_DOCSHELL for convenience, and add the ability to specify cause stacks. r=gerald
Markus Stange <mstange@themasta.com> - Thu, 14 Feb 2019 05:25:45 +0000 - rev 516886
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1515209 - Add profiler_add_text_marker and AUTO_PROFILER_TEXT_MARKER_DOCSHELL for convenience, and add the ability to specify cause stacks. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D19188
b51c6d4af327b290389a94c4ae2e9bdf2547f717: Bug 1526357 - Unregister the IOInterposer before writing the shutdown profile file to disk to avoid a deadlock, r=gerald.
Florian Quèze <florian@queze.net> - Tue, 12 Feb 2019 21:27:45 +0000 - rev 516684
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1526357 - Unregister the IOInterposer before writing the shutdown profile file to disk to avoid a deadlock, r=gerald. Differential Revision: https://phabricator.services.mozilla.com/D19501
fc9cf96cb4bb5adad50a67aa9254c4a8f1a598d9: Bug 1525409 - Rework the IOMarkerPayload structure to include better information; r=gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 06 Feb 2019 14:45:29 +0000 - rev 515303
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525409 - Rework the IOMarkerPayload structure to include better information; r=gerald Differential Revision: https://phabricator.services.mozilla.com/D18743
6a3dbb1faf0498a391635626cb44f9f3abafe3e0: Bug 1512456 - P9. Re-enable assertion. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 17:43:19 +0000 - rev 507210
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P9. Re-enable assertion. r=gerald Depends on D14032 Differential Revision: https://phabricator.services.mozilla.com/D14138
d5c767dcf1bba1d12d4a35c66ddc1a57842c5591: Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:47:01 +0000 - rev 507209
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu Those MozPromises are shared and must be made non-exclusive Differential Revision: https://phabricator.services.mozilla.com/D14032
ef791bbb33b96e7ce90c35c8a4ff59225e4ff611: Bug 1512456 - P7. Chain promises so they can be exclusive. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:54:20 +0000 - rev 507208
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P7. Chain promises so they can be exclusive. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D14031
aac0ba07ae633b5c5edead80b58acc1fe2b9de85: Bug 1512456 - P6. Tidy up some MozPromise usage. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:54:48 +0000 - rev 507207
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P6. Tidy up some MozPromise usage. r=gerald Make consistent use of MozPromise chaining where possible and remove unnecessary refcount. Differential Revision: https://phabricator.services.mozilla.com/D14029
7dfc6f04799cfabed605acf49be2bae064c28077: Bug 1512456 - P5. Refactor WaitForBgParent. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:46:29 +0000 - rev 507206
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P5. Refactor WaitForBgParent. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D14028
710519e214f0f51eaeb9fe7be9368ae908f637ed: Bug 1512456 - P3. Minor cleanup usage of GenericPromise. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:46:21 +0000 - rev 507204
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P3. Minor cleanup usage of GenericPromise. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D14026
15c81f3a8bd884e3de794b2424ba154af69d6a57: Bug 1512456 - P2. Make GenericPromise exclusive. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:46:17 +0000 - rev 507203
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P2. Make GenericPromise exclusive. r=gerald We introduce GenericNonExclusivePromise that can be used to explicitly state than non-exclusive use is needed We temporarily disable the assertion ensuring a promise is used exclusively when needed to allow for things to settle. Differential Revision: https://phabricator.services.mozilla.com/D14025
4e7923ac0159b263bfbe0b6922b485bb65005121: Bug 1512298 - Make IPDL MozPromise exclusive. r=gerald,froydnj
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 19:22:26 +0000 - rev 507201
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512298 - Make IPDL MozPromise exclusive. r=gerald,froydnj MozPromise most common use is to have an single or exclusive listener. By making the MozPromise generated by IPDL exclusive we can also use move semantics. While at it, we also use move semantics for the ResponseRejectReason and via the callback's reject method so that the lambda used with the MozPromise::Then can be identical to the one used by the IPDL callback. As it currently is, it provides no advantage over a copy as it's just an enum; however, this will facilitate future changes where it may not be. Differential Revision: https://phabricator.services.mozilla.com/D13906
25db74150dbfcb550a538f361c9c99555148374f: Bug 1510265 - P2. Don't use AllPromiseType in GMPServiceParent. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 06 Dec 2018 20:16:15 +0000 - rev 506006
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1510265 - P2. Don't use AllPromiseType in GMPServiceParent. r=gerald It's not needed, and only makes code harder to follow. Differential Revision: https://phabricator.services.mozilla.com/D13869
0de0365e049fea70c203850963577bbabdf88577: Bug 1510265 - P1. Enforce template-parameter classes restrictions in MozPromise. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 06 Dec 2018 16:26:01 +0000 - rev 506005
Push 10304 by csabou@mozilla.com at Mon, 10 Dec 2018 13:40:42 +0000
Bug 1510265 - P1. Enforce template-parameter classes restrictions in MozPromise. r=gerald And some required fixes to make things compile. Differential Revision: https://phabricator.services.mozilla.com/D13868
209ed62867bf0159b4d9a49fdd98bcea43c64287: Bug 1509462 - Make DecoderDoctorLifeLogger constructor/destructor protected. r=gerald
Alex Chronopoulos <achronop@gmail.com> - Tue, 27 Nov 2018 20:46:19 +0000 - rev 504908
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1509462 - Make DecoderDoctorLifeLogger constructor/destructor protected. r=gerald DecoderDoctorLifeLogger is used as a base class in many classes but it does need to have a virtual destructor to avoid adding a vtable in the class. Thus the constructor and destructor become protected to avoid being used as base pointer to delete the real object. Differential Revision: https://phabricator.services.mozilla.com/D13074
99321f96fd0c043d5a72a26bd0ff6e49759af698: Bug 1505284 - P3. Ensure gfxVars and gfxPrefs are always initialized when using PDMFactory. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 22 Nov 2018 16:31:03 +0000 - rev 504157
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505284 - P3. Ensure gfxVars and gfxPrefs are always initialized when using PDMFactory. r=gerald While typically those will always be, when using through gtest it won't. Differential Revision: https://phabricator.services.mozilla.com/D12519
ce4515855b43514b4ee6e5ef8d450ed2dbfb1a73: Bug 1507922 - make ownership of MetadataTags more clear in the ogg code; r=gerald,jya
Nathan Froyd <froydnj@mozilla.com> - Tue, 20 Nov 2018 10:10:31 -0500 - rev 503704
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507922 - make ownership of MetadataTags more clear in the ogg code; r=gerald,jya Use UniquePtr for return types, so it's obvious who has ownership.
aa7084b3c14b8500210e7065ffd172f1506f0cd4: Bug 1507093 - P2. Ensure that when returning from NotifyXPCOMShutdown we don't UAF. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 15 Nov 2018 12:48:02 +0000 - rev 503004
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507093 - P2. Ensure that when returning from NotifyXPCOMShutdown we don't UAF. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D11858
2dcd2dc5f9e2a075aaf5f94f29ce1fef4344a860: Bug 1507093 - P1. Ensure we never leak OwnerType object. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 15 Nov 2018 12:47:59 +0000 - rev 503003
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1507093 - P1. Ensure we never leak OwnerType object. r=gerald Potentially, if the watcher notification task failed to dispatch, we would have a cycle left between the WatchManager and the OwnerType Differential Revision: https://phabricator.services.mozilla.com/D11857
bcf48a8dba79f51f291e476053fab60e6586c9f3: Bug 1505910 - P3. Remove now unused AsTaskQueue(). r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 21:38:38 +0000 - rev 502287
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505910 - P3. Remove now unused AsTaskQueue(). r=gerald Depends on D11492 Differential Revision: https://phabricator.services.mozilla.com/D11493
1dab4c7062aeae80016ca8043a752271b6ab8a94: Bug 1505910 - P1. Remove taskqueue's shutdown in Benchmark. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 21:36:43 +0000 - rev 502285
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505910 - P1. Remove taskqueue's shutdown in Benchmark. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D11491