searching for reviewer(gcp)
cae2f8c62a2a: Bug 1466593 - When sandboxing the content process on OpenBSD, fake a DBUS session if none is running r=gcp a=pascalc
Landry Breuil <landry@openbsd.org> - Thu, 06 Sep 2018 09:54:00 +0300 - rev 489806
Push 9788 by ebalazs@mozilla.com at 2018-09-12 11:37 +0000
Bug 1466593 - When sandboxing the content process on OpenBSD, fake a DBUS session if none is running r=gcp a=pascalc
152b2a1144ae: Bug 1457092 - set conservative default values for pledge() sandboxing on OpenBSD. r=gcp
Landry Breuil <landry@openbsd.org> - Thu, 23 Aug 2018 07:33:00 +0300 - rev 488925
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1457092 - set conservative default values for pledge() sandboxing on OpenBSD. r=gcp
411427c1f5fe: Bug 1457092 - Content sandbox codepaths are Linux only. r=gcp
Landry Breuil <landry@openbsd.org> - Wed, 22 Aug 2018 05:27:00 -0400 - rev 488182
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1457092 - Content sandbox codepaths are Linux only. r=gcp
8f5c17ac83aa: Bug 1457092 - Implement sandboxing on OpenBSD. r=gcp, r=jld
Landry Breuil <landry@openbsd.org> - Thu, 23 Aug 2018 07:35:00 -0400 - rev 488181
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1457092 - Implement sandboxing on OpenBSD. r=gcp, r=jld Add StartOpenBSDSandbox method calling pledge() syscall, and use it where we're sandboxing processes. The pledge subsets are coming from two new prefs: - security.sandbox.pledge.content for the content process - security.sandbox.pledge.main for the main process
366a2aa802b5: Bug 1478575 - Unify CamerasChild shutdown paths. r=gcp
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 20 Aug 2018 10:44:49 +0200 - rev 488014
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1478575 - Unify CamerasChild shutdown paths. r=gcp
73e2097aa0c3: Bug 1485142: Make url-classifier 'PartialHashHex()' API return a nsAutoCString instead of nsCString, to address build warning & reduce copying. r=gcp
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 22 Aug 2018 16:51:56 +0000 - rev 487970
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1485142: Make url-classifier 'PartialHashHex()' API return a nsAutoCString instead of nsCString, to address build warning & reduce copying. r=gcp Before this patch -- with the nsCString return type -- we have to do heap allocation and copying to produce the return value. But the callers don't actually care about having a nsCString -- they just call .get() to access the character buffer, and log it, and then they're done. They can do this just as easily with the stack-allocated nsAutoCString that PartialHashHex() works with locally, so let's change the return type so that Return Value Optimization can give them that variable directly and avoid needless copying/allocation. This patch addresses the following clang 8.0 build warning: LookupCache.h:63:12 [-Wreturn-std-move] local variable 'hex' will be copied despite being returned by name Differential Revision: https://phabricator.services.mozilla.com/D3920
8743877cec09: Bug 1480554 - Fix missing include in SandboxOpenedFiles.cpp. r=gcp
Jed Davis <jld@mozilla.com> - Thu, 16 Aug 2018 09:15:56 -0600 - rev 487065
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1480554 - Fix missing include in SandboxOpenedFiles.cpp. r=gcp
02395f0e8074: Bug 1439057 - Tighten /dev/shm access in Linux content sandbox policy. r=gcp
Jed Davis <jld@mozilla.com> - Tue, 31 Jul 2018 10:41:29 -0600 - rev 484555
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1439057 - Tighten /dev/shm access in Linux content sandbox policy. r=gcp This patch uses the shared memory name prefixes introduced in bug 1447867 to prevent access to /dev/shm files of other applications or other processes within the same browser instance. When a shared memory implementation that doesn't use shm_open is available (specifically, the memfd_create support to be added in bug 1440203), /dev/shm access is completely denied. MozReview-Commit-ID: L2ylG5KrXTU
ecae69f91831: Bug 1243108 - Work around Linux kernel bug causing broker responses to be dropped. r=gcp
Jed Davis <jld@mozilla.com> - Thu, 19 Jul 2018 18:20:03 -0600 - rev 483165
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1243108 - Work around Linux kernel bug causing broker responses to be dropped. r=gcp MozReview-Commit-ID: LX2kEXybFGW
564e53c57905: Bug 1476340: Fix DEAD_STORE errors in security/sandbox/linux/*. r=gcp
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 18:30:09 +0100 - rev 482580
Push 9719 by ffxbld-merge at 2018-08-24 17:49 +0000
Bug 1476340: Fix DEAD_STORE errors in security/sandbox/linux/*. r=gcp MozReview-Commit-ID: 3jNPRWGb7rU
0d676b757477: Bug 1478575 - Unify CamerasChild shutdown paths. r=gcp, a=RyanVM
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 20 Aug 2018 10:44:49 +0200 - rev 478555
Push 9712 by ryanvm@gmail.com at 2018-08-23 12:41 +0000
Bug 1478575 - Unify CamerasChild shutdown paths. r=gcp, a=RyanVM
1489fb7b99b4: Bug 1467581 - Replace all nsAutoPtrs with UniquePtrs in Safe Browsing code. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 18 Jun 2018 13:54:59 -0700 - rev 477336
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1467581 - Replace all nsAutoPtrs with UniquePtrs in Safe Browsing code. r=gcp This should not change anything since we were using nsAutoPtrs properly, but we may as well clean this up given the recent move to smart pointers for everything. MozReview-Commit-ID: FWS54SYNiBm
5beee22d04c9: Bug 1467581 - Do less work in Reset() if Close() has been called. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 07 Jun 2018 17:45:46 -0700 - rev 477335
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1467581 - Do less work in Reset() if Close() has been called. r=gcp If Reset() is interleaved with a shutdown, there's no point in finishing up and we may as well bail early. MozReview-Commit-ID: Lhm6NfAEgSj
145132e9d947: Bug 1467581 - Remove the use of default captures in closures. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 07 Jun 2018 17:22:32 -0700 - rev 477334
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1467581 - Remove the use of default captures in closures. r=gcp Explicitly specify the arguments to copy to avoid making a copy of a dangling `this` pointer. Convert nsUrlClassifierDBService::mClassifier to a RefPtr since the update closure might need to continue to access its members after it's been released by the main thread. MozReview-Commit-ID: CPio3n9MmsK
1e68fab00d81: Bug 1469427 - Add settings shortcuts to download protection. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 18 Jun 2018 15:43:54 -0700 - rev 477333
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1469427 - Add settings shortcuts to download protection. r=gcp Files with this extension are used to create shortcuts to Windows setting pages. This apparently allows invoking any binary file with any parameters. MozReview-Commit-ID: 6WOEaVG7Lq5
d9da944ee84e: Bug 1469427 - Add AppleScript-related extensions to download protection. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 18 Jun 2018 15:40:21 -0700 - rev 477332
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1469427 - Add AppleScript-related extensions to download protection. r=gcp MozReview-Commit-ID: Dc0gyfnmki8
1151c924c029: Bug 1457092 - Only include SandboxBroker.h header on Linux sandbox. r=gcp
Landry Breuil <landry@openbsd.org> - Sat, 09 Jun 2018 08:44:00 -0400 - rev 476299
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1457092 - Only include SandboxBroker.h header on Linux sandbox. r=gcp
bcb06541c394: Bug 1467604 - Add .slk to the list of extensions covered by download protection. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 07 Jun 2018 15:00:45 -0700 - rev 476183
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467604 - Add .slk to the list of extensions covered by download protection. r=gcp MozReview-Commit-ID: 2cjfjL81y5G
e3d40506f24d: Bug 1452445 - Fix update error observer in unit test. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 29 May 2018 18:06:49 -0700 - rev 476121
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1452445 - Fix update error observer in unit test. r=gcp We should only observe for update errors while we are expecting a successful update. MozReview-Commit-ID: 3grGhmxqhIX
c09d2eeb54af: Bug 1434206 - Keep LookupResult objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 05 Jun 2018 13:15:03 -0700 - rev 476094
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Keep LookupResult objects in smart pointers. r=gcp Replace raw pointers to LookupResult with RefPtrs and eplace the nsAutoPtr objects + raw pointers params with UniquePtrs. Also remove unnecessarily paranoid OOM checks when creating single LookupResult objects since those are pretty small. MozReview-Commit-ID: G85RNnAat6H
78b075a48d8f: Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 24 May 2018 16:40:35 -0700 - rev 476093
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Make DBSserviceWorkerProxy as const as possible. r=gcp MozReview-Commit-ID: KPzzmb1Jehi
2b8b83d5ce3c: Bug 1434206 - Keep CacheResult objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:49:14 -0700 - rev 476092
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Keep CacheResult objects in smart pointers. r=gcp Some of the objects were kept in UniquePtr and nsAutoPtr but that seemed unnecessary complexity given that we can simply use RefPtr everywhere. It's also possible to make all of the CacheResult arrays const since we don't ever modify the elements once they are added. MozReview-Commit-ID: 5OlcbkQLrGb
789a09ee0980: Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:58:12 -0700 - rev 476091
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Clarify when the lookupcache arrays should be cleared. r=gcp MozReview-Commit-ID: 7smtnCC0MGT
080d38cebb99: Bug 1434206 - Make LookupCache objects const as much as possible. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 21 May 2018 15:11:01 -0700 - rev 476090
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Make LookupCache objects const as much as possible. r=gcp MozReview-Commit-ID: AqC6NUh6ifm
5d8b0206bfb4: Bug 1434206 - Keep LookupCache objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 19:13:48 -0700 - rev 476089
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Keep LookupCache objects in smart pointers. r=gcp The existing mix of UniquePtr and raw pointers is confusing when trying to figure out the exact lifetime of these objects. MozReview-Commit-ID: Br4S7BXEFKs
0980a35455a0: Bug 1434206 - Add const to functions and members that can take it. r=gcp
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:39:33 -0700 - rev 476088
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Add const to functions and members that can take it. r=gcp MozReview-Commit-ID: D8IQoLZkFaA
2a73d497179a: Bug 1434206 - Replace a pointer with a reference. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 15 May 2018 17:18:18 -0700 - rev 476087
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Replace a pointer with a reference. r=gcp This will prevent our holding on to this pointer incorrectly in the future. MozReview-Commit-ID: H8ueIOK1qAK
653f77b66d23: Bug 1434206 - Make TableUpdate objects const as much as possible. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 16:02:37 -0700 - rev 476086
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Make TableUpdate objects const as much as possible. r=gcp I tried to make TableUpdateArray point to const TableUpdate objects everywhere but there were two problems: - HashStore::ApplyUpdate() triggers a few Merge() calls which include sorting the underlying TableUpdate object first. - LookupCacheV4::ApplyUpdate() calls TableUpdateV4::NewChecksum() when the checksum is missing and that sets mChecksum. MozReview-Commit-ID: LIhJcoxo7e7
00affedf529b: Bug 1434206 - Keep TableUpdate objects in smart pointers. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:48:48 -0700 - rev 476085
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Keep TableUpdate objects in smart pointers. r=gcp Manually keeping tabs on the lifetime of these objects is a pain and is the likely source of some of our crashes. I suspect we might also be leaking memory. This change creates an explicit copy of the main array into the update thread to avoid using a non-thread-safe shared data structure. This is a shallow copy. Only the pointers to the TableUpdates are copied, which means one pointer per list (e.g. 5 in total for google4 in a new profile). MozReview-Commit-ID: 221d6GkKt0M
dbbfc8fd8005: Bug 1434206 - Assert that gethash processing happens on the right thread. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 11 May 2018 11:47:26 -0700 - rev 476084
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Assert that gethash processing happens on the right thread. r=gcp MozReview-Commit-ID: FbF8LzCZ3XO
757ddfe57c0c: Bug 1434206 - Don't cache gethash response if we failed to apply results. r=gcp
Francois Marier <francois@mozilla.com> - Fri, 01 Jun 2018 15:33:30 -0700 - rev 476083
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Don't cache gethash response if we failed to apply results. r=gcp MozReview-Commit-ID: APJ1qhofU3t
f2fe038eada3: Bug 1434206 - Use a TableUpdateV2 param in ApplyUpdate(). r=gcp
Francois Marier <francois@mozilla.com> - Thu, 10 May 2018 16:06:49 -0700 - rev 476082
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Use a TableUpdateV2 param in ApplyUpdate(). r=gcp HashStore::ApplyUpdate() is a V2-only function and so we can be explicit about that and remove unnecessary casts. Add a new update error code for when we fail to cast a TableUpdate object to the expected protocol version. MozReview-Commit-ID: 65BBwiZJw6J
38f1a6d6877e: Bug 1434206 - Clear the current table when protocol parser is done. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 10 May 2018 17:58:01 -0700 - rev 476081
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Clear the current table when protocol parser is done. r=gcp Add assertions in the functions that don't already test for mTableUpdate just to be extra-safe. MozReview-Commit-ID: 8R67SLSgj23
61a5f7d03cef: Bug 1434206 - Add const to members and functions that can take it. r=gcp
Francois Marier <francois@mozilla.com> - Wed, 16 May 2018 15:26:14 -0700 - rev 476080
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Add const to members and functions that can take it. r=gcp MozReview-Commit-ID: B2aaQTttPAV
56323b585c58: Bug 1434206 - Remove unused and undefined functions. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 28 May 2018 14:39:32 -0700 - rev 476079
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1434206 - Remove unused and undefined functions. r=gcp mProtocolV2 is still used to skip the caching of misses on V4: https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1353-1357 MozReview-Commit-ID: 2cHh9JiZuHh
99f438f07d89: Bug 1452445 - Fix update error observer in unit test. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 29 May 2018 18:06:49 -0700 - rev 475908
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1452445 - Fix update error observer in unit test. r=gcp We should only observe for update errors while we are expecting a successful update. MozReview-Commit-ID: 3grGhmxqhIX
486bd3917dee: Bug 1414051 - Move ThreatHit protobuf details to the body. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 19 Feb 2018 16:18:37 -0800 - rev 475851
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1414051 - Move ThreatHit protobuf details to the body. r=gcp Mark that channel as anonymous in order to prevent any cookies from being set here and potentially tie these proxied requests to list updates which will not go through the proxy. Also fix a return code in the case that httpChannel fails to QI. MozReview-Commit-ID: BaRyYRlUbsB
c74eb9a24c8b: Bug 1462640 - Allow content processes to mincore() individual pages. r=gcp
Jed Davis <jld@mozilla.com> - Fri, 18 May 2018 17:36:47 -0600 - rev 473540
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1462640 - Allow content processes to mincore() individual pages. r=gcp MozReview-Commit-ID: IclghYFyMPp
e881e8e454eb: Bug 1452445 - Fix update error observer in unit test. r=gcp, a=test-only
Francois Marier <francois@mozilla.com> - Tue, 29 May 2018 18:06:49 -0700 - rev 471244
Push 9342 by ryanvm@gmail.com at 2018-06-09 13:42 +0000
Bug 1452445 - Fix update error observer in unit test. r=gcp, a=test-only We should only observe for update errors while we are expecting a successful update. MozReview-Commit-ID: 3grGhmxqhIX
a761c0e32512: Bug 1452445 - Promote MOZ_LOG calls to NS_WARNING in LookupCacheV4. r=gcp
Francois Marier <francois@mozilla.com> - Mon, 30 Apr 2018 16:44:35 -0700 - rev 470563
Push 9184 by archaeopteryx@coole-files.de at 2018-05-06 20:01 +0000
Bug 1452445 - Promote MOZ_LOG calls to NS_WARNING in LookupCacheV4. r=gcp This should help narrow down which of the code paths is responsible for the intermittent failures we are seeing. MozReview-Commit-ID: JHVZzixpOg6
c7f6d061d06c: Bug 1434662 - Move initialization code to ProtocolParser::Begin(). r=gcp
Francois Marier <francois@mozilla.com> - Tue, 24 Apr 2018 10:08:56 +0200 - rev 468816
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Move initialization code to ProtocolParser::Begin(). r=gcp Repurpose the previously unused Begin() function to initialize ProtocolParser objects and also assert that we are not reusing objects across update since that's not supported. MozReview-Commit-ID: HIGGgOr388h
e1f41b9f1d44: Bug 1434662 - Remove dead code. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 19 Apr 2018 16:06:40 -0700 - rev 468815
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Remove dead code. r=gcp This check was added in bug 1296820 to disable V4 updates prior to their being implemented. It should have been removed once we landed working support for V4 updates. MozReview-Commit-ID: 828DIS72LNi
7bbbf41e9210: Bug 1434662 - Reset Safe Browsing V4 tables that fail to update. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 12 Apr 2018 10:11:30 -0700 - rev 468814
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Reset Safe Browsing V4 tables that fail to update. r=gcp This is a generalization of the reset code that's used in pver2 to reset all tables when a `pleasereset` command is received. MozReview-Commit-ID: LF4RegQHqoT
983099e546d8: Bug 1434662 - Move initialization code to ProtocolParser::Begin(). r=gcp
Francois Marier <francois@mozilla.com> - Thu, 19 Apr 2018 17:10:45 -0700 - rev 468571
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Move initialization code to ProtocolParser::Begin(). r=gcp Repurpose the previously unused Begin() function to initialize ProtocolParser objects and also assert that we are not reusing objects across update since that's not supported. MozReview-Commit-ID: HIGGgOr388h
39b9f46104ad: Bug 1434662 - Remove dead code. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 19 Apr 2018 16:06:40 -0700 - rev 468570
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Remove dead code. r=gcp This check was added in bug 1296820 to disable V4 updates prior to their being implemented. It should have been removed once we landed working support for V4 updates. MozReview-Commit-ID: 828DIS72LNi
6f652d798a0c: Bug 1434662 - Reset Safe Browsing V4 tables that fail to update. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 12 Apr 2018 10:11:30 -0700 - rev 468569
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1434662 - Reset Safe Browsing V4 tables that fail to update. r=gcp This is a generalization of the reset code that's used in pver2 to reset all tables when a `pleasereset` command is received. MozReview-Commit-ID: LF4RegQHqoT
baeab3bff807: Bug 1439057 - Tighten /dev/shm access in Linux content sandbox policy. r=froydnj,gcp
Jed Davis <jld@mozilla.com> - Thu, 12 Apr 2018 23:48:16 -0600 - rev 468169
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1439057 - Tighten /dev/shm access in Linux content sandbox policy. r=froydnj,gcp This patch uses the shared memory name prefixes introduced in bug 1447867 to prevent access to /dev/shm files of other applications or other processes within the same browser instance. When a shared memory implementation that doesn't use shm_open is available (specifically, the memfd_create support to be added in bug 1440203), /dev/shm access is completely denied. MozReview-Commit-ID: L2ylG5KrXTU
e63436b2efb3: Bug 1438671 - Remove the std::string wrapper in TableUpdateV4. r=gcp
Francois Marier <francois@mozilla.com> - Tue, 03 Apr 2018 17:11:30 -0700 - rev 465708
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1438671 - Remove the std::string wrapper in TableUpdateV4. r=gcp Given we're no longer using dependent strings in LookupCacheV4::PrefixString(), we will end up make a copy of the prefixes at some point. Let's do it early and remove a bunch of complicated code. Make the string copies fallible so that we return an error and fail the update instead of crashing. MozReview-Commit-ID: 5cZHSDIJSlD
bbacf34b38b9: Bug 1438671 - Add assertions to enforce the size of prefix strings. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 29 Mar 2018 15:40:13 -0700 - rev 465707
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1438671 - Add assertions to enforce the size of prefix strings. r=gcp Also document the meaning of mPrimed in LookupCache.h. MozReview-Commit-ID: 63GAHwU3Rx3
40b6b9a6bb95: Bug 1438671 - Remove some inappropriate uses of dependent strings. r=gcp
Francois Marier <francois@mozilla.com> - Thu, 29 Mar 2018 16:31:39 -0700 - rev 465706
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1438671 - Remove some inappropriate uses of dependent strings. r=gcp Dependent strings are recommended only when dealing with a character buffer (i.e. char*). Using it here makes it more likely that we'll hang on to a string buffer that will be deallocated. nsCString will by default share the underlying string buffers when it can (i.e. when copying entire strings on the heap) so it should be able to avoid unnecessary copies. MozReview-Commit-ID: 3rTUYmouzcT