searching for reviewer(gchang)
0e762fc7cb7446469e69b47932cbbdeccf50ecb2: Bug 1414789: Backout Stylo DOM APIs from beta. r=xidorn a=gchang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Feb 2018 14:38:05 +1100 - rev 452143
Push 8626 by xquan@mozilla.com at Thu, 01 Feb 2018 03:38:47 +0000
Bug 1414789: Backout Stylo DOM APIs from beta. r=xidorn a=gchang MozReview-Commit-ID: BW5BZpC63B8
93d75578332a47337e54424757c27cb3a103c0d8: Bug 1431282. Work around layout violating its own invariants and causing stylo code to crash, _again_. r=emilio, a=gchang FIREFOX_58b_RELBRANCH
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 03 Oct 2017 18:50:10 -0400 - rev 451526
Push 8555 by ryanvm@gmail.com at Thu, 18 Jan 2018 15:36:59 +0000
Bug 1431282. Work around layout violating its own invariants and causing stylo code to crash, _again_. r=emilio, a=gchang MozReview-Commit-ID: 3ggJI0qmOJV
63bf6cd0005459718a8a4a51bc3a7670aad5cdd2: bug 1429666 cubeb_resampler_speex: don't call data callback while draining r=padenot a=gchang FIREFOX_58b_RELBRANCH
Karl Tomlinson <karlt+@karlt.net> - Thu, 11 Jan 2018 13:30:24 +1300 - rev 451214
Push 8549 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:46:03 +0000
bug 1429666 cubeb_resampler_speex: don't call data callback while draining r=padenot a=gchang MozReview-Commit-ID: 1XEzZjPGai9
00868cd43957fa7b9f2a2cfc34230cf259fd86e5: Bug 1421345 - Check the canary during allocations. r=jet a=gchang FIREFOX_58b_RELBRANCH
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 17 Jan 2018 12:07:34 +1300 - rev 451213
Push 8549 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:46:03 +0000
Bug 1421345 - Check the canary during allocations. r=jet a=gchang
4ca9cf8165105bec7ce5327b5db307f4968eb11d: Bug 1401459 - always run HttpChannelChild::Release on main thread. r=mayhemer a=gchang FIREFOX_58b_RELBRANCH
Shih-Chiang Chien <schien@mozilla.com> - Thu, 11 Jan 2018 10:40:29 +0800 - rev 451212
Push 8549 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:46:03 +0000
Bug 1401459 - always run HttpChannelChild::Release on main thread. r=mayhemer a=gchang
f2fa08b4da33d1e44babe1de999ee078d7ac85cf: Bug 1430522 - [Form Autofill] Enable address autofill by default on release build. r=seanlee a=gchang FIREFOX_58b_RELBRANCH
Luke Chang <lchang@mozilla.com> - Mon, 15 Jan 2018 15:56:53 +0800 - rev 451211
Push 8549 by archaeopteryx@coole-files.de at Wed, 17 Jan 2018 10:46:03 +0000
Bug 1430522 - [Form Autofill] Enable address autofill by default on release build. r=seanlee a=gchang MozReview-Commit-ID: 9Pf8l7PqSMi
db3476b3775994ca22aebbd17854b9a53d2a50b5: Bug 1425612 - Better error messages for invalid structured clone data. r=sfink, a=gchang. FIREFOX_58b_RELBRANCH
Jason Orendorff <jorendorff@mozilla.com> - Wed, 10 Jan 2018 20:45:39 -0600 - rev 450756
Push 8542 by archaeopteryx@coole-files.de at Tue, 16 Jan 2018 09:23:07 +0000
Bug 1425612 - Better error messages for invalid structured clone data. r=sfink, a=gchang.
9624359659f033a34985be234cec79efb045bb87: Bug 1426783 - Fix error handling in deserialization of invalid typed arrays. r=sfink, a=gchang. FIREFOX_58b_RELBRANCH
Jason Orendorff <jorendorff@mozilla.com> - Fri, 05 Jan 2018 15:17:35 -0600 - rev 450755
Push 8542 by archaeopteryx@coole-files.de at Tue, 16 Jan 2018 09:23:07 +0000
Bug 1426783 - Fix error handling in deserialization of invalid typed arrays. r=sfink, a=gchang.
2e92b07020a5ce08fb5d1b263b38ca438424e1d4: Bug 1421345 - Check the canary during allocations. r=jet a=gchang FIREFOX_58b_RELBRANCH
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 15 Jan 2018 21:12:57 +1300 - rev 450753
Push 8540 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 11:43:22 +0000
Bug 1421345 - Check the canary during allocations. r=jet a=gchang
ff49cdee1a3d4221d20fa7ff554f77ee1b2553f3: Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang FIREFOX_58b_RELBRANCH
Tom Ritter <tom@mozilla.com> - Thu, 11 Jan 2018 14:25:14 -0600 - rev 450749
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang MozReview-Commit-ID: F96EUfXgK9F
0c5b5676912d96f13661c832bd596c783e933533: Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang FIREFOX_58b_RELBRANCH
Dragana Damjanovic dd.mozilla@gmail.com - Thu, 11 Jan 2018 10:17:00 +0200 - rev 450748
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
72faa446f04e76ee1fc25dd96cf90ce78be987d9: Bug 1427221 - Do nsMathMLmfencedFrame cleanup in DestroyFrom, not in the dtor. r=mattwoodrow a=gchang FIREFOX_58b_RELBRANCH
Mats Palmgren <mats@mozilla.com> - Tue, 09 Jan 2018 04:32:00 +0200 - rev 450747
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1427221 - Do nsMathMLmfencedFrame cleanup in DestroyFrom, not in the dtor. r=mattwoodrow a=gchang
1485c1f848a7d9e3f661252563b8eca592242b3a: Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang FIREFOX_58b_RELBRANCH
Michael Kaply <mozilla@kaply.com> - Thu, 21 Dec 2017 12:58:56 -0600 - rev 450746
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang MozReview-Commit-ID: JfSwJwMC46F
fc52af7442696c98d18f5642845d69d16124c732: Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 11 Jan 2018 10:31:17 -0500 - rev 450745
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 0d: Move browser_multie10s_update.js into its own directory. r=bkelly a=gchang This test is unfortunately a victim of a multi-e10s unregister() race from browser_force_refresh and given the imminent multi-e10s cleanup that's going to happen, the more complicated alternatives aren't worth the effort versus just moving this test to its own directory. ..and now it's disabled too. Bug 1429794 tracks re-enabling.
8668774ec233e58359fb27167ef1a12df4c32b1b: Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 17:31:01 -0500 - rev 450744
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 0c: browser_multie10s_update.js should not use setTimeout. r=bkelly a=gchang This test used a fixed setTimeout of 3secs for serving the SW. This lower-bounded the test runtime at 6 seconds, plus it was not safe in the event of a slow test runner. This set of changes, although a little ugly, improves the logic so that the SW's transmission is driven by a separate "release" fetch that is only triggered when both updates have been issued and the first update failure has been reported. This ensures we are observing the desired situation. There's also a sanity check on the number of times the SW script is fetched.
dcaced69fe4c60d822c669801778f0140330a41e: Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Tue, 09 Jan 2018 16:16:24 -0500 - rev 450743
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 0b: browser_multie10s_update.js needs to protect its invariants, clean-up after itself. r=bkelly a=gchang
f9005d863b4aa430aa08bd98c77c3b58c155a7af: Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Wed, 10 Jan 2018 12:38:25 -0500 - rev 450742
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 0a: Make browser_force_refresh.js clean up after itself. r=bkelly a=gchang
de5ea9bcb2cef9c2bb57de036093197ae3b2a1a1: Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:43 -0500 - rev 450741
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 6: Test cancellation of diverted client-intercepted streams. r=bkelly a=gchang This adds a test where we have a ServiceWorker return 2 different types of streams that Firefox recognizes as downloads which are handled by diversion of the channel to the parent. The diverted downloads are then cancelled and we verify that cancellation actually results in the underlying connections being closed and/or the ServiceWorker notified. Our 2 types of streams are: 1. A pass-through stream that is incrementally delivered through use of an .sjs file that delivers data using setInterval. 2. A SW-authored ReadableStream (which is not enabled by default, so we set a pref.) Determining when the .sjs's stream is canceled is accomplished by opening a second "monitor" connection that only completes when the streaming connection is closed. In all cases we differentiate between cancelation and timeouts firing.
d06c21f21ec73a1b817feeddf6802b9767b68362: Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:09:32 -0500 - rev 450740
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 5: FetchStreamReader needs to cancel its reader when it encounters write errors. r=baku, f=bkelly a=gchang Currently, FetchStreamReader never signals to the JS stream code that the reader has been closed. This means that when a ServiceWorker passes a ReadableStream to respondWith and the HTTP Channel gets canceled, the JS code will keep generating the stream without ever realizing the data's not going anywhere. It's necessary to cancel the reader. Or do something like that, this seems to work!
20f5dafc5c3bdbd32c9c281b39fb30586c50e37d: Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:04:55 -0500 - rev 450739
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 4: FetchDriver needs to propagate write failures. r=baku a=gchang In the scenario where a ServiceWorker returns a pass-through fetch via `evt.respondWith(fetch("underlying"))`, in order for the "underlying" HTTP channel to be canceled when the outer HTTP channel is canceled, FetchDriver's OnDataAvailable method needs to return an error when the output pipe experiences an error. Unfortunately, the contract for ReadSegments is effectively that it returns NS_OK regardless of what the rv of the write handler returned, so relying on the returned rv is insufficient. And because various Write*() methods will all fast-path to returning NS_OK if a count of 0 is passed, it's necessary to infer a closed/broken pipe by noticing that we tried to write more than 0 bytes of data but 0 bytes were written. (This is safe because the pipe we write into was created by FetchDriver::OnStartRequest which explicitly creates an infinite pipe, so it's not possible for the write to fail due to lack of space in the pipe.)
3a6d8ac9b23a01b749c5f151df2f80b9e8cf9fde: Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 13:59:13 -0500 - rev 450738
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 3: (Also Bug 1418795) SyntheticDiversionListener should handle !mIPCOpen. r=bkelly a=gchang The SyntheticDiversionListener needs to handle the case where the IPC connection is gone. This patch avoids calling Send* methods which will crash the content process if the actor has already been destroyed. Additionally, OnDataAvailable will return an error in such a case so that the caller can properly handle the error rather than continuing to attempt to send data to a listener that doesn't care. This latter change is an artifact of a previous hack attempt to fix a related diversion issue that is probably not required for this stack, but makes sense as a fix, so I've left it in.
9a2858960c24e4d855d7fe0560cb406f1b3a8732: Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:38:07 -0500 - rev 450737
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 2: Allow for diversion cancellation and trigger for intercepted channels. r=bkelly, r=mayhemer a=gchang The diversion mechanism never expected to be dealing with data sourced from the content process, but that's exactly what happens with ServiceWorker-intercepted channels with the current child-intercept situation (which is being fixed). In order to allow timely cancellation of diverted intercepted channels, there needs to be a way to relay to the HttpChannelChild that it needs to be canceled so that the synthesized pump can be canceled and diversion can be marked as complete. This patch adds such a mechanism to ADivertableParentChannel and PHttpChannel for the exclusive use of InterceptedHttpChannel and then uses it.
0d0a70391f7357cb48dfdc5814cfbd77be3cabab: Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrew Sutherland <asutherland@asutherland.org> - Thu, 04 Jan 2018 18:56:46 -0500 - rev 450736
Push 8538 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:26:11 +0000
Bug 1416879 - Part 1: DivertComplete should only be sent at OnStopRequest for synthesized responses. r=bkelly a=gchang Diversion for intercepted channels with a synthesized response is a special case. It is not appropriate to send DivertComplete when mEventQ has been drained, because we are not dealing with the usual mEventQ-enqueued OnDataAvailable payloads that had been received over the network and sent down to the child. In this case, all the data originates in the child and does not go through mEventQ. As such, the correct place to send DivertComplete is at OnStopComplete for the synthesized response.
05f9d3f417524ae6a4b8438a3c29b21d014e0da6: Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang
Tom Ritter <tom@mozilla.com> - Thu, 11 Jan 2018 14:25:14 -0600 - rev 450735
Push 8537 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:10:15 +0000
Bug 1429885 Support a rounding value of 0 for reduceTimerPrecision r=bkelly,timhuang a=gchang MozReview-Commit-ID: F96EUfXgK9F
6af0590440039c44a5299a8432a0b9f3e1566b13: Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
Dragana Damjanovic dd.mozilla@gmail.com - Thu, 11 Jan 2018 10:17:00 +0200 - rev 450734
Push 8537 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:10:15 +0000
Bug 1429859 - Check mDoNotTryEarlyData in Do0RTT(). r=mcmanus a=gchang
912e6c9630a185d5f14388704a11c5e5ac8f2fec: Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang
Michael Kaply <mozilla@kaply.com> - Thu, 21 Dec 2017 12:58:56 -0600 - rev 450733
Push 8537 by archaeopteryx@coole-files.de at Mon, 15 Jan 2018 10:10:15 +0000
Bug 1426081 - Migrate legacy search engines to WebExtensions. r=florian a=gchang MozReview-Commit-ID: JfSwJwMC46F
77e197f877508cfcffb11e05252a09f9930b93b1: Bug 1424341 Add privacy.reduceTimerPrecision and privacy.reduceTimerPrecision.microseconds prefs and tests r=bkelly,timhuang,mrbkap a=gchang FIREFOX_58b_RELBRANCH
Tom Ritter <tom@mozilla.com> - Wed, 10 Jan 2018 13:50:28 -0600 - rev 450731
Push 8535 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:26:02 +0000
Bug 1424341 Add privacy.reduceTimerPrecision and privacy.reduceTimerPrecision.microseconds prefs and tests r=bkelly,timhuang,mrbkap a=gchang This pref does not override privacy.resistFingerprinting, but when it is set (and privacy.resistFingerprinting is not) we will still adjust the precision of almost all timers. The adjustment amount is the second pref, which is defaulted to 20us but now dynamically adjustable (in the scale of microseconds.) We are landing this preffed off at the current value we clamp performance.now() at which is 20us. This commit is the combination of the multiple commits listed in Bug 1424341
327ccd0d5dc266b4490d9205da65dee6736bcb9c: Bug 1429133 - Some FontExplorer managed fonts are not rendered. r=Alex_Gaynor a=gchang FIREFOX_58b_RELBRANCH
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 10 Jan 2018 11:33:47 -0800 - rev 450730
Push 8535 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:26:02 +0000
Bug 1429133 - Some FontExplorer managed fonts are not rendered. r=Alex_Gaynor a=gchang MozReview-Commit-ID: L5x3GNb3HGU
50afadf44520a92711c6e65ff424a300aa0cda4b: Bug 1426500 - Part 2: Update test_interfaces mochitest to expect WebVR interfaces to be disabled on release builds for macOS. r=smaug, a=gchang FIREFOX_58b_RELBRANCH
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Thu, 11 Jan 2018 15:13:58 -0800 - rev 450729
Push 8535 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:26:02 +0000
Bug 1426500 - Part 2: Update test_interfaces mochitest to expect WebVR interfaces to be disabled on release builds for macOS. r=smaug, a=gchang
52f3fbce290687befb442e913faf57763bdf6814: Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang FIREFOX_58b_RELBRANCH
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 10 Jan 2018 16:14:21 -0800 - rev 450728
Push 8535 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:26:02 +0000
Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang - WebVR will continue to be enabled on macOS for Nightly and Dev Edition MozReview-Commit-ID: LpEX13yZVbb
102edbb34a09b8dcfb100ce96d765daa5ace091a: Bug 1425509 - Initialize PerformanceService in RuntimeService, r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 18 Dec 2017 17:49:54 +0100 - rev 450727
Push 8535 by archaeopteryx@coole-files.de at Sat, 13 Jan 2018 00:26:02 +0000
Bug 1425509 - Initialize PerformanceService in RuntimeService, r=bkelly a=gchang
574c337510b15521c16142130a2d1fee407ac25b: Bug 1417741 Add support of Atomic<> for Preferences::Add*VarCache r=baku,njn a=gchang on a CLOSED TREE FIREFOX_58b_RELBRANCH
Tom Ritter <tom@mozilla.com> - Wed, 20 Dec 2017 14:39:27 -0600 - rev 450723
Push 8532 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:23:32 +0000
Bug 1417741 Add support of Atomic<> for Preferences::Add*VarCache r=baku,njn a=gchang on a CLOSED TREE This is a partial backport of Bug 1417741 that only adds AddAtomicBoolVarCache because that is all we need.
fee5a8fb1f455dd8459b836e706613ebf49a93dc: Bug 1417431 - secureConnectionStart should be 0 for pages with HTTP scheme. r=bkelly a=gchang FIREFOX_58b_RELBRANCH
Dragana Damjanovic <dd.mozilla@gmail.com> - Wed, 06 Dec 2017 12:57:28 +0100 - rev 450722
Push 8532 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:23:32 +0000
Bug 1417431 - secureConnectionStart should be 0 for pages with HTTP scheme. r=bkelly a=gchang
5a556e5558de569582b9d1a9386518c84ca8c1c7: Bug 1416878 - Move the implementation of nsIWidgetListener from nsWebBrowser / nsWebShellWindow to a separate object. r=bz a=gchang FIREFOX_58b_RELBRANCH
Samael Wang <freesamael@gmail.com> - Fri, 12 Jan 2018 22:12:01 +0200 - rev 450721
Push 8532 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:23:32 +0000
Bug 1416878 - Move the implementation of nsIWidgetListener from nsWebBrowser / nsWebShellWindow to a separate object. r=bz a=gchang MozReview-Commit-ID: 5QV6lkCCGW5
d9c057e4160703d9dc1ed611e4cbd9208717aa9e: Bug 1261175. r=bobowen a=gchang FIREFOX_58b_RELBRANCH
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 14 Nov 2017 10:31:36 +1300 - rev 450719
Push 8532 by archaeopteryx@coole-files.de at Fri, 12 Jan 2018 20:23:32 +0000
Bug 1261175. r=bobowen a=gchang MozReview-Commit-ID: B9yAN0F01rj
2a4cb360a9f624fb4c52171137253bc933bc4844: Bug 1429219 - Ensure VP8 simulcast with temporal layers won't fail if there aren't enough bits. r=drno, a=gchang FIREFOX_58b_RELBRANCH
Randell Jesup <rjesup@jesup.org> - Wed, 10 Jan 2018 20:41:09 -0500 - rev 450622
Push 8529 by ryanvm@gmail.com at Fri, 12 Jan 2018 02:48:05 +0000
Bug 1429219 - Ensure VP8 simulcast with temporal layers won't fail if there aren't enough bits. r=drno, a=gchang
000398f8c373407ba621d56cbd3b370cf43469a8: Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Jan 2018 14:12:38 +0200 - rev 443204
Push 8524 by archaeopteryx@coole-files.de at Thu, 11 Jan 2018 12:34:09 +0000
Bug 1428589: Don't read a destroyed cookie list if the last cookie in the entry expired. r=jdm a=gchang Consider the following situation, which is what causes the failure: * `cookies` is an array of length 1 (either from the beginning, or because other cookies have been expired while in this loop). * the only cookie that remains is expired. We append the cookie to removedList, and then we call gCookieService->RemoveCookieFromList, which has the following code: if (aIter.entry->GetCookies().Length() == 1) { mDBState->hostTable.RawRemoveEntry(aIter.entry); } else { aIter.entry->GetCookies().RemoveElementAt(aIter.index); } If we enter the first branch, as it's the case, that will destroy the array. We're effectively removing stuff from the array while mutating it, which is scary. It's fine if we don't delete the array, since we iterate through it using indices, but still it's dangerous as heck. If we're the last element in the array though, we're doomed, because `cookies` is now destroyed. We not only try to access the array length again, but also we try to index on it the next time because we never stopped the loop (`i` is still zero, and the length may very well be garbage). Fix it by keeping the length in sync from the stack and breaking out from the loop if appropriately. MozReview-Commit-ID: 6qaC9yclvP2
e57848b337fcaeec8a8e23f45354603df11c2b5b: Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang
Andrew Swan <aswan@mozilla.com> - Sat, 04 Nov 2017 21:06:20 -0700 - rev 443203
Push 8524 by archaeopteryx@coole-files.de at Thu, 11 Jan 2018 12:34:09 +0000
Bug 1396399 - Clarify rules for applying activeTab permission to content scripts. r=kmag, r=bz a=gchang MozReview-Commit-ID: 9xPDX8Qk2iR
3f7a950871b4587af63fae0e82f601e0f4f10ba6: Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
Randell Jesup <rjesup@jesup.org> - Wed, 10 Jan 2018 20:41:03 -0500 - rev 443202
Push 8524 by archaeopteryx@coole-files.de at Thu, 11 Jan 2018 12:34:09 +0000
Bug 1426449: set the correct number of temporal layers for screencasts r=drno a=gchang
398360c9d5c6fcc80d7ced94afe65ee7f672b0bf: Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
Ben Kelly <ben@wanderview.com> - Wed, 10 Jan 2018 14:45:17 -0500 - rev 443201
Push 8523 by apavel@mozilla.com at Thu, 11 Jan 2018 11:10:56 +0000
Bug 1429542 Make HttpChannelChild::OverrideRunnable check for nullptr before using mNewChannel. r=asuth a=gchang
76192bc7ded10f07dd8eb314af1b268d2b0af248: Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang
Kearwood "Kip" Gilbert <kgilbert@mozilla.com> - Wed, 10 Jan 2018 16:14:21 -0800 - rev 443200
Push 8522 by btara@mozilla.com at Thu, 11 Jan 2018 10:37:12 +0000
Bug 1426500 - Disable WebVR for macOS on Beta and Release r=daoshengmu a=gchang - WebVR will continue to be enabled on macOS for Nightly and Dev Edition MozReview-Commit-ID: LpEX13yZVbb
3a94f3140a144491cde0c1805afcd13ae9922b7f: bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang
Ted Mielczarek <ted@mielczarek.org> - Wed, 06 Dec 2017 06:28:41 -0500 - rev 443199
Push 8521 by aciure@mozilla.com at Thu, 11 Jan 2018 10:22:37 +0000
bug 1422735 - Change symbol upload URL from Socorro to Tecken. r=nalexander a=gchang MozReview-Commit-ID: BBs6G8dFfPz
7047976f6bec7c8e611009b74456986e0045cfc9: Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
Alphan Chen <alchen@mozilla.com> - Fri, 05 Jan 2018 15:12:16 +0800 - rev 443198
Push 8521 by aciure@mozilla.com at Thu, 11 Jan 2018 10:22:37 +0000
Bug 1421214 - Try GoToAnchor() with unescaped string before using document's charset. r=smaug a=gchang
3e7bec52b1431c8dfd56c86ec5062514434fa788: Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
Jan de Mooij <jdemooij@mozilla.com> - Tue, 09 Jan 2018 16:37:12 -0500 - rev 443196
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1427126 - Use setElementWithType instead of setElement in AppendToList. r=bhackett, a=gchang
a1d9a99f12a544df996ebdf833cf3e65357a7361: Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang
Andrew McCreight <continuation@gmail.com> - Thu, 04 Jan 2018 14:59:14 -0800 - rev 443195
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1426801 - Clear gFirstIdleTask if we fail to dispatch the runnable. r=mrbkap, a=gchang MozReview-Commit-ID: 23f9VDTyyqg
38fd987182186720bc0b252a1dc94444f6db39f5: Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Thu, 04 Jan 2018 23:15:42 -0500 - rev 443194
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1428165 - Part 2: Fix history expiration query. r=nalexander, a=gchang 'modified' value might be missing; in SQLite, max(123, null) is null, and so we must coalesce fields which might be missing values. MozReview-Commit-ID: Bn1P0kdaHHT
916cbb15381ea0571c81e33ef37514855f152203: Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 05 Jan 2018 21:15:55 -0500 - rev 443193
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1428165 - Part 1: Ensure that 'modified' and 'created' timestamps are set when inserting history from sync. r=nalexander, a=gchang This fixes a regression introduced in Bug 1291821. History records would be bulk-inserted from sync, and our ContentProvider would erroneously forget to set these two timestamp fields. MozReview-Commit-ID: 2k0afijN62H
5b67ac2c216bef0bcf3a3cf7577eade0ffb5e0e2: Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:51 +0000 - rev 443192
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1426042 - Ensure we don't forget to set bidi data when required on a zero-length trailing frame. r=dholbert, a=gchang
b5147bc4e38410b1c5b66368f9e0d67f02e98738: Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Jan 2018 13:58:42 +0000 - rev 443191
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1426042 - Reftest for bidi reordering where line has an empty trailing ::after pseudo-element. r=dholbert, a=gchang
ed60f2c05c4ae44d1385176764dafe9b9c0321fa: Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang
Ryan Hunt <rhunt@eqrion.net> - Wed, 03 Jan 2018 16:56:25 -0600 - rev 443190
Push 8519 by ryanvm@gmail.com at Thu, 11 Jan 2018 02:47:48 +0000
Bug 1427089 - Wait for a previous empty transaction to complete before doing another empty transaction. r=dvander, a=gchang