searching for reviewer(froydnj)
af490228394e: Bug 1412192 - Use main-thread JSContext in SystemZoneResource::IsAvailable (r=froydnj)
Bill McCloskey <billm@mozilla.com> - Fri, 22 Sep 2017 15:58:06 -0700 - rev 442252
Push 8139 by ryanvm@gmail.com at 2017-11-13 02:28 +0000
Bug 1412192 - Use main-thread JSContext in SystemZoneResource::IsAvailable (r=froydnj) MozReview-Commit-ID: BC9OoHVaMEI
f367f91a3bde: Bug 1412191 - Fix CooperativeThreadPool thread count assertion (r=froydnj)
Bill McCloskey <billm@mozilla.com> - Fri, 22 Sep 2017 14:36:30 -0700 - rev 442251
Push 8139 by ryanvm@gmail.com at 2017-11-13 02:28 +0000
Bug 1412191 - Fix CooperativeThreadPool thread count assertion (r=froydnj) MozReview-Commit-ID: 4oUM0rh4ySs
41d3c1e5dacc: Bug 1395029 - Scheduler support for blockThreadedExecution (r=froydnj)
Bill McCloskey <billm@mozilla.com> - Thu, 21 Sep 2017 15:57:49 -0700 - rev 442248
Push 8139 by ryanvm@gmail.com at 2017-11-13 02:28 +0000
Bug 1395029 - Scheduler support for blockThreadedExecution (r=froydnj) MozReview-Commit-ID: EXRMRh9SCsQ
353999bc9b73: Bug 1416199 - Don't try to set signal handlers in Windows coverage build. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 10 Nov 2017 12:50:14 +0100 - rev 442221
Push 8139 by ryanvm@gmail.com at 2017-11-13 02:28 +0000
Bug 1416199 - Don't try to set signal handlers in Windows coverage build. r=froydnj
4d7c0110f849: Bug 1416164 - Replace NS_POSTCONDITION with MOZ_ASSERT. r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Sat, 04 Nov 2017 22:48:48 -0700 - rev 442178
Push 8138 by ryanvm@gmail.com at 2017-11-11 14:08 +0000
Bug 1416164 - Replace NS_POSTCONDITION with MOZ_ASSERT. r=froydnj MozReview-Commit-ID: 9K3Ksf36uxr
c555efc93048: Bug 1416164 - Replace NS_NOTYETIMPLEMENTED with MOZ_ASSERT_UNREACHABLE. r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Wed, 25 Oct 2017 00:37:02 -0700 - rev 442177
Push 8138 by ryanvm@gmail.com at 2017-11-11 14:08 +0000
Bug 1416164 - Replace NS_NOTYETIMPLEMENTED with MOZ_ASSERT_UNREACHABLE. r=froydnj MozReview-Commit-ID: B5TZB3v52wY
7b970d24b438: Bug 1416164 - Replace NS_ABORT with MOZ_ASSERT_UNREACHABLE. r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Tue, 24 Oct 2017 23:52:56 -0700 - rev 442176
Push 8138 by ryanvm@gmail.com at 2017-11-11 14:08 +0000
Bug 1416164 - Replace NS_ABORT with MOZ_ASSERT_UNREACHABLE. r=froydnj MozReview-Commit-ID: DRdYlOYqZpN
d8626c12e13f: Bug 1415453 - Use vfpv3-d16 as default on Android/arm. r=froydnj
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Fri, 10 Nov 2017 16:47:21 +0900 - rev 442173
Push 8138 by ryanvm@gmail.com at 2017-11-11 14:08 +0000
Bug 1415453 - Use vfpv3-d16 as default on Android/arm. r=froydnj According to https://developer.android.com/ndk/guides/abis.html, androideabi-v7a must support vfpv3-d16. So we should use it for fpu flag. MozReview-Commit-ID: 3rhmRTekmwD
499c60003ff1: Bug 1407432 - Remove stl-headers & system-headers; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:59:16 -0500 - rev 442115
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove stl-headers & system-headers; r=froydnj These have been replaced by stl-headers.mozbuild and system-headers.mozbuild MozReview-Commit-ID: EpPasSzgiJk
04b2f4aca51f: Bug 1407432 - Move system wrapper generation to moz.build; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:58:56 -0500 - rev 442114
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Move system wrapper generation to moz.build; r=froydnj The make-system-wrappers.py invocation is largely identical to make-stl-wrappers.py, though this script generates wrappers for both the STL headers and every other system header that can be used. Note that the nsprpub script didn't create multiple layers of subdirectories properly, so for example the 'ia64/sys/inline.h' wrapper is now generated properly. Additionally, MOZ_SYSTEM_ICU define was incorrectly using '#ifdef' instead of '#if ... == 1', which causes those unicode headers to have wrappers when they shouldn't. These will show up as differences when comparing the Makefile output to the moz.build output. MozReview-Commit-ID: KvQAawfzXao
ccc34ca6ecfd: Bug 1407432 - Move stl wrapper generation into moz.build; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 17:42:27 -0500 - rev 442113
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Move stl wrapper generation into moz.build; r=froydnj This is fairly straightforward to represent as a GENERATED_FILES, though we have to take some care to construct the outputs tuple correctly. This script needs to run during export, and unfortunately none of the STL headers have proper file extensions, so the 'new' header is special-cased in the recursive make backend to serve as a marker for running it in the correct tier. We can't remove the stl-headers file yet because it is still used for the system header generation. MozReview-Commit-ID: 3tQTOY0LAsQ
94f475532485: Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:58:28 -0500 - rev 442112
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj MozReview-Commit-ID: JVukxIg04AT
3258f49e8c73: Bug 1407432 - Remove unused private/*.h system wrappers; r=froydnj
Mike Shal <mshal@mozilla.com> - Thu, 09 Nov 2017 09:19:54 -0500 - rev 442111
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove unused private/*.h system wrappers; r=froydnj These don't actually install correctly, because 'private' is already a system wrapper. Neither of these files are included anywhere, so there's no harm in removing them. MozReview-Commit-ID: 1IAFMZDvKDV
88e0c2a4e725: Bug 1407432 - Remove ucx$inetdef.h from system headers; r=froydnj,ted
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 20:47:30 -0500 - rev 442110
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove ucx$inetdef.h from system headers; r=froydnj,ted This is no longer used in the tree, and the $ will get eaten somewhere along the way on the path from moz.build to the python invocation by make despite being shell_quoted. MozReview-Commit-ID: 5mwWQYDn8Nf
b0ded9bbd517: Bug 1320738 - Mark MOZ_PGO as a JS option. r=froydnj, a=RyanVM
Gregory Szorc <gps@mozilla.com> - Fri, 10 Nov 2017 09:23:27 -0800 - rev 442024
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1320738 - Mark MOZ_PGO as a JS option. r=froydnj, a=RyanVM The changesets in bug 1412932 changed the semantics for MOZ_PGO. Before, it was effectively being set as an environment variable by client.mk all the time. Afterwards - specifically after 2013c8dd1824 - the variable is set in mozconfigs via ac_add_options, which means it is only exposed to configure, not the environment. Investigation by dmajor revealed that -WX (warnings as errors) was added to a js/src file's compiler invocation after the PGO code refactor. (PGO and warnings as errors have a strange interaction - bug 437002 - and should be disabled there.) Strangely, addition of -WX was only present on Dev Edition PGO builds. The reason for this is likely mozharness. Mozharness will export the MOZ_PGO=1 environment variable for build configurations that it knows are PGO. It appears to do this for all PGO build configurations except Dev Edition. Since make and moz.configure inherit environment variables, mozharness was basically papering over the intended behavior change in 2013c8dd1824. This commit fixes the problem by marking MOZ_PGO as a JS option in moz.configure. This means `ac_add_options MOZ_PGO=1` (the new convention for enabling PGO) will set MOZ_PGO for SpiderMonkey's moz.configure. Of course, MOZ_PGO=1 in an environment variable still works. And mozharness's setting of this variable has the intended effect. Eventually, I'd like to clean up the mozharness code so it is less PGO aware and enables PGO via ac_add_options. But that's for another day. MozReview-Commit-ID: 1KYPJARI6SJ
4c69cfd07577: Bug 1415637 - Possibly incorrect MOZ_MAKE_MEM_UNDEFINED in nsTHashtable copy constructor. r=froydnj.
Julian Seward <jseward@acm.org> - Fri, 10 Nov 2017 11:23:12 +0100 - rev 441992
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1415637 - Possibly incorrect MOZ_MAKE_MEM_UNDEFINED in nsTHashtable copy constructor. r=froydnj.
86302df0b38a: Bug 1407432 - Remove stl-headers & system-headers; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:59:16 -0500 - rev 441902
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove stl-headers & system-headers; r=froydnj These have been replaced by stl-headers.mozbuild and system-headers.mozbuild MozReview-Commit-ID: EpPasSzgiJk
5a967cc85e28: Bug 1407432 - Move system wrapper generation to moz.build; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:58:56 -0500 - rev 441901
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Move system wrapper generation to moz.build; r=froydnj The make-system-wrappers.py invocation is largely identical to make-stl-wrappers.py, though this script generates wrappers for both the STL headers and every other system header that can be used. Note that the nsprpub script didn't create multiple layers of subdirectories properly, so for example the 'ia64/sys/inline.h' wrapper is now generated properly. Additionally, MOZ_SYSTEM_ICU define was incorrectly using '#ifdef' instead of '#if ... == 1', which causes those unicode headers to have wrappers when they shouldn't. These will show up as differences when comparing the Makefile output to the moz.build output. MozReview-Commit-ID: KvQAawfzXao
828d43ec1b16: Bug 1407432 - Move stl wrapper generation into moz.build; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 17:42:27 -0500 - rev 441900
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Move stl wrapper generation into moz.build; r=froydnj This is fairly straightforward to represent as a GENERATED_FILES, though we have to take some care to construct the outputs tuple correctly. This script needs to run during export, and unfortunately none of the STL headers have proper file extensions, so the 'new' header is special-cased in the recursive make backend to serve as a marker for running it in the correct tier. We can't remove the stl-headers file yet because it is still used for the system header generation. MozReview-Commit-ID: 3tQTOY0LAsQ
bacf04be0a48: Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 19:58:28 -0500 - rev 441899
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj MozReview-Commit-ID: JVukxIg04AT
8d770908a5b9: Bug 1407432 - Remove unused private/*.h system wrappers; r=froydnj
Mike Shal <mshal@mozilla.com> - Thu, 09 Nov 2017 09:19:54 -0500 - rev 441898
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove unused private/*.h system wrappers; r=froydnj These don't actually install correctly, because 'private' is already a system wrapper. Neither of these files are included anywhere, so there's no harm in removing them. MozReview-Commit-ID: 1IAFMZDvKDV
ffe9aed0944f: Bug 1407432 - Remove ucx$inetdef.h from system headers; r=froydnj,ted
Mike Shal <mshal@mozilla.com> - Wed, 08 Nov 2017 20:47:30 -0500 - rev 441897
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1407432 - Remove ucx$inetdef.h from system headers; r=froydnj,ted This is no longer used in the tree, and the $ will get eaten somewhere along the way on the path from moz.build to the python invocation by make despite being shell_quoted. MozReview-Commit-ID: 5mwWQYDn8Nf
0a1a5a1cb353: Bug 1415699 - Apply LLVM patches needed to support code coverage on Windows. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 08 Nov 2017 22:44:15 +0100 - rev 441844
Push 8134 by ryanvm@gmail.com at 2017-11-10 21:18 +0000
Bug 1415699 - Apply LLVM patches needed to support code coverage on Windows. r=froydnj
a06f5967bcb6: Bug 1415568 - Support applying patches to Windows clang. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Wed, 08 Nov 2017 17:23:12 +0100 - rev 441637
Push 8133 by ryanvm@gmail.com at 2017-11-09 23:33 +0000
Bug 1415568 - Support applying patches to Windows clang. r=froydnj
1528ff0ed838: Bug 1415083 - Rearrange the declaration of objects to avoid stack-use-after-scope. r=froydnj
James Cheng <jacheng@mozilla.com> - Tue, 07 Nov 2017 17:02:54 +0800 - rev 441466
Push 8130 by ryanvm@gmail.com at 2017-11-09 00:28 +0000
Bug 1415083 - Rearrange the declaration of objects to avoid stack-use-after-scope. r=froydnj MozReview-Commit-ID: 7nMw1i10b7e
b2dd86a66344: Bug 1409267 - Patch compiler-rt to always use prctl(PR_SET_PTRACER). r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 07 Nov 2017 15:07:30 +0900 - rev 441436
Push 8130 by ryanvm@gmail.com at 2017-11-09 00:28 +0000
Bug 1409267 - Patch compiler-rt to always use prctl(PR_SET_PTRACER). r=froydnj
1413e5b916a3: Bug 1413362 - part 3: Add support to build system for GoogleVR based WebVR on Android r=froydnj,nalexander
Randall Barker <rbarker@mozilla.com> - Thu, 02 Nov 2017 17:16:11 -0700 - rev 441395
Push 8130 by ryanvm@gmail.com at 2017-11-09 00:28 +0000
Bug 1413362 - part 3: Add support to build system for GoogleVR based WebVR on Android r=froydnj,nalexander MozReview-Commit-ID: 8BHBnvor5VT
ee8c2f65351c: Bug 1414370 - Emit ldflags in directories containing only rust programs for the benefit of cargo. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Mon, 06 Nov 2017 19:57:12 -0800 - rev 441381
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414370 - Emit ldflags in directories containing only rust programs for the benefit of cargo. r=froydnj MozReview-Commit-ID: 6gD7kAIQbtB
a478fd716627: Bug 1414298: Don't try to set yasm version config settings if yasm isn't found. r=froydnj
Tom Prince <mozilla@hocat.ca> - Mon, 06 Nov 2017 11:07:26 -0700 - rev 441347
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414298: Don't try to set yasm version config settings if yasm isn't found. r=froydnj MozReview-Commit-ID: LTDxJ5su7sM
c0a033707d7a: Bug 1396208 - For benchmarking, add a black box function that is opaque to the optimizer. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 10 Oct 2017 09:48:26 +0300 - rev 441301
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1396208 - For benchmarking, add a black box function that is opaque to the optimizer. r=froydnj MozReview-Commit-ID: 82jn6u6WRf0
8b15dfaeecaa: Bug 1413362 - part 3: Add support to build system for GoogleVR based WebVR on Android r=froydnj,nalexander
Randall Barker <rbarker@mozilla.com> - Thu, 02 Nov 2017 17:16:11 -0700 - rev 441288
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1413362 - part 3: Add support to build system for GoogleVR based WebVR on Android r=froydnj,nalexander MozReview-Commit-ID: 8BHBnvor5VT
4f5a502acbe8: Bug 1414767 - Moving SlicedInputStream under mozilla namespace, r=froydnj
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 07 Nov 2017 01:04:06 +0100 - rev 441227
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414767 - Moving SlicedInputStream under mozilla namespace, r=froydnj
5a9fa46f3cb9: Bug 1414558 - Build Clang toolchain on a Docker volume; r=froydnj
Gregory Szorc <gps@mozilla.com> - Mon, 06 Nov 2017 11:45:17 -0800 - rev 441207
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414558 - Build Clang toolchain on a Docker volume; r=froydnj Before, the build root was not in a Docker cache or volume. With current Docker works, that meant AUFS. We know AUFS is slow under I/O load and can cause random failures due to missing data after writes. This commit changes the build root to a known Docker volume, which will be backed by EXT4 and won't have the problems of AUFS. MozReview-Commit-ID: 6WOH0yednAv
6b89155dd988: Bug 1414906 - Build sccache with openssl 1.1.0g. r=froydnj
Ralph Giles <giles@mozilla.com> - Mon, 06 Nov 2017 10:16:07 -0800 - rev 441204
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414906 - Build sccache with openssl 1.1.0g. r=froydnj Fixes bn_sqrx8x_internal carry bug on x86_64 (CVE-2017-3736) MozReview-Commit-ID: 5qF9NfCi3XX
66d49b9e8217: Bug 1414767 - Moving SlicedInputStream under mozilla namespace, r=froydnj
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 06 Nov 2017 16:21:01 +0100 - rev 441176
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414767 - Moving SlicedInputStream under mozilla namespace, r=froydnj
82e2afb4d904: Bug 1414370 - Emit ldflags in directories containing only rust compilation for the benefit of cargo. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Fri, 03 Nov 2017 12:16:39 -0700 - rev 441173
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414370 - Emit ldflags in directories containing only rust compilation for the benefit of cargo. r=froydnj MozReview-Commit-ID: 9AuU3mjKR8V
d2a961ced3a0: Bug 1414794 - Unbreak the lld usage by providing the right data structure r=froydnj
Sylvestre Ledru <sledru@mozilla.com> - Mon, 06 Nov 2017 14:23:57 +0100 - rev 441139
Push 8127 by ryanvm@gmail.com at 2017-11-07 22:38 +0000
Bug 1414794 - Unbreak the lld usage by providing the right data structure r=froydnj MozReview-Commit-ID: 1caPjLBR4vS
17decbfb0720: Bug 1412048 - Remove NS_RUNTIMEABORT. r=froydnj
Chris Peterson <cpeterson@mozilla.com> - Tue, 24 Oct 2017 23:41:15 -0700 - rev 440986
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1412048 - Remove NS_RUNTIMEABORT. r=froydnj Use MOZ_CRASH, MOZ_CRASH_UNSAFE_OOL, or MOZ_CRASH_UNSAFE_PRINTF instead. MozReview-Commit-ID: 1kCCHMlgbGP
e85f59ea455d: Bug 1412048 - Replace some NS_RUNTIMEABORT(var) calls with MOZ_CRASH_UNSAFE_PRINTF. r=froydnj data-review=francois
Chris Peterson <cpeterson@mozilla.com> - Thu, 26 Oct 2017 00:49:00 -0700 - rev 440985
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1412048 - Replace some NS_RUNTIMEABORT(var) calls with MOZ_CRASH_UNSAFE_PRINTF. r=froydnj data-review=francois MOZ_CRASH_UNSAFE_PRINTF causes data collection because crash strings are annotated to crash-stats and are publicly visible. Firefox data stewards must do data review on usages of this macro. However, all the crash strings this patch collects with MOZ_CRASH_UNSAFE_PRINTF are already collected with NS_RUNTIMEABORT. MozReview-Commit-ID: 5ujXa9MHH5Z
dbcddce04a80: Bug 1412952 - Build clang-cl itself with VS2017. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 03 Nov 2017 12:29:58 -0400 - rev 440869
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1412952 - Build clang-cl itself with VS2017. r=froydnj
bcb92693eac8: Bug 1412952 - Use VS2017 with clang-cl builds. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 03 Nov 2017 12:29:58 -0400 - rev 440868
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1412952 - Use VS2017 with clang-cl builds. r=froydnj
ffb00b457b92: Bug 1412952: We want a HostX64 linker even with 32-bit clang-cl.exe. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 03 Nov 2017 12:29:58 -0400 - rev 440867
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1412952: We want a HostX64 linker even with 32-bit clang-cl.exe. r=froydnj 32-bit clang-cl.exe was looking specifically for HostX86\x86\link.exe, which doesn't exist in our automation package. Make it look in HostX64\x86 instead. This is an ugly hack and it would be preferable to just use a 64-bit compiler (bug 1414287).
fb2b705b77cb: Bug 1412952 - Loosen clang's MSVC detection to accept our automation's fake paths. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 03 Nov 2017 12:29:58 -0400 - rev 440866
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1412952 - Loosen clang's MSVC detection to accept our automation's fake paths. r=froydnj In a proper VS install, the path to cl.exe looks like: ...\VC\Tools\MSVC\14.11.25503\bin\HostX64\x64\cl.exe In our automation, the path is just: ...\VC\bin\HostX64\x64\cl.exe Clang tries to do some sanity-checking to make sure that the cl.exe it finds is the Microsoft compiler and not some other program. But the checks are a little too strict for us, so just look for "bin\Host*\*\cl.exe".
c0a99f75e8fc: Bug 1413675 - Downgrade to Windows SDK 10.0.15063.0 to fix clang builds. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 03 Nov 2017 09:26:58 -0400 - rev 440834
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1413675 - Downgrade to Windows SDK 10.0.15063.0 to fix clang builds. r=froydnj The new VS package is now based on update 15.4.2, although that release didn't affect any files in our package. I'm picking up the update mostly just to make filename unique.
962343e8bdf0: Bug 1413400 (part 2) - Make Preferences::sPreferences a StaticRefPtr. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 01 Nov 2017 13:55:28 +1100 - rev 440764
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1413400 (part 2) - Make Preferences::sPreferences a StaticRefPtr. r=froydnj. The notable part of this change is Shutdown(). I've made it just null out sPreferences, contrary to the old comment, which was strange for a couple of reasons: - ~Preferences() used to null out sPreference, which is backwards compared to how this sort of thing normally works. - In both the before and after cases, as far as I can tell, Preferences::Shutdown() is called but ~Preferences() is never called; something keeps the singleton Preferences instance alive until process termination. MozReview-Commit-ID: Ab0ui31rVcI
352bbd41f1fa: Bug 1413400 (part 1) - Move s{,Default}RootBranch into Preferences. r=froydnj.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 01 Nov 2017 13:41:14 +1100 - rev 440763
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1413400 (part 1) - Move s{,Default}RootBranch into Preferences. r=froydnj. sRootBranch and sDefaultRootBranch have the same lifetime as sPreferences, so this patch makes them non-static nsCOMPtr<> members of Preferences. MozReview-Commit-ID: 1TLhh13ZpBI
f532ca793b60: Bug 1413696 - Add default prefs for ASan Reporter. r=froydnj
Christian Holler <choller@mozilla.com> - Wed, 01 Nov 2017 22:32:19 +0100 - rev 440700
Push 8120 by ryanvm@gmail.com at 2017-11-04 17:45 +0000
Bug 1413696 - Add default prefs for ASan Reporter. r=froydnj MozReview-Commit-ID: 9a1uLem2UOQ
19955c48f09c: Bug 1406727 - Add more assertions. r=froydnj, r=francois
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 01 Nov 2017 16:20:51 +1300 - rev 440546
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406727 - Add more assertions. r=froydnj, r=francois MozReview-Commit-ID: JT9lMXAI9GT
fa3be8644d73: Bug 1413570 - Disable SSE2 when building mozjemalloc on x86 during PGO profile gen phase. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 02 Nov 2017 10:26:49 +0900 - rev 440512
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1413570 - Disable SSE2 when building mozjemalloc on x86 during PGO profile gen phase. r=froydnj Because of alignment issues due to the system glibc when running the SSE2 gcov code generated during the PGO profile gen phase, Firefox crashes when running the PGO profile. We work around the issue by disabling SSE2 when building mozjemalloc during that phase. That shouldn't affect the coverage data anyways, which is bound to the original C++ code, and the profile-use code generation will still emit SSE2 based on the coverage data if it needs to.
5bc78f996c0d: Bug 1413348: Remove build system variable for no-longer-used/supported MOZ_HORIZON configuration. r=froydnj
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 31 Oct 2017 15:37:43 -0700 - rev 440349
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1413348: Remove build system variable for no-longer-used/supported MOZ_HORIZON configuration. r=froydnj MozReview-Commit-ID: upsiM9SnHl