searching for reviewer(froydnj)
09a979b6e583: Bug 1488808 Part 16 - Avoid deadlocking in a few places after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:15:41 -0600 - rev 497794
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 16 - Avoid deadlocking in a few places after diverging from the recording, r=froydnj.
baaaaa544bb0: Bug 1488808 Part 10 - Notify the record/replay system when a message pump thread blocks after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:05:02 -0600 - rev 497788
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 10 - Notify the record/replay system when a message pump thread blocks after diverging from the recording, r=froydnj.
0ce807f9d1f6: Bug 1488808 Part 9 - Specify regions of code where recording is not interrupted and threads can diverge, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:04:29 -0600 - rev 497787
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 9 - Specify regions of code where recording is not interrupted and threads can diverge, r=froydnj.
0130de663e9f: Bug 1488808 Part 8 - Redirection changes for supporting layout and painting after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:04:01 -0600 - rev 497786
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 8 - Redirection changes for supporting layout and painting after diverging from the recording, r=froydnj.
b6ca168b7e52: Bug 1488808 Part 7 - Keep track of the PID of the recording process, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:02:02 -0600 - rev 497785
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 7 - Keep track of the PID of the recording process, r=froydnj.
4478e865d770: Bug 1488808 Part 5 - Add infrastructure for performing system calls in the middleman process, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:00:58 -0600 - rev 497783
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 5 - Add infrastructure for performing system calls in the middleman process, r=froydnj.
42143e96a1ea: Bug 1488808 Part 1 - Fix return value sets in Preamble_Veto, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 09:58:50 -0600 - rev 497779
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1488808 Part 1 - Fix return value sets in Preamble_Veto, r=froydnj.
2da6504c901e: Bug 1496581 - Split nsISeekableStream in 2 classes: nsISeekableStream and nsITellableStream, f=mayhemer, r=froydnj
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 18 Oct 2018 13:35:35 +0200 - rev 497666
Push 10002 by archaeopteryx@coole-files.de at 2018-10-19 23:09 +0000
Bug 1496581 - Split nsISeekableStream in 2 classes: nsISeekableStream and nsITellableStream, f=mayhemer, r=froydnj In the current code there are 3 main issues: 1. nsFileStream is not really thread-safe. There is nothing to protect the internal members and we see crashes. 2. nsPipeInputStream doesn't implement ::Seek() method and that caused issues in devtools when a nsHttpChannel sends POST data using a pipe. In order to fix this, bug 1494176 added a check in nsHttpChannel: if the stream doesn't implement ::Seek(), let's clone it. This was an hack around nsPipeInputStream, and it's bad. 3. When nsHttpChannel sends POST data using a file stream, nsFileStream does I/O on main-thread because of the issue 2. Plus, ::Seek() is called on the main-thread causing issue 1. Note that nsPipeInputStream implements only ::Tell(), of the nsISeekableStream methods. It doesn't implement ::Seek() and it doesn't implement ::SetEOF(). With this patch I want to fix point 2 and point 3 (and consequentially issue 1 - but we need a separate fix for it - follow up). The patch does: 1. it splits nsISeekableStream in 2 interfaces: nsITellableStream and nsISeekableStream. 2. nsPipeInputStream implements only nsITellableStream. Doing this, we don't need the ::Seek() check for point 2 in nsHttpChannel: a simple QI check is enough. 3. Because we don't call ::Seek() in nsHttpChannel, nsFileStream doesn't do I/O on the main-thread, and we don't crash doing so.
3eb04f5363eb: Bug 1496179 - Make mozglue.dll a private SxS assembly. r=aklotz,froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 10 Oct 2018 22:57:53 +0900 - rev 497637
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1496179 - Make mozglue.dll a private SxS assembly. r=aklotz,froydnj SxS assemblies do not obey the usual DLL search order. It will make it possible to load mozglue.dll from appdir even if the PreferSystem32Images mitigation is enabled and System32 has a random mozglue.dll.
06e5a5bfd05e: Bug 1498938 - Support [implicit_jscontext] XPIDL calls on Linux/PPC64.; r=froydnj
A. Wilcox <AWilcox@Wilcox-Tech.com> - Wed, 17 Oct 2018 23:12:51 +0000 - rev 497623
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1498938 - Support [implicit_jscontext] XPIDL calls on Linux/PPC64.; r=froydnj
ca4774548edb: Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj
Jim Blandy <jimb@mozilla.com> - Wed, 17 Oct 2018 21:34:57 +0000 - rev 497589
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj This was already reviewed and approved in bug 1426467. Differential Revision: https://phabricator.services.mozilla.com/D8913
bb1b80139e37: Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:43 +0000 - rev 497571
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader r=froydnj Now that the XPCOM component loader infrastructure has stopped pretending to support other file extensions, this intermediate interface is no longer needed. Depends on D8171 Differential Revision: https://phabricator.services.mozilla.com/D8172
11c813f192e2: Bug 1497707, part 4 - Only support loading JS files in the component manager r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:43 +0000 - rev 497570
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497707, part 4 - Only support loading JS files in the component manager r=froydnj JS is the only file extension actually supported, and there are a few layers of cruft that can be eliminated if we specialize it. This eliminates one XPCOM registration of the JS component loader. Depends on D8170 Differential Revision: https://phabricator.services.mozilla.com/D8171
32595f9e73d3: Bug 1497707, part 3 - Remove various unused things from nsComponentManager r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:42 +0000 - rev 497569
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497707, part 3 - Remove various unused things from nsComponentManager r=froydnj Depends on D8169 Differential Revision: https://phabricator.services.mozilla.com/D8170
f37f2d39ec9c: Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:42 +0000 - rev 497568
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null r=froydnj This allows some code to be deleted, including a KnownModule ctor. Depends on D8168 Differential Revision: https://phabricator.services.mozilla.com/D8169
63248a593eae: Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Wed, 17 Oct 2018 19:46:03 +0000 - rev 497550
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj The desired outcome of this change is that we'll set -Wl,--version-script based on linker kind and not on the output of $LINKER -v. This is a cheap way to address a simple problem that has a complicated ideal solution. The underlying issue is that in some situations, when targeting Android, a macOS system ld is interrogated to determine if a cross-compiling linker "is GNU ld" and a particular linker feature is set in that situation. The macOS system ld doesn't pass the "is GNU ld" test, and the linker feature isn't set; that causes link failures, even though the actual linker has nothing to do with the system ld. The ideal solution is to test for linker capabilities dynamically. We do a lot of that in old-configure.in, and we don't do any of that in toolchain.configure. Rather than start testing in toolchain.configure, we hard-code: a cheap solution to the immediate problem. MinGW suffers somewhat from the opposite problem: the linker "is GNU ld" (compatible), but the linker checks don't happen at all. We hard-code for MinGW based on the C compiler instead. Differential Revision: https://phabricator.services.mozilla.com/D8471
a64b17b18dae: Bug 1495574 - Support copying ip-relative xchg instructions, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Sun, 14 Oct 2018 09:48:34 -0600 - rev 497488
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1495574 - Support copying ip-relative xchg instructions, r=froydnj.
5687061cc832: Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Mon, 15 Oct 2018 10:36:45 +0200 - rev 497288
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
e85db490e17a: Bug 1499462: Remove dead failure handling and comments from ThrottledEventQueue::Create. r=froydnj
Jim Blandy <jimb@mozilla.com> - Tue, 16 Oct 2018 21:24:48 +0000 - rev 497274
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1499462: Remove dead failure handling and comments from ThrottledEventQueue::Create. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8890
3361fcc40ea2: Bug 1497446 - Follow-up to repair incorrect vendoring of lalrpop-snap. r=froydnj
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 16 Oct 2018 15:25:03 +0000 - rev 497233
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1497446 - Follow-up to repair incorrect vendoring of lalrpop-snap. r=froydnj This (large) file exists in the lalrpop-snap crate and should be part of the vendoring of that crate. However it seems to have been accidentally removed in bug 1497446. This patch adds it back by running ./mach vendor rust --build-peers-said-large-imports-were-ok on a clean m-c tree. Differential Revision: https://phabricator.services.mozilla.com/D8863
a3521c2b925b: Bug 1498404 - Fix some errors in manifests r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 16 Oct 2018 13:26:23 +0000 - rev 497228
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1498404 - Fix some errors in manifests r=froydnj In FxAccountsComponents.manifest, the previous line registers the component CID, but only for the main process. This means we hit an error while parsing the manifest in the child process, because the CID is not recognized. The fix is simply to not try to use the CID to register the contract in the child process. As for the rest of the changes, since bug 1438688, XPT information is compiled into the Firefox binary, so the interfaces manifest entry is no longer needed. This patch removes instances of this line from manifest files. This makes some manifest files empty, so the patch also removes the now-empty files. Differential Revision: https://phabricator.services.mozilla.com/D8751
1f5478a63db8: Bug 1495669: Share bindgen flags globally; r=emilio, r=froydnj
Benjamin Bouvier <benj@benj.me> - Tue, 09 Oct 2018 15:01:52 +0200 - rev 497082
Push 9996 by archaeopteryx@coole-files.de at 2018-10-18 18:37 +0000
Bug 1495669: Share bindgen flags globally; r=emilio, r=froydnj
b8d90d5901be: Bug 1498767 - Add missing MFBT tests to testing/cppunittest.py. r=froydnj
Botond Ballo <botond@mozilla.com> - Sat, 13 Oct 2018 21:54:27 +0000 - rev 496894
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1498767 - Add missing MFBT tests to testing/cppunittest.py. r=froydnj Also add a comment to mfbt/tests/moz.build to remind people that tests need to be added to testing/cppunittest.py. Differential Revision: https://phabricator.services.mozilla.com/D8664
91300d29898b: Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Fri, 12 Oct 2018 22:38:44 +0000 - rev 496696
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj The desired outcome of this change is that we'll set `-Wl,--version-script` based on linker kind and not on the output of `$LINKER -v`. This is a cheap way to address a simple problem that has a complicated ideal solution. The underlying issue is that in some situations, when targeting Android, a macOS system `ld` is interrogated to determine if a cross-compiling linker "is GNU ld" and a particular linker feature is set in that situation. The macOS system `ld` doesn't pass the "is GNU ld" test, and the linker feature isn't set; that causes link failures, even though the actual linker has nothing to do with the system `ld`. The ideal solution is to test for linker capabilities dynamically. We do a lot of that in old-configure.in, and we don't do any of that in toolchain.configure. Rather than start testing in toolchain.configure, we hard-code: a cheap solution to the immediate problem. Differential Revision: https://phabricator.services.mozilla.com/D8471
a232864e1002: Bug 1498450 - Avoid the footgun from @depends-function comparison r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 Oct 2018 13:44:08 +0000 - rev 496690
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1498450 - Avoid the footgun from @depends-function comparison r=froydnj While we do have some uses of @depends-function comparison in some templaces, related to host/target, we ought to be using `is` comparisons rather than `==` anyways, so we switch those, and prevent other kinds of comparisons being used at all. This unveils the one noted in https://phabricator.services.mozilla.com/D7713?id=21357#inline-30414 (and surprisingly only that one), that we remove entirely since it was doing nothing in practice. Bug 1492305 will have to add it back in a proper form. Differential Revision: https://phabricator.services.mozilla.com/D8501
5855ac73f9d7: Bug 1427808 - Remove the now-unused win64-clang-cl-st-an toolchain. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:15:00 -0400 - rev 496684
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1427808 - Remove the now-unused win64-clang-cl-st-an toolchain. r=froydnj
28f93e22d796: Bug 1427808 - Static analysis builds no longer need to force the use of link.exe. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:14:00 -0400 - rev 496683
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1427808 - Static analysis builds no longer need to force the use of link.exe. r=froydnj
5f551081abcb: Bug 1427808 - Make static analysis builds use the main win64-clang-cl toolchain. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:14:00 -0400 - rev 496682
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1427808 - Make static analysis builds use the main win64-clang-cl toolchain. r=froydnj
c8e0e2a2d309: Bug 1427808 - Fix libs for clang-plugin build. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:14:00 -0400 - rev 496681
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1427808 - Fix libs for clang-plugin build. r=froydnj
a9cb7624c15d: Bug 1496059 - Make Windows MSVC builds Tier 1. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:45:01 +0000 - rev 496652
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496059 - Make Windows MSVC builds Tier 1. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8457
40af17ba0d2c: Bug 1496059 - Run Windows MSVC builds on all branches. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:53 +0000 - rev 496651
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496059 - Run Windows MSVC builds on all branches. r=froydnj Also removes the signing jobs since they're not needed anymore. Differential Revision: https://phabricator.services.mozilla.com/D8456
1ade03649066: Bug 1496059 - Turn off tests for Windows MSVC builds. r=froydnj,ahal,jmaher
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:51 +0000 - rev 496650
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496059 - Turn off tests for Windows MSVC builds. r=froydnj,ahal,jmaher Also removes the signing jobs since they're not needed anymore. Differential Revision: https://phabricator.services.mozilla.com/D8455
f464ecbaeeda: Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj
Ryan VanderMeulen <ryanvm@gmail.com> - Fri, 12 Oct 2018 17:44:43 +0000 - rev 496649
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496059 - Don't use PGO for Windows opt-msvc builds now that they're not being shipped. r=froydnj This is a straight revert of bug 1474756. Differential Revision: https://phabricator.services.mozilla.com/D8454
1dfdc7ba998d: Bug 1431441 - Part 7 - Relax WebReplay fcntl rules to avoid sqlite crash r=froydnj
Haik Aftandilian <haftandilian@mozilla.com> - Fri, 12 Oct 2018 13:56:24 +0000 - rev 496628
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1431441 - Part 7 - Relax WebReplay fcntl rules to avoid sqlite crash r=froydnj Patch provided by Brian Hackett <bhackett@mozilla.com>. Only allow a limited set of commands to be used when events are not passed through and we are recording/replaying the outputs. Depends on D8474 Differential Revision: https://phabricator.services.mozilla.com/D8475
8878ac1f9f36: Bug 1497359 - Detect and reject re-use of objdirs between Make and Tup in configure. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Thu, 11 Oct 2018 19:16:49 +0000 - rev 496510
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497359 - Detect and reject re-use of objdirs between Make and Tup in configure. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8289
bb2685bc742e: Bug 1497336: Remove Cranelift Win32 static analysis workaround; r=froydnj
Benjamin Bouvier <benj@benj.me> - Thu, 11 Oct 2018 14:52:39 +0000 - rev 496457
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497336: Remove Cranelift Win32 static analysis workaround; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8062
9697308cfe00: Bug 1497741 - Remove source exception in gfx/graphite2/src/moz.build r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 10 Oct 2018 14:57:13 +0000 - rev 496365
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497741 - Remove source exception in gfx/graphite2/src/moz.build r=froydnj This effectively backs out bug 1272647, which was not necessary in the first place: the underlying issue had been fixed in bug 1245076, but the bug reporter had reported against version 45, while bug 1245076 was fixed in version 48. As a matter of fact, the reporter of bug 1272647 acknowledged in bug 1245076 that bug 1245076 fixed the issue. Differential Revision: https://phabricator.services.mozilla.com/D8179
70309e492279: Bug 1497716 - Add a redirection for realpath, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 09 Oct 2018 14:32:55 -1000 - rev 496239
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497716 - Add a redirection for realpath, r=froydnj.
eff92a00f2d8: Bug 1497060 - Stop putting stack information in record/replay error messages, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 09 Oct 2018 14:24:44 -1000 - rev 496237
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497060 - Stop putting stack information in record/replay error messages, r=froydnj.
e36764125483: Bug 1497027 - Crash properly after record/replay initialization failures, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Tue, 09 Oct 2018 14:20:10 -1000 - rev 496235
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497027 - Crash properly after record/replay initialization failures, r=froydnj.
8cca84d74504: Bug 1497382 - Make symbolstore.py fail when dump_syms fails r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Oct 2018 15:55:57 +0000 - rev 496082
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497382 - Make symbolstore.py fail when dump_syms fails r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8048
28530a1156ce: Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj
Tom Ritter <tom@mozilla.com> - Tue, 09 Oct 2018 19:38:56 +0000 - rev 496080
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj This commit also removes dwarf-exceptions from the x64 build. sjlj exceptions are needed on x86 because there is a bug currently involving SEH exceptions on x86. However on x64 there is not, so we can use the default SEH and get rid of dwarf exceptions. Additionally, to use SEH exceptions, we need to -fuse-cxa-atexit Differential Revision: https://phabricator.services.mozilla.com/D7759
8ecaee03d38e: Bug 1496486 - Valgrind suppression. rs=froydnj
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Oct 2018 18:58:48 +0200 - rev 496028
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496486 - Valgrind suppression. rs=froydnj I rewrote the computed value implementation to avoid allocating and this tricked Valgrind. There's nothing uninitialized or unsafe from the code in: https://hg.mozilla.org/integration/autoland/rev/4dd15fa31474#l28.68
1961aeb46e98: Bug 1496622 - convert Rust nsresult type alias to newtype w/#[repr(transparent)] r=froydnj
Myk Melez <myk@mykzilla.org> - Tue, 09 Oct 2018 16:02:32 +0000 - rev 496015
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496622 - convert Rust nsresult type alias to newtype w/#[repr(transparent)] r=froydnj MozReview-Commit-ID: AkzSS587MvC Differential Revision: https://phabricator.services.mozilla.com/D7832
df47d3ad9cc6: Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj
Tom Ritter <tom@mozilla.com> - Tue, 09 Oct 2018 14:10:56 +0000 - rev 496010
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1475998 Add a x86 MinGW Clang Build Job r=froydnj This commit also removes dwarf-exceptions from the x64 build. sjlj exceptions are needed on x86 because there is a bug currently involving SEH exceptions on x86. However on x64 there is not, so we can use the default SEH and get rid of dwarf exceptions. Additionally, to use SEH exceptions, we need to -fuse-cxa-atexit Differential Revision: https://phabricator.services.mozilla.com/D7759
7b660cc5c5b4: Bug 1496708 - Install node as system package. f=gaston r=Build r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Fri, 05 Oct 2018 05:37:00 +0300 - rev 495844
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496708 - Install node as system package. f=gaston r=Build r=froydnj Mozilla binaries (including toolchain artifacts) aren't available on BSDs.
584018b0397d: Bug 1496708 - Install cbindgen as system package. f=gaston r=Build r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Fri, 05 Oct 2018 05:37:00 +0300 - rev 495843
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496708 - Install cbindgen as system package. f=gaston r=Build r=froydnj cargo build is no longer called, so bootstrap will be faster. All dependencies (including cbindgen) are usually up-to-date on BSDs because there's no fallback to Mozilla binaries.
4ef3760a29be: Bug 1497169 - Unbreak bundled libevent on FreeBSD 12. r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Mon, 08 Oct 2018 05:12:00 +0300 - rev 495842
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1497169 - Unbreak bundled libevent on FreeBSD 12. r=froydnj
410533a1241e: Bug 1496733 - Explicitly install libXt on FreeBSD. r=Build r=froydnj
Jan Beich <jbeich@FreeBSD.org> - Fri, 05 Oct 2018 07:02:00 +0300 - rev 495841
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1496733 - Explicitly install libXt on FreeBSD. r=Build r=froydnj
ba9a0af62c4b: Bug 1475139 part 3 - Add serialization support for nsTHashtable with nsUint64HashKey. r=froydnj
Ryan Hunt <rhunt@eqrion.net> - Mon, 24 Sep 2018 21:35:31 -0500 - rev 495729
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1475139 part 3 - Add serialization support for nsTHashtable with nsUint64HashKey. r=froydnj I'd like to use a nsTHashtable acting as a set in a struct that will be passed over IPDL, but couldn't find any ParamTraits implementation for it. It'd be nice to make the implementation generic, but I couldn't find an easy way to do it. Differential Revision: https://phabricator.services.mozilla.com/D6782