searching for reviewer(froydnj)
3da147dac512: Bug 1469914 - Prevent the HAL from registering duplicate observers; r=froydnj a=lizzard
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 22 Jun 2018 00:35:08 +0200 - rev 477828
Push 9441 by archaeopteryx@coole-files.de at 2018-07-06 15:09 +0000
Bug 1469914 - Prevent the HAL from registering duplicate observers; r=froydnj a=lizzard This also replaces the custom logic in ObserverList with an nsTObserverArray which has all the necessary logic for stable iteration over a potentially changing list of items. Unused dependencies were also removed.
4eb0833bb0b4: Bug 1470907 - Call AsyncShutdown for threads at the end of nsHostResolver::ThreadFunc r=froydnj a=lizzard
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 26 Jun 2018 02:54:48 +0200 - rev 477786
Push 9422 by dluca@mozilla.com at 2018-07-02 15:37 +0000
Bug 1470907 - Call AsyncShutdown for threads at the end of nsHostResolver::ThreadFunc r=froydnj a=lizzard MozReview-Commit-ID: 2M8Qn8KDfdx
65ef3341465a: Bug 1470641 - Update already_AddRefed constructor comment. r=froydnj
Benjamin Peterson <benjamin@python.org> - Fri, 22 Jun 2018 23:25:19 -0700 - rev 477690
Push 9387 by aciure@mozilla.com at 2018-06-25 14:15 +0000
Bug 1470641 - Update already_AddRefed constructor comment. r=froydnj RIP B2G.
1dbc843c1429: Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Fri, 22 Jun 2018 15:10:39 -0700 - rev 477661
Push 9387 by aciure@mozilla.com at 2018-06-25 14:15 +0000
Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj MozReview-Commit-ID: CxLkQjX8veW
567df8598cdb: Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Fri, 22 Jun 2018 13:29:00 -0700 - rev 477656
Push 9387 by aciure@mozilla.com at 2018-06-25 14:15 +0000
Bug 1470552 - Update Makefile.in to refer to stub file target for buildid.h and source-repo.h generated in backend.mk r=froydnj MozReview-Commit-ID: JLgCA23U8zg
b04c3943f7b2: Bug 1469410 - UBSan false positive at tools/profiler/lul/LulMain.cpp:910:57. r=froydnj.
Julian Seward <jseward@acm.org> - Fri, 22 Jun 2018 10:03:06 +0200 - rev 477639
Push 9386 by nbeleuzu@mozilla.com at 2018-06-23 22:41 +0000
Bug 1469410 - UBSan false positive at tools/profiler/lul/LulMain.cpp:910:57. r=froydnj.
b92e2898ab18: Bug 1470488 - don't instrument win32's xptcall SharedStub; r=froydnj
David Major <dmajor@mozilla.com> - Fri, 22 Jun 2018 13:51:13 -0400 - rev 477638
Push 9386 by nbeleuzu@mozilla.com at 2018-06-23 22:41 +0000
Bug 1470488 - don't instrument win32's xptcall SharedStub; r=froydnj Compiler-inserted instrumentation is going to do terrible things to this function, so don't let the compiler do that.
db11d8b0ea46: Bug 1470055 - Lift libstdc++ requirement relaxation when building clang-plugin. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Jun 2018 11:45:30 +0900 - rev 477543
Push 9385 by dluca@mozilla.com at 2018-06-22 15:47 +0000
Bug 1470055 - Lift libstdc++ requirement relaxation when building clang-plugin. r=froydnj
b67973aeb2af: Bug 1447951 - Store nsDynamicAtom's chars after the end of the object. r=froydnj
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 22 Jun 2018 09:38:42 +1000 - rev 477525
Push 9385 by dluca@mozilla.com at 2018-06-22 15:47 +0000
Bug 1447951 - Store nsDynamicAtom's chars after the end of the object. r=froydnj This reduces memory usage because we only need one allocation instead of two for the dynamic atom and its chars, and because we don't need to store a refcount and a size. It precludes sharing of chars between dynamic atoms, but we weren't benefiting much from that anyway. This reduces per-process memory usage by up to several hundred KiB on my Linux64 box. One consequence of this change is that we need to allocate + copy in DOMString::SetKnownLiveAtom(), which could make some things slower.
8fc73342ecd9: Bug 1453795 - XPCom/String - Initialize member fields in classes/ structures. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 14 Jun 2018 13:57:45 +0300 - rev 477510
Push 9385 by dluca@mozilla.com at 2018-06-22 15:47 +0000
Bug 1453795 - XPCom/String - Initialize member fields in classes/ structures. r=froydnj
00ae61d46406: Bug 1453795 - XPCOM - Initialize member fields in classes/ structures. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 14:41:20 +0300 - rev 477364
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1453795 - XPCOM - Initialize member fields in classes/ structures. r=froydnj
11018f20ca8d: Bug 1469766 - Update OOM hook on rustc 1.28 after rust PR 51543. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 20 Jun 2018 13:44:10 +0900 - rev 477348
Push 9382 by cbrindusan@mozilla.com at 2018-06-21 15:23 +0000
Bug 1469766 - Update OOM hook on rustc 1.28 after rust PR 51543. r=froydnj
252ca15e9688: Bug 1464571 - fixes DOM Worker performance counters - r=baku,froydnj
Tarek Ziadé <tarek@mozilla.com> - Tue, 19 Jun 2018 16:14:06 +0200 - rev 477184
Push 9380 by csabou@mozilla.com at 2018-06-20 21:48 +0000
Bug 1464571 - fixes DOM Worker performance counters - r=baku,froydnj Now uses StaticPrefs instead of DOMPrefs, and how we count dispatches for Workers. MozReview-Commit-ID: DTumwcI5bG
a61ae45785b0: Bug 1469003 - Convert SegmentedVector to use a manually aligned |unsigned char| array for storage, using a clean C++11 idiom. r=froydnj
Jeff Walden <jwalden@mit.edu> - Mon, 18 Jun 2018 11:55:41 -0700 - rev 477144
Push 9376 by rgurzau@mozilla.com at 2018-06-19 16:01 +0000
Bug 1469003 - Convert SegmentedVector to use a manually aligned |unsigned char| array for storage, using a clean C++11 idiom. r=froydnj
f7bf77f5b69a: Bug 1467468 - Faulty: Run ReadFile() for IsMessageNameBlacklisted() on the main thread. r=valentin, sr=froydnj
Christoph Diehl <cdiehl@mozilla.com> - Thu, 14 Jun 2018 19:20:49 +0200 - rev 476907
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467468 - Faulty: Run ReadFile() for IsMessageNameBlacklisted() on the main thread. r=valentin, sr=froydnj
c6d82575895c: Bug 1464501 - Part 3: Use rust-size to get section sizes. r=froydnj
Eric Rahm <erahm@mozilla.com> - Thu, 07 Jun 2018 17:25:18 -0700 - rev 476857
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464501 - Part 3: Use rust-size to get section sizes. r=froydnj
dd1e05a26606: Bug 1465808 - Update double-conversion to latest upstream. rs=froydnj
Jeff Walden <jwalden@mit.edu> - Tue, 12 Jun 2018 22:12:42 -0700 - rev 476736
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465808 - Update double-conversion to latest upstream. rs=froydnj
132442e73569: Bug 1464501 - Part 3: Use rust-size to get section sizes. r=froydnj
Eric Rahm <erahm@mozilla.com> - Thu, 07 Jun 2018 17:25:18 -0700 - rev 476719
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464501 - Part 3: Use rust-size to get section sizes. r=froydnj
a9ef2fb7b1bc: Bug 1461965 - Enable xpcshell test coverage for GeckoView Telemetry. r=chutten,froydnj,janerik
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 05 Jun 2018 17:01:04 +0200 - rev 476628
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1461965 - Enable xpcshell test coverage for GeckoView Telemetry. r=chutten,froydnj,janerik This patch introduces the nsITelemetryGeckoViewTesting IDL interface which allows to control the Telemetry GeckoView persistence feature. This is useful to enable xpcshell test coverage for GeckoView code on all platforms. MozReview-Commit-ID: Hh0oq4qdqrX
5182bca90d06: Bug 1465709 - Hook rust OOM handler on rustc 1.28. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 31 May 2018 16:36:05 +0900 - rev 476605
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465709 - Hook rust OOM handler on rustc 1.28. r=froydnj Bug 1458161 added a rust OOM handler based on an unstable API that was removed in 1.27, replaced with something that didn't allow to get the failed allocation size. Latest 1.28 nightly (2018-06-13) has https://github.com/rust-lang/rust/pull/50880, https://github.com/rust-lang/rust/pull/51264 and https://github.com/rust-lang/rust/pull/51241 merged, which allow to hook the OOM handler and get the failed allocation size again. Because this is still an unstable API, we explicitly depend on strict versions of rustc. We also explicitly error out if automation builds end up using a rustc version that doesn't allow us to get the allocation size for rust OOM, because we don't want that to happen without knowing.
412df3e5dfa4: Bug 1468272 - Get rid of the codedir usage as it doesn't exist since 2009 r=froydnj
Sylvestre Ledru <sledru@mozilla.com> - Mon, 11 Jun 2018 17:27:34 -0700 - rev 476602
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1468272 - Get rid of the codedir usage as it doesn't exist since 2009 r=froydnj MozReview-Commit-ID: JX0rqoetgN8
faeec6285083: Bug 1467759 - Escape all the property names in JSONWriter. r=froydnj
Alessio Placitelli <alessio.placitelli@gmail.com> - Fri, 08 Jun 2018 19:50:25 +0200 - rev 476599
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467759 - Escape all the property names in JSONWriter. r=froydnj Scalar property names (e.g. IntProperty) are already escaped correctly. This patch escapes the collection property names (e.g. StartObjectProperty) as well (and adds test coverage for it). MozReview-Commit-ID: 68kkjPb2ZN7
627722819abb: Bug 1445383 - update ccache stats parser for ccache 3.4 and 3.5 r=froydnj
Peter Simonyi <pts@petersimonyi.ca> - Sat, 09 Jun 2018 14:55:46 -0400 - rev 476565
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1445383 - update ccache stats parser for ccache 3.4 and 3.5 r=froydnj MozReview-Commit-ID: KTr9RhkJN5B
69ffa8eab9d9: Bug 1456911 - Rewrite the fd shuffling to be simpler & handle identity mappings correctly. r=froydnj
Jed Davis <jld@mozilla.com> - Wed, 25 Apr 2018 17:44:08 -0600 - rev 476563
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1456911 - Rewrite the fd shuffling to be simpler & handle identity mappings correctly. r=froydnj This replaces some old Chromium code that tries to minimally disentangle an arbitrary file descriptor mapping with simpler algorithm, for several reasons: 1. Do something appropriate when a file descriptor is mapped to the same fd number in the child; currently they're ignored, which means they'll be closed if they were close-on-exec. This implementation duplicates the fd twice in that case, which seems to be uncommon in practice; this isn't maximally efficient but avoids special-case code. 2. Make this more generally applicable; the previous design is specialized for arbitrary code running between fork and exec, but we also want to use this on OS X with posix_spawn, which exposes a very limited set of operations. 3. Avoid the use of C++ standard library iterators in async signal safe code; the Chromium developers mention that this is a potential problem in some debugging implementations that take locks. 4. In general the algorithm is simpler and should be more "obviously correct"; more concretely, it should get complete coverage just by being run normally in a debug build. As a convenient side benefit, CloseSuperfluousFds now takes an arbitrary predicate for which fds to leave open, which means it can be used in other code that needs it without creating a fake fd mapping. MozReview-Commit-ID: EoiRttrbrKL
808a2fe2aaab: Bug 1456911 - Prelude: Fix unified build breakage exposed by the next patch. r=froydnj
Jed Davis <jld@mozilla.com> - Fri, 11 May 2018 20:25:19 -0600 - rev 476562
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1456911 - Prelude: Fix unified build breakage exposed by the next patch. r=froydnj This directory has a number of places where files unintentionally depend on `#include`s and `using` directives and forward declarations in other files in the same unified build group. Adding a file shifts the group boundaries and exposes some of those bugs; this patch fixes them (but there are others). MozReview-Commit-ID: AqAOdnXniTn
ffd4b055fb8b: bug 1439383 - clean up the load loadable roots thread when we're done with it r=froydnj,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 07 Jun 2018 15:11:49 -0700 - rev 476197
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
bug 1439383 - clean up the load loadable roots thread when we're done with it r=froydnj,jcj MozReview-Commit-ID: J5GnpwxYguz
22731d5b275a: Bug 1467462 - Adjust test_developer_options after bug 1467041. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 08 Jun 2018 07:11:42 +0900 - rev 476162
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467462 - Adjust test_developer_options after bug 1467041. r=froydnj Bug 1467041 changed the default for --enable-release such that it is affected by the milestone. Test both possible cases for milestones.
f4c9e858aff0: Bug 1466928 - Make mozilla::SmallPointerArray compatible with the C++ object model. r=froydnj
Jeff Walden <jwalden@mit.edu> - Thu, 07 Jun 2018 03:53:54 -0700 - rev 476148
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1466928 - Make mozilla::SmallPointerArray compatible with the C++ object model. r=froydnj
2dac13bda723: Bug 1467336 - Implement mozilla::IsAscii to detect pure ASCII characters. r=froydnj
Jeff Walden <jwalden@mit.edu> - Thu, 07 Jun 2018 02:17:10 -0700 - rev 476144
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467336 - Implement mozilla::IsAscii to detect pure ASCII characters. r=froydnj
b1521154cfec: Bug 1438212 - Implement mozilla::IsFloat32Representable using an algorithm that handles NaN correctly and doesn't sometimes invoke undefined behavior. r=froydnj
Jeff Walden <jwalden@mit.edu> - Wed, 06 Jun 2018 16:03:47 -0700 - rev 476135
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1438212 - Implement mozilla::IsFloat32Representable using an algorithm that handles NaN correctly and doesn't sometimes invoke undefined behavior. r=froydnj
9b5279a09e13: Bug 1465981 - Use memcpy instead of union-arm-punning (which has implementation-defined, desired behavior with gcc and presumably clang, and is not known to have problems on MSVC, but potentially could with other compilers) in BitwiseCast. r=froydnj
Jeff Walden <jwalden@mit.edu> - Wed, 06 Jun 2018 16:03:47 -0700 - rev 476134
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465981 - Use memcpy instead of union-arm-punning (which has implementation-defined, desired behavior with gcc and presumably clang, and is not known to have problems on MSVC, but potentially could with other compilers) in BitwiseCast. r=froydnj
17b140524c6e: Bug 1466909 - Use AddLvalueReference for UniquePtr's operator*(). r=froydnj
André Bargull <andre.bargull@gmail.com> - Thu, 07 Jun 2018 07:27:22 -0700 - rev 476113
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1466909 - Use AddLvalueReference for UniquePtr's operator*(). r=froydnj
14f7dab3a9bd: Bug 1467048 - Add a version of CorruptionCanary for statics. r=froydnj
Eric Rahm <erahm@mozilla.com> - Wed, 06 Jun 2018 14:50:17 -0700 - rev 476043
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467048 - Add a version of CorruptionCanary for statics. r=froydnj This adds 'CorruptionCanaryForStatics', which as the name implies is suitable for use in objects that are statically declared. It has a trivial destructor which allows us to avoid the need for static constructors.
c557100a9ea8: Bug 1467327 - Use bootstrapped clang if no system clang is found. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 Jun 2018 09:57:36 +0900 - rev 475932
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467327 - Use bootstrapped clang if no system clang is found. r=froydnj
ba02d348e3fd: Bug 1467327 - Use bootstrapped clang if no system clang is found. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 07 Jun 2018 09:57:36 +0900 - rev 475869
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467327 - Use bootstrapped clang if no system clang is found. r=froydnj
9f71934b9849: Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 06 Jun 2018 16:13:09 +0900 - rev 475867
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj --enable-release not being passed means developer options are enabled, which is generally speaking not desirable for builds meant to be shipped. This is somewhat alleviated for Firefox by MOZILLA_OFFICIAL implying --enable-release (as well as MOZ_AUTOMATION), but that doesn't apply to e.g. standalone js builds (even some of the standalone js jobs on our automation don't set MOZ_AUTOMATION for some reason). A reasonable thing to do is just to default builds for release/beta milestones to --enable-release, but still allow --disable-release to enable the developer options.
0014f483953e: Bug 1436768 - Add debug code to LazyLogModule. r=froydnj
Eric Rahm <erahm@mozilla.com> - Wed, 09 May 2018 11:16:27 -0700 - rev 475661
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1436768 - Add debug code to LazyLogModule. r=froydnj
c4cf68b6b73f: Bug 1445383 - update ccache stats parser for ccache 3.4 and 3.5 r=froydnj
Peter Simonyi <pts@petersimonyi.ca> - Tue, 05 Jun 2018 00:09:13 -0400 - rev 475578
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1445383 - update ccache stats parser for ccache 3.4 and 3.5 r=froydnj MozReview-Commit-ID: KTr9RhkJN5B
7910d46af606: Bug 1466475 - Make mozilla::Span produce aligned bogus pointers per new Rust rules. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 04 Jun 2018 12:59:46 +0300 - rev 475563
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1466475 - Make mozilla::Span produce aligned bogus pointers per new Rust rules. r=froydnj MozReview-Commit-ID: JFVSRu53Geh
cf6231e7ef0c: Bug 1464568 - Add an IPC call to get transform value for a given element on the compositor. r=froydnj,kats
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 05 Jun 2018 09:18:22 +0900 - rev 475546
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464568 - Add an IPC call to get transform value for a given element on the compositor. r=froydnj,kats This function returns the transform value modified by both OMTA and APZC. Note that the transform conversion code is almost the same as the code dropped in https://hg.mozilla.org/mozilla-central/rev/415811f3804f . MozReview-Commit-ID: HmsMQp3O4n4
82ef13b02416: Bug 1436768 - Add debug code to LazyLogModule. r=froydnj
Eric Rahm <erahm@mozilla.com> - Wed, 09 May 2018 11:16:27 -0700 - rev 475472
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1436768 - Add debug code to LazyLogModule. r=froydnj
f02640343be7: Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj
Miko Mynttinen <mikokm@gmail.com> - Fri, 01 Jun 2018 14:09:30 +0200 - rev 475346
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj MozReview-Commit-ID: KtQ31q6uFqZ
a0d11b55d595: Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
Miko Mynttinen <mikokm@gmail.com> - Fri, 01 Jun 2018 17:59:07 +0200 - rev 475345
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj MozReview-Commit-ID: HpdFXqQdIOO
7c8905b6b226: Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj
Miko Mynttinen <mikokm@gmail.com> - Fri, 01 Jun 2018 14:09:30 +0200 - rev 475325
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465060 - Part 2: Don't suppress pessimizing-move and self-move warnings r=froydnj MozReview-Commit-ID: KtQ31q6uFqZ
10446073eca8: Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
Miko Mynttinen <mikokm@gmail.com> - Fri, 01 Jun 2018 17:59:07 +0200 - rev 475324
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj MozReview-Commit-ID: HpdFXqQdIOO
7c74241c18ea: Bug 1464084 - Don't export std::thread::_M_start_thread symbols with --enable-stdcxx-compat. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 01 Jun 2018 08:10:25 +0900 - rev 475299
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464084 - Don't export std::thread::_M_start_thread symbols with --enable-stdcxx-compat. r=froydnj This relies on the fact that providing multiple --version-script combines them all, so we effectively create a new symbol version that has no global symbol, but hides the std::thread::_M_start_thread symbols. This version script trick happens to work with BFD ld, gold, and lld. The downside is that when providing multiple --version-script's, ld doesn't want any of them to have no version at all. So for the libraries that do already have a version script (through SYMBOLS_FILE), we use a version where there used to be none, using the library name as the version. Practically speaking, this binds the libraries a little closer than they used to be, kind of non-flat namespace on OSX (which is the default there), meaning the dynamic linker will actively want to use symbols from those libraries instead of a system library that might happen to have the same symbol name.
972057926234: Bug 1466054 - Run `mach build-backend -b GnMozbuildWriter`. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 01 Jun 2018 17:22:28 +0900 - rev 475291
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1466054 - Run `mach build-backend -b GnMozbuildWriter`. r=froydnj This refreshes the gn-generated moz.builds with the change from previous commit. Somehow, this does unrelated changes, there must be something funky in the gn-moz.build-generator.
6e7c5695e341: Bug 1466054 - Enable STL wrapping in gn and gyp processed code. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 01 Jun 2018 17:20:51 +0900 - rev 475290
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1466054 - Enable STL wrapping in gn and gyp processed code. r=froydnj We wrap STL headers so as to ensure our inline infallible operator new definitions are used, but for some reason, STL wrappers were disabled in whatever code we used gyp for first, and that ended up spreading as more things used gyp, and now with gn, whose handling cargo culted STL disabling from the gyp code. We remove all this disabling, because it turns out it causes no build problem anymore.
838c0ab9cbdb: Bug 1464084 - Don't export libstdc++ symbols with --enable-stdcxx-compat. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 01 Jun 2018 08:10:25 +0900 - rev 475286
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1464084 - Don't export libstdc++ symbols with --enable-stdcxx-compat. r=froydnj This relies on the fact that providing multiple --version-script combines them all, so we effectively create a new symbol version that has no global symbol, but hides as much std::* stuff as possible. The added symbol script could use `extern "C++"` syntax and demangled symbols but there is no guarantee the demangled symbols won't change. Plus, it's not possible to match demangled symbols that have a return type: they contain a space, and the only way to match that is to use double quotes, which doesn't allow globs at the same time. This version script trick happens to work with BFD ld, gold, and lld. The downside is that when providing multiple --version-script's, ld doesn't want any of them to have no version at all. So for the libraries that do already have a version script (through SYMBOLS_FILE), we use a version where there used to be none, using the library name as the version. Practically speaking, this binds the libraries a little closer than they used to be, kind of non-flat namespace on OSX (which is the default there), meaning the dynamic linker will actively want to use symbols from those libraries instead of a system library that might happen to have the same symbol name.
21c3c5fd4fac: Bug 1462784 - Annotate idle stacks in nsThreadPool. r=froydnj
Markus Stange <mstange@themasta.com> - Thu, 24 May 2018 08:58:44 -0400 - rev 475279
Push 9374 by jlund@mozilla.com at 2018-06-18 21:43 +0000
Bug 1462784 - Annotate idle stacks in nsThreadPool. r=froydnj MozReview-Commit-ID: GtHBHQiXpf3