searching for reviewer(evilpie)
30f92429e81b48118a57dc238da98286a3676a04: Bug 1699569 - Null terminate copied string under error condition r=evilpie,kmag
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 16 Apr 2021 16:32:29 +0000 - rev 643948
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1699569 - Null terminate copied string under error condition r=evilpie,kmag Differential Revision: https://phabricator.services.mozilla.com/D112047
ced517f952ce8591d012ba92711859ef89a900f7: Bug 1704561 - Ensure that Module return value is an object before binding it to evaluationPromise; r=evilpie
Yulia Startsev <ystartsev@mozilla.com> - Thu, 15 Apr 2021 12:28:48 +0000 - rev 643771
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1704561 - Ensure that Module return value is an object before binding it to evaluationPromise; r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D111849
62a94cbcdb7ebd71ec3ba4ecd54fc86a723859e5: Bug 1692018 - Fix LinkHandlerChild protocol regex r=evilpie
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 07 Apr 2021 11:10:36 +0000 - rev 642373
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1692018 - Fix LinkHandlerChild protocol regex r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D111082
c4825995d926d0631cad91afc779af90743c8f47: Bug 1700052 part 11 - Store getter/setter objects in slots instead of in the shape tree. r=jonco,evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 07 Apr 2021 07:16:07 +0000 - rev 642239
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700052 part 11 - Store getter/setter objects in slots instead of in the shape tree. r=jonco,evilpie There will be additional cleanup of the Shape code in follow-up patches. Differential Revision: https://phabricator.services.mozilla.com/D110258
250d9004c967dafd753255b72e3ac60b89d6c970: Bug 1470081 part 4 - Remove JSGetterOp and JSSetterOp. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Fri, 26 Mar 2021 08:51:26 +0000 - rev 640782
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1470081 part 4 - Remove JSGetterOp and JSSetterOp. r=evilpie Depends on D109359 Differential Revision: https://phabricator.services.mozilla.com/D109360
2d857a9fa2ca6ea068c077a4ed421db9525e2a09: Bug 1470081 part 2 - Remove JSGetterOp/JSSetterOp from PropertyDescriptor. r=evilpie,anba
Jan de Mooij <jdemooij@mozilla.com> - Fri, 26 Mar 2021 08:51:25 +0000 - rev 640780
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1470081 part 2 - Remove JSGetterOp/JSSetterOp from PropertyDescriptor. r=evilpie,anba GetterOp/SetterOp are now only used internally for array and arguments objects. PropertyDescriptor no longer has to know about these properties. Differential Revision: https://phabricator.services.mozilla.com/D109358
3d94e8d65c717a4efcaa74a707890847904ef370: Bug 1470081 part 1 - Stop using NativeDefineProperty for mapped ArgumentsObject properties. r=evilpie,anba
Jan de Mooij <jdemooij@mozilla.com> - Fri, 26 Mar 2021 08:51:24 +0000 - rev 640779
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1470081 part 1 - Stop using NativeDefineProperty for mapped ArgumentsObject properties. r=evilpie,anba This will let us remove GetterOp/SetterOp support from PropertyDescriptor in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D109357
b4c5cd4f232761de3998bd31a8b5b98c3ce755cd: Bug 1687025: Inline Array#forEach and friends r=evilpie
Iain Ireland <iireland@mozilla.com> - Tue, 23 Mar 2021 18:46:38 +0000 - rev 640298
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1687025: Inline Array#forEach and friends r=evilpie This was ~3x faster in a microbenchmark for `forEach`, `every`, and `some`, and ~2x faster for `map`. Differential Revision: https://phabricator.services.mozilla.com/D109415
38b147584291e1be326b02457622970dc20fa105: Bug 1700034 - Use MAX_ARRAY_INDEX for all isIndex functions. r=evilpie,anba
Jan de Mooij <jdemooij@mozilla.com> - Tue, 23 Mar 2021 06:24:02 +0000 - rev 640112
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1700034 - Use MAX_ARRAY_INDEX for all isIndex functions. r=evilpie,anba This fixes an inconsistency where IdIsIndex used MAX_ARRAY_INDEX (UINT32_MAX - 1) as maximum index value and isIndex on JSLinearString/JSAtom used UINT32_MAX. We now use MAX_ARRAY_INDEX as maximum index value for all of these. In the future it might make sense to optimize index values >= UINT32_MAX better (for example for large typed array indexes) and separate these two kinds again somehow, but for now it's better to be consistent. Differential Revision: https://phabricator.services.mozilla.com/D109268
ab1644a7b0eecbba9cad87f48821dc6c82bb8eab: Bug 1698791 part 3 - Add an is-index flag to JS atoms. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 20:58:29 +0000 - rev 640051
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 3 - Add an is-index flag to JS atoms. r=evilpie This lets us speed up JSAtom to PropertyKey conversions. This matters for example for megamorphic GetElem lookups (a very hot code path for modern JS frameworks). Although this calls isIndexSlow for each atom we create, it still results in a lot less calls to that method compared to before, when browsing some popular websites. Differential Revision: https://phabricator.services.mozilla.com/D108743
190e231ffdeb292c28d4f66164328dfe786d4a80: Bug 1698791 part 2 - Use isIndex/CheckStringIsIndex for StringIsArrayIndex. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 20:58:28 +0000 - rev 640050
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 2 - Use isIndex/CheckStringIsIndex for StringIsArrayIndex. r=evilpie StringIsArrayIndex is almost identical to isIndex/CheckStringIsIndex, but it's limited to UINT32_MAX - 2 instead of UINT32_MAX. This patch de-duplicates this with an explicit check for the smaller max length. This ensures we can benefit from the index-value optimization and the ATOM_IS_INDEX flag added in the next patch. The difference in maximum length is still confusing and should probably be cleaned up separately. Differential Revision: https://phabricator.services.mozilla.com/D108742
d1c00e47dfce7b6fef3bd40b4fcbe2a12f22756c: Bug 1698791 part 1 - Replace JSLinearString::isIndexSlow with CheckStringIsIndex. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 20:58:28 +0000 - rev 640049
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 1 - Replace JSLinearString::isIndexSlow with CheckStringIsIndex. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D108741
1bd16d8959e5450ed6fa84f56bca4c14a3befa27: Bug 1698791 part 3 - Add an is-index flag to JS atoms. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 16:16:35 +0000 - rev 639965
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 3 - Add an is-index flag to JS atoms. r=evilpie This lets us speed up JSAtom to PropertyKey conversions. This matters for example for megamorphic GetElem lookups (a very hot code path for modern JS frameworks). Although this calls isIndexSlow for each atom we create, it still results in a lot less calls to that method compared to before, when browsing some popular websites. Differential Revision: https://phabricator.services.mozilla.com/D108743
467a7afcdd3d4d489833ac88803d244529b7bc0e: Bug 1698791 part 2 - Use isIndex/CheckStringIsIndex for StringIsArrayIndex. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 16:16:35 +0000 - rev 639964
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 2 - Use isIndex/CheckStringIsIndex for StringIsArrayIndex. r=evilpie StringIsArrayIndex is almost identical to isIndex/CheckStringIsIndex, but it's limited to UINT32_MAX - 2 instead of UINT32_MAX. This patch de-duplicates this with an explicit check for the smaller max length. This ensures we can benefit from the index-value optimization and the ATOM_IS_INDEX flag added in the next patch. The difference in maximum length is still confusing and should probably be cleaned up separately. Differential Revision: https://phabricator.services.mozilla.com/D108742
48b921d8aeee4621a4027d1f324c093f286b5f81: Bug 1698791 part 1 - Replace JSLinearString::isIndexSlow with CheckStringIsIndex. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 22 Mar 2021 16:16:34 +0000 - rev 639963
Push 15309 by ffxbld-merge at Mon, 19 Apr 2021 17:51:21 +0000
Bug 1698791 part 1 - Replace JSLinearString::isIndexSlow with CheckStringIsIndex. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D108741
a71077321e06a11d045e321096a3a8efd4c0aec5: Bug 1697803 - Use DOM getter optimization for GetProp on WindowProxy too. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 16 Mar 2021 08:21:52 +0000 - rev 638720
Push 15212 by ffxbld-merge at Mon, 22 Mar 2021 14:40:41 +0000
Bug 1697803 - Use DOM getter optimization for GetProp on WindowProxy too. r=evilpie This is similar to what we do for GetName already. Differential Revision: https://phabricator.services.mozilla.com/D108429
181e16e12d9d960e747052d92ba5586e9aa66425: Bug 1684183 - stop replacing file extensions for zip, json and xml files, and add a pref in case further issues appear for the other document types r=evilpie
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 06 Jan 2021 19:16:48 +0000 - rev 629122
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1684183 - stop replacing file extensions for zip, json and xml files, and add a pref in case further issues appear for the other document types r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D100801
1f2cc599924e3f3e977e43c1b31789b41dd3b9bf: Bug 1672862 - Part 11: Remove failSoft mode from ObjectOpResult. r=tcampbell,evilpie
André Bargull <andre.bargull@gmail.com> - Tue, 22 Dec 2020 16:18:23 +0000 - rev 628590
Push 15035 by ffxbld-merge at Mon, 25 Jan 2021 15:18:06 +0000
Bug 1672862 - Part 11: Remove failSoft mode from ObjectOpResult. r=tcampbell,evilpie Parts 3-4 removed the only callers to `ObjectOpResult::failSoft()`. Differential Revision: https://phabricator.services.mozilla.com/D99400
0637bb0db1ea38d58c4c9fc7321fd77d3ea6dd06: Bug 1684183 - stop replacing file extensions for zip, json and xml files, and add a pref in case further issues appear for the other document types. r=evilpie, a=jcristau
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 06 Jan 2021 19:16:48 +0000 - rev 627317
Push 14994 by jcristau@mozilla.com at Thu, 07 Jan 2021 14:42:35 +0000
Bug 1684183 - stop replacing file extensions for zip, json and xml files, and add a pref in case further issues appear for the other document types. r=evilpie, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D100801
f50e7b70132a6dc7c2ec96719314b3cf95f4a11d: Bug 1665746 - Do not use self-hosted JS parameter name in decompiler. r=evilpie
Tooru Fujisawa <arai_a@mac.com> - Mon, 12 Oct 2020 12:27:20 +0000 - rev 618506
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665746 - Do not use self-hosted JS parameter name in decompiler. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D90718
48b632dabf393cd283c2dd04cdd0954da493a158: Bug 1669481 part 3 - Remove IonCacheIRCompiler::stub_. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 08 Oct 2020 08:38:58 +0000 - rev 617847
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669481 part 3 - Remove IonCacheIRCompiler::stub_. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D92621
ca23b81385d4805dd406a7b5e466f2205a0e3f66: Bug 1669481 part 2 - Change DOMExpandoGeneration stub field to RawInt64. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 08 Oct 2020 08:38:51 +0000 - rev 617846
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669481 part 2 - Change DOMExpandoGeneration stub field to RawInt64. r=evilpie The Ion CacheIR implementation can now bake in the generation again instead of loading it from the stub. Differential Revision: https://phabricator.services.mozilla.com/D92609
d9ca15f17655b0e3fc0f60b2d7576d9aff080be5: Bug 1669481 part 1 - Stop updating IC stubs for DOMExpandoGeneration changes. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 08 Oct 2020 08:38:28 +0000 - rev 617845
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1669481 part 1 - Stop updating IC stubs for DOMExpandoGeneration changes. r=evilpie Updating stubs complicates Warp transpiler support for DOM proxies and doesn't actually show up much on websites. Differential Revision: https://phabricator.services.mozilla.com/D92608
9c47bca207be7bdaf827d73a24332e1c2aec2545: Bug 1667333: Remove unecessary prefs for mime type checking r=necko-reviewers,evilpie,valentin
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Mon, 28 Sep 2020 06:35:10 +0000 - rev 616320
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667333: Remove unecessary prefs for mime type checking r=necko-reviewers,evilpie,valentin Differential Revision: https://phabricator.services.mozilla.com/D91406
3ee21418fd0ab4d8adc5e8aef6b2494a98802b9c: Bug 1643944 - Part 3: Transpile LoadFunctionName. r=evilpie
André Bargull <andre.bargull@gmail.com> - Wed, 23 Sep 2020 09:08:54 +0000 - rev 615755
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1643944 - Part 3: Transpile LoadFunctionName. r=evilpie Transpile LoadFunctionName using the same approach as taken for LoadFunctionLength. Depends on D90966 Differential Revision: https://phabricator.services.mozilla.com/D90967
4cda8cdf45cca5d63533a529bc7243208fdddf10: Bug 1643944 - Part 2: Optimise function.name in CacheIR. r=evilpie
André Bargull <andre.bargull@gmail.com> - Wed, 23 Sep 2020 08:36:43 +0000 - rev 615754
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1643944 - Part 2: Optimise function.name in CacheIR. r=evilpie Optimise `function.name` similar to the existing `function.length` optimisation. Depends on D90965 Differential Revision: https://phabricator.services.mozilla.com/D90966
6f10ebed59c75e821103a76d94265e640a8b6eb7: Bug 1643944 - Part 1: Use else-statement in finishBoundFunctionInit. r=evilpie
André Bargull <andre.bargull@gmail.com> - Tue, 22 Sep 2020 11:43:49 +0000 - rev 615753
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1643944 - Part 1: Use else-statement in finishBoundFunctionInit. r=evilpie `name` is non-nullptr if and only if the non-resolve hook fast-path was taken. That means we can change `if (!name)` to use a simple `else` statement. Differential Revision: https://phabricator.services.mozilla.com/D90965
5ac011c643ed81fb74982843660d1a8bf6d4b035: Bug 1663401 - Add ARM64 implementation of Pop(FloatRegister). r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Mon, 07 Sep 2020 11:09:01 +0000 - rev 613020
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1663401 - Add ARM64 implementation of Pop(FloatRegister). r=evilpie We were hitting the MOZ_CRASH when running jit-tests or Fenix with Warp enabled. Differential Revision: https://phabricator.services.mozilla.com/D89356
6a146cf8deb2d3a863f4a54cd2de77cb36b7de6f: Bug 1660983 part 3 - Don't turn prototypes into singletons if TI is disabled. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 25 Aug 2020 11:23:41 +0000 - rev 611415
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660983 part 3 - Don't turn prototypes into singletons if TI is disabled. r=evilpie Just a drive-by change for something I noticed. Depends on D88130 Differential Revision: https://phabricator.services.mozilla.com/D88131
f9d5521819eb47cc5ec5261d014932e1f2344961: Bug 1660983 part 2 - Make the function.prototype AddSlot optimization not depend on TI. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 25 Aug 2020 12:53:37 +0000 - rev 611414
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660983 part 2 - Make the function.prototype AddSlot optimization not depend on TI. r=evilpie This makes the optimization work with Warp. Also stop emitting GuardGroup if TI is disabled. Differential Revision: https://phabricator.services.mozilla.com/D88130
3b3331ff39f44af81124cd3a1442fe04302e0add: Bug 1660983 part 1 - Remove unnecessary holderId variable in tryAttachAddSlotStub. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 25 Aug 2020 11:07:10 +0000 - rev 611413
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660983 part 1 - Remove unnecessary holderId variable in tryAttachAddSlotStub. r=evilpie holderId was used for unboxed object expando properties. Differential Revision: https://phabricator.services.mozilla.com/D88129
82268ceb01e970132a6bdf5a178f68f9f8963352: Bug 1655405 - Properly handle numeric field names initialized with anonymous functions in classes. r=evilpie
Jeff Walden <jwalden@mit.edu> - Tue, 28 Jul 2020 12:46:46 +0000 - rev 607021
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1655405 - Properly handle numeric field names initialized with anonymous functions in classes. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D85093
f112125cab4db8b9665ae3072df166b0e9ccfdbe: Bug 1651645 part 9 - Add NON_PACKED flag to ObjectElements, use it in IsPackedArray. r=evilpie,anba
Jan de Mooij <jdemooij@mozilla.com> - Tue, 14 Jul 2020 07:02:11 +0000 - rev 604726
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 9 - Add NON_PACKED flag to ObjectElements, use it in IsPackedArray. r=evilpie,anba This way IsPackedArray does not depend on TI and can be used with Warp. Adds MStoreHoleValueElement for JSOp::InitElemArray writing a hole value. This instruction writes the hole value and sets the NON_PACKED flag. ICs don't optimize writing holes. We now also check in debug builds that if IsPackedArray returns true, the first few elements aren't the magic hole value. Differential Revision: https://phabricator.services.mozilla.com/D82966
783890691a76b39c4eb26f482ad815889643f881: Bug 1651645 part 8 - Fold writeToIndexWouldMarkNotPacked into its sole caller. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 21:31:04 +0000 - rev 604725
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 8 - Fold writeToIndexWouldMarkNotPacked into its sole caller. r=evilpie Also move it down a bit because we only need to do this when writing to an index > initlength. Depends on D82964 Differential Revision: https://phabricator.services.mozilla.com/D82965
5c435dbe3a720460af6daa0e993f9aa603e9379b: Bug 1651645 part 7 - Clean up ensureDenseInitializedLength a bit. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 21:29:35 +0000 - rev 604724
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 7 - Clean up ensureDenseInitializedLength a bit. r=evilpie Re-organize the code. Add an early return instead of a big if-statement. Change the initlen reference to a plain uint32_t. Depends on D82963 Differential Revision: https://phabricator.services.mozilla.com/D82964
726d3e7fd0428cf47be8bd3cb7931551f8db3c77: Bug 1651645 part 6 - Fold ensureDenseInitializedLengthNoPackedCheck into ensureDenseInitializedLength and call from ensureDenseElements. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 20:55:30 +0000 - rev 604723
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 6 - Fold ensureDenseInitializedLengthNoPackedCheck into ensureDenseInitializedLength and call from ensureDenseElements. r=evilpie The old code in ensureDenseElements marked non-packed before extending the elements capacity. That's a problem because it can be the statically-allocated EmptyObjectElements and we can't set the flag on that. It's clearer to do the non-packed check in ensureDenseInitializedLength. Depends on D82962 Differential Revision: https://phabricator.services.mozilla.com/D82963
9a6e4bca8f6ae1fbc3b7556bac1f63fa45d6c97a: Bug 1651645 part 5 - Assert initDenseElement/setDenseElement aren't called with the hole MagicValue. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 14 Jul 2020 07:26:24 +0000 - rev 604722
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 5 - Assert initDenseElement/setDenseElement aren't called with the hole MagicValue. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82962
c7a06239c86036335898d1ccf7aa477634c8b619: Bug 1651645 part 4 - Use setDenseElementHole in removeDenseElementForSparseIndex. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 20:55:29 +0000 - rev 604721
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 4 - Use setDenseElementHole in removeDenseElementForSparseIndex. r=evilpie The goal is to have just one place where OBJECT_FLAG_NON_PACKED is set. Depends on D82960 Differential Revision: https://phabricator.services.mozilla.com/D82961
d34278f7a4a713aada6fe56289a344395f194415: Bug 1651645 part 3 - Use markDenseElementsNotPacked in setDenseElementHole. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 20:55:29 +0000 - rev 604720
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 3 - Use markDenseElementsNotPacked in setDenseElementHole. r=evilpie Depends on D82959 Differential Revision: https://phabricator.services.mozilla.com/D82960
4a7666aa3cc64b5f63cc6ef1e816359cac07a0da: Bug 1651645 part 2 - Simplify DeleteArrayElement, make some methods private. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 20:55:29 +0000 - rev 604719
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 2 - Simplify DeleteArrayElement, make some methods private. r=evilpie Depends on D82958 Differential Revision: https://phabricator.services.mozilla.com/D82959
1b1c0c802a6b47c8d7c52725212ad23cdc636a10: Bug 1651645 part 1 - Inline setDenseElementMaybeConvertDouble into its sole caller. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 20:55:29 +0000 - rev 604718
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651645 part 1 - Inline setDenseElementMaybeConvertDouble into its sole caller. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82958
e33443877fc0e9b1417b4dbb3053486e250bdfab: Bug 1652153: Clear any pending exception when JS_EncodeStringToUTF8 failed in ErrorReportBuilder::init. r=evilpie
André Bargull <andre.bargull@gmail.com> - Mon, 13 Jul 2020 14:39:52 +0000 - rev 604578
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1652153: Clear any pending exception when JS_EncodeStringToUTF8 failed in ErrorReportBuilder::init. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D83237
2d225e4e6cff0d6156b311a6047bcd3f33174f1e: Bug 1651037 part 6 - Make MGuardProto work with MNurseryObject. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Jul 2020 11:01:13 +0000 - rev 603916
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651037 part 6 - Make MGuardProto work with MNurseryObject. r=evilpie Adds MGuardNullProto for the nullptr case. Depends on D82671 Differential Revision: https://phabricator.services.mozilla.com/D82672
55370f1ee53228f918133373967e71d8c67aa96f: Bug 1651037 part 5 - Change some MIR instructions to prepare for MNurseryObject use. r=iain,evilpie
Jan de Mooij <jdemooij@mozilla.com> - Thu, 09 Jul 2020 07:02:25 +0000 - rev 603915
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1651037 part 5 - Change some MIR instructions to prepare for MNurseryObject use. r=iain,evilpie WrappedFunction only needs the JSFunction* for natives. This way we can still optimize scripted calls to nursery-allocated functions. Depends on D82670 Differential Revision: https://phabricator.services.mozilla.com/D82671
c7b6b13b88f4f6f703394ed3bf1981620818d723: Bug 1646199 part 4 - Transpile GuardProto and GuardNullProto. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jul 2020 14:59:09 +0000 - rev 603694
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 4 - Transpile GuardProto and GuardNullProto. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82330
66141f547b06d8d809b9e5b70705f833fc2ecf62: Bug 1646199 part 3 - Assert object stub fields are non-nullptr. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jul 2020 15:02:49 +0000 - rev 603693
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 3 - Assert object stub fields are non-nullptr. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82329
00f8d21e8211027c8c2dbfb355d2302e04481689: Bug 1646199 part 2 - Split XrayExpandoShapeAndDefaultProto in two instructions to avoid storing a nullptr object. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Wed, 08 Jul 2020 09:59:24 +0000 - rev 603692
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 2 - Split XrayExpandoShapeAndDefaultProto in two instructions to avoid storing a nullptr object. r=evilpie This way we can also remove the hasExpando flag. Differential Revision: https://phabricator.services.mozilla.com/D82539
8d77f43ba3e869ab43140cceaa1b09cdc322723b: Bug 1646199 part 1 - Fix CacheIR LoadProto to assert the result isn't nullptr. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jul 2020 15:02:49 +0000 - rev 603691
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 1 - Fix CacheIR LoadProto to assert the result isn't nullptr. r=evilpie Use GuardProto / GuardNullProto to prevent loading a null proto in LoadProto. The next patch will assert objects stored in stub fields are always non-null. Differential Revision: https://phabricator.services.mozilla.com/D82328
07db2282c6f979160edf55885673d871ac2f89d4: Bug 1646199 part 3 - Transpile GuardProto and GuardNullProto. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jul 2020 06:45:43 +0000 - rev 603475
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 3 - Transpile GuardProto and GuardNullProto. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82330
bb26ed69fa5a879c12257b0d6fddd5fb27e35db6: Bug 1646199 part 2 - Assert object stub fields are non-nullptr. r=evilpie
Jan de Mooij <jdemooij@mozilla.com> - Tue, 07 Jul 2020 06:45:26 +0000 - rev 603474
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1646199 part 2 - Assert object stub fields are non-nullptr. r=evilpie Differential Revision: https://phabricator.services.mozilla.com/D82329