searching for reviewer(erahm)
b7de4c7bb68d5f89ff1600cf103ef0d911dfc638: Bug 1545381 - be more defensive in nsAppShellSingleton; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Mon, 22 Jul 2019 23:52:35 +0300 - rev 541507
Push 11628 by shindli@mozilla.com at Tue, 23 Jul 2019 21:26:25 +0000
Bug 1545381 - be more defensive in nsAppShellSingleton; r=erahm We're seeing crashes in bug 1545381 in appshell shutdown, which appear to point to appshell initialization somehow falling over non-obviously. Appshell initialization should basically never fail, so let's complain loudly if that ever happens. Differential Revision: https://phabricator.services.mozilla.com//D38915
822cb68b6ab75c96d7e36aa1f7fffda122d41f0c: Bug 1083971 - Add an option to output a binary file for the PSL data r=leplatrem,erahm
Arpit Bharti <arpitbharti73@gmail.com> - Tue, 02 Jul 2019 12:28:48 +0000 - rev 540575
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1083971 - Add an option to output a binary file for the PSL data r=leplatrem,erahm Differential Revision: https://phabricator.services.mozilla.com/D34364
a78ae8f1c287195f2d08c647625b92402d6a07ae: Bug 1562036 - [awsy] Re-enable "browser.tabs.remote.separatePrivilegedContentProcess". r=erahm
Henrik Skupin <mail@hskupin.info> - Sat, 29 Jun 2019 15:55:38 +0000 - rev 540350
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1562036 - [awsy] Re-enable "browser.tabs.remote.separatePrivilegedContentProcess". r=erahm Differential Revision: https://phabricator.services.mozilla.com/D36298
46fbd76b43e262194f58cbb015d022eee6104b7b: Bug 1530660: Fix registration for nsSafeFileOutputStream. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 20 Jun 2019 15:40:35 -0700 - rev 539437
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1530660: Fix registration for nsSafeFileOutputStream. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D35490
ffff810a545bfe707bbe23c51827821f043d3739: Bug 1559220 - Special case IndexedDB threads in wakeup telemetry, r=erahm
Olli Pettay <Olli.Pettay@helsinki.fi> - Sun, 16 Jun 2019 21:03:45 +0000 - rev 538717
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1559220 - Special case IndexedDB threads in wakeup telemetry, r=erahm The approach isn't perhaps super elegant, but it is a small and simple tweak. Differential Revision: https://phabricator.services.mozilla.com/D34923
12d826365c0c5009e025728bca75829227f5ceab: Bug 1558882 - Fixed intermittent on ThreadMetrics.CollectMetrics r=erahm
Tarek Ziadé <tarek@mozilla.com> - Fri, 14 Jun 2019 16:43:01 +0000 - rev 538535
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1558882 - Fixed intermittent on ThreadMetrics.CollectMetrics r=erahm The first test does not really need to check that we spend less than 200ms, and we can give more time to the scheduler in the second test, as long as we check that is less than the recursive dispatched event Differential Revision: https://phabricator.services.mozilla.com/D34988
a01cf6b0fc83e480637774c4636a3d40169176fd: Bug 1556993 - Ignore invalid handles in Mozilla{,Un}RegisterDebugHandle - r=erahm
Gerald Squelart <gsquelart@mozilla.com> - Wed, 12 Jun 2019 23:23:20 +0000 - rev 538209
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556993 - Ignore invalid handles in Mozilla{,Un}RegisterDebugHandle - r=erahm In particular, on Windows stdin/out/err may not be associated with a stream (e.g., app without console window), in which case _get_osfhandle() returns -2. Differential Revision: https://phabricator.services.mozilla.com/D34513
00ed5464273769a318dfd037f9044268e9ea5bfb: Bug 1554292 - Add simple telemetry probe to gather information about threads' wakeup frequency, r=erahm
Olli Pettay <Olli.Pettay@helsinki.fi> - Wed, 05 Jun 2019 20:26:09 +0000 - rev 537721
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1554292 - Add simple telemetry probe to gather information about threads' wakeup frequency, r=erahm This patch takes the approach to count up to 100 wakeups and reports then time it took for that period. Regression in wakeups could show up as decreased mean or median time. Differential Revision: https://phabricator.services.mozilla.com/D32543
39063905a5b8abcdf9e22efe94855621f69906f1: Bug 1122740 - remove useless null checks after allocating memory with |new| r=erahm
Nicklas Boman <smurfd@gmail.com> - Tue, 04 Jun 2019 04:43:11 +0000 - rev 536360
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1122740 - remove useless null checks after allocating memory with |new| r=erahm Differential Revision: https://phabricator.services.mozilla.com/D33445
af36f91523276c0e96596810dc480e1a5ae80921: Bug 1551648 - Record peak resident memory usage in telemetry. r=erahm
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 23 May 2019 20:06:33 +0000 - rev 534921
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551648 - Record peak resident memory usage in telemetry. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D32184
723d1a2c81e8bfb8dfce985e6e9fffa3716a1c7b: Bug 1539759 - Improve DTD entity handling. r=erahm
Peter Van der Beken <peterv@propagandism.org> - Tue, 21 May 2019 18:24:02 +0000 - rev 534458
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1539759 - Improve DTD entity handling. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D30248
d996ccc0aa7eab043a8b926c3dffcd7d899530b6: Bug 1530660: Fix registration for nsSafeFileOutputStream. r=erahm, a=jcristau
Kris Maglione <maglione.k@gmail.com> - Thu, 20 Jun 2019 15:40:35 -0700 - rev 534027
Push 11498 by jcristau@mozilla.com at Wed, 26 Jun 2019 09:03:59 +0000
Bug 1530660: Fix registration for nsSafeFileOutputStream. r=erahm, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D35490
52dbf56c513ce3c74033a3b8d0d47483dd868df5: Bug 1558882 - Fixed intermittent on ThreadMetrics.CollectMetrics. r=erahm, a=test-only
Tarek Ziadé <tarek@mozilla.com> - Fri, 14 Jun 2019 16:43:01 +0000 - rev 533926
Push 11463 by jcristau@mozilla.com at Mon, 17 Jun 2019 17:28:38 +0000
Bug 1558882 - Fixed intermittent on ThreadMetrics.CollectMetrics. r=erahm, a=test-only The first test does not really need to check that we spend less than 200ms, and we can give more time to the scheduler in the second test, as long as we check that is less than the recursive dispatched event Differential Revision: https://phabricator.services.mozilla.com/D34988
0be0455b63e02d8cd9c096a4837f6a47167fcb62: Bug 1539759 - Improve DTD entity handling. r=erahm a=jcristau
Peter Van der Beken <peterv@propagandism.org> - Tue, 21 May 2019 18:24:02 +0000 - rev 533632
Push 11381 by archaeopteryx@coole-files.de at Wed, 05 Jun 2019 18:22:40 +0000
Bug 1539759 - Improve DTD entity handling. r=erahm a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D30248
a15e072aac3f4e1fbfc78a9931c0290fba2d09cd: Bug 1551083 - Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r=erahm
Sylvestre Ledru <sledru@mozilla.com> - Tue, 14 May 2019 07:12:19 +0000 - rev 532567
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1551083 - Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r=erahm Depends on D30816 Differential Revision: https://phabricator.services.mozilla.com/D30817
7b168d837392915c41fe70b506222115659ff078: Bug 1551203, Bug 1551203 - Give ThrottledEventQueues names, r=erahm
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 13 May 2019 18:12:24 +0000 - rev 532459
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1551203, Bug 1551203 - Give ThrottledEventQueues names, r=erahm Differential Revision: https://phabricator.services.mozilla.com/D30920
16c03995ac55ce131282881c7c5d31ee6061441e: Bug 1539759 - Improve DTD entity handling. r=erahm
Peter Van der Beken <peterv@propagandism.org> - Mon, 13 May 2019 07:32:42 +0000 - rev 532409
Push 11268 by csabou@mozilla.com at Tue, 14 May 2019 15:24:22 +0000
Bug 1539759 - Improve DTD entity handling. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D30248
455d6f8a9d95bb4cd471e52c63fe03f64fa29d4e: Bug 1541183 - make sw-tp6 tier 3, r=erahm
Bob Clary <bclary@bclary.com> - Thu, 09 May 2019 18:42:06 +0000 - rev 532100
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541183 - make sw-tp6 tier 3, r=erahm Differential Revision: https://phabricator.services.mozilla.com/D30492
0e33c9c98d2c75fa62d4606feec22c5db6302779: Bug 1461601 - lower the OOM bound for TArray::test_fallible on Windows; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 01 May 2019 17:04:40 +0000 - rev 530951
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1461601 - lower the OOM bound for TArray::test_fallible on Windows; r=erahm Apparently 7 is not low enough. Maybe 6 will be. Differential Revision: https://phabricator.services.mozilla.com/D29503
8068f2c5ad489441277268b53e337a5b1de790d0: Bug 1478787: Rebuild stale SharedMap on Has() call. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 26 Jul 2018 13:23:54 -0700 - rev 530910
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1478787: Rebuild stale SharedMap on Has() call. r=erahm MozReview-Commit-ID: 5aFVBNQW4QR Differential Revision: https://phabricator.services.mozilla.com/D29398
ad8ea6ea53e9ec9df9ff49db568fa174c74daf36: Bug 1526086: Fix possible shutdown deadlock when writing preloader cache. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 18 Apr 2019 13:11:22 -0700 - rev 529747
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1526086: Fix possible shutdown deadlock when writing preloader cache. r=erahm There are currently some odd circumstances where we deadlock waiting for the background save thread to finish while it is blocked on sync dispatch to the main thread during shutdown. There were existing workarounds to prevent this, which tried to synchronously complete the main thread work required by the background thread at the start of shutdown, and some fallback anti-deadlock assertions to catch any remaining corner cases, but apparently Fennec has corner cases of its own that we didn't anticipate. This patch takes the more straightforward route of using an async shutdown blocker, which allows the async shutdown service to safely spin the event loop until the save completes, rather than an independent monitor loop, which does not. It also fixes a potential data race where the save thread could clear its mSaveThread member before NS_NewNamedThread returned, running afoul of nsCOMPtr sanity checks. Differential Revision: https://phabricator.services.mozilla.com/D28127
64e6baec51501e1ebab151e9d317fa68ea3d7dbd: Bug 1544286 - xpcom/ manual ESLint no-throw-literal fixes. r=erahm
Ian Moody <moz-ian@perix.co.uk> - Tue, 16 Apr 2019 15:02:10 +0000 - rev 528630
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544286 - xpcom/ manual ESLint no-throw-literal fixes. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D27451
59ae6dc11ba316a178ebbb5ad65a809c9118d5a8: bug 1542836: toolkit/xre: format --MOZ_LOG and --MOZ_LOG_FILE help text; r=erahm
Andreas Tolfsen <ato@sny.no> - Mon, 08 Apr 2019 19:30:44 +0000 - rev 527230
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1542836: toolkit/xre: format --MOZ_LOG and --MOZ_LOG_FILE help text; r=erahm Produces a help text that conforms to the line width recommendations of nsICommandLine. On the other hand, the formatting of the source code itself is rendered rather ugly by clang-format. Differential Revision: https://phabricator.services.mozilla.com/D26583
88c2a60599669ee7899764812730b90ce98a1450: Bug 1525303 - make LazyLogModule::operator LogModule* inline; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Tue, 02 Apr 2019 20:35:38 +0000 - rev 526551
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1525303 - make LazyLogModule::operator LogModule* inline; r=erahm Testing has determined that doing this has no detrimental size benefit, and a small positive performance impact. Differential Revision: https://phabricator.services.mozilla.com/D25848
31c1b09faec49bde81d6cb798f930e95b70f6141: Bug 1520339 - Part 2: handling memory reporting for VR process. r=kip,erahm
Daosheng Mu <daoshengmu@gmail.com> - Tue, 02 Apr 2019 05:13:17 +0000 - rev 526336
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1520339 - Part 2: handling memory reporting for VR process. r=kip,erahm Differential Revision: https://phabricator.services.mozilla.com/D25321
dc1284f4647243b786d5989edd0aeae952994866: bug 1439002 - remove useless debug spew from nsSiteSecurityService r=erahm
Dana Keeler <dkeeler@mozilla.com> - Mon, 01 Apr 2019 17:07:20 +0000 - rev 526255
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1439002 - remove useless debug spew from nsSiteSecurityService r=erahm Differential Revision: https://phabricator.services.mozilla.com/D25489
a5c4f7e6069a1962f5364226f4746914c08ae6ef: Bug 1539605 - add fast paths for integer formatting on nsTSubstring; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Fri, 29 Mar 2019 19:38:53 +0000 - rev 525686
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539605 - add fast paths for integer formatting on nsTSubstring; r=erahm This way we don't have to go through a bunch of printf nonsense, and we ought to be able to arrive at optimized routines that take advantage of constant radices, etc. Differential Revision: https://phabricator.services.mozilla.com/D25141
966a73bd6d8e2ff7f41517fea42b17a569d82804: Bug 1539815 - move inner queue creation into the PrioritizedEventQueue constructor; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Fri, 29 Mar 2019 20:37:09 +0000 - rev 525667
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539815 - move inner queue creation into the PrioritizedEventQueue constructor; r=erahm Outside code shouldn't have to care how many levels of priority PrioritizedEventQueue manages. Differential Revision: https://phabricator.services.mozilla.com/D25226
40046966515d6f5dff90093887c84e5d0ff144cc: Bug 1533240 - Replace DMD's custom TLS code with use of mozilla/ThreadLocal.h. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 22 Mar 2019 20:07:30 +0000 - rev 524858
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533240 - Replace DMD's custom TLS code with use of mozilla/ThreadLocal.h. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D22448
505c7972935b38db9a9e406d8cb15d1c0abe5b36: Bug 1536129 - Fix !MOZ_CALLSTACK_DISABLED blocking resource acquisition checking, r=erahm
Honza Bambas <honzab.moz@firemni.cz> - Tue, 19 Mar 2019 17:12:42 +0000 - rev 523905
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536129 - Fix !MOZ_CALLSTACK_DISABLED blocking resource acquisition checking, r=erahm Differential Revision: https://phabricator.services.mozilla.com/D23882
07ddc041094cd26e4970346d78583b887f83afea: Bug 1535301 - de-ICF RunnableMethodImpl::Run on Windows for crash disambiguation; r=erahm a=pascalc
Nathan Froyd <froydnj@mozilla.com> - Mon, 15 Apr 2019 17:01:49 +0200 - rev 523220
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1535301 - de-ICF RunnableMethodImpl::Run on Windows for crash disambiguation; r=erahm a=pascalc Differential Revision: https://phabricator.services.mozilla.com//D27546
25fbad7b3214444a3b07a52880faa61e399309a9: Bug 1534878 - xpcom: #include headers for global functions' declarations. r=erahm
Chris Peterson <cpeterson@mozilla.com> - Thu, 07 Mar 2019 23:32:54 -0800 - rev 522375
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: #include headers for global functions' declarations. r=erahm clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). The .cpp files defining these functions did not include the headers with the corresponding function prototypes used by other compilation units. Including a header file in its corresponding .cpp file can help catch mismatched declarations and definitions. xpcom/components/nsCategoryManager.cpp:637:6 [-Wmissing-prototypes] no previous prototype for function 'NS_CreateServicesFromCategory' xpcom/io/nsPipe3.cpp:1824:10 [-Wmissing-prototypes] no previous prototype for function 'nsPipeConstructor' xpcom/io/nsStringStream.cpp:475:10 [-Wmissing-prototypes] no previous prototype for function 'nsStringInputStreamConstructor' xpcom/threads/ThreadDelay.cpp:18:6 [-Wmissing-prototypes] no previous prototype for function 'DelayForChaosMode' Differential Revision: https://phabricator.services.mozilla.com/D23265
5ff84e853d700af894616574f581551a88a93dc7: Bug 1534878 - xpcom: Make some global functions static. r=erahm
Chris Peterson <cpeterson@mozilla.com> - Sun, 24 Feb 2019 17:35:59 -0800 - rev 522374
Push 10871 by cbrindusan@mozilla.com at Mon, 18 Mar 2019 15:49:32 +0000
Bug 1534878 - xpcom: Make some global functions static. r=erahm clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called). xpcom/base/Logging.cpp:85:13 [-Wmissing-prototypes] no previous prototype for function 'ToLogStr' xpcom/base/Logging.cpp:132:13 [-Wmissing-prototypes] no previous prototype for function 'ExpandPIDMarker' xpcom/base/LogModulePrefWatcher.cpp:37:6 [-Wmissing-prototypes] no previous prototype for function 'ResetExistingPrefs' xpcom/base/LogModulePrefWatcher.cpp:109:6 [-Wmissing-prototypes] no previous prototype for function 'LoadExistingPrefs' xpcom/base/nsCycleCollector.cpp:212:6 [-Wmissing-prototypes] no previous prototype for function 'SuspectUsingNurseryPurpleBuffer' xpcom/components/nsComponentManager.cpp:421:31 [-Wmissing-prototypes] no previous prototype for function 'begin' xpcom/components/nsComponentManager.cpp:427:31 [-Wmissing-prototypes] no previous prototype for function 'end' xpcom/ds/Dafsa.cpp:23:6 [-Wmissing-prototypes] no previous prototype for function 'GetNextOffset' xpcom/ds/Dafsa.cpp:55:6 [-Wmissing-prototypes] no previous prototype for function 'IsEOL' xpcom/ds/Dafsa.cpp:62:6 [-Wmissing-prototypes] no previous prototype for function 'IsMatch' xpcom/ds/Dafsa.cpp:70:6 [-Wmissing-prototypes] no previous prototype for function 'IsEndCharMatch' xpcom/ds/Dafsa.cpp:78:6 [-Wmissing-prototypes] no previous prototype for function 'GetReturnValue' xpcom/ds/Dafsa.cpp:91:5 [-Wmissing-prototypes] no previous prototype for function 'LookupString' xpcom/io/CocoaFileUtils.mm:195:13 [-Wmissing-prototypes] no previous prototype for function 'GetQuarantinePropKey' xpcom/io/CocoaFileUtils.mm:203:24 [-Wmissing-prototypes] no previous prototype for function 'CreateQuarantineDictionary' xpcom/rust/gtest/bench-collections/Bench.cpp:65:11 [-Wmissing-prototypes] no previous prototype for function 'MyRand' xpcom/rust/gtest/bench-collections/Bench.cpp:85:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_unordered_set' xpcom/rust/gtest/bench-collections/Bench.cpp:125:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_PLDHashTable' xpcom/rust/gtest/bench-collections/Bench.cpp:166:6 [-Wmissing-prototypes] no previous prototype for function 'Bench_Cpp_MozHashSet' xpcom/tests/gtest/TestAtoms.cpp:114:6 [-Wmissing-prototypes] no previous prototype for function 'isStaticAtom' xpcom/tests/gtest/TestCallTemplates.cpp:72:6 [-Wmissing-prototypes] no previous prototype for function 'JustTestingCompilation' xpcom/tests/gtest/TestCOMPtr.cpp:87:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIFoo' xpcom/tests/gtest/TestCOMPtr.cpp:98:6 [-Wmissing-prototypes] no previous prototype for function 'set_a_IFoo' xpcom/tests/gtest/TestCOMPtr.cpp:105:16 [-Wmissing-prototypes] no previous prototype for function 'return_a_IFoo' xpcom/tests/gtest/TestCOMPtr.cpp:164:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIBar' xpcom/tests/gtest/TestCOMPtr.cpp:175:6 [-Wmissing-prototypes] no previous prototype for function 'AnIFooPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:177:6 [-Wmissing-prototypes] no previous prototype for function 'AVoidPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:179:6 [-Wmissing-prototypes] no previous prototype for function 'AnISupportsPtrPtrContext' xpcom/tests/gtest/TestCOMPtr.cpp:263:6 [-Wmissing-prototypes] no previous prototype for function 'Comparison' xpcom/tests/gtest/TestCOMPtr.cpp:298:6 [-Wmissing-prototypes] no previous prototype for function 'DontAddRef' xpcom/tests/gtest/TestCRT.cpp:17:5 [-Wmissing-prototypes] no previous prototype for function 'sign' xpcom/tests/gtest/TestDeadlockDetector.cpp:62:6 [-Wmissing-prototypes] no previous prototype for function 'DisableCrashReporter' xpcom/tests/gtest/TestDeadlockDetector.cpp:74:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:95:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity2_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:159:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity4_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:182:5 [-Wmissing-prototypes] no previous prototype for function 'Sanity5_Child' xpcom/tests/gtest/TestDeadlockDetector.cpp:303:5 [-Wmissing-prototypes] no previous prototype for function 'ContentionNoDeadlock_Child' xpcom/tests/gtest/TestHashtables.cpp:88:6 [-Wmissing-prototypes] no previous prototype for function 'testTHashtable' xpcom/tests/gtest/TestHashtables.cpp:205:10 [-Wmissing-prototypes] no previous prototype for function 'CreateIFoo' xpcom/tests/gtest/TestMoveString.cpp:25:6 [-Wmissing-prototypes] no previous prototype for function 'SetAsOwned' xpcom/tests/gtest/TestMoveString.cpp:34:6 [-Wmissing-prototypes] no previous prototype for function 'ExpectTruncated' xpcom/tests/gtest/TestMoveString.cpp:40:6 [-Wmissing-prototypes] no previous prototype for function 'ExpectNew' xpcom/tests/gtest/TestMruCache.cpp:52:11 [-Wmissing-prototypes] no previous prototype for function 'MakeStringKey' xpcom/tests/gtest/TestMultiplexInputStream.cpp:106:34 [-Wmissing-prototypes] no previous prototype for function 'CreateStreamHelper' xpcom/tests/gtest/TestNonBlockingAsyncInputStream.cpp:62:10 [-Wmissing-prototypes] no previous prototype for function 'ReadSegmentsFunction' xpcom/tests/gtest/TestNsDeque.cpp:240:6 [-Wmissing-prototypes] no previous prototype for function 'CheckIfQueueEmpty' xpcom/tests/gtest/TestNsRefPtr.cpp:105:10 [-Wmissing-prototypes] no previous prototype for function 'CreateFoo' xpcom/tests/gtest/TestNsRefPtr.cpp:116:6 [-Wmissing-prototypes] no previous prototype for function 'set_a_Foo' xpcom/tests/gtest/TestNsRefPtr.cpp:123:13 [-Wmissing-prototypes] no previous prototype for function 'return_a_Foo' xpcom/tests/gtest/TestNsRefPtr.cpp:391:6 [-Wmissing-prototypes] no previous prototype for function 'AnFooPtrPtrContext' xpcom/tests/gtest/TestNsRefPtr.cpp:392:6 [-Wmissing-prototypes] no previous prototype for function 'AVoidPtrPtrContext' xpcom/tests/gtest/TestPLDHash.cpp:33:6 [-Wmissing-prototypes] no previous prototype for function 'TestCrashyOperation' xpcom/tests/gtest/TestPipes.cpp:98:10 [-Wmissing-prototypes] no previous prototype for function 'TestPipe' xpcom/tests/gtest/TestPipes.cpp:212:10 [-Wmissing-prototypes] no previous prototype for function 'TestShortWrites' xpcom/tests/gtest/TestPipes.cpp:354:6 [-Wmissing-prototypes] no previous prototype for function 'RunTests' xpcom/tests/gtest/TestPLDHash.cpp:90:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_InitialLengthTooBig' xpcom/tests/gtest/TestPLDHash.cpp:95:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_InitialEntryStoreTooBig' xpcom/tests/gtest/TestPLDHash.cpp:102:6 [-Wmissing-prototypes] no previous prototype for function 'InitCapacityOk_EntrySizeTooBig' xpcom/tests/gtest/TestSlicedInputStream.cpp:111:20 [-Wmissing-prototypes] no previous prototype for function 'CreateSeekableStreams' xpcom/tests/gtest/TestSlicedInputStream.cpp:125:20 [-Wmissing-prototypes] no previous prototype for function 'CreateNonSeekableStreams' xpcom/tests/gtest/TestStrings.cpp:471:6 [-Wmissing-prototypes] no previous prototype for function 'test_assign_helper' xpcom/tests/gtest/TestTArray.cpp:60:22 [-Wmissing-prototypes] no previous prototype for function 'DummyArray' xpcom/tests/gtest/TestTArray.cpp:72:22 [-Wmissing-prototypes] no previous prototype for function 'FakeHugeArray' xpcom/tests/gtest/TestThrottledEventQueue.cpp:96:6 [-Wmissing-prototypes] no previous prototype for function 'Enqueue' xpcom/threads/BlockingResourceBase.cpp:86:6 [-Wmissing-prototypes] no previous prototype for function 'PrintCycle' xpcom/threads/CPUUsageWatcher.cpp:41:10 [-Wmissing-prototypes] no previous prototype for function 'GetMicroseconds' xpcom/threads/CPUUsageWatcher.cpp:46:10 [-Wmissing-prototypes] no previous prototype for function 'GetMicroseconds' xpcom/threads/CPUUsageWatcher.cpp:51:40 [-Wmissing-prototypes] no previous prototype for function 'GetProcessCPUStats' xpcom/threads/CPUUsageWatcher.cpp:80:40 [-Wmissing-prototypes] no previous prototype for function 'GetGlobalCPUStats' xpcom/threads/nsTimerImpl.cpp:196:21 [-Wmissing-prototypes] no previous prototype for function 'GetTimerFiringsLog' Differential Revision: https://phabricator.services.mozilla.com/D23264
46f6705f9c0c2c8bbd45b60615a1081f40a8402b: Bug 1533240 - Replace DMD's custom TLS code with use of mozilla/ThreadLocal.h. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 14 Mar 2019 01:05:15 +0000 - rev 521823
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1533240 - Replace DMD's custom TLS code with use of mozilla/ThreadLocal.h. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D22448
7e2fced298cb76c55a36145780fb821ab1419cec: Bug 1531030: Use MOZ_DISABLE_POISON_IO_INTERPOSER to disable PoisonIOInterposer when it is unsafe to initialize; r=erahm
Aaron Klotz <aklotz@mozilla.com> - Fri, 01 Mar 2019 19:34:54 +0000 - rev 519867
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531030: Use MOZ_DISABLE_POISON_IO_INTERPOSER to disable PoisonIOInterposer when it is unsafe to initialize; r=erahm If we are running a background thread in the launcher process to log failures, then allowing the main thread to proceed with monkeypatching system calls is a Bad Idea. This patch gives us an environment variable that, when set, indicates that it is unsafe for PoisonIOInterposer to run. This scenario is an uncommon one, but one that we must account for nonetheless. Differential Revision: https://phabricator.services.mozilla.com/D21607
739c3b30b230fe1df1b3b94ae9b6a7df9467f31a: Bug 1529955 - remove corruption canary from LogModule; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 27 Feb 2019 14:28:10 -0500 - rev 519526
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1529955 - remove corruption canary from LogModule; r=erahm This canary isn't catching anything interesting, so we might as well save a little bit of overhead by removing it.
5aa193f471ea49165243f10c49f6ef99e26f723f: Bug 1521879 - Part 9: Re-enable the prefs service on the socket process. r=erahm
Byron Campen [:bwc] <docfaraday@gmail.com> - Mon, 25 Feb 2019 21:52:46 +0000 - rev 518889
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1521879 - Part 9: Re-enable the prefs service on the socket process. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D20724
965d985aeda572d16800fa301ca9fee410cb2fe7: Bug 1527803: Make sure debug service is instantiated before starting Watchdog thread. r=erahm
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Feb 2019 13:03:06 -0800 - rev 518601
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527803: Make sure debug service is instantiated before starting Watchdog thread. r=erahm The watchdog thread's stack is intentionally kept as small as possible, since the work that it does is trivial and should not require much stack space. One result of this is that the stack segment is generally too small to instantiate a new service (and we really don't want to be instantiating services on it anyway). The debug service is generally instantiated before the watchdog thread tries to touch it, but this isn't guaranteed (and, in particular, it often isn't for xpcshell runs on some noopt debug builds). Instantiating it before starting the watchdog thread solves this problem. Differential Revision: https://phabricator.services.mozilla.com/D20869
f597a73a6eaca926be5f95caa7a06d9cdcf50f0e: Bug 1521879 - Part 9: Re-enable the prefs service on the socket process. r=erahm
Byron Campen [:bwc] <docfaraday@gmail.com> - Fri, 22 Feb 2019 00:32:40 +0000 - rev 518454
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1521879 - Part 9: Re-enable the prefs service on the socket process. r=erahm Depends on D18231 Differential Revision: https://phabricator.services.mozilla.com/D20724
860bdc8fa78af1c8a20cbbcd41b29341369723c1: Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 16:03:41 -0800 - rev 518056
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
aa110fb783d526a0aa742b5fa5472d9bdfc1ca8c: Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Fri, 25 Jan 2019 15:20:36 -0800 - rev 518055
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
7a1ef487a9e74d66b112034051e49b77023860b8: Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 16:03:41 -0800 - rev 518038
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
accad7b4cbc71f35ffd4912044aa82c45872bb94: Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Fri, 25 Jan 2019 15:20:36 -0800 - rev 518037
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
e8ad5619116c31fc4d38e0e789ddb9b5d2a5bb25: Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 16:03:41 -0800 - rev 517335
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
1c6224158f64ae4291133faa56f538413092ff98: Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 24 Jan 2019 17:27:24 -0800 - rev 517333
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm
625f71135038f79c075f758e316fbb00097c9a18: Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Jan 2019 16:03:41 -0800 - rev 516934
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 12 - Convert everything else to static registration. r=erahm
614be688767fed0d16362dc5fbf0d34fc3c65579: Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Fri, 25 Jan 2019 15:20:36 -0800 - rev 516932
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 10 - Convert Windows widget module to static registration. r=erahm
9c24919ac5c2056255dec5725af1fa1548f29ca2: Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm
Kris Maglione <maglione.k@gmail.com> - Thu, 24 Jan 2019 17:27:24 -0800 - rev 516931
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1524687: Part 9 - Convert gtk widget module to static registration. r=erahm
e2e7beefa147f3ed2b6e69e98d7063e28ca4f376: Bug 1523948 - avoid bounds checks in nsTArray binary search methods; r=erahm
Nathan Froyd <froydnj@mozilla.com> - Wed, 30 Jan 2019 17:26:27 -0500 - rev 514063
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523948 - avoid bounds checks in nsTArray binary search methods; r=erahm We already take steps in `IndexOf` to avoid bounds checks--by using direct pointer accesses--and we should do the same thing for binary searches as well.
26b31ea8aeda9fb201e84deddac95d2dcc3a8649: Bug 1523949 - part 2 - switch BlockingResourceBase to MOZ_THREAD_LOCAL; r=erahm,emilio
Nathan Froyd <froydnj@mozilla.com> - Wed, 30 Jan 2019 17:26:27 -0500 - rev 514062
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523949 - part 2 - switch BlockingResourceBase to MOZ_THREAD_LOCAL; r=erahm,emilio This change results in somewhat nicer code and should be slightly more performant.