searching for reviewer(emk)
78ccad22a01cfb6cbf1b47f8f78e1b5d47b7bc6d: Bug 1549329 - Introduce localizable strings for unified Japanese encoding menu item and unified Cyrillic encoding menu item. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 06 May 2019 11:49:05 +0000 - rev 531663
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549329 - Introduce localizable strings for unified Japanese encoding menu item and unified Cyrillic encoding menu item. r=emk Add menu item strings for "Japanese" and "Cyrillic" without anything in parentheses afterwards. These strings are deliberately not taken into use yet but are landed in advance of the related functional changes in order to allow more options for possible uplifts in the future. Differential Revision: https://phabricator.services.mozilla.com/D30002
4a995c35eff47f4d6e5cc50329d0f450d1aa2320: Bug 1513799 - Remove windows-1252 as a Japanese detection outcome. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 05 Apr 2019 12:08:41 +0300 - rev 527164
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1513799 - Remove windows-1252 as a Japanese detection outcome. r=emk. If this removal turns out to be OK, we should be able to make the detector decide more quickly between the remaining options. Differential Revision: https://phabricator.services.mozilla.com/D26283
03d1b41cdfc057a5355d1e839151ff71f558d9a5: Bug 1434567 - Remove exception for Thunderbird from test_nonascii_path.js (bug 1433903, rev b76a1f5e05dc). r=emk
Jorg K <jorgk@jorgk.com> - Tue, 05 Mar 2019 15:23:00 +0200 - rev 520402
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1434567 - Remove exception for Thunderbird from test_nonascii_path.js (bug 1433903, rev b76a1f5e05dc). r=emk
f7ecf49bb4c0b11031475afa4f3b82c47828b2e7: Bug 1514664 - Implement TextEncoder.encodeInto(). r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Dec 2018 18:44:43 +0200 - rev 510514
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514664 - Implement TextEncoder.encodeInto(). r=emk.
7ffc28df24ee8e6cde5f5dacd63fe27aafcb6998: Bug 1111188 - Remove temporary workaround for ssltunnel in mochitest; r=emk
Geoff Brown <gbrown@mozilla.com> - Fri, 04 Jan 2019 09:21:49 -0700 - rev 509696
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1111188 - Remove temporary workaround for ssltunnel in mochitest; r=emk
7d6c4bedb93d7606e39810b8efa4df6788d7f264: Bug 1514728 - Fix bogus subspanning when sniffing a local file with more than 4 MB of ASCII. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Dec 2018 19:08:51 +0200 - rev 508221
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514728 - Fix bogus subspanning when sniffing a local file with more than 4 MB of ASCII. r=emk.
dba01afd51762abc4284a18547d70126afd46598: Bug 1513513 - Drop the file: URL UTF-8 sniffing limit from 50 MB to 4 MB. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 12 Dec 2018 14:21:23 +0200 - rev 507387
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1513513 - Drop the file: URL UTF-8 sniffing limit from 50 MB to 4 MB. r=emk.
a2df400cb88c79664cd8ba5fcf6b640373a85524: Bug 977540 - Avoid running Japanese, Russian and Ukrainian detectors on domains associated with different encoding legacies. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 10 Dec 2018 19:13:38 +0200 - rev 507338
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 977540 - Avoid running Japanese, Russian and Ukrainian detectors on domains associated with different encoding legacies. r=emk.
5a6f372f62c150b9263a1a59377a352284b35114: Bug 1071816 - Support loading unlabeled/BOMless UTF-8 text/html and text/plain files from file: URLs. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 04 Dec 2018 10:02:04 +0200 - rev 507025
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1071816 - Support loading unlabeled/BOMless UTF-8 text/html and text/plain files from file: URLs. r=emk.
46224f5a8a8c0e8b3783a35b155cbc6d8e3146ee: Bug 1482095 - Update encoding_rs to 0.8.6. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 09 Aug 2018 15:35:34 +0300 - rev 487475
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1482095 - Update encoding_rs to 0.8.6. r=emk. MozReview-Commit-ID: IqPrrQ7L1lU
91b8bd385fad6dc6be373ae6b3397a6537b6c51a: Bug 1471533 - Update encoding_rs to 0.8.4. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 27 Jun 2018 12:30:03 +0300 - rev 479049
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1471533 - Update encoding_rs to 0.8.4. r=emk. MozReview-Commit-ID: 40sRHT77Kzk
378b43fe165858dbf7d43800eaa88f0317dd7180: Bug 1470131 - Update encoding_rs to 0.8.3 for non-ASCII UTF-16 to UTF-8 encode performance. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 21 Jun 2018 15:34:16 +0300 - rev 478983
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1470131 - Update encoding_rs to 0.8.3 for non-ASCII UTF-16 to UTF-8 encode performance. r=emk. MozReview-Commit-ID: L6DhB63WzKp
00ed94326ec4816e44afa7e509a17535c439145e: Bug 1469512 - Update encoding_rs to 0.8.1. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 19 Jun 2018 12:46:46 +0300 - rev 477296
Push 9382 by cbrindusan@mozilla.com at Thu, 21 Jun 2018 15:23:31 +0000
Bug 1469512 - Update encoding_rs to 0.8.1. r=emk. MozReview-Commit-ID: 4iIHsLsXP1r
76a4a96da17c8ffa1bd57b84af81652a3b12870e: Bug 1469512 - Update encoding_rs to 0.8.1. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 19 Jun 2018 12:46:46 +0300 - rev 477286
Push 9380 by csabou@mozilla.com at Wed, 20 Jun 2018 21:48:50 +0000
Bug 1469512 - Update encoding_rs to 0.8.1. r=emk. MozReview-Commit-ID: 4iIHsLsXP1r
466d43707902ec86b9729c86cd7e844b3af7f075: Bug 1466807 - Update encoding_rs to 0.8.0. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Jun 2018 13:50:20 +0300 - rev 476160
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1466807 - Update encoding_rs to 0.8.0. r=emk MozReview-Commit-ID: 30vmruy1kiL
d608e536cf3026249b1ae6008282ae75e4e74dda: Bug 1445551: Follow-up: Fix typo. r=emk DONTBUILD
Kris Maglione <maglione.k@gmail.com> - Thu, 15 Mar 2018 21:57:28 -0700 - rev 461997
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1445551: Follow-up: Fix typo. r=emk DONTBUILD MozReview-Commit-ID: BDJD4SvrIX9
b76a1f5e05dc5978f8905631c3aa3720caa73fff: Bug 1433903 - Skip parts of test_nonascii_path.js for Thunderbird. r=emk
Jorg K <jorgk@jorgk.com> - Mon, 29 Jan 2018 14:48:00 +0200 - rev 453948
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1433903 - Skip parts of test_nonascii_path.js for Thunderbird. r=emk
993f338d5088a1109f85a26c93b1fb4002fc04ec: Bug 1428234 Part 1: Remove incorrect uses of persistentDescriptor in AddonManager r=emk,kmag
Andrew Swan <aswan@mozilla.com> - Mon, 22 Jan 2018 21:52:28 -0800 - rev 453386
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1428234 Part 1: Remove incorrect uses of persistentDescriptor in AddonManager r=emk,kmag MozReview-Commit-ID: 3pyF58rQcoa
d02263dd031ff2fe480dd76f42b26ca3c279b782: Bug 1431356 - Update encoding_rs to 0.7.2 and simd to 0.2.1. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 18 Jan 2018 12:26:21 +0200 - rev 452973
Push 8799 by mtabara@mozilla.com at Thu, 01 Mar 2018 16:46:23 +0000
Bug 1431356 - Update encoding_rs to 0.7.2 and simd to 0.2.1. r=emk. MozReview-Commit-ID: Lp3zyF2rLxN
eb62496a89f3990281f6fcb195d1565630f424ed: Bug 1428234 Part 1: Remove incorrect uses of persistentDescriptor in AddonManager r=emk,kmag a=lizzard
Andrew Swan <aswan@mozilla.com> - Mon, 22 Jan 2018 21:52:28 -0800 - rev 452123
Push 8620 by btara@mozilla.com at Wed, 31 Jan 2018 10:44:03 +0000
Bug 1428234 Part 1: Remove incorrect uses of persistentDescriptor in AddonManager r=emk,kmag a=lizzard MozReview-Commit-ID: 3pyF58rQcoa
9b2d90369dd303e4a7ea4dc2cb0fd89efc84cca7: Bug 1387340 - Ensure popup windows spawned on non-primary windows get a correct scale. r=emk,jfkthame
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 09 Jan 2018 11:19:36 -0500 - rev 450396
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1387340 - Ensure popup windows spawned on non-primary windows get a correct scale. r=emk,jfkthame MozReview-Commit-ID: CPKuH0W3KRL
354794d16661d1dbf5a08bd04d482d812fcf9817: Bug 960957 - Drop nsIFile support for non-UTF-8 file path encodings on non-Windows platforms. r=emk,m_kato
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 05 Dec 2017 13:33:52 +0200 - rev 447258
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 960957 - Drop nsIFile support for non-UTF-8 file path encodings on non-Windows platforms. r=emk,m_kato OS.File already only supports UTF-8 paths on non-Windows systems, so this change makes our different ways of accessing file paths consistent with each other. MozReview-Commit-ID: 8HiC5xC8tJN
436dbeb1d9b4e04220abcfab407de65567f1465d: Bug 943272 - Get rid of nsIPlatformCharset. r=emk
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 27 Nov 2017 12:45:14 +0900 - rev 446499
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 943272 - Get rid of nsIPlatformCharset. r=emk MozReview-Commit-ID: DVatkTEYA1q
8281f5415cfc6a94f237f418819c05505cf41821: Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs
Alphan Chen <alchen@mozilla.com> - Thu, 23 Nov 2017 15:03:41 +0800 - rev 445159
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 980904 - Disable the Character Encoding menu when document is decoded as UTF-8 without errors. r=hsivonen,emk,Gijs
f6a49a33c53dd7c515b39c1a81a6330a0030bdaa: Bug 1418438 - Avoid null deref in nsIDocShell's forcedCharset. r=emk
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 17 Nov 2017 21:28:50 +0100 - rev 444354
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1418438 - Avoid null deref in nsIDocShell's forcedCharset. r=emk MozReview-Commit-ID: KsTWmlAhDp8
9f8d4b0fd4dc6ee3ebee66875849dfff342b64d9: Bug 1418438 - Avoid null deref in nsIDocShell's forcedCharset. r=emk a=gchang
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 17 Nov 2017 21:28:50 +0100 - rev 442450
Push 8212 by archaeopteryx@coole-files.de at Thu, 23 Nov 2017 12:54:48 +0000
Bug 1418438 - Avoid null deref in nsIDocShell's forcedCharset. r=emk a=gchang MozReview-Commit-ID: KsTWmlAhDp8
f32554cf5530901c4ff65d25cc2b30c25b63500a: Bug 943284 - Use FallbackEncoding instead of nsIPlatformCharset r=emk
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 19 Oct 2017 19:28:00 +0900 - rev 437900
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 943284 - Use FallbackEncoding instead of nsIPlatformCharset r=emk MozReview-Commit-ID: 2pDp2RVV9zk
7abbc56b3bb78983e83d86a563799b9f4d538d53: Bug 1405615 - encoding_rs 0.7.1: Correctly encode U+DC00 followed by another low surrogate from UTF-16. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Wed, 04 Oct 2017 13:11:27 +0300 - rev 435754
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1405615 - encoding_rs 0.7.1: Correctly encode U+DC00 followed by another low surrogate from UTF-16. r=emk. `wrapping_sub()`-based high surrogate check was off by one due to error in copy and paste when defining the constant to compare against. That is, the subtraction that defines the constant was completely wrong but the result of the subtraction was only off by one, which is why the bug wasn't discovered immediately. This lead to the first low surrogate (U+DC00), and only the first low surrogate, getting accepted as a high surrogate. Discovered using cargo-fuzz. MozReview-Commit-ID: K3Ptws31WuV
08ff4ead034be474c2ef93d0be8e537b05394d18: Bug 1391213 - Make localeService.defaultLocale return the locale of the app package rather than a hard-coded en-US value. r=emk
Jonathan Kew <jkew@mozilla.com> - Sat, 23 Sep 2017 12:46:28 +0100 - rev 433357
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1391213 - Make localeService.defaultLocale return the locale of the app package rather than a hard-coded en-US value. r=emk
11bbf95a3db6099861f50c807b251caf392f3d14: Bug 1391213 - Make localeService.defaultLocale return the locale of the app package rather than a hard-coded en-US value. r=emk
Jonathan Kew <jkew@mozilla.com> - Sat, 23 Sep 2017 10:11:20 +0100 - rev 433354
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1391213 - Make localeService.defaultLocale return the locale of the app package rather than a hard-coded en-US value. r=emk
5804f73c5bd51631fb66be902a232cf07b2c555c: Bug 1385836 - Remove special cases obsoleted by "replacement" becoming a label of the replacement encoding. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 28 Aug 2017 12:57:17 +0300 - rev 426881
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1385836 - Remove special cases obsoleted by "replacement" becoming a label of the replacement encoding. r=emk MozReview-Commit-ID: 52uO6AVRHWX
72887ce9eaba5f8c0831fbc2b6026690dc8f060d: Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 28 Aug 2017 12:22:25 +0300 - rev 426729
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1372230 part 2 - Update encoding_rs to 0.7.0 and encoding_c to 0.8.0. r=emk MozReview-Commit-ID: DuK9BvVY50z
e4fe008d0265d4075f7b230706095cd463699d7b: Bug 1372230 part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 25 Aug 2017 12:37:28 +0300 - rev 426728
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1372230 part 1 - Move the code behing mozilla::Encoding::ForName() from encoding_rs to encoding_glue. r=emk MozReview-Commit-ID: 6cFRuyWoPhR
0c301b09c9f4b51a8816fab9877cf29c63683707: Bug 1391628 - Use fallback locale on nsICollation if locale is invalid. r=emk
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 24 Aug 2017 23:13:42 +0900 - rev 426074
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1391628 - Use fallback locale on nsICollation if locale is invalid. r=emk Original issue is that Microsoft Dynamics CRM uses invalid lang attribute in <xsl:sort>. <xsl:sort order="descending" select="@displayname[$sortColumnName='displayname'] | @name[$sortColumnName='name'] | exslt:node-set($FriendlyTypeNames)/types/type[@xmlName=current()/@datatype and $sortColumnName='datatype']" lang="$languageName"/> Our XSLT implementation detects "$languageName" as locale name, then use it to nsICollation. Until Gecko 54 for Windows, even if using invalid locale name for nsICollation, it uses platform locale as fallback. But from 55, we use same implementation as macOS's to use ICU. So this issue occurs. ICU implementation doesn't use fallback locale if it is invalid. We should use fallback locale if locale is invalid. Most code for fallback locale such as FallbackEncoding uses application locale, so use it. MozReview-Commit-ID: EKYkZG7Hnz0
08c538a185408e3f79fc7a0a08fba042ebebc689: Bug 1392181 - part2: HasRTLChars() should check if the character is at least equal or larger than the minimum RTL character, U+0590 r=emk
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 21 Aug 2017 18:03:21 +0900 - rev 425608
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1392181 - part2: HasRTLChars() should check if the character is at least equal or larger than the minimum RTL character, U+0590 r=emk HasRTLChars() appears in profile of attachment 8848015 after landing the patches for bug 1391538 because the landing made text in <input> or <textarea> always treated as non-single byte characters. Therefore, HasRTLChars() is now called by nsTextFragment::SetTo() a lot in editors. HasRTLChar() checks if it's in an RTL character for each character until it becomes true. However, if character is less than the minimum RTL character, U+0590, it works faster at least for Western languages. MozReview-Commit-ID: 4YecxQWUcmK
7f1d159041a2736260fcb1c8fdd026e5506244b9: Bug 1354004 - Make new Japanese default font settings ride the train r=emk,m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 21 Aug 2017 15:08:21 +0900 - rev 425598
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1354004 - Make new Japanese default font settings ride the train r=emk,m_kato Although, we still have an issue that is leading of text in <input type="text"> element causes overflow and scrollable (bug 1378065), we have no other compatibility issue reports and the issue is not so important nor easy to fix. So, now, let's make the new Japanese default font settings ride the train. MozReview-Commit-ID: J3SN9FtHoZg
d956bbef1b93800fbfa0f9229300433e1330f0d4: Bug 1387780 - Optimize string searching in MatchAutoCompleteFunction. r=adw, r=emk
Simon Lindholm <simon.lindholm10@gmail.com> - Sun, 20 Aug 2017 17:21:00 -0400 - rev 425558
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1387780 - Optimize string searching in MatchAutoCompleteFunction. r=adw, r=emk
afddc3468e43dfde06249486db292b9938dd4d12: Bug 1390391 - Removing version parameter of javascript in test_device_sensor_event.html and test_reduce_time_precision.html. r=emk
Tim Huang <tihuang@mozilla.com> - Mon, 21 Aug 2017 11:37:07 +0800 - rev 425429
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1390391 - Removing version parameter of javascript in test_device_sensor_event.html and test_reduce_time_precision.html. r=emk This patch removes the version parameter in test_device_sensor_event.html and test_reduce_time_precision.html. In addition, it fixes eslint errors of test_reduce_time_precision.html. MozReview-Commit-ID: 4CVRQG8xgu3
2d9e88c879dc84bd517a8ab3c114c88303ce3f4c: Bug 1390687 - remove versioned javascript and legacy generator code r=emk
Kate McKinley <kmckinley@mozilla.com> - Tue, 15 Aug 2017 16:08:16 -0700 - rev 424683
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1390687 - remove versioned javascript and legacy generator code r=emk MozReview-Commit-ID: 5f3NQdjQ68v
e26e9804c545afcb33549da0f7fd693cc3fc671f: Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Aug 2017 14:40:52 +1000 - rev 422652
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron. This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The places where nsXPIDLStrings are null-checked are replaced with |rv| checks. The patch also removes a couple of unused declarations from nsIStringBundle.idl. Note that nsStringBundle::GetStringFromNameHelper() was merged into GetStringFromName(), because they both would have had the same signature.
4aff598d54bd9e43d7939073ad911790da0a4e00: Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. r=emk.
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 04 Aug 2017 12:37:53 +0300 - rev 422581
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. r=emk. MozReview-Commit-ID: CHQQzPHxrus
e08568b12c294e87a2b0035cee4d9d174ccac0e8: Bug 1391628 - Use fallback locale on nsICollation if locale is invalid. r=emk, a=lizzard
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Thu, 24 Aug 2017 23:13:42 +0900 - rev 421456
Push 7686 by ryanvm@gmail.com at Mon, 28 Aug 2017 18:25:21 +0000
Bug 1391628 - Use fallback locale on nsICollation if locale is invalid. r=emk, a=lizzard Original issue is that Microsoft Dynamics CRM uses invalid lang attribute in <xsl:sort>. <xsl:sort order="descending" select="@displayname[$sortColumnName='displayname'] | @name[$sortColumnName='name'] | exslt:node-set($FriendlyTypeNames)/types/type[@xmlName=current()/@datatype and $sortColumnName='datatype']" lang="$languageName"/> Our XSLT implementation detects "$languageName" as locale name, then use it to nsICollation. Until Gecko 54 for Windows, even if using invalid locale name for nsICollation, it uses platform locale as fallback. But from 55, we use same implementation as macOS's to use ICU. So this issue occurs. ICU implementation doesn't use fallback locale if it is invalid. We should use fallback locale if locale is invalid. Most code for fallback locale such as FallbackEncoding uses application locale, so use it. MozReview-Commit-ID: EKYkZG7Hnz0
8cd4bd9ec8ae107a4c6a178c53aae56668804fbe: Bug 1381410 (part 5) - Reorder nsStringBundle. r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Jul 2017 18:37:32 +1000 - rev 418096
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381410 (part 5) - Reorder nsStringBundle. r=emk. This patch moves the destructor after the constructor, puts the NS_IMPL_ISUPPORTS line in a more sensible spot, and moves the Get*() functions before the Format*() functions in order to match the order in nsIStringBundle.idl.
3756382ef3b77ecfbd89d142c21e0ed202dfbf6b: Bug 1381410 (part 4) - Add missing monitor enter in nsStringBundle::Format*() functions. r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Jul 2017 18:36:16 +1000 - rev 418095
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381410 (part 4) - Add missing monitor enter in nsStringBundle::Format*() functions. r=emk. GetStringFromName() enters mReentrantMonitor(), and the other Get*() functions go through GetStringFromName(). But none of the Format*() functions enter the monitor. This patch moves some repeated code from GetStringFromName() and FormatStringFromName() into GetStringFromNameHelper(), including the monitor entry. All the Get*() and Format*() functions now use GetStringFromNameHelper(), which means they now all enter the monitor.
c528ff7eb1174dfc33d3d30b9da4b176fbacb5ff: Bug 1381410 (part 3) - Simplify nsExtensibleStringBundle::GetStringFromID(). r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Jul 2017 18:34:31 +1000 - rev 418094
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381410 (part 3) - Simplify nsExtensibleStringBundle::GetStringFromID(). r=emk. Similar to the previous patch, this patch changes GetStringFromID() to call GetStringFromName(), but this time in nsExtensibleStringBundle.
c200c517cd5b0b3005f914654751c35ef66a592f: Bug 1381410 (part 2) - Remove nsStringBundle::GetStringFromIDHelper(). r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Jul 2017 18:32:57 +1000 - rev 418093
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381410 (part 2) - Remove nsStringBundle::GetStringFromIDHelper(). r=emk. GetStringFromIDHelper() is very similar to GetSringFromNameHelper(). This patch removes the former, and changes GetStringFromID() to call GetStringFromName(), similar to how FormatStringFromID() calls FormatStringFromName().
048682b66e04eb7137241c9914f250f9a979a15a: Bug 1381410 (part 1) - Rename two protected methods in nsStringBundle. r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 17 Jul 2017 18:32:16 +1000 - rev 418092
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1381410 (part 1) - Rename two protected methods in nsStringBundle. r=emk. nsStringBundle has two public methods GetStringFrom{ID,Name}() and two very similar helper methods with the same name. It's easy to get confused between the two -- indeed, it may be the reason for the data race that this bug is about -- so this patch renames the helper functions by adding a "Helper" suffix.
129793760f2d718ed61ba17d9aacd57c7ec6785b: Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 12 Jul 2017 15:13:37 +1000 - rev 417515
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk. Most of the names passed to nsIStringBundle::{Get,Format}StringFromUTF8Name have one of the two following forms: - a 16-bit C string literal, which is then converted to an 8-bit string in order for the lookup to occur; - an 8-bit C string literal converted to a 16-bit string, which is then converted back to an 8-bit string in order for the lookup to occur. This patch introduces and uses alternative methods that can take an 8-bit C string literal, which requires changing some signatures in other methods and functions. It replaces all C++ uses of the old methods. The patch also changes the existing {Get,Format}StringFromName() methods so they take an AUTF8String argument for the name instead of a wstring, because that's nicer for JS code. Even though there is a method for C++ code and a different one for JS code, |binaryname| is used so that the existing method names can be used for the common case in both languages. The change reduces the number of NS_ConvertUTF8toUTF16 and NS_ConvertUTF16toUTF8 conversions while running Speedometer v2 from ~270,000 to ~160,000. (Most of these conversions involved the string "deprecatedReferrerDirective" in nsCSPParser.cpp.)
ac4eb026e67dfd763c63dc73661093c53667401c: Bug 943276 - Remove unused nsIPlatfromCharset. r=emk
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 10 Jul 2017 12:37:56 +0900 - rev 417095
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 943276 - Remove unused nsIPlatfromCharset. r=emk By bug 1261841, we don't use nsIPlatfromCharset on PluginTags. So we should remove unused header. MozReview-Commit-ID: 8Y4YwRzTJuk
f0a1809a7ee1722661f279ec21cc60b1270e4674: Bug 562590 - Make incomplete byte sequences near HTML EOF emit a REPLACEMENT CHARACTER. r=emk
Henri Sivonen <hsivonen@hsivonen.fi> - Thu, 22 Jun 2017 14:32:34 +0300 - rev 415968
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 562590 - Make incomplete byte sequences near HTML EOF emit a REPLACEMENT CHARACTER. r=emk MozReview-Commit-ID: 6NF4rMWxyVu