searching for reviewer(ehsan)
322dbb6b6736: Bug 1406818 - about:profile uses nsIToolkitProfile.removeInBackground, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:41 +0200 - rev 436876
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406818 - about:profile uses nsIToolkitProfile.removeInBackground, r=ehsan
eeb89284500e: Bug 1406818 - Introduce nsIToolkitProfile.removeInBackground to remove profile folder in a separate thread, r=ehsan
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 13 Oct 2017 08:47:41 +0200 - rev 436875
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406818 - Introduce nsIToolkitProfile.removeInBackground to remove profile folder in a separate thread, r=ehsan
db7617f6bfa0: Bug 1348976 - let OffscreenCanvas::TransferToImageBitmap report its error. r=mtseng, r=ehsan
Lee Salzman <lsalzman@mozilla.com> - Thu, 12 Oct 2017 14:14:54 -0400 - rev 436763
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1348976 - let OffscreenCanvas::TransferToImageBitmap report its error. r=mtseng, r=ehsan MozReview-Commit-ID: 8x5i4ukIWe5
17f625861aef: Bug 1404652: Part 1 - Add ChromeUtils.idleDispatch helper method. r=ehsan
Kris Maglione <maglione.k@gmail.com> - Sat, 23 Sep 2017 22:12:32 -0700 - rev 436578
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1404652: Part 1 - Add ChromeUtils.idleDispatch helper method. r=ehsan This is similar to Services.tm.idleDispatchToMainThread, but provides an IdleDeadline argument to its callbacks, the same way that Window.requestIdleCallback does. The IdleDeadline argument was necessary for my first attempt at this bug. It's not necessary for the current version, but I suspect it will be useful in other areas, and it also avoids some XPConnect overhead, so it's probably worth keeping. MozReview-Commit-ID: FtrbNkE7Vz5
3959033a3166: Bug 1365894 - Make SystemGroupImpl be a normal ref-counted object. r=ehsan
James Cheng <jacheng@mozilla.com> - Mon, 09 Oct 2017 13:40:12 -0400 - rev 435948
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1365894 - Make SystemGroupImpl be a normal ref-counted object. r=ehsan MozReview-Commit-ID: LUcoBhNx2M5
7e79bcb1f225: Bug 1406485 - provide PermissionHashKey with a move constructor; r=ehsan
Nathan Froyd <froydnj@mozilla.com> - Mon, 09 Oct 2017 10:39:38 -0400 - rev 435919
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406485 - provide PermissionHashKey with a move constructor; r=ehsan
22e994d66684: Bug 1406442 - Improve IPCShutdownState annotation for SendFinishShutdown state to know message status. r=ehsan
Andrew Osmond <aosmond@mozilla.com> - Fri, 06 Oct 2017 14:50:58 -0400 - rev 435706
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406442 - Improve IPCShutdownState annotation for SendFinishShutdown state to know message status. r=ehsan
cca8c45c7a34: Bug 1405602 - Add clang-apply-replacements to the clang-tidy build generated by toolchains. r=ehsan
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 04 Oct 2017 18:27:02 +0300 - rev 435396
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405602 - Add clang-apply-replacements to the clang-tidy build generated by toolchains. r=ehsan MozReview-Commit-ID: 1BT2ukzLoC3
5a295181603e: Bug 1402944: Part 9 - Optimize request/response header handling. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Sat, 23 Sep 2017 16:25:19 -0700 - rev 434291
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 9 - Optimize request/response header handling. r=mixedpuppy,ehsan We don't use the initial Map returned by ChannelWrapper as a map, so there's no need for the overhead involved in creating it. We also don't need the header map generated by HeaderChanger unless headers are actually being modified, which for many listeners they never are, so there's no need for the map creation and string lower-casing overhead prior to modification time. MozReview-Commit-ID: K2uK93Oo542
26711733ae3f: Bug 1402944: Part 7 - Move traceable channel registration to ChannelWrapper. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Sep 2017 18:15:39 -0700 - rev 434289
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 7 - Move traceable channel registration to ChannelWrapper. r=mixedpuppy,ehsan MozReview-Commit-ID: 6hGmh4VpJMQ
cd219dd09639: Bug 1402944: Part 5 - Move request filtering and permission matching into ChannelWrapper. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Wed, 27 Sep 2017 18:15:12 -0700 - rev 434287
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 5 - Move request filtering and permission matching into ChannelWrapper. r=mixedpuppy,ehsan This allows us to reuse the same URLInfo objects for each permission or extension that we match, and also avoids a lot of XPConnect overhead we wind up incurring when we access URI objects from the JS side. MozReview-Commit-ID: GqgVRjQ3wYQ
364f04c7fee0: Bug 1402944: Part 4 - Fold start/stop listener into ChannelWrapper. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Tue, 26 Sep 2017 13:39:30 -0700 - rev 434286
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 4 - Fold start/stop listener into ChannelWrapper. r=mixedpuppy,ehsan MozReview-Commit-ID: 52zZNjgaCEj
2c79c9374ca7: Bug 1402944: Part 3 - Move error checks into ChannelWrapper. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Tue, 26 Sep 2017 13:38:54 -0700 - rev 434285
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 3 - Move error checks into ChannelWrapper. r=mixedpuppy,ehsan MozReview-Commit-ID: 7uLonYWnLcX
cd804ea3508a: Bug 1402944: Part 2 - Move error string logic into ChannelWrapper. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Sep 2017 18:43:18 -0700 - rev 434284
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 2 - Move error string logic into ChannelWrapper. r=mixedpuppy,ehsan MozReview-Commit-ID: 4rOeoliLTV7
7d2d020de2ab: Bug 1402944: Part 1 - Document undocumented ChannelWrapper members. r=mixedpuppy,ehsan
Kris Maglione <maglione.k@gmail.com> - Fri, 22 Sep 2017 18:00:39 -0700 - rev 434283
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1402944: Part 1 - Document undocumented ChannelWrapper members. r=mixedpuppy,ehsan MozReview-Commit-ID: bdKJKfB6H7
c7f9baa225ff: Bug 1401706: Remove redundant UpdateValueDisplay call. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 14:48:02 +0200 - rev 433311
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1401706: Remove redundant UpdateValueDisplay call. r=Ehsan This was just moved from the old code, but we always call that function in CreateAnonymousContent, so no need to. MozReview-Commit-ID: 1zqmQM2KdpW Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
d327d1b7324d: Bug 1401706: Remove redundant boolean members from nsTextControlFrame. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:41 +0200 - rev 433310
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1401706: Remove redundant boolean members from nsTextControlFrame. r=Ehsan MozReview-Commit-ID: Ka81vlPMa88 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2ccf0d54c0f9: Bug 1401706: Remove unused macro. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:30 +0200 - rev 433309
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1401706: Remove unused macro. r=Ehsan MozReview-Commit-ID: EsvdnJkapgP Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
89e5fc708a1d: Bug 1401706: Move ownership of editor anon content to nsTextControlFrame. r=Ehsan
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 02:18:30 +0200 - rev 433308
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1401706: Move ownership of editor anon content to nsTextControlFrame. r=Ehsan MozReview-Commit-ID: 4QpbarX5dvf Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
55541ed45819: Bug 1356936 - Use __builtin_add/sub/mul_overflow() where available to optimize CheckedInt. r=waldo,ehsan
Mats Palmgren <mats@mozilla.com> - Thu, 21 Sep 2017 18:24:10 +0200 - rev 433099
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1356936 - Use __builtin_add/sub/mul_overflow() where available to optimize CheckedInt. r=waldo,ehsan MozReview-Commit-ID: ARw6zNelpSk
a4dfb0e4ad97: Bug 1365894 - Make SystemGroupImpl be a normal ref-counted object. r=ehsan, a=ritu
James Cheng <jacheng@mozilla.com> - Mon, 09 Oct 2017 13:40:12 -0400 - rev 432393
Push 7949 by ryanvm@gmail.com at 2017-10-11 20:50 +0000
Bug 1365894 - Make SystemGroupImpl be a normal ref-counted object. r=ehsan, a=ritu MozReview-Commit-ID: LUcoBhNx2M5
73daa36f9532: Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 14:48:02 +0200 - rev 431845
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove redundant UpdateValueDisplay call. r=Ehsan, a=sledru This was just moved from the old code, but we always call that function in CreateAnonymousContent, so no need to. MozReview-Commit-ID: 1zqmQM2KdpW Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
a896c16082f4: Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:41 +0200 - rev 431844
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove redundant boolean members from nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: Ka81vlPMa88 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
f1e83779aee9: Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 07:33:30 +0200 - rev 431843
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Remove unused macro. r=Ehsan, a=sledru MozReview-Commit-ID: EsvdnJkapgP Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
4d33cf91c8bd: Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 02:18:30 +0200 - rev 431842
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1401706 - Move ownership of editor anon content to nsTextControlFrame. r=Ehsan, a=sledru MozReview-Commit-ID: 4QpbarX5dvf Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
276e210419d6: Bug 1370613 - Update Book of Mozilla passage; r=ehsan
Seburo <seburo3@gmail.com> - Wed, 20 Sep 2017 23:04:38 -0400 - rev 431704
Push 7785 by ryanvm@gmail.com at 2017-09-21 13:39 +0000
Bug 1370613 - Update Book of Mozilla passage; r=ehsan
9cabdd061402: Bug 1401050 - Add vanishingly to the en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Tue, 19 Sep 2017 07:01:39 +0700 - rev 431184
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1401050 - Add vanishingly to the en-US dictionary. r=ehsan
64b9aee0d408: Bug 1400752 - Add intifada to the en-US dictionary. r=ehsan
Ekanan Ketunuti <ananuti@gmail.com> - Mon, 18 Sep 2017 08:41:19 +0700 - rev 431030
Push 7775 by ryanvm@gmail.com at 2017-09-19 01:22 +0000
Bug 1400752 - Add intifada to the en-US dictionary. r=ehsan
678bea28fe03: Revert bug 1385514 for causing bug 1399722. r=ehsan, a=lizzard on a CLOSED TREE FIREFOX_56b13_RELBRANCH FENNEC_56_0b13_BUILD1 FENNEC_56_0b13_RELEASE
Ryan VanderMeulen <ryanvm@gmail.com> - Mon, 18 Sep 2017 17:02:21 -0400 - rev 430874
Push 7773 by ryanvm@gmail.com at 2017-09-18 21:08 +0000
Revert bug 1385514 for causing bug 1399722. r=ehsan, a=lizzard on a CLOSED TREE
47901a63dd2b: Bug 1397214 - Prevent ContentChild::RecvSetXPCOMProcessAttributes from running after shutdown. r=ehsan
Andrew Osmond <aosmond@mozilla.com> - Fri, 15 Sep 2017 18:48:37 -0400 - rev 430784
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1397214 - Prevent ContentChild::RecvSetXPCOMProcessAttributes from running after shutdown. r=ehsan Since ContentChild itself may be created before the observer service is started, we cannot create an observer to simply listen for the xpcom-shutdown event. Thankfully we do not need to do anything special upon receiving the event -- we just need to know if it has been fired when we called RecvSetXPCOMProcessAttributes. As such, this patch creates a canary using ClearOnShutdown. If the canary is cleared, then we know xpcom-shutdown has been issued, and we should abort the initialization process. fixup
b3820db371ae: Bug 1398196, flush layout before hittesting when handling mousedown/up, r=ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 14 Sep 2017 23:26:24 +0300 - rev 430515
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1398196, flush layout before hittesting when handling mousedown/up, r=ehsan
90dd92f271f5: Bug 1398605, keep nsContentList objects alive for awhile when generating state keys so that new objects don't need to be created all the time, r=ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 14 Sep 2017 21:56:58 +0300 - rev 430491
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1398605, keep nsContentList objects alive for awhile when generating state keys so that new objects don't need to be created all the time, r=ehsan
e40d55e7a132: Bug 1340578 - Allow execCommand('paste') to be called from webextensions without a target, r=ehsan
Michael Layzell <michael@thelayzells.com> - Thu, 07 Sep 2017 13:41:13 -0400 - rev 429597
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1340578 - Allow execCommand('paste') to be called from webextensions without a target, r=ehsan
f41d54eddd16: Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down r=Ehsan
Thomas Nguyen <tnguyen@mozilla.com> - Thu, 07 Sep 2017 16:16:43 +0800 - rev 429156
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down r=Ehsan MozReview-Commit-ID: HRv5DpiPwmB
903bd3c9bfdd: Bug 1397412 - Implement Mochitest for EditorBase::FindBetterInsertionPoint() in plaintext editor. r=ehsan
Jorg K <jorgk@jorgk.com> - Thu, 07 Sep 2017 12:36:00 -0400 - rev 429117
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1397412 - Implement Mochitest for EditorBase::FindBetterInsertionPoint() in plaintext editor. r=ehsan
38323ec9e5da: Bug 1396468 - Spoof navigator.oscpu as 'Windows NT 6.1; Win64; x64' when resisting fingerprinting is enabled. r=ehsan
Ethan <ettseng@mozilla.com> - Mon, 04 Sep 2017 11:30:37 +0800 - rev 429040
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1396468 - Spoof navigator.oscpu as 'Windows NT 6.1; Win64; x64' when resisting fingerprinting is enabled. r=ehsan
7282bbabab15: Bug 1397536: Avoid newURI overhead for MatchPattern. r=ehsan,mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Wed, 06 Sep 2017 21:56:45 -0700 - rev 428907
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1397536: Avoid newURI overhead for MatchPattern. r=ehsan,mixedpuppy Ehsan, can you please review the (trivial) WebIDL changes, and Shane the WebRequest logic? The change to allow strings in MatchPattern arguments removes a huge amount of XPConnect overhead that accumulates when creating nsIURI objects for WebRequest processing. The change to re-use existing URI objects removes a huge amount of URI creation overhead. MozReview-Commit-ID: 3DJjAKJK1Sa
223a7c5a7c47: Bug 1396856: Part 3 - Add a WebIDL wrapper class for necko channels. r=ehsan,mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Wed, 06 Sep 2017 14:38:23 -0700 - rev 428905
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1396856: Part 3 - Add a WebIDL wrapper class for necko channels. r=ehsan,mixedpuppy Ehsan, can you please review the DOM bindings, and Shane the request logic? The bulk of the overhead WebRequest API is in its access to nsIChannel and friends through XPConnect. Since it's not really feasible to convert channels to use WebIDL bindings directly, this generic channel wrapper class serves the same purpose. MozReview-Commit-ID: 4mNP8HiKWK
3b496e60f978: Bug 1396856: Part 2 - Add top outer window ID to LoadInfo. r=ehsan
Kris Maglione <maglione.k@gmail.com> - Wed, 06 Sep 2017 14:25:23 -0700 - rev 428904
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1396856: Part 2 - Add top outer window ID to LoadInfo. r=ehsan The WebRequest API needs to know if a given window ID is at the top level, for various reasons. It currently figures this out by mapping a channel's load context to a <browser> element, which tracks its current top outer window ID. But this is inefficient, and not friendly to C++ callers. Adding the top window ID to the load info simplifies things considerably. MozReview-Commit-ID: Fy0gxTqQZMZ
3067ce95b439: Bug 1396323 - Don't initialize HTMLInputElement editor for eVoidEvent. r=ehsan
Ryan Hunt <rhunt@eqrion.net> - Tue, 05 Sep 2017 15:09:53 -0500 - rev 428852
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1396323 - Don't initialize HTMLInputElement editor for eVoidEvent. r=ehsan Keyboard APZ dispatches an eVoidEvent to gather all event targets that a key event would normally go to. This can sometimes trigger an HTMLInputElement to initialize its editor, which can cause unnecessary DOM modifications. MozReview-Commit-ID: 6EEttouVB81
b137fb389c95: Bug 1395945 - Remove child array getter. r=ehsan
Catalin Badea <catalin.badea392@gmail.com> - Mon, 13 Mar 2017 23:37:35 +0200 - rev 427889
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395945 - Remove child array getter. r=ehsan
c1522ab270db: Bug 1395701 part 2. Use a linked list, not a hashtable, for registering selection ranges on a node, so the registration will be faster. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Sep 2017 11:13:47 -0400 - rev 427873
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395701 part 2. Use a linked list, not a hashtable, for registering selection ranges on a node, so the registration will be faster. r=ehsan Inserting/removing things into a doubly-linked list is much faster than doing the same with a hashtable. Selection ranges register themselves on their common ancestor, but all we do with that in non-debug code is iterate all the ranges registered. A doubly-linked list works fine for that. This adds three words to every range for the LinkedListItem members, but that should be OK.
dd99274926b8: Bug 1395701 part 2. Use a linked list, not a hashtable, for registering selection ranges on a node, so the registration will be faster. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Sep 2017 11:13:47 -0400 - rev 427753
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395701 part 2. Use a linked list, not a hashtable, for registering selection ranges on a node, so the registration will be faster. r=ehsan Inserting/removing things into a doubly-linked list is much faster than doing the same with a hashtable. Selection ranges register themselves on their common ancestor, but all we do with that in non-debug code is iterate all the ranges registered. A doubly-linked list works fine for that. This adds three words to every range for the LinkedListItem members, but that should be OK.
11e80634f034: Bug 1395701 part 1. Maintain the "registered common ancestor" in a member on selection ranges. r=ehsan
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Sep 2017 11:13:25 -0400 - rev 427752
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395701 part 1. Maintain the "registered common ancestor" in a member on selection ranges. r=ehsan This costs an extra word per range, but ranges aren't that small anyway. The benefit is that we don't have to recompute it dynamically when we need it, which lets us simplify how selection ranges get registered with their common ancestors.
d75df8f79607: Bug 1366511: Part 3 - Add mozilla::ToResult() to convert other result types to equivalent Result. r=nbp,ehsan
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Aug 2017 21:28:31 -0700 - rev 427633
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1366511: Part 3 - Add mozilla::ToResult() to convert other result types to equivalent Result. r=nbp,ehsan Also adds a mozilla/ResultExtensions.h header to define the appropriate conversion functions for nsresult and PRResult. This is in a separate header since those types are not available in Spidermonkey, and this is the pattern other *Extensions.h headers follow. Also removes equivalent NS_TRY macros and WrapNSResult inlines that served the same purpose in existing code, and are no longer necessary. MozReview-Commit-ID: A85PCAeyWhx
0ae47966e150: Bug 1366511: Part 2 - Allow autoconverting Err(nsresult) to nsresult. r=ehsan,nbp
Kris Maglione <maglione.k@gmail.com> - Tue, 29 Aug 2017 21:28:22 -0700 - rev 427632
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1366511: Part 2 - Allow autoconverting Err(nsresult) to nsresult. r=ehsan,nbp This allows MOZ_TRY and MOZ_TRY_VAR to be transparently used in XPCOM methods when compatible Result types are used. Also removes a compatibility macro in SimpleChannel.cpp, and an identical specialization in AddonManagerStartup, which are no longer necessary after this change. MozReview-Commit-ID: 94iNrPDJEnN
886291827404: Bug 1366511: Part 1 - Allow packing Result<T, nsresult> values into a single word. r=ehsan,nbp
Kris Maglione <maglione.k@gmail.com> - Thu, 31 Aug 2017 16:01:43 -0700 - rev 427631
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1366511: Part 1 - Allow packing Result<T, nsresult> values into a single word. r=ehsan,nbp When used as an error value, nsresult should never be NS_OK, which means that we should be able to safely pack simple nsresult Result values into a single word. MozReview-Commit-ID: GJvnyTPjynk
9931b3249b03: Bug 1394719 - Optimize HasRTLChars usage and reduce malloc/free, r=ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 31 Aug 2017 14:54:46 +0300 - rev 427460
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394719 - Optimize HasRTLChars usage and reduce malloc/free, r=ehsan
243e4dae5e85: Bug 1393232, use nsStringBuffer for nsTextFragment::m2b r=ehsan
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 31 Aug 2017 14:48:07 +0300 - rev 427459
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1393232, use nsStringBuffer for nsTextFragment::m2b r=ehsan
ea2850222e1b: Bug 1395157 - Make EditorBase::EndPlaceholderTransaction() not retrieve nor hold nsIPresShell and nsCaret r=Ehsan
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 30 Aug 2017 23:24:26 +0900 - rev 427377
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395157 - Make EditorBase::EndPlaceholderTransaction() not retrieve nor hold nsIPresShell and nsCaret r=Ehsan EditorBase::EndPlaceholderTransaction() has hidden caret. However, it doesn't do it anymore. However, bug 805697 didn't remove unnecessary code that retrieves and hold nsIPresShell and nsCaret. This patch removes them. MozReview-Commit-ID: Eh9pbf8p2bZ