searching for reviewer(dzbarsky)
aa9b74a854d5ae7e9046d7f2ab03d4be6058b5a1: servo: Merge #10652 - Prevent use of reserved names in BindAttribLocation (from dzbarsky:reserved); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Tue, 19 Apr 2016 09:16:54 +0500 - rev 385208
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #10652 - Prevent use of reserved names in BindAttribLocation (from dzbarsky:reserved); r=dzbarsky (Depend on the WebGL tests landing) Source-Repo: https://github.com/servo/servo Source-Revision: 82b952c03f94c0b8433a9fccbe9b66aa7e704924
7a046d28846d18ca9d8a0f3752928aced3856b69: servo: Merge #8506 - Properly propagate changes when range or trees are mutated (from nox:finish-ranges); r=dzbarsky
Anthony Ramine <n.oxyde@gmail.com> - Sat, 26 Dec 2015 03:38:45 +0500 - rev 384463
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8506 - Properly propagate changes when range or trees are mutated (from nox:finish-ranges); r=dzbarsky Does the same thing as #6817, but storing Range instances directly in their start and end containers. Cc @dzbarsky Source-Repo: https://github.com/servo/servo Source-Revision: 89ab368258eb827b0dcc8d6e6deecd3ed3c1de71
68918e658167ea075d34e94e8ddce7f1473720f7: servo: Merge #8723 - Add origin-clean flag tracking for canvas (from dzbarsky:origin_clean); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Fri, 18 Dec 2015 03:57:29 +0500 - rev 384432
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8723 - Add origin-clean flag tracking for canvas (from dzbarsky:origin_clean); r=dzbarsky The resulting failures are because we aren't doing origin-comparison correctly (I bet the image ends up with an empty hostname or something). We could probably hack around that if we care, but it should just go away when we get the origin checking right. r? @jdm Source-Repo: https://github.com/servo/servo Source-Revision: 82e73e7a5f5bc87aec4797c7a60b8ac160de134c
77f99349f84d818ef26824b1d8767574b8ec49bf: servo: Merge #8997 - Implement WebGL scissor method (from dzbarsky:scissor); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Wed, 16 Dec 2015 10:36:02 +0500 - rev 384420
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8997 - Implement WebGL scissor method (from dzbarsky:scissor); r=dzbarsky Source-Repo: https://github.com/servo/servo Source-Revision: 1695c0ad27e4c9c062e26a5db154521e400ecbd9
846e889bdf69ac8415dc0254fe49945908c26140: servo: Merge #8761 - Implement some more WebGL functions (from dzbarsky:gl_functions); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Mon, 14 Dec 2015 07:55:50 +0500 - rev 384408
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8761 - Implement some more WebGL functions (from dzbarsky:gl_functions); r=dzbarsky r? @ecoal95 Source-Repo: https://github.com/servo/servo Source-Revision: 89d9aad1e1e3cd93b12088f09aad1193e7298ba4
4ccab135bd7ed2cf3204f1ea46fe457e05133d18: servo: Merge #8728 - Reset canvas state when changing bitmap dimensions (from dzbarsky:reset_bitmpa); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Fri, 04 Dec 2015 11:28:25 +0500 - rev 384354
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8728 - Reset canvas state when changing bitmap dimensions (from dzbarsky:reset_bitmpa); r=dzbarsky Ran http://mxr.mozilla.org/servo/source/tests/wpt/web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.2dstate.html?force=1#88 to confirm that this code is being executed, but the test still fails because the font isn't implemented and the expando doesn't get reset. Source-Repo: https://github.com/servo/servo Source-Revision: 2bb34feb3ec8ba7aa3161ebc52f2ae9595192238
6bfc14f503bb0ade4f32b08c907000fef16f2c84: servo: Merge #8729 - Update Canvas webIDL to spec (from dzbarsky:canvas_webidl); r=dzbarsky
David Zbarsky <dzbarsky@gmail.com> - Sun, 29 Nov 2015 09:02:58 +0500 - rev 384323
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #8729 - Update Canvas webIDL to spec (from dzbarsky:canvas_webidl); r=dzbarsky Source-Repo: https://github.com/servo/servo Source-Revision: 2d164f2bebb63aa35269a4c3355beea3bbdcff01
e3b0e545c21c591c998db347c0d1b55cb136d072: servo: Merge #7653 - Add transitions for CSS `calc()` (from notriddle:calc-transition); r=dzbarsky
Michael Howell <michael@notriddle.com> - Sun, 20 Sep 2015 00:22:13 -0600 - rev 383821
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #7653 - Add transitions for CSS `calc()` (from notriddle:calc-transition); r=dzbarsky Closes #7284 Source-Repo: https://github.com/servo/servo Source-Revision: 5667283d1f50ad4f6bf9291dcbc5b6f659c4acc8
d3469b9ed9accdfdc9c02186cbeca08e1f261f9d: servo: Merge #7289 - Combine transform-origin, perspective-origin code (from tgkokk:perspective-transform-origin-combine); r=dzbarsky
Theodore Kokkoris <t.kokkoris@gmail.com> - Thu, 20 Aug 2015 07:10:14 -0600 - rev 383628
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #7289 - Combine transform-origin, perspective-origin code (from tgkokk:perspective-transform-origin-combine); r=dzbarsky First PR, please tell me if anything is wrong/could use improvement. Fixes #7194. Source-Repo: https://github.com/servo/servo Source-Revision: c98c1651a329d152b436d017e15546f9b922fe93
2b5163c71d75a24f0450118cd3e1b796be963152: servo: Merge #7046 - Implement a base_url getter and use it for style attributes (from Ms2ger:base-url); r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Sat, 08 Aug 2015 06:53:32 -0600 - rev 383530
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #7046 - Implement a base_url getter and use it for style attributes (from Ms2ger:base-url); r=dzbarsky Source-Repo: https://github.com/servo/servo Source-Revision: 530d4547c945fbf120d546d6e9a31b8f3bacc78f
eec1d4b36dddddada31b423d1ef5e0ae7bf6134d: servo: Merge #7075 - Improve code around Window::load_url (from Ms2ger:load_url); r=dzbarsky
Ms2ger <Ms2ger@gmail.com> - Sat, 08 Aug 2015 06:09:13 -0600 - rev 383529
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #7075 - Improve code around Window::load_url (from Ms2ger:load_url); r=dzbarsky Source-Repo: https://github.com/servo/servo Source-Revision: a0af7a1581ffaa6b40149affdd5519caa2be015f
eed2a76f1a596aa4847996136dfd7517484a8f0b: Bug 1301628 - Corrects misc-argument-comment. r=dzbarsky
Ninad Bhat[:ninad101] <bhat.ninadmb@gmail.com> - Fri, 09 Sep 2016 10:45:00 +0200 - rev 354797
Push 6570 by raliiev@mozilla.com at Mon, 14 Nov 2016 12:26:13 +0000
Bug 1301628 - Corrects misc-argument-comment. r=dzbarsky
8ef4e254bd15c3be61820d7a3b82c23b766469be: Bug 1063992 - Set the animation player hold time to zero when it is initially paused; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Tue, 09 Sep 2014 08:55:34 +0900 - rev 227441
Push 4187 by bhearsum@mozilla.com at Fri, 28 Nov 2014 15:29:12 +0000
Bug 1063992 - Set the animation player hold time to zero when it is initially paused; r=dzbarsky This patch fixes a regression from bug 1033114, m-c changeset 9db3e43c19c1. That changeset changed the meaning of mHoldTime (despite the commit message which erroneously refers to mStartTime) to make it an offset from the start time rather than a timestamp. However, it failed to update the case when we have an initially-paused player. In that case the offset should be zero but the existing code set it to the same value as the start time (which is, itself, an offset from the beginning of the timeline) and the above changeset failed to update that.
6b686aa0a606be572e341853032a0b1e401909dc: Bug 1063992 - Set the animation player hold time to zero when it is initially paused. r=dzbarsky, a=lmandel
Brian Birtles <birtles@gmail.com> - Tue, 09 Sep 2014 08:55:34 +0900 - rev 224874
Push 3979 by raliiev@mozilla.com at Mon, 13 Oct 2014 16:35:44 +0000
Bug 1063992 - Set the animation player hold time to zero when it is initially paused. r=dzbarsky, a=lmandel This patch fixes a regression from bug 1033114, m-c changeset 9db3e43c19c1. That changeset changed the meaning of mHoldTime (despite the commit message which erroneously refers to mStartTime) to make it an offset from the start time rather than a timestamp. However, it failed to update the case when we have an initially-paused player. In that case the offset should be zero but the existing code set it to the same value as the start time (which is, itself, an offset from the beginning of the timeline) and the above changeset failed to update that.
41ba073e102dcd6d498bad39aafee0b10ac61c5c: Bug 1029969 - Make compositor animation (OMTA) tests ignore floating-point differences; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Fri, 27 Jun 2014 11:28:51 +0900 - rev 211916
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1029969 - Make compositor animation (OMTA) tests ignore floating-point differences; r=dzbarsky
e4d2010d17727f1588900a3722b1784f23aa43f9: Bug 1026323 - Add a test for a transition with a delay running on the compositor; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Mon, 23 Jun 2014 14:10:19 +0900 - rev 210787
Push 3857 by raliiev@mozilla.com at Tue, 02 Sep 2014 16:39:23 +0000
Bug 1026323 - Add a test for a transition with a delay running on the compositor; r=dzbarsky This patch adds a test for transitions with a delay that run on the compositor. Currently animations (including transitions) are not sent to the compositor until they reach the end of their delay phase introducing the possibility that the behavior might differ for animations with or without delays. This patch adds a simple test for a transition with a delay. It also fixes an existing bug in the opacity test. Also, it moves the step where the "transition" property is removed to the end of the test sequence rather than the end of the opacity test (which previously happened to occur at the end of the test sequence).
252653fe3a934b7106cdf929f2ac9ee6d821e818: Bug 1000944. Allow unions and dictionaries that contain non-SpiderMonkey WebIDL interface types to be copy-constructed. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 26 Apr 2014 21:49:59 -0400 - rev 198958
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 1000944. Allow unions and dictionaries that contain non-SpiderMonkey WebIDL interface types to be copy-constructed. r=dzbarsky
57553ed7b1400fc3413ccc2171f864b38213f5e4: Bug 958540 part 3. Switch the assignment operator on WebIDL unions to use SetAs*, not RawSetAs*, so you can use it to change the type of a union. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 01 Apr 2014 01:58:27 -0400 - rev 194971
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 958540 part 3. Switch the assignment operator on WebIDL unions to use SetAs*, not RawSetAs*, so you can use it to change the type of a union. r=dzbarsky
67819547c820df6a5989ddddc9f88b6059d61be0: Bug 958540 part 2. Rename the existing SetAs* methods on unions to RawSetAs* and add new SetAs* methods that ensure the right type for the union. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 01 Apr 2014 01:58:27 -0400 - rev 194970
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 958540 part 2. Rename the existing SetAs* methods on unions to RawSetAs* and add new SetAs* methods that ensure the right type for the union. r=dzbarsky
5d14c9ea9a49ba5ce84b2a26695593228ea17dd2: Bug 958540 part 1. Factor out the uninit behavior of union structs into a separate method. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 01 Apr 2014 01:58:27 -0400 - rev 194969
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 958540 part 1. Factor out the uninit behavior of union structs into a separate method. r=dzbarsky
430db7206b0ce49c6ff9a72439a6b30f2fbd756a: Bug 975261 part 5 - Fix OMTA animations with backwards fill; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Sat, 22 Mar 2014 05:59:58 +0800 - rev 193371
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 975261 part 5 - Fix OMTA animations with backwards fill; r=dzbarsky When we have a backwards fill and we sample at *exactly* the start of the animation on the next refresh driver tick, when we get to RestyleManager::ComputeStyleChangeFor (or more specifically ElementRestyler::CaptureChange) we notice that the style hasn't changed (since the first frame of the animation produces the same value as the backwards fill) and end up with an empty change list. As a result we never schedule a view manager flush and rebuild the layer. Hence, the animation never gets sent to the compositor thread. On the next tick we're already throttling the main thread. This patch fixes this by applying the same approach as is used for transitions, that is, explicitly marking which animations are running on the compositor thread so we know if we need to trigger a layer transaction or not. This should not only be more robust than the previous code but also facilitate aligning animations and transitions code (bug 880596).
33536a62f534a37098736066d2304cb9394de493: Bug 975261 part 4 - Add test for starting OMTA animations with backwards fill; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Sat, 22 Mar 2014 05:59:58 +0800 - rev 193370
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 975261 part 4 - Add test for starting OMTA animations with backwards fill; r=dzbarsky This test reproduces a bug where we don't send an animation to the compositor thread. The important step is the sample precisely at the start of the animation interval.
7a4ca3c2bb7f0f8a8835ba5ce2c4a1119796fd85: Bug 975261 part 3 - Add test for transforms; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Sat, 22 Mar 2014 05:59:57 +0800 - rev 193369
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 975261 part 3 - Add test for transforms; r=dzbarsky Adds a test for transform animations with a delay where there is already a transform specified on the element. This test used to fail but bug 828173 fixed it. It is included here as a regression test. (Prior to bug 828173 we were able to fix this by triggering ForceLayerRerendering inside nsAnimationManager::nsFlushAnimations whenever we detected *different* style rules but canThrottleTick=true) The issue stemmed from the fact that when an element has a transform property, LayerIsPrerenderedDataKey would get set on the layer because in nsDisplayTransform::ShouldPrerenderTransformedContent we would only check for the *presence* of an animation, not whether it is running. Then in RestyleManager::DoApplyRenderingChangeToTree we wouldn't do an invalidating paint because TryUpdateTransformOnly() returns true since it looks at LayerIsPrerenderedDataKey. Bug 828173 fixes this, at least in part, by checking if an animation is running. This bug may resurface if we put animations with a delay on the compositor thread hence it is worth including here.
7a8a2e851e1a520e0d459c2ba94b35c56bde0ce4: Bug 975261 part 2 - Trigger animations with a delay; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Sat, 22 Mar 2014 05:59:57 +0800 - rev 193368
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 975261 part 2 - Trigger animations with a delay; r=dzbarsky Animations with a delay are not put on the compositor thread until the end of the delay phase. However, there is currently nothing that explicitly triggers this transaction. It may occur due to flushes that arise from UI events but it is not guaranteed. This patch detects the end of a delay phase and turns off throttling for that sample. It re-uses the mLastNotification member which is not ideal but a subsequent patch in this queue removes this and replaces it with the approach used for transitions.
a380efaa88d564ad6b36631ab7835c8ae956532e: Bug 975261 part 1 - Add test for OMTA animations that start with a delay; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Sat, 22 Mar 2014 05:59:57 +0800 - rev 193367
Push 3624 by asasaki@mozilla.com at Mon, 09 Jun 2014 21:49:01 +0000
Bug 975261 part 1 - Add test for OMTA animations that start with a delay; r=dzbarsky
96f0f09c23c030781060d3d63dbe05d040c720c5: Bug 980207 - When the refresh driver is under test control, make compositor thread only update when a composite is scheduled; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Mon, 10 Mar 2014 13:47:12 +0900 - rev 189898
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 980207 - When the refresh driver is under test control, make compositor thread only update when a composite is scheduled; r=dzbarsky In order to make test behavior better match real-world sampling behavior, this patch updates the test code in CompositorParent so that it only updates the layer when a composite is scheduled. This enables creating mochitests that reproduce bugs observed in regular usage.
ef2e0154fc2e978899018b0f86ad373a600b430b: Bug 979658 part 4 - Rename PLayerTransaction.GetTransform to GetAnimationTransform; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Mon, 10 Mar 2014 13:47:12 +0900 - rev 189893
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 979658 part 4 - Rename PLayerTransaction.GetTransform to GetAnimationTransform; r=dzbarsky PLayerTransaction.GetTransform doesn't actually return the same kind of value when the transform on the layer is not set by animation. This is because it uses information stored with the animation to undo various transforms. We shouldn't pretend to return something useful/similar when we don't have that information available. This patch renames GetTransform to GetAnimationTransform and makes it return a union that has type void_t if the layer is not transformed by animation.
d6f58fa82ea761194e62f39161f9337086b53da2: Bug 979658 part 3 - Make LayerTransactionParent::RecvGetTransform convert to CSS pixels; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Mon, 10 Mar 2014 13:47:12 +0900 - rev 189892
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 979658 part 3 - Make LayerTransactionParent::RecvGetTransform convert to CSS pixels; r=dzbarsky LayerTransactionParent::RecvGetTransform takes care to reverse all the transformations applied by AsyncCompositionManager::SampleValue to the CSS values calculated so that it can return CSS values for testing. However, it fails to revert the conversion from CSS pixels to device pixels applied to the translation components of the transform by nsStyleTransformMatrix::ProcessTranslatePart as called by nsDisplayTransform::GetResultingTransformMatrix. This patch converts the resulting transform's translation components from device pixels back to CSS pixels. It also adds documentation for the other operations in LayerTransactionParent::RecvGetTransform.
3622141b21655dd80b36f931cfac0b3d8fe129ac: Bug 979658 part 1 - Add check that caller is chrome to GetOMTAOrComputedStyle; r=dzbarsky
Brian Birtles <birtles@gmail.com> - Mon, 10 Mar 2014 13:47:11 +0900 - rev 189890
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 979658 part 1 - Add check that caller is chrome to GetOMTAOrComputedStyle; r=dzbarsky Every other exposed method in nsDOMWindowUtils except getViewPortInfo and getViewId performs this check. This patch makes getOMTAOrComputedStyle check the caller is chrome as well.
63f04e426fdae72b049d345f2434dadd478ee2e9: Bug 979557: CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 189132
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 979557: CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled. r=dzbarsky This shouldn't behave differently depending on whether or not logging is enabled; that difference was introduced in bug 785648.
447343d88656aed33db076b1dd637c5e412d14e1: Bug 979555: Add default value for layers.offmainthreadcomposition.log-animations preference to all.js. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Tue, 04 Mar 2014 20:13:22 -0800 - rev 189131
Push 3503 by raliiev@mozilla.com at Mon, 28 Apr 2014 18:51:11 +0000
Bug 979555: Add default value for layers.offmainthreadcomposition.log-animations preference to all.js. r=dzbarsky It's good practice to have default values for all preferences in all.js. Otherwise some preference APIs throw exceptions and/or leave values uninitialized. It also makes the preference show up in about:config. Bug 875204 accidentally removed this line from all.js even though the pref was not removed. (The pref was initially added in bug 780342.)
321532cf56f834aac27a7e2add12ed4126c78173: Bug 952062. Fix union codegen to properly destroy the union members if conversion to them fails. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Dec 2013 15:33:57 -0500 - rev 177683
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 952062. Fix union codegen to properly destroy the union members if conversion to them fails. r=dzbarsky
f84ac36ce832c98ed5337ef2556b9e8854c195ba: Bug 952062. Fix union codegen to properly destroy the union members if conversion to them fails. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Dec 2013 15:33:57 -0500 - rev 177649
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 952062. Fix union codegen to properly destroy the union members if conversion to them fails. r=dzbarsky
9494599831b140b7865d27e16b0bee88874e2960: Bug 952375. Include headers for external interfaces in UnionConversions.h. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 20 Dec 2013 14:28:18 -0500 - rev 177639
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 952375. Include headers for external interfaces in UnionConversions.h. r=dzbarsky
50f78462069420e1ecdf264780de7c4abe7975e4: Bug 952073. Fix codegen to actually work correctly for the case of a nullable union dictionary member with no default value. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 19 Dec 2013 23:30:38 -0500 - rev 177406
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 952073. Fix codegen to actually work correctly for the case of a nullable union dictionary member with no default value. r=dzbarsky This fix just makes us take the normal Optional codepath for this case, since there is no weirdness here.
745ca55d396a39459575a4a26c132e076738f3c5: Bug 949501. Make nullable unions that are isMember stop claiming to have a holder. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 18 Dec 2013 11:20:43 -0500 - rev 177058
Push 3343 by ffxbld at Mon, 17 Mar 2014 21:55:32 +0000
Bug 949501. Make nullable unions that are isMember stop claiming to have a holder. r=dzbarsky
36fd56ac71ddf21d05eef1041f81026183cf601a: Bug 929512. Fix null default values for non-nullable unions containing a nullable type. r=dzbarsky, r=smaug pending
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 28 Oct 2013 00:33:15 -0400 - rev 166227
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 929512. Fix null default values for non-nullable unions containing a nullable type. r=dzbarsky, r=smaug pending
41496e6e589d8501b045a521ed759341c6862f1a: Bug 929673 Patch 3: Rename GetDeltaToMoz{Transform,Perspective}Origin to remove the Moz to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Thu, 24 Oct 2013 14:46:00 +0200 - rev 165774
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 929673 Patch 3: Rename GetDeltaToMoz{Transform,Perspective}Origin to remove the Moz to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
58cbe73b3920026e3c627e64185711474b663412: Bug 929673 Patch 2: Rename mToMozOrigin to mToTransformOrigin to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Thu, 24 Oct 2013 14:46:00 +0200 - rev 165773
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 929673 Patch 2: Rename mToMozOrigin to mToTransformOrigin to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
66e24e999199bdd06d9a67db873d6183933ea16b: Bug 929673 Patch 1: Rename mozOrigin to transformOrigin to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
L. David Baron <dbaron@dbaron.org> - Thu, 24 Oct 2013 14:46:00 +0200 - rev 165772
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 929673 Patch 1: Rename mozOrigin to transformOrigin to avoid use of deprecated CSS prefixes in variable names. r=dzbarsky
0779196218d24e14692b0e0c49e0ba731c623619: Bug 913920 - Part b: Implement HTMLFormControlsCollection and use it for HTMLFormElement.elements; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Thu, 03 Oct 2013 09:11:27 +0200 - rev 163486
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 913920 - Part b: Implement HTMLFormControlsCollection and use it for HTMLFormElement.elements; r=dzbarsky
d1ff09ace32b301f6a604ad52038e412debc6c0b: Bug 913920 - Part a: Rename nsFormControlList and move it to its own files; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Thu, 03 Oct 2013 09:11:26 +0200 - rev 163485
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 913920 - Part a: Rename nsFormControlList and move it to its own files; r=dzbarsky
eb41ace1d0b568b26dea6df503bf8d5cc0c1819f: Bug 771765 - Support template content process, part 9: allocating a toplevel protocol should return itself. r=dzbarsky
Cervantes Yu <cyu@mozilla.com> - Thu, 26 Sep 2013 12:19:09 +0800 - rev 163146
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 771765 - Support template content process, part 9: allocating a toplevel protocol should return itself. r=dzbarsky Reverse the effect in bug 879475 part 14 since we need to keep track of open protocols in the Nuwa process.
99a789a320c7218f9ffe3f4d2d74b0c1acafafca: Bug 915971. Rename FooReturnValue unions to OwningFoo, because we use them for more than just return values. r=dzbarsky
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 17 Sep 2013 11:16:02 -0400 - rev 161301
Push 3066 by akeybl@mozilla.com at Mon, 09 Dec 2013 19:58:46 +0000
Bug 915971. Rename FooReturnValue unions to OwningFoo, because we use them for more than just return values. r=dzbarsky
54247b7b87e6de61adaab87989d86b5bd8abfb42: Bug 915419. Add support for "object" types in owning unions (so union return values and unions in dictionaries and sequences. r=dzbarsky, smaug
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 12 Sep 2013 22:34:16 -0400 - rev 159865
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 915419. Add support for "object" types in owning unions (so union return values and unions in dictionaries and sequences. r=dzbarsky, smaug Adds RootedUnion and NullableRootedUnion structs that are used on the stack for union return values when the union needs rooting. It also adds a TraceUnion method on union return values, which is called by (Nullable)RootedUnion or by dictionary tracing. TraceUnion traces typed array and object members of unions (the only things unions can contain so far that might need tracing). Union return values are changed to store raw JSObject* or typed array structs instead of Rooted versions of both; the tracing is now handled via TraceUnion. The wrapping code for dictionary arguments to constructors is fixed to actually work. This required adding GetAs* methods to union return values that return references to the internal data. The SetToObject method is adjusted to actually work for union return value structs and not assume it's being generated for a union-conversion struct, and we now generate SetToObject methods as needed for union return values.
4fd64fc80694b08e2d7b309339a21a8f92aa1092: Bug 914048 - Reduce includes in CanvasRenderingContext2D.cpp; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Tue, 10 Sep 2013 09:03:38 +0200 - rev 159160
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 914048 - Reduce includes in CanvasRenderingContext2D.cpp; r=dzbarsky
e6a8b40cb9bd530608de816fa005ab464c7bbf55: Bug 913923 - Part c: Stop including BindingUtils.h in UnionTypes.h; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Tue, 10 Sep 2013 09:03:38 +0200 - rev 159159
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 913923 - Part c: Stop including BindingUtils.h in UnionTypes.h; r=dzbarsky
c762fde381a843b839b3be15a8f9c5821642e8e2: Bug 913923 - Part b: Move OwningNonNull into its own header; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Tue, 10 Sep 2013 09:03:37 +0200 - rev 159158
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 913923 - Part b: Move OwningNonNull into its own header; r=dzbarsky
e73983f4a10802a5f2e637422d40b69d743ba43b: Bug 913923 - Part a: Move UnionMember into its own header; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Tue, 10 Sep 2013 09:03:37 +0200 - rev 159157
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 913923 - Part a: Move UnionMember into its own header; r=dzbarsky
90a17a78cf796bdad22513e2f842b44c3a93ed39: Bug 774124 - Part c: Include nsContentUtils.h in HTMLSplitOnSpacesTokenizer.h; r=dzbarsky
Ms2ger <ms2ger@gmail.com> - Fri, 06 Sep 2013 08:40:33 +0200 - rev 158658
Push 2961 by lsblakk@mozilla.com at Mon, 28 Oct 2013 21:59:28 +0000
Bug 774124 - Part c: Include nsContentUtils.h in HTMLSplitOnSpacesTokenizer.h; r=dzbarsky