searching for reviewer(dholbert)
edc925e0821a1066f0b354a486cfffe34b40e4f2: Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 23 Jun 2019 10:08:16 +0000 - rev 534001
Push 11489 by malexandru@mozilla.com at Mon, 24 Jun 2019 13:35:34 +0000
Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert a=ritu This restores our previous and per-spec behavior. Comparing only ratios was not correct in the case one of the dimensions was zero and thus not scaled. Differential Revision: https://phabricator.services.mozilla.com/D35571
cb4e5f7609686f3255646b9a3904e4737e7bcebf: Bug 1550729 - Enable column-span pref for contain-size-multicol-{002,003}.html individually. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 May 2019 19:48:53 +0000 - rev 532286
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1550729 - Enable column-span pref for contain-size-multicol-{002,003}.html individually. r=dholbert CSS containment is enabled on early beta or earlier. Using "default-preferences" to flip column-span pref overrides CSS containment's pref at the first line in the reftest.list, which make the two test fail on late beta. Differential Revision: https://phabricator.services.mozilla.com/D30674
41a34b64ca1798f76f0781978d0d1c9d764d9a1a: Bug 1550629 - Fix comments mentioning GetAvailableSpace. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 10 May 2019 21:06:48 +0000 - rev 532283
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1550629 - Fix comments mentioning GetAvailableSpace. r=dholbert GetAvailableSpace was renamed to GetFloatAvailableSpace in bug 25888. DONTBUILD because this is a comment-only change. Differential Revision: https://phabricator.services.mozilla.com/D30581
2c165cc039113c935d13a630528173f2e34cdfe2: Bug 1545309 - Run ResizeObserver eventloop test after loading successfully. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 06 May 2019 22:53:09 +0000 - rev 531993
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545309 - Run ResizeObserver eventloop test after loading successfully. r=dholbert In test0(), we use the callback of `requestAnimationFrame` to know in which eventloop (i.e. `Tick()`) we are. However, we may not trigger the callback of `requestAnimationFrame` if we are not visible. This is an optimization in Bug 1145439. Detail: We use `Document::ShouldThrottleFrameRequests()` to check if we should throttle the frame requests in the current `Tick()`. This function returns true if we didn't get painted during the last paint, so we are not visible, so throttle the frame requests. Note that because we have to paint this document at least once to unthrottle it, we will drop one `requestAnimationFrame` frame when a document that previously wasn't visible scrolls into view. Therefore, we should make sure we got the first paint before running test0(). Using onload is not perfect, but we don't have other better choose for now. Differential Revision: https://phabricator.services.mozilla.com/D29772
57b5cbfc0d7a0857e896d0a41c366fc7a4d77da0: Bug 1545309 - Make test function independent from others in eventloop.html. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 06 May 2019 22:52:54 +0000 - rev 531992
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545309 - Make test function independent from others in eventloop.html. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29904
6cc70607d8afbe3a56fc6a3f3bc6544da4c8dba5: Bug 1494100 Part 3 - Implement "contain:size" for ColumnSetWrapperFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:58:39 +0000 - rev 531991
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494100 Part 3 - Implement "contain:size" for ColumnSetWrapperFrame. r=dholbert Add multicol-width-004.html and multicol-width-005.html to test "width: min-content" and "width: max-content" with column-span:all children. There's no size containment in these tests. Note it may be worth to reuse nsBlockFrame's mCachedMinISize and mCachedPrefISize to cache intrinsic size for ColumnSetWrapperFrame, but this can be done separately. Differential Revision: https://phabricator.services.mozilla.com/D29616
93fd1b5a5a025a54f109c8ab76d17ee1e6f860d1: Bug 1494100 Part 2 - Check column-span pref before checking the size containment in nsColumnSetFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:49:40 +0000 - rev 531990
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494100 Part 2 - Check column-span pref before checking the size containment in nsColumnSetFrame. r=dholbert If column-span is enabled, nsColumnSetFrame becomes an inner frame under ColumnSetWrapperFrame, and that outer frame is then where we should be handling size containment. This patch doesn't change the logic but make the logic easier to simplify once we start eliminating column-span pref. Differential Revision: https://phabricator.services.mozilla.com/D29615
e77c2a2c5d8238d23de731605789269873ecd97e: Bug 1494100 Part 1 - Create ColumnUtils, and extract utility functions in nsColumnSetFrame into it. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 08 May 2019 22:49:31 +0000 - rev 531989
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1494100 Part 1 - Create ColumnUtils, and extract utility functions in nsColumnSetFrame into it. r=dholbert The functions move to ColumnUtils will be used by ColumnSetWrapperFrame to implement GetPrefISize() and GetMinISize(). Also, I verify locally that non-unified build is still working by s/UNIFIED_SOURCES/SOURCES/ in layout/generic/moz.build. Differential Revision: https://phabricator.services.mozilla.com/D29614
c2250a23fd66e3c812cb023c2d12f6f5e8d5a2f2: Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 09 May 2019 02:32:30 +0000 - rev 531981
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 866102 - Implement -webkit-line-clamp. r=mats,emilio,dholbert Differential Revision: https://phabricator.services.mozilla.com/D20115
a0c91ab4d3477cdb041c00dee13354cafafb83fd: Bug 1545239 - Unobserve the target if using a different observed box. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:43 +0000 - rev 531971
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545239 - Unobserve the target if using a different observed box. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D30129
b34ea6abce97b002de66d2d0376b84e347f3151a: Bug 1545239 - Add tests for border-box and different writing modes. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 21:27:55 +0000 - rev 531970
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545239 - Add tests for border-box and different writing modes. r=dholbert 1. Add new tests with an extra argument of "content-box"/"border-box" in observe(), and test contectBoxSize and borderBoxSize. 2. Add a new test for changing the writing mode. Changing writing mode makes the element change the orientation, but the logical box size is still the same, so we shouldn't fire the event. Differential Revision: https://phabricator.services.mozilla.com/D28739
01338a1e26b7d838ddd591fca9a7495e338c6c96: Bug 1545239 - Make each test cases independent in resize-observer/observe.html. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:39 +0000 - rev 531969
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545239 - Make each test cases independent in resize-observer/observe.html. r=dholbert I think it's better to make sure each test is independent from others, so we create elements inside each test function. (Only change observe.html because I touch only this file in this bug.) Differential Revision: https://phabricator.services.mozilla.com/D29889
dc3570e93c4150f913a20baa6ee42c109ab85d60: Bug 1545239 - Update ResizeObserver and ResizeObserverEntry. r=smaug,dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:54:36 +0000 - rev 531968
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545239 - Update ResizeObserver and ResizeObserverEntry. r=smaug,dholbert In this patch, we support 1. content-box (default) 2. border-box And let ResizeObserverEntry expose these box sizes. Besides, we store the mLastReportedSize as the logical size. Differential Revision: https://phabricator.services.mozilla.com/D28737
2e3522f77b0f686663145bdce20ffceef3909896: Bug 1545239 - Move GetNodeDepth into ResizeObserver.cpp r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Wed, 08 May 2019 20:52:51 +0000 - rev 531967
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545239 - Move GetNodeDepth into ResizeObserver.cpp r=dholbert GetNodeDepth() is a special version for ResizeObserver to get the depth of node (across Shadow DOM). Based on the comment in D27615, it's better to move it into ResizeObserver.cpp. Differential Revision: https://phabricator.services.mozilla.com/D28736
e99ec6c4418fd17cba92ea8a8b7d5160f4cf3285: Bug 1548341 - Convert NS_STYLE_BORDER to an enum class in nsStyleConsts.h. r=dholbert
Jeremy Ir <jir.opensource@gmail.com> - Sun, 05 May 2019 23:39:27 +0000 - rev 531454
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548341 - Convert NS_STYLE_BORDER to an enum class in nsStyleConsts.h. r=dholbert Converting the NS_STYLE_BORDER definitions in to enumerated classes as per bug 1277133. The original constants broke the convention used by the rest of the definitions as the CSS property being described is `border-collapse`, so corrections were made with the migration to the enumerated class. Differential Revision: https://phabricator.services.mozilla.com/D29951
451701e88d92935b77385235832865dabe8c2942: Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 May 2019 23:28:21 +0000 - rev 531253
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29244
d077a01ccd637475a32bfe4ae92ea25f2cc84e14: Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 02 May 2019 21:41:33 +0000 - rev 531237
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548126 - Mark known existing reftests failures with column-span enabled. r=dholbert Due to the syntax limitation in failures.list, I cannot mark multicol-rule-004.xht as fails with column-span enabled and success with column-span disabled simultaneously. Luckily, we had another copy of it in testing/web-platform/tests/css/css-multicol/multicol-rule-004.xht, We can use it to test with column-span disabled for now. Differential Revision: https://phabricator.services.mozilla.com/D29419
704947d53e4c48d1b6f208eb551bb35207fb10ca: Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 May 2019 15:19:10 +0000 - rev 531182
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert Bug 1547939 added a bunch of extra tests for three properties (background, mask, and -webkit-mask). This made them time out more frequently in the Android emulator. Request a longer timeout to address this. Alternative is maybe just removing the tests or such, I don't think they're of particularly great value. Differential Revision: https://phabricator.services.mozilla.com/D29650
7187fa20af85cdba63c2c7ea2925df74faadf549: Bug 1548057 - Properly unregister the resize observer helpers when the shell goes away. r=dholbert,boris
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Apr 2019 19:44:55 +0000 - rev 530935
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1548057 - Properly unregister the resize observer helpers when the shell goes away. r=dholbert,boris Need to write a test for this. Also, as a matter of preventive measure, null out mOwner when it dies. That may matter in the case where the controller dies while the observer is getting notified. In that case, somebody still keeps a reference to the controller. Right now is fine because nothing will touch it again (the destructor doesn't), but that's not great, and it's better to just clear the pointer. Differential Revision: https://phabricator.services.mozilla.com/D29395
a5c14dc63aa6449d97c1a73918b7b6fbf33735c0: Bug 1547922 part 2 - Add some grid layout tests. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 30 Apr 2019 10:21:30 +0200 - rev 530909
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547922 part 2 - Add some grid layout tests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29325
3de2f935e2d2658dda91deba799149ee29ce3837: Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 30 Apr 2019 10:03:29 +0200 - rev 530908
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547922 part 1 - Fix broken flex layout tests. r=dholbert The flex item tests in this file are completely broken... First, there's a typo in the flex container style when concatenating: "... teal" + containerSizeDecl since you end up with "... tealinline-size:..." etc. Second, none of the tests actaully test anything at all, which you can see by removing the "+ subtest.candStyle" part on the reflow root candidate -- the test still pass! The reason for that is that its child (inner) has a solid purple border so when changing its size it will render differently and make the test pass regardless of any change that we intended to test. After fixing those two bugs it turns out that two of the subtests don't produce a rendering change at all, so those tests are bogus and needs to be rewritten. (I'm commenting them out for now.) Differential Revision: https://phabricator.services.mozilla.com/D29324
a484a2625d18c038723fad2c4032f7859fc51bc3: Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 30 Apr 2019 19:48:27 +0000 - rev 530830
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert This won't reintroduce any of the regressions that were triggered by our previous attempts to turn off -moz prefixed gradients, and lets us massively simplify the gradient code, if it sticks. Differential Revision: https://phabricator.services.mozilla.com/D29346
1181d18ea08c28012dea5243f24ca38df9d88dab: Bug 1542646 Part 13 - Make function declaration and definition parameter names match r=dholbert
longsonr <longsonr@gmail.com> - Sat, 27 Apr 2019 08:57:50 +0100 - rev 530473
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 13 - Make function declaration and definition parameter names match r=dholbert
b86894409b1b4481691a82b33f3107254511591c: Bug 1272409 - Part 5: Update test meta. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Fri, 26 Apr 2019 20:29:20 +0000 - rev 530411
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 5: Update test meta. r=dholbert In idlharness.window.js, ResizeObservation is not an public interface in the current spec, so the test should be updated. In eventloop.html, unfortunately, there are two issues: 1. The test framework will be timeout if there is any `assert_equals()` failed. We should rewrite it. 2. Actually, we only have one failure in this test file: `assert_equals(helper.rafCount, 1, "new loop");` in test0. We fire this event in the next Tick(), but we call the callback of `requestAnimationFrame()` after several Tick()s, so `helper.rafCount` is still 0 in this case. This may be a bug of the test because using `requestAnimationFrame()` cannot reflect the next event loop, or our scheduling of ResizeObserver is not correct. Note: this assert_equal() was added by Google, not by Fariskhi. Differential Revision: https://phabricator.services.mozilla.com/D27619
87c7a189cbe0d917f6579f796e43a8e5c29e7681: Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:18 +0000 - rev 530410
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug Depends on D27617 Differential Revision: https://phabricator.services.mozilla.com/D27618
0b7728e6fcda89443d3d580fe108f74a193c3b1c: Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:16 +0000 - rev 530409
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug Use ResizeObserverController to schedule the observers and manage them. Document will hold this controller in the later patch. Depends on D27616 Differential Revision: https://phabricator.services.mozilla.com/D27617
b634a26d0c2ed0efe2e7739b24aafcbf5820c058: Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Fri, 26 Apr 2019 20:29:14 +0000 - rev 530408
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug This implements the first version of spec, so the webidl file doesn't match the current spec and we will fix them in the follow-up bugs. i.e. 1. The default observer box is content-box. 2. `ResizeObserverBoxOptions`, `ResizeObserverOptions`, and `ResizeObserverSize` are not included in `ResizeObserver.webidl`. 3. `ResizeObserverEntry` doesn't have `borderBoxSize` and `contentBoxSize` attributes. Depends on D27615 Differential Revision: https://phabricator.services.mozilla.com/D27616
7b8695f2ca823fd8fa6e89d7327c7a2652a7ac51: Bug 1272409 - Fix fuzzy unified build failed after adding new files into dom/base. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Fri, 26 Apr 2019 20:29:30 +0000 - rev 530406
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Fix fuzzy unified build failed after adding new files into dom/base. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28934
12a4b6b72645f2327adb531d42ce31f39a5ea3f9: Bug 1542646 Part 12 - avoid implicit double to float conversions by using std:: variants of mathematical functions r=dholbert
longsonr <longsonr@gmail.com> - Thu, 25 Apr 2019 22:46:33 +0100 - rev 530249
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 12 - avoid implicit double to float conversions by using std:: variants of mathematical functions r=dholbert
62da064b1b8f2274df270f8f2de784e9b4d0302d: Bug 1546697 - Use a consistent style for enum classes in layout. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Apr 2019 23:03:04 +0000 - rev 530219
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546697 - Use a consistent style for enum classes in layout. r=dholbert Per the discussion in: https://groups.google.com/d/msg/mozilla.dev.platform/P79pwa9z5m8/iPYPAWPHCAAJ They should be CamelCase, and that's what most of them already do. This converts the rest, which are a few. For the ones that already used `e` or `k` prefixes, I've mostly done: for file in $(rg Type::e layout | cut -d : -f 1 | sort | uniq); do sed -i 's#Type::e#Type::#g' $file; done For the ones that used uppercase, I've removed the prefix if it was already in the type name, and turn them into CamelCase. Depends on D28680 Differential Revision: https://phabricator.services.mozilla.com/D28681
15cb052119fe2c70a42b0eeba69a4583f53a5718: Bug 1546697 - Make BaselineSharingGroup an enum class. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Apr 2019 22:42:13 +0000 - rev 530218
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546697 - Make BaselineSharingGroup an enum class. r=dholbert It looked a bit weird when mixed up with the other enum classes I'm about to rename. Depends on D28679 Differential Revision: https://phabricator.services.mozilla.com/D28680
41ee8dc862a966e71ab23a2b3ab59c72b2fc21c9: Bug 1547138 - IntrinsicSize shouldn't use nsStyleCoord. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Apr 2019 23:48:14 +0000 - rev 530216
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547138 - IntrinsicSize shouldn't use nsStyleCoord. r=dholbert We have a better type to represent "a coord or nothing", and that's Maybe. This code is shorter, and I think reads generally better / is less easy to misuse. I wrote this on top of bug 1547126 so there shouldn't be conflicts. Differential Revision: https://phabricator.services.mozilla.com/D28921
2ad8260489d690f7615abb7fe27890bdb430de9a: Bug 1272409 - Part 5: Update test meta. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Thu, 25 Apr 2019 18:30:18 +0000 - rev 530201
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 5: Update test meta. r=dholbert In idlharness.window.js, ResizeObservation is not an public interface in the current spec, so the test should be updated. In eventloop.html, unfortunately, there are two issues: 1. The test framework will be timeout if there is any `assert_equals()` failed. We should rewrite it. 2. Actually, we only have one failure in this test file: `assert_equals(helper.rafCount, 1, "new loop");` in test0. We fire this event in the next Tick(), but we call the callback of `requestAnimationFrame()` after several Tick()s, so `helper.rafCount` is still 0 in this case. This may be a bug of the test because using `requestAnimationFrame()` cannot reflect the next event loop, or our scheduling of ResizeObserver is not correct. Note: this assert_equal() was added by Google, not by Fariskhi. Differential Revision: https://phabricator.services.mozilla.com/D27619
224dad4cbdc349744e785e727bae745e5a798a49: Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Thu, 25 Apr 2019 18:30:16 +0000 - rev 530200
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 4: Integrate ResizeObserver with Document and reflow. r=dholbert,smaug Depends on D27617 Differential Revision: https://phabricator.services.mozilla.com/D27618
72775dbf35c88a564ec0839a9113e83fe17b4e5f: Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Thu, 25 Apr 2019 18:30:36 +0000 - rev 530199
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 3: Add ResizeObserverController. r=dholbert,smaug Use ResizeObserverController to schedule the observers and manage them. Document will hold this controller in the later patch. Depends on D27616 Differential Revision: https://phabricator.services.mozilla.com/D27617
c331a4a8b3439fdb15fd43544dd964cc7710847b: Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug
Fariskhi Vidyan <farislab@gmail.com> - Thu, 25 Apr 2019 18:30:06 +0000 - rev 530198
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1272409 - Part 2: Add ResizeObserver webidl and implementation. r=dholbert,smaug This implements the first version of spec, so the webidl file doesn't match the current spec and we will fix them in the follow-up bugs. i.e. 1. The default observer box is content-box. 2. `ResizeObserverBoxOptions`, `ResizeObserverOptions`, and `ResizeObserverSize` are not included in `ResizeObserver.webidl`. 3. `ResizeObserverEntry` doesn't have `borderBoxSize` and `contentBoxSize` attributes. Depends on D27615 Differential Revision: https://phabricator.services.mozilla.com/D27616
3638ca566d8832c2dee2d273d2a34adb54be521e: Bug 1542646 Part 11 - add explicit to constructor r=dholbert
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:43 +0100 - rev 530089
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 11 - add explicit to constructor r=dholbert
9fc36dfcb6cf0486b0e6cd3a38e7566075c2487b: Bug 1542646 Part 11 - add explicit to constructor r=dholbert
longsonr <longsonr@gmail.com> - Wed, 24 Apr 2019 21:39:43 +0100 - rev 530083
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 11 - add explicit to constructor r=dholbert
e5029a42a612c56a826a4634425c9f0670e9a111: Bug 1546223 Part 5 - Change ReflowInput::InitConstraints() to use Maybe for containing block size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 22:23:59 +0000 - rev 530044
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 5 - Change ReflowInput::InitConstraints() to use Maybe for containing block size. r=dholbert There are some minor behavior changes come with this. 1) Change the default containing block size to (NS_UNCONSTRAINEDSIZE, NS_UNCONSTRAINEDSIZE). I think this is more reasonable than (-1, -1). 2) mContainingBlockSize is used to cache only the block size passing though constructor, Init(), or the invalid (-1, -1). This patch makes it cache the value computed by ComputeContainingBlockRectangle(). Note that mContainingBlockSize is used only in nsTableWrapperFrame::InitChildReflowInput() to set the inner table frame's containing block to be the same as the outer table frame's. We don't change this behavior by caching more. Because even if the inner frame use the invalid cached (-1, -1) containing block size from the outer reflow input, it still computes the block size again in InitConstraints(). (Inner table's cb is the same as the outer table's per InitCBReflowInput().) Differential Revision: https://phabricator.services.mozilla.com/D28586
b23e64dd2c7bd9e83db404bde4b033d02d18d61e: Bug 1546223 Part 4 - Mechanically replace pointer with Maybe for ReflowInput's optional containing block size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 17:35:31 +0000 - rev 530043
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 4 - Mechanically replace pointer with Maybe for ReflowInput's optional containing block size. r=dholbert There's no behavior change in this patch. Differential Revision: https://phabricator.services.mozilla.com/D28426
d59741bdae0bb0a23bf3dc77ea3929bde1ccfeca: Bug 1546223 Part 3 - Use in-class member initializer for some of the member variables. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 17:35:31 +0000 - rev 530042
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 3 - Use in-class member initializer for some of the member variables. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28438
7bfdaa5f19d8731fc0375a2a4d8adccf946a16c1: Bug 1546223 Part 2 - Use in-class member initializer for those which were in constructor body. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 00:20:05 +0000 - rev 530041
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 2 - Use in-class member initializer for those which were in constructor body. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28428
3cd891607bf6137193b4f9975e27436e2c34e0cf: Bug 1546223 Part 1 - Use in-class member initializer for those which were in initializer list. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 17:35:05 +0000 - rev 530040
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 1 - Use in-class member initializer for those which were in initializer list. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28427
18c6cc260c2775694c5d1cf5350b8b3f04fcb97c: Bug 1546223 Part 0 - Remove unused NOISY_VERTICAL_ALIGN. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Apr 2019 17:35:05 +0000 - rev 530039
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546223 Part 0 - Remove unused NOISY_VERTICAL_ALIGN. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28429
d128c93735ff7f0654895ab0a4d987552efee242: Bug 1546739 - Fix detection of intrinsic size dependence of images. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 24 Apr 2019 20:05:34 +0000 - rev 530023
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546739 - Fix detection of intrinsic size dependence of images. r=dholbert Fixed width and height is not a strong enough condition. min/max-width with intrinsic size keywords makes the final size of the image also depend on the intrinsic size. Don't optimize away reflows when the intrinsic size changes if they're used. Differential Revision: https://phabricator.services.mozilla.com/D28720
8f99d1f6247203548fd613c6c23ede4c10562f74: Bug 1545892 - Reduce includes in gfx2DGlue.h, nsLayoutUtils.h, nsPresContext.h. r=dholbert
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 22 Apr 2019 19:58:52 +0000 - rev 529220
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545892 - Reduce includes in gfx2DGlue.h, nsLayoutUtils.h, nsPresContext.h. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D28266
81021da13bce7f15ef4129ad300af8894cd2af3f: Bug 874811 - Outer svg is a replaced box with CSS layout, and CSSOM should reflect that accordingly. r=dholbert,violet
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 22 Apr 2019 17:01:10 +0000 - rev 529188
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 874811 - Outer svg is a replaced box with CSS layout, and CSSOM should reflect that accordingly. r=dholbert,violet Co-authored-by: violet <violet.bugreport@gmail.com> Differential Revision: https://phabricator.services.mozilla.com/D28304
4496370098467d40a93a5c2febf0306bd69b7c51: Bug 1545230 - Enable AccessibleCaret gtests on Android. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 20 Apr 2019 20:27:32 +0000 - rev 529123
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545230 - Enable AccessibleCaret gtests on Android. r=dholbert These gtests are designed under the default preferences in mind. On Android, some of the preferences have different values, so we need to set them back to default value at the beginning of the tests so they don't fail on Android. Differential Revision: https://phabricator.services.mozilla.com/D28268
8f243d93742049295c734a5bd6e252d5a7d67c99: Bug 1542646 Part 10 - simplify boolean logic r=dholbert
longsonr <longsonr@gmail.com> - Sat, 20 Apr 2019 11:29:32 +0100 - rev 529114
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 10 - simplify boolean logic r=dholbert
9bb46f41277cf0beec92dd551c86c500dad5c3cf: Bug 1542646 Part 9 - Fix else after return r=dholbert
longsonr <longsonr@gmail.com> - Sat, 20 Apr 2019 11:26:19 +0100 - rev 529113
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542646 Part 9 - Fix else after return r=dholbert