searching for reviewer(dholbert)
921a30cac33b6d0760f318b6f1a2e3ce1bd687cc: Bug 386713 - Mark text-font-weight-01.svg passing on linux r=dholbert FIREFOX_BETA_79_BASE
longsonr <longsonr@gmail.com> - Sun, 28 Jun 2020 23:40:18 +0000 - rev 601837
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 386713 - Mark text-font-weight-01.svg passing on linux r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D81453
e95a37e6748c297a312f5bdb480173d7efdcd2d4: Bug 1648737 - Move SVGAFrame SVGGFrame SVGGenericContainerFrame SVGInnerSVGFrame SVGMarkerFrame SVGMaskFrame SVGSymbolFrame SVGViewportFrame to the mozilla namespace r=dholbert
longsonr <longsonr@gmail.com> - Sat, 27 Jun 2020 05:39:42 +0000 - rev 601768
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648737 - Move SVGAFrame SVGGFrame SVGGenericContainerFrame SVGInnerSVGFrame SVGMarkerFrame SVGMaskFrame SVGSymbolFrame SVGViewportFrame to the mozilla namespace r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D81310
1b8b8756acad785554d272c6b771b657bc551152: Bug 1648737 - Move SVGAFrame SVGGFrame SVGGenericContainerFrame SVGInnerSVGFrame SVGMarkerFrame SVGMaskFrame SVGSymbolFrame SVGViewportFrame to the mozilla namespace r=dholbert
longsonr <longsonr@gmail.com> - Fri, 26 Jun 2020 19:27:08 +0000 - rev 601732
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648737 - Move SVGAFrame SVGGFrame SVGGenericContainerFrame SVGInnerSVGFrame SVGMarkerFrame SVGMaskFrame SVGSymbolFrame SVGViewportFrame to the mozilla namespace r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D81310
c605d102fa64331e19e0b2733832e27365c4a88d: Bug 1648673 - Remove duplicate CSSOrderAwareFrameIteratorT typedefs in nsGridContainerFrame.h r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 26 Jun 2020 16:51:40 +0000 - rev 601715
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648673 - Remove duplicate CSSOrderAwareFrameIteratorT typedefs in nsGridContainerFrame.h r=dholbert * It's easier to maintain the type aliases of in one place, i.e. CSSOrderAwareFrameIterator.h, and the iterator's header itself doesn't include a lot of headers that add complex dependencies to nsGridContainerFrame.h. * Make "jump to definition" functionality in editors work correctly (rather than just jumping to those declarations.) Differential Revision: https://phabricator.services.mozilla.com/D81281
406930369866a0524398006491df475939cc48b0: Bug 1648463 - Move SVGForeignObjectFrame SVGImageFrame and SVGUseFrame to mozilla namespace r=dholbert,jgilbert
longsonr <longsonr@gmail.com> - Thu, 25 Jun 2020 20:42:49 +0000 - rev 601586
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1648463 - Move SVGForeignObjectFrame SVGImageFrame and SVGUseFrame to mozilla namespace r=dholbert,jgilbert stop exposing SVGImageListener as only SVGImageFrame uses it. Differential Revision: https://phabricator.services.mozilla.com/D81087
a24de17b72bdf0ebdf45775077b203e156bed18c: Bug 1562932 - Disable appearance WPT reftests on Windows due to animated theme painting. r=dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 25 Jun 2020 02:11:13 +0000 - rev 601387
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1562932 - Disable appearance WPT reftests on Windows due to animated theme painting. r=dholbert The <meter> element has an animation, which makes it difficult to reftest against. Differential Revision: https://phabricator.services.mozilla.com/D80814
bab16eaf2cde09281639626d13bb74636a6e0311: Bug 1647101 - Move SVGTextFrame SVGViewFrame SVGFEContainerFrame SVGFEImageFrame SVGFELeafFrame SVGFEUnstyledLeafFrame into the mozilla namespace r=dholbert
longsonr <longsonr@gmail.com> - Tue, 23 Jun 2020 22:59:34 +0000 - rev 601166
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647101 - Move SVGTextFrame SVGViewFrame SVGFEContainerFrame SVGFEImageFrame SVGFELeafFrame SVGFEUnstyledLeafFrame into the mozilla namespace r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D80383
f97fcfd4a045519d4bea0be975f86a6ed9caa043: Bug 1579186 - element.innerText should work with SVG text and foreignObject text r=dholbert
longsonr <longsonr@gmail.com> - Mon, 22 Jun 2020 18:46:35 +0000 - rev 600728
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1579186 - element.innerText should work with SVG text and foreignObject text r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D80376
715c953ae003a732c9fe24f64bcfe9b36579e259: Bug 1560275 - Flush layout in SVGGeometryElement::IsPointInStroke r=dholbert
longsonr <longsonr@gmail.com> - Mon, 15 Jun 2020 23:49:09 +0000 - rev 599900
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1560275 - Flush layout in SVGGeometryElement::IsPointInStroke r=dholbert SVGGeometryElement::IsPointInStroke calls SVGContentUtils::GetCTM and that can call nsSVGUtils::GetTransformMatrixInUserSpace which needs layout to be up to date Differential Revision: https://phabricator.services.mozilla.com/D79752
f4f558d1cc36ef3e1c3d3c0ca9ab576a315cedea: Bug 1644819 Part 3 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 13 Jun 2020 19:26:07 +0000 - rev 599696
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644819 Part 3 - Add a crashtest. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D79586
3b87f74ba068dbc588e61e7b71196d2d3a00049c: Bug 1644819 Part 2 - Prevent a split frame from being a dynamic reflow root. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 13 Jun 2020 04:04:13 +0000 - rev 599695
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644819 Part 2 - Prevent a split frame from being a dynamic reflow root. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D79585
4d39bd6871b85ab99737fb100f246a65ec7f610b: Bug 1644819 Part 1 - Assert that SharedFlexData is valid in flex container's continuations. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 13 Jun 2020 04:03:30 +0000 - rev 599694
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644819 Part 1 - Assert that SharedFlexData is valid in flex container's continuations. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D79584
8a48bbded63d7a216afc3c9466507842db9ddb7c: Bug 1640051 - Pull child's next-in-flow up after moving the child from overflow list to principal child list. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 12 Jun 2020 19:14:25 +0000 - rev 599653
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640051 - Pull child's next-in-flow up after moving the child from overflow list to principal child list. r=dholbert This is an extension to Bug 1271392 part 2. https://hg.mozilla.org/mozilla-central/rev/98710f78e04da1294b72517b5c5d7e0841eeb326 In flex/grid container P1's NormalizeChildLists(), when pulling up a first-in-flow frame F1 into the principal child list, we've already made sure its next-in-flow F2 is in P1's next-in-flow P2's respective overflow list. However, when reflowing P2, F2's next-in-flow may still be away in any of P2's next continuation chain, not necessary in P2's immediate next-in-flow P3. We'd want to pull up F2's next-in-flow (if any) after we move F2 from P2's overflow list into principal child list. This satisfies the assertion when calling SanityCheckChildListsBeforeReflow() on P3, i.e. any P2 children's next-in-flow should be in P3. Differential Revision: https://phabricator.services.mozilla.com/D78850
82d3d4f21315f99dca105cf711ac38977adbe5c9: Bug 1405813 - Move prev-in-flow's EOC list to this container frame's OC list in NormalizeChildLists(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 12 Jun 2020 19:03:49 +0000 - rev 599644
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1405813 - Move prev-in-flow's EOC list to this container frame's OC list in NormalizeChildLists(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78848
edfbe6020f30320f59907db427950f0080ddf347: Bug 1640441 - Don't do fancy floating point precision shenanigans on DOMRect::SetLayoutRect. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Jun 2020 18:57:15 +0000 - rev 599629
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640441 - Don't do fancy floating point precision shenanigans on DOMRect::SetLayoutRect. r=dholbert There are some issues with this code. It's using doubles, but SetRect only takes floats, so we lose precision there already. Instead of getting fancy, use the same conversion that the rest of Gecko uses, so that pages that compute style values out of getBoundingClientRect values don't get minor floating point changes. Differential Revision: https://phabricator.services.mozilla.com/D79326
dc0e21c99365d25fdc5edacd39c505e9449d3e10: Bug 1637788 Part 2 - Add more fragmentation reftests for multi-line row-oriented flex containers. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jun 2020 19:20:38 +0000 - rev 599295
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1637788 Part 2 - Add more fragmentation reftests for multi-line row-oriented flex containers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D79243
773e39dbc4cdbf08b0001b821bc3622f3db7f67b: Bug 1637788 Part 1 - Add base fragmentation reftests for multi-line row-oriented flex containers. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jun 2020 19:20:13 +0000 - rev 599294
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1637788 Part 1 - Add base fragmentation reftests for multi-line row-oriented flex containers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D79242
737f3b0c6b042a25667f4cb3692b699ef6a78917: Bug 1596160: Re-enable eslint rules within layout and address eslint failures in testcases r=dholbert
Kenrick <kenrick95@gmail.com> - Tue, 09 Jun 2020 15:27:37 +0000 - rev 598797
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1596160: Re-enable eslint rules within layout and address eslint failures in testcases r=dholbert This patch was largely automated. It was generated by manually editing .eslintrc.js and then running mach eslint layout --fix. Additionally, this includes manual changes to test_bug533845.xhtml and test_bug467442.xhtml that were necessary to appease eslint. Differential Revision: https://phabricator.services.mozilla.com/D78615
dbc4a4e02865a28378e74036788210245cd0f945: Bug 1560275 - Flush before trying to read style in SVGGeometryElement::IsPointInStroke r=dholbert,emilio
longsonr <longsonr@gmail.com> - Mon, 08 Jun 2020 21:58:40 +0000 - rev 598613
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1560275 - Flush before trying to read style in SVGGeometryElement::IsPointInStroke r=dholbert,emilio Differential Revision: https://phabricator.services.mozilla.com/D78721
9d2b99d6882e77d8032dd20bcd985bd80bd80b1a: Bug 1462186 - Mark reftest as slightly fuzzy on Windows 7 r=dholbert
longsonr <longsonr@gmail.com> - Mon, 08 Jun 2020 16:42:59 +0000 - rev 598543
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1462186 - Mark reftest as slightly fuzzy on Windows 7 r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78667
3b9d129eaf0388caf304a6600c407a8371712ce9: Bug 1644048 - wait for onload in reftest r=dholbert
longsonr <longsonr@gmail.com> - Mon, 08 Jun 2020 16:45:06 +0000 - rev 598536
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644048 - wait for onload in reftest r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78650
7f74b7440db868ddc8fd0aa82e8a78201388fd4c: Bug 1503525 - Increase fuzziness slightly r=dholbert
longsonr <longsonr@gmail.com> - Mon, 08 Jun 2020 16:40:50 +0000 - rev 598525
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1503525 - Increase fuzziness slightly r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78670
c98948afa16b1fc3f2d4b6af4391b2e475f8416f: Bug 1638051 - Stop clamping radialGradients. r=dholbert
longsonr <longsonr@gmail.com> - Sun, 07 Jun 2020 10:05:00 +0000 - rev 598361
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1638051 - Stop clamping radialGradients. r=dholbert We have to remove one of the radialGradient-basic-03-ref.svg tests (id=gradient5) because it's testing clamping i.e. an fr just inside the radius is the same as just outside and that's no longer true. Two of the other references are now different due to the lack of clamping. In order to get the test and reference the same, the reference is created using canvas since canvas has never had clamping. Clamping was required by SVG 1.1 but that requirement was explicitly removed in SVG 2 mostly to match canvas, which has never clamped. Any rendering artifacts would likely have been uncovered by canvas over the years since it has the same code that SVG uses absent any clamping. Differential Revision: https://phabricator.services.mozilla.com/D75706
2dd4b6b2f0d7519721b674ea31b7e5c609aab51f: Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Xidorn Quan <me@upsuper.org> - Sat, 06 Jun 2020 05:38:12 +0000 - rev 598334
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77584
382c1d654e2612cb21e4a27a3743be308f47f87e: Bug 1643173 Part 2 - Unify GetDisplayFlag helpers for flex and grid items. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Jun 2020 02:52:58 +0000 - rev 598144
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643173 Part 2 - Unify GetDisplayFlag helpers for flex and grid items. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D78167
9bea5add0bcdae7bf4f5c47f82c61634e93fc623: Bug 1643173 Part 1 - Convert enum nsIFrame::DISPLAY_CHILD_* to enum class. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Jun 2020 02:52:05 +0000 - rev 598143
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643173 Part 1 - Convert enum nsIFrame::DISPLAY_CHILD_* to enum class. r=dholbert The modifications are all straightforward conversion except the one in nsMathMLContainerFrame, where it is simplified by calling the equivalent BuildDisplayListForInline() helper. Differential Revision: https://phabricator.services.mozilla.com/D78166
6bb6a5cdc941eaa15c0e36dcaf8e4ad8509d4e90: Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert
Xidorn Quan <me@upsuper.org> - Thu, 04 Jun 2020 06:08:40 +0000 - rev 597920
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641139 - Reflow absolute frames in ruby container and ruby base container. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77584
65c8548cb97d3bb26fab48ebec7625883ec9b04d: Bug 1640028 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 22:20:41 +0000 - rev 597916
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640028 - Add a crashtest. r=dholbert Fixed by bug 1640275 and bug 1343948. Differential Revision: https://phabricator.services.mozilla.com/D78161
d39b5b23b9e7fc06f33ff4511a48fee3e117ea83: Bug 1640028 - Add a crashtest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 22:20:41 +0000 - rev 597901
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640028 - Add a crashtest. r=dholbert Fixed by bug 1640275 and bug 1343948. Differential Revision: https://phabricator.services.mozilla.com/D78161
ec3b786afe744aed08d454a180dfb5a1a70aba5a: Bug 1642430 - Improve SVGTests implementation r=dholbert
longsonr <longsonr@gmail.com> - Wed, 03 Jun 2020 15:34:21 +0000 - rev 597865
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642430 - Improve SVGTests implementation r=dholbert This is should not be a functional change, just making the methods in SVGTests easier to use/understand. There's a little dead code removal since we can go through the same code path for empty intl.accept_languages as we do when it has a value, and we'd almost always expect it to have a value. Differential Revision: https://phabricator.services.mozilla.com/D77694
5f82782c37e0ef0bd514f0b0c0259dfb26f23ab6: Bug 1608515: Update the SVG IsContainingWindowElementOfType impl for Fission r=barret,dholbert
Keefer Rourke <krourke@mozilla.com> - Wed, 03 Jun 2020 15:24:54 +0000 - rev 597855
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1608515: Update the SVG IsContainingWindowElementOfType impl for Fission r=barret,dholbert In nsSVGOuterSVGFrame::IsContainingWindowElementOfType, we now inspect the embedder by asking the window for its browsing context, instead of asking it directly for its frame element. Differential Revision: https://phabricator.services.mozilla.com/D77518
528fc992a6fa63d1c0b05d23896c91349d564293: Bug 1642694 - Build display list for frames in flex container's overflow container list. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jun 2020 03:52:29 +0000 - rev 597742
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642694 - Build display list for frames in flex container's overflow container list. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77855
bffa16d830c11999086fa5a0a6e09cb75b9cdb02: Bug 1642302 - mark wpt tests that depend on device-pixel-content-box as backlog (tier-2). r=dholbert
Joel Maher <jmaher@mozilla.com> - Tue, 02 Jun 2020 02:36:45 +0000 - rev 597519
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642302 - mark wpt tests that depend on device-pixel-content-box as backlog (tier-2). r=dholbert Mark wpt tests that depend on device-pixel-content-box as backlog (tier-2) Differential Revision: https://phabricator.services.mozilla.com/D77723
c50afc8ccccbe1d08bc4cc2c7976a656ca3747b9: Bug 1641803 - Remove old metadata for vendor-imports directory, r=dholbert
James Graham <james@hoppipolla.co.uk> - Mon, 01 Jun 2020 22:28:29 +0000 - rev 597513
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641803 - Remove old metadata for vendor-imports directory, r=dholbert This mostly refers to configurations that no longer exist Differential Revision: https://phabricator.services.mozilla.com/D77427
f3a829091fef65cf49209ed374688cdd6d5753ed: Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender r=dholbert
longsonr <longsonr@gmail.com> - Tue, 02 Jun 2020 02:53:22 +0000 - rev 597511
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D77577
027f8e28182dd3e0da0fdd09b3b6bb79af2ec7ba: Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender. r=dholbert, a=test-only
longsonr <longsonr@gmail.com> - Tue, 02 Jun 2020 02:53:22 +0000 - rev 596959
Push 13216 by ryanvm@gmail.com at Thu, 04 Jun 2020 14:32:15 +0000
Bug 1581622 - Make blend-exclusion reftest a slightly fuzzier match on geckoview webrender. r=dholbert, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D77577
a00f71376ad18b3cde3d92b338b5304c7ffd7334: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 21:54:57 +0000 - rev 595436
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
19b910256abfe62d1fcb177e48ed1c1a28f5b2ab: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 23:11:07 +0000 - rev 595435
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Differential Revision: https://phabricator.services.mozilla.com/D76205
3265c120177ff5e7cfe35fd9ab165c7d74284106: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 01:14:09 +0000 - rev 595249
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
057922187f3daa2396c04828dee2baeb895865bc: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 21 May 2020 18:38:59 +0000 - rev 595248
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Disable crashtest 1608851.html on Android because it causes OOM crash after landing this patch. Differential Revision: https://phabricator.services.mozilla.com/D76205
1da2faea06e80d252561993b9976a7777d911bbe: Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 May 2020 22:32:24 +0000 - rev 595099
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 2 - Add reftests for position:fixed flex & grid root element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D76206
84d138356c7699456abf8dc6483b1d49aab86771: Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 20 May 2020 22:32:06 +0000 - rev 595098
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1584890 Part 1 - Use nsFrameConstructorState::AddChild() to construct out-of-flow flex or grid container as the root element. r=dholbert If `contentFrame` is out-of-flow, nsFrameConstructorState::AddChild() can construct a placeholder frame for `contentFrame` and put the placeholder in `frameList`. Also, we need to use nsFrameConstructorState::GetGeometricParent() to get the correct parent when calling InitAndRestoreFrame() for an out-of-flow `contentFrame`. For example, if `contentFrame` has position:fixed, its parent should be ViewportFrame, not CanvasFrame (which is mDocElementContainingBlock). This patch also adds reftests for position:absolute flex & grid root element. Reftests for position:fixed root element are in the next part. Differential Revision: https://phabricator.services.mozilla.com/D76205
2924b52f3b3f620863d49f521b4a17d5b49be56b: Bug 1637145 Part 3 - Setup NS_STATE_FLEX_NORMAL_FLOW_CHILDREN_IN_CSS_ORDER for flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 03:46:52 +0000 - rev 594681
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637145 Part 3 - Setup NS_STATE_FLEX_NORMAL_FLOW_CHILDREN_IN_CSS_ORDER for flex container's next-in-flows. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D75156
dfd3e63d3371eac20a4217369677c1cbe16cce35: Bug 1637145 Part 2 - Use FlexItemIterator to improve the performance when generating FlexLines and FlexItems for flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 22:49:22 +0000 - rev 594680
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637145 Part 2 - Use FlexItemIterator to improve the performance when generating FlexLines and FlexItems for flex container's next-in-flows. r=dholbert By changing the FlexLines and FlexItems generated in flex container's first-in-flow in CSS "order" aware order (i.e. reverse them again if the flex container's internal axes are reversed), we can construct FlexItems for flex container's next-in-flows in linear time because once we find a FlexItem in the stored FlexLines via FlexItemIterator to construct a new FlexItem for a child frame, the FlexItem for the next child frame can only be found in a later entry (either in a later item in the same line, or an item in a later line). Differential Revision: https://phabricator.services.mozilla.com/D75155
ad89f466d991715dba86eb61630eee7f9761369c: Bug 1637145 Part 1 - Create a helper method for the code that generates FlexLines and FlexItems for a flex container's next-in-flows. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 03:46:46 +0000 - rev 594679
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637145 Part 1 - Create a helper method for the code that generates FlexLines and FlexItems for a flex container's next-in-flows. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D75154
bd3a170fc984a92ff6478480b16e3d8ce9cb2f68: Bug 1538537 - When suppressing anchoring on an scrollframe, forward to the frame that actually maintains the anchor as needed. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 May 2020 23:57:23 +0000 - rev 594678
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1538537 - When suppressing anchoring on an scrollframe, forward to the frame that actually maintains the anchor as needed. r=dholbert The test-case is position-change-heuristic.html but with body and #space having overflow: hidden, which makes it fail on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D75825
1ce1f7104af927a1c044bfe28fdbdd7f1dd5d59a: Bug 1639053 - Remove the ability to reverse axes internally for nsFlexContainerFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 19 May 2020 21:13:35 +0000 - rev 594638
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639053 - Remove the ability to reverse axes internally for nsFlexContainerFrame. r=dholbert The ability to reverse axes internally was added in bug 983427, but it turns out not to be used. test_flex_lines.html needs to be modified because those expected cross values are written as if the flex lines are physically in top-to-bottom order (due to we reversed the axes internally). Now we don't reverse the internal axes, the order of the flex lines becomes bottom-to-top due to "flex-wrap: wrap-reverse". The crossStart coordinate begins from the flex container's bottom end edge, and it increases from bottom to the top to the flex container's top end edge. (Note the flex container has 42px height.) Differential Revision: https://phabricator.services.mozilla.com/D75887
83b4973bb9d30a6c43b0b3ee4a259751dc275c6a: Bug 1637511 - Keep suppressing scrollbars than don't fit in the scrollport for overflow: auto. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 May 2020 21:24:15 +0000 - rev 594144
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1637511 - Keep suppressing scrollbars than don't fit in the scrollport for overflow: auto. r=dholbert Given there's content depending on it. This brings back the check from before the regression. I had to tweak percent-height-overflowing-image-1.html so that it doesn't hit scrollbar size limits on GTK (which are a bit ridiculous IMHO, but oh well). Differential Revision: https://phabricator.services.mozilla.com/D75171
76aa4bf4eabd44912cc33a4ccd4d5474fc0e2ca7: Bug 1622935 Part 4d - Add more reftests for single-line flex container in zero height multicols. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 11 May 2020 17:08:45 +0000 - rev 593170
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1622935 Part 4d - Add more reftests for single-line flex container in zero height multicols. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D74497
1035de8a28ce9fa3758f4ce92ec705f4b852baed: Bug 1622935 Part 4c - Add additional single-line flex container fragmentation reftests. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 08 May 2020 22:33:52 +0000 - rev 593169
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1622935 Part 4c - Add additional single-line flex container fragmentation reftests. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D73170