searching for reviewer(dbaron)
bccbe51cd7ca: Bug 1414147 - Move fontSmoothingBackgroundColor from nsStyleUserInterface to nsStyleFont / nsFont. r=dbaron
Markus Stange <mstange@themasta.com> - Thu, 02 Nov 2017 17:48:44 -0400 - rev 441030
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1414147 - Move fontSmoothingBackgroundColor from nsStyleUserInterface to nsStyleFont / nsFont. r=dbaron MozReview-Commit-ID: 7i0Sy50Badm
55562f81645e: Bug 1414513: Make the profile manager image selector a bit dumber. r=johannh a=dbaron a=nightly-crashes
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 04 Nov 2017 13:44:19 +0100 - rev 440992
Push 8123 by ryanvm@gmail.com at 2017-11-06 14:00 +0000
Bug 1414513: Make the profile manager image selector a bit dumber. r=johannh a=dbaron a=nightly-crashes MozReview-Commit-ID: 9NWUhP7KzZj
da60fbc99531: Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar. r=dbaron,njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 01 Nov 2017 10:19:56 +0900 - rev 440174
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1413111 - Use nsTSubstring::Split in nsCSSRuleProcessor::LangPseudoMatches instead of manually go through with FindChar. r=dbaron,njn
98c5873f6cf0: Bug 1318526 - pt 2 - Also remove unnecessary HTTP(../..) from reftest manifests now that tests run with relaxed file-URI origin restrictions. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Mon, 23 Oct 2017 23:57:11 +0100 - rev 438570
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1318526 - pt 2 - Also remove unnecessary HTTP(../..) from reftest manifests now that tests run with relaxed file-URI origin restrictions. r=dbaron
1bbadf495705: Bug 1393116 - Only fire resize event if size actually changed r=dbaron
angelsl <angelsl@in04.sg> - Sat, 09 Sep 2017 00:49:43 +0800 - rev 438403
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1393116 - Only fire resize event if size actually changed r=dbaron MozReview-Commit-ID: 1GssEpmUQNz
a75efb617f8c: Bug 1393116 - Move double-reflow for sizing-to-content one level lower r=dbaron
angelsl <angelsl@in04.sg> - Sat, 09 Sep 2017 00:38:54 +0800 - rev 438402
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1393116 - Move double-reflow for sizing-to-content one level lower r=dbaron After the fix to bug 1294442 and bug 1324499, ResizeReflow began to be called twice for each DOM update in webext popups, and we also artificially re-set the scroll outside of ResizeReflow to counter the DidDoReflow callback in nsHTMLScrollFrame setting scrolltop to zero due to the first reflow, which is done with unconstrained height. Because of the scrollport being reset we get spurious DOM scroll events. Replacing the scrollport also interrupts smooth scrolling. Move the double-reflow down one level into PresShell, doing it before DidDoReflow is called. The scrollport is no longer reset (causing a spurious scroll event), and we don't need to replace it (interrupting smooth scrolling). Also partially fixes bug 1396034. MozReview-Commit-ID: HzYITyH4UeW
2e84c446ce7f: Bug 1393116 - In ResizeReflow, check width too, when refusing SizeToContent without root frame r=dbaron
angelsl <angelsl@in04.sg> - Thu, 21 Sep 2017 22:35:48 +0800 - rev 438401
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1393116 - In ResizeReflow, check width too, when refusing SizeToContent without root frame r=dbaron MozReview-Commit-ID: 91D1cUB2JmW
1f1b4cb86b58: Bug 1318526 - Remove HTTP(..) from reftest manifests where this was only needed to work around file-URI origin restrictions. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Sun, 22 Oct 2017 08:31:41 +0100 - rev 438313
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1318526 - Remove HTTP(..) from reftest manifests where this was only needed to work around file-URI origin restrictions. r=dbaron
e7a617e26b96: Bug 1375858 - Don't allow nsBulletFrame to be transformed. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Wed, 18 Oct 2017 12:38:17 +1300 - rev 437613
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1375858 - Don't allow nsBulletFrame to be transformed. r=dbaron
c24097d6d633: Bug 1406211 - Add a reftest for animating opacity on a multiline inline element. r=dbaron
Ian Moody <moz-ian@perix.co.uk> - Mon, 09 Oct 2017 16:28:54 +0100 - rev 437046
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406211 - Add a reftest for animating opacity on a multiline inline element. r=dbaron MozReview-Commit-ID: 9z25jLeauO5
8da89309fd43: Bug 1406211 - Check whether the frame is one of continuation or ib-split-sinbling frames for animating element in nsIFrame::HasOpacityInternal(). r=dbaron
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sun, 15 Oct 2017 09:56:17 +0900 - rev 437045
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406211 - Check whether the frame is one of continuation or ib-split-sinbling frames for animating element in nsIFrame::HasOpacityInternal(). r=dbaron We need this change to generate nsDisplayOpacity for the continuation or ib-split-sibling frames other than the first continuation so the opacity animation on the continuation frames runs on the compositor. When we generate an nsDisplayOpacity, the animation runs on the compositor, but when we don't, the animation never updates since the animation is throttled on the main thread. MozReview-Commit-ID: DESftTLt0wq
41640ce02209: Bug 1406211 - Early return from nsIFrame::HasOpacityInternal if there is no EffectSet for the frame. r=dbaron
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Sun, 15 Oct 2017 09:56:17 +0900 - rev 437044
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406211 - Early return from nsIFrame::HasOpacityInternal if there is no EffectSet for the frame. r=dbaron If there is no EffectSet for the frame, it means no animation runs on the element for the frame. MozReview-Commit-ID: Ev9Hf3jquvU
fc7f5199a0e2: Bug 1406265 - use Set* and Is* instead of changing/getting the member directly. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Sun, 08 Oct 2017 20:06:00 -0400 - rev 435926
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1406265 - use Set* and Is* instead of changing/getting the member directly. r=dbaron MozReview-Commit-ID: 8l2MzjFGci4
b47b7fed9767: Bug 1317445 - Enable support for the 'font-display' descriptor in @font-face rules. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Thu, 05 Oct 2017 10:00:59 +0200 - rev 435422
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1317445 - Enable support for the 'font-display' descriptor in @font-face rules. r=dbaron
70b150570407: Bug 1397671 - Don't treat SVG transformed frames as being transformed for the purposes of computing Combines3DTransformWithAncestors. r=dbaron
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 26 Sep 2017 15:57:56 +1300 - rev 433622
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1397671 - Don't treat SVG transformed frames as being transformed for the purposes of computing Combines3DTransformWithAncestors. r=dbaron
a130f9b289df: Bug 1401287 - Skip sandbox check for test plug-in on Android; r=dbaron
Geoff Brown <gbrown@mozilla.com> - Fri, 22 Sep 2017 11:32:40 -0600 - rev 433323
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1401287 - Skip sandbox check for test plug-in on Android; r=dbaron The test plugins - dom/plugins/test/testplugin - are not built on Android. By assuming that the test plugin is not available on Android, a per-manifest check and warning can be avoided.
54a5c274f8a4: Bug 1397671 - Don't treat SVG transformed frames as being transformed for the purposes of computing Combines3DTransformWithAncestors. r=dbaron, a=sledru
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 26 Sep 2017 15:57:56 +1300 - rev 432013
Push 7870 by ryanvm@gmail.com at 2017-10-02 13:47 +0000
Bug 1397671 - Don't treat SVG transformed frames as being transformed for the purposes of computing Combines3DTransformWithAncestors. r=dbaron, a=sledru
ea5136a2af44: Bug 1401287 - Skip sandbox check for test plug-in on Android. r=dbaron, a=test-only
Geoff Brown <gbrown@mozilla.com> - Fri, 22 Sep 2017 11:32:40 -0600 - rev 431788
Push 7814 by ryanvm@gmail.com at 2017-09-24 21:16 +0000
Bug 1401287 - Skip sandbox check for test plug-in on Android. r=dbaron, a=test-only The test plugins - dom/plugins/test/testplugin - are not built on Android. By assuming that the test plugin is not available on Android, a per-manifest check and warning can be avoided.
9c1445f35fbf: Bug 1394226 - Add reftests. r=dbaron
Morris Tseng <mtseng@mozilla.com> - Thu, 21 Sep 2017 14:42:45 +0800 - rev 431712
Push 7785 by ryanvm@gmail.com at 2017-09-21 13:39 +0000
Bug 1394226 - Add reftests. r=dbaron MozReview-Commit-ID: FYOYVVKJsRg
0de55d6a505d: Bug 1394226 - Correct z-ordering for some table parts. r=dbaron
Morris Tseng <mtseng@mozilla.com> - Thu, 21 Sep 2017 14:42:44 +0800 - rev 431711
Push 7785 by ryanvm@gmail.com at 2017-09-21 13:39 +0000
Bug 1394226 - Correct z-ordering for some table parts. r=dbaron MozReview-Commit-ID: IdLhMGDmQag
b049c00f7a8f: Bug 1387594 - Add system colors for use in conjunction with -moz-font-smoothing-background-color and vibrant -moz-appearances. r=dbaron
Markus Stange <mstange@themasta.com> - Wed, 13 Sep 2017 13:48:07 +0200 - rev 430512
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1387594 - Add system colors for use in conjunction with -moz-font-smoothing-background-color and vibrant -moz-appearances. r=dbaron MozReview-Commit-ID: IxXZwONxy41
67ab42945b98: Bug 1387594 - Add a chrome-only CSS property called -moz-font-smoothing-background-color. r=dbaron
Markus Stange <mstange@themasta.com> - Wed, 16 Aug 2017 17:06:12 -0400 - rev 430508
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1387594 - Add a chrome-only CSS property called -moz-font-smoothing-background-color. r=dbaron This property accepts a color. It's inherited and defaults to transparent. Its value is respected on macOS when rendering text into transparent pixels. This property should be used for text that is placed on top of "vibrant" -moz-appearances, in order to achieve high quality text rendering for such text. In most cases, the property should be set to a named system color; an upcoming patch in this patch series will add one such color for each vibrant -moz-appearance value. However, in some cases it can also be useful to use a custom color: If text is rendered into an intermediate surface, for example because a mask is applied to it, and the background color behind that intermediate surface is known, then this property can be set to that background color in order to achieve subpixel AA for the text inside the mask effect. In that case, the font smoothing background color is respected because text is rendered into transparent pixels *inside the intermediate surface*. At the moment, the only example of that use case is the text of the active tab in the state where the text is overflowing. MozReview-Commit-ID: D98qQnxoFaq
405957d41476: Bug 895096 - Part 3: Clean up twipsPerPixel to oneDevPixel. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Tue, 12 Sep 2017 19:49:00 -0400 - rev 430178
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 895096 - Part 3: Clean up twipsPerPixel to oneDevPixel. r=dbaron MozReview-Commit-ID: 70aRd6KFpdd
78e432e75482: Bug 895096 - Part 2: Merge the identical parameters. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Tue, 12 Sep 2017 19:49:00 -0400 - rev 430177
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 895096 - Part 2: Merge the identical parameters. r=dbaron MozReview-Commit-ID: DNXagFqxLsq
5d6a0d528af1: Bug 895096 - Part 1: Round border-collapsed table borders to device pixels rather than CSS pixels, as for other borders, and store them (as BCPixelSize) as device pixels rather than CSS pixels. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Tue, 12 Sep 2017 19:48:00 -0400 - rev 430176
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 895096 - Part 1: Round border-collapsed table borders to device pixels rather than CSS pixels, as for other borders, and store them (as BCPixelSize) as device pixels rather than CSS pixels. r=dbaron MozReview-Commit-ID: 3yqj8gAAGYv
65d4f7ef3fe6: Bug 1389029 - Create custom change hint and post restyle event for rowspan, colspan attribute changes. r=dbaron
Neerja Pancholi <npancholi@mozilla.com> - Tue, 05 Sep 2017 13:30:40 -0700 - rev 428538
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1389029 - Create custom change hint and post restyle event for rowspan, colspan attribute changes. r=dbaron MozReview-Commit-ID: IwUlgDa3DAj
26e771621b71: Bug 1367860 (part 5) - Add testcases. r=dbaron
Kevin Hsieh <kevin.hsieh@ucla.edu> - Fri, 18 Aug 2017 14:46:45 -0700 - rev 426542
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1367860 (part 5) - Add testcases. r=dbaron MozReview-Commit-ID: E29lR1RMDp4
5bd865157802: Bug 1367860 (part 3) - Construct language-specific default variable font as fallback font, not specified font. r=dbaron
Kevin Hsieh <kevin.hsieh@ucla.edu> - Fri, 18 Aug 2017 12:56:02 -0700 - rev 426540
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1367860 (part 3) - Construct language-specific default variable font as fallback font, not specified font. r=dbaron MozReview-Commit-ID: 5kBHhvacxbS
680ccadcd055: Bug 1367860 (part 2) - Update CSS fallback font when lang changes. r=dbaron
Kevin Hsieh <kevin.hsieh@ucla.edu> - Fri, 18 Aug 2017 11:30:21 -0700 - rev 426539
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1367860 (part 2) - Update CSS fallback font when lang changes. r=dbaron MozReview-Commit-ID: 1VzxKnJJ1kD
960307b8d3c7: Bug 1367860 (part 1) - Handle CSS font-family units using switch instead of if. r=dbaron
Kevin Hsieh <kevin.hsieh@ucla.edu> - Fri, 18 Aug 2017 11:26:44 -0700 - rev 426538
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1367860 (part 1) - Handle CSS font-family units using switch instead of if. r=dbaron MozReview-Commit-ID: DBwSHM8kfGP
76c7aa772dc4: Bug 1324499: Save and restore scroll position after reflow in GetContentSizeInternal r=dbaron
angelsl <angelsl@in04.sg> - Mon, 21 Aug 2017 21:25:20 +0800 - rev 425775
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1324499: Save and restore scroll position after reflow in GetContentSizeInternal r=dbaron The bug is caused by the first call to ResizeReflow in nsDocumentViewer::GetContentSizeInternal, which reflows the content with unlimited height. ResizeReflow calls DidDoReflow, which calls a callback installed by nsHTMLScrollFrame that clamps the scroll port setting the scroll top to 0 and losing the original scroll top. When the content is reflowed again to the maximum height, the scroll top stays at 0. MozReview-Commit-ID: 3VkgWLqSTDP
14de940bb317: Bug 1386103 (part 1, attempt 3) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 09 Aug 2017 20:41:38 +1000 - rev 425089
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1386103 (part 1, attempt 3) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
5e6de75921f1: Bug 1390036 (part 2) - Remove nsXPIDLString use from NullString(). r=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Mon, 14 Aug 2017 14:46:53 +1000 - rev 424532
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1390036 (part 2) - Remove nsXPIDLString use from NullString(). r=dbaron. This requires adding a new constructor for ns[C]String that can be used to create an IsVoid string.
07241c0f20c1: Bug 1386103 (part 1, attempt 2) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 09 Aug 2017 16:34:12 +1000 - rev 423056
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1386103 (part 1, attempt 2) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
3f9ec011c9bd: Bug 1386103 (part 1) - Specify nsAuto[C]String storage size via template parameter. r=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Tue, 01 Aug 2017 11:58:45 +1000 - rev 423052
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1386103 (part 1) - Specify nsAuto[C]String storage size via template parameter. r=dbaron. This patch parameterizes nsAuto[C]String, renames them as nsAuto[C]StringN, and redefines nsAuto[C]String as typedefs for nsAuto[C]StringN<64>. (The alternative would be to templatize nsAuto[C]String and use a default parameter, but that would require writing "nsAuto[C]String<>" everywhere.)
2cc10ab1ca28: Bug 1379306 - Reftest for position:absolute block that is relative to table cell, row, row group. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Mon, 07 Aug 2017 20:31:00 +0200 - rev 422887
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1379306 - Reftest for position:absolute block that is relative to table cell, row, row group. r=dbaron MozReview-Commit-ID: 5ZdorkAhfj6
fe69c6a1b4a3: Bug 1379306 - Fix the wrong position when we calculate the position for position:absolute child. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Mon, 07 Aug 2017 20:31:00 +0200 - rev 422886
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1379306 - Fix the wrong position when we calculate the position for position:absolute child. r=dbaron Use |GetUsedBorder| instead of |GetComputedBorder| when we calculate the position for position:absolute child. MozReview-Commit-ID: 75gq5SFOVqT
9529eb7b4087: Bug 1385395 - Use flag bits in the nsGenericDOMDataNode to record whether nsTextFrame-related properties are present, so we don't perform unnecessary hashtable lookups in CharacterDataChanged etc. r=dbaron
Jonathan Kew <jkew@mozilla.com> - Mon, 07 Aug 2017 23:13:30 +0100 - rev 422823
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1385395 - Use flag bits in the nsGenericDOMDataNode to record whether nsTextFrame-related properties are present, so we don't perform unnecessary hashtable lookups in CharacterDataChanged etc. r=dbaron
e26e9804c545: Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 04 Aug 2017 14:40:52 +1000 - rev 422652
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron. This removes about 2/3 of the occurrences of nsXPIDLString in the tree. The places where nsXPIDLStrings are null-checked are replaced with |rv| checks. The patch also removes a couple of unused declarations from nsIStringBundle.idl. Note that nsStringBundle::GetStringFromNameHelper() was merged into GetStringFromName(), because they both would have had the same signature.
cb753cf67c6c: Bug 1324499 - Save and restore scroll position after reflow in GetContentSizeInternal. r=dbaron, a=gchang
angelsl <angelsl@in04.sg> - Mon, 21 Aug 2017 21:25:20 +0800 - rev 421434
Push 7684 by ryanvm@gmail.com at 2017-08-28 13:55 +0000
Bug 1324499 - Save and restore scroll position after reflow in GetContentSizeInternal. r=dbaron, a=gchang The bug is caused by the first call to ResizeReflow in nsDocumentViewer::GetContentSizeInternal, which reflows the content with unlimited height. ResizeReflow calls DidDoReflow, which calls a callback installed by nsHTMLScrollFrame that clamps the scroll port setting the scroll top to 0 and losing the original scroll top. When the content is reflowed again to the maximum height, the scroll top stays at 0. MozReview-Commit-ID: 3VkgWLqSTDP
1a6ea79cb3d7: Bug 1383075 part 1 - Handle URL token in a closer way to the spec. r=dbaron
Xidorn Quan <me@upsuper.org> - Fri, 28 Jul 2017 13:20:37 +1000 - rev 420813
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1383075 part 1 - Handle URL token in a closer way to the spec. r=dbaron MozReview-Commit-ID: B31txMs8fVw
9a7b90cf8a63: Bug 1361618 - Remove unnecessary calls to FlushPendingLinkUpdates. r=dbaron
J. Ryan Stinnett <jryans@gmail.com> - Thu, 29 Jun 2017 11:31:52 -0700 - rev 420390
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1361618 - Remove unnecessary calls to FlushPendingLinkUpdates. r=dbaron This removes the two calls to `FlushPendingLinkUpdates` in nsCSSFrameConstructor and GeckoRestyleManager, which appear to have no effect. Looking through what the pending link code is attempting to do: * When a new anchor is bound in `BindToTree` we do: 1. Link::ResetLinkState(false, Link::ElementHasHref()); * Set link's mLinkState to default (either unvisited or not link) * Set element's link mState bits to default (either unvisited or not link) 2. doc->RegisterPendingLinkUpdate(this); * Schedules idle dispatch to run `FlushPendingLinkUpdates` within 1 sec * In `FlushPendingLinkUpdates`: * For each pending link, call element->UpdateLinkState(link->LinkState()); 1. Register link for async history update to get potential future visited state 2. mLinkState is still unvisited / not link until we hear from history, so element state is unchanged Thus, there seems to be no need to call `FlushPendingLinkUpdates` outside of `BindToTree`, since visited state is always applied async anyway (so it doesn't work as an optimization to avoid restyling if visited, since that will trigger later). MozReview-Commit-ID: KbFuKve1KUi
7fbc3c5786d1: Bug 1383492: stylo: Change nscoord_MAX to 1<<30 - 1 ; r=emilio,dbaron
Manish Goregaokar <manishearth@gmail.com> - Tue, 25 Jul 2017 14:36:33 -0700 - rev 420244
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1383492: stylo: Change nscoord_MAX to 1<<30 - 1 ; r=emilio,dbaron nscoord_MAX is (1<<30) so that we can check for overflow *after* adding two nscoords. However, (nscoord_MAX + nscoord_MAX) will still overflow. Subtracting one makes this no longer possible. MozReview-Commit-ID: BtbQRMp5kWm
c5acd94ff501: Bug 1382327 - (reftest) Rename reftest-print to reftest-paged. r=dbaron
Tobias Schneider <schneider@jancona.com> - Wed, 26 Jul 2017 22:53:46 -0700 - rev 420061
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1382327 - (reftest) Rename reftest-print to reftest-paged. r=dbaron
11cadad891a4: Bug 1383492: stylo: Change nscoord_MAX to 1<<30 - 1 ; r=emilio,dbaron
Manish Goregaokar <manishearth@gmail.com> - Tue, 25 Jul 2017 14:36:33 -0700 - rev 419926
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1383492: stylo: Change nscoord_MAX to 1<<30 - 1 ; r=emilio,dbaron nscoord_MAX is (1<<30) so that we can check for overflow *after* adding two nscoords. However, (nscoord_MAX + nscoord_MAX) will still overflow. Subtracting one makes this no longer possible. MozReview-Commit-ID: BtbQRMp5kWm
32a63be3c80c: Bug 1375518 - Add reftest to check that border-radius is painted correctly on table. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Tue, 18 Jul 2017 12:00:27 +0800 - rev 419737
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1375518 - Add reftest to check that border-radius is painted correctly on table. r=dbaron MozReview-Commit-ID: KPuHtkttJim
7c414e653408: Bug 1375518 - Fix border-radius on table row groups, rows, column groups, or columns. r=dbaron
Ya-Chieh Wu <ywu@mozilla.com> - Fri, 14 Jul 2017 15:50:04 +0800 - rev 419734
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1375518 - Fix border-radius on table row groups, rows, column groups, or columns. r=dbaron Before bug 929484, border-radius on row groups, rows, column groups, or columns don't apply to the background of each cell, yet the border-radius on the cell itself does. After bug 929484, the behaviors changed. In this patch, I tried to revert the behaviors of border-radius on table row groups, rows, column groups, or columns back to what happened before bug 929484. MozReview-Commit-ID: 1Xg1qHde3lk
9c16700eed14: Bug 1364260 - Don't require whitespace between keywords and parens in supports rule condition. r=dbaron
Xidorn Quan <me@upsuper.org> - Thu, 20 Jul 2017 15:33:09 +1000 - rev 418543
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1364260 - Don't require whitespace between keywords and parens in supports rule condition. r=dbaron MozReview-Commit-ID: B7GsrDQ6NuO
68dccd8c1468: Bug 1379762 part 1. Don't call MediaFeaturesChanged if our override device pixel ratio is set to its current value. r=dbaron
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 17 Jul 2017 23:21:41 -0400 - rev 418109
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1379762 part 1. Don't call MediaFeaturesChanged if our override device pixel ratio is set to its current value. r=dbaron
3bc3266f999a: Bug 1350729 - Implement fake refcount logging for nsFakeStringBuffer. r=dbaron
Andrew McCreight <continuation@gmail.com> - Fri, 14 Jul 2017 10:20:23 -0700 - rev 417960
Push 7566 by mtabara@mozilla.com at 2017-08-02 08:25 +0000
Bug 1350729 - Implement fake refcount logging for nsFakeStringBuffer. r=dbaron Running with XPCOM_MEM_LOG_CLASSES=nsStringBuffer triggers an assertion in refcount logging for nsFakeStringBuffers. These are given an initial refcount of 1, without calling NS_LOG_ADDREF. Then, AddRef() is called on these objects in StaticAtom::StaticAtom(), and we tell the refcount logging system about the fake buffer, and that it has a refcount of 0, triggering the assertion. The first part of the fix is to call NS_LOG_ADDREF for this initial refcount, in StaticAtom(). This first fix causes refcount logging to start reporting that the fake string buffers leak, when XPCOM_MEM_LOG_CLASSES is not set. This is because refcount logging is now getting told about these objects being AddRefed at 1, which it takes to mean that an object is created. To work around this issue, I add an array gFakeBuffers that contains every fake string buffer we create, and tell the refcount logging system that these objects are all being destroyed, when the atom table is being shut down. This could result in some bogosity if the fake buffers are "leaked" but hopefully this is still an improvement over the current state. MozReview-Commit-ID: 5AxoBYAlYRU