searching for reviewer(dao)
edcfdb2bbe36f9c40c96ac5b8201aaa1e956eca6: Bug 1740393 Update preffed off "More from Mozilla 96" experiment w/QR code & email link, r=preferences-reviewers,desktop-theme-reviewers,pdahiya,dao,mstriemer
Dan Mosedale <dmose@mozilla.org> - Sat, 04 Dec 2021 17:37:37 +0000 - rev 670510
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1740393 Update preffed off "More from Mozilla 96" experiment w/QR code & email link, r=preferences-reviewers,desktop-theme-reviewers,pdahiya,dao,mstriemer Differential Revision: https://phabricator.services.mozilla.com/D132435
aa10a736dace67d4759ab0397a057c81a2b4f02c: Bug 1740393 Update "More from Mozilla" experiment with QR code/email link, r=preferences-reviewers,desktop-theme-reviewers,pdahiya,dao,mstriemer
Dan Mosedale <dmose@mozilla.org> - Sat, 04 Dec 2021 03:03:25 +0000 - rev 670505
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1740393 Update "More from Mozilla" experiment with QR code/email link, r=preferences-reviewers,desktop-theme-reviewers,pdahiya,dao,mstriemer Differential Revision: https://phabricator.services.mozilla.com/D132435
eb8c23dda78d3ed4bf244c3e72c76e81833086ff: Bug 1509931 - Use titlebar radius on Linux and make titlebar set-up work for lightweight themes. r=stransky,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Dec 2021 18:15:12 +0000 - rev 670262
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1509931 - Use titlebar radius on Linux and make titlebar set-up work for lightweight themes. r=stransky,dao To do this, we always draw the native titlebar behind the toolbox, and then make the toolbox adapt to it by using the titlebar radius. This makes us preserve the shadow properly. On Wayland we'd double-draw the shadow (see bug 1509931 comment 4) so this fixes it by trimming it as well using border-radius. Differential Revision: https://phabricator.services.mozilla.com/D128681
3c2567f65e5f57720c398e73714cbcaaab1a7640: Bug 1739615 - Force a light toolbar color when using the system theme on non-Linux platforms. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Dec 2021 14:03:11 +0000 - rev 670219
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1739615 - Force a light toolbar color when using the system theme on non-Linux platforms. r=desktop-theme-reviewers,dao Not sure what's the best way to test this. Differential Revision: https://phabricator.services.mozilla.com/D132392
1a0c81a339ff6cbd0b3d03d11e568360cfe09f52: Bug 1743803 - Remove unnecessary button-focus appearance value on Linux. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Dec 2021 13:33:02 +0000 - rev 670216
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1743803 - Remove unnecessary button-focus appearance value on Linux. r=dao This always draws transparent. Only real thing it does is forcing 0px padding. Differential Revision: https://phabricator.services.mozilla.com/D132563
babe6e5f9ba8b9c6bba914c4861f57c472e1b2ef: Bug 1742320 - Use dark form controls on about dialog. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Dec 2021 13:06:52 +0000 - rev 670213
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1742320 - Use dark form controls on about dialog. r=desktop-theme-reviewers,dao Some GTK light themes assume light backgrounds in some situations. Differential Revision: https://phabricator.services.mozilla.com/D132376
b17c1312fa2e0406ea1c3c6d2e44b1c317e370d4: Bug 1739615 - Force a light toolbar color when using the system theme on non-Linux platforms. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Dec 2021 07:19:27 +0000 - rev 670183
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1739615 - Force a light toolbar color when using the system theme on non-Linux platforms. r=desktop-theme-reviewers,dao Not sure what's the best way to test this. Differential Revision: https://phabricator.services.mozilla.com/D132392
5fe3c617d521ed21ffd41b8060dc1351e90650d1: Bug 1721217 - Part 12: Disable browser_scrollPositions.js, r=dao,daleharvey
Anny Gakhokidze <agakhokidze@mozilla.com> - Tue, 30 Nov 2021 16:31:38 +0000 - rev 670106
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1721217 - Part 12: Disable browser_scrollPositions.js, r=dao,daleharvey Differential Revision: https://phabricator.services.mozilla.com/D132388
50f07fce131a6a67ef8a2feedd3f334a9eda1fa1: Bug 1432090 - Honor GTK button layout. r=stransky,desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Nov 2021 11:37:52 +0000 - rev 669677
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1432090 - Honor GTK button layout. r=stransky,desktop-theme-reviewers,dao This is based off work by smurfd. But this patch doesn't support buttons both at the left and right, which simplifies a lot the implementation. Also, clean-up the existing env variables while at it. Co-authored-by: Nicklas Boman <smurfd@gmail.com> Differential Revision: https://phabricator.services.mozilla.com/D132073
52b6b0e4e646fc1220484cbb6f58cf674f13ad2e: Bug 1743010 - Prefer toolbar background to toolbar text to determine color-scheme, when available and opaque. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Nov 2021 09:34:35 +0000 - rev 669667
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1743010 - Prefer toolbar background to toolbar text to determine color-scheme, when available and opaque. r=desktop-theme-reviewers,dao As that can't be obscured by an image. Differential Revision: https://phabricator.services.mozilla.com/D132172
0d5589e4ee6585207a89410bb3e9b9412c7a82aa: Bug 1718846 - Draw our own titlebar buttons when using lightweight themes. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Nov 2021 14:56:15 +0000 - rev 669590
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1718846 - Draw our own titlebar buttons when using lightweight themes. r=dao Co-authored-by: Bernard Igiri <bigiri@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D129400
8aafc0622ff9ef46ff2d1d2885961205fd905368: Bug 1742661 - Add documentation for search engine icon sizes. r=dao
Mark Banner <standard8@mozilla.com> - Thu, 25 Nov 2021 10:28:45 +0000 - rev 669555
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1742661 - Add documentation for search engine icon sizes. r=dao Differential Revision: https://phabricator.services.mozilla.com/D131809
b7a2fbeaa6f69dd75b5c21f0b8fb60129f3f052a: Bug 1742764 - Don't prevent treecols and co. from growing. r=dao
Emilio Cobos Alvarez <emilio@crisal.io> - Wed, 24 Nov 2021 18:18:50 +0000 - rev 669496
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1742764 - Don't prevent treecols and co. from growing. r=dao Differential Revision: https://phabricator.services.mozilla.com/D132023
75dc332181abfbca718e361953cd101dc9b7f6ac: Bug 1742116: Remove a test for dead functionality r=dao
Tom Ritter <tom@mozilla.com> - Mon, 22 Nov 2021 16:12:21 +0000 - rev 669253
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1742116: Remove a test for dead functionality r=dao Differential Revision: https://phabricator.services.mozilla.com/D131636
ca306f7eb9912f0eeafc24a14716185291a12032: Bug 1737754 - Restore specificity for small buttons rule to fix infobar notification call-to-action buttons. r=jaws,desktop-theme-reviewers,dao
Sam Foster <sfoster@mozilla.com> - Fri, 19 Nov 2021 22:48:49 +0000 - rev 669154
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1737754 - Restore specificity for small buttons rule to fix infobar notification call-to-action buttons. r=jaws,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D131457
a21f52c1b50ac649f75e49acb494d9d6c36049b3: Bug 1725583 - Improve contrast of --in-content-box-border-color and --in-content-button-border-color in high contrast mode r=mtigley,desktop-theme-reviewers,dao
Shaoting Huang <huangs50@msu.edu> - Fri, 19 Nov 2021 21:55:11 +0000 - rev 669152
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1725583 - Improve contrast of --in-content-box-border-color and --in-content-button-border-color in high contrast mode r=mtigley,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D127452
8cd8d145ab66b52fdac865b0c435b8f3a3488591: Bug 1736368 - Use consistent min-heights for moz-tree-row and tree column headers. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Fri, 19 Nov 2021 14:03:30 +0000 - rev 669106
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1736368 - Use consistent min-heights for moz-tree-row and tree column headers. r=desktop-theme-reviewers,dao I couldn't reproduce this neither in Windows 10 nor 11 (the tree columns are small, but that happens both in light and dark mode). It is true, however, that the col pickers are too small generally on all platforms as well, so this seems reasonable. Differential Revision: https://phabricator.services.mozilla.com/D128751
1a065d19bef12aeb3f54a9cd30ae8dd6e1828e5b: Bug 1741931 - Use text color rather than background color to determine theme color scheme. r=harry,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 19 Nov 2021 14:03:06 +0000 - rev 669105
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1741931 - Use text color rather than background color to determine theme color scheme. r=harry,dao It's easy for themes that have image backgrounds to have bogus background colors. Text color should give a better indication of the color-scheme since it's always used, even with image backgrounds. Differential Revision: https://phabricator.services.mozilla.com/D131522
c2e3a0b6b0e4d28348f48e705e36f0fcee568e30: Bug 1741815 - Don't override lightweight theme colors in HCM. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Thu, 18 Nov 2021 18:43:15 +0000 - rev 669031
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1741815 - Don't override lightweight theme colors in HCM. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D131494
d5b7bad1db7901f87d008cc675b49fc1afb4c890: Bug 1741359 - Use auto outline for Windows buttons in dark mode. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Thu, 18 Nov 2021 18:40:37 +0000 - rev 669030
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1741359 - Use auto outline for Windows buttons in dark mode. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D131430
4ed9ad7c13505d461385aa97276ef71499a6dc98: Bug 1702983 - Display WebAuthn Attestation body of text in non bold. r=pbz,desktop-theme-reviewers,dao
Hannah Peuckmann <hpeuckmann@mozilla.com> - Thu, 18 Nov 2021 17:13:51 +0000 - rev 669023
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1702983 - Display WebAuthn Attestation body of text in non bold. r=pbz,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D131049
5c4174c4969cec4bb2584fa866d56f1f6f19ef36: Bug 1738855 - restore light theme active tab styles. r=dao
amy churchwell <achurchwell@mozilla.com> - Thu, 18 Nov 2021 11:28:55 +0000 - rev 668980
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738855 - restore light theme active tab styles. r=dao Differential Revision: https://phabricator.services.mozilla.com/D130401
665778c397d46923ff30771e1cb008e5a3b0644e: Bug 1738325 - Part 2 - Show expired but retained themes among the regular themes in about:addons. r=rpl,dao
Harry Twyford <htwyford@mozilla.com> - Wed, 17 Nov 2021 16:28:15 +0000 - rev 668916
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738325 - Part 2 - Show expired but retained themes among the regular themes in about:addons. r=rpl,dao Differential Revision: https://phabricator.services.mozilla.com/D130940
81b4750bca5d69c7fe45ba40952132a9ee1f1094: Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r=dao
Harry Twyford <htwyford@mozilla.com> - Wed, 17 Nov 2021 16:28:15 +0000 - rev 668915
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738325 - Uninstall expired themes from BuiltInThemes.jsm. r=dao This patch allows us to uninstall expired themes. It includes the uninstall logic in BuiltInThemes.ensureBuiltInThemes(), which runs on idle after startup and when about:addons is opened. It also changes aboutaddons.js so we don't show a blank Colorways section in about:addons if there are none installed. Finally, I removed the hidden pref gate controlling the Colorways feature. I initially included that to account for the possibility that we wouldn't finish the feature in time for 94 and we would've needed to uplift a simple patch to disable the dfeature. Since the feature has now shipped, there is no longer a need for the pref. After colorways expire, the user gets to keep the one they had installed going into the expiry, if any. This is information that would usually be associated with the profile. However, the themes are built-in (i.e. not in the profile). I get around this by saving a list of retained themes in a pref. This has drawbacks, such as making it possible to recover expired themes in about:config. I ran this by Product, and they're okay with it. Differential Revision: https://phabricator.services.mozilla.com/D130517
7e425f12545ab31cc0e15bad225f872903cd14d2: Bug 1738323 - Define built-in theme configuration file. r=dao
Harry Twyford <htwyford@mozilla.com> - Wed, 17 Nov 2021 16:28:14 +0000 - rev 668914
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738323 - Define built-in theme configuration file. r=dao I opted to define the configuration file as an object in a new JSM rather than as standard JSON. We will need to access this configuration data before UI startup, to read the installed theme from it. As a JSM, we can load it with getLazyModuleGetter and access it synchronously. A JSON file requires us to access it with fetch or IOUtils. We'd have to introduce async code to BuiltInThemes.maybeInstallActiveBuiltInTheme, which would be messy seeing as it runs in a sync context. Even though sync fetch or IOUtils would be fast since the file would be in omni.ja, I still don't want to add sync I/O anywhere near startup. Differential Revision: https://phabricator.services.mozilla.com/D130306
dca083f7bc4f82fdbeca2f9d128e8943bf1bca50: Bug 1696867 - Remove unused about.css r=desktop-theme-reviewers,dao
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 15 Nov 2021 08:56:28 +0000 - rev 668550
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1696867 - Remove unused about.css r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D130249
77ae78fcceeecde630644bcff25235eb6aa92100: Bug 1696867 - Use info-pages.css in about:cache r=dao
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 15 Nov 2021 08:56:28 +0000 - rev 668549
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1696867 - Use info-pages.css in about:cache r=dao Differential Revision: https://phabricator.services.mozilla.com/D130625
da5ac73d26ffd2a41b6d6a2ae0b07f3f75f39adb: Bug 1709349 - Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley,desktop-theme-reviewers,dao
lamoure6 <lamoure6@msu.edu> - Mon, 08 Nov 2021 14:39:20 +0000 - rev 667975
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1709349 - Adding blue/accent color to checked checkbox in HCM. r=mhowell,mtigley,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D130226
83b257ad49e374e76c940174fc023584d963c855: Bug 1738323 - Define built-in theme configuration file. r=dao
Harry Twyford <htwyford@mozilla.com> - Fri, 05 Nov 2021 14:05:22 +0000 - rev 667816
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1738323 - Define built-in theme configuration file. r=dao I opted to define the configuration file as an object in a new JSM rather than as standard JSON. We will need to access this configuration data before UI startup, to read the installed theme from it. As a JSM, we can load it with getLazyModuleGetter and access it synchronously. A JSON file requires us to access it with fetch or IOUtils. We'd have to introduce async code to BuiltInThemes.maybeInstallActiveBuiltInTheme, which would be messy seeing as it runs in a sync context. Even though sync fetch or IOUtils would be fast since the file would be in omni.ja, I still don't want to add sync I/O anywhere near startup. Differential Revision: https://phabricator.services.mozilla.com/D130306
9ec283f776cf26ec490b590b348f8f5615988b3e: Bug 1739042 - Force Windows' native context menus to be light. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@crisal.io> - Wed, 03 Nov 2021 17:54:55 +0000 - rev 667627
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1739042 - Force Windows' native context menus to be light. r=desktop-theme-reviewers,dao Since the native theme doesn't draw dark menus. Differential Revision: https://phabricator.services.mozilla.com/D130260
47aaa32834da994799e634cb2957a47adc9e60b8: Bug 1736807 - Use --toolbar-field-icon-fill-attention for login icon and remove login-icon class. r=desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Tue, 02 Nov 2021 19:29:11 +0000 - rev 667491
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1736807 - Use --toolbar-field-icon-fill-attention for login icon and remove login-icon class. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D129446
02724ee795e90a4e0b5de26d35c72599a1d07938: Bug 1734128 - Tab border irregular when scaled on Windows 10. r=desktop-theme-reviewers,dao
amy churchwell <achurchwell@mozilla.com> - Mon, 01 Nov 2021 16:22:10 +0000 - rev 666999
Push 16109 by ffxbld-merge at Mon, 06 Dec 2021 17:28:51 +0000
Bug 1734128 - Tab border irregular when scaled on Windows 10. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D128415
d12b8ece56e8f94ed1b7694ca37e0851e8859cee: Bug 1737754 - Restore specificity for small buttons rule to fix infobar notification call-to-action buttons. r=jaws,desktop-theme-reviewers,dao a=pascalc
Sam Foster <sfoster@mozilla.com> - Fri, 19 Nov 2021 22:48:49 +0000 - rev 666933
Push 16093 by pchevrel@mozilla.com at Wed, 24 Nov 2021 10:25:46 +0000
Bug 1737754 - Restore specificity for small buttons rule to fix infobar notification call-to-action buttons. r=jaws,desktop-theme-reviewers,dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D131457
bb0a1b7c2a45148b4ed28fe27720ff29124e3e25: Bug 1741815 - Don't override lightweight theme colors in HCM. r=desktop-theme-reviewers,dao a=pascalc
Emilio Cobos Alvarez <emilio@mozilla.com> - Thu, 18 Nov 2021 18:43:15 +0000 - rev 666915
Push 16084 by pchevrel@mozilla.com at Mon, 22 Nov 2021 15:59:22 +0000
Bug 1741815 - Don't override lightweight theme colors in HCM. r=desktop-theme-reviewers,dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D131494
5befbfbd9d6931363ed4ef7d78135e81ee0f97d1: Bug 1736807 - Use --toolbar-field-icon-fill-attention for login icon and remove login-icon class. r=desktop-theme-reviewers,dao a=pascalc
Harry Twyford <htwyford@mozilla.com> - Tue, 02 Nov 2021 19:29:11 +0000 - rev 666805
Push 16027 by pchevrel@mozilla.com at Tue, 09 Nov 2021 15:47:45 +0000
Bug 1736807 - Use --toolbar-field-icon-fill-attention for login icon and remove login-icon class. r=desktop-theme-reviewers,dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D129446
1145d08e7cd5574dc13de04acb201fad276bb408: Bug 1736522 - Hide titlebar button container on fullscreen on macOS. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Oct 2021 13:03:58 +0000 - rev 665950
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1736522 - Hide titlebar button container on fullscreen on macOS. r=desktop-theme-reviewers,dao This used to be done by: https://hg.mozilla.org/integration/autoland/rev/9785ceff3f61c52823d82b3f217b4897bcebaad3#l2.13 https://hg.mozilla.org/integration/autoland/rev/9785ceff3f61c52823d82b3f217b4897bcebaad3#l7.12 On macOS we don't want buttons on fullscreen at all. Differential Revision: https://phabricator.services.mozilla.com/D129173
f8ed785eea6d7b9bc660a9e76ff6d5810b95e30b: Bug 1734128 - Tab border irregular when scaled on Windows 10. r=desktop-theme-reviewers,dao
amy churchwell <achurchwell@mozilla.com> - Thu, 21 Oct 2021 17:35:02 +0000 - rev 665854
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1734128 - Tab border irregular when scaled on Windows 10. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D128415
46edc3da8b6cc3fe0b5ef8bb57cfd553c92120ad: Bug 1735643 - Unify Urlbar box HCM behaviour. r=desktop-theme-reviewers,dao
Harry Twyford <htwyford@mozilla.com> - Wed, 20 Oct 2021 19:27:00 +0000 - rev 665738
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1735643 - Unify Urlbar box HCM behaviour. r=desktop-theme-reviewers,dao This patch unifies the HCM colors used in the identity box, the search mode indicator, and the zoom indicator. It uses --button-bgcolor as the default background for all these elements. It uses SelectedItem/SelectedItemText on hover and active. This is similar to what we do with in-content buttons. Differential Revision: https://phabricator.services.mozilla.com/D128484
43f66f1b4f39e11b1fa7efaaa83cd3571edbc0a7: Bug 1718011 - Move update doorhangers upwards so that they overlap with the browser chrome r=dao
Kirk Steuber <ksteuber@mozilla.com> - Wed, 20 Oct 2021 16:51:32 +0000 - rev 665718
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1718011 - Move update doorhangers upwards so that they overlap with the browser chrome r=dao Differential Revision: https://phabricator.services.mozilla.com/D128423
63dee7b57626be83373304a5657719f720b4723a: Bug 1736141 - Derive a content theme from newtab page background, and use it for non-chrome docshells. r=mstange,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Oct 2021 08:25:57 +0000 - rev 665677
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1736141 - Derive a content theme from newtab page background, and use it for non-chrome docshells. r=mstange,dao We use "is-in-chrome-docshell" rather than "is a chrome doc" so that about: pages that are loaded in the content area (like about:addons etc) follow the general content theme as well. Cache the relevant color schemes since having that many branches on the default system theme made me a bit uncomfortable, and this code can be called quite a lot... Though it probably isn't such a huge deal. This makes us initialize the theme right away, so make sure subclasses do the right thing. This in practice was only an issue for GTK, which does cache the "system theme is dark" bit. Differential Revision: https://phabricator.services.mozilla.com/D128674
c9399923df7b9aecce48591c03fb324224eeab95: Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky,desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Oct 2021 18:51:41 +0000 - rev 665460
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1509931 - Remove -moz-gtk-csd-transparent-background. r=stransky,desktop-theme-reviewers,dao We always use alpha visual for WebRender, and appearance: none is unnecessary (root element has no intrinsic appearance). Differential Revision: https://phabricator.services.mozilla.com/D128682
d13671f3a4620c409e0d43351c35027f72016be2: Bug 1736368 - Use consistent min-heights for moz-tree-row and tree column headers. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Mon, 18 Oct 2021 16:25:27 +0000 - rev 665437
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1736368 - Use consistent min-heights for moz-tree-row and tree column headers. r=desktop-theme-reviewers,dao I couldn't reproduce this neither in Windows 10 nor 11 (the tree columns are small, but that happens both in light and dark mode). It is true, however, that the col pickers are too small generally on all platforms as well, so this seems reasonable. Differential Revision: https://phabricator.services.mozilla.com/D128751
81ca2d28c253bacdae4eabbce536a156a325ced8: Bug 1509931 - Simplify titlebar buttons CSS. r=desktop-theme-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 17 Oct 2021 14:23:24 +0000 - rev 665347
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1509931 - Simplify titlebar buttons CSS. r=desktop-theme-reviewers,dao There's no need to use the media query to set the default styles of the buttons, we only need to hide them if appropriate. Depends on D128682 Differential Revision: https://phabricator.services.mozilla.com/D128683
cfd460e7f462dfb1930b3bd57078b1b2f62717fc: Bug 1736038 - Remove -moz-toolbar-prefers-color-scheme. r=dao
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Oct 2021 16:53:08 +0000 - rev 665259
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1736038 - Remove -moz-toolbar-prefers-color-scheme. r=dao By making prefers-color-scheme return the ColorSchemeForChrome(), which accounts for the Firefox theme. Differential Revision: https://phabricator.services.mozilla.com/D128611
09ace42c5e87ccb3d892e9de4b9334023374e402: Bug 1529323 - Make prefers-color-scheme follow the Firefox theme, not the system theme (by default). r=mstange,dao,extension-reviewers,robwu
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Oct 2021 16:23:36 +0000 - rev 665254
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1529323 - Make prefers-color-scheme follow the Firefox theme, not the system theme (by default). r=mstange,dao,extension-reviewers,robwu Given all our UI is using -moz-toolbar-prefers-color-scheme, this seems like a more reasonable default nowadays. Allow for it to be configurable via the existing pref. Differential Revision: https://phabricator.services.mozilla.com/D128527
c9eb96aab0de879e9c812c75c2a8cb3eccc1f41c: Bug 1735465 - Make treecols look good on Windows dark mode by default. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Fri, 15 Oct 2021 11:35:38 +0000 - rev 665229
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1735465 - Make treecols look good on Windows dark mode by default. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D128479
fe3371d0bcb745ca33d859748e389c25d5c13582: Bug 1735619 - Remove border from downloads history button. r=dao
Emilio Cobos Alvarez <emilio@mozilla.com> - Thu, 14 Oct 2021 21:30:36 +0000 - rev 665201
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1735619 - Remove border from downloads history button. r=dao Differential Revision: https://phabricator.services.mozilla.com/D128480
132d9b4f70ed9a9d29cc3c1e41170dddd90af90b: Bug 1732692 - Set toolbar_top_separator to transparent for lush balanced theme. r=dao,harry
amy churchwell <achurchwell@mozilla.com> - Tue, 12 Oct 2021 16:10:34 +0000 - rev 664765
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1732692 - Set toolbar_top_separator to transparent for lush balanced theme. r=dao,harry Differential Revision: https://phabricator.services.mozilla.com/D128124
9785ceff3f61c52823d82b3f217b4897bcebaad3: Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@crisal.io> - Tue, 12 Oct 2021 13:20:13 +0000 - rev 664737
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao I've tested this (both with and without titlebar) in Linux, Win10, Win11, Win7 and macOS. * On macOS behavior doesn't change at all (since on fullscreen we didn't show the buttons to begin with). * Linux now shows "native" buttons on fullscreen (which is also an improvement). * On Windows 10/11 the sizing of the buttons is now the same when fullscreen vs. not (which is an improvement). * On Windows 7 we now use regular native-looking buttons (like on windows 10) instead of the custom windowControls.png. That could be considered a slight regression I guess, but is consistent with win10. Differential Revision: https://phabricator.services.mozilla.com/D128196
b74995b8a309c269eee1dd8e3b54c02bc42d6a38: Bug 1715990 - On windows HCM, draw titlebar ourselves rather than relying on the OS. r=desktop-theme-reviewers,dao
Emilio Cobos Alvarez <emilio@crisal.io> - Tue, 12 Oct 2021 12:53:30 +0000 - rev 664728
Push 15983 by ffxbld-merge at Mon, 01 Nov 2021 15:36:43 +0000
Bug 1715990 - On windows HCM, draw titlebar ourselves rather than relying on the OS. r=desktop-theme-reviewers,dao This prevents issues on win10 where this codepath is not really well tested, and also should be faster. Differential Revision: https://phabricator.services.mozilla.com/D128026