searching for reviewer(dao)
22a6f6f5023f0cd5c3474e52ddc2fa5f51136dba: Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=dao a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jan 2023 12:28:23 +0000 - rev 721183
Push 17517 by pchevrel@mozilla.com at Wed, 01 Feb 2023 14:36:41 +0000
Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=dao a=pascalc This was mixing old and new flexbox in a way that it happened to work before my patch, but really should've always needed min-width to work. Differential Revision: https://phabricator.services.mozilla.com/D167887
fac39bc41f50bf58ad4491fb2646f217ce568f45: Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=dao a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 31 Jan 2023 12:29:19 +0000 - rev 721182
Push 17517 by pchevrel@mozilla.com at Wed, 01 Feb 2023 14:36:41 +0000
Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=dao a=pascalc Why was it there? Who knows? Differential Revision: https://phabricator.services.mozilla.com/D167877
a766035681e3cd6a3907322a78032da929a58ba9: Bug 1810025 - ensure long data URIs are never fully present in the tab label, r=dao a=pascalc
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 18 Jan 2023 12:17:00 +0000 - rev 721076
Push 17461 by pchevrel@mozilla.com at Fri, 20 Jan 2023 12:48:48 +0000
Bug 1810025 - ensure long data URIs are never fully present in the tab label, r=dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D166737
e62fe8d903d1ca05a5172591c5ff8d370da4b349: Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao a=pascalc
mcheang <mcheang@mozilla.com> - Tue, 17 Jan 2023 15:11:23 +0000 - rev 721057
Push 17450 by pchevrel@mozilla.com at Wed, 18 Jan 2023 16:16:48 +0000
Bug 1810250 - Add weather icons for weather suggestions in the urlbar.r=adw,desktop-theme-reviewers,dao a=pascalc This patch receives a weather icon id from our merino server. We then use that icon id and map it to a specific weather icon svg file within urlbar-dyanmic-result.css. The icons colors are specified for light, dark, and high contrast mode. Differential Revision: https://phabricator.services.mozilla.com/D166848
c6ec3664e1f596c3126be42d9eb30f7e126f6bfa: Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao.
Florian Quèze <florian@queze.net> - Tue, 10 Jan 2023 08:26:07 +0000 - rev 720653
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. Differential Revision: https://phabricator.services.mozilla.com/D166099
4be513bf4ccb7a42498900ac186639cbae6ebe4b: Bug 1808965 - Stop calling _mouseleave and _mouseenter from _setPositionalAttributes. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 09 Jan 2023 18:29:38 +0000 - rev 720602
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808965 - Stop calling _mouseleave and _mouseenter from _setPositionalAttributes. r=dao Calling _mouseleave and _mouseenter from _setPositionalAttributes used to be needed to update the beforehovered and afterhovered attributes, as the tabs these attributes were set on might have changed. However, bug 1808661 removed these attributes, so mouseenter/mouseleave events should be sufficient for updating _hoveredTab itself. _setPositionalAttributes is a hot code-path, so avoiding the expensive querySelector("tab:hover") will improve performance when having lots of tabs. Depends on D166094 Differential Revision: https://phabricator.services.mozilla.com/D166225
b27dac0ce1b6147a511fc61d6a7ecc26512e2a2e: Bug 1806701 - Lock colorways migration behind a pref, disable by default on all channels. r=dao,zombie
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:17 +0000 - rev 720540
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806701 - Lock colorways migration behind a pref, disable by default on all channels. r=dao,zombie Depends on D165293 Differential Revision: https://phabricator.services.mozilla.com/D165455
ccfa3cf9a6bdd5f518c33f5c385f35e650eab962: Bug 1806701 - Remove migrated colorways themes from the list of the retained themes. r=zombie,dao
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:17 +0000 - rev 720539
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806701 - Remove migrated colorways themes from the list of the retained themes. r=zombie,dao Depends on D165196 Differential Revision: https://phabricator.services.mozilla.com/D165293
0bb92d5fb953846585dff41b018251263570674f: Bug 1806701 - Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r=zombie,dao
Luca Greco <lgreco@mozilla.com> - Mon, 09 Jan 2023 12:31:15 +0000 - rev 720536
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806701 - Allow builtin colorway themes to be updated to AMO hosted themes with the same addon ids. r=zombie,dao Differential Revision: https://phabricator.services.mozilla.com/D165194
1a38da4f6de9be57a0c305176990964cac1ac7e3: Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao.
Florian Quèze <florian@queze.net> - Mon, 09 Jan 2023 11:31:28 +0000 - rev 720532
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808729 - Limit session store writes to once per hour when the user is idle, r=dao. Differential Revision: https://phabricator.services.mozilla.com/D166099
bb55d68d351b9ac109cb74265c159883317c0fdc: Bug 1806765 - Implement zero-prefix telemetry and add weather suggestion exposure telemetry. r=dao
Drew Willcoxon <adw@mozilla.com> - Fri, 06 Jan 2023 23:44:19 +0000 - rev 720417
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806765 - Implement zero-prefix telemetry and add weather suggestion exposure telemetry. r=dao This adds telemetry to UrlbarView that records the following things related to the zero-prefix view (i.e., the topsites view): * Exposures: How many times the ZP view was shown * Engagements: How many times a result was picked in the ZP view * Abandonments: How many times the user abandoned the ZP view * Dwell time: How long the user was shown the ZP view I considered adding telemetry specifically for topsites instead of the ZP view as a whole, but since we have plans to start showing other types of results in the ZP view, I don't think it's a good idea to rely on one specific type of result as a proxy for the view itself. What DS and Product want to know about is the view itself: how many times it was shown, for how long, etc. This also adds one related scalar related to weather suggestions that counts the number of times it's shown. This is the same scalar I added in D164778 using a different, more complex approach. Depends on D164615 Differential Revision: https://phabricator.services.mozilla.com/D165253
1af752ee7a9d1fdf51d57a4c87378e1ba3e2e044: Bug 1808661 - Remove beforehovered and afterhovered. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:02 +0000 - rev 720416
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforehovered and afterhovered. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166094
ef929be929e54e74c1f9bfc7a67668d0031ea340: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720415
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
f7ba804ea8ec6284e075d10a233f22306b40a4e3: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720414
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
7b073cd0f4d7ff866929a504c30fe730eb496116: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:01 +0000 - rev 720413
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b9aaf8c0af510f07d6ce137f16bacfb196f70e73: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 21:48:00 +0000 - rev 720412
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
16871d37b8592175f4c443c2c4efa6ac745c6e1a: Bug 1808661 - Remove beforehovered and afterhovered. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:54 +0000 - rev 720395
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforehovered and afterhovered. r=dao Differential Revision: https://phabricator.services.mozilla.com/D166094
607a282e25f540e03bd140e2475269b538c512ff: Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:54 +0000 - rev 720394
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove before-multiselected and beforeMultiselected. r=Gijs,dao Depends on D166026 Differential Revision: https://phabricator.services.mozilla.com/D166027
c2ad604be36106e5ceea7b2fd761d93abf01b54f: Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720393
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove last-visible-tab and _lastTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166026
b22c7589a7bbf5ffa272632e03439af8ccc03dbd: Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720392
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove first-visible-tab and _firstTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166025
b0c1ee751b7aadebaa0fff0356560b36ac83bc87: Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Fri, 06 Jan 2023 19:38:53 +0000 - rev 720391
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808661 - Remove beforeselected-visible and _beforeSelectedTab. r=Gijs,dao Differential Revision: https://phabricator.services.mozilla.com/D166024
62e68f9b6f862590e90a30dddabfa99206fec504: Bug 1806985 - Use focus-visible instead of focus for PiP buttons. r=pip-reviewers,desktop-theme-reviewers,dao
Niklas Baumgardner <nbaumgardner@mozilla.com> - Thu, 05 Jan 2023 23:36:44 +0000 - rev 720327
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806985 - Use focus-visible instead of focus for PiP buttons. r=pip-reviewers,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D165909
ee61be99fb13bb08b94aaa3a50903a3a471cf0f6: Bug 1806903 - More from Mozilla - inline flow for description links. r=pdahiya,settings-reviewers,amy,dao
Shane Hughes <shughes@mozilla.com> - Thu, 05 Jan 2023 20:08:58 +0000 - rev 720308
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806903 - More from Mozilla - inline flow for description links. r=pdahiya,settings-reviewers,amy,dao Differential Revision: https://phabricator.services.mozilla.com/D165346
b7c21d63bd623860c099c96b5648bc07c5bc0a63: Bug 1808721 - Stop invalidating cached _tabs from showTab and hideTab. r=dao
Oriol Brufau <oriol-bugzilla@hotmail.com> - Thu, 05 Jan 2023 16:25:59 +0000 - rev 720287
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1808721 - Stop invalidating cached _tabs from showTab and hideTab. r=dao Invalidating cached _visibleTabs should be enough. Differential Revision: https://phabricator.services.mozilla.com/D166085
47c002d3637247e71ee901f32421deaecc9d8ea3: Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 04 Jan 2023 19:01:13 +0000 - rev 720091
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao Move most the event handling stuff to the DOM. I've left nsMenuBarFrame for now, but I will be removing that in the future. The basic set up is: * nsMenuParent becomes XULMenuParentElement (menubar or popup, manages the current active menu item) * nsMenuFrame -> XULButtonElements that return true for IsMenu(). Can't use XULMenuElement because of <button type=menu>, which behaves like a, well, menu. This makes the a11y events for menus (DOMMenuItem{Active,Inactive}) make sense (before that we were firing duplicate Inactive events etc, and the event order was rather suspicious). Differential Revision: https://phabricator.services.mozilla.com/D164210
1634f825626c05a1014de205653f31123439637e: Bug 1807984 - remove icon element that should never be displayed r=dao,amy
Robert Longson <longsonr@gmail.com> - Wed, 04 Jan 2023 16:00:37 +0000 - rev 720070
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1807984 - remove icon element that should never be displayed r=dao,amy Differential Revision: https://phabricator.services.mozilla.com/D165729
6ba37ceb159975373e1c9126199d843b96a4d651: Bug 1475606 - remove loadOneTab and switch its callers over, r=dao,perftest-reviewers,sparky
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 03 Jan 2023 22:24:44 +0000 - rev 719959
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1475606 - remove loadOneTab and switch its callers over, r=dao,perftest-reviewers,sparky Depends on D165774 Differential Revision: https://phabricator.services.mozilla.com/D165775
b2efc919bab153a7bcfaad18000efaf02d7dca13: Bug 1475606 - remove separate logic for tabbrowser's loadOneTab(), r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 03 Jan 2023 22:24:44 +0000 - rev 719958
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1475606 - remove separate logic for tabbrowser's loadOneTab(), r=dao This used to do three things: 1. determine whether we're background loading 2. determine a default owner tab 3. force allowInheritPrincipal to a bool value For the background loading, I removed the default pref check and moved the selection action into addTab. I defaulted it to true, so that existing addTab callers continue to open background tabs. I removed the code checking the pref: all existing loadOneTab callsites pass an explicit value and where appropriate check the pref themselves (sometimes doing the opposite in response to shift keypresses etc.). The one exception is browser_bug597218.js, but there the default of true gets used right now, which is still the same post-patch. For the owner tab, I moved setting the default into addTab. This shouldn't affect existing addTab callers as they don't pass inBackground anyway, so we default inBackground to true, in which case it just assigns null, only when ownerTab wasn't provided in the first place. For allowInheritPrincipal, the only reads of this in addTab use boolean negation anyway so forcing its type to bool first made no difference. Differential Revision: https://phabricator.services.mozilla.com/D165774
f11c529b240799df93c4dd8c17ecd8636f9b10de: Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Jan 2023 22:06:01 +0000 - rev 719953
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1805414 - Remove nsMenuFrame and nsMenuParent. r=smaug,Jamie,desktop-theme-reviewers,settings-reviewers,dao Move most the event handling stuff to the DOM. I've left nsMenuBarFrame for now, but I will be removing that in the future. The basic set up is: * nsMenuParent becomes XULMenuParentElement (menubar or popup, manages the current active menu item) * nsMenuFrame -> XULButtonElements that return true for IsMenu(). Can't use XULMenuElement because of <button type=menu>, which behaves like a, well, menu. This makes the a11y events for menus (DOMMenuItem{Active,Inactive}) make sense (before that we were firing duplicate Inactive events etc, and the event order was rather suspicious). Differential Revision: https://phabricator.services.mozilla.com/D164210
9b1c21cf3dbf87e6a85f11e49a6fb71a41c7be08: Bug 1738190 - allow opening inline SVG background images in a new tab, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 23 Dec 2022 17:23:44 +0000 - rev 719481
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1738190 - allow opening inline SVG background images in a new tab, r=dao Differential Revision: https://phabricator.services.mozilla.com/D165454
1c7233883670a8bd2fb3abe60bcf96c459e3d514: Bug 1806919 - simplify loadOneTab to not unwrap and rewrap the same object, r=dao
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 23 Dec 2022 17:23:43 +0000 - rev 719480
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1806919 - simplify loadOneTab to not unwrap and rewrap the same object, r=dao Differential Revision: https://phabricator.services.mozilla.com/D165453
c8ae77a066393f62938020933caceb8f342f41b8: Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida
Sergey Galich <sgalich@mozilla.com> - Fri, 16 Dec 2022 18:41:58 +0000 - rev 718729
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida Differential Revision: https://phabricator.services.mozilla.com/D158155
e0ae36457887054a6548606ec5388b6cef2dcd9f: Bug 1804353 - Don't select buttons on mousedown in the urlbar view. r=dao
Drew Willcoxon <adw@mozilla.com> - Fri, 16 Dec 2022 02:58:15 +0000 - rev 718638
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1804353 - Don't select buttons on mousedown in the urlbar view. r=dao This stops selecting buttons on mousedown so that selection and the input remain in a sensible state after clicking the block button while top sites are showing (e.g., in the weather suggestion). This turned out to be surprisingly complicated, so please see the bug and code comments for details. I think our selection logic is pretty brittle or at least convoluted and could stand to be simplified, but I didn't want to make large changes here. Ideally we wouldn't treat buttons any differently on mousedown -- so we'd select them too -- and it may be possible to do that while avoiding the problems I talk about in the bug, but I don't think it's at all worth the complexity that seems to be required. I added a new task to the test Daisuke created in D155812. Differential Revision: https://phabricator.services.mozilla.com/D164018
4c34b1f0c38db668c8a7399cc74f6d2bdb8be1e6: Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
Paul Adenot <paul@paul.cx> - Thu, 15 Dec 2022 14:11:04 +0000 - rev 718278
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao It's now clear when there is no log modules enabled. Differential Revision: https://phabricator.services.mozilla.com/D160210
ad94b64c18cb7691c3ddaa68c53df931a70d70e2: Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida
Sergey Galich <sgalich@mozilla.com> - Tue, 13 Dec 2022 03:09:18 +0000 - rev 717920
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida Differential Revision: https://phabricator.services.mozilla.com/D158155
dc1c2ffbc38e82e9d6a8b22d9d744ce45a6a3b56: Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
Paul Adenot <paul@paul.cx> - Mon, 12 Dec 2022 17:32:12 +0000 - rev 717849
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao It's now clear when there is no log modules enabled. Differential Revision: https://phabricator.services.mozilla.com/D160210
d6e93c10a90db0b5072095a72958540fb5c72d38: Bug 1293692 - Update ctrlTab thumbnails asynchronously. r=dao
Shane Hughes <shughes@mozilla.com> - Mon, 12 Dec 2022 00:25:59 +0000 - rev 717648
Push 17436 by ffxbld-merge at Mon, 16 Jan 2023 13:45:25 +0000
Bug 1293692 - Update ctrlTab thumbnails asynchronously. r=dao Use asynchronous methods to retrieve or generate page thumbnails. Also add explicit handling for unloaded browsers without stored page thumbnails. In that case, give the preview frame a fallback style instead of showing a broken img or an empty black canvas. Differential Revision: https://phabricator.services.mozilla.com/D159672
2522b2da871ea1779ad0ee4b1fe44a47fd21617d: Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida
Sergey Galich <sgalich@mozilla.com> - Fri, 09 Dec 2022 17:41:16 +0000 - rev 717135
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida Differential Revision: https://phabricator.services.mozilla.com/D158155
f59c8eb211e42eec668f14d0b99074992580e092: Bug 1786322 - Re-design bookmark detail pane to be a fixed height r=mak,desktop-theme-reviewers,dao
Jonathan Sudiaman <jsudiaman@mozilla.com> - Wed, 07 Dec 2022 23:47:38 +0000 - rev 716997
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1786322 - Re-design bookmark detail pane to be a fixed height r=mak,desktop-theme-reviewers,dao Expand default height of the library details pane and move form labels over to the side. {F4246935} Try Job: https://treeherder.mozilla.org/jobs?revision=c164cc6dc37b0ad3242ba1bb43ccb6f1ead1507c&repo=try Differential Revision: https://phabricator.services.mozilla.com/D161521
9723d831f2853db3e5b10dcfdcdb1b8fa64bee90: Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster
Sergey Galich <sgalich@mozilla.com> - Wed, 07 Dec 2022 22:59:32 +0000 - rev 716995
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster Differential Revision: https://phabricator.services.mozilla.com/D158155
961a442ae4ab5d7981fdcfb86ad422b13a736926: Bug 1783153 - Update strings and icons for Quickactions. r=daisuke,fluent-reviewers,desktop-theme-reviewers,flod,dao
Dale Harvey <dale@arandomurl.com> - Wed, 07 Dec 2022 20:28:43 +0000 - rev 716976
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1783153 - Update strings and icons for Quickactions. r=daisuke,fluent-reviewers,desktop-theme-reviewers,flod,dao Differential Revision: https://phabricator.services.mozilla.com/D158240
1ec8650f483147f13fe69c6b344d6509eec38e40: Bug 1804327 - Improve some styling for the context menu on Windows r=sfoster,dao
Itiel <itiel_yn8@walla.com> - Wed, 07 Dec 2022 20:04:58 +0000 - rev 716970
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1804327 - Improve some styling for the context menu on Windows r=sfoster,dao Differential Revision: https://phabricator.services.mozilla.com/D163985
258e7ce5c5a7bea7c428847094f797ebf1f96c16: Bug 1794485 - Remove colorway variation from about:welcome codebase r=pdahiya,dmose,desktop-theme-reviewers,dao
hanna alemu <halemu@mozilla.com> - Wed, 07 Dec 2022 19:05:24 +0000 - rev 716963
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1794485 - Remove colorway variation from about:welcome codebase r=pdahiya,dmose,desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D159324
2c0dae8a2aaf7c2563f2f810fe22fa784286a950: Bug 1676068 - Datepicker Pt.1 - Change DateTimePicker markup to HTML Table with ARIA Grid. r=Jamie,desktop-theme-reviewers,fluent-reviewers,flod,dao,mconley,kcochrane
Anna Yeddi <ayeddi@mozilla.com> - Wed, 07 Dec 2022 00:56:44 +0000 - rev 716842
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1676068 - Datepicker Pt.1 - Change DateTimePicker markup to HTML Table with ARIA Grid. r=Jamie,desktop-theme-reviewers,fluent-reviewers,flod,dao,mconley,kcochrane Done: - Changed DateTimePicker markup to HTML Table with ARIA Grid properties - Updated CSS for consistency - Provided localized strings for controls of the Datepicker itself and its Calendar widget - Added tests for the datepicker markup and its localization This patch is for HTML structure to comply with ARIA Design Practices 1.2 only. Further patches: - Pt.2 - Update month-year spinner dialog to follow the ARIA design pattern - Pt.3 - Replace Reset button with a Calendar button to toggle the datepicker's visibility - Pt.4 - Ensure keyboard support and proper focus behavior for both parts of the widget Differential Revision: https://phabricator.services.mozilla.com/D139980
bb81f9a1f97eff9e4058df8cae47bfcb9270ba82: Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao
Drew Willcoxon <adw@mozilla.com> - Tue, 06 Dec 2022 18:43:49 -0500 - rev 716838
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao This makes a couple of large changes: (1) "Generic" buttons (the ones added by `UrlbarView.#addRowButton()`) are now supported in all row types. The help button that's currently included in some types of rows when `result.payload.helpUrl` is defined is now supported for all row types, and two additional button types are now supported too: block buttons and labeled buttons. A row will get a block button if its `result.payload.isBlockable` is defined. It will get a labeled button if `result.payload.buttons` is defined and non-empty. A button can include a `url` property that is then added as an attribute on the button's element, and `UrlbarInput.pickResult()` will use this attribute to load the URL when the button is picked. (2) The reason I added labeled buttons is because it lets us support tip buttons without much more effort, which then lets us get rid of the special row type used for tips. With this patch, tips are now standard rows that use generic buttons. This approach should be compatible with the result menu, when we switch over to it, because we can include the help and block commands in the menu when `helpUrl` and `isBlockable` are defined, instead of creating buttons for them. Labeled buttons -- the ones used in tips -- would still be created. The result menu button itself can continue to be a generic button. It should also be compatible with including the result menu button inside the row selection. We'll still add buttons to `.urlbarView-row`, separate from `.urlbarView-row-inner`, so that the buttons can continue to be on the right side of the row. We can color the background of the row instead of the row-inner. As with D163630, my motivation for this change is to support generic buttons in dynamic result rows so that help and block buttons can be easily added to weather suggestions. Here too the larger changes of supporting generic labeled buttons and removing special rows for tips aren't strictly necessary, but I took the opportunity to rework things. Finally, this makes a few other changes: * It includes some of the more minor improvements to selection that I made in D163630. * It removes the help URL code from quick actions since it was decided not to show a help button. Currently, the button is hidden in CSS, but now that a generic help button is added for dynamic result rows when `result.payload.helpUrl` is defined, `helpUrl` needs to be removed from the payload to prevent a button from being added. * I removed the special tip wrapping behavior, where the tip button and help button would wrap below the tip's text. Instead, now the text wraps inside row-inner and the buttons always remain on the same horizontal as the text. I don't think it's worth the extra complication. Differential Revision: https://phabricator.services.mozilla.com/D163766
e0eac08ef8bc57af069cebff1aaf72080ea3c024: Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao
Drew Willcoxon <adw@mozilla.com> - Tue, 06 Dec 2022 22:28:55 +0000 - rev 716831
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao This makes a couple of large changes: (1) "Generic" buttons (the ones added by `UrlbarView.#addRowButton()`) are now supported in all row types. The help button that's currently included in some types of rows when `result.payload.helpUrl` is defined is now supported for all row types, and two additional button types are now supported too: block buttons and labeled buttons. A row will get a block button if its `result.payload.isBlockable` is defined. It will get a labeled button if `result.payload.buttons` is defined and non-empty. A button can include a `url` property that is then added as an attribute on the button's element, and `UrlbarInput.pickResult()` will use this attribute to load the URL when the button is picked. (2) The reason I added labeled buttons is because it lets us support tip buttons without much more effort, which then lets us get rid of the special row type used for tips. With this patch, tips are now standard rows that use generic buttons. This approach should be compatible with the result menu, when we switch over to it, because we can include the help and block commands in the menu when `helpUrl` and `isBlockable` are defined, instead of creating buttons for them. Labeled buttons -- the ones used in tips -- would still be created. The result menu button itself can continue to be a generic button. It should also be compatible with including the result menu button inside the row selection. We'll still add buttons to `.urlbarView-row`, separate from `.urlbarView-row-inner`, so that the buttons can continue to be on the right side of the row. We can color the background of the row instead of the row-inner. As with D163630, my motivation for this change is to support generic buttons in dynamic result rows so that help and block buttons can be easily added to weather suggestions. Here too the larger changes of supporting generic labeled buttons and removing special rows for tips aren't strictly necessary, but I took the opportunity to rework things. Finally, this makes a few other changes: * It includes some of the more minor improvements to selection that I made in D163630. * It removes the help URL code from quick actions since it was decided not to show a help button. Currently, the button is hidden in CSS, but now that a generic help button is added for dynamic result rows when `result.payload.helpUrl` is defined, `helpUrl` needs to be removed from the payload to prevent a button from being added. * I removed the special tip wrapping behavior, where the tip button and help button would wrap below the tip's text. Instead, now the text wraps inside row-inner and the buttons always remain on the same horizontal as the text. I don't think it's worth the extra complication. Differential Revision: https://phabricator.services.mozilla.com/D163766
263fffe843be0966cb3ae1b8fb6afc5ed02fd858: Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao
Drew Willcoxon <adw@mozilla.com> - Tue, 06 Dec 2022 16:35:31 +0000 - rev 716753
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1803873 - Support row buttons in all row types and make changes to tip rows. r=dao This makes a couple of large changes: (1) "Generic" buttons (the ones added by `UrlbarView.#addRowButton()`) are now supported in all row types. The help button that's currently included in some types of rows when `result.payload.helpUrl` is defined is now supported for all row types, and two additional button types are now supported too: block buttons and labeled buttons. A row will get a block button if its `result.payload.isBlockable` is defined. It will get a labeled button if `result.payload.buttons` is defined and non-empty. A button can include a `url` property that is then added as an attribute on the button's element, and `UrlbarInput.pickResult()` will use this attribute to load the URL when the button is picked. (2) The reason I added labeled buttons is because it lets us support tip buttons without much more effort, which then lets us get rid of the special row type used for tips. With this patch, tips are now standard rows that use generic buttons. This approach should be compatible with the result menu, when we switch over to it, because we can include the help and block commands in the menu when `helpUrl` and `isBlockable` are defined, instead of creating buttons for them. Labeled buttons -- the ones used in tips -- would still be created. The result menu button itself can continue to be a generic button. It should also be compatible with including the result menu button inside the row selection. We'll still add buttons to `.urlbarView-row`, separate from `.urlbarView-row-inner`, so that the buttons can continue to be on the right side of the row. We can color the background of the row instead of the row-inner. As with D163630, my motivation for this change is to support generic buttons in dynamic result rows so that help and block buttons can be easily added to weather suggestions. Here too the larger changes of supporting generic labeled buttons and removing special rows for tips aren't strictly necessary, but I took the opportunity to rework things. Finally, this makes a few other changes: * It includes some of the more minor improvements to selection that I made in D163630. * It removes the help URL code from quick actions since it was decided not to show a help button. Currently, the button is hidden in CSS, but now that a generic help button is added for dynamic result rows when `result.payload.helpUrl` is defined, `helpUrl` needs to be removed from the payload to prevent a button from being added. * I removed the special tip wrapping behavior, where the tip button and help button would wrap below the tip's text. Instead, now the text wraps inside row-inner and the buttons always remain on the same horizontal as the text. I don't think it's worth the extra complication. Differential Revision: https://phabricator.services.mozilla.com/D163766
e73defde7d215471cc86e8ce6a771356dc995c7e: Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao
Paul Adenot <paul@paul.cx> - Tue, 06 Dec 2022 15:46:40 +0000 - rev 716739
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1796554 - Make about:logging look a bit better, fix inconsistencies when clicking various buttons. r=desktop-theme-reviewers,mossop,flod,dao It's now clear when there is no log modules enabled. Differential Revision: https://phabricator.services.mozilla.com/D160210
a06081c856464add403177805414294320864e1d: Bug 1676068 - Datepicker Pt.1 - Change DateTimePicker markup to HTML Table with ARIA Grid. r=Jamie,desktop-theme-reviewers,fluent-reviewers,flod,dao,mconley,kcochrane
Anna Yeddi <ayeddi@mozilla.com> - Tue, 06 Dec 2022 03:18:24 +0000 - rev 716671
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1676068 - Datepicker Pt.1 - Change DateTimePicker markup to HTML Table with ARIA Grid. r=Jamie,desktop-theme-reviewers,fluent-reviewers,flod,dao,mconley,kcochrane Done: - Changed DateTimePicker markup to HTML Table with ARIA Grid properties - Updated CSS for consistency - Provided localized strings for controls of the Datepicker itself and its Calendar widget - Added tests for the datepicker markup and its localization This patch is for HTML structure to comply with ARIA Design Practices 1.2 only. Further patches: - Pt.2 - Update month-year spinner dialog to follow the ARIA design pattern - Pt.3 - Replace Reset button with a Calendar button to toggle the datepicker's visibility - Pt.4 - Ensure keyboard support and proper focus behavior for both parts of the widget Differential Revision: https://phabricator.services.mozilla.com/D139980
a2f9ac51b94bb8e74f9d2a8efcd85808e8c80db7: Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod
Kelly Cochrane <kcochrane@mozilla.com> - Fri, 02 Dec 2022 19:31:45 +0000 - rev 716515
Push 17339 by ffxbld-merge at Mon, 12 Dec 2022 14:35:11 +0000
Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D163719