searching for reviewer(cykesiopka)
facb23d70335db103f23fe988345f4b3d00aa8c9: bug 1397837 - remove vestigial references to "code signing" from PSM r=Cykesiopka,snorp
David Keeler <dkeeler@mozilla.com> - Fri, 01 Dec 2017 16:16:20 -0800 - rev 446690
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1397837 - remove vestigial references to "code signing" from PSM r=Cykesiopka,snorp As of bug 1257362, the platform does not verify code signing certificates in general, so anything involving the code signing trust of certificates can go. MozReview-Commit-ID: 9g9kM62xfYZ
e972f1bffe6982813442ad3cb6d59571fa85000f: bug 1413336 - (7/7) regenerate all the certificates! r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 08 Nov 2017 12:57:03 -0800 - rev 444088
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1413336 - (7/7) regenerate all the certificates! r=Cykesiopka Also regenerate the test_signed_app.js testcases. MozReview-Commit-ID: 483uNQT0wuG
f9180211e8740e0a335755d4f9792d3c89415ede: bug 1413336 - (6/7) replace setComponentByName with direct property setters r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Tue, 14 Nov 2017 13:35:10 -0800 - rev 444087
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1413336 - (6/7) replace setComponentByName with direct property setters r=Cykesiopka MozReview-Commit-ID: EIIzP04YHo9
d6c06eed38fe00a81b80cc936d632ec662ae4e8f: bug 1413336 - (5/7) ensure text files generated by pycert et. al. have trailing newlines r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 25 Oct 2017 16:59:18 -0700 - rev 444086
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1413336 - (5/7) ensure text files generated by pycert et. al. have trailing newlines r=Cykesiopka MozReview-Commit-ID: KduWJRzTxBp
37dd644dc98469029b33c3d41fd1e94f432d084d: bug 1413336 - (4/7) make certificate serial number generation not depend on pyasn1 object string representation r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 08 Nov 2017 14:12:03 -0800 - rev 444085
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1413336 - (4/7) make certificate serial number generation not depend on pyasn1 object string representation r=Cykesiopka MozReview-Commit-ID: 69GjudEKwQM
62a772c934611f76b351627c8aa9fa4116b1edaa: bug 1413336 - (3/7) fix pycert.py and pykey.py with respect to pyasn1/pyasn1-modules updates r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 08 Nov 2017 13:23:17 -0800 - rev 444084
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
bug 1413336 - (3/7) fix pycert.py and pykey.py with respect to pyasn1/pyasn1-modules updates r=Cykesiopka MozReview-Commit-ID: CsxOF7LdEHB
544b2dfa1b065fb49ea6f4b84edaa1cc95d5df86: bug 1407081 - rework signed app tests for flexibility with upcoming hash algorithm changes r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Tue, 10 Oct 2017 16:55:09 -0700 - rev 438054
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
bug 1407081 - rework signed app tests for flexibility with upcoming hash algorithm changes r=Cykesiopka,jcj MozReview-Commit-ID: 6HnJPrG7GfK
efebd70a62b5bf7b42253be5d93e0d49c526af72: bug 1257362 - remove the code-signing usage from certverifier as nothing uses it r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Mon, 02 Oct 2017 16:24:38 -0700 - rev 438011
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
bug 1257362 - remove the code-signing usage from certverifier as nothing uses it r=Cykesiopka MozReview-Commit-ID: 6nWy8k6fMvw
ee6479d783a60ad7ba4aad54a50bc8c1d77a894e: bug 1257362 - remove the code-signing usage from certverifier as nothing uses it r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Mon, 02 Oct 2017 16:24:38 -0700 - rev 435314
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
bug 1257362 - remove the code-signing usage from certverifier as nothing uses it r=Cykesiopka MozReview-Commit-ID: 6nWy8k6fMvw
a189001e988683bac65a2ef910f903d69a263c3f: bug 1257403 - don't bother verifying CA or email certificates when importing r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 22 Sep 2017 15:42:20 -0700 - rev 434527
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
bug 1257403 - don't bother verifying CA or email certificates when importing r=Cykesiopka Incidentally, this means we can remove certificateUsageVerifyCA and certificateUsageStatusResponder from CertVerifier, since we no longer use them. MozReview-Commit-ID: Bbqn8fShfTm
01992997c2bb93f53606b30c34aeb3383d488b7a: bug 1368652 - test that viewing a certificate with a long OID doesn't crash the browser r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 15 Sep 2017 14:18:27 -0700 - rev 431011
Push 7775 by ryanvm@gmail.com at Tue, 19 Sep 2017 01:22:09 +0000
bug 1368652 - test that viewing a certificate with a long OID doesn't crash the browser r=Cykesiopka MozReview-Commit-ID: JhUvDEJJvJy
7ad200a781d155df2d4be82f88b0541967eece0e: bug 1398932 - add a preference for enabling the sqlite-backed NSS databases r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Wed, 06 Sep 2017 14:31:27 -0700 - rev 430274
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1398932 - add a preference for enabling the sqlite-backed NSS databases r=Cykesiopka,jcj In the future, bug 1377940 will make the sqlite-backed databases the default, but until we're sure this will stick we want to be able to control this with a Firefox-only change. The use of a preference to configure which format to use will hopefully allow us to restore the old behavior quickly and relatively safely if necessary. Note that doing this should be done with care; any changes made in the sqlite databases after upgrade migration will not be reflected if we need to go back to the old database format. Thus, user data (imported CAs, client certificates, and keys) can be lost. MozReview-Commit-ID: tkovdiCU9v
75e4a2e292967513f19c32c59d104df0f49a1cb3: bug 1397471 - nsNSSCertificateDB::GetCerts needs to wait until the loadable roots have been loaded r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 06 Sep 2017 14:29:17 -0700 - rev 428982
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1397471 - nsNSSCertificateDB::GetCerts needs to wait until the loadable roots have been loaded r=Cykesiopka This was missed in the original implementation of bug 1372656. MozReview-Commit-ID: 8Sm26YlxZ7l
73af09f7cb84c174f6608a545956d424866cfdc4: bug 1393143 - remove a few unused attributes and methods on PKCS#11 interfaces r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Thu, 17 Aug 2017 16:11:57 -0700 - rev 428562
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1393143 - remove a few unused attributes and methods on PKCS#11 interfaces r=Cykesiopka MozReview-Commit-ID: FKO6G6ZKjAZ
192a101ff358f923fd99d5413a9cb1be816f1306: bug 1389664 - centralize on-demand empty pin initialization of the user's NSS database r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Tue, 18 Jul 2017 15:05:58 -0700 - rev 426173
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1389664 - centralize on-demand empty pin initialization of the user's NSS database r=Cykesiopka,jcj The sqlite-backed NSS database implementation requires explicitly setting some kind of pin (password, really). To maintain behavior compatibility with the old database implementation, we set the pin to the empty string as necessary. Previously this would only happen on Android (NSS_DISABLE_DBM builds), but because we're moving towards using the sqlite-backed implementation on all platforms, we should enable this code everywhere and move it to a more central location. This also fixes some now-unnecessary test behavior. MozReview-Commit-ID: KKtxmvOZt78
c76c0f1fadfe1f981f1fe1e9ddaafb5bf80ef602: bug 1391404 - fold nsIPKCS11 into nsIPKCS11ModuleDB r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 16 Aug 2017 17:06:59 -0700 - rev 425699
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1391404 - fold nsIPKCS11 into nsIPKCS11ModuleDB r=Cykesiopka This also moves the implementation of nsIPKCS11ModuleDB into its own file. MozReview-Commit-ID: LYXixzbx3Ia
ad20fd5faada2aedfea3e290c7501b8f6edff3c3: bug 1372656 - load loadable roots on a background thread r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 08 Jun 2017 16:10:00 -0700 - rev 422956
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
bug 1372656 - load loadable roots on a background thread r=Cykesiopka,jcj In a profile, loading the loadable roots PKCS#11 module (i.e. the built-in root CA module) accounted for about 60% of the time to initialize PSM/NSS. Since we only need the roots module loaded when we're actually looking for an issuing certificate or querying a certificate's trust, we can do the load asynchronously (where it hopefully finishes before we actually need it, because otherwise we'll have to wait anyway). MozReview-Commit-ID: JyY6NtpQAUj
ac03688d438263275bd4c1b5dd801a41cc786847: bug 1382866 - prompt for authentication when changing certificate trust fails r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Fri, 21 Jul 2017 16:58:42 -0700 - rev 419899
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1382866 - prompt for authentication when changing certificate trust fails r=Cykesiopka,jcj MozReview-Commit-ID: 3ryUyAfbNCs
0bb5555fa0272b604f6048f7385aa26e76655615: bug 1375709 - avoid deadlock when shutting down NSS r=Cykesiopka,ttaubert
David Keeler <dkeeler@mozilla.com> - Mon, 10 Jul 2017 16:25:51 -0700 - rev 417724
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1375709 - avoid deadlock when shutting down NSS r=Cykesiopka,ttaubert The deadlock fix attempted in bug 1273475 was incomplete. This should prevent the issue by preventing nsNSSShutDownPreventionLocks from attempting to increment the NSS activity state count when shutdown is in progress (this is acceptible because when code that creates any nsNSSShutDownPreventionLocks then checks isAlreadyShutDown(), it will return true because sInShutdown is true, thus preventing that code from unsafely using NSS resources and functions). MozReview-Commit-ID: 4o5DGbU2TCq
b274e6e81c8bd890dade81be1e989226ccad9fd2: Bug 1368652 - Use Mozilla string types to display OIDs in the certificate viewer. r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Thu, 01 Jun 2017 12:26:41 -0700 - rev 415074
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1368652 - Use Mozilla string types to display OIDs in the certificate viewer. r=Cykesiopka
def0cd765925f547ab60ac5647253578e4a56e26: bug 1291886 - clarify/fix locking in nsNSSComponent r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 08 Jun 2017 14:49:13 -0700 - rev 413430
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1291886 - clarify/fix locking in nsNSSComponent r=Cykesiopka,jcj Some of the locking in nsNSSComponent was inconsistent and/or just wrong. This clarifies what is protected by the lock and makes sure it is consistently acquired when those resources are accessed. This should also address potential deadlocks when other code would attempt to acquire nsNSSComponent resources during shutdown. This patch also removes some items in nsNSSComponent that are no longer relevant. MozReview-Commit-ID: 9iA5lfAixpj
2c89fdad73e084f634a00cc19877389ea77f402e: bug 1373068 - fix the ctypes declaration of SSL_ClearSessionCache in head_psm.js r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 14 Jun 2017 15:10:28 -0700 - rev 412936
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
bug 1373068 - fix the ctypes declaration of SSL_ClearSessionCache in head_psm.js r=Cykesiopka SSL_ClearSessionCache is `void SSL_ClearSessionCache()`. In head_psm.js it was being declared as `SECStatus SSL_ClearSessionCache()` and the "return value" was being checked, which was incorrect. This apparently wasn't causing failures on any of our test runs, but with tsan enabled the check would fail. MozReview-Commit-ID: 6KosOVPu8K4
3582719c52defa9de66c4aa7c9bd8e8651cf9ae8: Bug 1368652 - Use Mozilla string types to display OIDs in the certificate viewer. r=Cykesiopka a=al
David Keeler <dkeeler@mozilla.com> - Thu, 01 Jun 2017 12:26:41 -0700 - rev 411788
Push 7462 by cbook@mozilla.com at Thu, 29 Jun 2017 07:50:44 +0000
Bug 1368652 - Use Mozilla string types to display OIDs in the certificate viewer. r=Cykesiopka a=al
76a620a287bfa2bf79971613d2a28093c687c65b: bug 1369911 - gather telemetry on the prevalence of 3rd party PKCS#11 modules r=bsmedberg,Cykesiopka data-review=bsmedberg
David Keeler <dkeeler@mozilla.com> - Fri, 02 Jun 2017 16:44:06 -0700 - rev 411208
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1369911 - gather telemetry on the prevalence of 3rd party PKCS#11 modules r=bsmedberg,Cykesiopka data-review=bsmedberg MozReview-Commit-ID: Dw99Jm64QNU
600b709c2634cfd9d57f0eefd56af8d1200791c9: bug 1364159 - potentially avoid calling CERT_CreateSubjectCertList in NSSCertDBTrustDomain::FindIssuer r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 11 May 2017 16:41:12 -0700 - rev 408296
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1364159 - potentially avoid calling CERT_CreateSubjectCertList in NSSCertDBTrustDomain::FindIssuer r=Cykesiopka,jcj CERT_CreateSubjectCertList is not an inexpensive function call, since it enumerates the certificate database (i.e. reads from disk a lot). If we're verifying for a TLS handshake, however, we should already have in memory a certificate chain sent by the peer (there are some cases where we won't, such as session resumption (see bug 731478)). If we can, we should use those certificates before falling back to calling CERT_CreateSubjectCertList. MozReview-Commit-ID: ASjVGsELb1O
ee365962dce7e2988f316f39e622b298050fd212: bug 1349312 - part 2/2: add pyct.py and generate test certificate transparency information r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Mon, 17 Apr 2017 14:55:35 -0700 - rev 404358
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1349312 - part 2/2: add pyct.py and generate test certificate transparency information r=Cykesiopka,jcj MozReview-Commit-ID: 9Htv04PfRzb This introduces pyct.py with the capability of generating Signed Certificate Timestamps for our test certificates. Also introduces a simple testcase that should validate correctly under current CT requirements as well as one that does not validate due to an insufficient number of SCTs. (Note that "validate" in this case does not refer to the overall TLS handshake result, because CT is not currently required. It more or less refers to the value of certificateTransparencyStatus of the SSLStatus of the connection's securityInfo - see nsISSLStatus.idl.)
86fecaba102e114f4da2552ace8c4aec4d45f008: bug 1349312 - part 1/2: patch CT implementation to include debug-only test logs r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Wed, 19 Apr 2017 14:02:26 -0700 - rev 404357
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1349312 - part 1/2: patch CT implementation to include debug-only test logs r=Cykesiopka,jcj MozReview-Commit-ID: Gay4bliuiDc This modifies getCTKnownLogs.py to inject 3 debug-only Certificate Transparency log keys and 2 organizations ("Mozilla Test Org 1" and "2") for use with integration tests. Also updates CTKnownLogs.h as generated by the python script. The debug logs use the "default", "secp256r1", and "alternate" keys that are already present in our testing infrastructure (see pykey.py).
9daa585e4e9abc2957129599cc68624d96b307f7: bug 1337950 - work around failing to load a FIPS PKCS#11 module DB in NSS initialization r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 20 Apr 2017 10:31:22 -0700 - rev 403534
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1337950 - work around failing to load a FIPS PKCS#11 module DB in NSS initialization r=Cykesiopka,jcj Firefox essentially does not support running NSS in FIPS mode any longer. This has always been the case on Android from what I can tell and it has been the case on OS X since at least version 34 (see bug 1047584). It became the case on Windows as of version 53 (see bug 1295937). Unfortunately, before this patch, if a user attempted to run an affected version of Firefox using a profile directory containing an NSS database collection that had FIPS enabled, NSS initialization would fail and fall back to running in no DB mode, which had the side-effect of making any saved passwords and certificates unavailable. This patch attempts to detect and work around this failure mode by moving the PKCS#11 module DB (which is where the FIPS bit is set) to a backup location and basically running with a fresh, non-FIPS module DB. This allows Firefox to initialize NSS with the preexisting key and certificate databases available. MozReview-Commit-ID: 1E4u1ngZyRv
d0e27739f47519e531fd86e2f594a2c955751a51: bug 1352262 - make OCSP timeout values configurable r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Fri, 31 Mar 2017 15:21:40 -0700 - rev 401592
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1352262 - make OCSP timeout values configurable r=Cykesiopka,jcj The default OCSP timeout for soft-fail DV is still 2 seconds. This patch makes it configurable on the interval (0, 5] seconds. The default OCSP timeout for EV and hard-fail DV is still 10 seconds. This patch makes it configurable on the interval (0, 20] seconds. MozReview-Commit-ID: CPd8pwYrJhj
7c1d15e5f6b014dd6b8a247efe012db74c654a4f: bug 1349762 - handle two GlobalSign EV root transfers r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Mon, 03 Apr 2017 17:17:38 -0700 - rev 400832
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1349762 - handle two GlobalSign EV root transfers r=Cykesiopka,jcj (adapted from bug 1349762 comment 0) Google Trust Services (GTS) recently purchased two roots from GlobalSign that are both enabled for EV treatment: "GlobalSign Root CA - R2" and "GlobalSign ECC Root CA - R4". However, GTS does not have an EV audit, so we are going to turn off EV treatment for both of those root certificates. But "GlobalSign Root CA - R2" has intermediate cert "GlobalSign Extended Validation CA - SHA256 - G2" that continues to be controlled by GlobalSign, to be used to migrate their customers off dependence on that root. This patch removes EV treatment for "GlobalSign ECC Root CA - R4". It also removes EV treatment for all chains rooted in "GlobalSign Root CA - R2" unless the "GlobalSign Extended Validation CA - SHA256 - G2" intermediate is in the chain. MozReview-Commit-ID: Ej9L9zTwoPN
e87ffc90adf09391144f610ca22cf6fdf3d1d596: bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Thu, 30 Mar 2017 11:00:54 -0700 - rev 398899
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka MozReview-Commit-ID: 2DlMrB5TfKU
e46f832ac2627483037c2fbc2dc20075e352fd61: bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Thu, 30 Mar 2017 11:00:54 -0700 - rev 398878
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka MozReview-Commit-ID: 2DlMrB5TfKU
67e5ea975d53131939ef6d399ff1558fd9475c0f: bug 1347859 - prevent dialog overflow in certificate exception dialog by resizing to content r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Thu, 30 Mar 2017 14:00:29 -0700 - rev 398876
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1347859 - prevent dialog overflow in certificate exception dialog by resizing to content r=Cykesiopka MozReview-Commit-ID: HDjE9QldcxF
e8c4477db9bd24d48ca0069b77c10417bf4ddad3: bug 1345612 - avoid calling NS_NewURI on IP addresses when checking certificate overrides r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Mon, 20 Mar 2017 13:42:27 -0700 - rev 397708
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1345612 - avoid calling NS_NewURI on IP addresses when checking certificate overrides r=Cykesiopka When determining if a certificate error override is allowed for a host, we consult nsISiteSecurityService::IsSecureURI to see if the host is HSTS/HPKP. This API takes an nsIURI, but the calling code only has a hostname as an nsCString. Calling NS_NewURI works in all situations we will encounter except when the hostname is an IPv6 address. Since IP addresses are never HSTS/HPKP anyway, we can skip the NS_NewURI / IsSecureURI calls in those cases as a workaround. MozReview-Commit-ID: JXa8cGvqqTA
9d6095db50904cafcd4756903e181ba376d923dc: bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert
David Keeler <dkeeler@mozilla.com> - Mon, 13 Mar 2017 15:26:40 -0700 - rev 396842
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert MozReview-Commit-ID: 5bUTLz6mGKC In general, it is possible to create a new nsNSSShutDownObject after nsNSSShutDownList::shutdown() had been called. Before this patch, at that point, isAlreadyShutDown() would incorrectly return false, which could lead to code calling NSS functions, which would probably lead to a crash (because NSS could be uninitialized at that point). This change merges nsNSSShutDownList::shutdown() with evaporateAllNSSResources() into evaporateAllNSSResourcesAndShutDown() for simplicity and makes it so isAlreadyShutDown() returns true if called after that point.
9ba79bf5e771b08b5b7e93f424f9c88083679eee: bug 1339921 - disable clang's shadowed field warning in a mozilla::pkix gtest class r=Cykesiopka,dholbert
David Keeler <dkeeler@mozilla.com> - Tue, 14 Mar 2017 15:58:04 -0700 - rev 396115
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1339921 - disable clang's shadowed field warning in a mozilla::pkix gtest class r=Cykesiopka,dholbert pkixocsp_VerifyEncodedResponse_GetCertTrust has a field trustDomain that deliberately shadows the field it inherits from so that code doesn't use it by accident. MozReview-Commit-ID: 1Y4W6sA7lHD
58ae9ceae8251bdc4f6058aaa38765d0f6581b52: bug 1239344 - remove error alert for successful PKCS12 operations r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 03 Mar 2017 11:12:54 -0800 - rev 395521
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1239344 - remove error alert for successful PKCS12 operations r=Cykesiopka MozReview-Commit-ID: Hr6s2v2GmZQ
06328362721a1629dd00c3a5ce2a9dcfb0dd0296: bug 1339267 - re-work NSS initialization wrt thread/process etc. r=Cykesiopka,jcj
David Keeler <dkeeler@mozilla.com> - Thu, 09 Feb 2017 16:25:55 -0800 - rev 394977
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
bug 1339267 - re-work NSS initialization wrt thread/process etc. r=Cykesiopka,jcj MozReview-Commit-ID: 2U4c8Xgf0bv
2b04c29e7c67e87c8d3dde9b1b9986d43f9b99d7: Bug 1310127 - Part 2: Use MOZ_MUST_USE in netwerk/protocol/http r=Cykesiopka,mcmanus
Wei-Cheng Pan <wpan@mozilla.com> - Tue, 27 Dec 2016 19:05:13 +0800 - rev 394273
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1310127 - Part 2: Use MOZ_MUST_USE in netwerk/protocol/http r=Cykesiopka,mcmanus Log failures or just ignore them, no control flow change. MozReview-Commit-ID: D748DEjl3Fv
6d31880f7b72213e9663f1208fec400e7e5a0b8d: Bug 1337950 - Work around failing to load a FIPS PKCS#11 module DB in NSS initialization. r=Cykesiopka, r=jcj, a=gchang
David Keeler <dkeeler@mozilla.com> - Thu, 20 Apr 2017 10:31:22 -0700 - rev 393876
Push 7286 by ryanvm@gmail.com at Mon, 08 May 2017 19:19:24 +0000
Bug 1337950 - Work around failing to load a FIPS PKCS#11 module DB in NSS initialization. r=Cykesiopka, r=jcj, a=gchang Firefox essentially does not support running NSS in FIPS mode any longer. This has always been the case on Android from what I can tell and it has been the case on OS X since at least version 34 (see bug 1047584). It became the case on Windows as of version 53 (see bug 1295937). Unfortunately, before this patch, if a user attempted to run an affected version of Firefox using a profile directory containing an NSS database collection that had FIPS enabled, NSS initialization would fail and fall back to running in no DB mode, which had the side-effect of making any saved passwords and certificates unavailable. This patch attempts to detect and work around this failure mode by moving the PKCS#11 module DB (which is where the FIPS bit is set) to a backup location and basically running with a fresh, non-FIPS module DB. This allows Firefox to initialize NSS with the preexisting key and certificate databases available. MozReview-Commit-ID: 1E4u1ngZyRv
a6be6249c4648b95c18f4d0f36024c026e19ed16: Bug 1345612 - avoid calling NS_NewURI on IP addresses when checking certificate overrides r=Cykesiopka, a=gchang
David Keeler <dkeeler@mozilla.com> - Mon, 20 Mar 2017 13:42:27 -0700 - rev 393121
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
Bug 1345612 - avoid calling NS_NewURI on IP addresses when checking certificate overrides r=Cykesiopka, a=gchang When determining if a certificate error override is allowed for a host, we consult nsISiteSecurityService::IsSecureURI to see if the host is HSTS/HPKP. This API takes an nsIURI, but the calling code only has a hostname as an nsCString. Calling NS_NewURI works in all situations we will encounter except when the hostname is an IPv6 address. Since IP addresses are never HSTS/HPKP anyway, we can skip the NS_NewURI / IsSecureURI calls in those cases as a workaround. MozReview-Commit-ID: JXa8cGvqqTA
316ec3452a611f5c3bd9d400fe0cecd1db001752: Bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert a=gchang
David Keeler <dkeeler@mozilla.com> - Mon, 13 Mar 2017 15:26:40 -0700 - rev 393117
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
Bug 1344478 - isAlreadyShutDown should return true for nsNSSShutDownObjects created after NSS shut down r=Cykesiopka,ttaubert a=gchang MozReview-Commit-ID: 5bUTLz6mGKC In general, it is possible to create a new nsNSSShutDownObject after nsNSSShutDownList::shutdown() had been called. Before this patch, at that point, isAlreadyShutDown() would incorrectly return false, which could lead to code calling NSS functions, which would probably lead to a crash (because NSS could be uninitialized at that point). This change merges nsNSSShutDownList::shutdown() with evaporateAllNSSResources() into evaporateAllNSSResourcesAndShutDown() for simplicity and makes it so isAlreadyShutDown() returns true if called after that point.
df65d15b648daef67f1a76987c21f4fe9b23bdb7: bug 1294580 - prevent end-entity certificates from being their own trust anchors r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 24 Feb 2017 12:32:41 -0800 - rev 391735
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1294580 - prevent end-entity certificates from being their own trust anchors r=Cykesiopka MozReview-Commit-ID: KaZaFG8AWwl
9f8bb076c706884356998c48d4e3a79678735a3a: Bug 1323644 - Isolate the HSTS and HPKP storage by first party domain (PSM) r=Cykesiopka,keeler
Jonathan Hao <jhao@mozilla.com> - Tue, 14 Feb 2017 10:29:10 +0800 - rev 390496
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
Bug 1323644 - Isolate the HSTS and HPKP storage by first party domain (PSM) r=Cykesiopka,keeler MozReview-Commit-ID: HhFFqtpBNjO
c09eb845f9beea44e275a7d82877f7c62bf494ce: bug 1338701 - constify all TransportSecurityPreloads, use mozilla::BinarySearch over bsearch r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 10 Feb 2017 15:52:26 -0800 - rev 389190
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1338701 - constify all TransportSecurityPreloads, use mozilla::BinarySearch over bsearch r=Cykesiopka MozReview-Commit-ID: Lu3H9SpyJgR
19cd77acf2e0cf418224ecea75078d40dcf6e0da: bug 1335576 - stop passing nsINSSComponent around everywhere in nsNSSCertHelper.cpp r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Tue, 31 Jan 2017 14:08:56 -0800 - rev 387604
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1335576 - stop passing nsINSSComponent around everywhere in nsNSSCertHelper.cpp r=Cykesiopka MozReview-Commit-ID: LW4JEnvh1tR
2b15133c98cc855a553551cc50c8d66ef48d1fdf: bug 1335576 - run clang-format on nsNSSCertHelper.cpp r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Tue, 31 Jan 2017 13:23:55 -0800 - rev 387603
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1335576 - run clang-format on nsNSSCertHelper.cpp r=Cykesiopka MozReview-Commit-ID: 61ocKUdur9G
3a1ed6f4ed6aba725e85f8170cc13a25ca02cfe3: Bug 1122973 - Use templates instead of macros for NSS module factory constructors. r=Cykesiopka,keeler
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Sat, 28 Jan 2017 11:10:42 +0900 - rev 387557
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
Bug 1122973 - Use templates instead of macros for NSS module factory constructors. r=Cykesiopka,keeler MozReview-Commit-ID: EcnOKgruorA
da9c1e0ddf0fe3997cdd30c648b4d67b954eab0e: bug 1334694 - remove token arguments from nsIX509CertDB.importPKCS12File and exportPKCS12File r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Fri, 27 Jan 2017 15:26:20 -0800 - rev 378375
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1334694 - remove token arguments from nsIX509CertDB.importPKCS12File and exportPKCS12File r=Cykesiopka MozReview-Commit-ID: Ceo48mcF38I
ccfc55b6b0e073b57d592849df2484ba15d08d72: bug 1334321 - add test for nsISecretDecoderRing using existing key database r=Cykesiopka
David Keeler <dkeeler@mozilla.com> - Wed, 25 Jan 2017 15:34:21 -0800 - rev 378047
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
bug 1334321 - add test for nsISecretDecoderRing using existing key database r=Cykesiopka MozReview-Commit-ID: Fk8bC78QJzo