searching for reviewer(cpearce)
4b635d928b2bd42890ffc97c55622072092351e9: Bug 1549544 - Use the 'cenc' init data type when encountering cbcs media. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 14 May 2019 02:31:47 +0000 - rev 532860
Push 11272 by apavel@mozilla.com at Thu, 16 May 2019 15:28:22 +0000
Bug 1549544 - Use the 'cenc' init data type when encountering cbcs media. r=cpearce When encountering media using the common encryption format (mp4s containing pssh boxes), the encrypted event we fire should specify the cenc init data type. Fixes a bug where for cbcs the 'cbcs' init data type was used -- which is a bogus value. Differential Revision: https://phabricator.services.mozilla.com/D30095
a14a4e0b60ebc2ca635bbc777474cf2fa8cbc62d: Bug 1544602 - Make media.gmp.insecure.allow an atomic. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 16 Apr 2019 22:20:10 +0000 - rev 528699
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544602 - Make media.gmp.insecure.allow an atomic. r=cpearce Since this pref can be accessed from the GMP thread (per the bug), it should be an atomic. See bug 1465852 for the code the added the assertion hit in this bug, as well as further context as to why this should be an atomic. Differential Revision: https://phabricator.services.mozilla.com/D27831
46235152b24e33c652c4e94430897369bbb2090b: Bug 1525209 - Revert spec-incompliant pause event from bug 1461877. r=cpearce
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Apr 2019 09:57:59 +0000 - rev 528670
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1525209 - Revert spec-incompliant pause event from bug 1461877. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D27864
a38b2423065cdf70dd8db23a468c23de1d3b88dd: Bug 1538206 - Update comments in MediaKeySystemAccess to reflect current numbering in spec. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 16 Apr 2019 19:38:46 +0000 - rev 528607
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538206 - Update comments in MediaKeySystemAccess to reflect current numbering in spec. r=cpearce The spec referenced in the comments in code has been updated since the code was originally written. As such, some of the sections referenced in code comments now have different numbering. Update the comments to reflect this. Differential Revision: https://phabricator.services.mozilla.com/D27726
8e1aac075975dd109f48d5ad766c713c6f304af5: Bug 1542921 - turn on block autoplay by default. r=cpearce
alwu <alwu@mozilla.com> - Tue, 09 Apr 2019 23:43:33 +0000 - rev 527499
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542921 - turn on block autoplay by default. r=cpearce As we have successfully rolled out the feature via Normandy in 66, we should turn the feature on in >= 67 to not have to rely on Normandy going forward any more. Differential Revision: https://phabricator.services.mozilla.com/D26713
e217cf252bb06d2c4f4e61b49ccd1e77614a54df: Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:49 +0000 - rev 527398
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce - Watch for if a proxy shuts down during init and if so, shutdown the CDM parent that is being initialized. - Make ChromiumCDMParent only store a pointer to a ChromiumCDMProxy when it has successfully initialized. This avoid the lopsided relationship where a if a ChromiumCDMParent fails to initialize it may keep a pointer to a proxy, but the proxy will never have a reference to that CDM parent. Differential Revision: https://phabricator.services.mozilla.com/D26208
f09291096c4f9589a14f43468a04970202ae2468: Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:19 +0000 - rev 527397
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D26207
7178347182f50db3fce7af4910e97274d11cb7fa: Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:59 +0000 - rev 527396
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce This code is calling other code that expects to be on the main thread, and having this on the main thread (now that the main thread is a serial event target) makes it easier to reason about this and other main thread code. I.e. this cannot be running during other main thread code. Differential Revision: https://phabricator.services.mozilla.com/D26206
bc7e92510e95a39fef9f9fc32224c416e9d6f11f: Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:38 +0000 - rev 527395
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce This gives us greater flexibility in using the main thread member to run promises. The site where we obtain the main thread returns a serial event target, so we're not doing much more work here, we're just keeping the serial event target interface, rather than converting to an event target interface. Differential Revision: https://phabricator.services.mozilla.com/D26205
7c83e08566d34fe194069a5219a16755d1cbe757: Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:05:01 +0000 - rev 527394
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce Also remove unneeded MOZ_COUNT_[CTOR|DTOR] macros. We already get similar functionality from NS_INLINE_DECL_THREADSAFE_REFCOUNTING. Differential Revision: https://phabricator.services.mozilla.com/D26204
72c34a51659693fb9106e9df3488929d9a8a2117: Bug 1535010 - avoid unnecessary gmp directory creations during startup, r=cpearce.
Florian Quèze <florian@queze.net> - Thu, 28 Mar 2019 00:06:29 +0000 - rev 525367
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535010 - avoid unnecessary gmp directory creations during startup, r=cpearce. Differential Revision: https://phabricator.services.mozilla.com/D23320
1694fdeb8a6ad706eb77001076bb6f0ba95a577a: Bug 1525209 - Revert spec-incompliant pause event from bug 1461877. r=cpearce a=pascalc
Andreas Pehrson <apehrson@mozilla.com> - Wed, 17 Apr 2019 09:57:59 +0000 - rev 523246
Push 11115 by aiakab@mozilla.com at Fri, 19 Apr 2019 16:14:22 +0000
Bug 1525209 - Revert spec-incompliant pause event from bug 1461877. r=cpearce a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D27864
5710827ee9cf5011b6698590a7d31e922f636cf2: Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:49 +0000 - rev 523226
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1540136 - P5: Handle if ChromiumCDMProxy is shutdown in the middle of init. r=cpearce a=lizzard - Watch for if a proxy shuts down during init and if so, shutdown the CDM parent that is being initialized. - Make ChromiumCDMParent only store a pointer to a ChromiumCDMProxy when it has successfully initialized. This avoid the lopsided relationship where a if a ChromiumCDMParent fails to initialize it may keep a pointer to a proxy, but the proxy will never have a reference to that CDM parent. Differential Revision: https://phabricator.services.mozilla.com/D26208
ecb3ee5969c19fe8c52cedb2bd0291edf11dc83c: Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:07:19 +0000 - rev 523225
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1540136 - P4: Remove ChromiumCDMParent mMainThread as it is unused. r=cpearce a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D26207
385fde9e64e20795ca20d6cb7db114b0c0bcc8fe: Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:59 +0000 - rev 523224
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1540136 - P3: ChromiumCDMProxy runs CDM init thennable code on the main thread. r=cpearce a=lizzard This code is calling other code that expects to be on the main thread, and having this on the main thread (now that the main thread is a serial event target) makes it easier to reason about this and other main thread code. I.e. this cannot be running during other main thread code. Differential Revision: https://phabricator.services.mozilla.com/D26206
48e7d2342ffa2f1bc57853dcd0c3a8e4ca838c42: Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:06:38 +0000 - rev 523223
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1540136 - P2: CDMProxy stores main thread as nsISerialEventTarget, rather than nsIEventTarget. r=cpearce a=lizzard This gives us greater flexibility in using the main thread member to run promises. The site where we obtain the main thread returns a serial event target, so we're not doing much more work here, we're just keeping the serial event target interface, rather than converting to an event target interface. Differential Revision: https://phabricator.services.mozilla.com/D26205
40fb1ced2598f5f2372a29819baaab5c5aab8208: Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce a=lizzard
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 09 Apr 2019 15:05:01 +0000 - rev 523222
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1540136 - P1: Log more info in ChromiumCDMProxy dtor and Shutdown. r=cpearce a=lizzard Also remove unneeded MOZ_COUNT_[CTOR|DTOR] macros. We already get similar functionality from NS_INLINE_DECL_THREADSAFE_REFCOUNTING. Differential Revision: https://phabricator.services.mozilla.com/D26204
778c3da2f7ae901e6cb55115217f8fb32a798bae: Bug 1542921 - turn on block autoplay by default. r=cpearce a=pascalc
alwu <alwu@mozilla.com> - Tue, 09 Apr 2019 23:43:33 +0000 - rev 523127
Push 11064 by apavel@mozilla.com at Thu, 11 Apr 2019 08:46:03 +0000
Bug 1542921 - turn on block autoplay by default. r=cpearce a=pascalc As we have successfully rolled out the feature via Normandy in 66, we should turn the feature on in >= 67 to not have to rely on Normandy going forward any more. Differential Revision: https://phabricator.services.mozilla.com/D26713
062f54735111d741f9189f2c15e2b4da740783fa: Bug 1522547 - Have MediaKeys observe if the owning document becomes inactive so it can shutdown. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:21:40 +0000 - rev 520333
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Have MediaKeys observe if the owning document becomes inactive so it can shutdown. r=cpearce MediaKeys objects are typically created and associated with an HTMLMediaElement, however it is possible to create a MediaKeys object and not associate it with an HTMLMediaElement. This resulted in an issue where these MediaKeys would keep alive other components that would assert during bowrser shutdown (see bug 1522547). We anticipated that MediaKeys associated with an HTMLMediaElement would need to be shutdown if their owning document became inactive, but were not handling the case where the keys never became associated with an element. This patch has the MediaKeys listen directly to their owning document for activity change. The MediaKeys will shutdown if their document becomes inactive. This avoids MediaKeys not associated with HTMLMediaElements keeping other objects alive during browser shutdown. Differential Revision: https://phabricator.services.mozilla.com/D21983
153245ec86c26f88beba43d7858cf5c517e22d84: Bug 1522547 - Log in MediaKeySession dtor. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:21:30 +0000 - rev 520332
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Log in MediaKeySession dtor. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D21982
c273b07bc5f06aa68c6d8d2ce7074941a9075cad: Bug 1522547 - Add more logs to MediaKeys, use PRIu32 for printing where appropriate. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:21:28 +0000 - rev 520331
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Add more logs to MediaKeys, use PRIu32 for printing where appropriate. r=cpearce - Add more logging to MediaKeys. - Replace the instances of the %d formatter with PRIu32 when printing the PromiseId type (which has the underlying uint32_t type). Differential Revision: https://phabricator.services.mozilla.com/D21981
c092112f933effac6fbedd252a99bc0fdf0f9411: Bug 1522547 - Log `this` in ChromiumCDMProxy logs, use PRIu32 where appropriate. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:21:24 +0000 - rev 520330
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Log `this` in ChromiumCDMProxy logs, use PRIu32 where appropriate. r=cpearce Because multiple ChromiumCDMProxy object may exist during a browser lifetime, logging the value of `this` in their logs is useful for disambiguating log statements, as well as matching ChromiumCDMProxy objects to pointers held by other objects. Update formatter usage in logs to prefer PRIu32 over %u when the underlying type is uint32_t. Differential Revision: https://phabricator.services.mozilla.com/D21980
7e199486530b42d3b366883770197f03f143f924: Bug 1522547 - Differentiate GMPServiceParent and GMPServiceChild __CLASS__ macro. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:21:20 +0000 - rev 520329
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Differentiate GMPServiceParent and GMPServiceChild __CLASS__ macro. r=cpearce The macros in these classes are used to output class names in logs. Differentiating them helps make logs clearer. Differential Revision: https://phabricator.services.mozilla.com/D21979
6f4b04b69f8073c7c7a9cdfb3bfc511dec887105: Bug 1522547 - Add logging to GMPContentParent. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 16:19:43 +0000 - rev 520328
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522547 - Add logging to GMPContentParent. r=cpearce Use GMPLog.h in GMPContentPareant. Add logging to most functions. This logging was added to aid in diagnosing a shutdown crash, but should be generally useful to have. Driveby touchup of arg name to ChromiumCDMDestroyed to match header. Differential Revision: https://phabricator.services.mozilla.com/D21978
0bd2a637efa3b877d7145fe9d186afa6550e3ef2: Bug 1532354 - Remove virtual keyword on GMPServiceChild|GMPServiceParent::GetContentParent. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 00:32:07 +0000 - rev 520248
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532354 - Remove virtual keyword on GMPServiceChild|GMPServiceParent::GetContentParent. r=cpearce These functions already specify the override keyword. This change also makes them more consistent with the overloaded versions of the same functions in these classes. Depends on D21968 Differential Revision: https://phabricator.services.mozilla.com/D21975
65fc1cf8774f32b733ec0235adb1f61677fdff5f: Bug 1532354 - Remove unused DeleteGMPServiceParent class. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 00:31:27 +0000 - rev 520247
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532354 - Remove unused DeleteGMPServiceParent class. r=cpearce Bug 1352924 removed the usage of this class, so we can safely remove the dead code. Differential Revision: https://phabricator.services.mozilla.com/D21968
c1e80167030701714306b8e18a4b8d3ac49187aa: Bug 1532354 - Remove GMPServiceParent::ProcessPossiblePlugin decl as it is unimplemented. r=cpearce
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 05 Mar 2019 00:30:13 +0000 - rev 520246
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1532354 - Remove GMPServiceParent::ProcessPossiblePlugin decl as it is unimplemented. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D21967
07c49703b70c4cd01985771942e84aa37a66663c: Bug 1530220 - part4 : separate tesing web audio with gum to another test. r=cpearce
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:13:55 +0000 - rev 520209
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530220 - part4 : separate tesing web audio with gum to another test. r=cpearce Testing web audio with GUM is not related with the original purpose of this test. In order to reduce the complexity of this test, separate this part as another new test. Also modify the naming of functions, because Mozilla coding style is to use the camelCase for the name. Differential Revision: https://phabricator.services.mozilla.com/D21257
f706441a86b530d30be4fba47bff43f96ade97cb: Bug 1530220 - part2 : modify test in order to test different kinds of keycode. r=cpearce
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:09:50 +0000 - rev 520207
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530220 - part2 : modify test in order to test different kinds of keycode. r=cpearce Except printable keys, we would treat `carriage return` and `space` as supported user gesture inputs for activating document. Other keys won't activate document. Differential Revision: https://phabricator.services.mozilla.com/D21255
7c1b053e161b0795c83fc39289a8d4335b146127: Bug 1530220 - part1 : allow some non-printalble keys as supported user gesture inputs to activate document. r=masayuki,cpearce
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:06:22 +0000 - rev 520206
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1530220 - part1 : allow some non-printalble keys as supported user gesture inputs to activate document. r=masayuki,cpearce `carriage return` and `space` are common keys which user might use to start media, so we should take account them as supported user gesture inputs. As their pseudo char code are zero, we have to check their key code in order to distinguish them from other controls keys such as shift, alt... Differential Revision: https://phabricator.services.mozilla.com/D21253
6e3eb5df50ff8607f0f60e8f7f8b9ed573f74fa4: Bug 1526355 - part1 : notify the front end side to show the blocking icon if the site is still being blocked after it's back from the bfcache. r=cpearce
Alastor Wu <alwu@mozilla.com> - Mon, 04 Mar 2019 17:25:52 +0000 - rev 520123
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1526355 - part1 : notify the front end side to show the blocking icon if the site is still being blocked after it's back from the bfcache. r=cpearce In order to display blocking icon when the document comes back from the bfcache, we have to notify front end what's the current blocking status. As the front end side would clear blocking autoplay information when nagivation occurs, and the media might not invoke the play again when they comes back from the bfcache. Therefore, we should notify front end side that the site is still being blocked, and we should show blocking icon for it. Differential Revision: https://phabricator.services.mozilla.com/D21582
62d4e16fbb2b655a82418553929c9883279273a5: Bug 1531500 - Fix HE-AAC with WMF decoder. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 01 Mar 2019 00:54:32 +0000 - rev 519723
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1531500 - Fix HE-AAC with WMF decoder. r=cpearce The rate changes after decoding the first sample to what was indicated in the container. The code to handle that case was incorrectly removed in bug 1530234 Differential Revision: https://phabricator.services.mozilla.com/D21618
0a003a54ff4554cb8b68f3f0d54a6bd3ef166c16: Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds. r=cpearce,janerik
Alastor Wu <alwu@mozilla.com> - Tue, 26 Feb 2019 04:44:19 +0000 - rev 519109
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525156 - part2 : Add Telemetry to know how many autoplay media, which has been resumed from blocked, played exactly 7 secocnds or more, or less than 7 seconds. r=cpearce,janerik By adding the Telemetry to measure the number of video/audio which played exactly 7 seconds or more, or less than 7 seconds, after those media has been resumed from blocked state, we can know how many media would meet the Chrome's MEI condition, which could help us to know more about the whole landscape of autoplay media. In addition, it could help us know how many media are played 'by users intention' because we assume that users are more likely to stop the media if autoplay media is unblocked by accident. Differential Revision: https://phabricator.services.mozilla.com/D18628
adb554a755e5c3e3c4280d6de251e470aff7223c: Bug 1525156 - part1 : not dispatch event when play is rejected by AudioChannelAgent. r=cpearce
Alastor Wu <alwu@mozilla.com> - Thu, 21 Feb 2019 22:52:57 +0000 - rev 519108
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1525156 - part1 : not dispatch event when play is rejected by AudioChannelAgent. r=cpearce "blocked" event is used for blocking autoplay. The `AudioChannelAgentBlockedPlay()` returns true when we lost audio focus on Android, so actually we don't need to dispatch "blocked" event. Differential Revision: https://phabricator.services.mozilla.com/D18627
8579d0e08d4ab3ac1bf7af01d7cb39896a316303: Bug 1522923 - Turn off blocking autoplay on Beta. r=cpearce
Alastor Wu <alwu@mozilla.com> - Tue, 19 Feb 2019 20:28:25 +0000 - rev 518183
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1522923 - Turn off blocking autoplay on Beta. r=cpearce We would enable blocking autoplay feature via roll-out (Normandy), not just fliping on the pref. Therefore, we would turn off the pref on Beta on Feb 25th, which gives us 4 weeks on and 3 weeks off on Beta. And then use Normandy to turn the feature on step by step. Differential Revision: https://phabricator.services.mozilla.com/D20329
204a7782dc0b30c3dedae3ad7965bdcbd004a3ea: Bug 1516598 - remove 'feature-policy' checking for autoplay policy. r=cpearce,baku
Alastor Wu <alwu@mozilla.com> - Tue, 12 Feb 2019 18:21:58 +0000 - rev 516657
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1516598 - remove 'feature-policy' checking for autoplay policy. r=cpearce,baku From the following table, we can know the feature policy have no any effect for the autoplay result. That is, if the document has been gesture activated, we want to playback, regardless of the status of the feature policy. If the site has denied autoplay permission via feature policy, if the user gesture activates (clicks play) we still want to be able to play. Therefore, we can remove `feature-policy` checking. | gesture activated | autoplay feature policy status | allowed to play | |-------------------|--------------------------------|-----------------| | activated | allowed | true | | not activated | not allowed | false | | activated | not allowed | true | | not activated | allowed | false | Differential Revision: https://phabricator.services.mozilla.com/D18098
9452ba2d9657b30f5c82b201b3f3941a1a9e8f5f: Bug 1523013 - Clear SamplesWaitingForKey::mProxy in Shutdown(). r=cpearce
Andrew McCreight <continuation@gmail.com> - Wed, 30 Jan 2019 22:56:21 +0000 - rev 514033
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1523013 - Clear SamplesWaitingForKey::mProxy in Shutdown(). r=cpearce There's a strong cycle of references between SamplesWaitingForKey and CDMProxy that does not get cleared unless keys actually come in. This causes a leak. One way to avoid that leak is to clear the proxy reference when the things holding the SamplesWaitingForKey is shut down. Differential Revision: https://phabricator.services.mozilla.com/D17960
cd093abd9a5cac10c51cdf4aea052ed5fef34d8d: Bug 1526355 - part1 : notify the front end side to show the blocking icon if the site is still being blocked after it's back from the bfcache. r=cpearce a=lizzard
Alastor Wu <alwu@mozilla.com> - Mon, 04 Mar 2019 17:25:52 +0000 - rev 513412
Push 10839 by archaeopteryx@coole-files.de at Thu, 07 Mar 2019 09:52:32 +0000
Bug 1526355 - part1 : notify the front end side to show the blocking icon if the site is still being blocked after it's back from the bfcache. r=cpearce a=lizzard In order to display blocking icon when the document comes back from the bfcache, we have to notify front end what's the current blocking status. As the front end side would clear blocking autoplay information when nagivation occurs, and the media might not invoke the play again when they comes back from the bfcache. Therefore, we should notify front end side that the site is still being blocked, and we should show blocking icon for it. Differential Revision: https://phabricator.services.mozilla.com/D21582
3b0bc8cad66fcf18a00a9185ff534aad7b45f7db: Bug 1530220 - part4 : separate tesing web audio with gum to another test. r=cpearce a=lizzard
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:13:55 +0000 - rev 513407
Push 10838 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 00:22:54 +0000
Bug 1530220 - part4 : separate tesing web audio with gum to another test. r=cpearce a=lizzard Testing web audio with GUM is not related with the original purpose of this test. In order to reduce the complexity of this test, separate this part as another new test. Also modify the naming of functions, because Mozilla coding style is to use the camelCase for the name. Differential Revision: https://phabricator.services.mozilla.com/D21257
4b05bf628c6106f4d690a5da78e826f7ab3e80fc: Bug 1530220 - part2 : modify test in order to test different kinds of keycode. r=cpearce a=lizzard
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:09:50 +0000 - rev 513405
Push 10838 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 00:22:54 +0000
Bug 1530220 - part2 : modify test in order to test different kinds of keycode. r=cpearce a=lizzard Except printable keys, we would treat `carriage return` and `space` as supported user gesture inputs for activating document. Other keys won't activate document. Differential Revision: https://phabricator.services.mozilla.com/D21255
dc39216dfad387efd439083045062e323869a428: Bug 1530220 - part1 : allow some non-printalble keys as supported user gesture inputs to activate document. r=masayuki,cpearce a=lizzard
Alastor Wu <alwu@mozilla.com> - Tue, 05 Mar 2019 02:06:22 +0000 - rev 513404
Push 10838 by ccoroiu@mozilla.com at Thu, 07 Mar 2019 00:22:54 +0000
Bug 1530220 - part1 : allow some non-printalble keys as supported user gesture inputs to activate document. r=masayuki,cpearce a=lizzard `carriage return` and `space` are common keys which user might use to start media, so we should take account them as supported user gesture inputs. As their pseudo char code are zero, we have to check their key code in order to distinguish them from other controls keys such as shift, alt... Differential Revision: https://phabricator.services.mozilla.com/D21253
d520fdd91a48f4e7b5f858f666363629f96bd0ca: Bug 1522923 - Turn off blocking autoplay on Beta. r=cpearce a=lizzard
Alastor Wu <alwu@mozilla.com> - Tue, 19 Feb 2019 20:28:25 +0000 - rev 513285
Push 10789 by rmaries@mozilla.com at Wed, 27 Feb 2019 20:23:22 +0000
Bug 1522923 - Turn off blocking autoplay on Beta. r=cpearce a=lizzard We would enable blocking autoplay feature via roll-out (Normandy), not just fliping on the pref. Therefore, we would turn off the pref on Beta on Feb 25th, which gives us 4 weeks on and 3 weeks off on Beta. And then use Normandy to turn the feature on step by step. Differential Revision: https://phabricator.services.mozilla.com/D20329
1079d285dd4006cf27fd867d29c7e408a7627365: Bug 1523013 - Clear SamplesWaitingForKey::mProxy in Shutdown(). r=cpearce a=lizzard
Andrew McCreight <continuation@gmail.com> - Wed, 30 Jan 2019 22:56:21 +0000 - rev 512876
Push 10630 by nbeleuzu@mozilla.com at Wed, 06 Feb 2019 10:44:39 +0000
Bug 1523013 - Clear SamplesWaitingForKey::mProxy in Shutdown(). r=cpearce a=lizzard There's a strong cycle of references between SamplesWaitingForKey and CDMProxy that does not get cleared unless keys actually come in. This causes a leak. One way to avoid that leak is to clear the proxy reference when the things holding the SamplesWaitingForKey is shut down. Differential Revision: https://phabricator.services.mozilla.com/D17960
349af469066d1d484381e988b38de70d98ca2e06: Bug 1487844 - turn on the blocking-autoplay by default for all branches. r=cpearce
alwu <alwu@mozilla.com> - Wed, 23 Jan 2019 01:55:17 +0000 - rev 512065
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1487844 - turn on the blocking-autoplay by default for all branches. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D17315
89875cd4d9422dd0f7a169184ac2633a6669a196: Bug 1520361 - Add Telemetry to know how people add site to the exception list. r=smaug,cpearce,janerik
Alastor Wu <alwu@mozilla.com> - Tue, 22 Jan 2019 18:22:44 +0000 - rev 511972
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1520361 - Add Telemetry to know how people add site to the exception list. r=smaug,cpearce,janerik Add Telemetry to know the number of times user adds site to allow list, remove site from allow list, add site to block list and remove site from block list. Differential Revision: https://phabricator.services.mozilla.com/D16642
1c1ef238dc17b0e64ac6b860c165e871de21bd86: Bug 1520663 - enable blocking autoplay with user-gesture-activation model on Fennec. r=cpearce
alwu <alwu@mozilla.com> - Thu, 17 Jan 2019 22:24:37 +0000 - rev 511483
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1520663 - enable blocking autoplay with user-gesture-activation model on Fennec. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D16773
177103817494df65f31adc379f46af1dac849d10: Bug 1520457 - Adjust the message written in the console when the auto-play policy block an AudioContext. r=flod,cpearce
Paul Adenot <paul@paul.cx> - Wed, 16 Jan 2019 22:14:08 +0000 - rev 511357
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1520457 - Adjust the message written in the console when the auto-play policy block an AudioContext. r=flod,cpearce Differential Revision: https://phabricator.services.mozilla.com/D16692
5a384547b8b35e566a1afa2398067c82244091ba: Bug 1520088 - part5 - add pref to control whether blacklist can override the default setting. r=cpearce
Alastor Wu <alwu@mozilla.com> - Wed, 16 Jan 2019 03:57:11 +0000 - rev 511253
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1520088 - part5 - add pref to control whether blacklist can override the default setting. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D16640
5e0eb1c0074453818e7135ad87a97e4f3b1e674b: Bug 1520088 - part4 : modify test. r=cpearce
Alastor Wu <alwu@mozilla.com> - Wed, 16 Jan 2019 02:17:56 +0000 - rev 511252
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1520088 - part4 : modify test. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D16581
2ce9b482cda2d1ca16f063754be1bd43515de585: Bug 1520088 - part3 : implement different phases autoplay checking. r=cpearce
Alastor Wu <alwu@mozilla.com> - Wed, 16 Jan 2019 18:21:39 +0000 - rev 511251
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1520088 - part3 : implement different phases autoplay checking. r=cpearce The autoplay checking for media element has 4 different phases, 1. check whether media element itself meets the autoplay condition 2. check whethr the site is in the autoplay whitelist 3. check global autoplay setting and check wether the site is in the autoplay blacklist. 4. check whether media is allowed under current blocking model (click-to-play or user-gesture-activation) Differential Revision: https://phabricator.services.mozilla.com/D16525