searching for reviewer(chutten)
8bbb403aad3f0596b8de71e34080d655660952c3: Bug 1675534 - Update glean-parser to v1.29.0. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Thu, 12 Nov 2020 15:54:13 +0000 - rev 623226
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Update glean-parser to v1.29.0. r=chutten This version bump is required by the Rust glean-core version bump to v33.3.3. Depends on D96834 Differential Revision: https://phabricator.services.mozilla.com/D96835
b088e8256f9ca25a2d21fc21ba5d307c68e3bf1d: Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Thu, 12 Nov 2020 15:52:06 +0000 - rev 623225
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten This is vendoring the Glean Rust Language Bindings (built on the top of glean-core), providing a nice Glean SDK Rust API for consumers, for using in FOG. Depends on D96833 Differential Revision: https://phabricator.services.mozilla.com/D96834
133512f263d04debd817d9176aaf51a63fda6008: Bug 1675534 - Bump glean-core to 33.3.0. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Thu, 12 Nov 2020 15:51:33 +0000 - rev 623224
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Bump glean-core to 33.3.0. r=chutten This additionally brings in two more Rust dependencies: adler and autocfg. They are included in one of the latest flate2 version. Differential Revision: https://phabricator.services.mozilla.com/D96833
cd2a8ee2c844bf53c67bdd8d66f19f705b6a85b6: Bug 1676508 - Use snake_case naming for categories in the JS API. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Thu, 12 Nov 2020 14:40:04 +0000 - rev 623216
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676508 - Use snake_case naming for categories in the JS API. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D96700
6cf47060578f0277e2e90ea1d3e4ab6cd6671921: Bug 1676634 - drop aboutGlean.ftl from list of unused files (on non-Nightly branches). r=chutten DONTBUILD
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 12 Nov 2020 15:49:51 +0000 - rev 623200
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676634 - drop aboutGlean.ftl from list of unused files (on non-Nightly branches). r=chutten DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D96706
df7bc0f78217b6ea42425283c4540cf30c6a4c71: Bug 1676096 - Regenerate test output for glean_parser tests. r=chutten DONTBUILD
Jan-Erik Rediger <jrediger@mozilla.com> - Mon, 09 Nov 2020 14:26:31 +0000 - rev 622812
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1676096 - Regenerate test output for glean_parser tests. r=chutten DONTBUILD Unfortunately I missed regenerating them when I changed the output. Additionally the tests currently don't seem to run on CI so this was missed until now. Differential Revision: https://phabricator.services.mozilla.com/D96385
242953f682a599c795d512138ad7c4c257cabd75: Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Mon, 09 Nov 2020 14:46:04 +0000 - rev 622802
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten This is vendoring the Glean Rust Language Bindings (built on the top of glean-core), providing a nice Glean SDK Rust API for consumers, for using in FOG. Differential Revision: https://phabricator.services.mozilla.com/D96227
72fd081de136b57659c4de1246898f2f15924159: Bug 1675534 - Bump glean-core to 33.1.2. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Mon, 09 Nov 2020 13:39:45 +0000 - rev 622801
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Bump glean-core to 33.1.2. r=chutten This additionally brings in two more Rust dependencies: adler and autocfg. They are included in one of the latest flate2 version. Differential Revision: https://phabricator.services.mozilla.com/D96226
2c75ab4daa47218d57c584b560dfa948ca800d92: Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Mon, 09 Nov 2020 11:09:02 +0000 - rev 622668
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Vendor glean (Rust Language Bindings). r=chutten This is vendoring the Glean Rust Language Bindings (built on the top of glean-core), providing a nice Glean SDK Rust API for consumers, for using in FOG. Differential Revision: https://phabricator.services.mozilla.com/D96227
35d4d9bddadd221c2a555b9c5f66451f88444451: Bug 1675534 - Bump glean-core to 33.1.2. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Mon, 09 Nov 2020 11:08:54 +0000 - rev 622667
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1675534 - Bump glean-core to 33.1.2. r=chutten This additionally brings in two more Rust dependencies: adler and autocfg. They are included in one of the latest flate2 version. Differential Revision: https://phabricator.services.mozilla.com/D96226
b4adb485516bdab1c8d55199f103ef7e1c6bdce4: Bug 1673795 - don't fail test_SyncPingIntegration.js test for Thunderbird. r=chutten
Magnus Melin <mkmelin+mozilla@iki.fi> - Thu, 05 Nov 2020 14:37:10 +0000 - rev 622301
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673795 - don't fail test_SyncPingIntegration.js test for Thunderbird. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D96019
383271ec7243a87d4bc59669f1ebcd6eadcc407b: Bug 1673642 - Implement C++ and JS APIs for the Boolean Metric Type. r=chutten
brizental <beatriz.rizental@gmail.com> - Thu, 05 Nov 2020 12:01:58 +0000 - rev 622294
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673642 - Implement C++ and JS APIs for the Boolean Metric Type. r=chutten BONUS: Improve the docs for adding new metric type in C++ and JS, added two missing steps to the C++ part and changed the layout a bit to make it easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D95314
ffeebb5c7d51e7d63b60c225057717e46231d59c: Bug 1673795 - Integrate sync ping shutdown handling with TelemetryController and record if a sync shutdown ping was sent. r=chutten
Mark Hammond <mhammond@skippinet.com.au> - Thu, 05 Nov 2020 02:44:05 +0000 - rev 622216
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673795 - Integrate sync ping shutdown handling with TelemetryController and record if a sync shutdown ping was sent. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D94929
c37ba981fca07687c29fc9bae64de12ac7ad27d7: Bug 1674541. r=chutten
Mike Conley <mconley@mozilla.com> - Mon, 02 Nov 2020 18:48:46 +0000 - rev 622131
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674541. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95542
829ee953051ecd5bfe72b8c9b9757c832d480fda: Bug 1672706 - Document when and how metric types need to store the metric ID. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 16:32:20 +0000 - rev 621900
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Document when and how metric types need to store the metric ID. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95736
8aada26536b7ded336ff1657076589cc53411f75: Bug 1674728 - Apply clippy suggestions for the FOG code base. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:13:18 +0000 - rev 621899
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674728 - Apply clippy suggestions for the FOG code base. r=chutten All these were detected by running: cargo clippy --manifest-path /home/jer/mozilla/src/gecko/toolkit/components/glean/api/Cargo.toml which is the same as this: mach lint --linter clippy toolkit/components/glean/api/ -W but the latter fails to parse out which file the warnings are for. Differential Revision: https://phabricator.services.mozilla.com/D95510
46f513810a388b109e7992e66c036828eabf59d4: Bug 1674728 - Allow clippy to run correctly on FOG code. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:01:14 +0000 - rev 621898
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674728 - Allow clippy to run correctly on FOG code. r=chutten When running clippy, the linter, `MOZ_TOPOBJDIR` is not set (and the `metrics.rs` file might not even be generated yet), so we need to manually define some things we expect from it so the rest of the build can assume it's there. See https://bugzilla.mozilla.org/show_bug.cgi?id=1674726. Differential Revision: https://phabricator.services.mozilla.com/D95509
bb84538de3fd0a473609498cc9822e7410b9cc17: Bug 1672706 - Receive and pass on the metric ID for labeled metrics. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:01:12 +0000 - rev 621897
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Receive and pass on the metric ID for labeled metrics. r=chutten This removes the last left-over test files for integration tests. Differential Revision: https://phabricator.services.mozilla.com/D95018
37c0ff672a45a14bf72d5d295b1492666a3ce908: Bug 1672706 - Take the metric ID for a UUID metric r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:01:09 +0000 - rev 621896
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Take the metric ID for a UUID metric r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95508
01a91886058b9e2356defc1d5ca7af39742253db: Bug 1672706 - Store the metric ID in an event metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:01:07 +0000 - rev 621895
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Store the metric ID in an event metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95017
2d89bad6e07484291af752bdabde6cf4940bf8af: Bug 1672706 - Wait for Glean to initialize before submitting a ping in the test. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:01:04 +0000 - rev 621894
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Wait for Glean to initialize before submitting a ping in the test. r=chutten This also moves the tests into the code file itself. Differential Revision: https://phabricator.services.mozilla.com/D95016
cbb24d0d69af94d82e54f08d45c3d4faec1ce821: Bug 1672706 - Store the metric ID in a string list metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 15:41:21 +0000 - rev 621893
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Store the metric ID in a string list metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95015
48a6bef980ae64025191881160bf08c80407459e: Bug 1672706 - Store the metric ID in a timing distribution metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 15:41:21 +0000 - rev 621892
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Store the metric ID in a timing distribution metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95507
c5514bf0a84c0d2539c6c183c73410aab44d0973: Bug 1672706 - Store the metric ID in a memory distribution metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 14:00:58 +0000 - rev 621891
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Store the metric ID in a memory distribution metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95013
a7a415438ca7657ccc8513cedf1fa83e1c44dd6b: Bug 1672706 - Take the metric ID for a timespan metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:45 +0000 - rev 621890
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Take the metric ID for a timespan metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95012
546625e61b062cf614f3825ff7bb69236744a4e6: Bug 1672706 - Take the metric ID for a string metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:43 +0000 - rev 621889
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Take the metric ID for a string metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95011
8f4d4480020bc1b25e8494fb6ead6881852eaa22: Bug 1672706 - Take the metric ID for a datetime metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:35 +0000 - rev 621888
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Take the metric ID for a datetime metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95010
025d1f7457ec3442d4cbee89171ea6775ef9a3a1: Bug 1672706 - Take the metric ID for a boolean metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:33 +0000 - rev 621887
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Take the metric ID for a boolean metric. r=chutten This moves the tests to allow for test-only functionality. This will allow to more easily test IPC behavior in pure Rust. Differential Revision: https://phabricator.services.mozilla.com/D95009
f66355a21630409d31ec7788a577350571838f24: Bug 1672706 - Store metric ID in counter & replay counter metrics from IPC. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:25 +0000 - rev 621886
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Store metric ID in counter & replay counter metrics from IPC. r=chutten This now ensures we can: 1. Look up a metric by its (numeric) ID again (which is cheaper than carrying around strings. 2. Replay counter increments coming in from the IPC buffer Differential Revision: https://phabricator.services.mozilla.com/D95008
02261b74f88729834e154d5e24ce6dee142e305d: Bug 1672706 - Turn the metric ID into an opaque type around the integer representation. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:23 +0000 - rev 621885
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Turn the metric ID into an opaque type around the integer representation. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D95007
4c6cd4b1cf44d47fad2f052fe51ff4b5fbd144a6: Bug 1672706 - Stop unimplemented metric types from breaking the build. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 03 Nov 2020 10:37:15 +0000 - rev 621884
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672706 - Stop unimplemented metric types from breaking the build. r=chutten Not all types have corresponding C++ implementations (for the C++ and JS API) yet. To avoid too much work right now we skip auto-generating any code for these types for now until we do have them. Differential Revision: https://phabricator.services.mozilla.com/D95006
82b844f552726949fe21ef223842f2ee10cee3f5: Bug 1673642 - Implement C++ and JS APIs for the Boolean Metric Type. r=chutten
brizental <beatriz.rizental@gmail.com> - Mon, 02 Nov 2020 14:18:06 +0000 - rev 621701
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673642 - Implement C++ and JS APIs for the Boolean Metric Type. r=chutten BONUS: Improve the docs for adding new metric type in C++ and JS, added two missing steps to the C++ part and changed the layout a bit to make it easier to follow. Differential Revision: https://phabricator.services.mozilla.com/D95314
e9a0c954cdc75f63b50d102c35e361635986f048: Bug 1674156 - Add a link to the Firefox Telemetry test strategy doc. r=chutten DONTBUILD
Jan-Erik Rediger <jrediger@mozilla.com> - Mon, 02 Nov 2020 14:21:08 +0000 - rev 621692
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674156 - Add a link to the Firefox Telemetry test strategy doc. r=chutten DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D95514
dd322648c7cba7d8bd0f1b7facb16408899e369a: Bug 1674426 - Update email address in documentation. r=chutten
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 30 Oct 2020 17:42:45 +0000 - rev 621680
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1674426 - Update email address in documentation. r=chutten Depends on D95350 Differential Revision: https://phabricator.services.mozilla.com/D95351
f5ea75ac7bfed6029ee5d47be87f5996e16dc076: Bug 1671473 - Implement IPC for UUID metric type. r=chutten
brizental <beatriz.rizental@gmail.com> - Thu, 29 Oct 2020 13:41:36 +0000 - rev 621352
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1671473 - Implement IPC for UUID metric type. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D94935
63ebbe6a678cc16592ebcaeb9213a0cf6e4595a5: Bug 1644515 - Enable search tests with fixes; r=raphael,chutten
bforehand <bforehand@mozilla.com> - Wed, 28 Oct 2020 18:22:09 +0000 - rev 621236
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1644515 - Enable search tests with fixes; r=raphael,chutten Differential Revision: https://phabricator.services.mozilla.com/D94050
9651640bcc07bf2ca63aef37cf52ee61cf20587f: Bug 1673554 - Add an option to override the pioneer id. r=chutten
Alessio Placitelli <alessio.placitelli@gmail.com> - Wed, 28 Oct 2020 10:09:24 +0000 - rev 621133
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673554 - Add an option to override the pioneer id. r=chutten With this change, calling the submitExternalPing API will not necessarily require the pioneer id value to be stored in a pref. This added flexibility will allow the Pioneer/Ion Core Addon to own the storage of the id, communicating it to the legacy telemetry APIs as needed. Differential Revision: https://phabricator.services.mozilla.com/D94811
e41e89a62d3154397c7d14f4fdb8e580cf428075: Bug 1673731 - Remove needless printf from Stopwatch.cpp. r=chutten DONTBUILD
Mike Conley <mconley@mozilla.com> - Tue, 27 Oct 2020 21:17:43 +0000 - rev 621085
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1673731 - Remove needless printf from Stopwatch.cpp. r=chutten DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D94893
e312798400e80ec371a4f06d41206523b4a292b3: Bug 1646165 - Implement the XPIDL and C++ parts of a timespan metric. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:09:26 +0000 - rev 620275
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Implement the XPIDL and C++ parts of a timespan metric. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D92215
0cc93b4162bb7ce4dad82149e308565cc94d0bc5: Bug 1646165 - Implement the XPIDL and C++ parts of a counter metric. r=chutten,brizental
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:38:36 +0000 - rev 620274
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Implement the XPIDL and C++ parts of a counter metric. r=chutten,brizental This is the very first metric to gain support across all 3 languages (C++, JavaScript, Rust). There's no user yet, so we can't properly test it (a C++ test will come later). As its the first it also brings the XPIDL definition and some nice-to-haves with it (like a header file including all other metric type header files). Differential Revision: https://phabricator.services.mozilla.com/D92214
af5e9b06ff01ae24301fac6e017ea228c63de8c1: Bug 1646165 - Implement code generation for the JavaScript API. r=chutten,emilio
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:39:35 +0000 - rev 620273
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Implement code generation for the JavaScript API. r=chutten,emilio This is a bit more complex because of the multiple layers we have. For JavaScript we need to know: 1) Does an arbitrary string identify a valid category? 2) If yes, does another arbitrary string identify a valid metric inside that checked category? 3) If yes, Which type does that metric have? 4) If you got that, give me a type that has the right methods and forwards them to the right metric instance. So we create 2 lookup tables and encode additional information into the entries. 1. lookup table: Category name -> Index, where the index points into a string table, so we can ensure it's correct. 2. lookup table: Metric identifier (category name . metric name) -> Entry, where Entry is a 64-bit integer. This integer encodes: 1. An index into the string table to check for string equality with a search key 2. Type information to instantiate the correct C++ class 3. The metric's actual ID to lookup the underlying instance. With the 64 bits available we dedicate: 1. 32 bit to the string table offset. More than enough for a large string table. 2. 5 bit for the type. That allows for 32 metric types. We're not even close to that yet. 3. 27 bit for the metric ID. That allows for 130 million metrics. Let's not go there. Differential Revision: https://phabricator.services.mozilla.com/D92213
2b75c70b1f2d70664772ea6790a3b6a2a007e7c7: Bug 1646165 - Generate C++ code for Glean metrics based on IDs. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:23:33 +0000 - rev 620272
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Generate C++ code for Glean metrics based on IDs. r=chutten Based on the same Metric ID generation we now generate C++ code. As tested in the C++ API design document these are `constexpr` of the metric type implementations, wrapping the metric ID. Right now everything is generated into a single big GleanMetrics.h header file. Differential Revision: https://phabricator.services.mozilla.com/D92212
a72fe6375f8069b46893b1c308ab893ee0e67826: Bug 1646165 - Implement FOG's JavaScript API via WebIDL. r=chutten,webidl,emilio,smaug
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:36:46 +0000 - rev 620271
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Implement FOG's JavaScript API via WebIDL. r=chutten,webidl,emilio,smaug This is only the basic outline. It doesn't do anything yet, but compile. As there are no metrics generated for it it can't look up anything. To note: Actual metric types are implemented in XPIDL later. The following (priviliged) JavaScript code will soon work (if the corresponding metrics would be defined): const { Glean } = ChromeUtils.import("resource://gre/modules/Glean.jsm"); Glean.shared.test_only.count_things.add(1); Differential Revision: https://phabricator.services.mozilla.com/D92211
1b5253d542191c1f16f7bdef7db0a1c75dcc0b6d: Bug 1646165 - Generate Metric ID -> Metric instance map in Rust. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Wed, 21 Oct 2020 11:07:39 +0000 - rev 620270
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1646165 - Generate Metric ID -> Metric instance map in Rust. r=chutten Metric IDs are just a monotonically increasing number assigned to each metric. This is stable for a single compilation and should thus be enough to uniquely identify a metric. We create one hash map per metric type implementation in the generated Rust code as global statics, so we can later look up metrics. These maps are not modified at runtime. We map from the metric ID to a reference of lazy value of the global metric. This means we don't instantiate the metric until accessed. We also ensure to lazily instantiate the map itself to avoid the allocation at start, it happens at first access of the metric type. This makes access time non-deterministic, but for now this might be ok. We can come up with a more static layout when needed. Differential Revision: https://phabricator.services.mozilla.com/D92210
98447259d3a4e86ad2f50c6f81a89d45cd0f36ad: Bug 1672375 - Get rid of unused variable in TelemetryUserInteraction.cpp. r=chutten
Mike Conley <mconley@mozilla.com> - Wed, 21 Oct 2020 16:34:45 +0000 - rev 620163
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672375 - Get rid of unused variable in TelemetryUserInteraction.cpp. r=chutten This variable was used in a MOZ_DIAGNOSTIC_ASSERT, but that kind of ASSERT is a no-op outside of Nightly, DevEdition and debug builds. Differential Revision: https://phabricator.services.mozilla.com/D94323
04e687d202e9a5fb31f9f9c8d14d954c7a9a50de: Bug 1672184 - Remove OS and device_* core metrics from FOG. r=chutten
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 20 Oct 2020 16:28:42 +0000 - rev 620102
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1672184 - Remove OS and device_* core metrics from FOG. r=chutten These metrics are handled in glean-core internally or are optional anyway. We accidentally overwrote them here. Differential Revision: https://phabricator.services.mozilla.com/D94122
c842251ed63538a76db865459650d795d20d5262: Bug 1461690 Part 1: Write uninstall ping. r=chutten,Gijs
Adam Gashlin <agashlin@mozilla.com> - Tue, 20 Oct 2020 23:16:02 +0000 - rev 620003
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1461690 Part 1: Write uninstall ping. r=chutten,Gijs This covers the in-Firefox portions of the install ping, except for the otherInstalls count, which is added in part 2. Later parts will cover the uninstaller. Differential Revision: https://phabricator.services.mozilla.com/D92522
6dba004261322f95e4b001e910e63912450edd97: Bug 1661304 - Allow UserInteractions to clobber one another. r=chutten,dthayer
Mike Conley <mconley@mozilla.com> - Tue, 20 Oct 2020 20:17:01 +0000 - rev 619975
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1661304 - Allow UserInteractions to clobber one another. r=chutten,dthayer Depends on D93589 Differential Revision: https://phabricator.services.mozilla.com/D93590
ec504e705660bd4c55015c12d1b365b6cd7f0482: Bug 1661304 - Adding running() method to UserInteraction. r=chutten
Mike Conley <mconley@mozilla.com> - Tue, 20 Oct 2020 20:16:08 +0000 - rev 619974
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1661304 - Adding running() method to UserInteraction. r=chutten Depends on D92810 Differential Revision: https://phabricator.services.mozilla.com/D93589
158644b846dbdb624feb592ae8f8b5ac4eb38457: Bug 1661304 - Add tests for UserInteractions infrastructure. r=chutten
Mike Conley <mconley@mozilla.com> - Tue, 20 Oct 2020 20:15:40 +0000 - rev 619973
Push 14639 by ffxbld-merge at Mon, 16 Nov 2020 09:54:46 +0000
Bug 1661304 - Add tests for UserInteractions infrastructure. r=chutten Depends on D88684 Differential Revision: https://phabricator.services.mozilla.com/D92810