searching for reviewer(chmanchester)
4f6a9270754a0ca4e368bb0bf3256c72669fe79c: Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester a=RyanVM
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:16 +0000 - rev 533887
Push 11452 by jlorenzo@mozilla.com at Fri, 14 Jun 2019 15:11:56 +0000
Bug 1553065 - Move profile-use mozconfig info into common mozconfigs; r=firefox-build-system-reviewers,chmanchester a=RyanVM The 3-tier PGO builds used a separate mozconfig called 'profile-use' for the final tier. This created a problem when it rode to beta, since the same mozconfig was used for all trees, which meant we ended up with nightly branding on beta builds. With the PGO-enabling logic in common mozconfigs, we can enable it by setting the MOZ_PGO_PROFILE_USE environment variable from the task definition. All of the final-tier PGO builds now use the nightly, beta, etc mozconfigs like before, so branding should be intact. Differential Revision: https://phabricator.services.mozilla.com/D33172
4a7962ae170f16bc2b7b0e50348322ca1f01a7dc: Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester a=RyanVM
Mike Shal <mshal@mozilla.com> - Fri, 31 May 2019 23:56:12 +0000 - rev 533886
Push 11452 by jlorenzo@mozilla.com at Fri, 14 Jun 2019 15:11:56 +0000
Bug 1553065 - Use MOZ_LTO environment variable in mozconfig.unix; r=firefox-build-system-reviewers,chmanchester a=RyanVM This makes it consistent with bug 1530908 and 1536194. Differential Revision: https://phabricator.services.mozilla.com/D33171
73460fd9b68d7ddd5266cda0d0693ec4b15de14c: Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester a=test-only
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jun 2019 20:24:04 +0000 - rev 533845
Push 11439 by apavel@mozilla.com at Wed, 12 Jun 2019 23:10:06 +0000
Bug 1557336 - Unset LC_CTYPE when executing pipenv. r=chmanchester a=test-only Differential Revision: https://phabricator.services.mozilla.com/D34484
065339c2d869fa75c5bbfb033f44a9d3effbd8ec: Bug 1557171 - Update vendored lmdb-rkv-sys to 0.8.4. r=chmanchester, a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Tue, 11 Jun 2019 20:23:10 +0000 - rev 533805
Push 11434 by jcristau@mozilla.com at Wed, 12 Jun 2019 14:20:26 +0000
Bug 1557171 - Update vendored lmdb-rkv-sys to 0.8.4. r=chmanchester, a=jcristau The only change is a fix for building for mips. Differential Revision: https://phabricator.services.mozilla.com/D34096
aa3b94c7550a02cb7b9b23244cb62eb31af224e8: Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target. r=chmanchester a=jcristau
Mike Hommey <mh+mozilla@glandium.org> - Wed, 05 Jun 2019 02:53:01 +0000 - rev 533613
Push 11379 by opoprus@mozilla.com at Wed, 05 Jun 2019 15:35:52 +0000
Bug 1556880 - Support GCC ARM preprocessor defines to detect the ARM target. r=chmanchester a=jcristau Also set `fpu` to None for when we don't find it. Differential Revision: https://phabricator.services.mozilla.com/D33720
b23f1b4655818d6d64517ddd7fa74fae1fbd9507: Bug 1549346 - toggle sccache gcs feature to always on r=chmanchester
Rob Thijssen <rthijssen@mozilla.com> - Mon, 13 May 2019 23:56:02 +0000 - rev 532569
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1549346 - toggle sccache gcs feature to always on r=chmanchester partial revert of https://hg.mozilla.org/mozilla-central/rev/5b08dd3eeec9 where the gcs feature switch should have been to the win build only and always enabled rather than just when the SCCACHE_GCS_KEY_PATH variable is set. Differential Revision: https://phabricator.services.mozilla.com/D30774
3d041b01d6f08fa48a130e02f631132da7d7c0fd: Bug 1543215 - Enable PGO on Android aarch64 nightlies; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 09 May 2019 21:55:41 +0000 - rev 532140
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543215 - Enable PGO on Android aarch64 nightlies; r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D30567
c35863f496b662167c8c0c93e6f4b26670e70387: Bug 1543212 - Create a PGO-optimized android-aarch64 build; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 02 May 2019 21:36:46 +0000 - rev 531772
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543212 - Create a PGO-optimized android-aarch64 build; r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D29588
ae79b7fca45dc376e7f024da7f1ca84d81062868: Bug 1500228 - Upload config.status as a build artifact. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Mon, 06 May 2019 23:37:06 +0000 - rev 531614
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1500228 - Upload config.status as a build artifact. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D29771
cb867ce4e9ce3b40f72bff43df65ac09cffc6b22: Bug 1547038 - ignore unrelated errors when checking compiler flags with ccache; r=chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 30 Apr 2019 20:04:22 +0000 - rev 530831
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547038 - ignore unrelated errors when checking compiler flags with ccache; r=chmanchester Using `ccache` apparently interferes with how flag checking is done when we're using `clang` as our compiler. We can work around this by adding a few more flags to flag checking. Differential Revision: https://phabricator.services.mozilla.com/D28895
2de8fcb8a3416988e336632913158ed086ec2b7f: Bug 1547395 - Use 3-tier PGO for linux64-devedition builds; r=chmanchester
Mike Shal <mshal@mozilla.com> - Mon, 29 Apr 2019 19:37:33 +0000 - rev 530803
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547395 - Use 3-tier PGO for linux64-devedition builds; r=chmanchester Depends on D29247 Differential Revision: https://phabricator.services.mozilla.com/D29248
f27bd6eac64adf18990f35e5be504bc1c827a8c0: Bug 1547772 - Add back GenerateQI to offline LSan WPT whitelist. r=chmanchester
Andrew McCreight <continuation@gmail.com> - Mon, 29 Apr 2019 19:36:23 +0000 - rev 530621
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1547772 - Add back GenerateQI to offline LSan WPT whitelist. r=chmanchester I accidentally removed this in a prior whitelist cleanup. Differential Revision: https://phabricator.services.mozilla.com/D29232
9f95b1b2f9e11690859f415e0ceceba7b0e5b403: Bug 1540082 - add support for extra runtime targets in build-clang.py; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 23 Apr 2019 19:45:06 +0000 - rev 530208
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540082 - add support for extra runtime targets in build-clang.py; r=firefox-build-system-reviewers,chmanchester This change enables us to build compiler-rt and related libraries (e.g. address sanitizer, etc.) for whatever targets we like, assuming that we have an accessible sysroot for the target on the build machine. Depends on D28404 Differential Revision: https://phabricator.services.mozilla.com/D28405
1949dd602a233f6529f563b88d5edfe48b7c77d1: Bug 1546136 - dump cmake logs on command failures; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 23 Apr 2019 19:44:55 +0000 - rev 530206
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1546136 - dump cmake logs on command failures; r=firefox-build-system-reviewers,chmanchester CMake errors can be pretty opaque, especially if CMake is being run inside the Ninja build process. Let's try to surface those errors to make problems easier to debug. Differential Revision: https://phabricator.services.mozilla.com/D28360
cde301c4dbfc2fe7e5816331952075aa2a7989dd: Bug 1544115 - Consolidate whitelisting of Rust allocation functions for LSan WPT. r=chmanchester
Andrew McCreight <continuation@gmail.com> - Thu, 25 Apr 2019 16:28:38 +0000 - rev 530150
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544115 - Consolidate whitelisting of Rust allocation functions for LSan WPT. r=chmanchester This whitelisting is not as mangled as the old one, so hopefully it will be more resilient to changes in the Rust compiler. I moved them to the top level white list, because like with the JS leaks we are mostly focused on C++ leaks. Any interesting Rust leak is probably due to a C++ leak. Differential Revision: https://phabricator.services.mozilla.com/D28727
242ca1013e276fa1b75ebe777b615f1875ccdea6: bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Wed, 24 Apr 2019 17:18:22 +0000 - rev 529998
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester The previous commit disabled the remote agent by flipping the remote.enabled preference to false. That prevented the remote agent from initialising or being included in the --help message. This patch implies --enable-cdp in the default Firefox build on Firefox Nightly. Firefox for Android is not supported. This will cause builds to include the remote agent component that lives under remote/. Since the remote agent is disabled by default, users will first have to set the remote.enabled preference to true in order to use it. If you wish to explicitly opt out of including the remote agent when building Firefox, you may do so by using the --disable-cdp build flag in your mozconfig: ac_add_options --disable-cdp Differential Revision: https://phabricator.services.mozilla.com/D27540
57a319eeed2db0eb76136664456233de47c101df: bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Wed, 24 Apr 2019 15:18:09 +0000 - rev 529489
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester The previous commit disabled the remote agent by flipping the remote.enabled preference to false. That prevented the remote agent from initialising or being included in the --help message. This patch implies --enable-cdp in the default Firefox build on Firefox Nightly. Firefox for Android is not supported. This will cause builds to include the remote agent component that lives under remote/. Since the remote agent is disabled by default, users will first have to set the remote.enabled preference to true in order to use it. If you wish to explicitly opt out of including the remote agent when building Firefox, you may do so by using the --disable-cdp build flag in your mozconfig: ac_add_options --disable-cdp Differential Revision: https://phabricator.services.mozilla.com/D27540
473cfd3b34305a44dccb75fc24b1bf15ab772d20: Bug 1545502 - move fuzzing options to toolchain.configure; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 23 Apr 2019 19:15:17 +0000 - rev 529430
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545502 - move fuzzing options to toolchain.configure; r=firefox-build-system-reviewers,chmanchester We moved fuzzing options out of `toolkit/moz.configure` into `js`'s configure a while back, but we seem to have snuck some fuzzing-related options into `toolchain.configure` in the interim. But we can't make the `toolchain.configure` bits depend on the `js` bits; let's just put everything in `toolchain.configure`. Differential Revision: https://phabricator.services.mozilla.com/D28084
1427c70dc701efb6237c39e3d56868cd091d15d4: Bug 1544568 - pull out runtime library-related settings in build-clang.py; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 16 Apr 2019 17:18:01 +0000 - rev 529085
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544568 - pull out runtime library-related settings in build-clang.py; r=firefox-build-system-reviewers,chmanchester It seems better to set switches enabling runtime libraries and switches enabling runtime libraries to build in different places, as future changes might only enable runtime libraries for certain targets, but not need any special switches for building. Depends on D27594 Differential Revision: https://phabricator.services.mozilla.com/D27595
e7174496ab2c82d8a004a67b10d5cdb03d6dc6b6: Bug 1544568 - make setting of `LLVM_*_TARGETS` more explicit; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 16 Apr 2019 17:15:15 +0000 - rev 529084
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544568 - make setting of `LLVM_*_TARGETS` more explicit; r=firefox-build-system-reviewers,chmanchester `android_targets` here is a dict, not a sequence, and while `iter` on a dict object implicitly means `dict.iterkeys()`, that's not really obvious. We should instead be explicit about what we're doing here. Depends on D27593 Differential Revision: https://phabricator.services.mozilla.com/D27594
0b0b2dc12c33c8f507d0559559510da768f00074: Bug 1544568 - don't build XRay libraries; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 16 Apr 2019 17:14:15 +0000 - rev 529083
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544568 - don't build XRay libraries; r=firefox-build-system-reviewers,chmanchester We don't need them and we might as well be explicit about not building them. Depends on D27592 Differential Revision: https://phabricator.services.mozilla.com/D27593
536e9e448e987defcbc433c7f5f94f9aaddfa47d: Bug 1544568 - move compiler-rt runtimes setup into build_one_stage; r=firefox-build-system-reviewers,chmanchester
Nathan Froyd <froydnj@mozilla.com> - Tue, 16 Apr 2019 17:13:58 +0000 - rev 529082
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544568 - move compiler-rt runtimes setup into build_one_stage; r=firefox-build-system-reviewers,chmanchester The setup for compiler-rt is currently done before the stage 2 build, which happens to be the final stage for our android runtime libraries build. But we may also want to build runtime libraries on 3-stage bootstrap builds, in which case we don't want compiler-rt to be active for the second stage. Move the setup into build_one_stage so that the setup is controllable by is_final_stage, which is set in all the place that we care about. Differential Revision: https://phabricator.services.mozilla.com/D27592
2ee12a893122fe795ad529f97a5811cf97f69a7b: Bug 1537751 - Add x86_64 target to Android Clang build configuration. r=chmanchester
Jesse Schwartzentruber <truber@mozilla.com> - Tue, 16 Apr 2019 18:30:56 +0000 - rev 528767
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537751 - Add x86_64 target to Android Clang build configuration. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24349
d32384388e3d28bafb8cc078d98994bb27953553: bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester
Andreas Tolfsen <ato@sny.no> - Wed, 17 Apr 2019 16:41:38 +0000 - rev 528751
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester The previous commit disabled the remote agent by flipping the remote.enabled preference to false. That prevented the remote agent from initialising or being included in the --help message. This patch implies --enable-cdp in the default Firefox build on Firefox Nightly. Firefox for Android is not supported. This will cause builds to include the remote agent component that lives under remote/. Since the remote agent is disabled by default, users will first have to set the remote.enabled preference to true in order to use it. If you wish to explicitly opt out of including the remote agent when building Firefox, you may do so by using the --disable-cdp build flag in your mozconfig: ac_add_options --disable-cdp Differential Revision: https://phabricator.services.mozilla.com/D27540
fdbd2c02f391e03ca2e12438defedbb7828966b9: Bug 1516114 - Enable 3-tier PGO for Linux; r=firefox-build-system-reviewers,Callek,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 12 Apr 2019 20:54:40 +0000 - rev 528339
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1516114 - Enable 3-tier PGO for Linux; r=firefox-build-system-reviewers,Callek,chmanchester Now that 3-tier PGO uses a debian9 image to generate the profile data (bug 1519424), we no longer see the XDG_RUNTIME_DIR failures in the run task. The frequency of those errors was the primary blocker for enabling 3-tier PGO in the first place. Since we still see those errors occasionally in 1-tier PGO, we should switch to the 3-tier model for Linux. Differential Revision: https://phabricator.services.mozilla.com/D27326
c6d76bbda8fe5ed34ba3258dee088ef01f852809: Bug 1543663 - Create an empty config.status for TestManifestBackend; r=chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 12 Apr 2019 23:02:56 +0000 - rev 528179
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543663 - Create an empty config.status for TestManifestBackend; r=chmanchester The TestManifestBackend always has a dependency on config.status, even if configure hasn't been run yet. If configure is run later, this is intended to cause the TestManifestBackend to be regenerated so that it can use the configured values instead of a potentially incomplete setup. Mozbuild's backend_out_of_date() logic treats a missing file as always being out of date, which means if configure hasn't run, the TestManifestBackend will always be regenerated. Instead we can create a stub config.status file that will fix the out-of-date check, and can be treated as a BuildEnvironmentNotFoundException as if the file didn't exist at all. Differential Revision: https://phabricator.services.mozilla.com/D27195
3d0236f985f83c6b2f4800f814c004e0a2902468: Bug 1522931 - always check the OSX SDK version; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Fri, 12 Apr 2019 19:00:13 +0000 - rev 528131
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522931 - always check the OSX SDK version; r=firefox-build-system-reviewers,chmanchester Bug 1500504 added a version check for the SDK, but it only does the check if --with-macos-sdk is used. We should also check the version when using the default SDK. Note that this means we now set MACOS_SDK_DIR to be the default SDK even if it wasn't set explicitly from --with-macos-sdk Differential Revision: https://phabricator.services.mozilla.com/D17727
148b08e319b35670d0c8f91d1113a4af0f827f34: Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester
Mike Shal <marfey@gmail.com> - Wed, 10 Apr 2019 22:14:27 +0000 - rev 527719
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester If mozbuild parsing fails due to a missing file (eg: a file not existing in UNIFIED_SOURCES), then no Makefiles are written out, but config.status exists. This would cause mozbuild to think that configure doesn't need to run, and rely on make to perform the backend-out-of-date check in rebuild-backend.mk. Unfortunately since no Makefiles were written, the make command fails immediately and no attempt is made to re-create the backend. Note that this is only a problem if the first mozbuild parsing from a clobber build fails, otherwise there is typically a top-level Makefile from a previous build to call into (at which point make can determine it is out-of-date, and re-invoke itself). The fix is to have the RecursiveMake backend re-use the same logic that was introduced into mozbuild for alternate backends, and remove rebuild-backend.mk. This way, mozbuild can always determine if the backend needs to be regenerated, even if the initial parsing failed. Test code was also relying on rebuild-backend.mk to generate the TestBackend, but moving backend_out_of_date() into MozbuildObject allows this code to be shared. Differential Revision: https://phabricator.services.mozilla.com/D26262
27214432fe48701e165686814bea25f122e5fd4d: Bug 1522931 - always check the OSX SDK version; r=firefox-build-system-reviewers,chmanchester
Mike Shal <mshal@mozilla.com> - Tue, 09 Apr 2019 20:38:51 +0000 - rev 527497
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1522931 - always check the OSX SDK version; r=firefox-build-system-reviewers,chmanchester Bug 1500504 added a version check for the SDK, but it only does the check if --with-macos-sdk is used. We should also check the version when using the default SDK. Note that this means we now set MACOS_SDK_DIR to be the default SDK even if it wasn't set explicitly from --with-macos-sdk Differential Revision: https://phabricator.services.mozilla.com/D17727
730d38d7baf7a96e6cd9e633a01123d885a18a18: Bug 1537644 - Avoid using link.exe during configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Apr 2019 21:57:19 +0000 - rev 527485
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537644 - Avoid using link.exe during configure. r=chmanchester Interestingly, the change makes one configure test have a different result (localeconv ends up being found when it used not to be found), but the result of that check is actually not used on Windows because we set HAVE_LOCALECONV manually. Differential Revision: https://phabricator.services.mozilla.com/D25902
95b3298fd2d462ecf0aab134289838317009fb3c: Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester
Mike Shal <marfey@gmail.com> - Mon, 08 Apr 2019 16:37:56 +0000 - rev 527201
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537574 - Use mozbuild's backend-out-of-date logic for RecursiveMake; r=firefox-build-system-reviewers,chmanchester If mozbuild parsing fails due to a missing file (eg: a file not existing in UNIFIED_SOURCES), then no Makefiles are written out, but config.status exists. This would cause mozbuild to think that configure doesn't need to run, and rely on make to perform the backend-out-of-date check in rebuild-backend.mk. Unfortunately since no Makefiles were written, the make command fails immediately and no attempt is made to re-create the backend. Note that this is only a problem if the first mozbuild parsing from a clobber build fails, otherwise there is typically a top-level Makefile from a previous build to call into (at which point make can determine it is out-of-date, and re-invoke itself). The fix is to have the RecursiveMake backend re-use the same logic that was introduced into mozbuild for alternate backends, and remove rebuild-backend.mk. This way, mozbuild can always determine if the backend needs to be regenerated, even if the initial parsing failed. Test code was also relying on rebuild-backend.mk to generate the TestBackend, but moving backend_out_of_date() into MozbuildObject allows this code to be shared. Differential Revision: https://phabricator.services.mozilla.com/D26262
6ee134f8c056e78b1b24dce58b93fe437ce4ea30: Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester
Geoff Brown <gbrown@mozilla.com> - Tue, 26 Mar 2019 21:51:51 +0000 - rev 525054
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester Test automation code assumes crashinject.exe is available on Win32: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/build/automation.py.in#356 and minidumpwriter.exe on Windows when there is a 32/64 bit mismatch between python and the application build: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/testing/mozbase/mozcrash/mozcrash/mozcrash.py#428 so I think these should be available for Windows tests, and I suspect they have only been left out accidentally. I will file a new bug to get minidumpwriter working on aarch64. Differential Revision: https://phabricator.services.mozilla.com/D23895
ca91ac220ca923a5c2a05e62914ed739cb544203: Bug 1535441 - Update win64 clang-cl to 8.0.0final r=firefox-build-system-reviewers,chmanchester
David Major <dmajor@mozilla.com> - Fri, 22 Mar 2019 01:40:14 +0000 - rev 524648
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535441 - Update win64 clang-cl to 8.0.0final r=firefox-build-system-reviewers,chmanchester This gets us back to using an official release. Differential Revision: https://phabricator.services.mozilla.com/D24069
86e2a4fbe138e98528eae960d0589cf520f861df: Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 22:58:56 +0000 - rev 524639
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24449
fc6f661f4113fa38c6e44663c404edc7e3ceadec: Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 22 Mar 2019 11:05:18 +0000 - rev 524445
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester The current setup uses different ways for different platforms, with different workarounds, even using extra configuration items for Windows. Now that there can't be a difference between the host per the build system and the host per rust, we can get rid of those configuration items, and use a more common infrastructure. We cannot, however, avoid using wrapper scripts, because per-target rust link-arg flags don't work up great. The downside is that multiplies the number of wrappers, as we now have to have a different one for host and target, and then we have .bat files and shell scripts for, respectively, Windows hosts, and other hosts. Depends on D24321 Differential Revision: https://phabricator.services.mozilla.com/D24322
fca0ca0f03fed6ed7c9630304b7e426d1052de89: Bug 1524396 - Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Fri, 22 Mar 2019 11:06:11 +0000 - rev 524444
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1524396 - Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester While the substitution pattern is kind of awful in make, it will allow to more straightforwardly deal with the difference between target and host. Differential Revision: https://phabricator.services.mozilla.com/D24321
e0cacf5d936fbc2f277af6e5b680eaa4d95eec84: Bug 1537751 - Add x86_64 target to Android Clang build configuration. r=chmanchester
Jesse Schwartzentruber <truber@mozilla.com> - Thu, 21 Mar 2019 22:17:07 +0000 - rev 524393
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537751 - Add x86_64 target to Android Clang build configuration. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24349
b6ac884371a63090e06d4e481c07801c1f18f73c: Bug 1533560 - Enable sanitizer runtimes in Android clang. r=chmanchester
Jesse Schwartzentruber <truber@mozilla.com> - Thu, 21 Mar 2019 22:13:05 +0000 - rev 524392
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533560 - Enable sanitizer runtimes in Android clang. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24346
bf46557c98cb283a1ff94cff5a95baceba1b5b9a: Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 22:58:56 +0000 - rev 524377
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24449
d12b8cd1cee80c0c85d427bb2c507eaf240deabb: Bug 1534858 - Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester
Geoff Brown <gbrown@mozilla.com> - Thu, 21 Mar 2019 22:12:52 +0000 - rev 524374
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1534858 - Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester Test automation code assumes crashinject.exe is available on Win32: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/build/automation.py.in#356 and minidumpwriter.exe on Windows when there is a 32/64 bit mismatch between python and the application build: https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/testing/mozbase/mozcrash/mozcrash/mozcrash.py#428 so I think these should be available for Windows tests, and I suspect they have only been left out accidentally. I will file a new bug to get minidumpwriter working on aarch64. Differential Revision: https://phabricator.services.mozilla.com/D23895
3a444460cb6c3db935838ce735f1e6edceb55dfa: Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 23:40:41 +0000 - rev 524349
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester The current setup uses different ways for different platforms, with different workarounds, even using extra configuration items for Windows. Now that there can't be a difference between the host per the build system and the host per rust, we can get rid of those configuration items, and use a more common infrastructure. We cannot, however, avoid using wrapper scripts, because per-target rust link-arg flags don't work up great. The downside is that multiplies the number of wrappers, as we now have to have a different one for host and target, and then we have .bat files and shell scripts for, respectively, Windows hosts, and other hosts. Depends on D24321 Differential Revision: https://phabricator.services.mozilla.com/D24322
0480bca0d680ac6b42487f1489c1428ccc3d44c7: Bug 1524396 - Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 23:40:23 +0000 - rev 524348
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1524396 - Replace RUST_TARGET_ENV_NAME with make substitutions. r=chmanchester While the substitution pattern is kind of awful in make, it will allow to more straightforwardly deal with the difference between target and host. Differential Revision: https://phabricator.services.mozilla.com/D24321
a01996588f99c1e5179c004c50d88b9c1b04ca53: Bug 1521734 - Use thumbv7neon rust targets when stars align. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 23:36:49 +0000 - rev 524347
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521734 - Use thumbv7neon rust targets when stars align. r=chmanchester Newer versions of rust come with a specialized arm target that matches more closely our armv7 targets (with neon and thumb2), so use that when possible. Depends on D24324 Differential Revision: https://phabricator.services.mozilla.com/D24325
ca1eb7e8ff60b5f03b42213e6fbb46d3d7b84741: Bug 1521734 - Refresh rust target list in toolchain configure test. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 23:36:22 +0000 - rev 524346
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521734 - Refresh rust target list in toolchain configure test. r=chmanchester Depends on D24323 Differential Revision: https://phabricator.services.mozilla.com/D24324
f3cbeb24bd86b9bb31e20db92ee5543321cf768e: Bug 1521734 - Print out the chosen rust host/target triplet during configure. r=chmanchester
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 23:36:00 +0000 - rev 524345
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1521734 - Print out the chosen rust host/target triplet during configure. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D24323
6dea290b80da29a094aa5efaf2fb4db8eddb8142: Bug 1535981 - Throw error with more information when there is no public revision while building artifact mode. r=chmanchester
Tooru Fujisawa <arai_a@mac.com> - Thu, 21 Mar 2019 22:12:20 +0000 - rev 524338
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535981 - Throw error with more information when there is no public revision while building artifact mode. r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D23819
70ce7207292ea5426224e7ccdb9503de9a726338: Bug 1490743 - Work around missing type information in Windows debug symbols r=chmanchester
David Major <dmajor@mozilla.com> - Wed, 20 Mar 2019 15:04:41 +0000 - rev 524045
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1490743 - Work around missing type information in Windows debug symbols r=chmanchester See https://bugs.llvm.org/show_bug.cgi?id=38944. clang thought it could safely leave out type information for some of our classes, but that information would have been helpful for debugging. The flag in this patch turns off the debug-info limiting. Differential Revision: https://phabricator.services.mozilla.com/D24073
d2038c56d1389a5f472d8ee49a88a6af31278d7f: Bug 1535355 - Add --output & --format=json|text to ./mach static-analysis check, r=ahal,firefox-build-system-reviewers,chmanchester
Bastien Abadie <bastien@mozilla.com> - Tue, 19 Mar 2019 18:26:50 +0000 - rev 523985
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1535355 - Add --output & --format=json|text to ./mach static-analysis check, r=ahal,firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D23523
1ec10dce28e2587acb3329f89b600555ce54e315: Bug 1535301 - turn off ICF for Windows builds; r=chmanchester a=pascalc
Nathan Froyd <froydnj@mozilla.com> - Mon, 08 Apr 2019 18:19:39 +0200 - rev 523104
Push 11057 by archaeopteryx@coole-files.de at Wed, 10 Apr 2019 14:56:16 +0000
Bug 1535301 - turn off ICF for Windows builds; r=chmanchester a=pascalc We're doing this to try and gather some information on crashes that have stacks affected by ICF, particularly on beta. We plan to revert this patch after we've gathered crashes for a day or two. Differential Revision: https://phabricator.services.mozilla.com//D26765
0e7912ebf4946d6fb185c17e88f81ae6cb871e9e: Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester a=pascalc
Mike Hommey <mh+mozilla@glandium.org> - Thu, 21 Mar 2019 22:58:56 +0000 - rev 522778
Push 10939 by cbrindusan@mozilla.com at Thu, 28 Mar 2019 15:23:34 +0000
Bug 1537707 - Don't use full build symbols artifacts when MOZ_DISABLE_FULL_SYMBOLS is set. r=chmanchester a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24449