searching for reviewer(cbrewster)
76f83c89446244e1e94db9572717e6f78d6a7a1d: servo: Merge #20614 - Use the incumbent global as the source of x-origin postMessage (from asajeffrey:script-dissimilar-orgin-postMessage-from-incumbent); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Tue, 10 Apr 2018 15:10:07 -0400 - rev 466198
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
servo: Merge #20614 - Use the incumbent global as the source of x-origin postMessage (from asajeffrey:script-dissimilar-orgin-postMessage-from-incumbent); r=cbrewster <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #20604 (github issue number if applicable). - [X] These changes do not require tests because it's already caught by existing WPT <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: cba8b083d37ccff3ef9d658dbe997c31ce3352ea
12c401880034838257964e02499d3a083d5592a0: servo: Merge #18810 - Document the can-block-on relationship for servo (from asajeffrey:constellation-document-blocking); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Fri, 13 Oct 2017 15:39:20 -0500 - rev 436997
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
servo: Merge #18810 - Document the can-block-on relationship for servo (from asajeffrey:constellation-document-blocking); r=cbrewster <!-- Please describe your changes on the following line: --> This PR adds some documentation comments describing the can-block-on relation that is used to ensure deadlock-freedom. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14704 - [X] These changes do not require tests because it's documentation <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 4592e6e53aefb21cc78e75de7906ea7df97a5257
26922045f9c131c9e7a391afede31adadfe5d1a1: servo: Merge #18382 - Add CEReactions to element creation APIs (from servo:jdm-patch-1); r=cbrewster
Josh Matthews <josh@joshmatthews.net> - Wed, 06 Sep 2017 09:38:58 -0500 - rev 428687
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18382 - Add CEReactions to element creation APIs (from servo:jdm-patch-1); r=cbrewster This addresses https://github.com/whatwg/dom/pull/506. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because they will exist upstream in the future. Source-Repo: https://github.com/servo/servo Source-Revision: 4ada03febf2ecdae8220f174a80d22a49a232c5f
602e1a2a4f88e263b8eed094c49701fb3ff19a8b: servo: Merge #18181 - Make it possible to close a browsing context from the embedder (from paulrouget:close_browser); r=cbrewster
Paul Rouget <me@paulrouget.com> - Wed, 23 Aug 2017 03:55:27 -0500 - rev 425764
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18181 - Make it possible to close a browsing context from the embedder (from paulrouget:close_browser); r=cbrewster <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18006 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 5b4c9c7c770c676bd9eb2721fb23764e56c43dcc
fc4c3702eb154f6414a4ccf4571942cb2962c752: servo: Merge #18149 - make sure proper frame tree is sent when iframes change (from paulrouget:hittest-issue); r=cbrewster
Paul Rouget <me@paulrouget.com> - Mon, 21 Aug 2017 03:02:21 -0500 - rev 425379
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
servo: Merge #18149 - make sure proper frame tree is sent when iframes change (from paulrouget:hittest-issue); r=cbrewster We ran into a hittest issue because the frame tree was not correctly updated after #17425. The frame tree should be updated on tab change (via send_frame_tree) or when the frame sub tree changes and it's the active one (via update_frame_tree_if_active). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #18101 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a1006a52a7904b113ee99f5c5b15babb8ae57be4
91d7e3da08e32348b2a2515c0e46a9fecacbddfd: servo: Merge #17709 - always call new_pipeline() before add_pending_changes() (from paulrouget:new_pipeline_before_add_pending_changes); r=cbrewster
Paul Rouget <me@paulrouget.com> - Thu, 13 Jul 2017 10:50:07 -0700 - rev 417541
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17709 - always call new_pipeline() before add_pending_changes() (from paulrouget:new_pipeline_before_add_pending_changes); r=cbrewster There are some changes we want to make in `add_pending_changes` which require pipelines to be registered in self.pipelines. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a287271486e85a0e20d9465ebe25522ad5900a2c
2740545f5d670f07f9162b59e5397a435ab2d16f: servo: Merge #17413 - Update clipboard to 0.4 (from est31:master); r=cbrewster
est31 <MTest31@outlook.com> - Mon, 19 Jun 2017 18:22:25 -0700 - rev 413506
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
servo: Merge #17413 - Update clipboard to 0.4 (from est31:master); r=cbrewster Fixes #17271 Fixes #16459 Source-Repo: https://github.com/servo/servo Source-Revision: 154186f420f96897e926fa0a7c4a653cd0185e34
675ddaef4e5d0aaee6d03d78a78587d584a73e06: servo: Merge #17258 - Reduce code duplication when adding a SessionHistoryChange (from jkl445:issue-17249); r=cbrewster
Jeroen Kleijn <jkl445@hotmail.com> - Fri, 09 Jun 2017 11:41:53 -0700 - rev 411413
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #17258 - Reduce code duplication when adding a SessionHistoryChange (from jkl445:issue-17249); r=cbrewster <!-- Please describe your changes on the following line: --> Implemented add_pending_change method and refactored code to use this new method --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17249 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 1e1b7f6ac2ff44f43d47ed0302016df106a782ee
e328e1ff50af96566ef3440f6564781d60ef5aad: servo: Merge #17077 - Removed root browsing context from constellation (from asajeffrey:constellation-no-root-browsing-context); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Wed, 07 Jun 2017 21:57:10 -0700 - rev 411025
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #17077 - Removed root browsing context from constellation (from asajeffrey:constellation-no-root-browsing-context); r=cbrewster <!-- Please describe your changes on the following line: --> Removed the special root browsing context from the constellation. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #13994 - [X] These changes do not require tests because this isn't visible from user code <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: caa8343e137ab73e046773263dc3ce4b4ebb7b3f
4117a726b0b4f9c685080dd0f31c14ed80b76e78: servo: Merge #17161 - Set the initial disk image size for mac packages (from servo:jdm-patch-1); r=cbrewster
Josh Matthews <josh@joshmatthews.net> - Mon, 05 Jun 2017 16:41:10 -0700 - rev 410551
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #17161 - Set the initial disk image size for mac packages (from servo:jdm-patch-1); r=cbrewster Attempting to fix https://github.com/servo/servo/issues/16644 per https://apple.stackexchange.com/questions/156994/yosemite-hdiutil-create-failed-error-5341. Source-Repo: https://github.com/servo/servo Source-Revision: 5c3b9ef3a0db7aeaf76ede239bc3700369233e12
c0a31caeaad86985c5dc23d84f9d0a188c484650: servo: Merge #16916 - Added a TopLevelBrowsingContextId type (from asajeffrey:constellation-top-level-browsing-contexts); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Mon, 22 May 2017 15:13:42 -0500 - rev 408224
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16916 - Added a TopLevelBrowsingContextId type (from asajeffrey:constellation-top-level-browsing-contexts); r=cbrewster <!-- Please describe your changes on the following line: --> Added a `TopLevelBrowsingContextId` type, which is a subtype of `BrowsingContextId` that only refers to top-level browsing contexts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because refactoring <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: a0d6d6883c3f2fde6f0f3e13712a569ce3aa41e5
19d0683d197d645664e633a94317f9a3181bf903: servo: Merge #16876 - Renamed constellation::Frame to constellation::BrowsingContext (from asajeffrey:constellation-rename-frames); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Tue, 16 May 2017 23:10:45 -0500 - rev 406816
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16876 - Renamed constellation::Frame to constellation::BrowsingContext (from asajeffrey:constellation-rename-frames); r=cbrewster <!-- Please describe your changes on the following line: --> Now that script has `WindowProxy` rather than `BrowsingContext` objects, we can rename `Frame` in the constellation to `BrowsingContext`. In particular, this means that `FrameId`s are now `BrowsingContextid`s, which better captures their purpose (and they are used in a lot of places, not just the constellation). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because renaming <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 837531992864f920342020462830b933d5ed0280
d7f060e17f236b66a9c6f9627de9466a8b08d9cd: servo: Merge #16759 - Enable subpixel anti-aliasing on text by default (from glennw:subpixel); r=cbrewster
Glenn Watson <github@intuitionlibrary.com> - Sun, 07 May 2017 20:27:46 -0500 - rev 405100
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16759 - Enable subpixel anti-aliasing on text by default (from glennw:subpixel); r=cbrewster No doubt there are still some bugs and missing features related to subpixel text anti-aliasing. But enabling by default should allow us to detect these and fix them. If we run into any major issues, this is a standalone commit that can be reverted while we fix the problem. Source-Repo: https://github.com/servo/servo Source-Revision: 4e390e2630f244e77032ded404ca885c3e3ed8a7
62cc0fc2de82b914280735dc456980ececdc3f52: servo: Merge #16729 - Updating rust-openssl version to 0.9.11 (from Tacklebox:issue16708); r=cbrewster
Maxwell Borden <maxwellborden@gmail.com> - Thu, 04 May 2017 15:53:48 -0500 - rev 404674
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16729 - Updating rust-openssl version to 0.9.11 (from Tacklebox:issue16708); r=cbrewster <!-- Please describe your changes on the following line: --> Updated dependency rust-openssl to version 0.9.11 as suggested in issue 16708 to resolve compatibility issues with redhat openssl-devel --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - it reports duplicate bitflags dependancies - [X] These changes fix #16708 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because no code was changed. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 896f0c49b299197eff6101ee434b4feceeb77c4d
290dd813cbed201c39e1aa78a116ebfcf9b3c21d: servo: Merge #16325 - Fix formdata-blob.htm (from KiChjang:fix-formdata-wpt); r=cbrewster
Keith Yeung <kungfukeith11@gmail.com> - Mon, 10 Apr 2017 09:27:01 -0500 - rev 400340
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16325 - Fix formdata-blob.htm (from KiChjang:fix-formdata-wpt); r=cbrewster The other failure is a legitimate WPT bug, will fix upstream. Source-Repo: https://github.com/servo/servo Source-Revision: 638e1dc40bc70c3c0d9cd2efdaef852fdb371382
13dd8c2aef35f4410c15a8ba4a7525bf0d3709b1: servo: Merge #16121 - remove unused `use` statements in mako helpers (from froydnj:unused-property-mako-imports); r=cbrewster
Nathan Froyd <froydnj@gmail.com> - Fri, 24 Mar 2017 20:32:06 -0700 - rev 397717
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #16121 - remove unused `use` statements in mako helpers (from froydnj:unused-property-mako-imports); r=cbrewster These are no longer needed, according to `./mach build -d` and grep. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because compilation is sufficient Source-Repo: https://github.com/servo/servo Source-Revision: fe45283169bda4cd7f72df6b5c14651f7d23712b
8488d7ec99216231f598cd79dac2e74b17f14b18: servo: Merge #15878 - Frames in the constellation store LoadData rather than just URLs (from asajeffrey:constellation-frames-store-loaddata); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Tue, 14 Mar 2017 12:30:20 -0700 - rev 395690
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #15878 - Frames in the constellation store LoadData rather than just URLs (from asajeffrey:constellation-frames-store-loaddata); r=cbrewster <!-- Please describe your changes on the following line: --> Include LoadData in each session history entry, so that when we reload discarded documents we can include POST data etc. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14888 - [X] These changes do not require tests because we don't test document discarding. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 569d51dc30fda8011c6c0dcfad026f74f215ac10
b36f1d98974f50ee6176cda988bc97dd25f94b1d: servo: Merge #15751 - first stab. added ServoUrl as a parameter to report_error(...) of Par… (from avinash-vijayaraghavan:testing-csserror); r=cbrewster
avinash <avinash@avinashs-MacBook-Pro.local> - Mon, 06 Mar 2017 07:11:51 -0800 - rev 394204
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
servo: Merge #15751 - first stab. added ServoUrl as a parameter to report_error(...) of Par… (from avinash-vijayaraghavan:testing-csserror); r=cbrewster @jdm @SimonSapin <!-- Please describe your changes on the following line: --> 1. Added ServoUrl as a parameter to report_error(...) of ParseErrorReporter trait. 2. I am not sure how to handle the case of impl ParseErrorReporter for CSSErrorReporter and MemoryHoleReporter, so have not made any changes (other than adding ServoUrl arg) to report_error implementations for these. 3. In StdoutErrorReporter i have added the ServoUrl arg to the info! function, 4. I would like to know if i am on the correct path and clarify what else needs to be done. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ X] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #15708 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because wanted to clarify before writing tests <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 0dbee36915abd926e61ca8571e11abf1f97ec830
bbcdd2f20a7db6755eb8d81b05f4f9f7b2c18fef: servo: Merge #15653 - Cleanup arraybufferview type (from samliu:cleanup_arraybufferview_type); r=cbrewster
Sam Liu <sam@ambushnetworks.com> - Tue, 21 Feb 2017 06:54:30 -0800 - rev 390669
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15653 - Cleanup arraybufferview type (from samliu:cleanup_arraybufferview_type); r=cbrewster <!-- Please describe your changes on the following line: --> Replace uses of spidermonkey-specific JS_GetArrayBufferViewType with ArrayBufferView impl's method get_array_type(). Tests pass: ./mach test-wpt tests/wpt/web-platform-tests/WebCrypto ./mach test-wpt tests/wpt/web-platform-tests/webgl --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15605 (github issue number if applicable). - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 907c1ef3d280269b5fe87a67759411ab2f938a72
20f45a81138e49aa439d36623ce068df7e6e35ec: servo: Merge #15527 - Make HTMLOptionsCollection constructor accept a HTMLSelectElement argument. Fixes #15521 (from simon-whitehead:fix-15521); r=cbrewster
Simon Whitehead <chemnova@gmail.com> - Mon, 13 Feb 2017 13:31:33 -0800 - rev 389992
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15527 - Make HTMLOptionsCollection constructor accept a HTMLSelectElement argument. Fixes #15521 (from simon-whitehead:fix-15521); r=cbrewster <!-- Please describe your changes on the following line: --> Moves the `HTMLSelectElement.upcast()` call into the `HTMLOptionsCollection` constructors, replacing their signatures with `&HTMLSelectElement` references. This limits the surface area for misuse by only allowing `HTMLSelectElement` instances to be passed in rather than `Node` instances. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #15521. <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because: the linked issue explicitly says building without errors is good enough. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: da8d15427cbe82dabb3ce48580738b775c9086d0
54159b6c0a24f583b492e09baac4fdc6e0e841e5: servo: Merge #15289 - Expose interfaces only where they should be. #12415 - Partial (from montrivo:webidl-exposed); r=cbrewster
montrivo <montrivo@github.com> - Sun, 29 Jan 2017 00:00:19 -0800 - rev 387329
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15289 - Expose interfaces only where they should be. #12415 - Partial (from montrivo:webidl-exposed); r=cbrewster <!-- Please describe your changes on the following line: --> I verified the following interfaces: CSSStyleDeclaration.webidl ElementCSSInlineStyle.webidl ElementContentEditable.webidl EventHandler.webidl Screen.webidl StyleSheetList.webidl StyleSheet.webidl Client.webidl --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #12415 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: e58ef9115fb3c465680c37a78506823f4e629297
dbe3d34971cc73165f188f316f17dea0ec1908ac: servo: Merge #14971 - Constellation informs script about documents becoming inactive, active or fully active (from asajeffrey:script-track-active-documents); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Fri, 27 Jan 2017 16:30:37 -0800 - rev 387317
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14971 - Constellation informs script about documents becoming inactive, active or fully active (from asajeffrey:script-track-active-documents); r=cbrewster <!-- Please describe your changes on the following line: --> This PR replaces the current freeze/thaw mechanism by messages from the constellation to script informing it about when documents become inactive, active or fully active. This means we can now implement |Document::is_active()| which is used in |document.write|. This PR also changes how timers work: previously they were initialized running, and were then frozen/thawed. This means there was a transitory period when timers were running even though the document was not fully active. With this PR, timers are initially suspended, and are only resumed when the document is made fully active. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14876 - [X] These changes do not require tests because it's an interal refactoring. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: b5c94bad371114ab9f03e910f66c00a042997fc2
3722e15a67cccd2cda32fc4ad71b7d202fb6e706: servo: Merge #15155 - constellation: Cleanup the frame size handler (from emilio:frame-size-cleanup); r=cbrewster
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Jan 2017 10:13:45 -0800 - rev 387277
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15155 - constellation: Cleanup the frame size handler (from emilio:frame-size-cleanup); r=cbrewster This is a followup to #15129, addressing my last review comment. r? anyone Source-Repo: https://github.com/servo/servo Source-Revision: 231481570e7ffc6c036b54a15507a9b2260ffe87
588809a33cc43bbd13d93ad1e075290defdfe665: servo: Merge #15107 - convert less interesting debug! logs to traces (from DexterHaslem:15100-convert-debug-to-traces); r=cbrewster
Dexter Haslem <dexter.haslem@gmail.com> - Wed, 18 Jan 2017 21:29:59 -0800 - rev 387249
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15107 - convert less interesting debug! logs to traces (from DexterHaslem:15100-convert-debug-to-traces); r=cbrewster <!-- Please describe your changes on the following line: --> converted some debug! invocations to trace! --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15100 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because only logging changed <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: b8df502491b880cb942badee4ddbf7ec65b174fb
2c1deba467311aa624a8a8dd64f5df412c620781: servo: Merge #15016 - Documents now fully deactivate when a freeze message is sent (from prampey:doc-deactivate); r=cbrewster
Prudhvi Rampey <gergteg777@gmail.com> - Fri, 13 Jan 2017 14:15:44 -0800 - rev 387206
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #15016 - Documents now fully deactivate when a freeze message is sent (from prampey:doc-deactivate); r=cbrewster <!-- Please describe your changes on the following line: --> Documents now fully deactivate when a freeze message is sent --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14906 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because minimal changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 2fb9a345d6341f57ab4cfdd9a1ae68b2bbd5f9a2
147f4e4a12787ea3450634b4952a2ec5ac4854e0: servo: Merge #14911 - Handle properly alternate stylesheet (from charlesvdv:alternate-stylesheet); r=cbrewster
Charles Vandevoorde <charles.vandevoorde@hotmail.be> - Wed, 11 Jan 2017 10:34:04 -0800 - rev 387182
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14911 - Handle properly alternate stylesheet (from charlesvdv:alternate-stylesheet); r=cbrewster <!-- Please describe your changes on the following line: --> Alternate stylesheet are now fetched and then desactivated instead of ignoring them. I don't know if tests are required to check if the stylesheet is correctly loaded and disabled ? <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14881 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: cfc74e20603e7395a743b3b3c202db6db840da4d
73214982fcf057f54e13632d74fea2bdf411547a: servo: Merge #14914 - docs: alphabetize glossary entries (from kveretennicov:patch-1); r=cbrewster
Konstantin Veretennicov <kveretennicov+github@gmail.com> - Sun, 08 Jan 2017 11:38:45 -0800 - rev 387155
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14914 - docs: alphabetize glossary entries (from kveretennicov:patch-1); r=cbrewster <!-- Please describe your changes on the following line: --> Moves "Script" after "Renderer". --- <!-- Either: --> - [X] These changes do not require tests because it's a trivial documentation edit <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 183c4772e7b93bd6cd9b48a729a043421eb6bc65
7a0758d4b1b1694be2567dcb725e0fc67b02a9f7: servo: Merge #14860 - Index the session past correctly when discarding (from asajeffrey:constellation-index-past-correctly-when-discarding); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Fri, 06 Jan 2017 03:53:35 -0800 - rev 387136
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14860 - Index the session past correctly when discarding (from asajeffrey:constellation-index-past-correctly-when-discarding); r=cbrewster <!-- Please describe your changes on the following line: --> Oops, indexed from the wrong end when discarding documents in #14312. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because we're not testing document discarding <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7f9fd0ec1fe70b491d18e99f68988c1381615810
edba63f9322e5c20f710646d6f82ae74b7fbf012: servo: Merge #14559 - Implement browsing context discarding (from asajeffrey:script-track-document-and-bc-discarding); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Thu, 05 Jan 2017 18:20:12 -0800 - rev 387130
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14559 - Implement browsing context discarding (from asajeffrey:script-track-document-and-bc-discarding); r=cbrewster <!-- Please describe your changes on the following line: --> Implement browsing context discarding (https://html.spec.whatwg.org/multipage/browsers.html#discard-a-document). * When a pipeline is closed, inform the script thread whether the browsing context is to be discarded. * In script threads, synchronously discard any similar-origin documents and browsing contexts. * When a browsing context is discarded, it loses the reference to the active document, but the window keeps it, so we need to move the `Document` pointer from `BrowsingContext` to `Window`. * Fix the webIDL for Window to make parent and top optional (the spec says they can return null when the browsing context is discarded). --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14411 - [X] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 8b274f25d3fcbd92dddb83cd96b59a6d51c69d1b
d3dffc6efd074f4861dc87ebefe749782f77299b: servo: Merge #14312 - Implement discarding Document objects to reclaim space (from asajeffrey:script-discard-documents); r=cbrewster
Alan Jeffrey <ajeffrey@mozilla.com> - Wed, 04 Jan 2017 13:58:57 -0800 - rev 387120
Push 7198 by jlorenzo@mozilla.com at Tue, 18 Apr 2017 12:07:49 +0000
servo: Merge #14312 - Implement discarding Document objects to reclaim space (from asajeffrey:script-discard-documents); r=cbrewster <!-- Please describe your changes on the following line: --> This PR implements document discarding. Active documents are kept alive strongly, but inactive documents are only kept alive weakly. When a document is GCd, it is marked as discarded, and if it is every reactivated, a reload of the URL is triggered. Note that this PR is pretty aggressive about discarding, and can any inactive document (other than those being kept alive by other same-origin pipelines). We might want to damp it down a bit. Also note that this interacts with browser.html in that the reloading triggered by reactivating a document triggers mozbrowser events. To test this, I added a `-Zdiscard-inactive-documents` debug flag, which discards all inactive documents, even ones which are reachable through other same-origin pipelines. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14262. - [X] These changes do not require tests because we should be able to use the existing tests with `-Zdiscard-inactive-documents`. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 16b0da5004fd730de87883daa35a78b6af01f042