searching for reviewer(bzbarsky)
42b8c852164df58e6a586f0223b6340870dd87f2: Bug 1612308 - Add a test. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Fri, 05 Jun 2020 07:38:11 +0000 - rev 606093
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1612308 - Add a test. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62151
6b32769bb661afe85b2c94e5f4aa022471adb5f0: Bug 1612308 - Add a comment to BodyStream explaining why an expected state can't be asserted in a particular place. r=bzbarsky
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 22 Jul 2020 22:26:34 +0000 - rev 606092
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1612308 - Add a comment to BodyStream explaining why an expected state can't be asserted in a particular place. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62409
a76c2c98b33c884b16cb5036f2a2d79fa51b11a4: Bug 1367251 - add bindings for options to createImageBitmap and support flipY r=bzbarsky,aosmond,baku
aardgoose <angus.sawyer@gmail.com> - Wed, 15 Jul 2020 11:03:51 +0000 - rev 604891
Push 13434 by ffxbld-merge at Mon, 27 Jul 2020 16:59:11 +0000
Bug 1367251 - add bindings for options to createImageBitmap and support flipY r=bzbarsky,aosmond,baku implementation of imageOrientation: none|flipY. implementation of premultiplyAlpha: none|premultiply|default. Differential Revision: https://phabricator.services.mozilla.com/D29562
f12d21ad24e42eb6c037b5e876681205768a885e: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 26 May 2020 14:06:28 +0000 - rev 595924
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
9133eeb54db8be5f55e51576ae07a1113d48f1f5: Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 22 May 2020 08:08:42 +0000 - rev 595350
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1529203 - Add tests to check that the module map is cleared when using document.open r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D21719
f3b4666175d67db6e558a467c08c337c9192e621: Bug 1612891 - Use IgnoredErrorResult as the parsing easing error result. r=bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Fri, 06 Mar 2020 21:04:07 +0000 - rev 580342
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1612891 - Use IgnoredErrorResult as the parsing easing error result. r=bzbarsky IgnoredErrorResult works well as the auto suppressor class and it's cleaner. Differential Revision: https://phabricator.services.mozilla.com/D65810
436c85047eaf7f20cce47ea91293470845b9d7c1: Bug 1592037 - part6 : implement a chrome-only method for accessing current active media metadata during testing. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 05 Mar 2020 19:43:50 +0000 - rev 580089
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1592037 - part6 : implement a chrome-only method for accessing current active media metadata during testing. r=bzbarsky Create a chrome-only method to get the current media metadata to know if we correctly update the media metadata or not. That method would only be used for testing. Differential Revision: https://phabricator.services.mozilla.com/D64849
095b8239929e1b5eb9b89cbb4b067cc6bfcb5977: Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r=bzbarsky
Brian Birtles <birtles@gmail.com> - Wed, 04 Mar 2020 03:00:38 +0000 - rev 579726
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1619178 - Turn on dom.animations-api.timelines.enabled unconditionally; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D65251
5f121e61730d5b7f6dd5951f2386f9220fd7bf0b: Bug 1619171 - Don't prefix warnings with Error: in the console. r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Tue, 03 Mar 2020 18:14:00 +0000 - rev 579649
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1619171 - Don't prefix warnings with Error: in the console. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D65091
313815a62001f1f3c3653e230acf744ee94f4104: Bug 1617154 - [intersection-observer] Accept a Document as an explicit root. r=emilio,bzbarsky
Frederic Wang <fred.wang@free.fr> - Tue, 03 Mar 2020 12:25:30 +0000 - rev 579558
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1617154 - [intersection-observer] Accept a Document as an explicit root. r=emilio,bzbarsky This patch allows users to specify a Document as an explicit root of an intersection observer. For rationale, see the intent-to thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/64nDLTAZGzY It is implemented under a preference option enabled in Nightly: dom.IntersectionObserverExplicitDocumentRoot.enabled When disabled, the current TypeError exception is preserved so that people can continue to feature detect the support. The enhancement is tested by and enabled for the following test: https://w3c-test.org/intersection-observer/document-scrolling-element-root.html Differential Revision: https://phabricator.services.mozilla.com/D63766
a1d9de6e26750ec68da250c80a2fa27e65955db3: Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 02 Mar 2020 16:11:45 +0000 - rev 579394
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1617084 - Return nullptr_t instead of a full iterator from end(). r=bzbarsky This is legal with C++17. It's not too important for the ancestor iterators because they're just a pointer anyway, but it's nice for ShadowIncludingTreeIterator, which has an AutoTArray and what not. Depends on D63594 Differential Revision: https://phabricator.services.mozilla.com/D64355
d3b95145566b4cc07e7b11539d0c88ad6de5d7d4: Bug 1612308. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Sat, 29 Feb 2020 04:02:51 +0000 - rev 579192
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
d2722b64543975fd0f0a44533df9fcc2b3bbf270: Bug 1408122 - Apply prefers-color-scheme: dark to top-level about:blank. r=emilio,bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 13:43:02 +0000 - rev 579071
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1408122 - Apply prefers-color-scheme: dark to top-level about:blank. r=emilio,bzbarsky I think during the All Hands in Berlin you might have suggested to do this in nsPresContext::DefaultBackgroundColor, but this seems a bit more targeted and not a header. I haven't try tested this yet, so this more of a feedback? Differential Revision: https://phabricator.services.mozilla.com/D63801
fc9d28ae4655254a6ef8a57ac6577545b2a42ca7: Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:13:49 +0000 - rev 579062
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1549641 - Add devtools test for overwritten name and message in error object r=bzbarsky I had problems running this test locally and it turns out cssErrorReportingEnabled is not set/unset correctly. Thanks to Boris for pointing that out. Differential Revision: https://phabricator.services.mozilla.com/D64415
4bdb67b0a4f58d41158520892a459894f9990bd4: Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky
Tom Schuster <evilpies@gmail.com> - Fri, 28 Feb 2020 12:13:49 +0000 - rev 579061
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1549641 - Do not overwrite error message in xpc::ErrorReport. r=bzbarsky We would before always prefer the error name and message contained in the JSErrorReport, and that was probably ok, because ErrorReportToMessageString in xpc did basically the same thing as ErrorReportToString in js. However now that we have special code to try and retrieve overwritten name and message properties we need to prefer aToStringResult. There was one caller in ContentUtils that explicitly passed "<unknown>" for aToStringResult, all other callers either use nullptr or js::ErrorReport::toStringResult().c_str. Differential Revision: https://phabricator.services.mozilla.com/D64350
ff3125134c9355727730c53561d2b29144270e25: Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Feb 2020 18:44:33 +0000 - rev 578918
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky The code in nsIFrame::IsFocusable works for non-number input elements, because of the `IsRootOfNativeAnonymousSubtree` check, but doesn't work for `<input type=number>`, as the scrollable area is wrapped in a flex container (see nsNumberControlFrame::CreateAnonymousContent). It used to work (kinda) before bug 981248 because of the weird focus-manager redirection code to the inner <input> that was causing problems and which that bug removed. Make the check a bit more explicit, and add a test. Differential Revision: https://phabricator.services.mozilla.com/D64432
77174cb8538c7c24a2c2d6edc6cd64edb1bbcdd1: Bug 1604593 - Weaken assert in getNonWrapperObjectForCurrentCompartment(). r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 26 Feb 2020 04:22:13 +0000 - rev 578564
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1604593 - Weaken assert in getNonWrapperObjectForCurrentCompartment(). r=bzbarsky If we try to wrap an inner whose outer has navigated out of process, then we'll get a remote window proxy, not a window proxy. This was happening during the JS devtools test browser_webconsole_block_mixedcontent_securityerrors.js Differential Revision: https://phabricator.services.mozilla.com/D64217
602a074ca5a5b301cadad4e2005ff33008b3927f: Bug 1612308. r=bzbarsky
Jeff Walden <jwalden@mit.edu> - Wed, 26 Feb 2020 01:12:58 +0000 - rev 578544
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1612308. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61478
922d1a0e30901695cfc6efff2d47ff1d787e3b84: Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Mon, 24 Feb 2020 23:07:09 +0000 - rev 578458
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1612106 - Use NIGHTLY build flag to distinguish the writable/readonly Animation.timeline. r=birtles,bzbarsky We only support writable Animation.timeline attribute on nightly build, so use nightly build flag in WebIDL and Animation.h/cpp. For the test expectations, we also use this build flag to skip them or mark them as expected fail if necessary. Differential Revision: https://phabricator.services.mozilla.com/D63432
76472c6d442738730a601ecf22d6cd83e570cae2: Bug 1616537 - Don't give images with empty alt an intrinsic ratio. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 21 Feb 2020 21:03:22 +0000 - rev 578041
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1616537 - Don't give images with empty alt an intrinsic ratio. r=bzbarsky The spec seems to want us to treat it like an inline, but that's not what other browsers do (I added tests for this in bug 1196668, and they still pass in all engines). This is an oddly specific condition to put in nsImageFrame::ShouldShowBrokenImageIcon(), but oh well, we're past all sanity here I think... Differential Revision: https://phabricator.services.mozilla.com/D63715
3424a68c227cd30eed34e2123934ae5fca96d7ff: Bug 1617223 - Remove unused mPostMessageEventQueue from nsGlobalWindowOuter r=bzbarsky
Sean Feng <sefeng@mozilla.com> - Fri, 21 Feb 2020 17:43:59 +0000 - rev 577984
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1617223 - Remove unused mPostMessageEventQueue from nsGlobalWindowOuter r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D63691
4f19c1102c42b884a5a301d489cbccd96ee02dcb: Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky
Boris Chiou <boris.chiou@gmail.com> - Thu, 20 Feb 2020 19:09:34 +0000 - rev 577829
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1616443 - Hide composite memeber from the result of getKeyframes(). r=birtles,bzbarsky If dom.animations-api.compositing.enabled is false, we have to hide composite member from getKeyframes. Differential Revision: https://phabricator.services.mozilla.com/D63388
c8d3eff9375153835bd2130360419e526eaa6324: Bug 1611328 - part3 : generate a default metadata. r=bzbarsky
alwu <alwu@mozilla.com> - Thu, 20 Feb 2020 19:41:51 +0000 - rev 577827
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1611328 - part3 : generate a default metadata. r=bzbarsky Metadata is used to be showed on the virtual controller interface during media is playing, which website can set from MediaSession API. However, if website doesn't use media session, or the media session website uses doesn't have metadata, then we would like to generate a default one to tell user what website is playing media. If we're in private browsing mode, then we should not expose any website information in the default metadata. Differential Revision: https://phabricator.services.mozilla.com/D62536
1d24a1f7cf649addb2aa2f4e76edf616cf40fc93: Bug 1609426 - Part 4: Allow native DOM bindings during eager eval. r=jlast,bzbarsky
Logan Smyth <loganfsmyth@gmail.com> - Tue, 18 Feb 2020 17:50:00 +0000 - rev 577501
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1609426 - Part 4: Allow native DOM bindings during eager eval. r=jlast,bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61966
cb8677cbf5c63e6c06f6e7010a3f98adfb985bb7: Bug 1615741 - Make converting a buffer source follow the spec when a shared buffer is passed in; r=bzbarsky
Edgar Chen <echen@mozilla.com> - Tue, 18 Feb 2020 21:03:17 +0000 - rev 577473
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1615741 - Make converting a buffer source follow the spec when a shared buffer is passed in; r=bzbarsky Converting a shared buffer source to buffer souce type should always throw if the type isn't annotated with [AllowShared]. Differential Revision: https://phabricator.services.mozilla.com/D63047
870496388ab86dab002b8fd7a5872924bf2691c9: Bug 1607214, the implementation of the HTMLInputElement.controllers getter can return null, r=bzbarsky
Neil Deakin <neil@mozilla.com> - Tue, 18 Feb 2020 19:16:12 +0000 - rev 577459
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1607214, the implementation of the HTMLInputElement.controllers getter can return null, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D58789
5aabc907cf1f13ea81332753c93aa958c15039c0: Bug 1613524 - Remove workaround in nsImageBoxFrame::UpdateImage. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Feb 2020 21:20:25 +0000 - rev 576891
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1613524 - Remove workaround in nsImageBoxFrame::UpdateImage. r=bzbarsky Depends on D62149 Differential Revision: https://phabricator.services.mozilla.com/D62150
25bfc69bd9cc90510c530600d3141e4cf05821cb: Bug 1614674 - Poll for load in CSP frame-ancestors tests, r=bzbarsky
James Graham <james@hoppipolla.co.uk> - Thu, 13 Feb 2020 13:34:22 +0000 - rev 576689
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1614674 - Poll for load in CSP frame-ancestors tests, r=bzbarsky These tests are all timing out in Firefox because we don't send either a load or an error event for CSP-blocked loads. To work around this, poll the iframe for the load, assuming it's complete when we see a non-about:blank document with readyState complete (or an exception from trying to access a cross-origin resource). Differential Revision: https://phabricator.services.mozilla.com/D62447
03c1c36d300cf9c2b45f1ea0891bd5c3617ac0b1: Bug 1542784 - Make DOMIntersectionObserver::mCallback Variant. r=emilio,bzbarsky
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Wed, 12 Feb 2020 21:29:19 +0000 - rev 576578
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1542784 - Make DOMIntersectionObserver::mCallback Variant. r=emilio,bzbarsky So that it can accept a callback function implemented in C++ for lazy-loading. Depends on D61435 Differential Revision: https://phabricator.services.mozilla.com/D61436
a2bf92004940994b68132da4d82c3965af991535: Bug 1614674 - Poll for load in CSP frame-ancestors tests, r=bzbarsky
James Graham <james@hoppipolla.co.uk> - Wed, 12 Feb 2020 17:30:31 +0000 - rev 576536
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1614674 - Poll for load in CSP frame-ancestors tests, r=bzbarsky These tests are all timing out in Firefox because we don't send either a load or an error event for CSP-blocked loads. To work around this, poll the iframe for the load, assuming it's complete when we see a non-about:blank document with readyState complete (or an exception from trying to access a cross-origin resource). Differential Revision: https://phabricator.services.mozilla.com/D62447
05583692c421e76a1274e1878e7220300bbd3d61: Bug 1609426 - Part 2: Expose more possible Sandbox bindings. r=bzbarsky
Logan Smyth <loganfsmyth@gmail.com> - Wed, 12 Feb 2020 02:03:02 +0000 - rev 576429
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1609426 - Part 2: Expose more possible Sandbox bindings. r=bzbarsky The debugger needs references to the DOM native functions for its whitelist of pure functions that allow eager evaluation. These whitelist validations can happen for many objects across many realms, so it is much easier if we can pull these functions from a single central sandbox instead of trying to pull them in from a specific content realm. Differential Revision: https://phabricator.services.mozilla.com/D61964
02f22447369053837e8bc80c436224a8eb62bf16: Bug 1611332 - part7 : add test for checking active session among tabs. r=bzbarsky
alwu <alwu@mozilla.com> - Tue, 11 Feb 2020 18:46:05 +0000 - rev 576391
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1611332 - part7 : add test for checking active session among tabs. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61372
f68e07f10effd0ec6c72aabd370e5ad0d32d187f: Bug 1611332 - part4 : directly notify context where media session exists if we have active media session. r=chunmin,bzbarsky
alwu <alwu@mozilla.com> - Tue, 11 Feb 2020 20:55:51 +0000 - rev 576388
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1611332 - part4 : directly notify context where media session exists if we have active media session. r=chunmin,bzbarsky Since we can determine which browsing context contains an active media session via `MediaSessionController`, we should notify that context directly in order to access correct media session. Especially after we enable Fission, browsing contexts could exist in different processes, so choosing the right context to notify is really important. Differential Revision: https://phabricator.services.mozilla.com/D60937
e84b9499917e3ad3743197ddb360f8dfe26610d8: Bug 1611332 - part3 : notify media session being created and destroyed. r=chunmin,bzbarsky
alwu <alwu@mozilla.com> - Fri, 07 Feb 2020 09:30:03 +0000 - rev 576387
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1611332 - part3 : notify media session being created and destroyed. r=chunmin,bzbarsky Update media session status from the content process to the chrome process in order to track all alive media session. Differential Revision: https://phabricator.services.mozilla.com/D60936
d2c7a9b66822875ce9cd1ab769f8d90e25b437d9: Bug 1614329 - Fix the handling of the type attribute of HTMLStyleElement; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 11 Feb 2020 19:38:26 +0000 - rev 576351
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1614329 - Fix the handling of the type attribute of HTMLStyleElement; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62254
f3dd473708054b334de766530d9b6641c79b7907: Bug 1613943 - BeaconStreamListener::OnStartRequest should not set an network error. network code will interpret that as a real network error and close a connection immediately. r=bzbarsky
Dragana Damjanovic <dd.mozilla@gmail.com> - Tue, 11 Feb 2020 16:11:22 +0000 - rev 576341
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1613943 - BeaconStreamListener::OnStartRequest should not set an network error. network code will interpret that as a real network error and close a connection immediately. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D62129
ca430d9d7ba100ed387ecba5afcc9daa6fb4105b: Bug 1611024 - Turn WebGPU programmable passes into interface mixins r=jgilbert,webidl,bzbarsky
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 11 Feb 2020 03:03:47 +0000 - rev 576307
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1611024 - Turn WebGPU programmable passes into interface mixins r=jgilbert,webidl,bzbarsky this makes us closer to the upstream spec and removes a bunch of useless code Differential Revision: https://phabricator.services.mozilla.com/D62377
03b87e4336e5b73fb180ee0f51698f4351eddb58: Bug 1610881 - Get rid of ErrorResult.Throw(DOMException) in Payment code r=bzbarsky
Eden Chuang <echuang@mozilla.com> - Tue, 11 Feb 2020 08:45:49 +0000 - rev 576146
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1610881 - Get rid of ErrorResult.Throw(DOMException) in Payment code r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61557
bbf90fca3403a3abdfdc9daa2e3b9b87f8bdb80b: Bug 1613329 - part2 : add test. r=bzbarsky
alwu <alwu@mozilla.com> - Mon, 10 Feb 2020 22:35:27 +0000 - rev 576108
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1613329 - part2 : add test. r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61667
352b7113d015bde98e6e87d38976ed850ffa119f: Bug 1613329 - part1 : append text track to media element when binding track element to DOM tree. r=bzbarsky
alwu <alwu@mozilla.com> - Tue, 11 Feb 2020 00:41:14 +0000 - rev 576107
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1613329 - part1 : append text track to media element when binding track element to DOM tree. r=bzbarsky This change ensures that we always remember to add a text track to media element's track list. Differential Revision: https://phabricator.services.mozilla.com/D61666
9246a8ba73d89f9c6e1fa842c555fc576755716c: Bug 1612483 - Remove mozilla::dom::TabContext::IsMozBrowser(). r=bzbarsky
Tetsuharu OHZEKI <tetsuharu.ohzeki@gmail.com> - Wed, 05 Feb 2020 16:27:49 +0000 - rev 575975
Push 12808 by ffxbld-merge at Mon, 09 Mar 2020 15:29:44 +0000
Bug 1612483 - Remove mozilla::dom::TabContext::IsMozBrowser(). r=bzbarsky Now, this method returns simply the result of of `IsMozBrowserElement()`. In the old days, We used to have IsMozBrowserElement and IsMozBrowserOrApp, where the latter was true if we had a mozapp or mozbrowser. But with b2g removed, the app thing went away. `IsMozBrowser()` is less used than `IsMozBrowserElement()`. I think the former should be replaced by the later one. Differential Revision: https://phabricator.services.mozilla.com/D61699
11b25704ce8c8177096852b58aef341d4ee7fc7d: Bug 1612308. r=bzbarsky a=tjr
Jeff Walden <jwalden@mit.edu> - Sat, 29 Feb 2020 04:02:51 +0000 - rev 575929
Push 12802 by archaeopteryx@coole-files.de at Sat, 29 Feb 2020 14:22:03 +0000
Bug 1612308. r=bzbarsky a=tjr Differential Revision: https://phabricator.services.mozilla.com/D61478
9c528a390d2ae20362e78d4b31bef1a74ea520b3: Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky a=pascalc
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Feb 2020 18:44:33 +0000 - rev 575910
Push 12794 by apavel@mozilla.com at Thu, 27 Feb 2020 20:08:51 +0000
Bug 1617342 - Don't treat scrollable boxes inside input elements as focusable. r=bzbarsky a=pascalc The code in nsIFrame::IsFocusable works for non-number input elements, because of the `IsRootOfNativeAnonymousSubtree` check, but doesn't work for `<input type=number>`, as the scrollable area is wrapped in a flex container (see nsNumberControlFrame::CreateAnonymousContent). It used to work (kinda) before bug 981248 because of the weird focus-manager redirection code to the inner <input> that was causing problems and which that bug removed. Make the check a bit more explicit, and add a test. Differential Revision: https://phabricator.services.mozilla.com/D64432
fc9d508cfd0132cf7096abecfc6ccf4e3ad254c0: Bug 1613943 - BeaconStreamListener::OnStartRequest should not set an network error. network code will interpret that as a real network error and close a connection immediately. r=bzbarsky, a=RyanVM
Dragana Damjanovic <dd.mozilla@gmail.com> - Tue, 11 Feb 2020 16:11:22 +0000 - rev 575686
Push 12686 by ryanvm@gmail.com at Wed, 12 Feb 2020 19:55:44 +0000
Bug 1613943 - BeaconStreamListener::OnStartRequest should not set an network error. network code will interpret that as a real network error and close a connection immediately. r=bzbarsky, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D62129
c76d8b822e3c503565560f4f73e1ca5d04621e35: Bug 1611701 - Tweak NODE_IS_EDITABLE flag handling for NAC so that it works consistently for <input type=number>. r=bzbarsky,masayuki,whimboo
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 06 Feb 2020 22:15:19 +0000 - rev 575311
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1611701 - Tweak NODE_IS_EDITABLE flag handling for NAC so that it works consistently for <input type=number>. r=bzbarsky,masayuki,whimboo I thought this would fix <input type=number style="user-select: none">, but turns out it doesn't. <input type=number> doesn't have the editor root as a root of the anonymous subtree, so the current hack wouldn't work, as the anon root wouldn't have the editable flag. So tweak the code a bit to handle stuff in a simpler way than setting the flags after the fact, and set the NAC-root flag earlier to avoid the mOuterWrapper->AppendChildTo(root) call forgetting about root's flags. I had to tweak one AccessibleCaret test, but that's because it uses <textarea> with user-select: none, and our behavior there is not particularly sane. It just happened to work because that test-case also had a bunch of contenteditable elements, and we stop matching this rule: https://searchfox.org/mozilla-central/rev/220a3bd6063fcbe5ca50e88dcabdc7dee0aca448/layout/style/contenteditable.css#22 Because the anonymous div now properly matches :-moz-read-write, which made the rule apply and the test work. See comment 4 of this bug. I'll fix this stuff up and add some tests for our behavior here in bug 1611699. I refactored the dragdrop tests to cover more input types, but I ended up not being able to use them because they're dependent on the content. Instead I added an extra test and changed the refactor so that it applies to <input type=search>, as there's layout work going on in bug 558594, and it'd be unfortunate to regress this there too. Differential Revision: https://phabricator.services.mozilla.com/D61094
5a866419f68917aa52ede96a700f94307c6614a5: Bug 1611457 - Respect script blocker in JSWindowActor, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Tue, 04 Feb 2020 18:16:07 +0000 - rev 575310
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1611457 - Respect script blocker in JSWindowActor, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D61354
60267b43ccfadc5f49b41af32191dafc45122bee: Bug 1612447, part 4 - Use UniquePtr for XPCMaps. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 05 Feb 2020 03:30:48 +0000 - rev 575108
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1612447, part 4 - Use UniquePtr for XPCMaps. r=bzbarsky The main advantage here is that it documents who really owns the maps. Differential Revision: https://phabricator.services.mozilla.com/D61330
76380801f52df7b9d45de9681d95036127af0752: Bug 1612447, part 3 - Fix sizes of XPCMaps. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 05 Feb 2020 03:29:29 +0000 - rev 575107
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1612447, part 3 - Fix sizes of XPCMaps. r=bzbarsky This will make the places we call ctors a little nicer, and the extra flexibility is never used. Differential Revision: https://phabricator.services.mozilla.com/D61329
fc553a0eee2d07af75efe932e2d085e330c2c1e6: Bug 1612447, part 2 - Inline the XPCMap newMap methods. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 05 Feb 2020 03:25:03 +0000 - rev 575106
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1612447, part 2 - Inline the XPCMap newMap methods. r=bzbarsky These methods used to do something interesting, but now they are just wrappers around constructor calls. This patch also gets rid of the default ctors that are "deleted" by a comment. There's no need to delete them because we are already defining a constructor, so no default constructor will be created. Differential Revision: https://phabricator.services.mozilla.com/D61328
40979bb0a9d077afe2b920e56fec4a6146d55eaf: Bug 1612447, part 1 - Remove some XPCMap Remove methods that are never called. r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 05 Feb 2020 03:22:50 +0000 - rev 575105
Push 12662 by ffxbld-merge at Mon, 10 Feb 2020 10:43:10 +0000
Bug 1612447, part 1 - Remove some XPCMap Remove methods that are never called. r=bzbarsky Things are now removed from these maps using iterators. Differential Revision: https://phabricator.services.mozilla.com/D61327