searching for reviewer(btseng)
3c96d3de9c7c7eea1692c1bdbca882644a587660: Bug 1222284 - Part 3: Enable test browser_permissionsPromptWorker.js again on mac, r=btseng
Shawn Huang <shuang@mozilla.com> - Thu, 20 Jul 2017 15:10:39 +0800 - rev 418654
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1222284 - Part 3: Enable test browser_permissionsPromptWorker.js again on mac, r=btseng
c515128e7461bb95661d5b306d9ebe3053023c34: Bug 1222284 - Part 2: Replace setFinishedCallback with waitForMessage for browser tests, r=btseng
Shawn Huang <shuang@mozilla.com> - Thu, 20 Jul 2017 15:10:30 +0800 - rev 418653
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1222284 - Part 2: Replace setFinishedCallback with waitForMessage for browser tests, r=btseng For all tests depend on testFinishedCallback() function, the following had been changed: * waitForExplicitFinish() will be replaced with add_task(). * gBrowser.selectedBrowser.addEventListener() will be replaced with waitForMessage(). * testFinishedCallback, testResult, and testException will be unified to testResult.
e7ebcd8b7d5874cf1ffb89db67a02c93db0462aa: Bug 1222284 - Part 1: Replace setFinishedCallback with waitForMessage, r=btseng
Shawn Huang <shuang@mozilla.com> - Thu, 20 Jul 2017 15:10:24 +0800 - rev 418652
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1222284 - Part 1: Replace setFinishedCallback with waitForMessage, r=btseng setFinishedCallback() might have the same race issue as previously bug 1324163 resolved. - testFinishedCallback will be replaced with waitForMessage() in head.js. - testResult, and testException will be unified to testResult.
878fe0c8aa814859489c89b284e4f13c64801831: Bug 1370701 - Part 2: Null out the private window, r=btseng
Shawn Huang <shuang@mozilla.com> - Tue, 18 Jul 2017 15:31:03 +0800 - rev 418115
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1370701 - Part 2: Null out the private window, r=btseng
e4c0cb48a3f18462e581cbf99315426f214bb705: Bug 1370701 - Wait for private browsing window has been fully closed, r=btseng
Shawn Huang <shuang@mozilla.com> - Wed, 12 Jul 2017 18:36:26 +0800 - rev 417327
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1370701 - Wait for private browsing window has been fully closed, r=btseng BrowserTestUtils.closeWindow which is waiting for the final session storage message from the children (in case of the test one for each window) + "domwindowclosed" event on the parent side. It's possible that window.close() is called but window doesn't fully close yet.
96573f588ab7a2a350ee587678cdde95146f283c: Bug 1362945 - Label runnables in dom/file/ipc, r=btseng
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 22 Jun 2017 11:05:56 +0200 - rev 414191
Push 7566 by mtabara@mozilla.com at Wed, 02 Aug 2017 08:25:16 +0000
Bug 1362945 - Label runnables in dom/file/ipc, r=btseng
a13ef3bd6a0343710015fc5bbe31d438af48c7b6: Bug 1370701 - Wait for private browsing window has been fully closed. r=btseng, a=test-only
Shawn Huang <shuang@mozilla.com> - Wed, 12 Jul 2017 18:36:26 +0800 - rev 411960
Push 7507 by ryanvm@gmail.com at Thu, 13 Jul 2017 15:41:21 +0000
Bug 1370701 - Wait for private browsing window has been fully closed. r=btseng, a=test-only BrowserTestUtils.closeWindow which is waiting for the final session storage message from the children (in case of the test one for each window) + "domwindowclosed" event on the parent side. It's possible that window.close() is called but window doesn't fully close yet.
50f39d5543d8df968c2313e74528c595c3089f2d: Bug 1370519 - Part 4: Get rid of FileHandleCommon.h/cpp; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 07 Jun 2017 12:36:58 +0200 - rev 410797
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370519 - Part 4: Get rid of FileHandleCommon.h/cpp; r=btseng
e5f90f396476ef1efdfe421c5c903343ca9904a3: Bug 1370519 - Part 3: Remove unused files; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 07 Jun 2017 12:36:51 +0200 - rev 410796
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370519 - Part 3: Remove unused files; r=btseng
398e771204b76ab4fd049c54ce4025a6d14b2d5b: Bug 1370519 - Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors); r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 07 Jun 2017 12:36:42 +0200 - rev 410795
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370519 - Part 2: Merge FileHandle base classes with IndexedDB specific classes (except parent actors); r=btseng
1637d5c1dd6c9a1752e68fe7f2b84420d816db0b: Bug 1370519 - Part 1: Add missing includes to fix non-unified builds; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 07 Jun 2017 12:36:20 +0200 - rev 410794
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1370519 - Part 1: Add missing includes to fix non-unified builds; r=btseng
1253a062332e18fbd03b97918874df64d8e2a58b: Bug 1356824 - Fix a typo in the comments; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 07 Jun 2017 08:57:57 +0200 - rev 410768
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1356824 - Fix a typo in the comments; r=btseng
665f1887a112dac916caac5e659764a0f62db27b: Bug 1356824 - Don't clear mWaitingFactoryOp without holding a self reference in (Open|Delete)DatabaseOp::NoteDatabaseClosed(). r=btseng
Jan Varga <jan.varga@gmail.com> - Thu, 01 Jun 2017 13:08:52 -0400 - rev 409968
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1356824 - Don't clear mWaitingFactoryOp without holding a self reference in (Open|Delete)DatabaseOp::NoteDatabaseClosed(). r=btseng Remove now useless self reference in OpenDatabaseOp::SendResults(). Add comments for how to call FactoryOp::Run() safely and also add comments to all the call sites. This prevents a self destruction while Run() (or a method that is called by Run()) is still being executed. Also fix TransactionDatabaseOperationBase which also calls Run() directly in NoteContinueReceived().
97a93e11531e319ef20d2f57e6f51878533af4b9: Bug 1339826 - Part 3: Add a self reference in Maintenance::Finish() to prevent self destruction while the method is still being executed; r=btseng
Jan Varga <jan.varga@gmail.com> - Fri, 28 Apr 2017 17:43:03 +0200 - rev 403807
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1339826 - Part 3: Add a self reference in Maintenance::Finish() to prevent self destruction while the method is still being executed; r=btseng
5963f2cdd2e76d9497a4f04cd54bc524d5015790: Bug 1339826 - Part 2: Warn if a maintenance finishes with an error; r=btseng
Jan Varga <jan.varga@gmail.com> - Fri, 28 Apr 2017 17:42:53 +0200 - rev 403806
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1339826 - Part 2: Warn if a maintenance finishes with an error; r=btseng
932f73cb6ba9cfc55519ea5a7b7c285b6101f32d: Bug 1339826 - Part 1: Don't assume that some nsIFile methods can't ever fail; r=btseng
Jan Varga <jan.varga@gmail.com> - Fri, 28 Apr 2017 17:42:39 +0200 - rev 403805
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1339826 - Part 1: Don't assume that some nsIFile methods can't ever fail; r=btseng
65c632f7889f79425818ab5acd4c67d1ae49b457: Bug 1350564 - Don't try to addref a null mResult in Request::GetResult and UsageRequest::GetResult (mResult can be null when mHaveResultOrErrorCode is true); r=btseng
Jan Varga <jan.varga@gmail.com> - Tue, 18 Apr 2017 10:15:57 +0200 - rev 401741
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1350564 - Don't try to addref a null mResult in Request::GetResult and UsageRequest::GetResult (mResult can be null when mHaveResultOrErrorCode is true); r=btseng
21063e15627ed95d8319001f45a95d7213f0c454: Bug 1348660 - Part 6: Rename QuotaManager::IsOriginWhitelistedForPersistentStorage() to QuotaManager::IsOriginInternal(); r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:14:09 +0100 - rev 397067
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 6: Rename QuotaManager::IsOriginWhitelistedForPersistentStorage() to QuotaManager::IsOriginInternal(); r=btseng
2c3319501b59c23468e18069268aa5e71d862446: Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:14:04 +0100 - rev 397066
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 5: Implement a method to retrieve usage data for all origins at once; r=btseng
24244ba9a14440f6c0b20e280d60b18498bf6aff: Bug 1348660 - Part 4: Extract common code from GetOriginUsageOp to a new base class QuotaUsageRequestBase; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:13:58 +0100 - rev 397065
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 4: Extract common code from GetOriginUsageOp to a new base class QuotaUsageRequestBase; r=btseng
f9f06917c82a73e18a1ef189c891f506b313aa01: Bug 1348660 - Part 3: Separate the canceled state out of UsageInfo; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:13:54 +0100 - rev 397064
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 3: Separate the canceled state out of UsageInfo; r=btseng
c0d0402b8bb0d22cb0b9e33c91b2277d77107100: Bug 1348660 - Part 2: Rename usage related methods and structures to express the relation to a concrete origin; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:13:48 +0100 - rev 397063
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 2: Rename usage related methods and structures to express the relation to a concrete origin; r=btseng
ea3c6e12b49991ae80061d66dec24e28ccfeb237: Bug 1348660 - Part 1: Convert nsIQuotaUsageRequest result related attributes to a new structure nsIQuotaUsageResult and expose it using a new result attribute of type nsIVariant; r=btseng
Jan Varga <jan.varga@gmail.com> - Wed, 22 Mar 2017 12:13:38 +0100 - rev 397062
Push 7391 by mtabara@mozilla.com at Mon, 12 Jun 2017 13:08:53 +0000
Bug 1348660 - Part 1: Convert nsIQuotaUsageRequest result related attributes to a new structure nsIQuotaUsageResult and expose it using a new result attribute of type nsIVariant; r=btseng
cb4a4275b365b126ae56b1df5521756b693d8ff9: Bug 1356824 - Don't clear mWaitingFactoryOp without holding a self reference in (Open|Delete)DatabaseOp::NoteDatabaseClosed(). r=btseng, a=ritu FIREFOX_54_0b13_BUILD1 FIREFOX_54_0b13_RELEASE
Jan Varga <jan.varga@gmail.com> - Thu, 01 Jun 2017 13:08:52 -0400 - rev 394153
Push 7378 by ryanvm@gmail.com at Thu, 01 Jun 2017 20:32:57 +0000
Bug 1356824 - Don't clear mWaitingFactoryOp without holding a self reference in (Open|Delete)DatabaseOp::NoteDatabaseClosed(). r=btseng, a=ritu Remove now useless self reference in OpenDatabaseOp::SendResults(). Add comments for how to call FactoryOp::Run() safely and also add comments to all the call sites. This prevents a self destruction while Run() (or a method that is called by Run()) is still being executed. Also fix TransactionDatabaseOperationBase which also calls Run() directly in NoteContinueReceived().
5f5f861ab495278246dcd738d893c981faf3ea90: Bug 1282408 - Add ignore-initialization-check annotation to mPrlVersion from CdmaIccInfo. r=btseng
Paul Bignier <paul.bignier@gmail.com> - Tue, 27 Sep 2016 15:08:20 +0200 - rev 358576
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1282408 - Add ignore-initialization-check annotation to mPrlVersion from CdmaIccInfo. r=btseng
3065442079d905ee46349d4a4c3a52169080705b: Bug 1282408 - Add ignore-initialization-check annotation to mIsDisplayNetworkNameRequired & mIsDisplaySpnRequired from IccInfo. r=btseng
Paul Bignier <paul.bignier@gmail.com> - Tue, 27 Sep 2016 12:24:37 +0200 - rev 358574
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1282408 - Add ignore-initialization-check annotation to mIsDisplayNetworkNameRequired & mIsDisplaySpnRequired from IccInfo. r=btseng
58fc35829a492d829a2b7801c8f3c51d5123b4e8: Bug 1290853 - Iterate the blocked transactions in the first-come, first-served order. r=btseng
Jan Varga <jvarga@mozilla.com> - Wed, 24 Aug 2016 13:40:25 +0800 - rev 358269
Push 6795 by jlund@mozilla.com at Mon, 23 Jan 2017 14:19:46 +0000
Bug 1290853 - Iterate the blocked transactions in the first-come, first-served order. r=btseng
153a1790611f5456b04315b01d34c9369547713f: Bug 975778 - Part 2: Add a new testcase for CDMA call waiting (Testcase). r=btseng
Ben Hsu <driftersprt@gmail.com> - Thu, 08 Oct 2015 03:07:00 +0800 - rev 312889
Push 5703 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:18:41 +0000
Bug 975778 - Part 2: Add a new testcase for CDMA call waiting (Testcase). r=btseng
9bb256876625f94d55c7a1e26728504d2cbca748: Bug 975778 - Part 1: Modify some helper functions (head.js). r=btseng
Ben Hsu <driftersprt@gmail.com> - Thu, 08 Oct 2015 02:57:00 +0800 - rev 312888
Push 5703 by raliiev@mozilla.com at Mon, 07 Mar 2016 14:18:41 +0000
Bug 975778 - Part 1: Modify some helper functions (head.js). r=btseng
6d26e408810ffb9775993017fe8f8da26ec552ef: Bug 1225923 - part 3 - fix AppendElement(nsDependentString(...)) calls in dom/telephony/; r=btseng
Nathan Froyd <froydnj@mozilla.com> - Wed, 18 Nov 2015 10:53:05 -0500 - rev 309089
Push 5513 by raliiev@mozilla.com at Mon, 25 Jan 2016 13:55:34 +0000
Bug 1225923 - part 3 - fix AppendElement(nsDependentString(...)) calls in dom/telephony/; r=btseng I think the intent of these calls is to not copy the information strings passed in, but to simply convert them to a friendlier nsString container for processing. In the TelephonyDialCallback case, we're copying the strings only to convert them to an array of JS::Value, which copies the data again. We might as well avoid one of the copies. In the TelephonyParent case, we're copying the strings only to send them over an IPC channel. Therefore, it's safe to not copy the strings initially, because the original strings will remain live long enough to send the IPC message.
6d06e276a2b97671fac54a4eacd51fbe7d746dac: Bug 1155072 - Part 1: Deprecate nsITelephonyListener.conferenceCallStateChanged (Telephony). r=btseng
Ben Hsu <driftersprt@gmail.com> - Mon, 12 Oct 2015 01:47:00 +0200 - rev 301963
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1155072 - Part 1: Deprecate nsITelephonyListener.conferenceCallStateChanged (Telephony). r=btseng
137777f64b8cc2076592c94a2007c14e016bcecd: Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests. r=btseng
Edgar Chen <echen@mozilla.com> - Sat, 10 Oct 2015 12:05:38 +0800 - rev 300803
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1213547 - [Cellbroadcast] Split test_ril_worker_cellbroadcast.js into smaller tests. r=btseng
718fb43568add84c5da677c0e5c89f07c614c241: Bug 1171807 - Part 2: Move to enums and deprecate TelephonyCall.mCallState and TelephonyCallGroup.mCallState (DOM). r=btseng
Ho-Pang Hsu <driftersprt@gmail.com> - Tue, 06 Oct 2015 19:11:00 +0200 - rev 299956
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1171807 - Part 2: Move to enums and deprecate TelephonyCall.mCallState and TelephonyCallGroup.mCallState (DOM). r=btseng
40236e4d9d64a8eae2f51d18d920e895935df72e: Bug 1204817 - Delete the child property of a parent call only when the parent call exists. r=btseng
Ben Hsu <driftersprt@gmail.com> - Tue, 15 Sep 2015 02:03:00 +0200 - rev 299678
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1204817 - Delete the child property of a parent call only when the parent call exists. r=btseng
11da6ec60db484dbe1079573866f67622d4ccaa4: Bug 1147296 - Part 5: Replace two testcases (Testcase). r=btseng
Ben Hsu <driftersprt@gmail.com> - Fri, 25 Sep 2015 12:57:59 +0800 - rev 299670
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1147296 - Part 5: Replace two testcases (Testcase). r=btseng
e8e26bc2681759ba91857ef7f35f6599c064487c: Bug 1147296 - Part 4: Expose new functions (head.js). r=btseng
Ben Hsu <driftersprt@gmail.com> - Fri, 11 Sep 2015 03:09:00 +0800 - rev 299669
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1147296 - Part 4: Expose new functions (head.js). r=btseng
23035c45e742ce9fe92f0f772e3efdf310da2671: Bug 1147296 - Part 3: Introduce a new check function for both GSM and CDMA (head.js). r=btseng
Ben Hsu <driftersprt@gmail.com> - Sun, 04 Oct 2015 22:52:00 +0800 - rev 299668
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1147296 - Part 3: Introduce a new check function for both GSM and CDMA (head.js). r=btseng
b6c3d38e34b9e875ebe30287eb48438d8d54f3f7: Bug 1147296 - Part 2: Move to telephony command group and support CDMA operations (head.js). r=btseng
Ben Hsu <driftersprt@gmail.com> - Fri, 11 Sep 2015 03:07:00 +0800 - rev 299667
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1147296 - Part 2: Move to telephony command group and support CDMA operations (head.js). r=btseng
1731f93991cc69ce5737faca11cefb62c3d93a71: Bug 1147296 - Part 1: Create |Modem| helper object (head.js). r=btseng
Ben Hsu <driftersprt@gmail.com> - Sun, 04 Oct 2015 22:51:00 +0800 - rev 299666
Push 5392 by raliiev@mozilla.com at Mon, 14 Dec 2015 20:08:23 +0000
Bug 1147296 - Part 1: Create |Modem| helper object (head.js). r=btseng
763a6d65f36c2d04c83dcdab815b9d3ab73c3823: Bug 1197008 - Stop assuming 0 is an invalid threadId. r=btseng r=hsinyi
Reuben Morais <reuben.morais@gmail.com> - Wed, 02 Sep 2015 09:37:17 -0300 - rev 293116
Push 5245 by raliiev@mozilla.com at Thu, 29 Oct 2015 11:30:51 +0000
Bug 1197008 - Stop assuming 0 is an invalid threadId. r=btseng r=hsinyi
a29e9b59c7f5343d815907f0ba72f740396facb2: Bug 1187832 - Update ril_worker and corresponding test cases. r=btseng
Samael Wang <freesamael@gmail.com> - Tue, 04 Aug 2015 13:58:42 +0800 - rev 289697
Push 5245 by raliiev@mozilla.com at Thu, 29 Oct 2015 11:30:51 +0000
Bug 1187832 - Update ril_worker and corresponding test cases. r=btseng
93db1a349ab9e8a84750e9a92bf21f2fea861c18: Bug 1175430 - Expose Network-Specific Error Cause for Various Error Handling in App Layer. r=btseng
younghwan.ji <younghwan.ji@gmail.com> - Mon, 10 Aug 2015 10:08:23 +0900 - rev 289696
Push 5245 by raliiev@mozilla.com at Thu, 29 Oct 2015 11:30:51 +0000
Bug 1175430 - Expose Network-Specific Error Cause for Various Error Handling in App Layer. r=btseng
b61a73af6333694a3eb7982baf7984cf6d81f300: Bug 1167132 - Part 8: [NetworkManager] Move network information into a separate interface (Mms). r=btseng
Jessica Jong <jjong@mozilla.com> - Wed, 29 Jul 2015 02:10:00 -0400 - rev 286950
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1167132 - Part 8: [NetworkManager] Move network information into a separate interface (Mms). r=btseng
d5f6df9fc4a7e39f5207f509f75ce39742130208: Bug 1043250 - Part 5: Update marionette test cases. r=btseng
Samael Wang <freesamael@gmail.com> - Tue, 14 Jul 2015 14:57:57 +0800 - rev 286184
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1043250 - Part 5: Update marionette test cases. r=btseng test_set_smsc_address / test_smsc_address: - Update the test cases to reflect the interface change.
a254def80fe678f6a5b5ba59f6eef85f52c14a99: Bug 1043250 - Part 4: Update SMS IPC implementation. r=btseng
Samael Wang <freesamael@gmail.com> - Tue, 14 Jul 2015 14:57:49 +0800 - rev 286183
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1043250 - Part 4: Update SMS IPC implementation. r=btseng PSmsRequest.ipdl: - Update ReplyGetSmscAddress to include extra parameters. SmsChild: - Update Recv__delete__ to reflect the change of PSmsRequest. SmsParent: - Update NotifyGetSmscAddress to reflect the change of PSmsRequest.
8288be78c5f51b71bccf80658c007e0bc4961162: Bug 1043250 - Part 2: Update MobileMessageCallback and SmsService. r=btseng
Samael Wang <freesamael@gmail.com> - Tue, 14 Jul 2015 14:57:33 +0800 - rev 286181
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1043250 - Part 2: Update MobileMessageCallback and SmsService. r=btseng nsIMobileMessageCallback.idl - Update the signature of NotifyGetSmscAddress and uuid. MobileMessageCallback.cpp: - Update NotifyGetSmscAddress to reflect the signature change and to adapt Promise. - Update NotifyGetSmscAddressFailed to adapt Promise. nsISmsService.idl: - Update the comment to emphasize NUMBER_PLAN_IDENTIFICATION constants reflects enumeration values. SmsService.js: - Update the invocation of notifySmscAddress as the signature changes.
281c89d5582f414e15971ccb9d7488c06d5d58ab: Bug 1043250 - Part 1: Update ril_worker and xpcshell test. r=btseng
Samael Wang <freesamael@gmail.com> - Mon, 20 Jul 2015 14:43:46 +0800 - rev 286180
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1043250 - Part 1: Update ril_worker and xpcshell test. r=btseng ril_worker.js: - Remove SMSC attribute. - Rewrite REQUEST_GET_SMSC_ADDRESS function. - Remove the usage of rilRequestError since it's removed in Bug 991582. test_ril_worker_smsc_address.js: - Add a test case for getSmscAddress. ril_const.js: - Add more clear comment for CALLED_PARTY_BCD_NPI array.
664126b31237735d0f73290e9e18d174206f4931: Bug 984413 - Add JSdoc in MobileMessageDB.jsm. r=btseng
Samael Wang <freesamael@gmail.com> - Mon, 13 Jul 2015 16:03:14 +0800 - rev 284445
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 984413 - Add JSdoc in MobileMessageDB.jsm. r=btseng
746f6aab10abc78866ea9174748b4ffa7d3ec74e: Bug 1181466 - Fix observe function in SmsService/MmsService. r=btseng
Samael Wang <freesamael@gmail.com> - Thu, 09 Jul 2015 11:59:45 +0800 - rev 283744
Push 5067 by raliiev@mozilla.com at Mon, 21 Sep 2015 14:04:52 +0000
Bug 1181466 - Fix observe function in SmsService/MmsService. r=btseng Ensure deletedInfo object is converted by subject.QueryInterface() when "sms-deleted" topic observed.
a312bb7e2c14e14a33202896e0c3aca1e08139fe: Bug 1173156 - Fix typo and add a Marionette test case. r=btseng
Samael Wang <freesamael@gmail.com> - Mon, 15 Jun 2015 17:17:56 +0800 - rev 279593
Push 4932 by jlund@mozilla.com at Mon, 10 Aug 2015 18:23:06 +0000
Bug 1173156 - Fix typo and add a Marionette test case. r=btseng