searching for reviewer(bholley)
d7611ae5168b: Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 05 Mar 2018 10:57:12 +0100 - rev 460918
Push 9094 by archaeopteryx@coole-files.de at 2018-04-19 16:18 +0000
Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley a=jcristau This should hopefully make pushPrefEnv able to deal with it. I optimistically enabled Android too, pending a CI run. MozReview-Commit-ID: 47C4q0lzIek
e3104f4386e8: Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley a=jcristau
Tom Ritter <tom@mozilla.com> - Fri, 09 Mar 2018 20:12:53 -0600 - rev 460251
Push 8891 by rgurzau@mozilla.com at 2018-03-21 13:06 +0000
Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley a=jcristau PresShell only uses performane.now to track refresh times, and notify internal observers. We can provide more accurate times by not clamping and jittering these numbers. MozReview-Commit-ID: FkDGJhrLeAy
2f58f0b2f939: Bug 1444679: Remove WrappedJSIdentity. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Mar 2018 03:13:47 +0100 - rev 460069
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444679: Remove WrappedJSIdentity. r=bholley Seemed to only be used for the method that was removed in the previous patch. MozReview-Commit-ID: 1cKpVBlxa7r
c5e091682eb1: Bug 1444679: Remove unused nsXPCWrappedJSClass::IsWrappedJS. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Mar 2018 02:36:46 +0100 - rev 460068
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444679: Remove unused nsXPCWrappedJSClass::IsWrappedJS. r=bholley MozReview-Commit-ID: KnNOjaEpa0g
2ea235b4dedb: Bug 1444507: Remove unused binding functions. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Mar 2018 20:10:22 +0100 - rev 459993
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444507: Remove unused binding functions. r=bholley MozReview-Commit-ID: EGceLrhKVIm
258c14f97fa2: servo: Merge #20248 - style: Change the order we match selectors on invalidation to match normal order (from emilio:invalidation-selectors-faster); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 18:44:29 -0500 - rev 459807
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
servo: Merge #20248 - style: Change the order we match selectors on invalidation to match normal order (from emilio:invalidation-selectors-faster); r=bholley This changes the order to match the normal selector-matching order, which is usually faster. That is, when matching div:nth-child(2), for example, before this patch we'd first try to match :nth-child(2), and only then div. This patch makes us walk until the end or the next combinator, and only then match backwards, matching first div, then :nth-child. Bug: 1443814 Reviewed-by: bholley Source-Repo: https://github.com/servo/servo Source-Revision: 8e52f8a523e2f12b2666536d0f8ff3fa40b83ef5
f75c77abb835: servo: Merge #20241 - style: Make getting the XBL binding faster (from emilio:xbl-faster); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 11:31:35 -0500 - rev 459727
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
servo: Merge #20241 - style: Make getting the XBL binding faster (from emilio:xbl-faster); r=bholley Source-Repo: https://github.com/servo/servo Source-Revision: 9b540d199e87acdbc7aea51f5b7e4370b187ce09
7daaf289c085: Bug 1443652 part 2. Add a bunch of web platform tests for load and error events on stylesheet links. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 07 Mar 2018 16:06:48 -0500 - rev 459618
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1443652 part 2. Add a bunch of web platform tests for load and error events on stylesheet links. r=bholley MozReview-Commit-ID: 1lieHmpuRtH
ba6cef216a17: Bug 1443652 part 1. Fix the buggy existing load-event test for stylesheets. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 07 Mar 2018 16:06:48 -0500 - rev 459617
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1443652 part 1. Fix the buggy existing load-event test for stylesheets. r=bholley The test was adding the load listener to the <link> _after_ the load event on the <link> had already fired. MozReview-Commit-ID: JAS94H9SNOo
3954a5975f11: Bug 1375913 - Do not disable thread pool in the parent process. r=bholley
Xidorn Quan <me@upsuper.org> - Wed, 07 Mar 2018 14:30:11 +1100 - rev 459380
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1375913 - Do not disable thread pool in the parent process. r=bholley MozReview-Commit-ID: 2EMq1IdlEof
a50ae6e8b614: servo: Merge #20222 - Do not disable thread pool in the parent process (from upsuper:chrome-thread-pool); r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 06 Mar 2018 17:54:34 -0500 - rev 459377
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
servo: Merge #20222 - Do not disable thread pool in the parent process (from upsuper:chrome-thread-pool); r=bholley This is the Servo side change of [bug 1375913](https://bugzilla.mozilla.org/show_bug.cgi?id=1375913). Source-Repo: https://github.com/servo/servo Source-Revision: 3b96fb2cbe8754b30646e8bd914806048c0b6db2
c64f3b38bf58: Bug 1443344. Flag a parent sheet load as failed if an import is blocked by content policy. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 06 Mar 2018 14:45:27 -0500 - rev 459346
Push 8820 by archaeopteryx@coole-files.de at 2018-03-07 14:27 +0000
Bug 1443344. Flag a parent sheet load as failed if an import is blocked by content policy. r=bholley MozReview-Commit-ID: AArgnuHbCYL
6d99da728f77: Bug 1442126. Make sure to consistently fail a sheet load if any of its imports fail. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 06 Mar 2018 14:45:27 -0500 - rev 459345
Push 8820 by archaeopteryx@coole-files.de at 2018-03-07 14:27 +0000
Bug 1442126. Make sure to consistently fail a sheet load if any of its imports fail. r=bholley This fixes a race where we would fail if and only if our last-to-complete import failed. MozReview-Commit-ID: L33bIxlkj08
cb363ac1897a: Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Mar 2018 14:24:17 -0500 - rev 458766
Push 8808 by archaeopteryx@coole-files.de at 2018-03-02 22:13 +0000
Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley MozReview-Commit-ID: HTs3RwEOmZ4
8fc2c103027b: Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Mar 2018 14:24:17 -0500 - rev 458614
Push 8808 by archaeopteryx@coole-files.de at 2018-03-02 22:13 +0000
Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley MozReview-Commit-ID: HTs3RwEOmZ4
65c9ae7b75e3: servo: Merge #20146 - Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads (from bholley:explicit_load_data); r=bholley
Bobby Holley <bobbyholley@gmail.com> - Wed, 28 Feb 2018 11:32:00 -0500 - rev 458187
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20146 - Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads (from bholley:explicit_load_data); r=bholley https://bugzilla.mozilla.org/show_bug.cgi?id=1441896 Source-Repo: https://github.com/servo/servo Source-Revision: e8f77861a9af8d88ba62625838a10d63c74d22ed
d24a4454d076: Bug 1425759: Simplify the style backend type setup. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 25 Feb 2018 17:28:14 +0100 - rev 457997
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1425759: Simplify the style backend type setup. r=bholley Now that what we use to decide whether a document is styled by Servo are only prefs and the doc principal, we don't need to inherit the style backend type, since unless the pref has changed, the result will be the same. MozReview-Commit-ID: KBmeBn1cRne
b45ca837446a: Bug 1439395: Avoid leaving an stale restyle root if there's no servo data on it. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Feb 2018 18:50:19 +0100 - rev 457988
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Avoid leaving an stale restyle root if there's no servo data on it. r=bholley If a single element is inserted in the document, from the lazy frame construction path we mark it as the restyle root. It has no restyle data, and we weren't calling ClearServoData when its parent was being removed from ClearServoDataFromSubtree, thus leaving the stale restyle root. MozReview-Commit-ID: GY812b8tDk0
15ba5a05f9ab: Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 14:46:38 +0100 - rev 457987
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley We used to do it this way effectively until I fixed it in bug 1400936. Per the list of fuzz bugs that bug has in the "Depends on" field, some of those without a super-clear fix, and others that aren't listed in there, and all the complexity we had to deal with while receiving restyle requests mid-unbind, etc, I think this is the right call. This clears data on RestyleManager::ContentRemoved for non-anonymous nodes, and on UnbindFromTree for subtrees rooted at anonymous nodes. This will hopefully yield enforceable invariants. MozReview-Commit-ID: IMwX5Uh1apv
ca30d7a852e7: Bug 1440258: Flag doc level anonymous content instead of guessing. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Feb 2018 02:30:00 +0100 - rev 457517
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1440258: Flag doc level anonymous content instead of guessing. r=bholley Poking at the frame tree has problems: If we poke in negative (using eSkipNativeAnonymousContent), as we were doing, we mess up the case where we're actually _not_ doc-level, and _not_ ::before or ::after. This can't happen for content documents, but can happen for chrome (since nsDocElementBoxFrame implements nsIAnonymousContentCreator). If we poke in positive, as we used to, you get that right, but mess up the root scrollbar case. Instead, use a node property to mark doc level anon content. This is a case rare enough that it seems worth to not steal a node bit. To recap the failure: * The initial value of -moz-control-character-visiblity is different on beta and nightly. * XUL has a global rule setting -moz-control-character-visibility on the root, to a value so that it's the initial one on nightly, but the non-initial one on beta. * Changes to this property cause a reframe. * Reframes of a nsIAnonymousContentCreator anon content reframe the container. * We were failing to inherit correctly for the nsIAnonymousContentCreator content for the root XUL element on the initial styling, inheriting from the default computed values instead, since we failed to reach the root element's primary frame from GetFlattenedTreeParentForDocumentElementNAC -> AppendDocumentLevelNativeAnonymousContentTo, since the primary frame is set _after_ processing children. This seems somewhat risky to change, and inconsistent with any other stuff the frame constructor does, see bug 973390. * Given that, the next restyle of the root element, in this case caused due to the customizable UI, we _found_ the actual correct parent, recomputed the style, saw that -moz-control-character-visiblity had changed, and reframed. But we were reframing the whole window, not just the NAC, because of the fourth bullet point. Reframing the whole window caused us to lose the popup state (that's bug 1440506). Worse than that is the fact that given we reframe and reconstruct the anonymous countent again, we go back to the initial bogus state, just awaiting for the next restyle to reframe the whole window. I wish there was a bullet-proof way to test it that isn't just counting reframes and relying on which properties reframe or not, but due to the nature of nsIAnonymousContentCreator's NAC, it's not possible in any easy way I can think of. MozReview-Commit-ID: IPYB5trsN8R
1218f0cd72df: Bug 1439285: Hack around bug 1406134. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 20:03:43 +0100 - rev 457384
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439285: Hack around bug 1406134. r=bholley MozReview-Commit-ID: Cg2HxB99cGD
90dde2f81fa0: Bug 1439285: Make the old image request arrive to FinishStyle if we come from ResolveSameStructsAs. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 19:44:44 +0100 - rev 457383
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439285: Make the old image request arrive to FinishStyle if we come from ResolveSameStructsAs. r=bholley MozReview-Commit-ID: H1N9jNql9tl
ba27cf3b8520: servo: Merge #20082 - style: Cleanup always-false argument to Servo_ResolveStyleLazily (from emilio:ignore-existing-styles); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Feb 2018 06:09:15 -0500 - rev 457103
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20082 - style: Cleanup always-false argument to Servo_ResolveStyleLazily (from emilio:ignore-existing-styles); r=bholley I changed this setup in https://bugzilla.mozilla.org/show_bug.cgi?id=1414999, because it was totally unsound. Source-Repo: https://github.com/servo/servo Source-Revision: 691f3be24a6fcc90ae7d0b9b0783abf8674e1b0f
3ab4e934cd7f: Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 14:46:38 +0100 - rev 456951
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley We used to do it this way effectively until I fixed it in bug 1400936. Per the list of fuzz bugs that bug has in the "Depends on" field, some of those without a super-clear fix, and others that aren't listed in there, and all the complexity we had to deal with while receiving restyle requests mid-unbind, etc, I think this is the right call. This clears data on RestyleManager::ContentRemoved for non-anonymous nodes, and on UnbindFromTree for subtrees rooted at anonymous nodes. This will hopefully yield enforceable invariants. MozReview-Commit-ID: IMwX5Uh1apv
84dbe2d215f7: Bug 1439016: Remove dead code from Shadow DOM v0. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 18:15:38 +0100 - rev 456928
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Remove dead code from Shadow DOM v0. r=bholley Could do that on a different bug but... MozReview-Commit-ID: L1ri2s8z75f
b8cd6601b753: Bug 1439016: Crashtest. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 18:08:06 +0100 - rev 456927
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Crashtest. r=bholley The crashtest will crash whenever the shell is destroyed, which is annoying, but... MozReview-Commit-ID: 1JkLy5K98bS
6ec2d0d818ce: Bug 1439016: Assert that there's no stale servo data in shadow roots either. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 15:00:37 +0100 - rev 456926
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Assert that there's no stale servo data in shadow roots either. r=bholley Just expanding the assertion to cover shadow trees. MozReview-Commit-ID: FLE0noGzaIF
577a507f9ee1: Bug 1439016: Clear servo data on slot changes too. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 14:54:12 +0100 - rev 456925
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Clear servo data on slot changes too. r=bholley Pretty much the same way as what we do on XBL insertion point changes, since the data would be stale. I think both of those are kind of a hack, btw, and that we could fix it doing ClearServoDataFromSubtree properly before we start unbinding. That'd prevent all these issues, and all the complexity that entails receiving restyle requests mid-unbind (we'd guarantee the tree is always in a stable state). That's a matter of a different bug though. MozReview-Commit-ID: Ev6RvGuPGiv
7a63a457c8e8: Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 16:30:43 +1100 - rev 456919
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley MozReview-Commit-ID: D19QBD4nqWf
2c061c1f3319: Bug 1438497 part 2 - Do not report bindings which are cached in XUL prototype cache. r=bholley
Xidorn Quan <me@upsuper.org> - Mon, 19 Feb 2018 17:27:08 +1100 - rev 456903
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1438497 part 2 - Do not report bindings which are cached in XUL prototype cache. r=bholley MozReview-Commit-ID: 7ZqQswt7QtA
befae37d1035: Bug 1438497 - Add bindings into memory report. r=bholley,njn
Xidorn Quan <me@upsuper.org> - Fri, 16 Feb 2018 23:02:28 +1100 - rev 456846
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1438497 - Add bindings into memory report. r=bholley,njn MozReview-Commit-ID: FrFEUlrqcs8
720647f95790: servo: Merge #20070 - Add sizeof for AuthorStyles (from upsuper:authorstyles-size); r=bholley,njn
Xidorn Quan <me@upsuper.org> - Sun, 18 Feb 2018 23:13:10 -0500 - rev 456845
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20070 - Add sizeof for AuthorStyles (from upsuper:authorstyles-size); r=bholley,njn This is the Servo side change for [bug 1438497](https://bugzilla.mozilla.org/show_bug.cgi?id=1438497). Source-Repo: https://github.com/servo/servo Source-Revision: a98da8ce939e8afe7bac737ac02e3bcb226a1ea9
0264b78fe72b: Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 16:30:43 +1100 - rev 456628
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley MozReview-Commit-ID: D19QBD4nqWf
4e0d4c91940b: Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 13 Feb 2018 16:30:43 +1100 - rev 456506
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1417138 part 2 - Enable stylo-chrome by default. r=bholley MozReview-Commit-ID: D19QBD4nqWf
7369f0c49008: servo: Merge #20016 - Remove reference to the Gecko pref svg.paint-order.enabled (from jfkthame:master); r=bholley
Jonathan Kew <jfkthame@gmail.com> - Sun, 11 Feb 2018 06:57:22 -0500 - rev 455816
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20016 - Remove reference to the Gecko pref svg.paint-order.enabled (from jfkthame:master); r=bholley <!-- Please describe your changes on the following line: --> This pref (to potentially disable support for a CSS property) is to be removed from Gecko, so we should also remove the reference to it in the Servo (stylo) code; the property will be always-supported, just like the majority of others. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). (See gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1437267.) <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because ... it's just removing support for a pref that is never actually used (it has defaulted to true ever since it was introduced in Gecko). <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: aacb9085e566bb4a25e3c882fad3110d862fc13d
fa2042520eb9: Bug 1436276. Bindings should create their return promises in the current compartment even when called over Xrays. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 10 Feb 2018 01:34:10 -0500 - rev 455761
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1436276. Bindings should create their return promises in the current compartment even when called over Xrays. r=bholley These are cases that are implementing the "convert an exception to a Promise" steps of the Web IDL spec. Typically the exception is thrown in the current compartment; the Promise returned should simply match that. Otherwise we can end up with a situation in which the promise doesn't actaully have access to its rejection value, which will cause problems if someone uses then() on the promise: the return value of the then() call will get a sanitized exception instead of the real one. We _could_ try to match the actual compartment of the exception, in theory. But it's not clear why this would be preferable to using the current compartment, even if there were cases in which the exception _doesn't_ match the current compartment. Which there likely are not. MozReview-Commit-ID: Ac2BHIHxfvY
a7613be6bcd2: servo: Merge #20010 - style: Cascade pres hints after normal user rules (from emilio:pres-hints-cascade); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Feb 2018 07:46:38 -0500 - rev 455753
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20010 - style: Cascade pres hints after normal user rules (from emilio:pres-hints-cascade); r=bholley Per https://drafts.csswg.org/css-cascade/#preshint and https://html.spec.whatwg.org/#presentational-hints. This was causing failures in the link color reftests with the preferences sheet as a User sheet. Bug: 1436782 Reviewed-by: bholley MozReview-Commit-ID: 9iwEqPBw4CF Source-Repo: https://github.com/servo/servo Source-Revision: 2cc75a783d1a7e2a82ef1e6502ca5a4463a3fb4b
1f3a5b496acd: Bug 1435596. Give cross-origin objects (windows and locations) a 'then' property in all cases. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 10 Feb 2018 01:21:59 -0500 - rev 455739
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435596. Give cross-origin objects (windows and locations) a 'then' property in all cases. r=bholley For locations, it always returns undefined. For windows, it returns undefined unless there is a named subframe named "then", in which case that named subframe is returned. The idea is to be able to resolve promises with cross-origin objects. MozReview-Commit-ID: HPyTvtwFdsG
87a3fe2c7e9b: Bug 1436782: Insert the prefs sheet at the UA level. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Feb 2018 22:46:06 +0100 - rev 455703
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1436782: Insert the prefs sheet at the UA level. r=bholley Since that's what it's effectively happening anyway. MozReview-Commit-ID: AZGONTbCTNa
48cf4fb1409b: Bug 1436798: style: Move author-style-disabled handling to push_applicable_declarations. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Feb 2018 13:05:28 +0100 - rev 455699
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1436798: style: Move author-style-disabled handling to push_applicable_declarations. r=bholley This will make it easier to handle it properly for Shadow DOM, though this patch doesn't do that. This also makes some method inline and infallible for convenience, since nobody checks the errors anyway. MozReview-Commit-ID: Hq3erAUs5tf
4798fb33e87f: Bug 1435483 part 2. Stop allowing creation of Exception objects via contract/CID. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 05 Feb 2018 16:34:04 -0500 - rev 454933
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1435483 part 2. Stop allowing creation of Exception objects via contract/CID. r=bholley MozReview-Commit-ID: H6RmL4BZfgh
6d21bdf7eab3: Bug 1434474: There's no need to rebuild font / counter styles / font feature values off a runnable. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 31 Jan 2018 11:12:36 +0100 - rev 454516
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1434474: There's no need to rebuild font / counter styles / font feature values off a runnable. r=bholley Everything that needs them up-to-date will call flush appropriately, there should be no need to do it manually. This way we coalesce all the stylist updates until the next style flush in the best case, or until one of the consumers actually needs them. MozReview-Commit-ID: BVsxXxhtcKL
73b38134f4bf: servo: Merge #19787 - style: Make GeckoElement::has_class faster (from emilio:opt-has-class); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Jan 2018 15:15:01 -0600 - rev 451359
Push 8551 by ryanvm@gmail.com at 2018-01-17 15:17 +0000
servo: Merge #19787 - style: Make GeckoElement::has_class faster (from emilio:opt-has-class); r=bholley By force-inlining the fast path, and pulling out a branch that rust didn't manage to pull out. Source-Repo: https://github.com/servo/servo Source-Revision: 1ac35dc7abd0b984838dfa4be581a319158190a5
8be5c5375a90: Bug 1430164. Stop doing weird sandbox-callable-wrapping for DOM constructors. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 12 Jan 2018 14:28:28 -0500 - rev 450953
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
Bug 1430164. Stop doing weird sandbox-callable-wrapping for DOM constructors. r=bholley This fixes DOM constructor identity in web extension content scripts to work as expected. MozReview-Commit-ID: Ab4sFWiMU6c
31e94d208ac2: servo: Merge #19751 - Clean up the selectors crate for a new crates.io release (from servo:selectors); r=bholley
Simon Sapin <simon.sapin@exyr.org> - Fri, 12 Jan 2018 16:55:12 -0600 - rev 450939
Push 8543 by ryanvm@gmail.com at 2018-01-16 14:33 +0000
servo: Merge #19751 - Clean up the selectors crate for a new crates.io release (from servo:selectors); r=bholley Source-Repo: https://github.com/servo/servo Source-Revision: 6ca651c0c8271ce185448e1db95b893a276eaed9
777faf67f590: Bug 1405635: Test that custom content doesn't inherit from the root element. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Oct 2017 01:40:48 +0200 - rev 435583
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405635: Test that custom content doesn't inherit from the root element. r=bholley MozReview-Commit-ID: GvjsdQk5Wt4
1df4622b548b: Bug 1405635: Test that custom content doesn't inherit from the root element. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Oct 2017 01:40:48 +0200 - rev 435564
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1405635: Test that custom content doesn't inherit from the root element. r=bholley MozReview-Commit-ID: GvjsdQk5Wt4
7e8237735403: Bug 1403699 Part 1: Unify ServoBindings synchronization primitives into a single RWLock. r=bholley
Brad Werth <bwerth@mozilla.com> - Tue, 03 Oct 2017 12:57:38 -0700 - rev 435201
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403699 Part 1: Unify ServoBindings synchronization primitives into a single RWLock. r=bholley MozReview-Commit-ID: GdYLEQHiM1f
be0e197531f2: servo: Merge #18712 - stylo: use FnvHashMap everywhere, remove default HashMap construction methods (from Manishearth:fnv); r=bholley
Manish Goregaokar <manishsmail@gmail.com> - Tue, 03 Oct 2017 18:47:46 -0500 - rev 435072
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
servo: Merge #18712 - stylo: use FnvHashMap everywhere, remove default HashMap construction methods (from Manishearth:fnv); r=bholley r=bholley bug 1385971 Source-Repo: https://github.com/servo/servo Source-Revision: 89724c6b32c6c0b7673df6d5b735e057a392f51b
93de74a2302a: Bug 1403397 - Revert: Round hashglobe allocations up to the nearest page size. r=bholley
Bobby Holley <bobbyholley@gmail.com> - Tue, 03 Oct 2017 10:09:08 -0700 - rev 435030
Push 8114 by jlorenzo@mozilla.com at 2017-11-02 16:33 +0000
Bug 1403397 - Revert: Round hashglobe allocations up to the nearest page size. r=bholley This reverts commit a4aba77facc8ceab1e0d7f7d796075a6606b15c6. MozReview-Commit-ID: 7quMDoDmqxL