searching for reviewer(bholley)
81ac511f7ff4: Bug 1405635 - Test that custom content doesn't inherit from the root element. r=bholley, a=ritu
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 Oct 2017 01:40:48 +0200 - rev 432298
Push 7927 by ryanvm@gmail.com at 2017-10-09 18:10 +0000
Bug 1405635 - Test that custom content doesn't inherit from the root element. r=bholley, a=ritu MozReview-Commit-ID: GvjsdQk5Wt4
b2fab82b2d77: Bug 1403699 - Unify ServoBindings synchronization primitives into a single RWLock. r=bholley, a=ritu
Brad Werth <bwerth@mozilla.com> - Tue, 03 Oct 2017 12:57:38 -0700 - rev 432262
Push 7923 by ryanvm@gmail.com at 2017-10-09 15:16 +0000
Bug 1403699 - Unify ServoBindings synchronization primitives into a single RWLock. r=bholley, a=ritu MozReview-Commit-ID: GdYLEQHiM1f
3a3dd3b7cfc6: Bug 1385971 - #18712 - stylo: use FnvHashMap everywhere, remove default HashMap construction methods (from Manishearth:fnv); r=bholley,a=ritu
Manish Goregaokar <manishsmail@gmail.com> - Tue, 03 Oct 2017 18:47:46 -0500 - rev 432198
Push 7899 by bholley@mozilla.com at 2017-10-05 05:13 +0000
Bug 1385971 - #18712 - stylo: use FnvHashMap everywhere, remove default HashMap construction methods (from Manishearth:fnv); r=bholley,a=ritu r=bholley bug 1385971 Source-Repo: https://github.com/servo/servo Source-Revision: 89724c6b32c6c0b7673df6d5b735e057a392f51b MozReview-Commit-ID: 9xwpLDsyXef
1c7e7fda6b0d: Bug 1403712 - Crashtest. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Sep 2017 14:19:23 +0200 - rev 432068
Push 7874 by ryanvm@gmail.com at 2017-10-02 16:29 +0000
Bug 1403712 - Crashtest. r=bholley, a=sledru MozReview-Commit-ID: DtOKa8V4deq Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
fd9bd6556ea8: Bug 1403712 - Clear the restyle root at the end of UnbindFromTree too. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Sep 2017 14:18:36 +0200 - rev 432067
Push 7874 by ryanvm@gmail.com at 2017-10-02 16:29 +0000
Bug 1403712 - Clear the restyle root at the end of UnbindFromTree too. r=bholley, a=sledru MozReview-Commit-ID: 7swfspMWUe6 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
c5ae2d14772f: Bug 1403712 - Make some assertions not assert for conditions that may happen mid-unbind. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Sep 2017 14:17:41 +0200 - rev 432066
Push 7874 by ryanvm@gmail.com at 2017-10-02 16:29 +0000
Bug 1403712 - Make some assertions not assert for conditions that may happen mid-unbind. r=bholley, a=sledru MozReview-Commit-ID: DNSphdMismy Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
5a5d0e596c1d: Bug 1403465 - style: Avoid creating element data in Servo_ResolvePseudoStyle. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 28 Sep 2017 10:40:02 +0200 - rev 432061
Push 7873 by ryanvm@gmail.com at 2017-10-02 15:43 +0000
Bug 1403465 - style: Avoid creating element data in Servo_ResolvePseudoStyle. r=bholley, a=sledru The reason the patch in bug 1402285 doesn't work is that we call this function multiple times with the same element. This fixes it. MozReview-Commit-ID: Ko9zirCOzTR
dade9951a461: Bug 1403615 - Also follow the NODE_DESCENDANTS_NEED_FRAMES bit in ClearRestyleStateFromSubtree. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Sep 2017 19:19:12 +0200 - rev 432044
Push 7872 by ryanvm@gmail.com at 2017-10-02 15:07 +0000
Bug 1403615 - Also follow the NODE_DESCENDANTS_NEED_FRAMES bit in ClearRestyleStateFromSubtree. r=bholley, a=sledru We don't follow this bit intentionally because we know that even if it's set, when none of the other two bits are set there are no other restyle / change hints down the tree. We rely on the frame constructor to clean the mess up, though, and it doesn't really do a good work about it. In particular, the case we're hitting on the test-case is: <body descendant-need-frames change=reconstruct style="display: table-column-group"> <div descendant-need-frames> <div descendant-need-frames> <span needs-frame></span> </div> </div> </body> When we see we need to reconstruct the body, we call ClearRestyleStateFromSubtree, but that doesn't do much now, since we don't follow the descendant-need-frames bits. Then, when we reconstruct the content, we arrive at[1] when constructing the first child <div>. The <div> flags have been cleared, but not the children's! Then a text-node is inserted in a <div>, breaking all sorts of invariants. This is the easiest fix. Other fixes include clearing the flags on SetAsUndisplayedContent. But that implies not clearing them in ShouldCreateItemsForChild, and doing that somewhere more sensible. I suspect it's not too hard, but that's a slightly more risky change, will do it if you prefer it. [1]: http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/layout/base/nsCSSFrameConstructor.cpp#6092 MozReview-Commit-ID: 7026wkQLQkz
35bae846b629: Bug 1402094 - Blacklist about:reader from using stylo. r=bholley, a=sledru
Xidorn Quan <me@upsuper.org> - Thu, 28 Sep 2017 16:19:45 +1000 - rev 432036
Push 7871 by ryanvm@gmail.com at 2017-10-02 14:28 +0000
Bug 1402094 - Blacklist about:reader from using stylo. r=bholley, a=sledru MozReview-Commit-ID: 6cG1x1tcOwn
87e4233eab27: Bug 1403024 - Part 1: Add nsContentUtils::SchemeIs helper function. r=bholley, a=sledru
Xidorn Quan <me@upsuper.org> - Tue, 26 Sep 2017 10:21:01 +1000 - rev 431950
Push 7844 by ryanvm@gmail.com at 2017-09-28 14:49 +0000
Bug 1403024 - Part 1: Add nsContentUtils::SchemeIs helper function. r=bholley, a=sledru MozReview-Commit-ID: 2NVc5QJSjl
12d437dedc4d: Bug 1402366 - Mark datetimebox as not needing xul.css. r=bholley, r=jessica, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 21:23:11 +0200 - rev 431932
Push 7843 by ryanvm@gmail.com at 2017-09-28 13:51 +0000
Bug 1402366 - Mark datetimebox as not needing xul.css. r=bholley, r=jessica, a=sledru We create a datetimebox in content documents that gets an XBL binding on nsDateTimeControlFrame::CreateAnonymousContent. This is done during frame construction, and loading a datetimebox insert xul.css in the document, which causes invalidation to run. datetimebox styles are in html.css, and there's no rule in xul.css that styles it, so we don't need to load the stylesheet at all. MozReview-Commit-ID: 2SbIOoER2uB
1512bd018892: Bug 1402472 - servo: style: Make sure to not run any style invalidation in an unstyled children only traversal. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 22 Sep 2017 21:16:43 -0500 - rev 431852
Push 7822 by ryanvm@gmail.com at 2017-09-25 14:41 +0000
Bug 1402472 - servo: style: Make sure to not run any style invalidation in an unstyled children only traversal. r=bholley, a=sledru MozReview-Commit-ID: IFPA7LJpvsZ Source-Repo: https://github.com/servo/servo Source-Revision: 5a6b90b14ff709eab41493a05c8235c522d35250
3fa652b178a2: Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 24 Sep 2017 19:16:10 +0200 - rev 431840
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1402684 - Clear the servo data early, but the flags later, in UnbindFromTree. r=bholley, a=sledru MozReview-Commit-ID: 5rRGKq39smW
99992ed2b3f3: Bug 1400936 - Crashtests. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:12:33 +0200 - rev 431839
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Crashtests. r=bholley, a=sledru MozReview-Commit-ID: 6Q07StWSog Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
ca0193447310: Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:05:47 +0200 - rev 431838
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r=bholley, a=sledru This is the actual fix, and makes sure that the state is consistent even if we notify of state changes on a parent during unbind. We potentially do a bit more work than needed given we set the document as the root in that case instead of the parent which could potentially be the root itself, but that's not a huge deal I think, given these cases are rare. If this happens to be a perf problem, we may want to just drop the root during UnbindFromTree if aNullParent == true and the root is a descendant of `this`. MozReview-Commit-ID: A9d2igM0hMr Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
6b96a0fab002: Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:59 +0200 - rev 431837
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r=bholley, a=sledru This is the reason similar assertion failures can't be reproduced with elements and stuff like fieldset and form validity changes. nsBindingManager::ContentRemoved calls SetXBLInsertionParent, which clears all the Servo data from the subtree eagerly, which is a waste when the actual binding parent is the same (null). MozReview-Commit-ID: A5wLKfD4OTL Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2d4c045f3066: Bug 1400936 - Remove dumb null check. r=bholley, a=sledru
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:30 +0200 - rev 431836
Push 7821 by ryanvm@gmail.com at 2017-09-25 14:09 +0000
Bug 1400936 - Remove dumb null check. r=bholley, a=sledru MozReview-Commit-ID: CLs2UcA8DF9 Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
ae92b4765e63: Bug 1401792 - Release assert when adopting element with style data across style backend. r=bholley
Xidorn Quan <me@upsuper.org> - Thu, 21 Sep 2017 14:41:21 +1000 - rev 431673
Push 7785 by ryanvm@gmail.com at 2017-09-21 13:39 +0000
Bug 1401792 - Release assert when adopting element with style data across style backend. r=bholley MozReview-Commit-ID: 6D6bvSJHEcS
18723c6944b1: Bug 1400540 - Decide style backend type based on principal. r=bholley
Xidorn Quan <me@upsuper.org> - Wed, 20 Sep 2017 08:26:53 +1000 - rev 431336
Push 7782 by ryanvm@gmail.com at 2017-09-20 11:51 +0000
Bug 1400540 - Decide style backend type based on principal. r=bholley MozReview-Commit-ID: A4y9Shdbr7g
5fa2260faa05: Bug 1399006 - Invoke PurgeCachedImages to release object in main thread while ServoTraversal. r=bholley
vincentliu <vliu@mozilla.com> - Tue, 19 Sep 2017 15:13:27 +0800 - rev 431165
Push 7781 by ryanvm@gmail.com at 2017-09-20 00:42 +0000
Bug 1399006 - Invoke PurgeCachedImages to release object in main thread while ServoTraversal. r=bholley
cd3a11354b72: Bug 1399546: Remove broken code for handling the body text color. r=bholley,Manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 15 Sep 2017 22:52:26 +0200 - rev 430755
Push 7768 by ryanvm@gmail.com at 2017-09-16 16:13 +0000
Bug 1399546: Remove broken code for handling the body text color. r=bholley,Manishearth MozReview-Commit-ID: AfAT9DgzvI7
9232bc78ae68: Bug 1398619 - Correctly inherit backend for document created by DOMParser, and add test for it. r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 12 Sep 2017 14:28:27 +1000 - rev 429695
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1398619 - Correctly inherit backend for document created by DOMParser, and add test for it. r=bholley The old code doesn't work because mScriptHandlingObject is a nsWeakPtr, which cannot be casted to nsPIDOMWindowInner directly. Since scriptHandlingObject is a strong reference to the same object, we can just try casting that. MozReview-Commit-ID: JRBs5N6xxc0
903b743e407e: servo: Merge #18434 - Bug 1395064 - stylo: Add uses of fallible Vec, SmallVec and HashMap f… (from julian-seward1:master); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 10 Sep 2017 12:30:39 -0500 - rev 429462
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18434 - Bug 1395064 - stylo: Add uses of fallible Vec, SmallVec and HashMap f… (from julian-seward1:master); r=bholley …acilities. r=emilio@crisal.io. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: be804a8155b0a942324f564df569233d13c97dcd
8f53032e5451: Bug 1397472 - Measure ElementData. r=bholley.
Nicholas Nethercote <nnethercote@mozilla.com> - Sat, 09 Sep 2017 00:12:25 +1000 - rev 429372
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1397472 - Measure ElementData. r=bholley. We already measure (in Rust code) the things hanging off it, but overlooked the object itself. This patch adds measurement on the C++ side.
3352077c1e39: servo: Merge #18422 - style: Remove stale todo about handling scrollbars in viewport units (from emilio:stale-todo); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 08 Sep 2017 16:30:26 -0500 - rev 429335
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18422 - style: Remove stale todo about handling scrollbars in viewport units (from emilio:stale-todo); r=bholley This is effectively not going to happen, per https://github.com/w3c/csswg-drafts/issues/1766 Source-Repo: https://github.com/servo/servo Source-Revision: 9c0abfea239077bc490ed8a2d4a7c32ba782942d
95543c372e9f: servo: Merge #18412 - Increase stack safety margin for stylo (from bholley:bump_style_stacks); r=bholley
Bobby Holley <bobbyholley@gmail.com> - Thu, 07 Sep 2017 13:52:48 -0500 - rev 429057
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18412 - Increase stack safety margin for stylo (from bholley:bump_style_stacks); r=bholley https://bugzilla.mozilla.org/show_bug.cgi?id=1395708 Source-Repo: https://github.com/servo/servo Source-Revision: 8868d2223dbb28b07ae1936095bc9ec644fe58a7
4d492424cba2: Bug 1397371 - Remove the telemetry for ensuring that documents and friends can never end up with an expanded principal; r=bholley
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 06 Sep 2017 14:05:02 -0400 - rev 428862
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1397371 - Remove the telemetry for ensuring that documents and friends can never end up with an expanded principal; r=bholley
1fc9e24649a8: Bug 1396570: Null check getter/setter when JSPROP_GETTER/JSPROP_SETTER is set. r=bholley f=jandem
Kris Maglione <maglione.k@gmail.com> - Mon, 04 Sep 2017 17:27:31 -0700 - rev 428626
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1396570: Null check getter/setter when JSPROP_GETTER/JSPROP_SETTER is set. r=bholley f=jandem These flags don't guarantee that the getter and setter functions are defined. MozReview-Commit-ID: GBcoRYoKHqL
7b3215e18443: Bug 1330412 - Enable Stylo by default. r=bholley,froydnj
J. Ryan Stinnett <jryans@gmail.com> - Thu, 24 Aug 2017 18:22:22 -0500 - rev 428527
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1330412 - Enable Stylo by default. r=bholley,froydnj MozReview-Commit-ID: LqrUHJ4WNFG
49d106783eec: servo: Merge #18384 - style: Don't waste a whole selector map for each class / id in the document (from emilio:invalidation-map-bloat); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Sep 2017 12:51:17 -0500 - rev 428503
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18384 - style: Don't waste a whole selector map for each class / id in the document (from emilio:invalidation-map-bloat); r=bholley On top of #18375, only last commit needs review. Source-Repo: https://github.com/servo/servo Source-Revision: 4721ef81fd7fb6ee15546a6abe140a66ce0280e8
1130f8849a63: servo: Merge #18366 - style: Avoid dropping the other threads' TLS contexts too early (from emilio:fix-statistics-crash); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 04 Sep 2017 11:54:15 -0500 - rev 428275
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18366 - style: Avoid dropping the other threads' TLS contexts too early (from emilio:fix-statistics-crash); r=bholley When collecting style statistics, we have this path that moves the TLS contexts to be dropped before the local context. Since destroying the TLS context runs the sequential task queue, that means that sequential tasks would be executed sooner than usual, before we drop the main thread TLS context. Since we have that reuse of the main thread context's bloom filter, and some tasks end up creating one (Servo_StyleSet_GetBaseComputedValuesForElement, I'm looking at you), we may borrow the bloom filter before we're done with it on the traversal code path. This was hitting on YouTube, when DUMP_STYLE_STATISTICS was used. Source-Repo: https://github.com/servo/servo Source-Revision: 4608955949aa20a2d2ed251b56e9a5a3cf5681c5
b24a12ef6a1d: servo: Merge #18350 - stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname (from emilio:ship-system-metric-stuff); r=bholley,manishearth
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Sep 2017 02:49:29 -0500 - rev 427936
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18350 - stylo: Expose -moz-system-metric and -moz-empty-except-children-with-localname (from emilio:ship-system-metric-stuff); r=bholley,manishearth They don't have the flag in Gecko. Though I wonder if we could unship them from non-UA sheets. Bug: 1396048 Reviewed-by: bholley MozReview-Commit-ID: LGzGDjCZpJC Source-Repo: https://github.com/servo/servo Source-Revision: e0e09538fa97f5568c52266ee969ec21432e72f7
1f5bed26622a: Bug 1363482: Part 6 - Add Cu.readFile helper to access the file preloader from JS. r=bholley
Kris Maglione <maglione.k@gmail.com> - Thu, 31 Aug 2017 17:02:06 -0700 - rev 427915
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1363482: Part 6 - Add Cu.readFile helper to access the file preloader from JS. r=bholley MozReview-Commit-ID: B7kSvhxbL4f
f11a526ada48: Bug 1394598. Stop using a belt-and-suspenders opaque wrapper for eval and Function when they're being exposed by SpecialPowers. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 01 Sep 2017 16:30:57 -0400 - rev 427870
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394598. Stop using a belt-and-suspenders opaque wrapper for eval and Function when they're being exposed by SpecialPowers. r=bholley
c2bc5c2bbb2e: Bug 1395351: Use the parallel traversal flag more often. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Sep 2017 19:28:57 +0200 - rev 427803
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395351: Use the parallel traversal flag more often. r=bholley MozReview-Commit-ID: JF6i0HDniR2
2c92da356508: Bug 1395351: Assert the root element is styled in StyleDocument. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Sep 2017 19:31:45 +0200 - rev 427802
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395351: Assert the root element is styled in StyleDocument. r=bholley MozReview-Commit-ID: 6KncJ5IqLbt
ec07132e0715: Bug 1395351: Don't clobber restyle root flags from frame construction. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 21:37:50 +0200 - rev 427801
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395351: Don't clobber restyle root flags from frame construction. r=bholley MozReview-Commit-ID: EsXKiLbYQsY
1feb294747ee: Bug 1395351: Use the style flattened tree in EffectCompositor::PreTraverseInSubtree. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Sep 2017 19:28:01 +0200 - rev 427800
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1395351: Use the style flattened tree in EffectCompositor::PreTraverseInSubtree. r=bholley MozReview-Commit-ID: ATVxx8EXJWY
a0bef0340a9d: Bug 1374235: style: Remove the for reconstruction traversals. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 21:21:49 +0200 - rev 427714
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1374235: style: Remove the for reconstruction traversals. r=bholley One less hack, a few more to go. MozReview-Commit-ID: 6katL1EGn2U
ae11f1948d45: servo: Merge #18342 - style: Remove the for reconstruction traversals (from emilio:die-forreconstruct-die); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 01 Sep 2017 08:56:58 -0500 - rev 427707
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
servo: Merge #18342 - style: Remove the for reconstruction traversals (from emilio:die-forreconstruct-die); r=bholley One less hack, a few more to go. Bug: 1374235 Reviewed-by: bholley MozReview-Commit-ID: 6katL1EGn2U Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io> Source-Repo: https://github.com/servo/servo Source-Revision: 876b70b02c7a3c8aad26b26dcbcfddaa5c747493
35afffcb4182: Bug 1374235: style: Remove the for reconstruction traversals. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 21:21:49 +0200 - rev 427671
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1374235: style: Remove the for reconstruction traversals. r=bholley One less hack, a few more to go. MozReview-Commit-ID: 6katL1EGn2U
fe4bf0764f4d: Bug 1394935 - A crash test. r=bholley
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Fri, 01 Sep 2017 13:27:11 +0900 - rev 427588
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935 - A crash test. r=bholley MozReview-Commit-ID: 1zSJPx2sVbi
8daf204f77fb: Bug 1394935: Add a special case for marking something as dirty from invalidation code. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:26 +0200 - rev 427559
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Add a special case for marking something as dirty from invalidation code. r=bholley Not sure about the name, or whether making it a static or not (a static seemed slightly clearer, but nbd, feel free to bikeshed about it). MozReview-Commit-ID: FHGmcoprN2Q
c3f9a3e2ce96: Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:25 +0200 - rev 427558
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Assert that if we find a common ancestor using the dirty bits, it is the actual common flattened tree ancestor. r=bholley MozReview-Commit-ID: GRJ539QXS9e
3b1074717dac: Bug 1394935: Fix a little typo in NoteDirtyElement. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:23 +0200 - rev 427557
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Fix a little typo in NoteDirtyElement. r=bholley MozReview-Commit-ID: LMQlNcJjz80
089cbcabf67a: Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:22 +0200 - rev 427556
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Assert that we don't call into NoteDirtyElement with extra bits on the restyle root's parent chain. r=bholley MozReview-Commit-ID: Kt5aZSRBvlE
9fad64b68cbc: Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:21 +0200 - rev 427555
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Assert that the content we're marking dirty is under the restyle root. r=bholley This would also have catched the bug earlier. MozReview-Commit-ID: 8uNXPnpXk6m
5ededad9baca: Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:20 +0200 - rev 427554
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Add a (commented out for now) assertion about clobbering dirty bits. r=bholley Will get this fixed tomorrow, I have patches but forgot to push to try. MozReview-Commit-ID: 3Dcb1MTo8g5
88227ffe3c6e: Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:19 +0200 - rev 427553
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Assert that the new root is always higher up in the tree than the old root. r=bholley The bug here is that we're clobbering a restyle root with another one which is down in the tree, when calling NoteDirtyElement on the document element with the flags already propagated. This assertion would've catched it earlier, and make it more obvious. MozReview-Commit-ID: 3mucQvr7A1x
f8c9e983f36c: Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 09:42:24 +0200 - rev 427552
Push 7761 by jlund@mozilla.com at 2017-09-15 00:19 +0000
Bug 1394935: Introduce nsContentUtils::CommonFlattenedTreeAncestorForStyle. r=bholley MozReview-Commit-ID: GThZUOIe30o