searching for reviewer(bholley)
560f881dffb8: Bug 1457325 - Expose time to DOMContentFlushed on the timeline. r=bholley,r=mstange
Bobby Holley <bobbyholley@gmail.com> - Thu, 26 Apr 2018 15:36:52 -0700 - rev 469688
Push 9174 by archaeopteryx@coole-files.de at 2018-04-30 15:33 +0000
Bug 1457325 - Expose time to DOMContentFlushed on the timeline. r=bholley,r=mstange MozReview-Commit-ID: E6QPjgfUKdo
56a2a8cc35fd: Bug 1456350 - Forward webrender error log to gfxCriticalNote r=bholley
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 27 Apr 2018 16:48:39 +0900 - rev 469579
Push 9171 by ryanvm@gmail.com at 2018-04-28 10:35 +0000
Bug 1456350 - Forward webrender error log to gfxCriticalNote r=bholley
36a7b939360d: Bug 1457026: followup: Skip a rustest that depends on include order and isn't super-useful. r=bholley on a CLOSED TREE
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Apr 2018 19:11:35 +0200 - rev 469398
Push 9171 by ryanvm@gmail.com at 2018-04-28 10:35 +0000
Bug 1457026: followup: Skip a rustest that depends on include order and isn't super-useful. r=bholley on a CLOSED TREE MozReview-Commit-ID: 3lwAyl8aztW
046d0e259116: Bug 1455492: While here, fix refcount churn. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Apr 2018 03:45:04 +0200 - rev 468476
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1455492: While here, fix refcount churn. r=bholley MozReview-Commit-ID: 88jzsn25e53
c007f07170a5: Bug 1455492: Remove redundant ParseSheet arguments. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 Apr 2018 03:42:00 +0200 - rev 468475
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1455492: Remove redundant ParseSheet arguments. r=bholley For the async caller, pretty much everything can be extracted out of the loader / loadData. For the sync callers, we need to be a bit more careful because ReparseSheet tries to get its line number on its own. I changed the compat mode passed to the reparse stuff to be the document's one in this case, but that seems a bug fix. MozReview-Commit-ID: 2wi5HPRAlPi
3692b02e7ca2: Bug 1436782: Insert the prefs sheet at the UA level. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Feb 2018 22:46:06 +0100 - rev 468074
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1436782: Insert the prefs sheet at the UA level. r=bholley Since that's what it's effectively happening anyway. MozReview-Commit-ID: AZGONTbCTNa
20b1c2e6fceb: Bug 1452143: Fix dom / style tests. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 16 Apr 2018 16:40:15 +0200 - rev 467617
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452143: Fix dom / style tests. r=bholley MozReview-Commit-ID: 95JfwBVDdRD
8c85b98829b2: Bug 1452143: Make InspectorUtils.getAllStyleSheets handle Shadow DOM, and also optionally not return UA / User sheets. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 16 Apr 2018 19:10:57 +0200 - rev 467612
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452143: Make InspectorUtils.getAllStyleSheets handle Shadow DOM, and also optionally not return UA / User sheets. r=bholley We don't want to reparse over and over shared sheets, and that confused code pretty heavily. MozReview-Commit-ID: 7qkXoCoPNFW
3f214ca585db: Bug 1452143: Expose and honor a cssErrorReportingEnabled in the docshell. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Apr 2018 11:59:09 +0200 - rev 467611
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452143: Expose and honor a cssErrorReportingEnabled in the docshell. r=bholley The idea would be for parallel CSS parsing to check the static methods in ErrorReporter before loading the sheet. MozReview-Commit-ID: D7cedJQpz9K
2c051e8bfb3e: Bug 1452627: Fix nsStyleContentAttr stuff. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Apr 2018 21:04:22 +0200 - rev 466668
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452627: Fix nsStyleContentAttr stuff. r=bholley MozReview-Commit-ID: 4hi75VQcmkN
f6e323494896: Bug 1452916: Remove dead error reporting code. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Apr 2018 12:26:13 +0200 - rev 466208
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452916: Remove dead error reporting code. r=bholley MozReview-Commit-ID: GAn0ASQzBt
81fd385c9197: Bug 1452916: Expose the error reporting pref. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 10 Apr 2018 12:03:48 +0200 - rev 466207
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1452916: Expose the error reporting pref. r=bholley MozReview-Commit-ID: wkUSJ50Nne
151e6dc2df8e: Bug 474655: Add a deprecation warning + use counter to GetPropertyCSSValue. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Mar 2018 14:13:29 +0100 - rev 461869
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 474655: Add a deprecation warning + use counter to GetPropertyCSSValue. r=bholley The use counter comes built-in with the DeprecatedOperationList stuff. MozReview-Commit-ID: 9Opag1NMp32
dd1c00afe429: Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 05 Mar 2018 10:57:12 +0100 - rev 461791
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley This should hopefully make pushPrefEnv able to deal with it. I optimistically enabled Android too, pending a CI run. MozReview-Commit-ID: 47C4q0lzIek
3ae212da6586: servo: Merge #20302 - Include some traversal statistics in style tracing marker (from upsuper:traversal-stats); r=bholley
Xidorn Quan <me@upsuper.org> - Wed, 14 Mar 2018 21:01:08 -0400 - rev 461750
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
servo: Merge #20302 - Include some traversal statistics in style tracing marker (from upsuper:traversal-stats); r=bholley This is the Servo side changes of [bug 1444296](https://bugzilla.mozilla.org/show_bug.cgi?id=1444296). Source-Repo: https://github.com/servo/servo Source-Revision: 8e6cfbca47a259f20ba1c0d09e599169372d4930
ab2df71dc9de: Bug 1444296 part 1 - Have servo report traversal statistics to gecko. r=bholley
Xidorn Quan <me@upsuper.org> - Thu, 15 Mar 2018 11:59:22 +1100 - rev 461746
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1444296 part 1 - Have servo report traversal statistics to gecko. r=bholley MozReview-Commit-ID: 52YO9mzvneR
ba24b6cd4de9: Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley
Tom Ritter <tom@mozilla.com> - Fri, 09 Mar 2018 20:12:53 -0600 - rev 461730
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley PresShell only uses performane.now to track refresh times, and notify internal observers. We can provide more accurate times by not clamping and jittering these numbers. MozReview-Commit-ID: FkDGJhrLeAy
92200efbd20c: Bug 1443415: Move nsPresContext::NotifyFontFaceSetOnRefresh to nsIPresShell. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 06 Mar 2018 09:01:35 +0100 - rev 461721
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1443415: Move nsPresContext::NotifyFontFaceSetOnRefresh to nsIPresShell. r=bholley The font face set is owned by the document now, and the shell knows about refresh driver ticks. There's no reason for it to live in the pres context. MozReview-Commit-ID: I8gtimok7VG
c407e9656999: Bug 1442804 - heap write analysis: nsTArray owns its header, r=bholley
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:46:28 -0800 - rev 461629
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1442804 - heap write analysis: nsTArray owns its header, r=bholley
228f3feb9061: Bug 1442804 - heap write analysis: whitelist GetAutoArrayBuffer, which returns a pointer into |this|, r=bholley
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:45:56 -0800 - rev 461628
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1442804 - heap write analysis: whitelist GetAutoArrayBuffer, which returns a pointer into |this|, r=bholley
277393616f91: Bug 1442804 - heap write analysis: explicitly whitelist stringbuffer canary field, r=bholley
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:44:42 -0800 - rev 461627
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1442804 - heap write analysis: explicitly whitelist stringbuffer canary field, r=bholley
3ae1535c7890: Bug 1442804 - heap write analysis: whitelist all atomics, r=bholley
Steve Fink <sfink@mozilla.com> - Tue, 06 Mar 2018 08:43:36 -0800 - rev 461626
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
Bug 1442804 - heap write analysis: whitelist all atomics, r=bholley
2b2a4a2c4a90: servo: Merge #20223 - style: Allow to share style across elements with similar XBL bindings (from emilio:share-xbl); r=xidorn,bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 12 Mar 2018 16:48:36 -0400 - rev 461265
Push 9165 by asasaki@mozilla.com at 2018-04-26 21:04 +0000
servo: Merge #20223 - style: Allow to share style across elements with similar XBL bindings (from emilio:share-xbl); r=xidorn,bholley Also move the checks so that the tag name checks (presumably cheaper) come earlier. Source-Repo: https://github.com/servo/servo Source-Revision: 087cf21d79cb090c2a8b55b441e6004921b540aa
d7611ae5168b: Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley a=jcristau
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 05 Mar 2018 10:57:12 +0100 - rev 460918
Push 9094 by archaeopteryx@coole-files.de at 2018-04-19 16:18 +0000
Bug 1369411: Use a runnable instead of a timer for pref changes in nsPresContext. r=bholley a=jcristau This should hopefully make pushPrefEnv able to deal with it. I optimistically enabled Android too, pending a CI run. MozReview-Commit-ID: 47C4q0lzIek
e3104f4386e8: Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley a=jcristau
Tom Ritter <tom@mozilla.com> - Fri, 09 Mar 2018 20:12:53 -0600 - rev 460251
Push 8891 by rgurzau@mozilla.com at 2018-03-21 13:06 +0000
Bug 1443943 Allow internal callers of performance.now() to opt-out of clamping/jittering r=bholley a=jcristau PresShell only uses performane.now to track refresh times, and notify internal observers. We can provide more accurate times by not clamping and jittering these numbers. MozReview-Commit-ID: FkDGJhrLeAy
2f58f0b2f939: Bug 1444679: Remove WrappedJSIdentity. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Mar 2018 03:13:47 +0100 - rev 460069
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444679: Remove WrappedJSIdentity. r=bholley Seemed to only be used for the method that was removed in the previous patch. MozReview-Commit-ID: 1cKpVBlxa7r
c5e091682eb1: Bug 1444679: Remove unused nsXPCWrappedJSClass::IsWrappedJS. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 11 Mar 2018 02:36:46 +0100 - rev 460068
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444679: Remove unused nsXPCWrappedJSClass::IsWrappedJS. r=bholley MozReview-Commit-ID: KnNOjaEpa0g
2ea235b4dedb: Bug 1444507: Remove unused binding functions. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 09 Mar 2018 20:10:22 +0100 - rev 459993
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
Bug 1444507: Remove unused binding functions. r=bholley MozReview-Commit-ID: EGceLrhKVIm
258c14f97fa2: servo: Merge #20248 - style: Change the order we match selectors on invalidation to match normal order (from emilio:invalidation-selectors-faster); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 18:44:29 -0500 - rev 459807
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
servo: Merge #20248 - style: Change the order we match selectors on invalidation to match normal order (from emilio:invalidation-selectors-faster); r=bholley This changes the order to match the normal selector-matching order, which is usually faster. That is, when matching div:nth-child(2), for example, before this patch we'd first try to match :nth-child(2), and only then div. This patch makes us walk until the end or the next combinator, and only then match backwards, matching first div, then :nth-child. Bug: 1443814 Reviewed-by: bholley Source-Repo: https://github.com/servo/servo Source-Revision: 8e52f8a523e2f12b2666536d0f8ff3fa40b83ef5
f75c77abb835: servo: Merge #20241 - style: Make getting the XBL binding faster (from emilio:xbl-faster); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Mar 2018 11:31:35 -0500 - rev 459727
Push 8824 by archaeopteryx@coole-files.de at 2018-03-12 14:54 +0000
servo: Merge #20241 - style: Make getting the XBL binding faster (from emilio:xbl-faster); r=bholley Source-Repo: https://github.com/servo/servo Source-Revision: 9b540d199e87acdbc7aea51f5b7e4370b187ce09
7daaf289c085: Bug 1443652 part 2. Add a bunch of web platform tests for load and error events on stylesheet links. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 07 Mar 2018 16:06:48 -0500 - rev 459618
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1443652 part 2. Add a bunch of web platform tests for load and error events on stylesheet links. r=bholley MozReview-Commit-ID: 1lieHmpuRtH
ba6cef216a17: Bug 1443652 part 1. Fix the buggy existing load-event test for stylesheets. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 07 Mar 2018 16:06:48 -0500 - rev 459617
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1443652 part 1. Fix the buggy existing load-event test for stylesheets. r=bholley The test was adding the load listener to the <link> _after_ the load event on the <link> had already fired. MozReview-Commit-ID: JAS94H9SNOo
3954a5975f11: Bug 1375913 - Do not disable thread pool in the parent process. r=bholley
Xidorn Quan <me@upsuper.org> - Wed, 07 Mar 2018 14:30:11 +1100 - rev 459380
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
Bug 1375913 - Do not disable thread pool in the parent process. r=bholley MozReview-Commit-ID: 2EMq1IdlEof
a50ae6e8b614: servo: Merge #20222 - Do not disable thread pool in the parent process (from upsuper:chrome-thread-pool); r=bholley
Xidorn Quan <me@upsuper.org> - Tue, 06 Mar 2018 17:54:34 -0500 - rev 459377
Push 8822 by archaeopteryx@coole-files.de at 2018-03-08 23:51 +0000
servo: Merge #20222 - Do not disable thread pool in the parent process (from upsuper:chrome-thread-pool); r=bholley This is the Servo side change of [bug 1375913](https://bugzilla.mozilla.org/show_bug.cgi?id=1375913). Source-Repo: https://github.com/servo/servo Source-Revision: 3b96fb2cbe8754b30646e8bd914806048c0b6db2
c64f3b38bf58: Bug 1443344. Flag a parent sheet load as failed if an import is blocked by content policy. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 06 Mar 2018 14:45:27 -0500 - rev 459346
Push 8820 by archaeopteryx@coole-files.de at 2018-03-07 14:27 +0000
Bug 1443344. Flag a parent sheet load as failed if an import is blocked by content policy. r=bholley MozReview-Commit-ID: AArgnuHbCYL
6d99da728f77: Bug 1442126. Make sure to consistently fail a sheet load if any of its imports fail. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 06 Mar 2018 14:45:27 -0500 - rev 459345
Push 8820 by archaeopteryx@coole-files.de at 2018-03-07 14:27 +0000
Bug 1442126. Make sure to consistently fail a sheet load if any of its imports fail. r=bholley This fixes a race where we would fail if and only if our last-to-complete import failed. MozReview-Commit-ID: L33bIxlkj08
cb363ac1897a: Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Mar 2018 14:24:17 -0500 - rev 458766
Push 8808 by archaeopteryx@coole-files.de at 2018-03-02 22:13 +0000
Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley MozReview-Commit-ID: HTs3RwEOmZ4
8fc2c103027b: Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 01 Mar 2018 14:24:17 -0500 - rev 458614
Push 8808 by archaeopteryx@coole-files.de at 2018-03-02 22:13 +0000
Bug 1442313 part 1. Make xpc::IsInAutomation a bit faster. r=bholley MozReview-Commit-ID: HTs3RwEOmZ4
65c9ae7b75e3: servo: Merge #20146 - Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads (from bholley:explicit_load_data); r=bholley
Bobby Holley <bobbyholley@gmail.com> - Wed, 28 Feb 2018 11:32:00 -0500 - rev 458187
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20146 - Stylo: Pass an explicit parent SheetLoadData for child stylesheet loads (from bholley:explicit_load_data); r=bholley https://bugzilla.mozilla.org/show_bug.cgi?id=1441896 Source-Repo: https://github.com/servo/servo Source-Revision: e8f77861a9af8d88ba62625838a10d63c74d22ed
d24a4454d076: Bug 1425759: Simplify the style backend type setup. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 25 Feb 2018 17:28:14 +0100 - rev 457997
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1425759: Simplify the style backend type setup. r=bholley Now that what we use to decide whether a document is styled by Servo are only prefs and the doc principal, we don't need to inherit the style backend type, since unless the pref has changed, the result will be the same. MozReview-Commit-ID: KBmeBn1cRne
b45ca837446a: Bug 1439395: Avoid leaving an stale restyle root if there's no servo data on it. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Feb 2018 18:50:19 +0100 - rev 457988
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Avoid leaving an stale restyle root if there's no servo data on it. r=bholley If a single element is inserted in the document, from the lazy frame construction path we mark it as the restyle root. It has no restyle data, and we weren't calling ClearServoData when its parent was being removed from ClearServoDataFromSubtree, thus leaving the stale restyle root. MozReview-Commit-ID: GY812b8tDk0
15ba5a05f9ab: Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 14:46:38 +0100 - rev 457987
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley We used to do it this way effectively until I fixed it in bug 1400936. Per the list of fuzz bugs that bug has in the "Depends on" field, some of those without a super-clear fix, and others that aren't listed in there, and all the complexity we had to deal with while receiving restyle requests mid-unbind, etc, I think this is the right call. This clears data on RestyleManager::ContentRemoved for non-anonymous nodes, and on UnbindFromTree for subtrees rooted at anonymous nodes. This will hopefully yield enforceable invariants. MozReview-Commit-ID: IMwX5Uh1apv
ca30d7a852e7: Bug 1440258: Flag doc level anonymous content instead of guessing. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Feb 2018 02:30:00 +0100 - rev 457517
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1440258: Flag doc level anonymous content instead of guessing. r=bholley Poking at the frame tree has problems: If we poke in negative (using eSkipNativeAnonymousContent), as we were doing, we mess up the case where we're actually _not_ doc-level, and _not_ ::before or ::after. This can't happen for content documents, but can happen for chrome (since nsDocElementBoxFrame implements nsIAnonymousContentCreator). If we poke in positive, as we used to, you get that right, but mess up the root scrollbar case. Instead, use a node property to mark doc level anon content. This is a case rare enough that it seems worth to not steal a node bit. To recap the failure: * The initial value of -moz-control-character-visiblity is different on beta and nightly. * XUL has a global rule setting -moz-control-character-visibility on the root, to a value so that it's the initial one on nightly, but the non-initial one on beta. * Changes to this property cause a reframe. * Reframes of a nsIAnonymousContentCreator anon content reframe the container. * We were failing to inherit correctly for the nsIAnonymousContentCreator content for the root XUL element on the initial styling, inheriting from the default computed values instead, since we failed to reach the root element's primary frame from GetFlattenedTreeParentForDocumentElementNAC -> AppendDocumentLevelNativeAnonymousContentTo, since the primary frame is set _after_ processing children. This seems somewhat risky to change, and inconsistent with any other stuff the frame constructor does, see bug 973390. * Given that, the next restyle of the root element, in this case caused due to the customizable UI, we _found_ the actual correct parent, recomputed the style, saw that -moz-control-character-visiblity had changed, and reframed. But we were reframing the whole window, not just the NAC, because of the fourth bullet point. Reframing the whole window caused us to lose the popup state (that's bug 1440506). Worse than that is the fact that given we reframe and reconstruct the anonymous countent again, we go back to the initial bogus state, just awaiting for the next restyle to reframe the whole window. I wish there was a bullet-proof way to test it that isn't just counting reframes and relying on which properties reframe or not, but due to the nature of nsIAnonymousContentCreator's NAC, it's not possible in any easy way I can think of. MozReview-Commit-ID: IPYB5trsN8R
1218f0cd72df: Bug 1439285: Hack around bug 1406134. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 20:03:43 +0100 - rev 457384
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439285: Hack around bug 1406134. r=bholley MozReview-Commit-ID: Cg2HxB99cGD
90dde2f81fa0: Bug 1439285: Make the old image request arrive to FinishStyle if we come from ResolveSameStructsAs. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 19:44:44 +0100 - rev 457383
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439285: Make the old image request arrive to FinishStyle if we come from ResolveSameStructsAs. r=bholley MozReview-Commit-ID: H1N9jNql9tl
ba27cf3b8520: servo: Merge #20082 - style: Cleanup always-false argument to Servo_ResolveStyleLazily (from emilio:ignore-existing-styles); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Feb 2018 06:09:15 -0500 - rev 457103
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
servo: Merge #20082 - style: Cleanup always-false argument to Servo_ResolveStyleLazily (from emilio:ignore-existing-styles); r=bholley I changed this setup in https://bugzilla.mozilla.org/show_bug.cgi?id=1414999, because it was totally unsound. Source-Repo: https://github.com/servo/servo Source-Revision: 691f3be24a6fcc90ae7d0b9b0783abf8674e1b0f
3ab4e934cd7f: Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 14:46:38 +0100 - rev 456951
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439395: Clear Servo data only when the DOM is in a consistent state. r=bholley We used to do it this way effectively until I fixed it in bug 1400936. Per the list of fuzz bugs that bug has in the "Depends on" field, some of those without a super-clear fix, and others that aren't listed in there, and all the complexity we had to deal with while receiving restyle requests mid-unbind, etc, I think this is the right call. This clears data on RestyleManager::ContentRemoved for non-anonymous nodes, and on UnbindFromTree for subtrees rooted at anonymous nodes. This will hopefully yield enforceable invariants. MozReview-Commit-ID: IMwX5Uh1apv
84dbe2d215f7: Bug 1439016: Remove dead code from Shadow DOM v0. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 18:15:38 +0100 - rev 456928
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Remove dead code from Shadow DOM v0. r=bholley Could do that on a different bug but... MozReview-Commit-ID: L1ri2s8z75f
b8cd6601b753: Bug 1439016: Crashtest. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 18:08:06 +0100 - rev 456927
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Crashtest. r=bholley The crashtest will crash whenever the shell is destroyed, which is annoying, but... MozReview-Commit-ID: 1JkLy5K98bS
6ec2d0d818ce: Bug 1439016: Assert that there's no stale servo data in shadow roots either. r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 15:00:37 +0100 - rev 456926
Push 8799 by mtabara@mozilla.com at 2018-03-01 16:46 +0000
Bug 1439016: Assert that there's no stale servo data in shadow roots either. r=bholley Just expanding the assertion to cover shadow trees. MozReview-Commit-ID: FLE0noGzaIF