searching for reviewer(bgrins)
2ed2eb2fcea8: Bug 1486870 - Fix copy/pasting stacktraces in console; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 25 Jan 2019 17:16:10 +0000 - rev 512599
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1486870 - Fix copy/pasting stacktraces in console; r=bgrins. The changes were made in Github to have proper markup for the SmartTrace component. In the console, we change how the "Copy Message" and "Export visible messages" context menu actions work so they use the Selection API instead of `element.textContent`. The Selection API reflects what would happen if a user do a text selection, so having our actions to do the same ensure that we keep our markup suitable for the clipboard. Differential Revision: https://phabricator.services.mozilla.com/D17378
2fbbe85bb992: Bug 1486870 - Adapt SmartTrace component to the modified Frames component; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 25 Jan 2019 17:13:38 +0000 - rev 512597
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1486870 - Adapt SmartTrace component to the modified Frames component; r=bgrins. The Frames component changed significantly on Github, which means we need to do some adjustments in the SmartTrace component (pass the `selectable` prop, change CSS rules, …). For now, we also hide the Framework icons as we need to find a way to properly share the underlying CSS from the debugger (See https://github.com/devtools-html/debugger.html/issues/7782). Differential Revision: https://phabricator.services.mozilla.com/D17376
c20e24b35432: Bug 1522115 - Prevent the new "about:config" search field from moving slightly when the page is scrolled. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 24 Jan 2019 18:58:26 +0000 - rev 512485
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1522115 - Prevent the new "about:config" search field from moving slightly when the page is scrolled. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D17392
cbc275919e80: Bug 1521797 - Don't run the new "about:config" tests on debug builds for bug 1507747. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 23 Jan 2019 22:53:21 +0000 - rev 512466
Push 10566 by archaeopteryx@coole-files.de at Mon, 28 Jan 2019 12:41:12 +0000
Bug 1521797 - Don't run the new "about:config" tests on debug builds for bug 1507747. r=bgrins The search field is now focused by the test code as part of intialization, which may cause the intermittent leak in bug 1507747 to surface. Differential Revision: https://phabricator.services.mozilla.com/D17506
364d6aef9d05: Bug 1516258 - Part 1 - Stop using XULScrollElement::EnsureElementIsVisible. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 17 Jan 2019 14:25:38 +0000 - rev 511649
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516258 - Part 1 - Stop using XULScrollElement::EnsureElementIsVisible. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D16840
47e7e2dac7c9: Bug 1503826 - Remove the treerows binding, r=bgrins
Victor Porof <vporof@mozilla.com> - Thu, 17 Jan 2019 10:53:53 +0100 - rev 511640
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1503826 - Remove the treerows binding, r=bgrins
529a10531043: Bug 1489491 - Populate reverse search with input text selection; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 18 Jan 2019 13:20:44 +0000 - rev 511542
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1489491 - Populate reverse search with input text selection; r=bgrins. If the user selected some text in the console input and opens the reverse search UI, we populate the reverse search input with the selected text and do a reverse search with this text. A test is added to ensure this works as expected. Differential Revision: https://phabricator.services.mozilla.com/D16843
dae7a246b32d: Bug 1507704 - Migrate the columnpicker binding into a custom element, r=bgrins
Victor Porof <vporof@mozilla.com> - Mon, 14 Jan 2019 09:38:24 +0100 - rev 511422
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1507704 - Migrate the columnpicker binding into a custom element, r=bgrins
ecd71a7f46f8: Bug 1501417 - Part 2 - Don't wait for the Enter key in the new "about:config" search field. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 15 Jan 2019 14:37:30 +0000 - rev 511140
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501417 - Part 2 - Don't wait for the Enter key in the new "about:config" search field. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D16310
963484091d53: Bug 1501417 - Part 1 - Use the search string set in previous sessions. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 15 Jan 2019 14:22:16 +0000 - rev 511139
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501417 - Part 1 - Use the search string set in previous sessions. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D16309
062ab37367fb: Bug 1501411 - Make sure that copying preference values from the new "about:config" page preserves whitespace. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 15 Jan 2019 14:21:07 +0000 - rev 511138
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501411 - Make sure that copying preference values from the new "about:config" page preserves whitespace. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D16056
cd0401ea98ff: Bug 1501410 - Part 4 - Make the filter case insensitive. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 15:08:04 +0000 - rev 511137
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501410 - Part 4 - Make the filter case insensitive. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15947
2039967a0b3b: Bug 1501410 - Part 3 - Detect changes in preferences. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 15:26:11 +0000 - rev 511136
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501410 - Part 3 - Detect changes in preferences. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15946
5b558b35ac4f: Bug 1501410 - Part 2 - Add support for recovering deleted preferences. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 15 Jan 2019 23:48:11 +0000 - rev 511135
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501410 - Part 2 - Add support for recovering deleted preferences. r=bgrins This updates the user interface for adding new preferences to be closer to the mockup, and makes deleted preferences more similar to rows that are not added yet. This will later make it simpler to react to external changes in the underlying data. Differential Revision: https://phabricator.services.mozilla.com/D15945
20f2bbf59893: Bug 1501410 - Part 1 - Optimize the variables containing the global state. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 15:25:49 +0000 - rev 511134
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1501410 - Part 1 - Optimize the variables containing the global state. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15944
346851347c90: Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo
James Teh <jteh@mozilla.com> - Fri, 11 Jan 2019 04:52:50 +0000 - rev 510784
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514687 - Allow accessibility code to focus XUL radio buttons without selecting them. r=bgrins,smaug,MarcoZ,paolo 1. This requires exposing radiogroup's focusedItem property to C++. Unfortunately, there's no existing equivalent in nsIDOMXULSelectControlItemElement. radiogroup is the only element that needs this, so a new interface has been created for it. 2. Accessibility uses focusedItem instead of selectedItem when setting focus. 3. When an item is focused, accessibility needs to be notified. This is done using a DOMMenuItemActive event. Differential Revision: https://phabricator.services.mozilla.com/D15295
0fe293d9f494: Bug 1454363 - Unify the "popup" and "popup-scrollbars" bindings. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Sat, 29 Dec 2018 15:37:05 +0000 - rev 510195
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1454363 - Unify the "popup" and "popup-scrollbars" bindings. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15277
00d33e7058c1: Bug 1437641 - Remove numberbox binding and convert usages to input[type=number]. r=bgrins,dao
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 09 Jan 2019 08:51:32 +0000 - rev 510124
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1437641 - Remove numberbox binding and convert usages to input[type=number]. r=bgrins,dao Differential Revision: https://phabricator.services.mozilla.com/D15882
14e4487e1c6b: Bug 1517507 - Part 4 - Move the editing code to the PrefRow class. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 11:48:41 +0000 - rev 510010
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517507 - Part 4 - Move the editing code to the PrefRow class. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15665
13e4170bccb1: Bug 1517507 - Part 3 - Share the table row creation and update code. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 11:48:29 +0000 - rev 510009
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517507 - Part 3 - Share the table row creation and update code. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15664
be8b406d7fe4: Bug 1517507 - Part 2 - Improve validation of numeric input. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 11:48:18 +0000 - rev 510008
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517507 - Part 2 - Improve validation of numeric input. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15663
f24ea722320a: Bug 1517507 - Part 1 - Add in-content styling for input[type="number"]. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 08 Jan 2019 11:48:08 +0000 - rev 510007
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517507 - Part 1 - Add in-content styling for input[type="number"]. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15662
bc5767b55411: Bug 1499289 - Allow to invoke getters from webconsole autocomplete function; r=bgrins,flod.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 07 Jan 2019 17:53:55 +0000 - rev 509974
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1499289 - Allow to invoke getters from webconsole autocomplete function; r=bgrins,flod. This patch introduces a new component, ConfirmDialog, that will be rendered on screen when the autocomplete service indicates that there's an unsafe getter in the completion path. The component is rendered in the toolbox document, like the autocomplete popup. In order to still write it in React, it uses a React portal, which allow to render an element outside of the React component tree. Tests are added to make sure the dialog works as expected. Differential Revision: https://phabricator.services.mozilla.com/D12943
9b92ad8d977d: Bug 1499289 - Change how we deal with getter evaluation in JsPropertyProvider; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 07 Jan 2019 09:49:10 +0000 - rev 509973
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1499289 - Change how we deal with getter evaluation in JsPropertyProvider; r=bgrins. While trying to implement the invoke getter from autocomplete popup, it became clear to me that the initial implementation in js-property-provider wasn't good enough, as we need to keep track of all the authorizations the user gave when working on a given expression. In order to handle this, JsPropertyProvider now returns an array of strings representing the path to the unsafe getter when no matching authorizations are provided. If authorizations are provided, we can check for each properties that the user authorized the execution. This way, we can handle deep object access after a getter (e.g. `x.myGetter.foo.bar.baz.entries`) without asking the user if they want to invoke `myGetter` on each step of the completion. This makes handling intermediary getters (e.g. `x.myGetter.foo.myOtherGetter.bar`) way easier as well. In the UI, the user will be prompted to invoke the getter one after the other (if for example they try to complete a pasted expression which contains multiple getters, they will have prompts for `myGetter`, and then for `myOtherGetter`). We wire-up the webconsole client and the webconsole actor for the autocomplete function, to make them ready for frontend use. The existing JsPropertyProvider getters test are updated to match the change of parameter (invokeGetter -> authorizedEvaluations), and some tests are added to make sure everything work as intended. Differential Revision: https://phabricator.services.mozilla.com/D12940
c65391dd1e7d: Bug 1231489 - Use content prototype for autocompletion of String, Number and Array literals; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 08 Jan 2019 07:59:24 +0000 - rev 509968
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1231489 - Use content prototype for autocompletion of String, Number and Array literals; r=bgrins. When provided a string, number or array literals, we use to simply return the properties from String.prototype, Number.prototype and Array.prototype. This is working fine unless the content prototypes are modified. In order to make it work properly, we retrieve the actual content prototype. The js-property-provider unit test is modified to ensure this is working as expected. Differential Revision: https://phabricator.services.mozilla.com/D15843
ff84fa856102: Bug 1472558 - Convert "richlistbox" to Custom Element. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 31 Dec 2018 07:54:10 +0000 - rev 509592
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1472558 - Convert "richlistbox" to Custom Element. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15502
a1f41c6cfda4: Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 02 Jan 2019 11:54:17 +0000 - rev 509545
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15567
64f0c0341dc8: Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 03 Jan 2019 13:27:22 +0000 - rev 509544
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15570
30a9b6900d37: Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 02 Jan 2019 09:57:59 +0000 - rev 509543
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15569
798c09311606: Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 02 Jan 2019 11:54:17 +0000 - rev 509538
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 3 - Display the correct value when resetting a localized preference. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15567
8dcd5d5e815d: Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 02 Jan 2019 11:53:39 +0000 - rev 509537
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 2 - Unify which preferences are used for tests. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15570
f0489fc1ef50: Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 02 Jan 2019 09:57:59 +0000 - rev 509536
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1517213 - Part 1 - Share more selectors in tests. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15569
3ab044c93118: Bug 1516876 - Remove the "autocomplete-richlistbox" binding. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Sun, 30 Dec 2018 15:59:57 +0000 - rev 509344
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516876 - Remove the "autocomplete-richlistbox" binding. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15501
9781b1970089: Bug 1516448 - Remove the "categories-list" binding. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Sun, 30 Dec 2018 11:51:03 +0000 - rev 509343
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516448 - Remove the "categories-list" binding. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15499
c1a87fe81d16: Bug 1516957 - Part 4 - Share the search function. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 31 Dec 2018 12:15:50 +0000 - rev 509342
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516957 - Part 4 - Share the search function. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15516
dda920bc62dd: Bug 1516957 - Part 3 - Share more test functions. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 31 Dec 2018 12:15:38 +0000 - rev 509341
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516957 - Part 3 - Share more test functions. r=bgrins This results in querying the document more often, but makes the test code more concise. Differential Revision: https://phabricator.services.mozilla.com/D15515
214d0e9f7825: Bug 1516957 - Part 2 - Create a base test class and unify tab creation functions. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 31 Dec 2018 11:42:00 +0000 - rev 509340
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516957 - Part 2 - Create a base test class and unify tab creation functions. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15514
c762e770dec4: Bug 1516957 - Part 1 - Remove uses of ContentTask from the new "about:config" tests. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 31 Dec 2018 11:41:48 +0000 - rev 509339
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516957 - Part 1 - Remove uses of ContentTask from the new "about:config" tests. r=bgrins Uses of ContentTask can be removed because the page will continue to be loaded in the parent process for the time being. We don't want to give generic write access to preferences to the content processes until there is a way to separate privileged browser pages from regular web content using different process types. Differential Revision: https://phabricator.services.mozilla.com/D15513
8b2453d488ae: Bug 1472557 - Remove the "scrollbox" anonymous element from "richlistbox". r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Sun, 30 Dec 2018 13:48:45 +0000 - rev 509269
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1472557 - Remove the "scrollbox" anonymous element from "richlistbox". r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15388
7e0448a4aa48: Bug 1516442 - Move "listheader" outside of "richlistbox". r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 26 Dec 2018 17:00:31 +0000 - rev 509099
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516442 - Move "listheader" outside of "richlistbox". r=bgrins The only uses of "listheader" are part of in-content preferences, and they are updated to use adjacent elements. This is in preparation for the removal of the inner scrollbox in the "richlistbox" binding. Differential Revision: https://phabricator.services.mozilla.com/D15387
82be4a42a1d3: Bug 1516266 - Part 2 - Unify the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 26 Dec 2018 14:49:14 +0000 - rev 509040
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516266 - Part 2 - Unify the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15302
7241050ae933: Bug 1516266 - Part 1 - Unify the content of the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 24 Dec 2018 15:34:24 +0000 - rev 509039
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1516266 - Part 1 - Unify the content of the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D15301
ddcc1ef99354: Bug 1515759 - Revert in tree.xml the changes from bug 1508141. r=bgrins
Richard Marti <richard.marti@gmail.com> - Fri, 21 Dec 2018 19:39:22 +0100 - rev 508838
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1515759 - Revert in tree.xml the changes from bug 1508141. r=bgrins
0381e284d33b: Bug 1514815 - Keep console scrolled to bottom when rendering SmartTrace; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 20 Dec 2018 14:37:41 +0000 - rev 508652
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514815 - Keep console scrolled to bottom when rendering SmartTrace; r=bgrins. Differential Revision: https://phabricator.services.mozilla.com/D15010
851d0b820ac2: Bug 1514815 - Add an `onReady` prop to the SmartTrace component; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 20 Dec 2018 14:37:41 +0000 - rev 508651
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514815 - Add an `onReady` prop to the SmartTrace component; r=bgrins. Since the component renders asynchronously, consumers might want to hook up to the actual first rendering. We provide an `onRender` prop that will be called once, when the component is ready. Differential Revision: https://phabricator.services.mozilla.com/D14999
d822219ea9bc: Bug 1514815 - Keep console scrolled to bottom when rendering SmartTrace; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 19 Dec 2018 21:06:40 +0000 - rev 508618
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514815 - Keep console scrolled to bottom when rendering SmartTrace; r=bgrins. Depends on D14999 Differential Revision: https://phabricator.services.mozilla.com/D15010
209bdfcecdc9: Bug 1514815 - Add an `onReady` prop to the SmartTrace component; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 19 Dec 2018 21:01:25 +0000 - rev 508617
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1514815 - Add an `onReady` prop to the SmartTrace component; r=bgrins. Since the component renders asynchronously, consumers might want to hook up to the actual first rendering. We provide an `onRender` prop that will be called once, when the component is ready. Differential Revision: https://phabricator.services.mozilla.com/D14999
cc75d9afa3bb: Bug 1511130 - Part II, Allow UAWidgetsChild to destruct widgets even if it throws during construction r=bgrins
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Dec 2018 20:59:00 +0000 - rev 507587
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1511130 - Part II, Allow UAWidgetsChild to destruct widgets even if it throws during construction r=bgrins This patch move the actual widget construction to a onsetup method, allow UAWidgetsChild to hold the reference of the widget instance even if the actual setup (happens in the onsetup call) throws. With the reference of the widget kept, UAWidgetsChild will finally able to call its destructor later on. Depends on D13607 Differential Revision: https://phabricator.services.mozilla.com/D13608
bb27071244f9: Bug 1511130 - Part I, Backed out changeset faacbb32e16a (Bug 1511130) r=bgrins
Timothy Guan-tin Chien <timdream@gmail.com> - Sat, 01 Dec 2018 22:28:46 +0000 - rev 507586
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1511130 - Part I, Backed out changeset faacbb32e16a (Bug 1511130) r=bgrins My approach in bug 1505957 turned out to be flawed. Differential Revision: https://phabricator.services.mozilla.com/D13607
7ea008f8701b: Bug 1512289 - Remove webconsole reverse search pref; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Dec 2018 13:01:30 +0000 - rev 506882
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512289 - Remove webconsole reverse search pref; r=bgrins. Differential Revision: https://phabricator.services.mozilla.com/D13913