searching for reviewer(bgrins)
4c11d8d96c24: Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 12 Oct 2018 15:07:17 +0100 - rev 496817
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure. Differential Revision: https://phabricator.services.mozilla.com/D8421
0bfaf2361851: Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=paolo,bgrins
Vincent Cote <vincent.cote@uleth.ca> - Tue, 09 Oct 2018 15:45:39 +0100 - rev 496040
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=paolo,bgrins Differential Revision: https://phabricator.services.mozilla.com/D6573
2614ca0a8884: Bug 1452626 - Remove the "download" binding. r=mak,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 04 Oct 2018 11:12:03 +0100 - rev 495564
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1452626 - Remove the "download" binding. r=mak,bgrins Differential Revision: https://phabricator.services.mozilla.com/D7176
933956374571: Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 04 Oct 2018 01:03:19 +0000 - rev 495547
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov Depends on D7575 Differential Revision: https://phabricator.services.mozilla.com/D7576
e994da668be6: Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=bgrins,paolo
Vincent Cote <vincent.cote@uleth.ca> - Fri, 05 Oct 2018 10:41:49 +0000 - rev 495529
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1493446 - Create a skeleton of the new internal settings HTML page. r=bgrins,paolo Differential Revision: https://phabricator.services.mozilla.com/D6573
3036b43dd00b: Bug 1493819 - Provide in-tree document on UA Widgets r=bgrins,bholley
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 05 Oct 2018 03:52:19 +0000 - rev 495489
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1493819 - Provide in-tree document on UA Widgets r=bgrins,bholley Differential Revision: https://phabricator.services.mozilla.com/D7545
a74eb57d75ff: Bug 1493819 - Provide in-tree document on UA Widgets r=bgrins,bholley
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 05 Oct 2018 03:34:18 +0000 - rev 495483
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1493819 - Provide in-tree document on UA Widgets r=bgrins,bholley Differential Revision: https://phabricator.services.mozilla.com/D7545
95ae87f52148: Bug 1410820 - Extensively test top-level await evaluation; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:01:16 +0000 - rev 494296
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1410820 - Extensively test top-level await evaluation; r=bgrins. We add several tests and modify the existing one to make sure we handle top level await correctly in different situation (resolving, rejecting, when paused in the debugger, when using $_, …). Depends on D6925 Differential Revision: https://phabricator.services.mozilla.com/D6926
a7edd08b7f6d: Bug 1410820 - Enhance webconsole test helpers; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:00:32 +0000 - rev 494295
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1410820 - Enhance webconsole test helpers; r=bgrins. 1. Allow passing a selector to waitForMessage helper function: This will allow to wait for specific message (warning, error, result, …). This patch also fixes 2 tests that were already passing an erroneous selector to waitForMessage. 2. Add an executeAndWaitForMessage function: This will make a lot of our tests much easier to read. The function takes an input, an expected output and an optional selector, execute the input and resolves when a message matching the provided text (and selector if passed) is displayed in the output. Depends on D6903 Differential Revision: https://phabricator.services.mozilla.com/D6925
6fabe4062700: Bug 1410820 - top-level await evaluation should be handled as regular evaluation; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 15:59:47 +0000 - rev 494294
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1410820 - top-level await evaluation should be handled as regular evaluation; r=bgrins. This patch turns the current top-level handling, which relies on the console API to print the result of the await expression, into something natively handled by the server. First, we don't add a .then handler to the generated async iife by the mapper. We also removes the case we added in the JsTerm to *not* print the result for top-level await expression. In order to make the server capable of handling generated async iife caused by the mapper, we send to evaluateJsAsync the `mapped` object that `mapExpression` returns. This way, the server can check if an expression was originally a top-level await. If it is the case, we get the promise from the async iife and wait for it to settle. If it resolves, we simply return the result, as a grip, to the client. If it rejects, we return a special packet indicating to not print anything to the client. The error will be reported by the engine as `uncaught exception: …`. We add several tests and modify the existing one to make sure we handle top level await correctly in different situation (resolving, rejecting, when paused in the debugger, when using $_, …). Differential Revision: https://phabricator.services.mozilla.com/D6903
dfc7e23a0dfa: Bug 1172314 - Print arguments passed into console.trace. r=bgrins.
StefanYohansson <snotr@sadfeelings.me> - Thu, 27 Sep 2018 13:27:57 +0000 - rev 494272
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1172314 - Print arguments passed into console.trace. r=bgrins. Added trace extra parameters to be printed alongside console.trace() output. Differential Revision: https://phabricator.services.mozilla.com/D7051
3eff766fa7c2: Bug 1491354 - Extends top-level await mapping from debugger to toolbox; r=bgrins,jlast.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 24 Sep 2018 08:17:30 +0000 - rev 493595
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491354 - Extends top-level await mapping from debugger to toolbox; r=bgrins,jlast. This patch makes the parser-worker available at the toolbox level. This way, the console does not have to rely on the debugger being open to map top-level await expression. In order to make the worker works in the toolbox, some changes are required (passing a window object, checking inToolbox differently). We take this as an opportunity to *not* display the async iife result, a promise, in the console. This is made by checking if the input was mapped, and if so, ignoring the result we get from the server. A couple tests are added to ensure the basic usage works as expected. This patch should be considered as a v0 for top-level await evaluation as there are things that are not perfect here. Since we rely on console.log the result are treated differently from other evaluation results: - the style is different - the result gets added to the log cache (when restarting the console, the results will still be displayed, but not the commands). - the results can be filtered, although evaluation results should not - `$_` after a top-level await evaluation returns the Promise created by the async iife, not the result that was displayed in the console. All those should be addressed in Bug 1410820. Differential Revision: https://phabricator.services.mozilla.com/D6038
5111ca226d2b: Bug 1492619 - Use children instead of childNodes in customizable ui tests. r=bgrins
Brendan Dahl <bdahl@mozilla.com> - Wed, 19 Sep 2018 22:43:04 +0000 - rev 493095
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1492619 - Use children instead of childNodes in customizable ui tests. r=bgrins Fixes browser_customization_context_menus.js MozReview-Commit-ID: KtRIFGu5ILA Differential Revision: https://phabricator.services.mozilla.com/D6335
b32d9892402b: Bug 1491914 - Include a binding for `ChromeUtils` in the browser content toolbox. r=bgrins
Jim Blandy <jimb@mozilla.com> - Mon, 17 Sep 2018 11:06:58 -0700 - rev 493059
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491914 - Include a binding for `ChromeUtils` in the browser content toolbox. r=bgrins
55115a3dfb82: Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:43 +0100 - rev 493048
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4556
e1bac78c8df5: Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:12 +0100 - rev 493047
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4555
acce14683c13: Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:43 +0100 - rev 493027
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4556
323773a395cc: Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:12 +0100 - rev 493026
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4555
f29ac1523010: Bug 1478372, remove unneeded QueryInterface implementation for custom XUL elements as this is now done by nsXULElement::QueryInterface, r=bgrins
Neil Deakin <neil@mozilla.com> - Wed, 19 Sep 2018 06:46:55 -0400 - rev 492968
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1478372, remove unneeded QueryInterface implementation for custom XUL elements as this is now done by nsXULElement::QueryInterface, r=bgrins
7e69cb7b9206: Bug 1478372, allow QueryInterface to be used for custom element implemented interfaces, r=bz,bgrins
Neil Deakin <neil@mozilla.com> - Wed, 19 Sep 2018 06:46:41 -0400 - rev 492967
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1478372, allow QueryInterface to be used for custom element implemented interfaces, r=bz,bgrins
c61662006c89: Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins,flod
Jan Odvarko <odvarko@gmail.com> - Wed, 19 Sep 2018 09:58:08 +0000 - rev 492943
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins,flod Differential Revision: https://phabricator.services.mozilla.com/D6015
83af3bf2f967: Bug 1491776 - Do not use markText to show the completion text; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 18 Sep 2018 19:22:01 +0000 - rev 492913
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491776 - Do not use markText to show the completion text; r=bgrins. Differential Revision: https://phabricator.services.mozilla.com/D6020
3aaccb374a59: Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:43 +0100 - rev 492856
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4556
3a111e9e5c9c: Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:12 +0100 - rev 492855
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4555
35bd32f99f60: Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:43 +0100 - rev 492766
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - docshell/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4556
f40900bf8621: Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:46:12 +0100 - rev 492765
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1485305 - devtools/ Ensure loadURI always passes a triggeringPrincipal() r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4555
057a798ae661: Bug 1491296 - Remove isThemeSelected -> selectedThemeID migration code. r=bgrins
Dão Gottwald <dao@mozilla.com> - Fri, 14 Sep 2018 15:15:54 +0200 - rev 492551
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1491296 - Remove isThemeSelected -> selectedThemeID migration code. r=bgrins
2aa3365b87b1: Bug 1471245 - Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 17 Sep 2018 15:48:42 +0000 - rev 492501
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1471245 - Replace openNewTabAndToolbox by openNewTabAndConsole in webconsole tests; r=bgrins. This is done in all the tests that don't need an explicit reference to the toolbox. Differential Revision: https://phabricator.services.mozilla.com/D6037
6581e89029aa: Bug 1490279 - Enable reverse search before running reverse search tests; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 11 Sep 2018 16:16:02 +0000 - rev 491511
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1490279 - Enable reverse search before running reverse search tests; r=bgrins. This is needed for beta since, for now, we only enable reverse search on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D5525
50eedf887f96: Bug 1488915 - Migrate toolbox-process-window.xul to HTML; r=bgrins
Jan Odvarko <odvarko@gmail.com> - Mon, 10 Sep 2018 17:14:57 +0000 - rev 491401
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1488915 - Migrate toolbox-process-window.xul to HTML; r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D5255
8e3364f777f0: Bug 1024913 - Add tests for Reverse search; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:24:42 +0000 - rev 491103
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add tests for Reverse search; r=bgrins. Depends on D3114 Differential Revision: https://phabricator.services.mozilla.com/D5153
3025bb790d39: Bug 1024913 - Enable reverse search in jsterm; r=bgrins,flod.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:24:40 +0000 - rev 491101
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Enable reverse search in jsterm; r=bgrins,flod. Differential Revision: https://phabricator.services.mozilla.com/D3114
28becf26d84b: Bug 1024913 - Move jsterm auto-focus handling into App.js; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:22:47 +0000 - rev 491100
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Move jsterm auto-focus handling into App.js; r=bgrins. The App component takes the whole document space, so we can move the code that listen for every click in the console UI to decide if the jsterm should be focused or not. This feels more like the React way, and will also provide us better access to the store and the props when we need them in this focus handling (like this will be the case for hiding the reverse search UI). Depends on D5150 Differential Revision: https://phabricator.services.mozilla.com/D5152
ab579e9e03e7: Bug 1024913 - Add SVG images for the Reverse Search input; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:22:15 +0000 - rev 491099
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add SVG images for the Reverse Search input; r=bgrins. This adds 2 arrowhead images to navigate to the next and previous result in the reverse search UI. The search.svg icon is modified to accept fill through CSS. Depends on D5149 Differential Revision: https://phabricator.services.mozilla.com/D5150
c73046f4daa3: Bug 1024913 - Add a preference to enable the reverse search UI; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:21:46 +0000 - rev 491098
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add a preference to enable the reverse search UI; r=bgrins. Retrieve this preference in the console to pass it as a prop to the root App component. Differential Revision: https://phabricator.services.mozilla.com/D5149
1c18e0422ffa: Bug 1024913 - Add tests for Reverse search; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 05:16:25 +0000 - rev 491082
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add tests for Reverse search; r=bgrins. Depends on D3114 Differential Revision: https://phabricator.services.mozilla.com/D5153
c4e5a7ff8e53: Bug 1024913 - Enable reverse search in jsterm; r=bgrins,flod.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 05:16:00 +0000 - rev 491081
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Enable reverse search in jsterm; r=bgrins,flod. Differential Revision: https://phabricator.services.mozilla.com/D3114
7f269add6e54: Bug 1024913 - Move jsterm auto-focus handling into App.js; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 05:15:58 +0000 - rev 491080
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Move jsterm auto-focus handling into App.js; r=bgrins. The App component takes the whole document space, so we can move the code that listen for every click in the console UI to decide if the jsterm should be focused or not. This feels more like the React way, and will also provide us better access to the store and the props when we need them in this focus handling (like this will be the case for hiding the reverse search UI). Depends on D5150 Differential Revision: https://phabricator.services.mozilla.com/D5152
ccd6afc2a739: Bug 1024913 - Add SVG images for the Reverse Search input; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 05:15:56 +0000 - rev 491079
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add SVG images for the Reverse Search input; r=bgrins. This adds 2 arrowhead images to navigate to the next and previous result in the reverse search UI. The search.svg icon is modified to accept fill through CSS. Depends on D5149 Differential Revision: https://phabricator.services.mozilla.com/D5150
1613377c1b43: Bug 1024913 - Add a preference to enable the reverse search UI; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 05:14:14 +0000 - rev 491078
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1024913 - Add a preference to enable the reverse search UI; r=bgrins. Retrieve this preference in the console to pass it as a prop to the root App component. Differential Revision: https://phabricator.services.mozilla.com/D5149
66bc93855cfa: Bug 1487457 - Make console reflows faster; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 31 Aug 2018 12:51:36 +0000 - rev 490799
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1487457 - Make console reflows faster; r=bgrins. This patch remove some unused dom elements and CSS rules that might negatively influence reflow times. Also, we set an hidden overflow to all the element we know for sure won't ever have a scrollbar, which seems to speed up the reflow significantly. Differential Revision: https://phabricator.services.mozilla.com/D4695
3edd9e52dbfe: Bug 1488336 - Group clear mark and markText for completion text; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 04 Sep 2018 16:19:23 +0000 - rev 490506
Push 9984 by ffxbld-merge at 2018-10-15 21:07 +0000
Bug 1488336 - Group clear mark and markText for completion text; r=bgrins. This way, codeMirror does not trigger so many reflows and makes setAutocompletionText faster. An unwanted side-effect was that it made closing the console a lot slower. Looking at the closing code of the JsTerm, we do call setAutocompletionText("") in the end, which we don't really need since we destroy the editor shortly after. Removing this call keeps closing time the same as before. Differential Revision: https://phabricator.services.mozilla.com/D4905
6b9c111f3da9: Bug 1453723 - actually wait for the homepage to load, r=bgrins
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 30 Aug 2018 16:29:59 +0000 - rev 489228
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1453723 - actually wait for the homepage to load, r=bgrins Explicitly specify which load we're waiting for to avoid intermittent oranges Differential Revision: https://phabricator.services.mozilla.com/D4692
6ce3008e2f46: Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 29 Aug 2018 14:04:25 +0100 - rev 489215
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins Differential Revision: https://phabricator.services.mozilla.com/D4531
e2d52cbf726d: Bug 1457218 - Part 2 - Remove support for menu button types in notification bars. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 29 Aug 2018 10:56:09 +0100 - rev 489214
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1457218 - Part 2 - Remove support for menu button types in notification bars. r=bgrins The "menu-button" notification button type is unused, and the "menu" type is implemented using a normal button that opens a popup. Differential Revision: https://phabricator.services.mozilla.com/D4530
ce10788000f5: Bug 1457218 - Part 1 - Don't inherit from "menu-button-base" in the "download-subview-toolbarbutton" binding. r=bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Thu, 30 Aug 2018 10:28:01 +0100 - rev 489213
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1457218 - Part 1 - Don't inherit from "menu-button-base" in the "download-subview-toolbarbutton" binding. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D4529
a35cbdf27bd1: Bug 1487452 - Set devtools.debugger.features.map-await-expression to true only on Nightly; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 30 Aug 2018 16:24:27 +0000 - rev 489194
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1487452 - Set devtools.debugger.features.map-await-expression to true only on Nightly; r=bgrins. Differential Revision: https://phabricator.services.mozilla.com/D4691
14677ccf804e: Bug 1487177 - Fix rule view overridden item alignment. r=bgrins
Gabriel Luong <gabriel.luong@gmail.com> - Wed, 29 Aug 2018 15:14:09 -0400 - rev 489124
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1487177 - Fix rule view overridden item alignment. r=bgrins
609e1efc1f9f: Bug 1484979 - Fix old-jsterm UI glitches; r=bgrins.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 29 Aug 2018 05:41:52 +0000 - rev 488900
Push 9738 by aciure@mozilla.com at 2018-09-03 16:13 +0000
Bug 1484979 - Fix old-jsterm UI glitches; r=bgrins. The completion node was wrongly positioned as soon as the input overflowed. We fix this by setting the completionNode height in resizeInput, like we do for the inputNode. The inputNode takes the whole remaining vertical space when starting the console. But when typing, the height is computed and set according to what's in the input. Which means the input wasn't taking the remaining space anymore, which could be weird (e.g. if the user wants to select some text by starting dragging below the actual input, although the UI would indicate it is possible). The autocompletionPopup was a bit off due to 2 things: - in the function that was returning the chevronWidth, we were subtracting the autocomplete popup padding. But the autocomplete popup already handles that itself. - in the function that was computing the character width, we were using offsetWidth which returned a rounded value. This means that the further the autocompletion was displayed at, the more the popup would be off. We use getBoundingClientRect().width instead which gives us a decimal value. And we also make sure to not alter the scrolling position in the inputNode when accepting an autocompletion result (a test is added). Differential Revision: https://phabricator.services.mozilla.com/D4207
20db845c4c87: Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 24 Aug 2018 15:44:38 +0100 - rev 488869
Push 9734 by shindli@mozilla.com at 2018-08-30 12:18 +0000
Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins Differential Revision: https://phabricator.services.mozilla.com/D4306