searching for reviewer(andi)
030c742c25d5e3aab01c2e020345a7cd5506b207: Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 14 May 2019 07:12:37 +0000 - rev 532563
Push 11270 by rgurzau@mozilla.com at Wed, 15 May 2019 15:07:19 +0000
Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi Differential Revision: https://phabricator.services.mozilla.com/D30816
ebcc8dd9c2bc63bc4e82ce15a87aa66c0f73e932: Bug 1544797 - clang-format: Use the topsrcdir to generate the paths instead of the pwd r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 16 Apr 2019 17:38:24 +0000 - rev 528595
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1544797 - clang-format: Use the topsrcdir to generate the paths instead of the pwd r=andi If the user runs mach clang-format from the builddir, it was finding and using unified files. Differential Revision: https://phabricator.services.mozilla.com/D27750
323eef8fd5ff8d4968c77fb6c77d65b010b31ad6: Bug 1541412 - Add static-analysis check-java to source-test tasks, r=ahal,andi
Bastien Abadie <bastien@mozilla.com> - Mon, 08 Apr 2019 15:41:30 +0000 - rev 527589
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1541412 - Add static-analysis check-java to source-test tasks, r=ahal,andi Differential Revision: https://phabricator.services.mozilla.com/D25929
6f723cac81ddf18954af5c5b3d430864e849930b: Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 05 Apr 2019 21:42:17 +0000 - rev 527067
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542146 - Apply the change with the option StatementMacros from clang-format-8 r=andi # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D26280
55ed5f885d52c347f6ef98bb86d2eb71f2a729c3: Bug 1542146 - Use the new option StatementMacros from clang-format-8 r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 05 Apr 2019 21:41:57 +0000 - rev 527066
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1542146 - Use the new option StatementMacros from clang-format-8 r=andi Differential Revision: https://phabricator.services.mozilla.com/D26279
6a4df15647dc5bafc27baac34635c3d0e18ecb16: Bug 1540643 - Add testing/web-platform/tests/tools/third_party/ to the thirdparty list r=andi DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 10:25:29 +0000 - rev 526529
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540643 - Add testing/web-platform/tests/tools/third_party/ to the thirdparty list r=andi DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D25567
299b8a36da73c52e9a6f39c3ee292f6986ca1429: Bug 1540769 - Enable readability-redundant-preprocessor r=andi
Sylvestre Ledru <sledru@mozilla.com> - Tue, 02 Apr 2019 06:07:39 +0000 - rev 526362
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1540769 - Enable readability-redundant-preprocessor r=andi Differential Revision: https://phabricator.services.mozilla.com/D25630
20b1524329bb89a5fd944d46aa15183dc0caf6ce: Bug 1536790 - Also import clangTidyMPIModule when building the clang-plugin r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 12:24:37 +0000 - rev 526312
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536790 - Also import clangTidyMPIModule when building the clang-plugin r=andi Depends on D24175 Differential Revision: https://phabricator.services.mozilla.com/D25026
f5395d54a7d10df951f10edebe4d593436f85d50: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Sylvestre Ledru <sledru@mozilla.com> - Mon, 01 Apr 2019 12:24:35 +0000 - rev 526310
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Differential Revision: https://phabricator.services.mozilla.com/D24175
9eb7867c1dd431f6effdd99bfea5c8a003ebb730: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Sylvestre Ledru <sledru@mozilla.com> - Sat, 30 Mar 2019 01:23:21 +0200 - rev 525689
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Reviewers: andi Reviewed By: andi Bug #: 1536790 Differential Revision: https://phabricator.services.mozilla.com/D24175
20d5cdaa08e33da406709986f812c23404f33a96: Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 28 Mar 2019 17:49:41 +0000 - rev 525537
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi Patch wrote by Sylvestre Ledru (sylvestre@mozilla.com) Differential Revision: https://phabricator.services.mozilla.com/D24175
fa3daa92292dde4bf9405c56e43a464e53c349a2: Bug 1519636 - Ride along: Add media/libdav1d/version.h to the ignore list r=andi
Sylvestre Ledru <sledru@mozilla.com> - Wed, 27 Mar 2019 07:33:24 +0000 - rev 525127
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1519636 - Ride along: Add media/libdav1d/version.h to the ignore list r=andi Differential Revision: https://phabricator.services.mozilla.com/D24558
45e9712fb50e6abdc26ad0b311289fe50540c735: Bug 1539013. Teach MOZ_CAN_RUN_SCRIPT about taking pointers to live references. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:55:41 +0000 - rev 525038
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539013. Teach MOZ_CAN_RUN_SCRIPT about taking pointers to live references. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24840
4e4f6c86795203a8255bed21a17e2d5cfce12520: Bug 1539016 part 2. Teach MOZ_CAN_RUN_SCRIPT analysis about conditional operators. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:56:36 +0000 - rev 525037
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539016 part 2. Teach MOZ_CAN_RUN_SCRIPT analysis about conditional operators. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24839
48e6a07862e0c79ecac3aa7dc826a2f3e42bb98f: Bug 1539016 part 1. Refactor the MOZ_CAN_RUN_SCRIPT analysis a bit to make new live things easier to add. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 26 Mar 2019 20:56:16 +0000 - rev 525036
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1539016 part 1. Refactor the MOZ_CAN_RUN_SCRIPT analysis a bit to make new live things easier to add. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24838
eeff570a825a7370902317ae5dc53862d4f82c7e: Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:50 +0000 - rev 524245
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24258
664d49ea52757224083e93a9742e676bb8689ef4: Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:52:33 +0000 - rev 524244
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi Since these are compile-time constants, they can't exactly go away on us due to running script, right? Differential Revision: https://phabricator.services.mozilla.com/D24195
1133a148d29c657567b6985e08af96adab3328f7: Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:50:55 +0000 - rev 524243
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi We need to typecheck the trivials too, not just the final thing after trivials are stripped, because casts are trivials. Differential Revision: https://phabricator.services.mozilla.com/D24186
15a5f72d591f9af00b5379495e8d7258e5840226: Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:49:11 +0000 - rev 524242
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24120
9acf9a003aa388a9d7efd11fb2a9031b6a7ed7df: Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:48:33 +0000 - rev 524241
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi The old code for member method calls did the following: 1) Find the member method calls. 2) Look at their "this" expression. 3) If the "this" is an operator call, check for any of the arguments of the operator call being invalid. 4) Otherwise (if not an operator call) check for the "this" value being invalid. This wasn't right, because the "is invalid" check checks the type and only considers refcounted things. So if the code looked something like "foo[i]->call_method()", we would look at the types of "foo" and "i" and determine that none of those are refcounted types so there is nothing invalid here (since "foo" is some sort of array type and "i" is an integer). The new setup just checks whether the "this" value is invalid, which does the type check on the "this" value itself; in the "foo[i]->call_method()" case on "foo[i]". We then adjust the exclusions in InvalidArg to consider operator-> on known-live things valid, to allow the thing that we were really trying to accomplish with the "check for an operator call" bits: "stackRefPtr->some_method()". The test coverage being added for the made-up TArray type is meant to catch things like the geolocation issue that was being hidden by the buggy behavior. I'm not using nsTArray itself because some header included by nsTArray.h tries to define operator new/delete bits inline and that triggers warnings that then cause a clang-plugin test failure, because they're unexpected. Differential Revision: https://phabricator.services.mozilla.com/D24117
6365c8d87a5c8811f5dda4e4417450515e1f6bc3: Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 21 Mar 2019 11:47:22 +0000 - rev 524240
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi "this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT conditions hold, and its const members can't change value and drop their refs. Differential Revision: https://phabricator.services.mozilla.com/D23997
f754116e738e64751d2aad9ac0aa295aabd939ce: Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 20:04:13 +0000 - rev 524169
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1537537. Improve the MOZ_CAN_RUN_SCRIPT analysis reporting around invalid args. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24258
f9df48cfea437be34e3935f44d48c00c13b33f7f: Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 20:04:11 +0000 - rev 524168
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536736. Allow constexpr things in the MOZ_CAN_RUN_SCRIPT analysis. r=andi Since these are compile-time constants, they can't exactly go away on us due to running script, right? Differential Revision: https://phabricator.services.mozilla.com/D24195
7a9888e700cf54d199d2b373ef14cab07ce78609: Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 15:25:55 +0000 - rev 524167
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536825. Fix the interaction of ignoreTrivials and typechecks in MOZ_CAN_RUN_SCRIPT analysis. r=andi We need to typecheck the trivials too, not just the final thing after trivials are stripped, because casts are trivials. Differential Revision: https://phabricator.services.mozilla.com/D24186
e2551303c5cfeb97bc874cb750240dc10b413aaf: Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 14:40:34 +0000 - rev 524166
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536724. Consider a smartptr temporary to be live for MOZ_CAN_RUN_SCRIPT analysis purposes. r=andi Differential Revision: https://phabricator.services.mozilla.com/D24120
f497ce3b74193fdbc272e68719f3bc603e62571b: Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 18:08:16 +0000 - rev 524165
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536719. Fix handling of member method calls in the MOZ_CAN_RUN_SCRIPT analysis. r=andi The old code for member method calls did the following: 1) Find the member method calls. 2) Look at their "this" expression. 3) If the "this" is an operator call, check for any of the arguments of the operator call being invalid. 4) Otherwise (if not an operator call) check for the "this" value being invalid. This wasn't right, because the "is invalid" check checks the type and only considers refcounted things. So if the code looked something like "foo[i]->call_method()", we would look at the types of "foo" and "i" and determine that none of those are refcounted types so there is nothing invalid here (since "foo" is some sort of array type and "i" is an integer). The new setup just checks whether the "this" value is invalid, which does the type check on the "this" value itself; in the "foo[i]->call_method()" case on "foo[i]". We then adjust the exclusions in InvalidArg to consider operator-> on known-live things valid, to allow the thing that we were really trying to accomplish with the "check for an operator call" bits: "stackRefPtr->some_method()". The test coverage being added for the made-up TArray type is meant to catch things like the geolocation issue that was being hidden by the buggy behavior. I'm not using nsTArray itself because some header included by nsTArray.h tries to define operator new/delete bits inline and that triggers warnings that then cause a clang-plugin test failure, because they're unexpected. Differential Revision: https://phabricator.services.mozilla.com/D24117
fd59264c47c1bfe373888d234ededf056c1112fa: Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 20 Mar 2019 04:19:24 +0000 - rev 524164
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536336. Change MOZ_CAN_RUN_SCRIPT analysis to allow const members of "this" in addition to stack refptrs. r=andi "this" is guaranteed to stay alive as long as other MOZ_CAN_RUN_SCRIPT conditions hold, and its const members can't change value and drop their refs. Differential Revision: https://phabricator.services.mozilla.com/D23997
2a807fde4c47339f48e548127d215880183fbcae: Bug 1536763 - Support more than 100 files in ./mach static-analysis check, r=andi
Bastien Abadie <bastien@mozilla.com> - Wed, 20 Mar 2019 13:03:13 +0000 - rev 524031
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1536763 - Support more than 100 files in ./mach static-analysis check, r=andi Differential Revision: https://phabricator.services.mozilla.com/D24151
f65aaa2a97bb8bc7ab61a4fb650db6b356911767: Bug 1534421. Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 12:13:08 +0000 - rev 521707
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1534421. Fix the CAN_RUN_SCRIPT analysis to treat a deref of an arg as live if it would treat the arg as live. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23071
b6d239de820fce497fc6e7d5f6a10ad2a1a4122b: Bug 1534518. Change CanRunScriptChecker caller function note to point to the declaration, not the definition. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 12:11:34 +0000 - rev 521706
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1534518. Change CanRunScriptChecker caller function note to point to the declaration, not the definition. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23082
bad1df2f11e3962bea1ec567845e50399cf87357: Bug 1534630: Slightly optimize scheduling of clang-format jobs; r=andi
Benjamin Bouvier <benj@benj.me> - Tue, 12 Mar 2019 16:30:12 +0000 - rev 521671
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1534630: Slightly optimize scheduling of clang-format jobs; r=andi Instead of over-estimating the number of items in a batch, do the opposite: slightly under-estimate the number of items, then dispatch outstanding items (by just adding one item to each batch). Differential Revision: https://phabricator.services.mozilla.com/D23141
9b6190dc000dd50c2a971bb795c8df29099eb864: Bug 1506439 part 1. Fix CanRunScript analysis handling of arguments that default to null. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 13 Mar 2019 02:33:57 +0000 - rev 521642
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1506439 part 1. Fix CanRunScript analysis handling of arguments that default to null. r=andi Differential Revision: https://phabricator.services.mozilla.com/D23064
aaf573c47a9c2edf5eba678974d9745e21260acd: Bug 1533152 - [flake8] Make sure glob patterns are honoured when passing files directly, r=andi
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 12 Mar 2019 15:08:41 +0000 - rev 521566
Push 10867 by dvarga@mozilla.com at Thu, 14 Mar 2019 15:20:45 +0000
Bug 1533152 - [flake8] Make sure glob patterns are honoured when passing files directly, r=andi Flake8 ignores the 'exclude' section of the .flake8.yml if you pass in a direct path to a file. To get around this we have some custom logic to handle these exclusions for us, but this custom logic didn't account for globs. Differential Revision: https://phabricator.services.mozilla.com/D23145
94ae30387e57697e0044cad778459f751319fe11: Bug 1533617 part 5. Disallow virtual MOZ_CAN_RUN_SCRIPT methods overriding a non-MOZ_CAN_RUN_SCRIPT superclass method. r=andi
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 11 Mar 2019 14:20:27 +0000 - rev 521388
Push 10866 by nerli@mozilla.com at Tue, 12 Mar 2019 18:59:09 +0000
Bug 1533617 part 5. Disallow virtual MOZ_CAN_RUN_SCRIPT methods overriding a non-MOZ_CAN_RUN_SCRIPT superclass method. r=andi This way if a caller calls a method that has a MOZ_CAN_RUN_SCRIPT override, it can detect that it's possibly calling a MOZ_CAN_RUN_SCRIPT thing without having to know about the override. Differential Revision: https://phabricator.services.mozilla.com/D22839
fa4a19e4e88bf6cd3e08e8c447b0697b813f4231: Bug 1511160 - Add dom/media/webaudio/blink/ to the thirdparty list of code r=andi
Sylvestre Ledru <sledru@mozilla.com> - Thu, 29 Nov 2018 21:02:28 +0000 - rev 505291
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1511160 - Add dom/media/webaudio/blink/ to the thirdparty list of code r=andi Differential Revision: https://phabricator.services.mozilla.com/D13466
19475486e59680b67779fcf4c95a004e4c88d02f: Bug 1510919 - Make mach clang-format support .cc files r=andi
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 29 Nov 2018 07:21:33 +0000 - rev 505120
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1510919 - Make mach clang-format support .cc files r=andi Differential Revision: https://phabricator.services.mozilla.com/D13372
3b50a5b394b9467ba99fa0e956b53c49b66f3238: Bug 1508069 - Add js/src/editline to the ignore list r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 23 Nov 2018 21:57:50 +0000 - rev 504329
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508069 - Add js/src/editline to the ignore list r=andi Differential Revision: https://phabricator.services.mozilla.com/D12804
7906ebf6dfd90d32544c5128b8ca4fde02e46e35: Bug 1506756 - Remove the use of real_path added in bug 1501903. r=andi
Mike Hommey <mh+mozilla@glandium.org> - Tue, 13 Nov 2018 08:22:25 +0000 - rev 502424
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506756 - Remove the use of real_path added in bug 1501903. r=andi In the first part of bug 1501903, paths were canonicalized in inThirdPartyPath. For some reason, this seems to add a non-negligible overhead on Windows. OTOH, most include paths handed by the build system are absolute, and most paths that contains .. are for system headers, which don't matter for the inThirdPartyPath test. Considering the inThirdPartyPath has been using non-canonicalized paths for the longest, we'll assume it's fine to come back to that mode. Differential Revision: https://phabricator.services.mozilla.com/D11725
0f9d5e93e0ba6fb9bde4dfb9befd6b941d2007f6: Bug 1505943 - Add clang-format off to keep the line the same way r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 09 Nov 2018 15:09:58 +0000 - rev 501864
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1505943 - Add clang-format off to keep the line the same way r=andi Avoid lint cpp-virtual-final false positive Differential Revision: https://phabricator.services.mozilla.com/D11476
9349b769c3895fc20d0597992e074ab135f3cd5f: Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 09 Nov 2018 13:45:40 +0000 - rev 501846
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506117 - layout/style/nsCSSKeywordList.h: do not format r=andi Differential Revision: https://phabricator.services.mozilla.com/D11471
373660eb34c8a9d0fbc7ad0ad2874fbd2cb32c6b: Bug 1468447 - Add closure-library to the list of thirdparty r=andi DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Tue, 30 Oct 2018 11:47:16 +0000 - rev 499940
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1468447 - Add closure-library to the list of thirdparty r=andi DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D10188
1adc093c7842895d7e70c3b4b65ecb032bf154c1: Bug 1501903 - Cache the results of inThirdPartyPath. r=andi
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Oct 2018 21:21:36 +0000 - rev 499495
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501903 - Cache the results of inThirdPartyPath. r=andi The function is called a lot for the same paths and is rather costly, so cache the results for each path. Depends on D9758 Differential Revision: https://phabricator.services.mozilla.com/D9759
20af1d9ed3cd6ddf036d456f24815fa67c5a5d2f: Bug 1501903 - Properly handle paths in inThirdPartyPath. r=andi
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Oct 2018 11:05:27 +0000 - rev 499494
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1501903 - Properly handle paths in inThirdPartyPath. r=andi SourceLocation that are passed to inThirdPartyPath might be macro expansion locations, for which SourceManager.getFilename returns the path of the directory containing the source, rather than of the expansion location. Furthermore, the paths getFileName returns are not canonical, and can contain e.g. `..`. Differential Revision: https://phabricator.services.mozilla.com/D9758
cb24d2d42554fb0f0f01ee5de3187d19e9985de4: Bug 1466449 - Update Tokenizer.java and StackNode.java to initialize properties. r=andi
Jonathan Kingston <jkt@mozilla.com> - Mon, 22 Oct 2018 11:34:58 +0100 - rev 498961
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1466449 - Update Tokenizer.java and StackNode.java to initialize properties. r=andi
6b3e88486ae17007d89f1b4925104f6d9f33886d: Bug 1506756 - Remove the use of real_path added in bug 1501903. r=andi, a=NPOTB
Mike Hommey <mh+mozilla@glandium.org> - Tue, 13 Nov 2018 08:22:25 +0000 - rev 498526
Push 10203 by ryanvm@gmail.com at Thu, 15 Nov 2018 15:07:39 +0000
Bug 1506756 - Remove the use of real_path added in bug 1501903. r=andi, a=NPOTB In the first part of bug 1501903, paths were canonicalized in inThirdPartyPath. For some reason, this seems to add a non-negligible overhead on Windows. OTOH, most include paths handed by the build system are absolute, and most paths that contains .. are for system headers, which don't matter for the inThirdPartyPath test. Considering the inThirdPartyPath has been using non-canonicalized paths for the longest, we'll assume it's fine to come back to that mode. Differential Revision: https://phabricator.services.mozilla.com/D11725
2058a60f13a7172dec390d9608fe35e2e7761e55: Bug 1501903 - Cache the results of inThirdPartyPath. r=andi a=RyanVM
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Oct 2018 21:21:36 +0000 - rev 498172
Push 10054 by csabou@mozilla.com at Fri, 26 Oct 2018 19:18:40 +0000
Bug 1501903 - Cache the results of inThirdPartyPath. r=andi a=RyanVM The function is called a lot for the same paths and is rather costly, so cache the results for each path. Depends on D9758 Differential Revision: https://phabricator.services.mozilla.com/D9759
a186639fc5c55c43708a6f897902c714f0dab791: Bug 1501903 - Properly handle paths in inThirdPartyPath. r=andi a=RyanVM
Mike Hommey <mh+mozilla@glandium.org> - Thu, 25 Oct 2018 11:05:27 +0000 - rev 498171
Push 10054 by csabou@mozilla.com at Fri, 26 Oct 2018 19:18:40 +0000
Bug 1501903 - Properly handle paths in inThirdPartyPath. r=andi a=RyanVM SourceLocation that are passed to inThirdPartyPath might be macro expansion locations, for which SourceManager.getFilename returns the path of the directory containing the source, rather than of the expansion location. Furthermore, the paths getFileName returns are not canonical, and can contain e.g. `..`. Differential Revision: https://phabricator.services.mozilla.com/D9758
a471f63471541d373a70dbc4676dd0249122e187: Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r=andi
Sylvestre Ledru <sledru@mozilla.com> - Fri, 12 Oct 2018 16:16:01 +0000 - rev 496633
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r=andi Differential Revision: https://phabricator.services.mozilla.com/D8560
6fe284f84898c89846f765ae0746967789ecbe16: Bug 1253844 - Enable the readability-implicit-bool-conversion checker r=andi
Sylvestre Ledru <sledru@mozilla.com> - Wed, 03 Oct 2018 16:30:29 +0000 - rev 495375
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1253844 - Enable the readability-implicit-bool-conversion checker r=andi Differential Revision: https://phabricator.services.mozilla.com/D7606
ba9d952a37de83181cbf5e2ab3f35032401c75c8: Bug 1496084 - Document in config.yaml how to add a new checker r=andi
Sylvestre Ledru <sledru@mozilla.com> - Wed, 03 Oct 2018 15:53:31 +0000 - rev 495152
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1496084 - Document in config.yaml how to add a new checker r=andi Differential Revision: https://phabricator.services.mozilla.com/D7607