searching for reviewer(alwu)
5433da8d8132bf7743ae9db90889f2b95330441e: Bug 1580112 - Stop updating the database when the value has not changed. r=alwu a=RyanVM
Alex Chronopoulos <achronop@gmail.com> - Wed, 11 Sep 2019 20:21:51 +0000 - rev 551886
Push 11985 by nerli@mozilla.com at Wed, 18 Sep 2019 20:33:34 +0000
Bug 1580112 - Stop updating the database when the value has not changed. r=alwu a=RyanVM In most of the cases, the value to be stored is the same as the existing value, which does not require an update to the database. Setting something in the database requires disk access. By using this we avoid accessing the disk in the majority of the cases. Differential Revision: https://phabricator.services.mozilla.com/D45504
ab1e0dacd90a8a729b064755a70c8af73618e634: Bug 1576627 - Move MaybeNotifyAutoplayBlocked from Document to HTMLMediaElement; r=alwu
Edgar Chen <echen@mozilla.com> - Tue, 27 Aug 2019 21:22:19 +0000 - rev 550995
Push 11858 by rmaries@mozilla.com at Thu, 29 Aug 2019 15:29:30 +0000
Bug 1576627 - Move MaybeNotifyAutoplayBlocked from Document to HTMLMediaElement; r=alwu Given that it is used only in HTMLMediaElement. Differential Revision: https://phabricator.services.mozilla.com/D43452
4f5115932bdac48f923c48f7a4843f5925e131e2: Bug 1562990 - Remove 'audioMuted' and 'audioVolume' properties from nsIDOMWindowUtils. r=NeilDeakin,alwu,farre
Abdoulaye O. Ly <ablayelyfondou@gmail.com> - Mon, 19 Aug 2019 21:17:21 +0000 - rev 549311
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562990 - Remove 'audioMuted' and 'audioVolume' properties from nsIDOMWindowUtils. r=NeilDeakin,alwu,farre While working on porting the (audio-playback indicators) bug 1562990 to fission, we saw the potential to delete some methods in nsIDOMWindowUtils because they were not used anymore in our codebase except in a couple of tests files. So now, we should only mute/unmute or change the volume in the parent process. As such, interfaces are added in SpecialPowers to change media muted or volume state from content processes. Differential Revision: https://phabricator.services.mozilla.com/D41782
9d89249349d07225b6f5e34381ddbb9044ef2912: Bug 1573976 - Update hdcp version strings used in GetStatusForPolicy. r=dminor,alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 16 Aug 2019 17:17:32 +0000 - rev 549257
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1573976 - Update hdcp version strings used in GetStatusForPolicy. r=dminor,alwu These strings are detailed at https://github.com/WICG/hdcp-detection/blob/master/explainer.md, and were changed since the original implementation of this feature. Differential Revision: https://phabricator.services.mozilla.com/D42062
9666df4faff79b8883397e1210673a9a325b3106: Bug 1573976 - Fix GetStatusForPolicy handling of unrecognized values. r=dminor,alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 16 Aug 2019 17:47:21 +0000 - rev 549256
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1573976 - Fix GetStatusForPolicy handling of unrecognized values. r=dminor,alwu GetStatusPolicy should not treat unrecognized values as if they were no hdcp policy. A trivial example is that if we do not recognize a newer hdcp string, say "2.3", then we should not query if the CDM supports this policy as if it were no hdcp. This patch means that we surface and error to JS if we do no recognize an hdcp string. Differential Revision: https://phabricator.services.mozilla.com/D42061
2a7a1901557eb923fa616b28ac438818e7f087dc: Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 06 Aug 2019 17:48:41 +0000 - rev 547156
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu This fixes an edge case where it was possible for an HTMLMediaElement in the middle of setup to have ownership transferred to a inactive document and deref a null pointer. This happened because we have special handling for EME related media where we perform more aggressive shutdown on for media in inactive documents. As far as I can tell, there's nothing specced that forbids performing EME related functionality on elements in inactive documents. However, our code already prevents doing so in other cases. E.g. if you create an inactive document, place an HTMLMediaElement in it and try to setup EME related data on it, then that will fail. So this fix just covers another such case. While it would be nice to support doing these operations on inactive document's media, it seems like very much an edge case, and something that would require a large amount of reworking in how we handle inactive documents. We can cross that bridge later should we ever need do so. Differential Revision: https://phabricator.services.mozilla.com/D40482
3b56af8ee88e7ee682717a358cc65c284d45ea6a: Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Tue, 06 Aug 2019 17:48:29 +0000 - rev 547155
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D40481
21f0da4d57639840635aa5c9fcde97b57d44d829: Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 02 Aug 2019 21:53:53 +0000 - rev 546539
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1547784 - Return an error if an EME associated MediaElement becomes inactive as deocder setup finishes. r=alwu This fixes an edge case where it was possible for an HTMLMediaElement in the middle of setup to have ownership transferred to a inactive document and deref a null pointer. This happened because we have special handling for EME related media where we perform more aggressive shutdown on for media in inactive documents. As far as I can tell, there's nothing specced that forbids performing EME related functionality on elements in inactive documents. However, our code already prevents doing so in other cases. E.g. if you create an inactive document, place an HTMLMediaElement in it and try to setup EME related data on it, then that will fail. So this fix just covers another such case. While it would be nice to support doing these operations on inactive document's media, it seems like very much an edge case, and something that would require a large amount of reworking in how we handle inactive documents. We can cross that bridge later should we ever need do so. Differential Revision: https://phabricator.services.mozilla.com/D40482
54b3b878f07d47e40b6962b9f95ddfe1dd84b7ae: Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 02 Aug 2019 21:54:03 +0000 - rev 546538
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1547784 - Add crashtest for moving media element with media keys to inactive doc. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D40481
0928c6245907b29a632be53031c0f4ea358151ee: Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce
Dan Minor <dminor@mozilla.com> - Fri, 02 Aug 2019 18:17:45 +0000 - rev 546496
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce This removes all telemetry which expired in Firefox 69 or earlier, with the exceptions of the following, which we plan to renew: * AUDIO_TRACK_SILENCE_PROPORTION * MEDIA_AUTOPLAY_WOULD_BE_ALLOWED_COUNT * MEDIA_AUTOPLAY_WOULD_NOT_BE_ALLOWED_COUNT * MEDIACACHESTREAM_LENGTH_KB * MEDIA_MKV_CANPLAY_REQUESTED * MEDIA_PAGE_COUNT * MEDIA_PAGE_HAD_MEDIA_COUNT * VIDEO_DROPPED_FRAMES_PROPORTION * VIDEO_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE * VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE * VIDEO_INTER_KEYFRAME_AVERAGE_MS * VIDEO_INTER_KEYFRAME_MAX_MS * VIDEO_SUSPEND_RECOVERY_TIME_MS * VIDEO_VP9_BENCHMARK_FPS * WEB_AUDIO_BECOMES_AUDIBLE_TIME * WEBVTT_TRACK_KINDS Differential Revision: https://phabricator.services.mozilla.com/D37313
b8661a3b5dc23c855fbebf7af1ac0c2c47ddd20d: Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce
Dan Minor <dminor@mozilla.com> - Fri, 02 Aug 2019 15:37:59 +0000 - rev 546469
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1356046 - Remove expired media telemetry; r=jya,alwu,bryce This removes all telemetry which expired in Firefox 69 or earlier, with the exceptions of the following, which we plan to renew: * AUDIO_TRACK_SILENCE_PROPORTION * MEDIA_AUTOPLAY_WOULD_BE_ALLOWED_COUNT * MEDIA_AUTOPLAY_WOULD_NOT_BE_ALLOWED_COUNT * MEDIACACHESTREAM_LENGTH_KB * MEDIA_MKV_CANPLAY_REQUESTED * MEDIA_PAGE_COUNT * MEDIA_PAGE_HAD_MEDIA_COUNT * VIDEO_DROPPED_FRAMES_PROPORTION * VIDEO_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME * VIDEO_HIDDEN_PLAY_TIME_PERCENTAGE * VIDEO_INFERRED_DECODE_SUSPEND_PERCENTAGE * VIDEO_INTER_KEYFRAME_AVERAGE_MS * VIDEO_INTER_KEYFRAME_MAX_MS * VIDEO_SUSPEND_RECOVERY_TIME_MS * VIDEO_VP9_BENCHMARK_FPS * WEB_AUDIO_BECOMES_AUDIBLE_TIME * WEBVTT_TRACK_KINDS Differential Revision: https://phabricator.services.mozilla.com/D37313
9b3f4d1a7c206b88fd3cf4ae8beb4cf145a3136e: Bug 1561486 - shutdown demuxer early. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 10 Jul 2019 12:04:50 +0000 - rev 544147
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1561486 - shutdown demuxer early. r=alwu We don't need the demuxer after we've resolved the promise. Differential Revision: https://phabricator.services.mozilla.com/D36713
ee059061515f19c66cbc1466108d2cf0e05de0bd: Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 10 Jul 2019 05:24:54 +0000 - rev 542616
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D36566
b157ff9c0f229695504eec11632e1789a7820708: Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 09 Jul 2019 21:45:29 +0000 - rev 542536
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D36566
8fcc3c00d7c0113d0e86dcc8efc36d4b2fa1ab01: Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu a=RyanVM
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 10 Jul 2019 05:24:54 +0000 - rev 541346
Push 11580 by archaeopteryx@coole-files.de at Mon, 15 Jul 2019 14:32:23 +0000
Bug 1561484 - Keep MediaInfo object for entire benchmark. r=alwu a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D36566
8c6d523bdb3bdff85404f46576187a9ae035d32e: Bug 1553046 - Update wpt metadata for webvtt tests that crash. r=alwu
Maja Frydrychowicz <mjzffr@gmail.com> - Sat, 22 Jun 2019 06:36:53 +0000 - rev 539508
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1553046 - Update wpt metadata for webvtt tests that crash. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D35475
7a6d1ef048099da40346447f987474efb0234324: Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu
Andreas Pehrson <apehrson@mozilla.com> - Tue, 11 Jun 2019 11:49:26 +0000 - rev 538136
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1554699 - Don't fire "timeupdate" in PlayInternal as it's against spec. r=jya,alwu Bug 1279865 introduced this under the premise of "Run TimeMarchesOn() at the beginning of play.", but it did a bit too much. This makes us spec compliant for this particular case again. Differential Revision: https://phabricator.services.mozilla.com/D33650
75a6f48ca07813830b88470606a2145b2f7610e7: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Thu, 06 Jun 2019 09:06:09 +0000 - rev 537231
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
2dacf7539a2f6238bc9731fddc5eac8460fb9afc: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Wed, 05 Jun 2019 01:03:14 +0000 - rev 536627
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
d64cb52ebf88093b7c4b40597a795ed5d46a2214: Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers
Dale Harvey <dale@arandomurl.com> - Tue, 04 Jun 2019 17:33:06 +0000 - rev 536527
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1543812 - Add ability to block all autoplay. r=johannh,alwu,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D30135
b9bd90dd38bfcc9ea7231d0dd326fced00750749: Bug 1545108 - Use a diagnostic assert to check for nullptr when pushing into MediaQueue. r=alwu
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 25 Apr 2019 17:08:27 +0000 - rev 530173
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1545108 - Use a diagnostic assert to check for nullptr when pushing into MediaQueue. r=alwu We're rarely getting nullptrs out of MediaQueues. It's not clear where these are coming from, as we have many guards against them. Upgrade this assert to a diagnostic to help us track the source and determine if the value is null before entering the queue. Differential Revision: https://phabricator.services.mozilla.com/D28866
40db29867fd9f6fb49a8af84aa1f3029d5ea668a: Bug 1538003 - Disable some more intermittently failing webvtt tests. r=alwu"
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 26 Mar 2019 02:11:55 +0000 - rev 524857
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1538003 - Disable some more intermittently failing webvtt tests. r=alwu" Differential Revision: https://phabricator.services.mozilla.com/D24436
2d1930ba617fd4ab61d0c427b570faedd632aa34: Bug 1504060 - Log instead of asserting that webm samples do not have timestamps > segment druation. r=alwu
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 01 Mar 2019 18:20:00 +0000 - rev 519870
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1504060 - Log instead of asserting that webm samples do not have timestamps > segment druation. r=alwu We're able to hit this assertion in the wild due to bad muxers. As such, replace the assert with a log. If a sample has a time stamp > the segment duration, use that instead of the duration for calculating our next time stamp. Use an explicit int64_t type in the signature for our next time stamp calculation as the logging explicitly expects an int64_t (makes it harder to change the types involved and footgunning by having a wrong formatter in the logs). Differential Revision: https://phabricator.services.mozilla.com/D21717
a110f9abc663ae498abb7b9c929d64b350b972bc: Bug 1527863 - Prevent the video controls from inheriting white-space style. r=alwu
Jared Wein <jwein@mozilla.com> - Thu, 14 Feb 2019 18:08:32 +0000 - rev 517069
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1527863 - Prevent the video controls from inheriting white-space style. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D19802
589b502d9d46a8bd5bfec8da0022d9ca56eb1041: Bug 1519812 - toolkit/content/tests/browser/browser_autoplay* tests should be marked as the 'Audio/Video: Playback' component. r=alwu
Mark Banner <standard8@mozilla.com> - Mon, 14 Jan 2019 19:00:38 +0000 - rev 510937
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1519812 - toolkit/content/tests/browser/browser_autoplay* tests should be marked as the 'Audio/Video: Playback' component. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D16451
d5c767dcf1bba1d12d4a35c66ddc1a57842c5591: Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:47:01 +0000 - rev 507209
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P8. Use GenericNonExclusivePromise where needed. r=gerald,alwu Those MozPromises are shared and must be made non-exclusive Differential Revision: https://phabricator.services.mozilla.com/D14032
167783db980446c172f7c3bab123cd565a8ed886: Bug 1512456 - P4. Replace assert with MOZ_ASSERT. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:46:25 +0000 - rev 507205
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P4. Replace assert with MOZ_ASSERT. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D14027
2109be597625ff232c74d6b8778f32fcd964563c: Bug 1512456 - P1. Don't use GenericPromise with MediaSink. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Dec 2018 10:44:51 +0000 - rev 507202
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512456 - P1. Don't use GenericPromise with MediaSink. r=alwu The VideoSink shares the AudioSink's own EndedPromise to notify its user that it has ended. As such, the MozPromise used must be non-exclusive. Using the GenericPromise for such purpose only hid that requirement. We also remove the MediaSink from the media namespace, and clarify the naming of some arguments and class members to accurately describe what they do. Differential Revision: https://phabricator.services.mozilla.com/D14024
720f409b83f27d5c92c9194157b6f7ac65068361: Bug 1423241 - Remove screen-wakelock code that no longer has an effect. r=alwu
Andreas Pehrson <apehrson@mozilla.com> - Fri, 23 Nov 2018 15:01:18 +0000 - rev 504267
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1423241 - Remove screen-wakelock code that no longer has an effect. r=alwu Differential Revision: https://phabricator.services.mozilla.com/D9102
6a32be5a7100fc82eea08a2952778c2dce7e84ff: Bug 1506076 - Mark video android decoder as needing AnnexB. r=jolin,alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 09 Nov 2018 22:07:40 +0000 - rev 501920
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506076 - Mark video android decoder as needing AnnexB. r=jolin,alwu It only used to work as the H264Converter used to check that the conversion needed was != kNeedAVCC (the default being kNone) Differential Revision: https://phabricator.services.mozilla.com/D11526
7f1d96b0004f2d12a131dbf1116cda7bf3410dfb: Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Sep 2018 21:21:11 +0000 - rev 492000
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu The MozAutoplayMediaBlocked event should have its target set to the video element, not the document. Also, MozNoControlsBlockedVideo event has to initialized from the CustomEvent constructor of the right window for the XBL binding to access it. I don't know when it stopped working. Test is added to ensure the entire UI won't break. Differential Revision: https://phabricator.services.mozilla.com/D5801
b88bbab404c63daba2e0994f937ab62bf05d44fb: Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Sep 2018 22:38:43 +0000 - rev 491999
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1491066 - Allow TextTrackManager to pass cue without videocontrols r=alwu With UA Widget, the videocontrols container is created lazily. It won't be a problem for WebVTT.processCues() in vtt.jsm, so TextTrackManager::UpdateCueDisplay() should not early return there, but pass nullptr to it. Differential Revision: https://phabricator.services.mozilla.com/D3667
b28c1da957075c15f306c05ff94332210b09b277: Bug 1488520 - Continue searching for a moof until a valid one is found. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 06 Sep 2018 18:32:37 +0000 - rev 490837
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1488520 - Continue searching for a moof until a valid one is found. r=alwu It is possible for audio and videos moofs to be interleaved in the stream. If we were to stop on an invalid moof or a moof whose track ID doesn't match, the track would end up not playing. Differential Revision: https://phabricator.services.mozilla.com/D5157
34cfa5617f98a5bdd84ba2a9765fded743c4ac96: Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu a=pascalc
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 13 Sep 2018 21:21:11 +0000 - rev 490040
Push 9887 by dluca@mozilla.com at Tue, 25 Sep 2018 16:09:06 +0000
Bug 1487143 - Properly dispatch MozAutoplayMediaBlocked event to content, r=alwu a=pascalc The MozAutoplayMediaBlocked event should have its target set to the video element, not the document. Also, MozNoControlsBlockedVideo event has to initialized from the CustomEvent constructor of the right window for the XBL binding to access it. I don't know when it stopped working. Test is added to ensure the entire UI won't break. Differential Revision: https://phabricator.services.mozilla.com/D5801
f5f55e363d318effdfd504061c50f87e06301c6f: Bug 1478208 - Implement HTMLMediaElement.allowedToPlay. r=alwu,bz
Chris Pearce <cpearce@mozilla.com> - Wed, 25 Jul 2018 14:25:17 +1200 - rev 484778
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1478208 - Implement HTMLMediaElement.allowedToPlay. r=alwu,bz Various web authors have expressed desire to know in advance whether autoplay will work. They want this in order to avoid paying the price for downloading media that won't play. Or they want to take other action such as showing a poster image instead. This is of particular interest to Firefox, as we're planning on showing a prompt to ask the user whether they would like a site to play. If sites want to determine whether they can autoplay but avoid the prompt showing, they won't be able to just call play() in Firefox and see whether it works, as that would likely show the prompt if the user doesn't already have a stored permission. We've been working out a spec here: https://github.com/whatwg/html/issues/3617#issuecomment-398613484 This implements what is the consensus to date there; HTMLMediaElement.allowedToPlay, which returns true when a play() call would not be blocked with NotAllowedError by autoplay blocking policies. MozReview-Commit-ID: AkBu0G7uCJ0
f4e4541f3c1c760975a76668e72e11f1f56d8b3c: Bug 1477881 - Ensure AutoplayPermissionRequest can't double report a response. r=alwu
Chris Pearce <cpearce@mozilla.com> - Tue, 24 Jul 2018 10:23:05 +1200 - rev 483144
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1477881 - Ensure AutoplayPermissionRequest can't double report a response. r=alwu We cancel the permission request in the AutoplayPermissionRequest destructor, and if we get a genuine cancel from the doorhanger. The Request reports the cancel to the AutoplayPermissionManager, but we reuse the same manager across different requests. So if a second request for permission comes in, we create a new AutoplayPermissionRequest and fire that off to the front end code, but the first request could be destroyed after the second request is dispatched but before the response for the second request has retuned. Thus and the cancel in the first's destructor could be reported to the manager as the second's result. We should clear the AutoplayPermissionRequest's reference to the Manager in Approve() and Cancel() so that we can't mixup the responses like this. MozReview-Commit-ID: 1qYJfLOaqST
36a8327139530a95003d431f3f43e7c3f6f9c3ee: Bug 1395086 - Increase max wait time to avoid intermittent failure in testAudioFocus; r=alwu
Geoff Brown <gbrown@mozilla.com> - Thu, 18 Jan 2018 11:25:45 -0700 - rev 451718
Push 8560 by ryanvm@gmail.com at Fri, 19 Jan 2018 16:34:00 +0000
Bug 1395086 - Increase max wait time to avoid intermittent failure in testAudioFocus; r=alwu
772fef647fd7750f8c87dfd4f55bbd85046a555a: Bug 1420608. P2 - fix the test timeout. r=alwu
JW Wang <jwwang@mozilla.com> - Fri, 08 Dec 2017 17:35:29 +0800 - rev 447892
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1420608. P2 - fix the test timeout. r=alwu See comment 50 for the cause. Since file_silentAudioTrack.html calls play() to start playback immediately, it is possible that 'mozentervideosuspend' has been fired before check_video_decoding_state() has a chance to register event handlers. We call load() and play() to start playback from the beginning so we won't miss any events. MozReview-Commit-ID: 9sKygfIxEtS
5a9fbe6806cfa927e1b19c60f0f351ae0e6f7777: Bug 1415821 - Correct the behavior for BADCUE state. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 15 Nov 2017 17:21:09 +0800 - rev 443940
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415821 - Correct the behavior for BADCUE state. r=alwu MozReview-Commit-ID: G59NBC9rcGa
1786297a20dfb8cdd1082edc746b9479e78435a1: Bug 1415821 - Support multi-line parsing for REGION/STYLE block. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 15 Nov 2017 10:25:02 +0800 - rev 443939
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415821 - Support multi-line parsing for REGION/STYLE block. r=alwu MozReview-Commit-ID: HhRkv27UPO
0f276f1cc275f89a759e956c8b2ccc5388387f07: Bug 1415821 - Modify .vtt REGION syntax. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 15 Nov 2017 10:24:59 +0800 - rev 443938
Push 8527 by Callek@gmail.com at Thu, 11 Jan 2018 21:05:50 +0000
Bug 1415821 - Modify .vtt REGION syntax. r=alwu MozReview-Commit-ID: 4GydOirj87V
e6296bec0ce15fe0c8b31502cf0f0a7fae245c66: Bug 1409983 - Reorder the shouldCompute() funciton and "remove all child nodes of MediaElement" in vtt.jsm. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Thu, 19 Oct 2017 16:30:38 +0800 - rev 438427
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1409983 - Reorder the shouldCompute() funciton and "remove all child nodes of MediaElement" in vtt.jsm. r=alwu We should call shouldCompute() function first, then remove all children of MediaElement. MozReview-Commit-ID: 6623Xn6T4mx
e676d685201215b687fd5946712d5d457d6722dd: Bug 1407940 - P2. Only ever access mTaskQueue in a thread-safe fashion. r=alwu,gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 12 Oct 2017 13:30:47 +0200 - rev 436838
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1407940 - P2. Only ever access mTaskQueue in a thread-safe fashion. r=alwu,gerald mTaskQueue is only read on the main thread, but read and written on the demuxer's taskqueue. We need to ensure that accesses are synchronised. MozReview-Commit-ID: Gbc15iYgZOe
6d14932fb843455f20e536849b73c0f92ba1871e: Bug 1401922 - P2. Only set error when non handled. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 21 Sep 2017 13:29:54 +0200 - rev 433064
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1401922 - P2. Only set error when non handled. r=alwu MozReview-Commit-ID: CF2Iw0i0nD8
907df99df1bba77704558b8ff712b4b75b897439: Bug 1401922 - P1. Ensure an error is returned when no decoder could be created. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 21 Sep 2017 13:25:05 +0200 - rev 433063
Push 8114 by jlorenzo@mozilla.com at Thu, 02 Nov 2017 16:33:21 +0000
Bug 1401922 - P1. Ensure an error is returned when no decoder could be created. r=alwu PDMFactory::CreateDecoder may not always modify CreateDecoderParams::mError as not all PDM handle this optional return value. MozReview-Commit-ID: K8WFA0o778U
d2a6c60348a88fa912539f986f259ac63db5d806: Bug 1401922 - P2. Only set error when non handled. r=alwu, a=sledru
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 21 Sep 2017 13:29:54 +0200 - rev 431886
Push 7837 by ryanvm@gmail.com at Wed, 27 Sep 2017 17:37:56 +0000
Bug 1401922 - P2. Only set error when non handled. r=alwu, a=sledru MozReview-Commit-ID: CF2Iw0i0nD8
7cd3c4b643b04c8f15e325fa9b08b390ad170e8c: Bug 1401922 - P1. Ensure an error is returned when no decoder could be created. r=alwu, a=sledru
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 21 Sep 2017 13:25:05 +0200 - rev 431885
Push 7837 by ryanvm@gmail.com at Wed, 27 Sep 2017 17:37:56 +0000
Bug 1401922 - P1. Ensure an error is returned when no decoder could be created. r=alwu, a=sledru PDMFactory::CreateDecoder may not always modify CreateDecoderParams::mError as not all PDM handle this optional return value. MozReview-Commit-ID: K8WFA0o778U
f59c34720c8037e17f2205f65a2c8cad85455b93: Bug 1400537 - P1. Don't assume that the PDM will properly report an error. r=alwu
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 17 Sep 2017 18:01:37 +0200 - rev 430924
Push 7775 by ryanvm@gmail.com at Tue, 19 Sep 2017 01:22:09 +0000
Bug 1400537 - P1. Don't assume that the PDM will properly report an error. r=alwu Only the Windows H264 decoder supports CreateDecoderParam::mError, all the other PDM leave the value untouched. As such, it can't be assumed that in case of failure, the mError attribute will be set. MozReview-Commit-ID: GWHGP6Wv3fl
2bf1aae5795a74407c9aad2dd8962aae433b03fc: Bug 1400180 - Fix CID 1417508 Uninitialized members of TextTrackCue::mLine and mPosition by giving them default values. r=alwu
James Cheng <jacheng@mozilla.com> - Fri, 15 Sep 2017 17:12:38 +0800 - rev 430606
Push 7768 by ryanvm@gmail.com at Sat, 16 Sep 2017 16:13:49 +0000
Bug 1400180 - Fix CID 1417508 Uninitialized members of TextTrackCue::mLine and mPosition by giving them default values. r=alwu MozReview-Commit-ID: CB6980MNqP1
8cd07fc93f8bc17c7114949adf813d26aeed55d0: Bug 1372329 - Disable layout/reftests/webm-video/poster-2.html on Android 4.3. r=alwu
bechen@mozilla.com <bechen@mozilla.com> - Wed, 06 Sep 2017 11:03:09 +0800 - rev 428688
Push 7761 by jlund@mozilla.com at Fri, 15 Sep 2017 00:19:52 +0000
Bug 1372329 - Disable layout/reftests/webm-video/poster-2.html on Android 4.3. r=alwu MozReview-Commit-ID: CMzmIA8YI3i