searching for reviewer(aklotz)
d8c1bf3fd700aea554a6ea902b32c354ead17895: Bug 1644561 - Verify that mCapturePixelsResults is not empty. r=aklotz
Agi Sferro <agi@sferro.dev> - Wed, 24 Jun 2020 17:07:03 +0000 - rev 601295
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1644561 - Verify that mCapturePixelsResults is not empty. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D80757
53f01e0036e1bf65486cb0b0158f69de2ee46bd7: Bug 1635564 - Implement ensureBuiltIn. r=droeh,aklotz
Agi Sferro <agi@sferro.dev> - Tue, 23 Jun 2020 19:03:50 +0000 - rev 601042
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1635564 - Implement ensureBuiltIn. r=droeh,aklotz Verified locally that reading the manifest does not affect performance in Fenix (which uses 5 different built-in extensions) for google.com. 79.0.20200617184425 - Don't parse manifest fully-drawn : avg: 2030 ± 11 stddev: 112 n=101 about:blank : avg: 2775 ± 26 stddev: 265 n=101 page loaded : avg: 3922 ± 50 stddev: 503 n=101 79.0.20200617205116 - Parse manifest fully-drawn : avg: 2025 ± 13 stddev: 130 n=89 about:blank : avg: 2761 ± 24 stddev: 232 n=89 page loaded : avg: 3866 ± 39 stddev: 377 n=89 Differential Revision: https://phabricator.services.mozilla.com/D80567
47d8e049731befdfbdcd65c1fd09541fc206dfe3: Bug 1647761 - Part 2: Remove outdated process priority terminology, r=mccr8,geckoview-reviewers,aklotz
Nika Layzell <nika@thelayzells.com> - Tue, 23 Jun 2020 17:34:51 +0000 - rev 601031
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1647761 - Part 2: Remove outdated process priority terminology, r=mccr8,geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D80684
f612d453e009554f7d9a375ebf01e8606178c38c: Bug 1642577 - De-elevate the process with CreateProcessAsUser if the compat flag RUNASADMIN is set. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Mon, 22 Jun 2020 18:37:49 +0000 - rev 600724
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1642577 - De-elevate the process with CreateProcessAsUser if the compat flag RUNASADMIN is set. r=aklotz If the process was elevated due to AppCompatFlags, we should not use LaunchUnelevated to launch the browser process because it starts an infinite loop of process launch. The fix is to make GetElevationState return a new elevation state if RUNASADMIN is set in AppCompatFlags. With that state, we use CreateProcessAsUser to launch the browser process. Differential Revision: https://phabricator.services.mozilla.com/D80114
5066e3d136dc7ade7f3e5547a66735d156caf8b4: Bug 1640087: Part 2: tuck optimized prefetches behind a preference. r=dthayer,aklotz
Emma Malysz <emalysz@mozilla.com> - Mon, 22 Jun 2020 16:38:15 +0000 - rev 600682
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1640087: Part 2: tuck optimized prefetches behind a preference. r=dthayer,aklotz PrefetchRegistryInfo is intended to be a temporary file in order to conduct this experiment on startup times vs. retention. Most of the implementation is similar to LauncherRegistryInfo. If we startup and the registry is different than the preference, we will want to use the preference for the purpose of this experiment. Differential Revision: https://phabricator.services.mozilla.com/D76993
5409134fc766cfea378963fa5a37ac9c56515fdd: Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 16 Jun 2020 12:22:55 +0000 - rev 599931
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz This removes the support for the 'geckoview' telemetry in the core and in the JSM files. It also cleans up testing and the configurations. Differential Revision: https://phabricator.services.mozilla.com/D79521
dd0ce5e4a1bf410938a840a8ee223b250bb66f54: Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 16 Jun 2020 08:49:12 +0000 - rev 599902
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz This removes the support for the 'geckoview' telemetry in the core and in the JSM files. It also cleans up testing and the configurations. Differential Revision: https://phabricator.services.mozilla.com/D79521
b746ee53bfe9d96612b4397349d81cb0564293a0: Bug 1643129 - Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Wed, 10 Jun 2020 05:44:48 +0000 - rev 599035
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1643129 - Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz This is needed in order to catch certain problems with LoginStorage.jsm. Differential Revision: https://phabricator.services.mozilla.com/D78142
aa85ec8bc0721238f2c3a88342dfeca418b036fd: Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj
Ricky Stewart <rstewart@mozilla.com> - Mon, 01 Jun 2020 16:00:28 +0000 - rev 597410
Push 13310 by ffxbld-merge at Mon, 29 Jun 2020 14:50:06 +0000
Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible. Differential Revision: https://phabricator.services.mozilla.com/D77496
0929113893bd796bc5b0d4002585878a8506ec9d: Bug 1618058 - [2.c.7] Implement Autocomplete API backend. r=geckoview-reviewers,MattN,aklotz
Eugen Sawin <esawin@mozilla.com> - Mon, 25 May 2020 18:45:25 +0000 - rev 595822
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1618058 - [2.c.7] Implement Autocomplete API backend. r=geckoview-reviewers,MattN,aklotz Differential Revision: https://phabricator.services.mozilla.com/D73753
f121c6c8aeb0c4b6f1e4a5c5d1b58648746a14da: Bug 1639275 - Add some null checking to Base64Utils r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Wed, 20 May 2020 21:58:33 +0000 - rev 595205
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1639275 - Add some null checking to Base64Utils r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D76219
6c10970490f3cc19e644964f583be1a047c08b2c: Bug 1628903: Prefetch DLLs to improve disk reads on Windows HDD devices. r=aklotz
Emma Malysz <emalysz@mozilla.com> - Wed, 20 May 2020 17:09:24 +0000 - rev 595049
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1628903: Prefetch DLLs to improve disk reads on Windows HDD devices. r=aklotz These DLLs were identified as good candidates for prefetch using the diskify logs. Differential Revision: https://phabricator.services.mozilla.com/D73121
9c6d6a6348256a1e350b08751bcbad7c75440ce2: Bug 1636656 - Update Clobber r=aklotz
J.C. Jones <jjones@mozilla.com> - Wed, 20 May 2020 18:14:36 +0000 - rev 595047
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636656 - Update Clobber r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D76195
2533428c72fb9d304286dbf87114b979b4b9ed04: Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 20 May 2020 14:07:19 +0000 - rev 595042
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz If the drop target did not initiate an async operation, `DoDragDrop` will block on the main thread until the data transfer completes. Although the `ObtainCachedIconFile` callback itself will run off the main thread, `ObtainCachedIconFile` will end up with calling `NotifyIconObservers` that heavily relies on the main thread. So `ObtainCachedIconFile` will have no chance to run the callback. To complete the data transfer, however, the `ObtainCachedIconFile` callback must signal the event object to unblock `CMemStream::Read`. Deadlock. Differential Revision: https://phabricator.services.mozilla.com/D75531
ea4dbf383a4d727a5d5fbcf78dc315c337ec0414: Bug 1638251 - Remove unused members in Frame from GeckoJavaSampler. r=geckoview-reviewers,aklotz,canaltinova
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 18 May 2020 14:15:28 +0000 - rev 594471
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1638251 - Remove unused members in Frame from GeckoJavaSampler. r=geckoview-reviewers,aklotz,canaltinova fileName and lineNo are unused now. Differential Revision: https://phabricator.services.mozilla.com/D75481
cc785b60375172d99168ef6deda4e65082cbea2e: Bug 1636646. ifdef direct manipulation code so it's not compiled on mingw. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Sat, 09 May 2020 21:38:55 +0000 - rev 592748
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1636646. ifdef direct manipulation code so it's not compiled on mingw. r=aklotz It seems like the build environment needs updating/modifying so it can handle this. But for now we unbreak the build. Differential Revision: https://phabricator.services.mozilla.com/D74525
321438a68aab3d4faff5fa3ed5dac29e02a59d9f: Bug 1630912. Create the necessary direct manipulation objects. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:19:58 +0000 - rev 592701
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Create the necessary direct manipulation objects. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D71305
b1bd509220e999f0184962a19e098ddda8603038: Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Fri, 08 May 2020 23:19:38 +0000 - rev 592700
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz We need this in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D71304
875ebbd9a1c941dadc923d08bd3271e846ad77d5: Bug 1635569 - Set execute flags when prefetching images r=aklotz
Doug Thayer <dothayer@mozilla.com> - Wed, 06 May 2020 11:53:27 +0000 - rev 592257
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1635569 - Set execute flags when prefetching images r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D73941
c4023f4d8d8b55caf3156a6dc1bf410e1e3fa605: Bug 1632583: Only register taskbar button creation message in the parent process. r=aklotz
Bob Owen <bobowencode@gmail.com> - Tue, 05 May 2020 16:11:44 +0000 - rev 592102
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1632583: Only register taskbar button creation message in the parent process. r=aklotz This also removes XRE_Win32kCallsAllowed and replaces its other use. Differential Revision: https://phabricator.services.mozilla.com/D73909
4d31941a0eb4f8ff4419dcf2ea2f2bdca16e6e63: Bug 1634493 - Add GVE setting for extensions in private browsing. r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 05 May 2020 18:07:47 +0000 - rev 591949
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634493 - Add GVE setting for extensions in private browsing. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D73771
65e4e70c6851a13827fd9173d88adc828fb40b81: Bug 1634493 - Wait for extension policy to be ready. r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 05 May 2020 18:07:40 +0000 - rev 591948
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1634493 - Wait for extension policy to be ready. r=aklotz When exporting the addon object, the extension policy sometimes is not ready yet (very common when `list()` is called at startup), so we need to wait until it's ready or the values in it will not be correct. Differential Revision: https://phabricator.services.mozilla.com/D73770
e202ddeb4e40d0c6b19d84bc37e600df092cf9a5: Bug 1630912. Create the necessary direct manipulation objects. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Mon, 04 May 2020 15:26:39 +0000 - rev 591760
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Create the necessary direct manipulation objects. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D71305
f7d9852a3d090d251ec9b68722d8e7c80a35f7bc: Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz
Timothy Nikkel <tnikkel@gmail.com> - Fri, 01 May 2020 23:32:38 +0000 - rev 591759
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1630912. Add PT_TOUCHPAD to touchinjection_sdk80.h. r=aklotz We need this in a later patch. Differential Revision: https://phabricator.services.mozilla.com/D71304
b1e3283418511f9d4be419c5f34c333eb312cdb3: Bug 1620118 - Part 1: Add ProcessedModuleLoadEvent::mIsDependent. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Mon, 04 May 2020 17:20:51 +0000 - rev 591650
Push 13186 by ffxbld-merge at Mon, 01 Jun 2020 09:52:46 +0000
Bug 1620118 - Part 1: Add ProcessedModuleLoadEvent::mIsDependent. r=aklotz This patch adds a boolean field `mIsDependent` indicating whether a module was loaded via the executable's Import Directory Table or not. This patch also partially reverts Bug 1587539, moving a logic to detect Import Directory tampering to `PEHeaders`'s ctor. With this, we can skip generating a map of the executable's dependent modules if no tampering is detected. Differential Revision: https://phabricator.services.mozilla.com/D66274
6300450479416459fad0ad5d12d86fe4201e0a39: Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz, a=pascalc
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 20 May 2020 14:07:19 +0000 - rev 591547
Push 13173 by ryanvm@gmail.com at Thu, 21 May 2020 20:26:54 +0000
Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz, a=pascalc If the drop target did not initiate an async operation, `DoDragDrop` will block on the main thread until the data transfer completes. Although the `ObtainCachedIconFile` callback itself will run off the main thread, `ObtainCachedIconFile` will end up with calling `NotifyIconObservers` that heavily relies on the main thread. So `ObtainCachedIconFile` will have no chance to run the callback. To complete the data transfer, however, the `ObtainCachedIconFile` callback must signal the event object to unblock `CMemStream::Read`. Deadlock. Differential Revision: https://phabricator.services.mozilla.com/D75531
54d5f4042cb1c53e456c76e29a2e127f74ffd8f8: Bug 1630655 - Squash TSAN data race report in IOInterposer r=aklotz
Doug Thayer <dothayer@mozilla.com> - Thu, 30 Apr 2020 17:17:21 +0000 - rev 590524
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1630655 - Squash TSAN data race report in IOInterposer r=aklotz In practice this shouldn't substantially change the behavior, but it gets around being UB, and it shouldn't really cost us in terms of performance. The alternative would be adding it to the TSAN whitelist, which feels worse. Differential Revision: https://phabricator.services.mozilla.com/D72015
b2494600413762179d7adad5b515fb52c3cc169c: Bug 1633650: mscom::Interceptor: Don't call HandlerProvider::GetPayloadSize for external process callers. r=aklotz
James Teh <jteh@mozilla.com> - Tue, 28 Apr 2020 16:21:58 +0000 - rev 590022
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1633650: mscom::Interceptor: Don't call HandlerProvider::GetPayloadSize for external process callers. r=aklotz When an Interceptor is marshaled for an external (non-chrome) process caller, we do not provide a handler and thus don't call HandlerProvider::WriteHandlerPayload. However, GetMarshalSizeMax previously called HandlerProvider::GetPayloadSize even for external process callers. For a11y's handlerProvider, we must build the payload to get the size. This is wasteful in this case, since we're just going to throw it away. Differential Revision: https://phabricator.services.mozilla.com/D72796
927287985117099359053d980bfca6f33c80f6cf: Bug 1627084 part 3: Build handler payloads in HandlerProvider::ToWrappedObject. r=aklotz,MarcoZ
James Teh <jteh@mozilla.com> - Fri, 24 Apr 2020 20:31:22 +0000 - rev 589545
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1627084 part 3: Build handler payloads in HandlerProvider::ToWrappedObject. r=aklotz,MarcoZ This avoids separate cross-thread calls when marshaling each object returned from an IGeckoBackChannel bulk fetch method. Differential Revision: https://phabricator.services.mozilla.com/D69485
24936cdfa320fdd4f0cd25ecdd6d64a43e50e7df: Bug 1627084 part 2: mscom: Provide access to the HandlerProvider from the Interceptor. r=aklotz
James Teh <jteh@mozilla.com> - Fri, 24 Apr 2020 20:25:21 +0000 - rev 589544
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1627084 part 2: mscom: Provide access to the HandlerProvider from the Interceptor. r=aklotz Because MainThreadHandoff sits between the Interceptor and the HandlerProvider, the caller must: 1. Get the event sink (the IInterceptorSink) from the Interceptor using IInterceptor::GetEventSink. 2. QI to the new IMainThreadHandoff interface. (An IInterceptorSink might not necessarily be a MainThreadHandoff.) 3. Get the HandlerProvider from the MainThreadHandoff using IMainThreadHandoff::GetHandlerProvider. Differential Revision: https://phabricator.services.mozilla.com/D69484
269ca6f2610cce1c9c8fb0179645e652b2a09037: Bug 1627084 part 1: Don't compile ipc/mscom/MainThreadHandoff.cpp in unified mode. r=aklotz
James Teh <jteh@mozilla.com> - Fri, 24 Apr 2020 20:22:06 +0000 - rev 589543
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1627084 part 1: Don't compile ipc/mscom/MainThreadHandoff.cpp in unified mode. r=aklotz We need to define INITGUID here in a subsequent patch, which is incompatible with unified mode. Differential Revision: https://phabricator.services.mozilla.com/D70292
2e05e81cc8582a7e5f5ab8bc43bbed0ebd501f74: Bug 1630655 - Squash TSAN data race report in IOInterposer r=aklotz
Doug Thayer <dothayer@mozilla.com> - Fri, 24 Apr 2020 20:31:53 +0000 - rev 589526
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1630655 - Squash TSAN data race report in IOInterposer r=aklotz In practice this shouldn't substantially change the behavior, but it gets around being UB, and it shouldn't really cost us in terms of performance. The alternative would be adding it to the TSAN whitelist, which feels worse. Differential Revision: https://phabricator.services.mozilla.com/D72015
322f2ff6b80ac0e86e8c991bd2b79a07f133143c: Bug 1595596 - Use MMAP_FAULT_HANDLER in StartupCache r=aklotz
Doug Thayer <dothayer@mozilla.com> - Fri, 10 Apr 2020 21:16:15 +0000 - rev 586954
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1595596 - Use MMAP_FAULT_HANDLER in StartupCache r=aklotz Please double check that I am using this correctly. I believe we are seeing the crash in the linked bug because we are not handling hardware faults when reading from the memory mapped file. This patch just wraps all accesses in the MMAP_FAULT_HANDLER_ macros. Depends on D53042 Differential Revision: https://phabricator.services.mozilla.com/D53043
b21a6490b28626fc1c4513a10bf2205babdc3756: Bug 1628449 - Dispatch `onLoadRequest()` return values immediately r=geckoview-reviewers,agi,aklotz
James Willcox <snorp@snorp.net> - Wed, 08 Apr 2020 20:35:15 +0000 - rev 586523
Push 13072 by ffxbld-merge at Mon, 04 May 2020 14:22:08 +0000
Bug 1628449 - Dispatch `onLoadRequest()` return values immediately r=geckoview-reviewers,agi,aklotz This is a very performance-critical path, so we want to avoid dispatching the value listener on a future loop iteration. Differential Revision: https://phabricator.services.mozilla.com/D70247
5c3c02b4f8ca53fffa1f81403332e75aada918ef: Bug 1535365 - Enable the extension process. r=snorp,aklotz
Agi Sferro <agi@sferro.dev> - Fri, 03 Apr 2020 20:55:25 +0000 - rev 585315
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1535365 - Enable the extension process. r=snorp,aklotz Differential Revision: https://phabricator.services.mozilla.com/D69596
5a8b721ced71ec42afeed7a774f2fab205d83cd5: Bug 1624336 - Block old versions of COMODO Firewall to prevent them from crashing Firefox r=aklotz
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 02 Apr 2020 20:47:30 +0000 - rev 585175
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624336 - Block old versions of COMODO Firewall to prevent them from crashing Firefox r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D68188
f38bdddd570d59a054431f5a44f245180fb086bc: Bug 1617436 - Reset caret before doing another find in page test. r=geckoview-reviewers,aklotz
Eitan Isaacson <eitan@monotonous.org> - Wed, 01 Apr 2020 16:18:50 +0000 - rev 585166
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1617436 - Reset caret before doing another find in page test. r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D69229
523e9e4e336c5b73a3b9e0b5c8f61fc3c0b8bc7e: Bug 1626802 part 2: Implement HandlerProvider::IsInterfaceMaybeSupported for a11y. r=aklotz,MarcoZ
James Teh <jteh@mozilla.com> - Thu, 02 Apr 2020 04:09:20 +0000 - rev 584979
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1626802 part 2: Implement HandlerProvider::IsInterfaceMaybeSupported for a11y. r=aklotz,MarcoZ Differential Revision: https://phabricator.services.mozilla.com/D69286
36d97bd2feaacf2d7cb9740212fe103084cb5b09: Bug 1626802 part 1: mscom: Provide a way for Interceptors to avoid unnecessary cross-thread QueryInterface calls. r=aklotz
James Teh <jteh@mozilla.com> - Wed, 01 Apr 2020 23:30:21 +0000 - rev 584978
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1626802 part 1: mscom: Provide a way for Interceptors to avoid unnecessary cross-thread QueryInterface calls. r=aklotz When marshaling a11y calls from the content process, there are quite a lot of cross-thread QueryInterface calls (ipc::mscom::Interceptor::QueryInterfaceTarget). Some of these are for special COM interfaces like IAgileObject and IFastRundown, which we could just special case in Interceptor::QueryInterface like we do for INoMarshal. However, it seems there are a lot of other interfaces being queried and it's not clear why. This patch adds a new HandlerProvider method: IsInterfaceMaybeSupported. This allows implementations to indicate when there are interfaces which they definitely don't support, allowing the call to be answered without a cross-thread call. Differential Revision: https://phabricator.services.mozilla.com/D69285
34c018c96749690a3994b506f1e5113a67647acf: Bug 1595596 - Use MMAP_FAULT_HANDLER in StartupCache r=aklotz
Doug Thayer <dothayer@mozilla.com> - Fri, 27 Mar 2020 21:00:47 +0000 - rev 584403
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1595596 - Use MMAP_FAULT_HANDLER in StartupCache r=aklotz Please double check that I am using this correctly. I believe we are seeing the crash in the linked bug because we are not handling hardware faults when reading from the memory mapped file. This patch just wraps all accesses in the MMAP_FAULT_HANDLER_ macros. Depends on D53042 Differential Revision: https://phabricator.services.mozilla.com/D53043
7e5d2266b58f4f8b031121874915cbb3d3693a06: Bug 1624724 - Fix startup crash tracking in GeckoView. r=geckoview-reviewers,aklotz,snorp
Brendan Dahl <brendan.dahl@gmail.com> - Fri, 27 Mar 2020 18:16:36 +0000 - rev 584384
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1624724 - Fix startup crash tracking in GeckoView. r=geckoview-reviewers,aklotz,snorp Gecko uses a canary file to determine if the last startup was succesful or not and subsequently uses that status to determine if the startup cache should be used. The file should be deleted either on a clean exit or after the browser has succesfully started after a delay. On android there will never be a clean exit and file was not manually being deleted after startup. To fix this, delete the file after all the idle startup tasks finish. Differential Revision: https://phabricator.services.mozilla.com/D68451
777d941a0f0e748baff20cd44748f0540b550297: Bug 1598068 - Increase Android targetSdk to 29 r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Thu, 26 Mar 2020 23:28:47 +0000 - rev 584018
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1598068 - Increase Android targetSdk to 29 r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D61013
de94a3c40ad2e87d947aff7ef836f7f8ea444492: Bug 1620453: Force Windows plugin wmode to be direct, opaque or transparent r=aklotz
David Parks <daparks@mozilla.com> - Thu, 19 Mar 2020 21:08:45 +0000 - rev 583881
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1620453: Force Windows plugin wmode to be direct, opaque or transparent r=aklotz This code always intended to force wmode to be one of these modes (bug 1340276) but was not robust to unexpected wmode values (e.g. "default"). Unexpected values are now promoted to "direct". Differential Revision: https://phabricator.services.mozilla.com/D66477
2b63cf3ee0092c976a0c5bb90ca48f264aabfd5d: Bug 1615139 - Remove RestoreImportDirectory from SandboxBroker::LaunchApp. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 19 Mar 2020 23:15:27 +0000 - rev 582990
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1615139 - Remove RestoreImportDirectory from SandboxBroker::LaunchApp. r=aklotz When the launcher process is enabled, we run `RestoreImportDirectory` twice as below. This patch removes the 1st one. 1st call: xul!mozilla::SandboxBroker::LaunchApp --> xul!mozilla::RestoreImportDirectory 2nd call: xul!mozilla::SandboxBroker::LaunchApp --> firefox!mozilla::InitializeDllBlocklistOOP --> firefox!mozilla::InitializeDllBlocklistOOPInternal --> firefox!mozilla::RestoreImportDirectory To handle the case where the launcher process is disabled, we need to call `RestoreImportDirectory` from `InitializeDllBlocklistOOP` if the browser process is not bootstrapped. Differential Revision: https://phabricator.services.mozilla.com/D62853
73614f918c31a9e28f857f59a3fe025d14cd8778: Bug 1577217 - Enable the third-party-modules ping in Release build. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 19 Mar 2020 22:23:58 +0000 - rev 582980
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1577217 - Enable the third-party-modules ping in Release build. r=aklotz No significant issues has been reported since we enabled the ping in early beta of 73. It's time to enable it in all versions including Release build. Differential Revision: https://phabricator.services.mozilla.com/D67023
1e174ff5c656af1aeb1d069e1fc6aa61271c2c97: Bug 1621804 - Block the latest release of OpenSC which crashes Firefox nightly r=aklotz
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 19 Mar 2020 22:36:51 +0000 - rev 582979
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1621804 - Block the latest release of OpenSC which crashes Firefox nightly r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D67529
ab2014f6c4afdee652ecd3a4d0274bab644e3b8f: Bug 1605478 - Skip processing a loading event of xul.dll without duration. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 12 Mar 2020 17:43:41 +0000 - rev 582231
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1605478 - Skip processing a loading event of xul.dll without duration. r=aklotz Analyzing the diagnostics asserts that were temporarily introduced, there were loading events of xul.dll where `mLoadDurationMS` was empty. We put them into the array of loading events but excluding them from the array of modules, resulting in serialization failure of `UntrustedModulesData`. The crashing processes loaded external modules of antivirus application, such as Symantec, AVAST, or Comodo. With these modules, xul.dll might be loaded without hitting `ntdll!LdrLoadDll` (`ModuleLoadInf::IsBare()` == false). The proposed fix is to skip processing a loading event of xul.dll regardless of the state of `mLoadDurationMS`. Differential Revision: https://phabricator.services.mozilla.com/D66110
fe284afeeb48cb581085cbddcff393ea19927592: Bug 1619778 - Wait for Gecko to be ready when delivering Web Push events r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Fri, 13 Mar 2020 20:08:26 +0000 - rev 581964
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1619778 - Wait for Gecko to be ready when delivering Web Push events r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D66586
f0bca273ad0e0bd59361105aa6f59e9f74308112: Bug 1619778 - Add `GeckoThread#waitForState()`. r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Fri, 13 Mar 2020 19:49:48 +0000 - rev 581963
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1619778 - Add `GeckoThread#waitForState()`. r=geckoview-reviewers,aklotz This allows us to asynchronously wait for a given `GeckoThread` state to be reached. Differential Revision: https://phabricator.services.mozilla.com/D66585
6b51291b425c28a06f9e48e5d6c449a3f2bde444: Bug 1619778 - Remove unused `GeckoThread#waitOnGecko` methods. r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Thu, 12 Mar 2020 15:33:57 +0000 - rev 581962
Push 12945 by ffxbld-merge at Mon, 06 Apr 2020 13:49:11 +0000
Bug 1619778 - Remove unused `GeckoThread#waitOnGecko` methods. r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D66584