searching for reviewer(adw)
0b6cb70fd50350497730beb217c8fa19a598f280: Bug 1647925 - Make EventBufferer more reliable with tab-to-search. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Fri, 16 Oct 2020 07:29:38 +0000 - rev 619044
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1647925 - Make EventBufferer more reliable with tab-to-search. r=adw Differential Revision: https://phabricator.services.mozilla.com/D92818
e9bece1d136024763f7e71dc456d2e57753f9fec: Bug 1665934 - Part 3 - Add tab-to-search onboarding telemetry. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 16:29:13 +0000 - rev 618997
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 3 - Add tab-to-search onboarding telemetry. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93113
0cd1d314471b965c2c5ba0b5cee701949d08d2c6: Bug 1665934 - Part 2 - Add onboarding intervention for tab-to-search. r=fluent-reviewers,adw,flod
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 16:31:00 +0000 - rev 618995
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 2 - Add onboarding intervention for tab-to-search. r=fluent-reviewers,adw,flod There are a couple of issues that still need to be resolved, but I think this is ready for review: - This patch does not use the icon in the UX spec. I'm waiting on that icon and just using the engine icon in the meantime. - We also don't have a spec for how the result should wrap at narrow window widths, so I put some placeholder behaviour in. - It appears dynamic results are incapable of overriding the CSS for normal Urlbar classes unless !important is used, regardless of specificity. Thus a few rules in dynamic-tabToSearch.css use !important, which isn't ideal. It appears this is because dynamic result stylesheets are [loaded](https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/browser/components/urlbar/UrlbarView.jsm#1783,1785,1802) as `AGENT_SHEET`s. Changing that value to AUTHOR_SHEET allows the dynamic result CSS to override the normal Urlbar classes without !important. This strikes me as a tough issue. dynamic-tabToSearch.css is an agent sheet since it's provided by the browser. I do wonder if its defensible to load it as an author sheet since it will usually be loaded by an extension/external developer (this might be a stretch :). I'm not well-versed enough in the technicalities here to really make a call, so I'm eager to hear if @dao or @adw have any thoughts on how to resolve this issue. Differential Revision: https://phabricator.services.mozilla.com/D93015
b256f36594dbb3e785b64fdeeeb7bca15fb63f22: Bug 1665934 - Part 1.5 - Split _addDynamicStylesheet and _removeDynamicStylesheet out from UrlbarView into the file body. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 12:30:39 +0000 - rev 618994
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 1.5 - Split _addDynamicStylesheet and _removeDynamicStylesheet out from UrlbarView into the file body. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93583
c297c729eaa251b1c61616e3b8c71ac5b9a36df9: Bug 1665934 - Part 1 - Allow results to set their own resultSpan. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 12:30:41 +0000 - rev 618993
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 1 - Allow results to set their own resultSpan. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93112
342354dfd59466ca1ce5ab74f4c9d03674788948: Bug 1665934 - Part 3 - Add tab-to-search onboarding telemetry. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 11:19:17 +0000 - rev 618931
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 3 - Add tab-to-search onboarding telemetry. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93113
56946d59bf0a75086cc432ddf130794101e7998b: Bug 1665934 - Part 2 - Add onboarding intervention for tab-to-search. r=fluent-reviewers,adw,flod
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 11:18:53 +0000 - rev 618930
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 2 - Add onboarding intervention for tab-to-search. r=fluent-reviewers,adw,flod There are a couple of issues that still need to be resolved, but I think this is ready for review: - This patch does not use the icon in the UX spec. I'm waiting on that icon and just using the engine icon in the meantime. - We also don't have a spec for how the result should wrap at narrow window widths, so I put some placeholder behaviour in. - It appears dynamic results are incapable of overriding the CSS for normal Urlbar classes unless !important is used, regardless of specificity. Thus a few rules in dynamic-tabToSearch.css use !important, which isn't ideal. It appears this is because dynamic result stylesheets are [loaded](https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/browser/components/urlbar/UrlbarView.jsm#1783,1785,1802) as `AGENT_SHEET`s. Changing that value to AUTHOR_SHEET allows the dynamic result CSS to override the normal Urlbar classes without !important. This strikes me as a tough issue. dynamic-tabToSearch.css is an agent sheet since it's provided by the browser. I do wonder if its defensible to load it as an author sheet since it will usually be loaded by an extension/external developer (this might be a stretch :). I'm not well-versed enough in the technicalities here to really make a call, so I'm eager to hear if @dao or @adw have any thoughts on how to resolve this issue. Differential Revision: https://phabricator.services.mozilla.com/D93015
1b03418a14f64a179d79befa071fa78a45889cea: Bug 1665934 - Part 1.5 - Split _addDynamicStylesheet and _removeDynamicStylesheet out from UrlbarView into the file body. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 11:18:23 +0000 - rev 618929
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 1.5 - Split _addDynamicStylesheet and _removeDynamicStylesheet out from UrlbarView into the file body. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93583
8c1edb639aa6124cebc71c96b9151f879ed1c691: Bug 1665934 - Part 1 - Allow results to set their own resultSpan. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 11:18:12 +0000 - rev 618928
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665934 - Part 1 - Allow results to set their own resultSpan. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93112
159d9266d98eac844f9ac06f01857bda23358591: Bug 1667931 - Add a urlbar test searching a single word with a default POST engine. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Wed, 14 Oct 2020 19:59:26 +0000 - rev 618914
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667931 - Add a urlbar test searching a single word with a default POST engine. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93538
8e41ebb110cfce3f06b5272fb2506198084d66ed: Bug 1671218 - Enable update2 prefs on Release. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 15 Oct 2020 01:08:26 +0000 - rev 618890
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1671218 - Enable update2 prefs on Release. r=adw Differential Revision: https://phabricator.services.mozilla.com/D93586
b684585c33b677e893b73b617249f0028d4b14bd: Bug 1661882 - Remove getAutofillSearchString test helper. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 02 Oct 2020 07:00:34 +0000 - rev 617035
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1661882 - Remove getAutofillSearchString test helper. r=adw Differential Revision: https://phabricator.services.mozilla.com/D91971
c25899d7b631470b983650ee254177381a62eaad: Bug 1667470 - Enable tab-to-search on Nightly. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 02 Oct 2020 07:01:46 +0000 - rev 617034
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1667470 - Enable tab-to-search on Nightly. r=adw Tests are passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2de70d799eb0d0f4a5ae3d2c0b76c96bc7a34bbd Differential Revision: https://phabricator.services.mozilla.com/D92156
aa9339a3e611780577eb793be0c81c436740e99d: Bug 1647927 - Return an array from UrlbarSearchUtils.enginesForDomainPrefix and support UrlbarProviderTabToSearch sending multiple results. r=adw
Harry Twyford <htwyford@mozilla.com> - Wed, 30 Sep 2020 17:58:21 +0000 - rev 616799
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1647927 - Return an array from UrlbarSearchUtils.enginesForDomainPrefix and support UrlbarProviderTabToSearch sending multiple results. r=adw Differential Revision: https://phabricator.services.mozilla.com/D91959
00e795e5aeb16945e822e0e8dc33974326d3c014: Bug 1668340 - Fix browser_tabKeyBehavior.js on Beta. r=adw
Harry Twyford <htwyford@mozilla.com> - Wed, 30 Sep 2020 17:53:47 +0000 - rev 616737
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1668340 - Fix browser_tabKeyBehavior.js on Beta. r=adw Differential Revision: https://phabricator.services.mozilla.com/D91968
286c876f4fa4eaf79716ecceebdc73371f05305d: Bug 1647923 - Add tab-to-search telemetry. r=adw
Harry Twyford <htwyford@mozilla.com> - Tue, 29 Sep 2020 21:21:44 +0000 - rev 616630
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1647923 - Add tab-to-search telemetry. r=adw This adds tab-to-search telemetry, both for the new tabtosearch search mode entry point and for tabtosearch results in our usual Urlbar result-selection scalars. I also added a subtest in browser_urlbar_event_telemetry, but realized as I was writing it that it was not useful. We don't consider entering search more as the end of an engagement, so tab-to-search results will not appear in event telemetry. We already considered this in bug 1654680 and resolved it by adding detailed urlbar.searchmode.* scalars, so I don't consider it a blocker. I left the new subtest in since it was mostly done anyways and it can't hurt. Differential Revision: https://phabricator.services.mozilla.com/D91469
c6f68f0740eb898710ff16d95804c5f58d8c7bba: Bug 1647923 - Add UrlbarProviderTabToSearch. r=adw,fluent-reviewers
Harry Twyford <htwyford@mozilla.com> - Wed, 30 Sep 2020 00:22:03 +0000 - rev 616629
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1647923 - Add UrlbarProviderTabToSearch. r=adw,fluent-reviewers This patch adds tab-to-search results, partially reusing the existing code in `UrlbarProviderAutofill._matchSearchEngineDomain`. Tests are included. Telemetry is included in a child revision. This patch doesn't add the "Search <engine name> directly from the address bar." action text. Our current action text code l10n is in a .properties file and I thought adding branching translation logic in UrlbarView would be a mess. I think Marco might be converting that .properties file to Fluent in bug 1658629. If he is, I'll rebase my patch on his and add the new action text it in this patch. If he isn't, I'll file a follow-up for converting that .properties file and adding the tab-to-search action text, which we can address before preffing `update2.tabToComplete` on. Either way, I think this is ready for a first-round review. This patch is based on D91076 and D91077. It doesn't have any functional dependency, but there are some conflicts, especially in the added telemetry. Differential Revision: https://phabricator.services.mozilla.com/D91468
680a99a50a1e85ca3018d7b6bbeeb351eb3bbbe7: Bug 1666927 - Allow tabbing past keywordoffer results with update2 enabled. r=adw
Harry Twyford <htwyford@mozilla.com> - Tue, 29 Sep 2020 03:52:56 +0000 - rev 616544
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1666927 - Allow tabbing past keywordoffer results with update2 enabled. r=adw Differential Revision: https://phabricator.services.mozilla.com/D91295
f91203c07d8e2155200b7b5c5c2ad9ba540a321e: Bug 1658629 - Update heuristic action when cycling through local one-offs with a search string. r=adw,fluent-reviewers,flod
Marco Bonardo <mbonardo@mozilla.com> - Tue, 29 Sep 2020 10:07:08 +0000 - rev 616494
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1658629 - Update heuristic action when cycling through local one-offs with a search string. r=adw,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D91574
8c767027d7cfc368b0a07d0ca42fd5586a5343a8: Bug 1657414 - Support search mode in the Touch Bar. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 25 Sep 2020 20:45:48 +0000 - rev 616253
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1657414 - Support search mode in the Touch Bar. r=adw Differential Revision: https://phabricator.services.mozilla.com/D91077
37c38c09d3dd2bd0f9b695fe5f3e9789f34a8e56: Bug 1665076 - Call setSearchMode directly from search(), fix search mode handoff, and introduce new search mode probes. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 25 Sep 2020 20:45:33 +0000 - rev 616252
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1665076 - Call setSearchMode directly from search(), fix search mode handoff, and introduce new search mode probes. r=adw This patch calls setSearchMode directly from search(). This sets up a solution for the problem in the bug and also fixes the issue where a call to search() with a restriction token would flicker the token before it was replaced with the search mode indicator. I added new tabmenu and bookmarkmenu entry points to take advantage of this new functionality. This also fixes the issues with handoff. Besides the problem of search() recording typed for handoff, `handoff` wasn't even registered as a Telemetry probe! That was my mistake. I added a test for handoff telemetry. It was only practical to test it in PBM since it uses a different implementation than about:home that's easier to test. I wrote a lengthy comment above the subtest about why I think this is okay. Differential Revision: https://phabricator.services.mozilla.com/D91076
35a5c311e239acb96568408806cc206dbea96c77: Bug 1664760 - Improve the set of results when in search mode for a non-general search engine. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Wed, 23 Sep 2020 08:26:06 +0000 - rev 615562
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 1664760 - Improve the set of results when in search mode for a non-general search engine. r=adw - always show search suggestions first in search mode - use restyleSearches only in search mode, to get cleaner history results and dedupe against search history - filter redirects differently depending on restyleSearches Differential Revision: https://phabricator.services.mozilla.com/D90719
a4c430e03eca7137007717722b2d6ad52aa1005a: Bug 513180 - Add identical if check from key press to search-go-button press for newTabPref r=adw
tanner <tanner.drake@protonmail.com> - Tue, 22 Sep 2020 03:38:34 +0000 - rev 615355
Push 14302 by ffxbld-merge at Mon, 19 Oct 2020 16:06:48 +0000
Bug 513180 - Add identical if check from key press to search-go-button press for newTabPref r=adw Differential Revision: https://phabricator.services.mozilla.com/D90586
60314c2f5125593270ebc4e88dd2c012cffdf7dd: Bug 1665123 - Avoid early calls to setSearchMode and add a check for search service initialization. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 18 Sep 2020 18:35:08 +0000 - rev 614631
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1665123 - Avoid early calls to setSearchMode and add a check for search service initialization. r=adw Differential Revision: https://phabricator.services.mozilla.com/D90612
35e3da7b767242d5b1ab83241e180dac090296df: Bug 1664320 - Enter search mode preview when cycling through one-offs with the keyboard. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 18 Sep 2020 14:39:01 +0000 - rev 614594
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1664320 - Enter search mode preview when cycling through one-offs with the keyboard. r=adw Differential Revision: https://phabricator.services.mozilla.com/D90600
05dfedbee11d616fdd8610ee35ca9e67d66ce98a: Bug 1663686 - Convert question mark into search mode. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Thu, 17 Sep 2020 19:03:35 +0000 - rev 614501
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1663686 - Convert question mark into search mode. r=adw Differential Revision: https://phabricator.services.mozilla.com/D90357
c4d5918d66701ee43bfdbb637f3111c34aa71c32: Bug 1657676 - Add search mode preview. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 17 Sep 2020 03:31:04 +0000 - rev 614433
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657676 - Add search mode preview. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89964
b445d02b136718eca7816a246de054b0449e9f39: Bug 1657676 - Add search mode preview. r=adw
Harry Twyford <htwyford@mozilla.com> - Wed, 16 Sep 2020 23:18:59 +0000 - rev 614330
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657676 - Add search mode preview. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89964
706ab0988678e0bd435de591cc85f925e43aca91: Bug 1665036 - Enable update2 prefs in browser_searchMode_engineRemoval.js. r=adw
Harry Twyford <htwyford@mozilla.com> - Tue, 15 Sep 2020 23:26:07 +0000 - rev 614175
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1665036 - Enable update2 prefs in browser_searchMode_engineRemoval.js. r=adw Differential Revision: https://phabricator.services.mozilla.com/D90281
6e3078121a1316419c38e57fcbb8cae01cdb4b60: Bug 1657676 - Add search mode preview. r=adw
Harry Twyford <htwyford@mozilla.com> - Tue, 15 Sep 2020 22:55:12 +0000 - rev 614121
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657676 - Add search mode preview. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89964
af47bc7c002d4c84f857dc62b6d2046a891d2412: Bug 1657801 - Exit search mode if the current search mode engine is removed. r=adw
Harry Twyford <htwyford@mozilla.com> - Mon, 14 Sep 2020 20:27:10 +0000 - rev 613915
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657801 - Exit search mode if the current search mode engine is removed. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89827
079bf1a540404e9f8713da616d52f3e302392370: Bug 1662477 - Don't toggle local one-offs if urlbar privacy preferences are flipped. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Sat, 12 Sep 2020 08:46:34 +0000 - rev 613715
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1662477 - Don't toggle local one-offs if urlbar privacy preferences are flipped. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89917
fbb67f1371852dda8473561e173ab2bfa85ac2ac: Bug 1664252 - Stop breaking redirect chains when expiring visits for long urls. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Sat, 12 Sep 2020 01:02:15 +0000 - rev 613714
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1664252 - Stop breaking redirect chains when expiring visits for long urls. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89924
bd0fa775730739b8776b90041547ed55c019263b: Bug 1657212 - Support one-off key modifiers and remove one-off context menus. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 11 Sep 2020 20:07:07 +0000 - rev 613671
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1657212 - Support one-off key modifiers and remove one-off context menus. r=adw This patch adds support for key modifiers on the refreshed one-offs. They work the same as the old key modifiers, with one exception: Shift+Click and Shift+Enter both execute a search immediately in the current tab, replicating the behaviour of the old one-offs. For empty searches, Shift+Click and Shift+Enter just enter search mode. To support these Shift modifiers, we dropped support for opening a one-off search in a new window. Users can still search in a new window with a non-default engine by typing a search string, selecting a one-off with the keyboard, then Shift+Clicking the heuristic result or the Go button. Other key modifiers worth pointing out include Accel+Click to search in a new background tab and Alt+Enter to search in a new foreground tab. If these modifiers are used on the local one offs or with an empty query, we open search mode in the new tab. Differential Revision: https://phabricator.services.mozilla.com/D89504
711b8615bb3f978a68a27314719247fdde9a6aed: Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Mon, 07 Sep 2020 22:07:28 +0000 - rev 613094
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89143
ef2483cfdf64f9265139bfb7727a624c97e6a3ab: Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Fri, 04 Sep 2020 08:57:57 +0000 - rev 612969
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89143
0eacf15bc150050afeaaeee067f042ce6ac576ff: Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw
Marco Bonardo <mbonardo@mozilla.com> - Wed, 02 Sep 2020 20:33:25 +0000 - rev 612919
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw Differential Revision: https://phabricator.services.mozilla.com/D89143
83153a82d391bb73824323423b14e161bcd8cb86: Bug 1655473 - Allow autofill only in local search modes. r=adw
Harry Twyford <htwyford@mozilla.com> - Wed, 02 Sep 2020 19:23:12 +0000 - rev 612838
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1655473 - Allow autofill only in local search modes. r=adw Differential Revision: https://phabricator.services.mozilla.com/D88219
66bb2eab21ce420a8096381faeb17fa5dedbd706: Bug 1654680 - Add telemetry for search mode. r=adw
Harry Twyford <htwyford@mozilla.com> - Wed, 02 Sep 2020 15:08:50 +0000 - rev 612775
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1654680 - Add telemetry for search mode. r=adw Summary of changes: 1. Adds an `entry` property to the searchMode object to tag how search mode was entered. 2. Introduces `urlbar.searchmode.*` scalars. These scalars are suffixed with an entry point into search mode, for example `urlbar.searchmode.oneoff`, or `urlbar.searchmode.topsites_urlbar`. Those entry points tell us how search mode is entered most often. The keys for these scalars are strings describing what kind of search mode was entered. In most cases, this will be the name of a search engine, like "Google", or "DuckDuckGo". It may also be one of "history", "bookmarks", or "tabs". We only collect the names of engines that are bundled with Firefox. If the user enters search mode with an engine they installed themselves, we record "other" as the key. 3. Adds a urlbar-searchmode SAP to SEARCH_COUNTS. 4. Adds a browser.engagement.navigation.urlbar_searchmode probe. 5. Adds a urlbar_searchmode SAP to the navigation.search event. Differential Revision: https://phabricator.services.mozilla.com/D87510
64efed429f67a5f929e044fcc3f3a402101af7dd: Bug 1632318 - Left / Right Arrow key navigation in the one-off search buttons breaks convention (should move caret, not select one-off). r=adw
Marco Bonardo <mbonardo@mozilla.com> - Tue, 01 Sep 2020 13:28:00 +0000 - rev 612575
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1632318 - Left / Right Arrow key navigation in the one-off search buttons breaks convention (should move caret, not select one-off). r=adw Differential Revision: https://phabricator.services.mozilla.com/D88536
150d1ddcbfdeb70c73d976e7d5dc7a83a3129645: Bug 1660681 - Replace gURLBar.setSearchMode({}) calls in tests with exitSearchMode helper. r=adw
harry <htwyford@mozilla.com> - Sat, 29 Aug 2020 00:51:21 +0000 - rev 612210
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1660681 - Replace gURLBar.setSearchMode({}) calls in tests with exitSearchMode helper. r=adw Differential Revision: https://phabricator.services.mozilla.com/D88671
a27cf293e768189867ee80b1dc00613afa02134d: Bug 1655849 - Allow engagement events to start from click event. r=adw
Harry Twyford <htwyford@mozilla.com> - Sat, 29 Aug 2020 00:42:51 +0000 - rev 612209
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1655849 - Allow engagement events to start from click event. r=adw Solving this is as simple as adding "click" to the list of events allowed to start an engagement event. Previously, we didn't have any clicks that could start an engagement event (although we allowed `mousedown` for focusing the Urlbar). Now, we have a few click events that start something that could be considered engagement: clicking a one off and clicking the exit button on the search mode indicator. When engagementEvent.start() is called, [we bail](https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/browser/components/urlbar/UrlbarController.jsm#720) if we're currently in an engagement. I can no longer trigger the error in the bug in regular Firefox use; I assume at the time this bug was filed, it was possible to record/discard an engagement by clicking the one-offs a second time. The second click would call `engagementEvent.start()` again and the error would be throw since we discarded the previous engagement event. This no longer seems to be the case. I can trigger it from tests though. That's because this is a common pattern in our tests: ``` await UrlbarTestUtils.promiseAutocompleteResultPopup({ window, value: TEST_QUERY, }); await UrlbarTestUtils.enterSearchMode(window); ``` If we don't include `fireInputEvent: true` in our call to `promiseAutocompleteResultPopup`, the view is opened without ever starting an engagement event. Then when `enterSearchMode` clicks a one-off, we call `UrlbarInput.startQuery`, which starts an engagement event. The error follows. Adding click to the list of allowedEvents fixes this in tests and addresses any edge cases we might create in the future where the user is able to click a one-off without already being in an engagement event. Depends on D87510 Differential Revision: https://phabricator.services.mozilla.com/D88480
3a848c81a60655c298e6f2060abaef43f0e99652: Bug 1659131 - Top Site search shortcuts should enter search mode. r=adw
Harry Twyford <htwyford@mozilla.com> - Mon, 24 Aug 2020 23:21:13 +0000 - rev 611191
Push 13943 by ffxbld-merge at Mon, 21 Sep 2020 13:41:08 +0000
Bug 1659131 - Top Site search shortcuts should enter search mode. r=adw Differential Revision: https://phabricator.services.mozilla.com/D87908
780fe058bccdaeadb66ec1f0e31c91fd7765f6a7: Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw, a=RyanVM
Marco Bonardo <mbonardo@mozilla.com> - Tue, 01 Sep 2020 18:35:55 +0200 - rev 610991
Push 13888 by ryanvm@gmail.com at Thu, 10 Sep 2020 17:14:11 +0000
Bug 1661949 - Can't search from the Address Bar with ? if keyword.enabled = false. r=adw, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D89143
c57215f3634fbd7b9cc8b00bd5f8a29bdcb6a457: Bug 1660681 - Replace gURLBar.setSearchMode({}) calls in tests with exitSearchMode helper. r=adw a=test-only
harry <htwyford@mozilla.com> - Sat, 29 Aug 2020 00:51:21 +0000 - rev 610614
Push 13670 by btara@mozilla.com at Sat, 29 Aug 2020 20:08:10 +0000
Bug 1660681 - Replace gURLBar.setSearchMode({}) calls in tests with exitSearchMode helper. r=adw a=test-only Differential Revision: https://phabricator.services.mozilla.com/D88671
c089d805db488ef5c19f298d5227374ae3605f49: Bug 1660425 - Use the entire search string when autofilling in UrlbarProviderTokenAliasEngines. r=adw
Harry Twyford <htwyford@mozilla.com> - Sat, 22 Aug 2020 02:37:05 +0000 - rev 610367
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1660425 - Use the entire search string when autofilling in UrlbarProviderTokenAliasEngines. r=adw Differential Revision: https://phabricator.services.mozilla.com/D87919
2f35ed9d355fcfd0156e0bc6a1a2eda1a29528d7: Bug 1659775 - Restrict adaptive history from appearing in search mode. r=adw
Harry Twyford <htwyford@mozilla.com> - Thu, 20 Aug 2020 20:12:01 +0000 - rev 610240
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1659775 - Restrict adaptive history from appearing in search mode. r=adw Differential Revision: https://phabricator.services.mozilla.com/D87796
5254d40a3e218a564bcec311190a7b3339edaea1: Bug 1647917 - Announce search mode to screen readers. r=adw,fluent-reviewers,flod
Harry Twyford <htwyford@mozilla.com> - Fri, 14 Aug 2020 19:06:47 +0000 - rev 609374
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1647917 - Announce search mode to screen readers. r=adw,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D87082
9bfa6276ddc55be311c681960647e96317589a0d: Bug 1658646 - Show local results for search modes other than general purpose search engines. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 14 Aug 2020 03:57:15 +0000 - rev 609287
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1658646 - Show local results for search modes other than general purpose search engines. r=adw Differential Revision: https://phabricator.services.mozilla.com/D86998
e5655c6b1c5ffdd51053ef37694cdd11718832cd: Bug 1658646 - Show local results for search modes other than general purpose search engines. r=adw
Harry Twyford <htwyford@mozilla.com> - Fri, 14 Aug 2020 01:15:43 +0000 - rev 609248
Push 13553 by ffxbld-merge at Mon, 24 Aug 2020 12:51:36 +0000
Bug 1658646 - Show local results for search modes other than general purpose search engines. r=adw Differential Revision: https://phabricator.services.mozilla.com/D86998