searching for reviewer(achronop)
f79e3ad10f11e0e058bcf7245d95999dd623b87d: Bug 1583996 - Unlock CubebDeviceEnumerator mutex during call to cubeb_enumerate_devices. r=achronop
Matthew Gregan <kinetik@flim.org> - Tue, 08 Oct 2019 18:53:55 +0000 - rev 558145
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1583996 - Unlock CubebDeviceEnumerator mutex during call to cubeb_enumerate_devices. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D48475
840c4edafa021eeac6a7e6ae0e828d0adcfea92e: Bug 1581193 - Fix devicechange event on Windows; r=achronop
Dan Minor <dminor@mozilla.com> - Tue, 17 Sep 2019 06:47:06 +0000 - rev 554890
Push 12169 by ffxbld-merge at Mon, 14 Oct 2019 16:59:29 +0000
Bug 1581193 - Fix devicechange event on Windows; r=achronop This restores the code for generating devicechange events that was accidentally removed as part of updating the Windows video capture code in Bug 1552755. Differential Revision: https://phabricator.services.mozilla.com/D46033
c0bd917aeecce986301440bff852a4e7a463969f: Bug 1581193 - Fix devicechange event on Windows; r=achronop a=lizzard
Dan Minor <dminor@mozilla.com> - Tue, 17 Sep 2019 06:47:06 +0000 - rev 552038
Push 12036 by rgurzau@mozilla.com at Tue, 24 Sep 2019 21:36:29 +0000
Bug 1581193 - Fix devicechange event on Windows; r=achronop a=lizzard This restores the code for generating devicechange events that was accidentally removed as part of updating the Windows video capture code in Bug 1552755. Differential Revision: https://phabricator.services.mozilla.com/D46033
f2eb3134819666e6feac816c96d195ddc4c89c4d: Bug 1561254 - Support groupId in constraints. r=achronop,jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Tue, 30 Jul 2019 16:28:44 +0000 - rev 545886
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1561254 - Support groupId in constraints. r=achronop,jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D37692
365d1b03475e7f0ae89f26d9eaa30645b7dec4c8: Bug 1563193 - Remove "media.webaudio.audiocontextoptions-samplerate.enabled". r=achronop
Paul Adenot <paul@paul.cx> - Wed, 03 Jul 2019 12:12:15 +0000 - rev 540751
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1563193 - Remove "media.webaudio.audiocontextoptions-samplerate.enabled". r=achronop Differential Revision: https://phabricator.services.mozilla.com/D36733
c3d1fc5ebcc5032372989d442f27e61f42810f24: Bug 1561945 - P2: Update cubeb from upstream to 98a1c8e. r=achronop
Chun-Min Chang <chun.m.chang@gmail.com> - Sun, 30 Jun 2019 23:36:38 +0000 - rev 540397
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1561945 - P2: Update cubeb from upstream to 98a1c8e. r=achronop Pick commits: 98a1c8e - Enable Windows build on Travis. (#514) 02bcf9c - cubeb_sun: Fixes to support high latency playback, and illumos build fix. (#513) 9f39687 - sunaudio (NetBSD/illumos) backend (#510) 03eb237 - Fix tests warnings (#512) acbed7d - Add audiounit-rust backend (#511) 421010c - Update Travis builds: clang 3.6 -> 3.8, g++ 4.8 -> 5.x, XCode 6.4 -> 9.4. (#509) 3643750 - wasapi: return unique_ptr normally, without std::move (#443) 9ea8137 - Switch Travis builds to Ubuntu Xenial (16.04) to pick up a newer MinGW. (#508) Differential Revision: https://phabricator.services.mozilla.com/D36212
be328974461dae10ca7b8b2aaf711251255ae563: Bug 1561945 - P1: Copy sunaudio backend to cubeb. r=achronop
Chun-Min Chang <chun.m.chang@gmail.com> - Thu, 27 Jun 2019 16:59:00 +0000 - rev 540276
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1561945 - P1: Copy sunaudio backend to cubeb. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D36215
ecdebbbb2253bf877ba3b68a0e872b5ed9dbac34: Bug 1549321 - Pass AudioIPC init failure back to child rather than IPC_FAIL() killing parent. r=achronop
Matthew Gregan <kinetik@flim.org> - Fri, 07 Jun 2019 11:52:54 +0000 - rev 537483
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1549321 - Pass AudioIPC init failure back to child rather than IPC_FAIL() killing parent. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D34105
546170ac7ca95ecacf73efeef9c1f53bb4b2fefc: Bug 1550695 - Wrap cubeb_init in EnsureMTA to handle being called from threads where COM is uninitialized. r=achronop
Matthew Gregan <kinetik@flim.org> - Tue, 28 May 2019 09:53:04 +0000 - rev 535621
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1550695 - Wrap cubeb_init in EnsureMTA to handle being called from threads where COM is uninitialized. r=achronop Depends on D32654 Differential Revision: https://phabricator.services.mozilla.com/D32655
4a88deceba11c2dae458a4130e2ed9f0e7c81dd8: Bug 1550695 - Avoid duplicating cubeb_init in both arms of MOZ_CUBEB_REMOTING ifdef. r=achronop
Matthew Gregan <kinetik@flim.org> - Tue, 28 May 2019 09:43:08 +0000 - rev 535620
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1550695 - Avoid duplicating cubeb_init in both arms of MOZ_CUBEB_REMOTING ifdef. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D32654
abda154079efcd7fdc78ab5a0ba6e13fc14aa93a: Bug 1550695 - Wrap cubeb_init in EnsureMTA to handle being called from threads where COM is uninitialized. r=achronop a=jcristau
Matthew Gregan <kinetik@flim.org> - Tue, 28 May 2019 09:53:04 +0000 - rev 533511
Push 11342 by malexandru@mozilla.com at Fri, 31 May 2019 14:58:20 +0000
Bug 1550695 - Wrap cubeb_init in EnsureMTA to handle being called from threads where COM is uninitialized. r=achronop a=jcristau Depends on D32654 Differential Revision: https://phabricator.services.mozilla.com/D32655
d68ba2d3844c731135e9fbdf750e727fd8412fea: Bug 1550695 - Avoid duplicating cubeb_init in both arms of MOZ_CUBEB_REMOTING ifdef. r=achronop a=jcristau
Matthew Gregan <kinetik@flim.org> - Tue, 28 May 2019 09:43:08 +0000 - rev 533510
Push 11342 by malexandru@mozilla.com at Fri, 31 May 2019 14:58:20 +0000
Bug 1550695 - Avoid duplicating cubeb_init in both arms of MOZ_CUBEB_REMOTING ifdef. r=achronop a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32654
19907c1f0f10b740510ae828b6db2d1891e9d7a8: Bug 1549699 - Don't use communication devices by default on Windows. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 07 May 2019 15:19:32 +0000 - rev 531725
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1549699 - Don't use communication devices by default on Windows. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D30205
5967ffe89473dc2cc5ecdd516a83a126b8b57755: Bug 1543419 - Fix libdav1d moz.yaml quoting. r=achronop
Thomas Daede <tdaede@mozilla.com> - Wed, 10 Apr 2019 15:59:00 +0000 - rev 527608
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1543419 - Fix libdav1d moz.yaml quoting. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D26927
4f6d8ed9e94809f911907725a708627e3faaed01: Bug 1533559 - Update libdav1d to 0.2.1. r=achronop
Thomas Daede <tdaede@mozilla.com> - Tue, 19 Mar 2019 17:35:09 +0000 - rev 523881
Push 11265 by ffxbld-merge at Mon, 13 May 2019 10:53:39 +0000
Bug 1533559 - Update libdav1d to 0.2.1. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D23761
a21454f433a1c9dfd88e75db4a3ea08fe8f2c560: Bug 1521577 - Don't block a MediaStream where at least one track is pulled. r=achronop
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 28 Jan 2019 07:26:03 +0000 - rev 513469
Push 10862 by ffxbld-merge at Mon, 11 Mar 2019 13:01:11 +0000
Bug 1521577 - Don't block a MediaStream where at least one track is pulled. r=achronop With the per-track pulling settings we have today it is clearly the intention of the producer to start consuming a track that has pulling enabled, even if there are other tracks where pulling is disabled. This patch fixes that, so that when a stream has at least one pulled track it will append null data to other tracks (commonly video) if they are lacking data. This means that we still block an entire stream if all tracks have pulling disabled - to maintain the status quo for media element capture, which is the only push-only producer of data. Differential Revision: https://phabricator.services.mozilla.com/D17611
a7206b7354fbdfba4c7f5b0d6f3909bee7f1ab36: Bug 1521577 - Don't block a MediaStream where at least one track is pulled. r=achronop a=lizzard
Andreas Pehrson <pehrsons@mozilla.com> - Mon, 28 Jan 2019 07:26:03 +0000 - rev 512758
Push 10587 by archaeopteryx@coole-files.de at Thu, 31 Jan 2019 10:03:18 +0000
Bug 1521577 - Don't block a MediaStream where at least one track is pulled. r=achronop a=lizzard With the per-track pulling settings we have today it is clearly the intention of the producer to start consuming a track that has pulling enabled, even if there are other tracks where pulling is disabled. This patch fixes that, so that when a stream has at least one pulled track it will append null data to other tracks (commonly video) if they are lacking data. This means that we still block an entire stream if all tracks have pulling disabled - to maintain the status quo for media element capture, which is the only push-only producer of data. Differential Revision: https://phabricator.services.mozilla.com/D17611
2f4288c49610e004e668f6065a54ca591ac7d215: Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop
Paul Adenot <paul@paul.cx> - Mon, 14 Jan 2019 15:09:34 +0000 - rev 510851
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D16201
0f68913927a57f85b9d575541f7c1aff77e27d00: Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop
Paul Adenot <paul@paul.cx> - Fri, 11 Jan 2019 17:22:24 +0000 - rev 510614
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D16201
b0471cb7631f638fddf2776a50eeb641ac04e5f1: Bug 1450762 - Don't prompt for device permissions on Android in MediaDevices.enumerateDevices() r=achronop
James Willcox <snorp@snorp.net> - Wed, 02 Jan 2019 16:44:35 +0000 - rev 509388
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1450762 - Don't prompt for device permissions on Android in MediaDevices.enumerateDevices() r=achronop Differential Revision: https://phabricator.services.mozilla.com/D14575
0e9a610fe05f5e830d4cc387b6d293e94347e3c7: Bug 1450762 - Don't prompt for device permissions on Android in MediaDevices.enumerateDevices() r=achronop
James Willcox <snorp@snorp.net> - Wed, 26 Dec 2018 19:33:13 +0000 - rev 509052
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1450762 - Don't prompt for device permissions on Android in MediaDevices.enumerateDevices() r=achronop Differential Revision: https://phabricator.services.mozilla.com/D14575
995a65365aa1b925ba740380e055cda335689e85: Bug 1512280 - Fix some nits and shorten MediaManager::GetUserMedia(). r=achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 12 Dec 2018 20:42:01 +0000 - rev 507429
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512280 - Fix some nits and shorten MediaManager::GetUserMedia(). r=achronop Differential Revision: https://phabricator.services.mozilla.com/D13858
616721cad8938767508b3dc34e0a98f53c47d600: Bug 1512280 - Fix some nits and shorten MediaManager::GetUserMedia(). r=achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 12 Dec 2018 02:23:57 +0000 - rev 507312
Push 10547 by ffxbld-merge at Mon, 21 Jan 2019 13:03:58 +0000
Bug 1512280 - Fix some nits and shorten MediaManager::GetUserMedia(). r=achronop Differential Revision: https://phabricator.services.mozilla.com/D13858
8d48fc5df52513e5d144f1334bad6f188c333916: Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop, a=abillings
Paul Adenot <paul@paul.cx> - Mon, 14 Jan 2019 15:09:34 +0000 - rev 506715
Push 10526 by ryanvm@gmail.com at Tue, 15 Jan 2019 21:05:27 +0000
Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop, a=abillings Differential Revision: https://phabricator.services.mozilla.com/D16201
8a78c4c56019d4891f24998613f80de5f894f340: Bug 1492479 - Simplify MediaDeviceSetRefCnt by removing one redundant pointer indirection. r=achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 30 Nov 2018 05:15:34 +0000 - rev 505358
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1492479 - Simplify MediaDeviceSetRefCnt by removing one redundant pointer indirection. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D11842
a616c269bbccf381c45e6909417819103179a67a: Bug 1475209 - Have MediaManager::EnumerateDevices() return a promise. r=achronop,jya
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 30 Nov 2018 05:14:05 +0000 - rev 505355
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1475209 - Have MediaManager::EnumerateDevices() return a promise. r=achronop,jya Differential Revision: https://phabricator.services.mozilla.com/D8009
46c936ce7efed56027d7770690f94ee31f415d7a: Bug 1492479 - Have MediaManager::GetUserMedia() return a promise. r=achronop,jya
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 30 Nov 2018 05:13:58 +0000 - rev 505354
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1492479 - Have MediaManager::GetUserMedia() return a promise. r=achronop,jya Differential Revision: https://phabricator.services.mozilla.com/D8008
daffe63f1a1f313446c7f4c29e24de04f4ed1062: Bug 1503756 - Change name of media device; r=achronop
Gregory Szorc <gps@mozilla.com> - Wed, 14 Nov 2018 20:02:57 +0000 - rev 502867
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1503756 - Change name of media device; r=achronop Regenerating the ubuntu1604-test Docker image pulls in a new package version that changes the name of a media device. This media device name is currently hard coded in the mochitest test harness. This commit makes a change to force regeneration of the Docker image and updates the hardcoded device name to reflect the new version. Differential Revision: https://phabricator.services.mozilla.com/D11927
ca744888101ed29447b95c6fa30ae1ff8d207e51: Bug 1499871 - Update test metadata for wpt audio-output on fennec r=achronop
Wes Kocher <wkocher@mozilla.com> - Thu, 25 Oct 2018 07:54:21 +0000 - rev 499375
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499871 - Update test metadata for wpt audio-output on fennec r=achronop Differential Revision: https://phabricator.services.mozilla.com/D9723
121ccc3d4437ee3a44aa29d4c94feb17073f815c: Bug 1499871 - Fix spelling of "NotAllowedError" r=achronop
Wes Kocher <wkocher@mozilla.com> - Wed, 24 Oct 2018 17:21:13 +0000 - rev 499244
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1499871 - Fix spelling of "NotAllowedError" r=achronop Differential Revision: https://phabricator.services.mozilla.com/D9615
22f5c9171d258adadc703aca664bbca476fa441a: Bug 1497751 update driver state before handing control to another thread r=achronop
Karl Tomlinson <karlt+@karlt.net> - Sat, 13 Oct 2018 12:45:18 +1300 - rev 496836
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497751 update driver state before handing control to another thread r=achronop Differential Revision: https://phabricator.services.mozilla.com/D8180
8aa6552b8f99bfd3358ae3306625461e6f4678e5: Bug 1498237 - switch test_fingerprints.html to use video instead of audio. r=achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 12 Oct 2018 18:06:29 +0000 - rev 496655
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1498237 - switch test_fingerprints.html to use video instead of audio. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D8583
f2d7836b93f9ad88ef27388df27be1e6510bcdb8: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop a=reland
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 12 Oct 2018 20:25:07 +0300 - rev 496609
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop a=reland Differential Revision: https://phabricator.services.mozilla.com/D8053
419218259bc1a6f5f1cd527225f1f200fbf55126: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 11 Oct 2018 02:02:32 +0000 - rev 496403
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop Differential Revision: https://phabricator.services.mozilla.com/D8053
493e812d03421d640f1111e57373d6c4d777f789: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 10 Oct 2018 07:51:09 +0000 - rev 496268
Push 9984 by ffxbld-merge at Mon, 15 Oct 2018 21:07:35 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop Differential Revision: https://phabricator.services.mozilla.com/D8053
b118b720b2c7c94b634c86350b83014c2840e7bf: Bug 1480856 - Allow for another 10ms of silence when processing audio input. r=achronop
Andreas Pehrson <apehrson@mozilla.com> - Tue, 07 Aug 2018 21:02:41 +0000 - rev 485534
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1480856 - Allow for another 10ms of silence when processing audio input. r=achronop Differential Revision: https://phabricator.services.mozilla.com/D2786
acbf4a97ecca6ff4a0b5f2c08115f91523e41461: Bug 1404977 - Exit NotifyInputData early if there's no input listener. r=achronop
Andreas Pehrson <apehrson@mozilla.com> - Fri, 03 Aug 2018 14:14:36 +0200 - rev 485175
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1404977 - Exit NotifyInputData early if there's no input listener. r=achronop MozReview-Commit-ID: KMy01D2VjLi
c6bc352b5e6240004c40db86d7ddec1671a5aa99: Bug 1480161: Fix underrun assert for processed input stream. r=achronop
Andreas Pehrson <apehrson@mozilla.com> - Thu, 02 Aug 2018 10:25:05 +0000 - rev 484882
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1480161: Fix underrun assert for processed input stream. r=achronop The logic here intends to (as is written in the comment) append one block of silence to the track to allow for us to underrun one full scratch buffer. The code doesn't match this behavior however, because if we are not underrunning by less than a block, we end up appending *less* than a block. This causes us to append at a later time as the scratch buffer can swallow more (up to a full block) than we appended. Without processing this seems to work because of timing and ordering, but with processing (aec/agc/ns) we tend to add 71 (512 for an iteration - 441 packed) samples of silence, leaving us to hit the assert with a 44% ((128-71)/128) chance during subsequent iterations. Differential Revision: https://phabricator.services.mozilla.com/D2644
d8d3fca29016566df5d798d0709f51a4036f40c7: Bug 1475431 - r=achronop a=lizzard
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 24 Jul 2018 15:37:01 +0300 - rev 478091
Push 9527 by archaeopteryx@coole-files.de at Tue, 24 Jul 2018 12:44:30 +0000
Bug 1475431 - r=achronop a=lizzard
8671df890e45454e6ddaefe0dc41b005f24fa128: Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:16:24 +0200 - rev 475128
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop MozReview-Commit-ID: DrnadeBS8hi
4ac439f97956a46b322b85423c516d2eb6f17b2c: Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:15:29 +0200 - rev 475127
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop We initialize the channelCountMode and channelInterpretation (that cannot be changed) appropriately in the C++ ctor, and the channelCount manually as well. Then we check manually that the options for the channelCountMode, the channelCount and channelInterpretation have not been passed, or are not incorrect. MozReview-Commit-ID: 4YdYfaGqKqn
190899b047d2eca97616b7c2cacdc59b8f7ffce8: Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 17:18:39 +0200 - rev 475126
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop MozReview-Commit-ID: 5pAdWn9zV9e
9af1ffb437be63b6956970b47eebc78e6e2310af: Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:16:24 +0200 - rev 475019
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop MozReview-Commit-ID: DrnadeBS8hi
9a085b0513f78344b07724c049860b089c313894: Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:15:29 +0200 - rev 475018
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop We initialize the channelCountMode and channelInterpretation (that cannot be changed) appropriately in the C++ ctor, and the channelCount manually as well. Then we check manually that the options for the channelCountMode, the channelCount and channelInterpretation have not been passed, or are not incorrect. MozReview-Commit-ID: 4YdYfaGqKqn
ebfc3c04016ab0cce5489973e63cdb6dfdee191c: Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 17:18:39 +0200 - rev 475017
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop MozReview-Commit-ID: 5pAdWn9zV9e
91a4b9b7cfa8444e760a99ae4518e678e1cc14ef: Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:16:24 +0200 - rev 474750
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Properly reflect the channelCount when set in the ctor using the option object, on a ChannelSplitterNode. r=achronop MozReview-Commit-ID: DrnadeBS8hi
852233de6408712da07a2f09721c7e35d67d608f: Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 18:15:29 +0200 - rev 474749
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456946 - Don't call AudioNode::Initialize on an ChannelSplitterNode during construction to avoid throwing. r=achronop We initialize the channelCountMode and channelInterpretation (that cannot be changed) appropriately in the C++ ctor, and the channelCount manually as well. Then we check manually that the options for the channelCountMode, the channelCount and channelInterpretation have not been passed, or are not incorrect. MozReview-Commit-ID: 4YdYfaGqKqn
0ae2e92fead51b853ed02ccfdab31a96c505f5a8: Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 17:18:39 +0200 - rev 474748
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop MozReview-Commit-ID: 5pAdWn9zV9e
9e1a3230d085fb9c158a08b25227178f42ec823f: Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 17:18:39 +0200 - rev 474443
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1456265 - Make ChannelSplitterNode have a channelCountMode of "explicit" and a channelIntepretation of "discrete" by default. r=achronop MozReview-Commit-ID: 5pAdWn9zV9e
4894b2dded631ed8d175fca75add23a4cc84ade9: Bug 1453648 - Remove special handling for Sine source at 440 Hz test device. r=achronop
Bryce Van Dyk <bvandyk@mozilla.com> - Wed, 11 Apr 2018 17:12:28 -0400 - rev 466554
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1453648 - Remove special handling for Sine source at 440 Hz test device. r=achronop MozReview-Commit-ID: foVINjjMOX