searching for reviewer(abillings)
f764410a3326: Bug 1543159 - TypeHashSet should use a non-reserved bit for marking elements to be moved. r=jandem a=abillings
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Tue, 16 Apr 2019 18:45:45 +0000 - rev 523233
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1543159 - TypeHashSet should use a non-reserved bit for marking elements to be moved. r=jandem a=abillings Differential Revision: https://phabricator.services.mozilla.com/D26961
cf8b04d3bfcd: Bug 1534593 part 3. Initialize JSObject* entries in Record types. r=qdot a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 16 Apr 2019 19:18:52 +0000 - rev 523232
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1534593 part 3. Initialize JSObject* entries in Record types. r=qdot a=abillings Differential Revision: https://phabricator.services.mozilla.com/D27562
499c3102dc05: Bug 1534593 part 2. Factor out the "determine the default initializer" code from dictionary member init and reuse it for sequence member init. r=qdot a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 16 Apr 2019 19:18:09 +0000 - rev 523231
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1534593 part 2. Factor out the "determine the default initializer" code from dictionary member init and reuse it for sequence member init. r=qdot a=abillings The other option would be to implement nsTArrayElementTraits for JSObject* and null-initialize there. Differential Revision: https://phabricator.services.mozilla.com/D27561
ef03afcf3cff: Bug 1534593 part 1. Stop special-casing JS::Value initialization, since JS::Value now always initializes itself on construction. r=qdot,waldo a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 15 Apr 2019 15:26:49 -0400 - rev 523230
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1534593 part 1. Stop special-casing JS::Value initialization, since JS::Value now always initializes itself on construction. r=qdot,waldo a=abillings
7a0993f0f4fb: Bug 1538619 - TransactionDatabaseOperationBase::SendFailureResult not called if the actor has been destroyed; r=asuth a=abillings
Jan Varga <jan.varga@gmail.com> - Mon, 25 Mar 2019 19:11:01 +0100 - rev 523221
Push 11107 by archaeopteryx@coole-files.de at Thu, 18 Apr 2019 15:56:49 +0000
Bug 1538619 - TransactionDatabaseOperationBase::SendFailureResult not called if the actor has been destroyed; r=asuth a=abillings Differential Revision: https://phabricator.services.mozilla.com/D24744
828f8931afe0: Bug 1538042 Part 1: Change nsIFind::Find to have access to text length. r=mccr8 a=abillings
Brad Werth <bwerth@mozilla.com> - Fri, 29 Mar 2019 15:55:57 +0000 - rev 523105
Push 11057 by archaeopteryx@coole-files.de at Wed, 10 Apr 2019 14:56:16 +0000
Bug 1538042 Part 1: Change nsIFind::Find to have access to text length. r=mccr8 a=abillings Differential Revision: https://phabricator.services.mozilla.com/D25005
8d7186b2f9a6: Bug 1530958 - Disable unboxed objects by default r=jandem a=abillings
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 11 Feb 2019 11:55:20 +0000 - rev 513417
Push 10839 by archaeopteryx@coole-files.de at Thu, 07 Mar 2019 09:52:32 +0000
Bug 1530958 - Disable unboxed objects by default r=jandem a=abillings (This patch is a rollup of the folloiwing two:) Bug 1525579 - Add pref for unboxed objects r=jandem Differential Revision: https://phabricator.services.mozilla.com/D18870 *** Bug 1526451 - Disable unboxed objects by default r=jandem,tcampbell Differential Revision: https://phabricator.services.mozilla.com/D19197
4c7d56a0a897: Bug 1529203 - Add release build assertions around using modules with the wrong global r=jandem a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Sat, 02 Mar 2019 09:04:06 +0000 - rev 513353
Push 10812 by jcoppeard@mozilla.com at Sat, 02 Mar 2019 09:04:31 +0000
Bug 1529203 - Add release build assertions around using modules with the wrong global r=jandem a=abillings
0f09554ca8cb: Bug 1529203 - Clear the module map when changing a Document's global r=bzbarsky a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 01 Mar 2019 16:53:47 +0000 - rev 513352
Push 10812 by jcoppeard@mozilla.com at Sat, 02 Mar 2019 09:04:31 +0000
Bug 1529203 - Clear the module map when changing a Document's global r=bzbarsky a=abillings Differential Revision: https://phabricator.services.mozilla.com/D21718
89ac71e3fa34: Bug 1524208: Compare result of BaseInputPin::Receive to S_OK. r=pehrsons, a=abillings
Dan Minor <dminor@mozilla.com> - Wed, 13 Feb 2019 06:33:27 -0800 - rev 513184
Push 10745 by ryanvm@gmail.com at Thu, 21 Feb 2019 14:14:16 +0000
Bug 1524208: Compare result of BaseInputPin::Receive to S_OK. r=pehrsons, a=abillings Differential Revision: https://phabricator.services.mozilla.com/D19675
820b728e1ebe: Bug 1516425 - Avoid unnecessarily attaching layers during shutdown of TabParent. r=aosmond, a=abillings
Ryan Hunt <rhunt@eqrion.net> - Fri, 11 Jan 2019 13:24:57 -0600 - rev 513183
Push 10745 by ryanvm@gmail.com at Thu, 21 Feb 2019 14:14:16 +0000
Bug 1516425 - Avoid unnecessarily attaching layers during shutdown of TabParent. r=aosmond, a=abillings
c5a3a2a563c9: Bug 1524214 - Grab caching capturing content with local variable (for beta, release and esr60). r=smaug a=abillings
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 04 Feb 2019 11:58:53 +0100 - rev 512811
Push 10608 by archaeopteryx@coole-files.de at Mon, 04 Feb 2019 11:05:11 +0000
Bug 1524214 - Grab caching capturing content with local variable (for beta, release and esr60). r=smaug a=abillings
666a44dfa6eb: Bug 1516514: Clear the hasCachedSavedFrame bit on frames on compartment mismatch. r=jorendorff, a=abillings DEVEDITION_65_0b12_BUILD1 DEVEDITION_65_0b12_RELEASE FENNEC_65_0b12_BUILD1 FENNEC_65_0b12_RELEASE FIREFOX_65_0b12_BUILD1 FIREFOX_65_0b12_RELEASE
Jim Blandy <jimb@mozilla.com> - Thu, 17 Jan 2019 21:09:04 +0000 - rev 506770
Push 10538 by ryanvm@gmail.com at Thu, 17 Jan 2019 23:24:27 +0000
Bug 1516514: Clear the hasCachedSavedFrame bit on frames on compartment mismatch. r=jorendorff, a=abillings The code that manages the LiveSavedFrameCache would very much like to assert that, if a frame has its hasCachedSavedFrame bit set, then it actually does have an entry in the LiveSavedFrameCache. However, in the presence of compartment mismatches, this becomes temporarily untrue, and OOMs can make 'temporarily' longer than expected. This patch more aggressively clears frames' hasCachedSavedFrame bits, so that when we do purge the cache for a compartment mismatch, all frames get their bits cleared before we start repopulating the cache. Differential Revision: https://phabricator.services.mozilla.com/D16661
8d48fc5df525: Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop, a=abillings
Paul Adenot <paul@paul.cx> - Mon, 14 Jan 2019 15:09:34 +0000 - rev 506715
Push 10526 by ryanvm@gmail.com at Tue, 15 Jan 2019 21:05:27 +0000
Bug 1499426 - Align the lifetime of AudioInputProcessing with the lifetime of MediaEngineWebRTCAudio. r=achronop, a=abillings Differential Revision: https://phabricator.services.mozilla.com/D16201
46828493249a: Bug 1512450 - Clean up reslicing of audio buffers in AudioIPC's server data callback. r=chunmin, a=abillings
Matthew Gregan <kinetik@flim.org> - Tue, 18 Dec 2018 18:07:54 +0200 - rev 506297
Push 10366 by ryanvm@gmail.com at Wed, 19 Dec 2018 14:52:23 +0000
Bug 1512450 - Clean up reslicing of audio buffers in AudioIPC's server data callback. r=chunmin, a=abillings
930054aa138b: Bug 1508102 - Take account of XPCWrappedJS::mJSObjGlobal in cycle collector methods r=mccr8 a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 28 Nov 2018 17:29:19 +0000 - rev 505046
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1508102 - Take account of XPCWrappedJS::mJSObjGlobal in cycle collector methods r=mccr8 a=abillings
0e459cfc0d2a: Bug 1506640 - Trace wrappers rooters during sweep phase r=pbone a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 15 Nov 2018 11:57:00 +0000 - rev 503016
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1506640 - Trace wrappers rooters during sweep phase r=pbone a=abillings
e721c3e314bd: Bug 1500759 - Root parameter dictionaries in AesTask::Init() r=keeler a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 07 Nov 2018 11:12:49 +0000 - rev 501283
Push 10290 by ffxbld-merge at Mon, 03 Dec 2018 16:23:23 +0000
Bug 1500759 - Root parameter dictionaries in AesTask::Init() r=keeler a=abillings
4d29ca8acec1: Bug 1504816 - Ensure source buffer is kept alive while compiling function r=baku a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 12 Nov 2018 10:42:56 +0000 - rev 498441
Push 10163 by jcoppeard@mozilla.com at Mon, 12 Nov 2018 10:51:41 +0000
Bug 1504816 - Ensure source buffer is kept alive while compiling function r=baku a=abillings
222184270b1b: Bug 1494752. r=jonco, a=abillings DEVEDITION_64_0b8_BUILD1 DEVEDITION_64_0b8_RELEASE FIREFOX_64_0b8_BUILD1 FIREFOX_64_0b8_RELEASE
Jeff Walden <jwalden@mit.edu> - Thu, 11 Oct 2018 13:54:41 -0700 - rev 498408
Push 10141 by ryanvm@gmail.com at Thu, 08 Nov 2018 14:19:56 +0000
Bug 1494752. r=jonco, a=abillings
503d94e63a24: Bug 1496159 - Don't try to load modules from the bytecode cache. r=nbp, a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 05 Oct 2018 11:30:22 -0400 - rev 490202
Push 9945 by ryanvm@gmail.com at Sat, 06 Oct 2018 12:35:23 +0000
Bug 1496159 - Don't try to load modules from the bytecode cache. r=nbp, a=abillings
fb5111a3fc51: Bug 1493347 - Drop DataChannelListener on Destroy(). r=drno, a=abillings
Randell Jesup <rjesup@jesup.org> - Mon, 01 Oct 2018 00:39:12 -0400 - rev 490114
Push 9913 by ryanvm@gmail.com at Mon, 01 Oct 2018 11:11:53 +0000
Bug 1493347 - Drop DataChannelListener on Destroy(). r=drno, a=abillings
0b2b3eb663d9: Bug 1490234 - Make permissions specific for Windows shared memory handle. r=jld, a=abillings
Bob Owen <bobowencode@gmail.com> - Tue, 18 Sep 2018 11:50:18 +0100 - rev 489920
Push 9833 by ryanvm@gmail.com at Wed, 19 Sep 2018 01:04:41 +0000
Bug 1490234 - Make permissions specific for Windows shared memory handle. r=jld, a=abillings
868b50082f4f: Bug 1481844 - Clear expando for objects with an ExpandoAndGeneration before wrapping r=bz a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 03 Sep 2018 10:46:39 +0100 - rev 489591
Push 9740 by archaeopteryx@coole-files.de at Tue, 04 Sep 2018 16:57:14 +0000
Bug 1481844 - Clear expando for objects with an ExpandoAndGeneration before wrapping r=bz a=abillings
ec59471499f1: Bug 1481093 - Also update children of typed object type descriptor objects when compacting r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 13 Aug 2018 13:21:34 +0100 - rev 486344
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1481093 - Also update children of typed object type descriptor objects when compacting r=sfink a=abillings
e72e7f5db9a6: Bug 1472734 - Allow ClearEdgesTracer when GC tracer is required to accomodate GCManagedDeletePolicy during sweeping r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 12 Jul 2018 10:35:36 +0100 - rev 481459
Push 9719 by ffxbld-merge at Fri, 24 Aug 2018 17:49:46 +0000
Bug 1472734 - Allow ClearEdgesTracer when GC tracer is required to accomodate GCManagedDeletePolicy during sweeping r=sfink a=abillings
660d4e503a69: Bug 1480965 - Fix review nit. r=asuth, a=abillings
Blake Kaplan <mrbkap@mozilla.com> - Tue, 21 Aug 2018 13:17:50 -0400 - rev 478550
Push 9709 by ryanvm@gmail.com at Thu, 23 Aug 2018 01:35:54 +0000
Bug 1480965 - Fix review nit. r=asuth, a=abillings
be6250630b54: Bug 1472734 - Allow ClearEdgesTracer when GC tracer is required to accomodate GCManagedDeletePolicy during sweeping r=sfink a=abillings a=lizzard
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 12 Jul 2018 10:35:36 +0100 - rev 477978
Push 9484 by archaeopteryx@coole-files.de at Mon, 16 Jul 2018 16:31:57 +0000
Bug 1472734 - Allow ClearEdgesTracer when GC tracer is required to accomodate GCManagedDeletePolicy during sweeping r=sfink a=abillings a=lizzard
a7826942ef6b: Bug 1203273 - Add more diagnostics for gray buffer marking crashes on OSX r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 29 May 2018 10:28:08 +0100 - rev 474479
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1203273 - Add more diagnostics for gray buffer marking crashes on OSX r=sfink a=abillings
a0414a6c423b: Bug 1436505. r=mats, a=abillings
Matt Woodrow <mwoodrow@mozilla.com> - Mon, 28 May 2018 12:42:54 +1200 - rev 474303
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1436505. r=mats, a=abillings
43ea2b7997e1: Bug 1442722 - discardTransferables is a no-op for DifferentProcess clones, r=jorendorff, a=abillings
Steve Fink <sfink@mozilla.com> - Fri, 06 Apr 2018 15:33:32 -0700 - rev 473479
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1442722 - discardTransferables is a no-op for DifferentProcess clones, r=jorendorff, a=abillings
ea7f34ae33bb: Bug 1457703 - Use function pointers rather than virtual run method for GC parallel tasks r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:09:31 +0100 - rev 471924
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457703 - Use function pointers rather than virtual run method for GC parallel tasks r=sfink a=abillings
9b7cc103ce95: Bug 1457703 - Don't fixup an associated object's shape when updating moved pointers in another object r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:09:27 +0100 - rev 471923
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457703 - Don't fixup an associated object's shape when updating moved pointers in another object r=sfink a=abillings
aebec628c235: Bug 1457703 - Fix count of compacting update tasks started r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:09:23 +0100 - rev 471922
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1457703 - Fix count of compacting update tasks started r=sfink a=abillings
f75ee4da0e5d: Bug 1459568 - Expose gray object on return from shell test function r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:08:52 +0100 - rev 471921
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1459568 - Expose gray object on return from shell test function r=sfink a=abillings
6ae810d395d1: Bug 1452464. r=miko a=abillings
Matt Woodrow <mwoodrow@mozilla.com> - Sat, 21 Apr 2018 16:25:33 +1200 - rev 471913
Push 9374 by jlund@mozilla.com at Mon, 18 Jun 2018 21:43:20 +0000
Bug 1452464. r=miko a=abillings
44883c246d62: Bug 1467852 Align LoadInfo::mServiceWorkerTaintingSynthesized handling with other service worker fields. r=valentin a=abillings
Ben Kelly <ben@wanderview.com> - Sun, 10 Jun 2018 18:44:53 -0700 - rev 471275
Push 9347 by bkelly@mozilla.com at Mon, 11 Jun 2018 01:45:05 +0000
Bug 1467852 Align LoadInfo::mServiceWorkerTaintingSynthesized handling with other service worker fields. r=valentin a=abillings
0c12ddf5d3f7: Bug 1465898 - Remove unused code for managing physical audio devices. r=agaynor, a=abillings
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 04 Jun 2018 22:28:09 +0200 - rev 471230
Push 9337 by ryanvm@gmail.com at Fri, 08 Jun 2018 18:43:57 +0000
Bug 1465898 - Remove unused code for managing physical audio devices. r=agaynor, a=abillings MozReview-Commit-ID: 7NsUfzJCUOB
2516557db4bf: Bug 1464784 - Hold a strong ref to the document in callers of ConvertNodesOrStringsIntoNode. r=smaug, a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 02 Jun 2018 01:26:00 -0400 - rev 471131
Push 9307 by ryanvm@gmail.com at Sun, 03 Jun 2018 00:24:54 +0000
Bug 1464784 - Hold a strong ref to the document in callers of ConvertNodesOrStringsIntoNode. r=smaug, a=abillings
c9632ef7fb17: Bug 1465108 - Use function pointers rather than virtual run method for GC parallel tasks r=sfink a=abillings a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:09:31 +0100 - rev 470982
Push 9284 by jcoppeard@mozilla.com at Wed, 30 May 2018 09:26:08 +0000
Bug 1465108 - Use function pointers rather than virtual run method for GC parallel tasks r=sfink a=abillings a=RyanVM
8adb9f8f8993: Bug 1465108 - Fix count of compacting update tasks started r=sfink a=abillings a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 10 May 2018 10:09:23 +0100 - rev 470981
Push 9284 by jcoppeard@mozilla.com at Wed, 30 May 2018 09:26:08 +0000
Bug 1465108 - Fix count of compacting update tasks started r=sfink a=abillings a=RyanVM
2f803318f71f: Bug 1463494 - Delete the sensor observerlist array in a deferred manner. r=froydnj, r=jchen, a=abillings
Randell Jesup <rjesup@jesup.org> - Fri, 25 May 2018 21:16:28 -0400 - rev 470944
Push 9271 by ryanvm@gmail.com at Sun, 27 May 2018 16:55:08 +0000
Bug 1463494 - Delete the sensor observerlist array in a deferred manner. r=froydnj, r=jchen, a=abillings Clean up sensorlist if Dispatch fails.
9f007f15b9cf: Bug 1425930 - Handle Broadcast()->Notify() calling RemoveObserver(). r=froydnj, a=abillings
Randell Jesup <rjesup@jesup.org> - Mon, 21 May 2018 15:30:35 -0400 - rev 470943
Push 9271 by ryanvm@gmail.com at Sun, 27 May 2018 16:55:08 +0000
Bug 1425930 - Handle Broadcast()->Notify() calling RemoveObserver(). r=froydnj, a=abillings
3b349484f1de: Bug 1459162 - Update dimensions early in ClearTarget. r=lsalzman a=abillings
Jonathan Kew <jkew@mozilla.com> - Thu, 17 May 2018 09:49:58 +0100 - rev 470825
Push 9234 by jkew@mozilla.com at Thu, 17 May 2018 08:54:31 +0000
Bug 1459162 - Update dimensions early in ClearTarget. r=lsalzman a=abillings
453294133297: Bug 1459607 - CallSiteObjects can only contain strings. r=jandem, a=abillings
Tom Schuster <evilpies@gmail.com> - Tue, 08 May 2018 22:42:54 +0200 - rev 470761
Push 9218 by ryanvm@gmail.com at Sun, 13 May 2018 19:56:21 +0000
Bug 1459607 - CallSiteObjects can only contain strings. r=jandem, a=abillings
f3ad04730dd3: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 469150
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
42be71805c42: Bug 1447156; r=bkelly a=abillings
Jan Varga <jan.varga@gmail.com> - Wed, 11 Apr 2018 06:36:04 +0200 - rev 466326
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1447156; r=bkelly a=abillings
54ae81245f46: Bug 1446811 - Support exporting array and object binding patterns r=jorendorff a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Thu, 22 Mar 2018 18:24:32 +0000 - rev 463125
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446811 - Support exporting array and object binding patterns r=jorendorff a=abillings
b1dacff4b374: Bug 1203273 - Add a canary to check gray buffers are valid r=sfink a=abillings
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 20 Mar 2018 10:19:37 +0000 - rev 462496
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1203273 - Add a canary to check gray buffers are valid r=sfink a=abillings
6b4e98424f0d: Bug 1446062: Vorbis fix r=jmspeex a=abillings
Monty Montgomery <monty@xiph.org> - Thu, 15 Mar 2018 18:12:05 -0400 - rev 461838
Push 9165 by asasaki@mozilla.com at Thu, 26 Apr 2018 21:04:54 +0000
Bug 1446062: Vorbis fix r=jmspeex a=abillings