searching for reviewer(VladBaicu)
e4a1c144d595462f87eaa3923e28c6aab66a195b: Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 26 Aug 2019 13:09:09 +0000 - rev 550377
Push 11858 by rmaries@mozilla.com at Thu, 29 Aug 2019 15:29:30 +0000
Bug 1575605 - Crash in [@ java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java)] r=VladBaicu Now performing a sanity check after grabbing the child at position due to the fact that it can be null if the position is out of array bounds (this usually happens when all panels are hidden and we request an orientation change). Differential Revision: https://phabricator.services.mozilla.com/D43236
d374e582afbc0c9b8b7a1916a08440dff94a9049: Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Aug 2019 18:10:55 +0000 - rev 548499
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha Right now, there are a lot of things that race to complete before Gecko creates or first reads the profile. One of those things is extracting system addons (the `assets/features/` directory of the APK) to disk, ready for the Gecko profile code to enumerate them. Bug 1534451 added a non-trivial amount of background computation during `onCreate`. This tickled the existing race conditions such that system addon extraction frequently loses the race, making system addons unreliable. In addition, for reasons unknown, `PostUpdateHandler` did its work during `onStart`. But the Gecko profile was created/first read earlier, in `onCreate`. This widened the race window. This commit pulls the update handler into `onCreate`, which is at least early enough for it to have a chance of winning the race; and it makes the work synchronous, which is the simplest way to ensure that it is actually in place before Gecko startup (and profile creation/first read). Since system addons are our "get out of jail" card in many situations, the cost of extracting earlier seems like a good trade-off. That is, I'm sure the early disk access will appear in profiles, and it may even regress Raptor -- but it's a good trade-off. Differential Revision: https://phabricator.services.mozilla.com/D41687
63e44a1a4a2e4edca5a9670dc8d453c3a6b9935b: Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 13 Aug 2019 14:00:13 +0000 - rev 548236
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu Enabled bidirectional realtime variable updates for production mode. Differential Revision: https://phabricator.services.mozilla.com/D41231
a3d80ef3d9b938722e21ae5745c94d67d4155bed: Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 13 Aug 2019 12:32:49 +0000 - rev 548151
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu Enabled bidirectional realtime variable updates for production mode. Differential Revision: https://phabricator.services.mozilla.com/D41231
9028adf52037ba02413fa24921b75124692ceee9: Bug 1565488 - Wrong panel from welcome screen is highlighted after clearing data;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Tue, 30 Jul 2019 16:22:11 +0000 - rev 547975
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1565488 - Wrong panel from welcome screen is highlighted after clearing data;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D39797
2fab9efb6ec532448b3b87dcb224954018b00e17: Bug 1562622 - Calling getViewTreeObserver again to get new object to test isAlive().;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Wed, 31 Jul 2019 14:35:08 +0000 - rev 546314
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1562622 - Calling getViewTreeObserver again to get new object to test isAlive().;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D39929
3eff9a10cc588a946d52465ae1c3af7f0da4ec5c: Bug 1568521 Tracking protection doorhanger's Enable/Disable states don't work r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 24 Jul 2019 16:00:32 +0000 - rev 544548
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1568521 Tracking protection doorhanger's Enable/Disable states don't work r=VladBaicu Now using lastURI instead of principal and now we are using the right functions in order to test permissions. Differential Revision: https://phabricator.services.mozilla.com/D39190
56410364cab03ba3981240427b2bcde809524700: Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Mon, 15 Jul 2019 09:36:47 +0000 - rev 543265
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu Depends on D34386 Differential Revision: https://phabricator.services.mozilla.com/D34387
835ac3ae20ba6c1f55c4e0bd7adeb133c45e0904: Bug 1480031 - Truncate floating menu labels if they overflow screen width; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 12 Jul 2019 11:30:48 +0000 - rev 543082
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1480031 - Truncate floating menu labels if they overflow screen width; r=VladBaicu There's currently a bug in Android's framework that manifests by placing the floating menu off-screen if a menu label overflows the menu's width. https://issuetracker.google.com/issues/137169336 To overcome this we'll manually check and truncate any menu label that could cause issues based on the floating menu style declared upstream. Differential Revision: https://phabricator.services.mozilla.com/D37684
395584e3f86a3e2d7b6eb623e1c3daffae200705: Bug 1529557 - Mutate share drawable to prevent against it being reused from cache; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 11 Jul 2019 23:15:30 +0300 - rev 542921
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1529557 - Mutate share drawable to prevent against it being reused from cache; r=VladBaicu Summary: The share drawable is used in multiple places in code. Android would cache it and subsequently serve a now dirty version of it with transformations potentially added. By mutating it into a new drawable we ensure we'll always have it clean. Reviewers: VladBaicu Reviewed By: VladBaicu Subscribers: emilio Bug #: 1529557 Differential Revision: https://phabricator.services.mozilla.com/D37734
67f71ec8a8a47eb503283d492523d00a71a2ab09: Bug 1563039 - Fix erroneous base domain highlighting. r=VladBaicu
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 09 Jul 2019 11:43:32 +0000 - rev 542474
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1563039 - Fix erroneous base domain highlighting. r=VladBaicu Domain highlighting needs to find the *last* instance of the base domain within the domain part of the URL. Otherwise, there's a chance we mistakenly highlight (parts of) a subdomain if it matches the base domain, too. Differential Revision: https://phabricator.services.mozilla.com/D37311
554b7ac3b30bddd473c575d6eac90a6483b4bae9: Bug 1529557 - Ensure share icons will have the same size r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 09 Jul 2019 11:41:48 +0000 - rev 542391
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1529557 - Ensure share icons will have the same size r=VladBaicu Used `fitCenter` and`adjustViewBounds` to ensure the images will be scaled to fit their container while keeping their aspect ratio. Increased resolution of some images used in the share menu to maths the others' and also remove some bluriness of the previous' when they are enlarged. They were losslessly optimized with an average of 18% savings. Differential Revision: https://phabricator.services.mozilla.com/D37386
bbe14fc961956ebccf579c867b4f4828176dc2f9: Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 08 Jul 2019 12:15:44 +0000 - rev 542130
Push 11848 by ffxbld-merge at Mon, 26 Aug 2019 19:26:25 +0000
Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu Removed OpenH264 plugin from addons list for users that doesn't have it installed. Differential Revision: https://phabricator.services.mozilla.com/D37237
299be89a866661fc0989f151fe646a8a569170ed: Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu a=RyanVM
Andrei Lazar <andrei.a.lazar@softvision.ro> - Tue, 13 Aug 2019 14:00:13 +0000 - rev 541963
Push 11802 by archaeopteryx@coole-files.de at Fri, 16 Aug 2019 19:36:43 +0000
Bug 1568674 Leanplum startup problem in Fennec 68.0 r=VladBaicu a=RyanVM Enabled bidirectional realtime variable updates for production mode. Differential Revision: https://phabricator.services.mozilla.com/D41231
151bfae582afadf93c61e55e1fd4f980a716756f: Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha, a=RyanVM
Nick Alexander <nalexander@mozilla.com> - Wed, 14 Aug 2019 18:10:55 +0000 - rev 541952
Push 11793 by ryanvm@gmail.com at Thu, 15 Aug 2019 16:39:25 +0000
Bug 1570690 - Synchronously extract system addons before Gecko startup in Fennec. r=VladBaicu,Grisha, a=RyanVM Right now, there are a lot of things that race to complete before Gecko creates or first reads the profile. One of those things is extracting system addons (the `assets/features/` directory of the APK) to disk, ready for the Gecko profile code to enumerate them. Bug 1534451 added a non-trivial amount of background computation during `onCreate`. This tickled the existing race conditions such that system addon extraction frequently loses the race, making system addons unreliable. In addition, for reasons unknown, `PostUpdateHandler` did its work during `onStart`. But the Gecko profile was created/first read earlier, in `onCreate`. This widened the race window. This commit pulls the update handler into `onCreate`, which is at least early enough for it to have a chance of winning the race; and it makes the work synchronous, which is the simplest way to ensure that it is actually in place before Gecko startup (and profile creation/first read). Since system addons are our "get out of jail" card in many situations, the cost of extracting earlier seems like a good trade-off. That is, I'm sure the early disk access will appear in profiles, and it may even regress Raptor -- but it's a good trade-off. Differential Revision: https://phabricator.services.mozilla.com/D41687
6b61417a79440bb7793c5dab1afcd607ba8491fe: Bug 1565488 - Wrong panel from welcome screen is highlighted after clearing data. r=VladBaicu, a=RyanVM
Brad Arant <brad.arant@softvision.com> - Tue, 30 Jul 2019 16:22:11 +0000 - rev 541914
Push 11778 by ryanvm@gmail.com at Wed, 14 Aug 2019 03:07:29 +0000
Bug 1565488 - Wrong panel from welcome screen is highlighted after clearing data. r=VladBaicu, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39797
d8752d92d911198c48670581d82b65d770e5e789: Bug 1562622 - Calling getViewTreeObserver again to get new object to test isAlive(). r=VladBaicu, a=RyanVM
Brad Arant <brad.arant@softvision.com> - Wed, 31 Jul 2019 14:35:08 +0000 - rev 541702
Push 11685 by ryanvm@gmail.com at Fri, 02 Aug 2019 01:59:38 +0000
Bug 1562622 - Calling getViewTreeObserver again to get new object to test isAlive(). r=VladBaicu, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D39929
8d8802147a78b165439eb25dd66c49d26aab40e0: Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu a=RyanVM
Brad Arant <brad.arant@softvision.com> - Mon, 15 Jul 2019 09:36:47 +0000 - rev 541490
Push 11621 by archaeopteryx@coole-files.de at Mon, 22 Jul 2019 20:16:35 +0000
Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu a=RyanVM Depends on D34386 Differential Revision: https://phabricator.services.mozilla.com/D34387
43030692b97baac6e41b94f3a59829209fdd3aaa: Bug 1480031 - Truncate floating menu labels if they overflow screen width; r=VladBaicu a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 12 Jul 2019 14:30:48 +0300 - rev 541479
Push 11620 by rmaries@mozilla.com at Mon, 22 Jul 2019 19:45:05 +0000
Bug 1480031 - Truncate floating menu labels if they overflow screen width; r=VladBaicu a=RyanVM There's currently a bug in Android's framework that manifests by placing the floating menu off-screen if a menu label overflows the menu's width. https://issuetracker.google.com/issues/137169336 To overcome this we'll manually check and truncate any menu label that could cause issues based on the floating menu style declared upstream. Differential Revision: https://phabricator.services.mozilla.com//D37684
345b3f7685faf0fa46b568e34a5d2baf9e92cae0: Bug 1529557 - Mutate share drawable to prevent against it being reused from cache; r=VladBaicu a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 11 Jul 2019 23:15:30 +0300 - rev 541436
Push 11607 by nerli@mozilla.com at Thu, 18 Jul 2019 14:12:34 +0000
Bug 1529557 - Mutate share drawable to prevent against it being reused from cache; r=VladBaicu a=RyanVM Summary: The share drawable is used in multiple places in code. Android would cache it and subsequently serve a now dirty version of it with transformations potentially added. By mutating it into a new drawable we ensure we'll always have it clean. Reviewers: VladBaicu Reviewed By: VladBaicu Subscribers: emilio Bug #: 1529557 Differential Revision: https://phabricator.services.mozilla.com/D37734
18ed4493aa99009f084e2ee606fdc73f6ddffe92: Bug 1529557 - Ensure share icons will have the same size r=VladBaicu a=RyanVM
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 09 Jul 2019 11:41:48 +0000 - rev 541435
Push 11607 by nerli@mozilla.com at Thu, 18 Jul 2019 14:12:34 +0000
Bug 1529557 - Ensure share icons will have the same size r=VladBaicu a=RyanVM Used `fitCenter` and`adjustViewBounds` to ensure the images will be scaled to fit their container while keeping their aspect ratio. Increased resolution of some images used in the share menu to maths the others' and also remove some bluriness of the previous' when they are enlarged. They were losslessly optimized with an average of 18% savings. Differential Revision: https://phabricator.services.mozilla.com/D37386
20015237f3bf35daa3265a18bb8c7a3ac0a2ebd6: Bug 1563039 - Fix erroneous base domain highlighting. r=VladBaicu, a=RyanVM
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 09 Jul 2019 11:43:32 +0000 - rev 541361
Push 11584 by ryanvm@gmail.com at Mon, 15 Jul 2019 17:35:02 +0000
Bug 1563039 - Fix erroneous base domain highlighting. r=VladBaicu, a=RyanVM Domain highlighting needs to find the *last* instance of the base domain within the domain part of the URL. Otherwise, there's a chance we mistakenly highlight (parts of) a subdomain if it matches the base domain, too. Differential Revision: https://phabricator.services.mozilla.com/D37311
67b5cc66a182b7e8e0ab458ccb832e8d1ded0c8d: Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu a=RyanVM
Andrei Lazar <andrei.a.lazar@softvision.ro> - Mon, 08 Jul 2019 17:03:25 +0300 - rev 541349
Push 11580 by archaeopteryx@coole-files.de at Mon, 15 Jul 2019 14:32:23 +0000
Bug 1561844 Remove OpenH264 plugin from about:addons r=VladBaicu a=RyanVM Removed OpenH264 plugin from addons list for users that doesn't have it installed. Differential Revision: https://phabricator.services.mozilla.com/D37237
d9c61c4e5b1dde53a85002aa0ca74afebf608c80: Bug 1562831 - Stop the Crash Service cleanly to prevent it's restart; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Wed, 03 Jul 2019 13:13:10 +0000 - rev 540758
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1562831 - Stop the Crash Service cleanly to prevent it's restart; r=VladBaicu The service would be restarted after System.exit(0) which would show the crash feedback form again to the user. That System.exit(0) was initially used to prevent a silent ANR because of the Service being started from background on Android Oreo+ without a foreground notification. To overcome all this we'll also use a foreground notification on Android Oreo+ but with NotificationManager.IMPORTANCE_LOW to be non-intrusive. Differential Revision: https://phabricator.services.mozilla.com/D36746
b788a1f2f095478c9bd82cc606e803b3bfbaf3e5: Bug 1489458 - Remove extraneous console logging in browser.js.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Fri, 28 Jun 2019 12:32:14 +0000 - rev 540465
Push 11529 by archaeopteryx@coole-files.de at Thu, 04 Jul 2019 15:22:33 +0000
Bug 1489458 - Remove extraneous console logging in browser.js.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D36284
76b7becd27ac4c52e6ce2a4530804cae3def5867: Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Thu, 20 Jun 2019 18:04:11 +0000 - rev 539972
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1268019 - Return default icon for download files that do not have intent for handling.;r=VladBaicu Depends on D34386 Differential Revision: https://phabricator.services.mozilla.com/D34387
53b89d516cbce0085e231c9c981fb0cf3747eef1: Bug 1555051 - Use GeckoJarReader to read the theme image; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 25 Jun 2019 14:54:41 +0000 - rev 539690
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555051 - Use GeckoJarReader to read the theme image; r=VladBaicu If the theme is persisted as an xpi we'll use GeckoJarReader to read get the image from inside the archive otherwise read it directly. Differential Revision: https://phabricator.services.mozilla.com/D35808
cd51e03eae41569182609d970dafaf6eb62b6f2e: Bug 1561245 - Add a null check for the received Intent; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 25 Jun 2019 14:52:48 +0000 - rev 539689
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1561245 - Add a null check for the received Intent; r=VladBaicu According to the documentation - https://developer.android.com/reference/android/app/Service.html "The Intent supplied to Context.startService(Intent) may be null if the service is being restarted after its process has gone away, and it had previously returned anything except START_STICKY_COMPATIBILITY." We will ignore the case when the system restarts our Service as we only expect it to be properly started by us, in the event of a crash. Differential Revision: https://phabricator.services.mozilla.com/D35790
2cada2586c93a5f0e5a0869c7943f86ef4bb2c97: Bug 1556083 - Resolve deadlock by using just one lock, not two; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 24 Jun 2019 17:52:40 +0000 - rev 539646
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556083 - Resolve deadlock by using just one lock, not two; r=VladBaicu Classic deadlock situation possible because getDatabaseHelperForProfile(..) would lock on [PerProfileDatabase] and then try to on [GeckoProfile] while at the same time it would be possible for another thread which already had the [GeckoProfile] lock to call this method and so try to acquire the [PerProfileDatabase] lock. The simplest solution to resolve this and the one I went with is to ensure that one of those threads will not need both locks and it turns out that the getDatabaseHelperForProfile method can easily be refactored to use only the GeckoProfile lock, change which would not significantly increase the block of code synchronized with the same key. Differential Revision: https://phabricator.services.mozilla.com/D35646
1e2272faa004fdacb4cff7db7055e633736c4ae3: Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 21 Jun 2019 12:22:20 +0000 - rev 539453
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557661 java.lang.NullPointerException: at org.mozilla.gecko.home.TabMenuStripLayout.onPageSelected(TabMenuStripLayout.java) r=VladBaicu Fixed an issue where we were trying to set some attributes on a null object due to the fact that the view had not finished rendering. Differential Revision: https://phabricator.services.mozilla.com/D35515
0e1180cd2a89aa974ae7190839631249727cfca4: Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 18:53:44 +0000 - rev 539443
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu Our Restarter Service would have issues on Android Q: It would run on a separate process that allowed it to kill the app's process but when trying to restart the app it would fail because it would've been a background Service and as such it would've been restricted from starting other Android Application components. To make it work on Android Q we would need to migrate it to a foreground service or piggy-back the SYSTEM_ALERT_WINDOW permission given by the user for the Tab Queue functionality. The chosen solution is simpler and not affected by any of those limitations. Depends on D35402 Differential Revision: https://phabricator.services.mozilla.com/D35403
819d3061b8fb3cbc3143ac68e8f521b7e32f362c: Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 21 Jun 2019 06:24:43 +0000 - rev 539442
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu Fix for the following scenario: - "Don't keep activities" checked - Change system language Upon detecting a locale change in BrowserApp's onCreate() we would call finish() and then return before calling super.onCreate(). This patch introdues the call to super.onCreate() before returning and ensures that the app will die cleanly so that upon restarting Gecko can reinit add-ons that touch the UI. Differential Revision: https://phabricator.services.mozilla.com/D35402
cc3c2ca06c275e5936152c364c76092a8db32f6b: Bug 1555950 - Ignore lint error for drawables used for localized Top Sites; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 18:12:01 +0000 - rev 539353
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555950 - Ignore lint error for drawables used for localized Top Sites; r=VladBaicu Depends on D34681 Differential Revision: https://phabricator.services.mozilla.com/D35441
278b037a8049927297ca27e97c564fe3b69156e2: Bug 1555950 - Add/update Top Sites favicons; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 18:03:07 +0000 - rev 539352
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555950 - Add/update Top Sites favicons; r=VladBaicu Updated existing "suggestedsites_*" drawables to better match current websites favicons. Added new "suggestedsites_*" drawables that are to be used by the localized Top Sites. All images are added in density qualified drawable folders which based on my testing need to range between 90x90px for mdpi to 360x360px for xxxhdpi. Depends on D34680 Differential Revision: https://phabricator.services.mozilla.com/D34681
4e9151073a0f672523c084cb78df7a8dabccb075: Bug 1555950 - Locale changing will rebuild suggested sites lookup map; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 18:02:18 +0000 - rev 539351
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1555950 - Locale changing will rebuild suggested sites lookup map; r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D34680
390ec5bd9da78514854ce82c041077d12ddef80a: Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 15:49:47 +0000 - rev 539349
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551614 - Simpler way of restarting our app in a new process; r=VladBaicu Our Restarter Service would have issues on Android Q: It would run on a separate process that allowed it to kill the app's process but when trying to restart the app it would fail because it would've been a background Service and as such it would've been restricted from starting other Android Application components. To make it work on Android Q we would need to migrate it to a foreground service or piggy-back the SYSTEM_ALERT_WINDOW permission given by the user for the Tab Queue functionality. The chosen solution is simpler and not affected by any of those limitations. Depends on D35402 Differential Revision: https://phabricator.services.mozilla.com/D35403
ab1822f92ad7cd1ecf989b46936a8ba014cf00a3: Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 20 Jun 2019 15:41:10 +0000 - rev 539348
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551614 - Call BrowserApp's onCreate() before finish(); r=VladBaicu Fix for the following scenario: - "Don't keep activities" checked - Change system language Upon detecting a locale change in BrowserApp's onCreate() we would call finish() and then return before calling super.onCreate(). This patch introdues the call to super.onCreate() before returning and ensures that the app will die cleanly so that upon restarting Gecko can reinit add-ons that touch the UI. Differential Revision: https://phabricator.services.mozilla.com/D35402
0fc4b64bb62b83af780606f14b50299ff5434626: Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 14 Jun 2019 17:05:33 +0000 - rev 538565
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu With this changes we must now support 3 Onboarding versions. With this changes we must now support 3 Onboarding versions. Latest Onboarding UX will use a new title for the "Sync screen", new subtext, new image and new text for the signin button. This will be presented only if all this new Strings are localized. Refactored the existing OnboardingStringUtil to serve as a central point of getting the right resources to be used and querying the Onboarding UX version the app should offer. Added to SyncPanel the missing logic to hide the space otherwise occupied by the Onboarding screen message, when there is no message. (now behaving the same as the other Onboarding screens.) Applied a lossless compression for the new sync image which resulted in a 26.5% size reduction. Removed the lint suppression initially necessary for when first added the updated Sync Strings which were not used at the moment. Differential Revision: https://phabricator.services.mozilla.com/D35012
cc09b9a55c4825e055b32c2c2e812e555283cb56: Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 14 Jun 2019 12:36:39 +0000 - rev 538523
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu With this changes we must now support 3 Onboarding versions. Latest Onboarding UX will use a new title for the "Sync screen", new subtext, new image and new text for the signin button. This will be presented only if all this new Strings are localized. Refactored the existing OnboardingStringUtil to serve as a central point of getting the right Strings to be used and querying the Onboarding UX version the app should offer. Applied a lossless compression for the new sync image which resulted in a 26.5% size reduction. Removed the lint suppression initially necessary for when first added the updated Sync Strings which were not used at the moment. Differential Revision: https://phabricator.services.mozilla.com/D35012
572c808b302bba6714a7b19f2228dd53a89d48b0: Bug 1268019 - Fix code violation of missing braces on if code block.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Tue, 11 Jun 2019 07:41:38 +0000 - rev 538522
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1268019 - Fix code violation of missing braces on if code block.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D34386
f0a2c42d0ef7c99ecf41afadb1a21258ad0cae57: Bug 1551458 Back button won't go back in history (Pixel 3 XL(Android 9)) r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 12 Jun 2019 10:36:01 +0000 - rev 538177
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1551458 Back button won't go back in history (Pixel 3 XL(Android 9)) r=VladBaicu Created an exception in the key event suppression mechanism for the back button KEYCODE. Differential Revision: https://phabricator.services.mozilla.com/D33950
53931ee8bb199c8daf59ff554c1aee1e1afc3828: Bug 1550291 - Android Q: Use the overlay permission or a foreground notification to start the crash handler; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 10 Jun 2019 15:52:58 +0000 - rev 537733
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1550291 - Android Q: Use the overlay permission or a foreground notification to start the crash handler; r=VladBaicu Android Q doesn't allow starting Activities from background. https://developer.android.com/preview/privacy/background-activity-starts We can either piggy-back the SYSTEM_ALERT_WINDOW permission given by the user for the Tab Queue functionality or use a foreground notification from where users could start `CrashReporterActivity`. Differential Revision: https://phabricator.services.mozilla.com/D33029
745cae0780eee5e4d2fe6211ffa98ef4d18cb33c: Bug 1556382 - Reset error message for "Find in page" after dismiss; r=VladBaicu
Andrei Teslovan <andrei.teslovan@softvision.ro> - Thu, 06 Jun 2019 11:57:23 +0000 - rev 537251
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1556382 - Reset error message for "Find in page" after dismiss; r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D33934
38dc20b6a2731ba55a04650256baf18af35371b9: Bug 1557203 - AndroidQ has final APIs. Update the feature29Plus check; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 06 Jun 2019 11:56:02 +0000 - rev 537246
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1557203 - AndroidQ has final APIs. Update the feature29Plus check; r=VladBaicu With Beta4 AndroidQ now ships with final APIs so the previous check we used, VERSION.CODENAME now returns REL instead of Q. But final APIs means AndroidQ will not share API level 28 with AndroidP anymore so we can finally check for Build.VERSION.SDK_INT. Differential Revision: https://phabricator.services.mozilla.com/D33906
20709a491a1e94ec07b764817f6ebf88238460a7: Bug 1538270 - Removal of extra space at end of message.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Mon, 27 May 2019 19:23:58 +0000 - rev 535652
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1538270 - Removal of extra space at end of message.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D32411
8194de6da1c74fe2d5332409c66f6e684e380e44: Bug 1524868 - StartActivity must be called from Activity context and not Application context.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Fri, 24 May 2019 15:11:23 +0000 - rev 535579
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1524868 - StartActivity must be called from Activity context and not Application context.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D32481
49f7d8f42f5eb06c6c106372965b25fcd122bf51: Bug 1547924 - Ensure Leanplum Onboarding falls back to the new Onboarding UX; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 30 Apr 2019 16:43:46 +0300 - rev 535399
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1547924 - Ensure Leanplum Onboarding falls back to the new Onboarding UX; r=VladBaicu Summary: - Added the `LAST_PRIVACY` case for when the user is already signed into Firefox; - Use the new default onboarding strings and images. If they are localized. Differential Revision: https://phabricator.services.mozilla.com/D29347
58dd65c6aa95426b911013eb10ba2e2f460e1b16: Bug 1511839 - Return the generated file if the camera result has "inline-data" action; r=VladBaicu
Petru Lingurar <petru.lingurar@softvision.ro> - Thu, 23 May 2019 12:17:34 +0000 - rev 534843
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1511839 - Return the generated file if the camera result has "inline-data" action; r=VladBaicu Handle the case when Camera would actually save a new photo but would return just a thumbnail and not the full image https://github.com/aosp-mirror/platform_packages_apps_camera/blob/33c59af04ab44eff0e3806f140d472252300646a/src/com/android/camera/PhotoModule.java#L1345-L1371 Differential Revision: https://phabricator.services.mozilla.com/D32307
423af5a3c7e2ea11d43d93bca16ce52247b866ee: Bug 1552535 Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined r=VladBaicu
Andrei Lazar <andrei.a.lazar@softvision.ro> - Wed, 22 May 2019 13:11:39 +0000 - rev 534605
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1552535 Ci.nsIScriptSecurityManager.NO_APP_ID / UNKNOWN_APP_ID are undefined r=VladBaicu Removed variable that resolved to undefined. Differential Revision: https://phabricator.services.mozilla.com/D32136
81e2959af69065808f368500becaa85f61a9ac1c: Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu
Brad Arant <brad.arant@softvision.com> - Wed, 22 May 2019 09:10:45 +0000 - rev 534539
Push 11522 by ffxbld-merge at Mon, 01 Jul 2019 09:00:55 +0000
Bug 1538270 - Show toast for default file picker when permissions denied.;r=VladBaicu Differential Revision: https://phabricator.services.mozilla.com/D32073