searching for reviewer(RyanVM)
2195f60b96bf0479b09105f7c671da16bd9553cb: Bug 1773067 - Test that getStats on closed peer connection rejects and doesn't hang. r=jesup,jrmuizel a=RyanVM DEVEDITION_102_0b5_BUILD2 DEVEDITION_102_0b5_RELEASE FIREFOX_102_0b5_BUILD2 FIREFOX_102_0b5_RELEASE
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 07 Jun 2022 21:21:14 +0000 - rev 689895
Push 16735 by ryanvm@gmail.com at Tue, 07 Jun 2022 21:29:16 +0000
Bug 1773067 - Test that getStats on closed peer connection rejects and doesn't hang. r=jesup,jrmuizel a=RyanVM Depends on D148562 Differential Revision: https://phabricator.services.mozilla.com/D148563
61d7c7fd8c5488b96fdcf0fd698d632235f600a5: Bug 1773067 - Restore previous behavior of rejecting getStats if invoked on closed peer connection. r=jesup,jrmuizel a=RyanVM
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 07 Jun 2022 21:21:14 +0000 - rev 689894
Push 16735 by ryanvm@gmail.com at Tue, 07 Jun 2022 21:29:16 +0000
Bug 1773067 - Restore previous behavior of rejecting getStats if invoked on closed peer connection. r=jesup,jrmuizel a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D148562
2f42f16a5be80c0a09a1d23a659752de6a5c2973: No Bug, mozilla-beta repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM DEVEDITION_102_0b2_BUILD1 DEVEDITION_102_0b2_RELEASE FIREFOX_102_0b2_BUILD1 FIREFOX_102_0b2_RELEASE
ffxbld <ffxbld@mozilla.com> - Mon, 30 May 2022 12:51:23 +0000 - rev 689827
Push 16700 by ryanvm@gmail.com at Tue, 31 May 2022 19:49:22 +0000
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D147646
c9802e666fdee57f9bf43ca391a1815cfe727588: No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 23 May 2022 11:43:45 +0000 - rev 689190
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D147079
974bc11d251bea2ac2b119ee368ee4f9528c4225: No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Thu, 19 May 2022 11:57:24 +0000 - rev 688901
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146796
e2ba8198b156a1abd575877f75ee7303ecc0092e: No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 16 May 2022 13:40:00 +0000 - rev 688404
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146422
f6dc9b5e231a7e878ca9733299ad74943d913ff2: No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 09 May 2022 13:47:59 +0000 - rev 687358
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145877
7bb9efa58526a297b185bfcb1d64dfa4dee020f9: No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Thu, 05 May 2022 12:58:54 +0000 - rev 686952
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145585
e365299d0059624e22ce49cf7912d2d2a2dcc35e: No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 02 May 2022 12:27:06 +0000 - rev 686446
Push 16690 by ffxbld-merge at Mon, 30 May 2022 11:09:45 +0000
No Bug, mozilla-central repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145224
62b172f7d5f0ea07b5c4d9e9f124b384d69a28a8: Bug 1769807 - Ensure Win32k state initialized before content launch. r=nalexander, a=RyanVM FIREFOX_RELEASE_101_BASE
Chris Martin <cmartin@mozilla.com> - Fri, 20 May 2022 20:55:05 +0000 - rev 686417
Push 16688 by ryanvm@gmail.com at Mon, 23 May 2022 11:48:29 +0000
Bug 1769807 - Ensure Win32k state initialized before content launch. r=nalexander, a=RyanVM Win32k Lockdown state must be initialized on the main thread, but currently a process launcher may be the first thing to read it on the IPC Thread Initializing Win32k Lockdown state also relies on the gfxPlatform being initialized, but that also isn't explicit anywhere. This patch ensures both things are true: Always ensure that Win32k State is initialized before queuing a process launch to the IPC Thread, and always ensure that gfxPlatform is initialized before attempting to read the gfx state. Differential Revision: https://phabricator.services.mozilla.com/D146821
5208d4422e6778297f519364b838bfd8770313c8: No Bug, mozilla-beta repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 23 May 2022 11:04:21 +0000 - rev 686416
Push 16688 by ryanvm@gmail.com at Mon, 23 May 2022 11:48:29 +0000
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D147077
94c0d44227f34ef4e4b68323c7b6a4863e7f1753: Bug 1769771 - Basic constructable stylesheets + devtools tests. r=nchevobbe, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 22:32:29 +0000 - rev 686412
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1769771 - Basic constructable stylesheets + devtools tests. r=nchevobbe, a=RyanVM Just testing that the editor and the new label work as expected since these are the things that I could find broken in my reduced examples. Differential Revision: https://phabricator.services.mozilla.com/D146688
d670faee05c336ecd3dd8cc4af5bfe04ee6544dd: Bug 1769771 - Differentiate inline from constructed stylesheets in rule view. r=nchevobbe, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 22:32:28 +0000 - rev 686411
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1769771 - Differentiate inline from constructed stylesheets in rule view. r=nchevobbe, a=RyanVM
3b52c1e7b46f8171efb84395fba7a0cdb15782a5: Bug 1769771 - Improve DevTools support for constructable stylesheets. r=nchevobbe, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 22:32:28 +0000 - rev 686410
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1769771 - Improve DevTools support for constructable stylesheets. r=nchevobbe, a=RyanVM These should be trivial fixes for the most part, just fixing assumptions for constructable stylesheets which have no owner node. Since Gecko internally also has the concept of "associated document", let's just use that. We don't have the authored text around for these. We could keep it around but I'd kinda prefer we didn't have to just for devtools, since it seems to me we already need to deal with rules not being there (imagine e.g. an empty style element with all the rules inserted via script with insertRule()). So returning the empty string should be reasonable for now... Writing some tests now... Differential Revision: https://phabricator.services.mozilla.com/D146682
330c54f6b54781f1d2f62ce7a535a9bff4fb237e: Bug 1769572 - [devtools] The CONNECT method should no longer be sent on request resend. r=nchevobbe, a=RyanVM
Hubert Boma Manilla <hmanilla@mozilla.com> - Thu, 19 May 2022 18:26:43 +0000 - rev 686409
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1769572 - [devtools] The CONNECT method should no longer be sent on request resend. r=nchevobbe, a=RyanVM The CONNECT method sent on Edit & Resend of certain requests crashes firefox based on https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c2, Necko uses CONNECT in a special way, so lets restrict the devtools from selecting and sending it. The crash happens with both the current and new edit and resend panels, so this patch needs to be tested for both. Use the devtools.netmonitor.features.newEditAndResend and set it to true to enable the new edit and resend panel. Note: The new edit and resend panel is enabled by default in Nightly. See https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c0 for the STR for the current Edit and Resend panel See https://bugzilla.mozilla.org/show_bug.cgi?id=1769572#c7 for the STR for the new Edit and Resend Differential Revision: https://phabricator.services.mozilla.com/D146820
8fc2b876351d43ec158b3e4712fad9784b05f898: Bug 1769762 - Override navigator.plugins for Tiktok. r=twisniewski, a=RyanVM
Ksenia Berezina <kberezina@mozilla.com> - Fri, 20 May 2022 18:37:01 +0000 - rev 686408
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1769762 - Override navigator.plugins for Tiktok. r=twisniewski, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146937
5c7f45fbad67a3002e37b8085659507efc62b4ef: Bug 1770337 - land NSS NSS_3_78_1_RTM UPGRADE_NSS_RELEASE. r=jschanck, a=RyanVM
Dennis Jackson <djackson@mozilla.com> - Fri, 20 May 2022 17:09:58 +0000 - rev 686407
Push 16684 by ryanvm@gmail.com at Fri, 20 May 2022 20:18:23 +0000
Bug 1770337 - land NSS NSS_3_78_1_RTM UPGRADE_NSS_RELEASE. r=jschanck, a=RyanVM 2022-05-20 Dennis Jackson <djackson@mozilla.com> * doc/rst/releases/index.rst, doc/rst/releases/nss_3_78_1.rst: Release notes for NSS 3.78.1 [1892ac0bb68d] [NSS_3_78_1_RTM] <NSS_3_78_BRANCH> 2022-05-16 Dennis Jackson <djackson@mozilla.com> * cmd/smimetools/cmsutil.c, lib/smime/cmsdigest.c: Bug 1767590 - Initialize pointers passed to NSS_CMSDigestContext_FinishMultiple r=#nss-reviewers,kaie As NSS_CMSDigestContext_FinishMultiple may leave its outparam unchanged when it returns SECSuccess, ensure that we set the value to NULL prior to invoking it. If this has happened because data was missing and hence the digest was never updated, the secasn1d parser will notice the missing child and raise a decodeError. [f90a530a6606] <NSS_3_78_BRANCH> 2022-05-19 John M. Schanck <jschanck@mozilla.com> * lib/ckfw/wrap.c: Bug 1766978 - improve error handling after nssCKFWInstance_CreateObjectHandle. r=djackson [1c30ba79a5f8] <NSS_3_78_BRANCH> 2022-05-20 Dennis Jackson <djackson@mozilla.com> * lib/nss/nss.h, lib/softoken/softkver.h, lib/util/nssutil.h: Set version numbers to 3.78.1 final [0d9296f60e29] <NSS_3_78_BRANCH> 2022-04-28 Dennis Jackson <djackson@mozilla.com> * .hgtags: Added tag NSS_3_78_RTM for changeset 30fe50c80e23 [ccf9be30b3b2] <NSS_3_78_BRANCH> Differential Revision: https://phabricator.services.mozilla.com/D146896
0c24d74593fd226eb7b3c81c99d2cbb8fe42d5e1: Bug 1770151 - Constrain size for Wayland on SetPopupPosition if needed. r=stransky, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 17:24:57 +0000 - rev 686405
Push 16682 by ryanvm@gmail.com at Fri, 20 May 2022 16:03:45 +0000
Bug 1770151 - Constrain size for Wayland on SetPopupPosition if needed. r=stransky, a=RyanVM Constraining only the pref size is almost fine. We also need to constrain the anchor size when we're sized to the popup. Differential Revision: https://phabricator.services.mozilla.com/D146809
20dc1c9a679dd097920bd365a404ff4a6f2cde36: Bug 1770126 - Make WindowsLocationProvider::Watch() not try to watch for events if already watching. r=gcp, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 09:28:59 +0000 - rev 686404
Push 16682 by ryanvm@gmail.com at Fri, 20 May 2022 16:03:45 +0000
Bug 1770126 - Make WindowsLocationProvider::Watch() not try to watch for events if already watching. r=gcp, a=RyanVM The second call would fail and thus fall back to MLS, but only null out mLocation (not unregister the existing listener), so Windows would think we're still using the location permission forever. Differential Revision: https://phabricator.services.mozilla.com/D146785
4f74020d04560b6f27c717e8b44a21b39350f2a7: Bug 1770126 - Make WindowsLocationProvider::Startup() deal correctly with already-initialized instances. r=gcp, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 May 2022 09:28:59 +0000 - rev 686403
Push 16682 by ryanvm@gmail.com at Fri, 20 May 2022 16:03:45 +0000
Bug 1770126 - Make WindowsLocationProvider::Startup() deal correctly with already-initialized instances. r=gcp, a=RyanVM We can call Startup() on an already-running instance, and that would cause us to not unregister notifications from a pre-existing ILocation instance, which seems likely to cause things like bug 1766770. Other location providers deal correctly with this. Differential Revision: https://phabricator.services.mozilla.com/D146783
2d407d0eb9a2f5eb68c1067db926093d893d00b4: Bug 1768734 - Make sure JS holders are cleared before a shutdown GC. r=mccr8, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 18 May 2022 09:04:05 +0000 - rev 686392
Push 16674 by ryanvm@gmail.com at Thu, 19 May 2022 14:56:21 +0000
Bug 1768734 - Make sure JS holders are cleared before a shutdown GC. r=mccr8, a=RyanVM Previously this was optimized to trace only gray roots in collecting zones, but there was a bug in that it also skipped clearing roots because this happens before the start of GC when zones are selected for collection. Instead, make sure we only perform this optimziation when marking. Differential Revision: https://phabricator.services.mozilla.com/D146585
b73ecde406d98cd5bca19810fa9763478745c6bb: Bug 1768559: Do something safe in this weird corner case. r=mjf, a=RyanVM
Byron Campen <docfaraday@gmail.com> - Tue, 17 May 2022 00:01:26 +0000 - rev 686391
Push 16674 by ryanvm@gmail.com at Thu, 19 May 2022 14:56:21 +0000
Bug 1768559: Do something safe in this weird corner case. r=mjf, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145979
7562c30debb78502e24792d1255e8ab4d74ff630: Bug 1769869 - Fix nsVideoFrame::ReflowFinished. r=jfkthame, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 18 May 2022 16:33:25 +0000 - rev 686390
Push 16674 by ryanvm@gmail.com at Thu, 19 May 2022 14:56:21 +0000
Bug 1769869 - Fix nsVideoFrame::ReflowFinished. r=jfkthame, a=RyanVM ReflowFinished can happen with scripts allowed, so make sure not to synchronously fire events, as they can fire content microtasks which could destroy the frame. Differential Revision: https://phabricator.services.mozilla.com/D146668
5cca6ebd1edb7bb66ae62f0e0a98ea65e92f9064: No Bug, mozilla-beta repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Thu, 19 May 2022 11:05:57 +0000 - rev 686389
Push 16674 by ryanvm@gmail.com at Thu, 19 May 2022 14:56:21 +0000
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146794
e249c0dc507f77b1637efb6fcf12838add374cac: Bug 1767556 - Don't remove composing state when composition is started from first character. r=agi, a=RyanVM
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Sun, 15 May 2022 07:27:48 +0000 - rev 686388
Push 16673 by ryanvm@gmail.com at Thu, 19 May 2022 02:37:04 +0000
Bug 1767556 - Don't remove composing state when composition is started from first character. r=agi, a=RyanVM This occurs since newer GBoard's behaviour seems to be changed. When `GeckoEditable` receives text change from Gecko, it is possible to remove composing state if composition is started from first character. If Gecko's text change by IME, we shouldn't reset text state in `onTextChange`. `mCausedOnlyByComposition` means that this change is by IME. Differential Revision: https://phabricator.services.mozilla.com/D146159
22ef84cec753cf9a66485d083654bd4f8f47e938: Bug 1758416 - Don't tranform empty strings into null blobs during migration; r=jstutte, a=RyanVM
Jan Varga <jvarga@mozilla.com> - Wed, 18 May 2022 12:49:26 +0000 - rev 686387
Push 16673 by ryanvm@gmail.com at Thu, 19 May 2022 02:37:04 +0000
Bug 1758416 - Don't tranform empty strings into null blobs during migration; r=jstutte, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146697
0d0ca1ab39bf77e8a435d50e2d023ef3e8fc7f80: Bug 1769410 - Use computed offset to read float register contents in MachineState::read. r=iain, a=RyanVM
Jan de Mooij <jdemooij@mozilla.com> - Tue, 17 May 2022 09:18:16 +0000 - rev 686377
Push 16665 by ryanvm@gmail.com at Tue, 17 May 2022 16:27:42 +0000
Bug 1769410 - Use computed offset to read float register contents in MachineState::read. r=iain, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146424
d80f76406016feb26a1314a9779d474dcb18e072: Bug 1768475 - [devtools] WalkerActor watchRootNode should not check isDocumentReady. r=nchevobbe, a=RyanVM
Julian Descottes <jdescottes@mozilla.com> - Tue, 17 May 2022 06:04:47 +0000 - rev 686375
Push 16665 by ryanvm@gmail.com at Tue, 17 May 2022 16:27:42 +0000
Bug 1768475 - [devtools] WalkerActor watchRootNode should not check isDocumentReady. r=nchevobbe, a=RyanVM If the walker actor was initialized, we assume the document is ready enough and a root node can be returned if available. A new test was added for a slow loading document. Differential Revision: https://phabricator.services.mozilla.com/D146464
3e9db832b8f56e2d53df86cbfe03399da515055a: Bug 1769071 - Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm. r=bvandersloot, a=RyanVM
Tim Huang <tihuang@mozilla.com> - Fri, 13 May 2022 14:53:34 +0000 - rev 686374
Push 16664 by ryanvm@gmail.com at Tue, 17 May 2022 15:21:30 +0000
Bug 1769071 - Remove the clean up code for the search param prefs in the migration code in the BrowserGlue.jsm. r=bvandersloot, a=RyanVM The clean up code for the search param prefs is not necessary anymore. This patch remove the code but doesn't touch the UI Version number so that we won't mess up with the migration steps in the future. Differential Revision: https://phabricator.services.mozilla.com/D146284
684c3ff766d439404905bc34b633264877c65744: Bug 1768232 - Use a flag to indicate fixed elements rather than checking the elements pointer. r=jandem, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 10 May 2022 15:10:50 +0000 - rev 686372
Push 16664 by ryanvm@gmail.com at Tue, 17 May 2022 15:21:30 +0000
Bug 1768232 - Use a flag to indicate fixed elements rather than checking the elements pointer. r=jandem, a=RyanVM This adds the ObjectElements::FIXED flag to indicate fixed elements and doesn't rely on the elements pointer. Differential Revision: https://phabricator.services.mozilla.com/D145960
b4f8b435c6792a8554ed83f8022afd04e818098d: Bug 1767434 - Make updateDetailsPane always retrieve treeIndex. r=mak, a=RyanVM
James Teow <jteow@mozilla.com> - Mon, 16 May 2022 14:21:59 +0000 - rev 686370
Push 16663 by ryanvm@gmail.com at Tue, 17 May 2022 13:30:38 +0000
Bug 1767434 - Make updateDetailsPane always retrieve treeIndex. r=mak, a=RyanVM The problem with my previous solution for bug 1471546 was that bookmarkIndex is not updated when a user sorts the list of bookmarks. So my solution is to always use the treeIndex since its more reliable. I've also added two tests: the first checks if the row the visible after clicking a bookmark that's close to the bottom of the viewable area, and the second does the same after re-sorting the list. Differential Revision: https://phabricator.services.mozilla.com/D145509
6107881b08b1f0ab6bb79066bb2bc1959a3f87ca: Bug 1766909 - Wrap ObservableArray proxy on getter, rather than throwing. r=peterv, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 May 2022 07:36:03 +0000 - rev 686369
Push 16663 by ryanvm@gmail.com at Tue, 17 May 2022 13:30:38 +0000
Bug 1766909 - Wrap ObservableArray proxy on getter, rather than throwing. r=peterv, a=RyanVM This will still prevent them from accessing stuff (.length will be undefined, etc), but seems better than unexpectedly throwing. This fixes the issue at hand at least. With this patch, we reject length accesses here: https://searchfox.org/mozilla-central/rev/86c98c486f03b598d0f80356b69163fd400ec8aa/js/xpconnect/wrappers/XrayWrapper.cpp#229-233 Your call on whether this patch is enough as-is, or more work is needed. Also your call on whether if more work is needed that needs to happen on this bug or somewhere else. I'm not sure what we'd need to do to support this more "properly", presumably we'd need to add special XRay support to ObservableArrayProxyHandler or so? Pointers (or patches of course ;)) welcome. Also unsure about the setter situation, I _think_ it's fine not to throw given the code I read, but please sanity-check. Differential Revision: https://phabricator.services.mozilla.com/D145045
3b1a54e5108b8bbed3a532d54c741a3f553043b2: Bug 1766656 - Take account of dynamic elements when swapping object. r=jandem, a=RyanVM
Jon Coppeard <jcoppeard@mozilla.com> - Wed, 11 May 2022 11:06:08 +0000 - rev 686368
Push 16663 by ryanvm@gmail.com at Tue, 17 May 2022 13:30:38 +0000
Bug 1766656 - Take account of dynamic elements when swapping object. r=jandem, a=RyanVM We need to copy nursery allocated elements into malloc memory when swapping a nursery obect into the tenured heap, and update memory accounting in a few places. The patch also fixes a bug in calculating how much of the nursery was tenured which came up during testing (we don't know how big proxy objects if they've been swpping into the nursery so assume the minimum size). Differential Revision: https://phabricator.services.mozilla.com/D145722
30568298b02d9c9f1bb3a5f1c9d33ac1e19f595e: Bug 1769309: Block hmpalert.dll v3.8.8.889 and earlier due to crashes with win32k lockdown. r=gcp, a=RyanVM
Bob Owen <bobowencode@gmail.com> - Sat, 14 May 2022 22:48:34 +0000 - rev 686366
Push 16661 by ryanvm@gmail.com at Mon, 16 May 2022 14:00:34 +0000
Bug 1769309: Block hmpalert.dll v3.8.8.889 and earlier due to crashes with win32k lockdown. r=gcp, a=RyanVM The version from a fresh install from Sophos website is 3.8.19.923. Only blocking in child processes. Differential Revision: https://phabricator.services.mozilla.com/D146382
e2df93963a7e11693373c45719f0c2323ca0c5a3: Bug 1765907 - PBM experiment message should override default promo message. r=mviar, a=RyanVM
Punam Dahiya <pdahiya@mozilla.com> - Thu, 12 May 2022 18:24:06 +0000 - rev 686365
Push 16661 by ryanvm@gmail.com at Mon, 16 May 2022 14:00:34 +0000
Bug 1765907 - PBM experiment message should override default promo message. r=mviar, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D144871
2a24d890efafd7e05606b3b0c3460e31e3363493: No Bug, mozilla-beta repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM
ffxbld <ffxbld@mozilla.com> - Mon, 16 May 2022 11:07:11 +0000 - rev 686364
Push 16661 by ryanvm@gmail.com at Mon, 16 May 2022 14:00:34 +0000
No Bug, mozilla-beta repo-update HSTS HPKP remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146421
8a3dffe2c8c3237c1341df884b69a2fcb1805f38: Bug 1766342 - Compute the process creation timestamp lazily. r=glandium, a=RyanVM
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 13 May 2022 09:27:58 +0000 - rev 686356
Push 16654 by ryanvm@gmail.com at Fri, 13 May 2022 20:20:34 +0000
Bug 1766342 - Compute the process creation timestamp lazily. r=glandium, a=RyanVM This reverts bug 1751041 and adds a separate function to take the first timestamp that was taken by a process. The latter is then used when creating JS objects to avoid hazards warnings about allocating memory when an object is not yet rooted. Differential Revision: https://phabricator.services.mozilla.com/D144829
5446f8872e3de6e679ff369672257596792e118b: Bug 1730434 - Limit length of allowCredentials set. r=dveditz, a=RyanVM
R. Martinho Fernandes <bugs@rmf.io> - Thu, 12 May 2022 15:21:31 +0000 - rev 686355
Push 16654 by ryanvm@gmail.com at Fri, 13 May 2022 20:20:34 +0000
Bug 1730434 - Limit length of allowCredentials set. r=dveditz, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145228
245e84df3268a6ce6eb93c192d1286dda92eafc7: Bug 1767200 - Fix Delete File on history downloads. r=Gijs, a=RyanVM
Shane Hughes <shmediaproductions@gmail.com> - Tue, 10 May 2022 20:46:42 +0000 - rev 686354
Push 16654 by ryanvm@gmail.com at Fri, 13 May 2022 20:20:34 +0000
Bug 1767200 - Fix Delete File on history downloads. r=Gijs, a=RyanVM My previous patch for bug 1755570 contained an oversight that caused problems when deleting history downloads' target files. This patch just adds a minimal data removal method to the history download prototype, so the DownloadElementShell methods can execute without exceptions. Differential Revision: https://phabricator.services.mozilla.com/D145279
a3c663fcae8c7e82e8875206c30bfd7c76a1cba3: Bug 1764435 - Fix scrollbar drawing when scrollbars are on the left. r=spohl, a=RyanVM
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 09 May 2022 17:09:24 +0000 - rev 686352
Push 16652 by ryanvm@gmail.com at Fri, 13 May 2022 14:39:19 +0000
Bug 1764435 - Fix scrollbar drawing when scrollbars are on the left. r=spohl, a=RyanVM Our scrollbar drawing code had various RTL checks for the writing mode. These checks were busted since bug 1554571 (where the writing-mode of the scrollbar frames and so on is reset). However, they also wouldn't be correct (we allow to customize scrollbar position via pref). Instead, look at the scrollable frame to really know if the scrollbar is on the right or not. Compute that once in Theme.cpp and pass it around light we were doing for the "is horizontal" bit. Differential Revision: https://phabricator.services.mozilla.com/D145865
2a4276c5c33bd840c80c717f78dbe96c21907d6b: Bug 1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer, a=RyanVM
Jonathan Watt <jwatt@jwatt.org> - Thu, 12 May 2022 20:59:24 +0000 - rev 686351
Push 16652 by ryanvm@gmail.com at Fri, 13 May 2022 14:39:19 +0000
Bug 1769132 - Fix "Print selection only" when pref 'print.prefer_system_dialog' is set to true. r=mstriemer, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146249
a8b97db3614cc38924c4c82dc39f79984f07f891: Bug 1760765 - Clean up OriginKeyStore handling. r=karlt, a=RyanVM
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 09 May 2022 01:33:02 +0000 - rev 686350
Push 16652 by ryanvm@gmail.com at Fri, 13 May 2022 14:39:19 +0000
Bug 1760765 - Clean up OriginKeyStore handling. r=karlt, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D143097
a21f05403031f75c0822d895dd36627a69cb5d5b: Bug 1767999: Re-enable Win32k Lockdown by default. r=gcp, a=RyanVM
Bob Owen <bobowencode@gmail.com> - Thu, 05 May 2022 18:14:03 +0000 - rev 686349
Push 16652 by ryanvm@gmail.com at Fri, 13 May 2022 14:39:19 +0000
Bug 1767999: Re-enable Win32k Lockdown by default. r=gcp, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145618
4808ff29b757e7548501ca0d59f6180f32993ebf: Bug 1767606 - Scrollbars are wrongly displayed inside the "TCP" spotlight at various scaling (e.g., 125%) and locales (e.g., ar). r=mviar, a=RyanVM DEVEDITION_101_0b6_BUILD1 DEVEDITION_101_0b6_RELEASE FIREFOX_101_0b6_BUILD1 FIREFOX_101_0b6_RELEASE
Ed Lee <edilee@mozilla.com> - Wed, 11 May 2022 13:20:28 +0000 - rev 686341
Push 16645 by ryanvm@gmail.com at Thu, 12 May 2022 19:39:16 +0000
Bug 1767606 - Scrollbars are wrongly displayed inside the "TCP" spotlight at various scaling (e.g., 125%) and locales (e.g., ar). r=mviar, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146012
779485a979fe9292eb4d8bf4c788e248fa86c2db: Bug 1768237 - Clean up locking and checks for name/face duplication during CheckForLegacyFamilyNames. r=lsalzman, a=RyanVM
Jonathan Kew <jkew@mozilla.com> - Wed, 11 May 2022 08:47:32 +0000 - rev 686340
Push 16645 by ryanvm@gmail.com at Thu, 12 May 2022 19:39:16 +0000
Bug 1768237 - Clean up locking and checks for name/face duplication during CheckForLegacyFamilyNames. r=lsalzman, a=RyanVM A number of the crash stacks here involve CheckForLegacyFamilyNames. I think what's happening in these cases is that we've found a font family record via the mOtherFamilyNames table (which means it was the result of a legacy-name or localized-name search already). That family is locked in CheckForLegacyFamilyNames, but then if we find another version of the name in one of its faces, we may end up finding the same record within AddWithLegacyFamilyName and trying to lock it recursively. Cleaning up the locking in gfxFontFamily (we don't need to hold a write-lock in CheckForLegacyFamilyNames, read-lock is sufficient) and suppressing the use of CheckForLegacyFamilyNames for family records that were created via that codepath in the first place should prevent this happening. Depends on D145970 Differential Revision: https://phabricator.services.mozilla.com/D145971
9b21b4923105d65c503b3c324c6d5f5eb8006fda: Bug 1768237 - Don't take the lock in gfxFontFamily::HasOtherFamilyNames before calling ReadOtherFamilyNames, because it does the locking internally. r=lsalzman, a=RyanVM
Jonathan Kew <jkew@mozilla.com> - Wed, 11 May 2022 08:47:32 +0000 - rev 686339
Push 16645 by ryanvm@gmail.com at Thu, 12 May 2022 19:39:16 +0000
Bug 1768237 - Don't take the lock in gfxFontFamily::HasOtherFamilyNames before calling ReadOtherFamilyNames, because it does the locking internally. r=lsalzman, a=RyanVM This was a trivial error, and accounts for some of the crashes listed. It's wrong for HasOtherFamilyNames to lock the gfxFontFamily record, because it then calls ReadOtherFamilyNames which does locking internally. Other callsites of ReadOtherFamilyNames don't lock before calling it, we shouldn't do so here either. Differential Revision: https://phabricator.services.mozilla.com/D145970
c98f9743cfefdf30895904dea388f030c384ab6d: Bug 1553878 - Check that SessionAccessibility is attached before calling isCacheEnabled. r=agi, a=RyanVM
Eitan Isaacson <eitan@monotonous.org> - Tue, 10 May 2022 22:17:38 +0000 - rev 686338
Push 16645 by ryanvm@gmail.com at Thu, 12 May 2022 19:39:16 +0000
Bug 1553878 - Check that SessionAccessibility is attached before calling isCacheEnabled. r=agi, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145989
eb2524001bfdba125c43900fca9950f46519f4ab: Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan, a=RyanVM
Dão Gottwald <dao@mozilla.com> - Thu, 12 May 2022 09:36:14 +0000 - rev 686337
Push 16645 by ryanvm@gmail.com at Thu, 12 May 2022 19:39:16 +0000
Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D146050
31ad80aaa62e451e524de8d21da43e9a5e3dc50a: Bug 1768251 - Start reducing use of MOZ_KnownLive in PipeTo operations r=smaug,saschanaz a=RyanVM
Matthew Gaudet <mgaudet@mozilla.com> - Wed, 11 May 2022 16:08:09 +0000 - rev 686333
Push 16643 by ryanvm@gmail.com at Thu, 12 May 2022 14:16:02 +0000
Bug 1768251 - Start reducing use of MOZ_KnownLive in PipeTo operations r=smaug,saschanaz a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D145887
569e6cb837e14961e01e147784e8b65f8606e272: Bug 1761275 - Fix WebP crash on OOM. r=aosmond, a=RyanVM
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 11 May 2022 12:38:30 +0000 - rev 686332
Push 16643 by ryanvm@gmail.com at Thu, 12 May 2022 14:16:02 +0000
Bug 1761275 - Fix WebP crash on OOM. r=aosmond, a=RyanVM Backport of upstream commit: https://github.com/webmproject/libwebp/commit/2de4b05a56e4da42d170f4af8b01327a3b4b251b Differential Revision: https://phabricator.services.mozilla.com/D145815